[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #5 from David Cook --- (In reply to David Cook from comment #4) > Actually, I think it was a case of suffering from buffering, and I just > wasn't using a reasonable test load. It's look better now... Except now when I'm trying to write out iso2709 records and I'm not getting anything again... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #4 from David Cook --- Actually, I think it was a case of suffering from buffering, and I just wasn't using a reasonable test load. It's look better now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #3 from David Cook --- Running a simple Mojo app using morbo and still not getting the stream, so I must be doing something wrong in Mojolicious... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #2 from David Cook --- I'm using Mojo::Server::PSGI->to_psgi_app, and I'm not receiving a stream of content in my web client. I decided to bypass Apache, and even when I go to Starman directly on port 5000, I'm still not getting my stream from Mojo. Going to grab some lunch and have another crack at this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #1 from David Cook --- I think that C4::Auth and C4::Templates will need a bit of refactoring to get the AuthN/AuthZ and Template::Toolkit working 100% correctly, but this is very achievable. I have ideas about how to get this done. I'm just going to focus first on streaming output rather than the Koha internals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26792] Create simple is_authenticated and is_authorized methods for AuthN/AuthZ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26792 --- Comment #1 from David Cook --- Of course, is_authenticated should probably also trigger session timeouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26792] New: Create simple is_authenticated and is_authorized methods for AuthN/AuthZ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26792 Bug ID: 26792 Summary: Create simple is_authenticated and is_authorized methods for AuthN/AuthZ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org There should be simple methods for checking if a web user is authenticated and authorized. Basically, you check a cookie value for a session ID, check if that session ID maps to an authentic user account, and then check if that user account has authorizations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #73 from Katrin Fischer --- I am sorry, but I can't get the tests to pass... updatedatabase, dbic, reset_all.. and still: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for Statement "UPDATE `items` SET `datelastborrowed` = ?, `holdingbranch` = ?, `issues` = ?, `onloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0='2020-10-22', 1="Branch4T", 2=1, 3='2020-10-21', 4=990] at /home/vagrant/kohaclone/Koha/Object.pm line 169 # No tests run! t/db_dependent/Koha/Patrons.t 28/41 # Failed test 'No tests run for subtest "get_overdues"' # at t/db_dependent/Koha/Patrons.t line 1454. Broken FK constraint# Looks like your test exited with 2 just after 28. t/db_dependent/Koha/Patrons.t Dubious, test returned 2 (wstat 512, 0x200) Failed 14/41 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 51 tests but ran 0. t/db_dependent/Koha/Patrons.t (Wstat: 512 Tests: 28 Failed: 1) Failed test: 28 Non-zero exit status: 2 Parse errors: Bad plan. You planned 41 tests but ran 28. They pass on the same db on master :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #30 from Katrin Fischer --- Waiting for the final QA on bug 23971. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #58 from Katrin Fischer --- Neither the original patches nor Joubu's alternative(?) apply at the moment. I feel like we got a bit stuck here. Aleisha, could you take a look at comment#50 too when rebasing and maybe Joubu's patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #3 from Lisette Scheer --- Agreed, this would be useful. I know some websites can tell if you are on mobile and display a link or button only if you are. That could be handy since there wouldn't be a real use case for using the barcode on a PC? Also if we could make it so it ups the screen brightness (not sure if possible just in mobile browser) but most people don't seem to keep their phones at high enough brightness to be read by a barcode scanner. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #28 from Katrin Fischer --- Created attachment 112226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112226=edit Bug 14866: (QA follow-up) Add hint to system preferences Adds a hint about the new configuration option to the existing system preference sectoin. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Katrin Fischer changed: What|Removed |Added Attachment #111938|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 112225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112225=edit Bug 14866: Make high holds work with different item types To test: 1) Apply patch, update database, restart services 2) Enable decreaseLoanHighHolds sysprefs if not already active 3) Go to circulation rules and set a value under 'Decrease loan holds (day)' that is DIFFERENT from decreaseLoanHighHoldsDuration 4) Check out an item with holds and confirm that the value from the rule is used instead of the system preference 5) Confirm tests pass before and after the patch t/db_dependent/DecreaseLoanHighHolds.t Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer Signed-off-by: Henry Bolshaw Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8437 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26791 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] New: Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 Bug ID: 26791 Summary: Build Mojolicious controller replacement for export.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org As per my notes on Bug 8437, starting at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437#c33, any Koha .pl script that needs to stream a large response to a client web browser is never going to work, so long as we're using Plack::App::CGIBin to create a PSGI handler. While I tried to create my own streaming version of Plack::App::WrapCGI, I found a third-party module to be buggy, and that writing my own would be prohibitive in terms of time and energy. It's also architectural glue code that we really might not want to maintain long-term. So I've concluded that an alternative would be to write a Mojolicious controller to replace export.pl. While CGI Koha can still use export.pl, when we're using Starman/Plack, we can redirect to the appropriate Mojolicious endpoint. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 David Cook changed: What|Removed |Added Attachment #109632|0 |1 is obsolete|| --- Comment #46 from David Cook --- Created attachment 112224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112224=edit Bug 8437: Exclude export.pl from plack When attempting to download large files from Koha plack can timeout Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1 - Try to export your entire DB from Tools->Export 2 - If big enough, it fails 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4 - Restart all the things 5 - Repeat export, it succeeds Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #45 from David Cook --- (In reply to David Cook from comment #44) > (In reply to Nick Clemens from comment #30) > > Created attachment 109632 [details] [review] [review] > > Bug 8437: Exclude export.pl from plack > > > > When attempting to download large files from Koha plack can timeout > > > > Excluding the script from plack is a simple fix until we have a more > > permanent fix for this > > issue. > > > > To test: > > 1 - Try to export your entire DB from Tools->Export > > 2 - If big enough, it fails > > 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf > > 4 - Restart all the things > > 5 - Repeat export, it succeeds > > My test plan: > 0. Using koha-testing-docker > 1. cp debian/templates/apache-shared-intranet-plack.conf > /etc/koha/apache-shared-intranet-plack.conf > 2. enable "backup_db_via_tools" in /etc/koha/sites/kohadev/koha-conf.xml > 3. echo 'flush_all' | nc -q 1 memcached 11211 > 4. service apache2 restart > 5. koha-plack --restart kohadev > 6. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl > 7. Note "Unfortunately, no backups are available." > > So that's not going to work... but I have another idea. My test plan: 0. Using koha-testing-docker 1. cp debian/templates/apache-shared-intranet-plack.conf /etc/koha/apache-shared-intranet-plack.conf 2. Point koha-testing-docker at a database with a large number of biblios (e.g. 40,000 biblios) 3. echo 'flush_all' | nc -q 1 memcached 11211 4. restart_all 5. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 6. Click "Don't export items" 7. Click "Export bibliographic records" 8. Note after about 5 seconds that a download for koha.mrc starts. Perfect. Cheers, Nick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #44 from David Cook --- (In reply to Nick Clemens from comment #30) > Created attachment 109632 [details] [review] > Bug 8437: Exclude export.pl from plack > > When attempting to download large files from Koha plack can timeout > > Excluding the script from plack is a simple fix until we have a more > permanent fix for this > issue. > > To test: > 1 - Try to export your entire DB from Tools->Export > 2 - If big enough, it fails > 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf > 4 - Restart all the things > 5 - Repeat export, it succeeds My test plan: 0. Using koha-testing-docker 1. cp debian/templates/apache-shared-intranet-plack.conf /etc/koha/apache-shared-intranet-plack.conf 2. enable "backup_db_via_tools" in /etc/koha/sites/kohadev/koha-conf.xml 3. echo 'flush_all' | nc -q 1 memcached 11211 4. service apache2 restart 5. koha-plack --restart kohadev 6. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 7. Note "Unfortunately, no backups are available." So that's not going to work... but I have another idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #60 from Katrin Fischer ---
Hi Nick,
I think there are some small things:
1) We are missing unit tests for the changes to SearchField.pm and
Elasticsearch.pm
2) I believe the removed needs to be added back after the ELSE:
+[% IF search_field.mandatory %]
+
+[% ELSE %]
-
+[% END %]
+
3) Database update
+if( !column_exists( 'search_field', 'mandatory' ) ) {
+$dbh->do( "ALTER TABLE search_field ADD COLUMN mandatory tinyint(1)
NULL DEFAULT NULL" );
+}
Please add AFTER opac to make sure we always end up with the same sequence of
columsn :)
Functionality wise this appears to work ok.
I think we'd need to work out which other fields we deem mandatory as a next
step?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 David Cook changed: What|Removed |Added Attachment #11177|0 |1 is obsolete|| --- Comment #43 from David Cook --- Comment on attachment 11177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11177 Bug 8437: variable scoping for tools/export.pl I think that this one is obsolete at this point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #42 from David Cook --- In any case, I think we do need to solve the immediate problem ASAP, so I'm going to go ahead with Nick's patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26751] Fatal exception if only one repo defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 --- Comment #10 from David Cook --- (In reply to Tomás Cohen Arazi from comment #8) > I'd say we should leave this bug alone, and propose the refactoring in its > own bug, so stable branches can have this feature fixed. Also there might be > other options to explore. I proposed to move things into YAML or JSON, > splitting the Zebra and general config for good. I think using the XML::Simple "forcearray" option may have been a good idea in this case, but this patch works too. But I agree about a new bug about refactoring configuration. I've opened bug 26790. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26790] New: Refactor Koha configuration (koha-conf.xml)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 Bug ID: 26790 Summary: Refactor Koha configuration (koha-conf.xml) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org I propose moving /yazgfs/config out of koha-conf.xml and into koha-conf.yml (or even several different *-conf.yml files). The majority of the /yazgfs child nodes are actually configuration values for zebrasrv (ie Zebra). We should respect /yazgfs as Zebra configuration and leave it alone. I also propose we move from XML to YAML, as it's more human-friendly and it's easier to parse into the data structure that we need. XML::Simple, which is an obsolete module according to its creator, is currently used to parse koha-conf.xml and it's behaviour can be unpredictable. We should ideally eliminate our usage of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26789] New: Need note fields for all sections of circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26789 Bug ID: 26789 Summary: Need note fields for all sections of circulation rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently the circulation rules only allow notes for each line in the first table. Perhaps it would be better to have a single, multiline note field for each library at the top, so admin can put in notes for anything on the page. As is, the current note fields are too small for adequate notes, and you can't add notes for other sections of the page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26747] OverDrive always available titles display 999999 copies available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26747 --- Comment #5 from Katrin Fischer --- I couldn't follow the test plan, but have verified the code looks correct and checked the API documentation: https://developer.overdrive.com/apis/library-availability-new -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26747] OverDrive always available titles display 999999 copies available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26747 Katrin Fischer changed: What|Removed |Added Attachment #11|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 112223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112223=edit Bug 26747: Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 99 copies available 6 - Apply patch 7 - Note they now say 'Always available' Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26788] New: Circulation rule note field too small.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26788 Bug ID: 26788 Summary: Circulation rule note field too small. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The note field does not allow enough room for notes. Should be much bigger and allow for multiline entry, similar to circulation note in patron account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26747] OverDrive always available titles display 999999 copies available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26747 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26747] OverDrive always available titles display 999999 copies available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26747 Katrin Fischer changed: What|Removed |Added Attachment #112197|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 11 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11=edit Bug 26747: Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 99 copies available 6 - Apply patch 7 - Note they now say 'Always available' Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7236] Add "Save as RDF" option to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7236 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26749] Correct dropdown markup in OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26749 Katrin Fischer changed: What|Removed |Added Attachment #112198|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112221=edit Bug 26749: Correct dropdown markup in OPAC cart This patch corrects the markup of the "Download" dropdown menu in the OPAc cart. It was not updated during the upgrade to Bootstrap 4. To test, apply the patch and perform a catalog search in the OPAC. - Add some titles to the cart. - Open the cart and test the "Download" menu button. - The menu should display correctly, and the menu items should work to download the correct files. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26749] Correct dropdown markup in OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26749 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Katrin Fischer changed: What|Removed |Added Keywords|Academy | --- Comment #14 from Katrin Fischer --- E-Mails, cron and unit tests cannot be tested on a sandbox, so removing the Academy keyword. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Katrin Fischer changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Katrin Fischer changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26722] [Omnibus] Use descriptive link texts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722 Katrin Fischer changed: What|Removed |Added Summary|[Omnibus] Don't use "here" |[Omnibus] Use descriptive |and similar as a link text |link texts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26032] Add 'is new' filter in items search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- My problem is that the "is new" is not really a feature at the moment that is really advertised anywhere in standard Koha - I believe having a field to limit on with no idea where to set it will be confusing :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26032] Add 'is new' filter in items search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26032] Add 'is new' filter in items search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #12 from Katrin Fischer --- Hi Fridolin, there is no mapping in MARC21 for the "new_status", so it cannot be edited via the item editor. It also seems that this is not set to any value by default. I am really not sure how this is used normally, it doesn't seem to be well integrated in "default" Koha right now. Can you explain? I'd also love if the div had an id so it would e possible to hide the option for libraries not using this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 --- Comment #4 from Lisette Scheer --- I was doing it before a term rather than after, that is why it didn't work: Jaspers day - no results Jasper's Day - 4 results Jaspers~ day - 172 results. (title that matches at the top.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26032] Add 'is new' filter in items search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26787] getletter does not fallback to default language - transaction receipts can be blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26787 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Can't apply this patch in order to apply and test 8179 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #19 from Katrin Fischer --- :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 --- Comment #18 from Heather --- Unfortunately, it's not working. I followed this test plan exactly: To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Search for a record by entering "specious" in the keyword box and hitting enter 4/Click "import" on a record 5/For any subfield (maybe specifically the text in an 020 field) double click on the text This is where it failed. The exact keyboard shortcut ctrl-c would not copy the highlighted text. I then verified that it was working in my Koha catalog--it is. So I redefined the keyboard shortcut in the sandbox as Hayley mentions to do, to ctrl-e, and tried again, and it still wouldn't copy with the keyboard shortcut ctrl-e. I got the exact same behavior in Firefox and Chrome with my sandbox. (The remapping of the keyboard shortcut to ctrl-e persisted from Firefox to Chrome.) I could get the highlighted term copied with right-clicking (in Windows) & selecting "copy" from that pop-up menu, which did copy with the initial letter of the subfield code as predicted, so that's still working. But copying with shortcut keys didn't work. Other keyboard shortcuts worked, e.g., "ctrl-shift-c" to copy current subfield worked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26782] Circulation conditions: first 2 columns show as sortable, but cannot be sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26786] Allow customization of list email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26786 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 3150 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Katrin Fischer --- *** Bug 26786 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26787] New: getletter does not fallback to default language - transaction receipts can be blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26787 Bug ID: 26787 Summary: getletter does not fallback to default language - transaction receipts can be blank Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org getletter does not fallback to default language, it searches for a language if passed then gives up To recreate 1 - Enable 'TranslateNotices' syspref 2 - Define ACCOUNT_CREDIT notice for print transport in default language 3 - Make sure 'English (en)' notice is not defined 4 - Make a payment on a patrons account 5 - Go to the patrons transactions and click 'Print' on the payment 6 - Is blank? 7 - Copy notice from default to english 8 - Try again, it works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #17 from Owen Leonard --- I think this shouldn't explode if you are not logged in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7236] Add "Save as RDF" option to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7236 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Cannot change owner of list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- I've been talking to a library that wants to create custom lists for patrons -- the patron fills out a readers advisory form and the library prepares a list of recommendations. It'd be great if this would allow the library to create a private list and make the patron the owner. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26786] New: Allow customization of list email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26786 Bug ID: 26786 Summary: Allow customization of list email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The content and formatting of the email with which Koha sends a list is hardcoded in sendshelf. It'd be great to have a way to customize that email to change the wording, change the from address, and pick whether or not to attached MARC files. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26782] Circulation conditions: first 2 columns show as sortable, but cannot be sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 --- Comment #2 from Owen Leonard --- Created attachment 112220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112220=edit Bug 26782: Add new class for indicating default sort without sortability This patch adds to the globally-included CSS a class which can be added to tables when they are configured using DataTables options that set a default sort but don't allow the user to reorder columns. The new class shows a grey rather than blue sorting indicator and sets the cursort to the default pointer rather than the link "hand." To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Administration -> Circulation and fine rules In the table of circulation rules, confirm that the first two columns, "Patron category" and "Item type" have a grey sorting icon in the header cell indicating ascencing sort. Hovering the cursor over these cells should show a default arrow cursor rather than the link cursor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25971] Allow arbitrary database field as runtime parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25971 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26782] Circulation conditions: first 2 columns show as sortable, but cannot be sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 --- Comment #17 from Heather --- Happy to, Katrin! I'll work on signing off on it this afternoon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26782] Circulation conditions: first 2 columns show as sortable, but cannot be sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26782 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26785] JS errors in pos/pay.tt in 20.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Katrin Fischer changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Component|Tools |Fines and fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26785] JS errors in pos/pay.tt in 20.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 --- Comment #1 from Owen Leonard --- I think line 338 is a backporting error and that it doesn't belong: }, items_columns_settings, false); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1 on this, having just run into the same question. By default, the circ wizard is limiting based on homebranch and holdingbranch, but only based on the items table, where items.homebranch and items.holdingbranch are null for things that only exist in deleteditems. If you set those dropdowns to blank and don't limit based on anything else that exists in items rather than statistics, then the wizard will include stats for deleted items. I'd be ok with an immediate quick-fix of just not making this default to limiting based on homebranch and holdingbranch. I'd be even happier about making the wizard look at both items and deleteditems. If we could also get some way to see the SQL used by the wizard, for diagnostic purposes, that'd be amazing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112207|0 |1 is obsolete|| --- Comment #91 from Séverine Queune --- Created attachment 112217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112217=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 8 -v 2 2. should be green Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112210|0 |1 is obsolete|| --- Comment #93 from Séverine Queune --- Created attachment 112219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112219=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112208|0 |1 is obsolete|| --- Comment #92 from Séverine Queune --- Created attachment 112218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112218=edit Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112204|0 |1 is obsolete|| --- Comment #88 from Séverine Queune --- Created attachment 112214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112214=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112205|0 |1 is obsolete|| --- Comment #89 from Séverine Queune --- Created attachment 112215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112215=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112206|0 |1 is obsolete|| --- Comment #90 from Séverine Queune --- Created attachment 112216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112216=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112203|0 |1 is obsolete|| --- Comment #87 from Séverine Queune --- Created attachment 112213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112213=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112202|0 |1 is obsolete|| --- Comment #86 from Séverine Queune --- Created attachment 112212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112212=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112165|0 |1 is obsolete|| --- Comment #85 from Séverine Queune --- Created attachment 112211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112211=edit Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=26779 Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112209|0 |1 is obsolete|| --- Comment #84 from Séverine Queune --- Created attachment 112210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112210=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112172|0 |1 is obsolete|| --- Comment #82 from Séverine Queune --- Created attachment 112208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112208=edit Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112201|0 |1 is obsolete|| --- Comment #83 from Séverine Queune --- Created attachment 112209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112209=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112171|0 |1 is obsolete|| --- Comment #81 from Séverine Queune --- Created attachment 112207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112207=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 8 -v 2 2. should be green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112166|0 |1 is obsolete|| --- Comment #76 from Séverine Queune --- Created attachment 112202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112202=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112170|0 |1 is obsolete|| --- Comment #80 from Séverine Queune --- Created attachment 112206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112206=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112169|0 |1 is obsolete|| --- Comment #79 from Séverine Queune --- Created attachment 112205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112205=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112168|0 |1 is obsolete|| --- Comment #78 from Séverine Queune --- Created attachment 112204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112204=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112167|0 |1 is obsolete|| --- Comment #77 from Séverine Queune --- Created attachment 112203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112203=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26785] New: JS errors in pos/pay.tt in 20.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Bug ID: 26785 Summary: JS errors in pos/pay.tt in 20.05.x Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In 20.05 there is a JS error in pos/pay.tt. This error does not exist in master. TO recreate: 1. enable EnablePointOfSale 2. enable UseCashRegisters 3. Go to /cgi-bin/koha/pos/pay.pl 4. See the console error Not 100% sure but maybe this is fixed in master because of Bug 26234? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #75 from Séverine Queune --- Created attachment 112201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112201=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Martin Renvoize changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Martin Renvoize changed: What|Removed |Added Attachment #112199|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 112200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112200=edit Bug 12656: Allow --reason to be passed to cancel_expired_holds This patch adds the --reason option to cancel_expired_holds which allows the library to optionally set a reason for cancellation when running the cronjob. This will prompt the HOLD_CANCELLED notice to be sent to the patron. To test: 1/ Ensure the unit tests continue to pass after the patch (t/db_dependent/Reserves/CancelExpiredReserves.t) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Martin Renvoize changed: What|Removed |Added Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 --- Comment #12 from Martin Renvoize --- Created attachment 112199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112199=edit Bug 12656: Allow --reason to be passed to cancel_expired_holds This patch adds the --reason option to cancel_expired_holds which allows the library to optionally set a reason for cancellation when running the cronjob. This will prompt the HOLD_CANCELLED notice to be sent to the patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26582 --- Comment #48 from Tomás Cohen Arazi --- Hi, it all looks ok. Things to look at: - Bug 26582 is PQA, should we rebase this one on top of it? I can help (it means moving the tests to the relevant file, etc). This is mainly a question for the RM. - I don't see tests for Koha::EDI related to the added APPROVE_BASKET action. They should be in t/db_dependent/Koha/EDI.t There's a minor rebase issue (tests count). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23971 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #109 from Joonas Kylmälä --- Some things need a bit more work: If no patron email we get error === 1. Add patron without email 2. Go to cgi-bin/koha/opac-messaging.pl and select email checkbox for every messaging setting 3. Observe following error: > Patron has not set email address, cannot use email as message transport at > /usr/share/perl5/Exception/Class/Base.pm line 88 > 1. in Exception::Class::Base::throw at > /usr/share/perl5/Exception/Class/Base.pm line 88 > 2. in Koha::Patron::Message::Preference::_set_message_transport_types at > /kohadevbox/koha/Koha/Patron/Message/Preference.pm line 409 > 3. in Koha::Patron::Message::Preference::message_transport_types at > /kohadevbox/koha/Koha/Patron/Message/Preference.pm line 224 > 4. in Koha::Patron::Message::Preference::set at > /kohadevbox/koha/Koha/Patron/Message/Preference.pm line 247 > 5. in C4::Form::MessagingPreferences::handle_form_action at > /kohadevbox/koha/C4/Form/MessagingPreferences.pm line 110 > 6. in (eval) at /kohadevbox/koha/opac/opac-messaging.pl line 67 After fixing this it should be made sure also that removing email address in a patron which had the messaging preferences removes the messaging preferences (or handles it some proper way). More robust input handling in OPAC needed = In the opac messaging preferences change with the HTML dev console the value of "Days in advance" to be 50 and submit the request, you will then get following error: > days_in_advance has to be a value between 0-30 for Advance_Notice. at > /usr/share/perl5/Exception/Class/Base.pm line 88 Expected outcome: a nicer result is shown to the user about invalid parameters, we should handle all errors in the code. What do the last two commits do === Bug 18595: Disable digest checkbox when forced on: - This one maybe I don't understand because of the first error caused by missing email. Specifically I don't understand in which situation the digest checkbox should be disabled. Bug 18595: Validate days_in_advance - What does this do exactly? I see it change days_in_advance=NULL but what is the reason behind that? QA tool errors == $ koha-qa.pl -v 2 -c 9 FAIL C4/Reserves.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL circ/returns.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). OK forbidden patterns OK git manipulation OK pod OK spelling OK valid FAIL koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling FAIL tt_valid lines 163, 169 OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling FAIL tt_valid lines 131, 133 OK valid_template For the critic qa errors see the details with for example using $ perlcritic circ/returns.pl $ perlcritic C4/Reserves.pm Not quite sure how to fix the template issues. That's all the issues I spotted. The code review I did didn't find any issues and all the test mentioned in the test plan work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26749] Correct dropdown markup in OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26749 Lucas Gass changed: What|Removed |Added Attachment #112029|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 112198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112198=edit Bug 26749: Correct dropdown markup in OPAC cart This patch corrects the markup of the "Download" dropdown menu in the OPAc cart. It was not updated during the upgrade to Bootstrap 4. To test, apply the patch and perform a catalog search in the OPAC. - Add some titles to the cart. - Open the cart and test the "Download" menu button. - The menu should display correctly, and the menu items should work to download the correct files. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26749] Correct dropdown markup in OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26749 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26747] OverDrive always available titles display 999999 copies available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26747 Lucas Gass changed: What|Removed |Added Attachment #112022|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 112197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112197=edit Bug 26747: Show 'Always available' if title always available in overdrive To test: 1 - Have a developer account for overdrive, or library credentials https://developer.overdrive.com/ 2 - Enter info into 'Overdrive' sysprefs and enable overdrive 3 - Search for 'house' in the opac 4 - Click the overdrive link 5 - Note some titles in the collection show 99 copies available 6 - Apply patch 7 - Note they now say 'Always available' Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26747] OverDrive always available titles display 999999 copies available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26747 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- RM Note: We might possibly want a way to *not* transfer info to existing patrons when guaranteeing them ( possibly another syspref, or a checkbox when adding a guarantor ). The feature does leave existing fields untouched. I will leave that decision to the RM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
