[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #43 from David Cook --- See Bug 26854 for a potential fix. While I haven't tried with Plack, we haven't been forking stage-marc-import.pl correctly in a CGI environment either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342 --- Comment #17 from David Cook --- By the way, Bug 26854 will fix the progress bar not updating issue. While I haven't tried it, I bet that it would also allow use of Plack for Stage MARC Import. Can't speak go the table locking as I've never seen that issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26854 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20342 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 --- Comment #6 from David Cook --- Note: You can actually test this with as little as 436 records actually. I exported the koha-testing-docker database and re-imported it, and it demonstrated the change well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Cook changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #3 from David Cook --- Created attachment 112656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112656=edit Bug 26853: Throw a fatal error if import_biblios insert fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | Summary|"Data too long for column" |Data lost due to "Data too |errors during MARC import |long for column" errors ||during MARC import Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #4 from David Cook --- Created attachment 112657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112657=edit Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Cook changed: What|Removed |Added Attachment #112656|0 |1 is obsolete|| --- Comment #5 from David Cook --- Created attachment 112658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112658=edit Bug 26853: Throw a fatal error if import_biblios insert fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 --- Comment #5 from David Cook --- Created attachment 112655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112655=edit Bug 26854: Close STDERR when forking stage-marc-import.pl We need to close STDERR when forking stage-marc-import.pl, or else the CGI session with Apache httpd does not properly finish. This leads to unexpected behaviour across different httpd versions, operating systems, etc. This patch closes the STDERR file handle when forking a child process to do MARC imports, and it re-opens STDERR to a log file in the logdir directory to catch any import errors. Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 3. Upload a MARC file with a large number of records (e.g. 30,000 records) 4. Open F12 dev tools 5. Click on "Network" tab 6. Clear all existing network logs 7. Click "Stage for import" 8. After ~30 seconds, the request to stage-marc-import.pl should return a 200 code 9. Immediately, calls to background-job-progress.pl should start, and the "Job progress" bar should update at a maximum rate of every .5 seconds (or more realistically 1-2 seconds) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26674] Extended patron attributes REST endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26674 --- Comment #1 from Lari Taskula --- Probably duplicate of Bug 23666 but we should have a Bug for accessing borrower_attribute_types via REST API as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26674] Extended patron attributes REST endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26674 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 --- Comment #27 from Lari Taskula --- What options should circulation rules have for onsite-checkout? Option 1: "No"circulation_rules.onsite_checkout => 0 "Yes" circulation_rules.onsite_checkout => 1 or Option 2: "All" circulation_rules.onsite_checkout => undef "No"circulation_rules.onsite_checkout => 0 "Yes" circulation_rules.onsite_checkout => 1 The problem has to do with how we process circulation_rules scopes and the "*" aka undef value. 1. With option 1 it becomes impossible to share rules for normal and on-site checkouts and likely requires a lot of rule duplication. Also, how would we handle cases where the value for onsite-checkout is not known as there is no '*' rule? Just use the "No" option? 2. My reasoning for option 2 was that it would enable sharing of rules between those two checkout types. For example, sharing a fine rule: branch | onsite | ccode | itype | name| value * | * | * | * | fine| 5 * | 1 | * | * | renewalsallowed | 1 * | 0 | * | * | renewalsallowed | 5 But it seems such flexibility is not supported by the current graphical user interface because it just sets all the rules in that row for that scope, even if you don't touch them (to test: simply create a new rule using a new scope and press Save, and you will see all rule columns were added into circulation_rules). So we cannot share the rules unless we do it directly in the database. Not sure how it works in the upcoming GUI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 --- Comment #4 from David Cook --- Note that in the case of openSUSE apache2 2.4.33 with CGI, eventually the zombie process is reaped, and that's when the AJAX request finally completes and the background-job-progress.pl polling starts. I have no idea why the Ubuntu 18.04 apache2 2.4.29 times out while the others do not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 --- Comment #3 from David Cook --- Note the following from https://perldoc.perl.org/functions/fork: "Note that if your forked child inherits system file descriptors like STDIN and STDOUT that are actually connected by a pipe or socket, even if you exit, then the remote server (such as, say, a CGI script or a backgrounded job launched from a remote shell) won't think you're done. You should reopen those to /dev/null if it's any issue." While they only list STDIN and STDOUT, when it comes to CGI all of STDIN, STDOUT, and STDERR of the CGI script are connected to the web server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 --- Comment #2 from David Cook --- Of course, if we close STDERR in the child, we lose the logs. I'll look to see if I can do something clever there... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15032 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26854 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25810] Stage MARC records for import progress meter sticks at 0%
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25810 --- Comment #2 from David Cook --- Fixing bug 26854 should fix this problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25810] Stage MARC records for import progress meter sticks at 0%
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25810 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE CC||dc...@prosentient.com.au Status|NEW |RESOLVED --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 26854 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Cook changed: What|Removed |Added CC||boz...@nd.edu --- Comment #1 from David Cook --- *** Bug 25810 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] New: stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 Bug ID: 26854 Summary: stage-marc-import.pl does not properly fork Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org When stage-marc-import.pl forks, the child process closes STDOUT, but it does not close STDERR, which is also connected to the Apache httpd parent process. This means that the parent stage-marc-import.pl process becomes a zombie process, as Apache httpd (apache2 2.4.25 Debian 9 && apache2 2.4.29 Ubuntu 18.04 && apache2 2.4.33 openSUSE Leap 15.1) does not reap it, as you can see below: kohadev+ 32716 32712 74 02:17 ?00:00:26 [stage-marc-impo] kohadev+ 32725 1 28 02:18 ?00:00:02 /usr/bin/perl /kohadevbox/koha/tools/stage-marc-import.pl The above happens when running CGI-only Koha or Plack-enabled Koha which does not proxy stage-marc-import.pl. Across 3 different Koha instances, I am experiencing different outcomes in the web browser, although ultimately the forked child process does stage the records (unless bug 26853 occurs). -- That said, I have noticed something interesting. On openSUSE with CGI, I'm seeing a 200 in the browser, although the AJAX request does not complete, so the polling of background-job-progress.pl does not happen. On Ubuntu 18.04 with Plack, Apache returns a 502 to the browser. On Debian 9 with Plack (koha-testing-docker), no status is returned but it doesn't timeout. Possibly differences include different Apache httpd behaviour and different Apache configuration. If we fix this issue, I think that we'll find that behaviour across the different instances becomes more consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #2 from David Cook --- Another option would be to truncate the data before trying to insert it into the database. But considering that things like Koha::MetaSearcher use those fields... maybe we should fix them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #1 from David Cook --- One option is to try to match the import_biblios columns with the biblio and biblioitems tables... I notice import_biblios has an index on title, so I don't know if that will truncate the title for the index, or if it will just fail. If people don't clean their import_biblios table, this could also be a massive database update later, which would not be fun... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] New: "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 Bug ID: 26853 Summary: "Data too long for column" errors during MARC import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org I'm noticing "Data too long for column 'title'" and "Data too long for column 'issn'" database errors in the logs. These are preventing import_biblios rows from being added to the system, although import_records rows are still being added. On koha-testing-docker, these errors are being silently ignored, which is not good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26852] Subfield $e missing in X11 definition of MARC 21 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Janusz Kaczmarek changed: What|Removed |Added Status|NEW |Needs Signoff CC||janus...@gmail.com Assignee|koha-b...@lists.koha-commun |janus...@gmail.com |ity.org | --- Comment #1 from Janusz Kaczmarek --- Created attachment 112654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112654=edit Bug 26852 -- subfield $e missing in X11 definition of MARC21 headings Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26852] New: Subfield $e missing in X11 definition of MARC 21 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Bug ID: 26852 Summary: Subfield $e missing in X11 definition of MARC 21 headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: janus...@gmail.com QA Contact: testo...@bugs.koha-community.org According to MARC 21 definition, subfield $e should be controlled by authority records in X11 fields. Cf.: http://www.loc.gov/marc/authority/ad111.html http://www.loc.gov/marc/authority/adx11.html http://www.loc.gov/marc/bibliographic/bdx11.html Currently, $e is missing in X11 field description in C4/Heading/MARC21.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Lari Taskula changed: What|Removed |Added Attachment #112632|0 |1 is obsolete|| --- Comment #26 from Lari Taskula --- Created attachment 112653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112653=edit Bug 26814: (SMART-RULES GUI) Disable hold rules when on-site option selected SMART-RULES GUI tag means that this patch will apply before Bug 15522. To test: 1. Apply patch 2. Go to Circulation and fine rules in staff client 3. Observe the main circulation rules matrix, observe the following columns: Holds allowed (total) Holds allowed (daily) Holds per record (count) On shelf holds allowed OPAC item level holds Article requests 4. Set "On-site checkout" to "No" or "On-site" 5. Observe the columns in step 3, they should now be disabled 6. Set "On-site checkout" to "All" 7. Observe the columns in step 3, they should now be enabled 8. Add a new rule: On-site checkout: "On-site" Current checkouts allowed: 1 and click Save. 9. Find the row you just added and press Edit. 10. Observe the columns in step 3, they should now be disabled 11. Press Edit for any other row where On-site checkout is "All" 12. Observe the columns in step 3, they should now be enabled Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Lari Taskula changed: What|Removed |Added Attachment #112630|0 |1 is obsolete|| --- Comment #24 from Lari Taskula --- Created attachment 112651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112651=edit Bug 26814: (SMART-RULES GUI) Add onsite_checkout into user interface SMART-RULES GUI tag means that this patch will apply before Bug 15522. To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Lari Taskula changed: What|Removed |Added Attachment #112631|0 |1 is obsolete|| --- Comment #25 from Lari Taskula --- Created attachment 112652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112652=edit Bug 26814: (SMART-RULES GUI) Indent and add onsite_checkout to all_rules hash SMART-RULES GUI tag means that this patch will apply before Bug 15522. No other changes in this patch. To test: 1. git diff --word-diff=color --ignore-all-space HEAD~1 -- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt 2. Observe only $osc has been added Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #54 from Arthur Suzuki ---
Hi Alexis,
Sorry for the late reply...
After applying both patches I still get a failed tests:
root@kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 27/50
# Failed test 'AddReturn must have debarred the patron'
# at t/db_dependent/Circulation.t line 89.
# got: ''
# expected: '1'
# AddReturn returned message $VAR1 = {
# 'WasReturned' => 1
# };
# Looks like you failed 1 test of 29.
t/db_dependent/Circulation.t .. 29/50
# Failed test 'AddReturn + suspension_chargeperiod'
# at t/db_dependent/Circulation.t line 2397.
t/db_dependent/Circulation.t .. 48/50 # Looks like you failed 1 test of 50.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/50 subtests
Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 256 Tests: 50 Failed: 1)
Failed test: 29
Non-zero exit status: 1
Files=1, Tests=50, 22 wallclock secs ( 0.07 usr 0.01 sys + 17.66 cusr 1.62
csys = 19.36 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #19 from David Cook --- (In reply to Kyle M Hall from comment #18) > (In reply to Owen Leonard from comment #17) > > I think this shouldn't explode if you are not logged in > > Should it 401? Makes sense to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21059] callback function in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21059 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #12 from Alex Buckley --- Thanks very much for testing Caroline! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851 --- Comment #1 from Nick Clemens --- Created attachment 112650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112650=edit Bug 26851: Don't generate a notice to library if no content To test: 1 - Check out an over due to a patron 2 - Set overdue triggers to a trigger less than number of days overdue 3 - Make sure the patron has no email 4 - Set content of ODUE notice to: [%# Comment will not print %] 5 - perl misc/cronjobs/overdue_notices.pl 6 - Check the message queue 7 - There is a notice sent to the library: "These messages were not sent directly to the patrons." With no messages 8 - Apply patch 9 - Repeat 10 - No new message generated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26851] New: Overdue notices should not send a report to the library if there is no content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851 Bug ID: 26851 Summary: Overdue notices should not send a report to the library if there is no content Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz The script checks if there is a letter when falling back to print, but it shoudl also check for the content of that letter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21059] callback function in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21059 Tomás Cohen Arazi changed: What|Removed |Added Assignee|n...@bywatersolutions.com |agustinmoy...@theke.io CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26850] New: Turning off pick up location does not affect current hold request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26850 Bug ID: 26850 Summary: Turning off pick up location does not affect current hold request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Each year, schools or other libraries that have to close for a season can have their pick up locations turned off. However, this does not affect currently active hold requests that chose that library as a pick up location. I would suggest a feature either in preferences or in the individual library next to the pick up location switch that would, if enabled, suspend that hold when triggered, flag the hold as needing attention, and notify the patron that the hold has been suspended until they choose a new pick up location. This could either be invisible to the staff, and the check-in would then go to the next patron in the queue, or it could alert the staff member at check in and give them the option to trigger the next hold or ignore (I think the first option would be less staff intensive). The patron's hold list could list the item as suspended, and needs attention. Once they choose a new location, it would unsuspend, and they would not loose their place in the queue. Or they could choose to ignore, and wait for the location to open, which would reactivate the hold (based on the needing attention flag), or they could choose to cancel the hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Ivan Dziuba changed:
What|Removed |Added
CC||ivan.dzi...@inlibro.com
--- Comment #67 from Ivan Dziuba ---
Hi all! Why I cann't apply this patch?
I see this error:
Bug 17385 - Add custom export formats for bibliographic records
100670 - Bug 17385: Add custom export XSLT
100671 - Bug 17385: Add tests for CustomXSLTExportList
100672 - Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder
100673 - Bug 17385: (QA follow-up) Add caching
100674 - Bug 17385: QA Critics Fixed and added Missing Filters
100675 - Bug 17385: Added download option in list
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17385: Add custom export XSLT
.git/rebase-apply/patch:179: trailing whitespace.
} else {
.git/rebase-apply/patch:182: trailing whitespace.
$template->param(bib_list => $bib_list);
.git/rebase-apply/patch:526: trailing whitespace.
} else {
.git/rebase-apply/patch:529: trailing whitespace.
$template->param(bib_list => $bib_list);
warning: 4 lines add whitespace errors.
error: insufficient permission for adding an object to repository database
.git/objects
error: Repository lacks necessary blobs to fall back on 3-way merge.
Patch failed at 0001 Bug 17385: Add custom export XSLT
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-17385-Add-custom-export-XSLT-Jg3ZcG.patch
How can I resolve this problem? Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Victor Grousset/tuxayo changed: What|Removed |Added Status|Passed QA |Pushed to oldoldstable Version(s)||19.05.17 released in|| --- Comment #11 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Victor Grousset/tuxayo changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #10 from Victor Grousset/tuxayo --- I works! thanks a lot and sorry for the delay. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #11 from Caroline Cyr La Rose --- Thank Alex! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Caroline Cyr La Rose changed: What|Removed |Added Attachment #112633|0 |1 is obsolete|| --- Comment #10 from Caroline Cyr La Rose --- Created attachment 112649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112649=edit Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26434] Plugin dirs duplicates in @INC with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Julian Maurice changed: What|Removed |Added Blocks||26849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 [Bug 26849] Fix Array::Utils dependency in cpanfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 --- Comment #1 from Julian Maurice --- Created attachment 112648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112648=edit Bug 26849: Fix Array::Utils dependency in cpanfile Since bug 26434, if the module is missing Koha does not start. So it should be marked as required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26849] New: Fix Array::Utils dependency in cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Bug ID: 26849 Summary: Fix Array::Utils dependency in cpanfile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org Depends on: 26434 Since bug 26434, if the module is missing Koha does not start. So it should be marked as required Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 [Bug 26434] Plugin dirs duplicates in @INC with plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26848] Fix Readonly dependency in cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26848] Fix Readonly dependency in cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 --- Comment #1 from Julian Maurice --- Created attachment 112647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112647=edit Bug 26848: Fix Readonly dependency in cpanfile - It is a required module. If it is missing, Koha will not start - Set the minimum version to 2.00. While not strictly required, it's the version that states that "Deprecation of Readonly::XS as a requirement for fast, readonly scalars is complete", it is available in Debian oldoldstable (jessie, 8), and Readonly::XS was not even needed with Perl > 5.8, which allows us to: - Remove dependency on Readonly::XS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26848] New: Fix Readonly dependency in cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Bug ID: 26848 Summary: Fix Readonly dependency in cpanfile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #24 from Agustín Moyano --- Ok, Séverine, just removed all Data::Printer from code. Could you please try again? Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #23 from Agustín Moyano --- Created attachment 112646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112646=edit Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t -- You are receiving
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #22 from Agustín Moyano --- Created attachment 112645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112645=edit Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #21 from Agustín Moyano --- Created attachment 112644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112644=edit Bug 8179: Add syspref to database This patch adds the AcqReceiveMultipleOrderLines syspref by atomicupdate and in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added Attachment #112554|0 |1 is obsolete|| Attachment #112555|0 |1 is obsolete|| Attachment #112556|0 |1 is obsolete|| Attachment #112558|0 |1 is obsolete|| Attachment #112588|0 |1 is obsolete|| --- Comment #20 from Agustín Moyano --- Created attachment 112643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112643=edit Bug 8179: Add tests This patch adds tests in: * t/db_dependent/Koha/Acquisition/Fund.t * t/db_dependent/Koha/Acquisitoin/Order.t * t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26847] New: Make borrower category code accessible in all pages of the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Bug ID: 26847 Summary: Make borrower category code accessible in all pages of the OPAC Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: rickard.lindf...@sh.se QA Contact: testo...@bugs.koha-community.org It would be useful to see which borrower category a user has when logged in. This way, the library could personalize information with javascript, to certain categories. On every page, there's for example: data-borrowernumber and data-branchcode. Maybe here, it would be suitable for a data-borrowercategory? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #19 from Agustín Moyano --- (In reply to Séverine Queune from comment #18) > Hi Agustin, > No "Processing" problem anymore ! > But I now get this Software error trying to receive an order, whenever I use > the current "Receive" link or the new checkbox : > Can't locate Data/Printer.pm in @INC (you may need to install the > Data::Printer module) (@INC contains: /var/repositories/koha > /home/koha/perl5/lib/perl5/x86_64-linux-gnu-thread-multi > /home/koha/perl5/lib/perl5 /etc/perl > /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 > /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 > /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 > /usr/local/lib/site_perl . /home/koha/koha-dev/var/lib/plugins) at > /var/repositories/koha/acqui/orderreceive.pl line 141. > BEGIN failed--compilation aborted at > /var/repositories/koha/acqui/orderreceive.pl line 141. > > No error when I switch back to master. > I stop the test at step 12, but for step 14, could we imagine to ass the > usual options "Check all / Uncheck all" we have on other Koha pages ? > I know it would be useful, especially if we use it combined with filters on > basket for example or author if a collection must be receipted. Sorry about that.. I'll fix that ASAP. Regarding check all / uncheck all I thought about that, but wasn't sure what the expected behaviour should be. Because this tables are paginated on server, it means that we do not have all rows when render. So this check all should check only the rows that are visible, or all rows that matches the filter? Maybe we could do something similar to what GMail does, to have a check all that only selects visible rows, and display a label or a button that says something like "Select all 523 rows". Anyhow, this should be a consistent behaviour for all datatables and deserves it's own bug and discussion. That's the reason why I didn't implement that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #4 from Agustín Moyano --- Created attachment 112642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112642=edit Bug 24359: Remove hold from holds queue when captured This patch removes a hold from holds queue when captured by check in. To test: 1. check out an item from a book with multiple items for patron_1 2. place a biblio level hold for patron_2 3. perl misc/cronjobs/holds/build_holds_queue.pl CHECK => holds queue shows the placed hold 4. check in the item from step 1 and confirm hold for patron_2 SUCCESS => hold for patron_2 is no longer in holds queue 5. prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #3 from Agustín Moyano --- Created attachment 112641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112641=edit Bug 24359: Add test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Agustín Moyano changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26846] New: serial-collections page no longer check the expected and late serials automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26846 Bug ID: 26846 Summary: serial-collections page no longer check the expected and late serials automatically Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: timothy_alexis.v...@ub.lu.se QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com We noticed this when upgrading from 19.05.04 to 20.05.03 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #57 from Arthur Suzuki --- Hi Lisette, I've rebased the last patch which seemed to create some issues while trying to apply the patch. Can you try to apply the patch again after refreshing master? (now working for me). Kind regards, Arthur for BibLibre's Support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Arthur Suzuki changed: What|Removed |Added Attachment #111370|0 |1 is obsolete|| --- Comment #56 from Arthur Suzuki --- Created attachment 112640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112640=edit Bug 8137: (follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lucas Gass changed: What|Removed |Added Attachment #112629|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 112639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112639=edit Bug 26804: Add modal content preview This patch turns the 'News' column into a preview button. That preview button displays a modal with content of that rows news item. To test: 1. Apply patch 2. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and this image set to 1000px. 'https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg; width="1000" />'. 3. Make sure and have some content with a lot of width and some content with a lot of height. 4. Test the Preview content button 5. Make sure you can scroll through long modals and across modals that are wide 6. Try at different screen sizes and with different combonations of News items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26845] New: Refactor get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26845 Bug ID: 26845 Summary: Refactor get_template_and_user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org C4::Auth::get_template_and_user is a terrifyingly large function that does way too many things, and it's a complete mess. Many of the $template->param interactions are just setting system preferences. We shouldn't even need to do that anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26792] Create simple is_authenticated and is_authorized methods for AuthN/AuthZ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26792 David Cook changed: What|Removed |Added Blocks||26791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 [Bug 26791] Build Mojolicious controller replacement for export.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What|Removed |Added Depends on||26792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26792 [Bug 26792] Create simple is_authenticated and is_authorized methods for AuthN/AuthZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26792] Create simple is_authenticated and is_authorized methods for AuthN/AuthZ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26792 --- Comment #2 from David Cook --- I'm making some good progress here. I've created some methods like Koha::Auth->is_authenticated and Koha::Auth->is_authorized, and then implemented those in a Mojolicious application mounted in plack.psgi at 'intranet/staff'. (The Koha::Auth->is_authenticated is used to cover all routes in the Mojo startup() function, while Koha::Auth->is_authorized is implemented in a "helper", which allows it to be easily and cleanly used in Mojo controller actions.) I need to refactor C4::Auth to create a "is_timed_out" function and add that to Koha::Auth->is_authenticated, but otherwise these should be nearly ready. I should probably rename "is_authorized" to "authorize" as it actually authorizes the user. The "is_authenticated" is just a check though. If it fails, the plan is to redirect the user to a login page or internally use a Mojo login controller. I need to put some more thought into that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26112] Errors in marc21_authorities files for uk-UA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #8 from Bohdan --- Created attachment 112638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112638=edit Remove duplicate values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26112] Errors in marc21_authorities files for uk-UA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 --- Comment #7 from Bohdan --- Created attachment 112637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112637=edit Fix frameworks inserts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26844] Log viewer does not indicate which logs are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26844 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26844] Log viewer does not indicate which logs are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26844 --- Comment #1 from Nick Clemens --- Created attachment 112636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112636=edit Bug 26844: Add warning to disabled logs on log viewer To test: 1 - Go to Admin->System preferences->Logs tab 2 - Make sure some logs are disabled 3 - Go to Tools->Log viewer 4 - Note you can select logs that are disabled 5 - Apply patch 6 - Reload page 7 - Note disabled logs have a warning icon and hover text -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26844] Log viewer does not indicate which logs are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26844 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26844] New: Log viewer does not indicate which logs are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26844 Bug ID: 26844 Summary: Log viewer does not indicate which logs are enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It would be nice on the log viewer page if there was feedback about which logs are currently enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #18 from Kyle M Hall --- (In reply to Owen Leonard from comment #17) > I think this shouldn't explode if you are not logged in Should it 401? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #42 from Kyle M Hall --- (In reply to Vihaan Gupta from comment #41) > i am not able to find usekohaplugin in koha version 20.05 in system > perfrences can any one tell me where to i have enable in new koha > version? That system preference was removed by bug 20415 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26843] New: label-manage.pl: Argument "batch_id" isn't numeric in numeric eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26843 Bug ID: 26843 Summary: label-manage.pl: Argument "batch_id" isn't numeric in numeric eq Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: hblanc...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 112635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112635=edit error in export label Hi, When i try to do an label export, "label-edit-batch.pl", gets an error I view the logs and gets the following: [Tue Oct 27 12:03:59.307796 2020] [cgi:error] [pid 5768] [client 172.16.29.2:59813] AH01215: [Tue Oct 27 12:03:59 2020] label-manage.pl: Argument "batch_id" isn't numeric in numeric eq (==) at /usr/share/koha/lib/C4/Creators/Lib.pm line 550.: /usr/share/koha/intranet/cgi-bin/labels/label-manage.pl, referer: https://catalogo-intra.mydomain.edu.co/cgi-bin/koha/labels/label-home.pl any idea? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Vihaan Gupta changed: What|Removed |Added CC||ujjwalguptax...@gmail.com --- Comment #41 from Vihaan Gupta --- i am not able to find usekohaplugin in koha version 20.05 in system perfrences can any one tell me where to i have enable in new koha version? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Replace 'list-invites' parameter with system preference in cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #2 from Alex Buckley --- Hi Katrin, I've done a bit of investigation and found bug 13287 , and wondered if our approach to the --list-invites parameter in the cleanup_database.pl cron job should change? Looking at that bug, I saw instead of replacing the cron parameter with a system preference, they used both: * If both parameter and syspref are set then prioritise the parameter value * If only syspref is set then use syspref value * If only parameter set then use parameter value * If neither syspref nor parameter value is set then don't do anything If we go with this approach, then at least existing installs can to continue to call the cleanup_database.pl cronjob, with the list-invites parameter, without a change of behaviour. What are your thoughts on this? I thought it good to have a discussion about this, before I start writing the unit tests! Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26842] New: SIP should allow bib level hols
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26842 Bug ID: 26842 Summary: SIP should allow bib level hols Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Koha's SIP server was engineered to allow for item level holds down to and including C4::SIP::ILS::add_hold which accepts both an item id ( in the form of a barcode, SIP field AJ ), or a title id ( i.e. biblionumber, SIP field AJ ). add_hold is passed the barcode, *or* the biblionumber if a barcode was not passed in. All code after this point presumes that the value passed was a barcode. This should be corrected so that record level holds can be placed via SIP in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Replace 'list-invites' parameter with system preference in cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #1 from Alex Buckley --- Created attachment 112634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112634=edit Bug 26831: Add a system preference to define the number of days used for purging unaccepted list share invites in cleanup_database.pl The PurgeUnacceptedListShareInvitesOlderThan system preference value is used whenever the cleanup_database.pl cron job is called without the --list-invites parameter. If neither the system preference or the --list-invites parameter has a value then the cronjob errors out. Test plan: 1. Apply patch 2. Update database: sudo koha-shell cd installer/data/mysql ./updatedatabase.pl 3. Confirm the default value of the PurgeUnacceptedListShareInvitesOlderThan system preference is 14 4. Run the cleanup_database.pl script without the --list-invites parameter: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl -v 5. Confirm the following text is included in the output: "Purging unaccepted list share invites older than 14 days." 6. Clear the aforementioned system preference. Run the cleanup_database.pl cron job with the --list-invites parameter defined: ./cleanup_database.pl --list-invites 10 -v 7. Confirm the following text is included in the output: "Purging unaccepted list share invites older than 10 days." 8. Input a value of 20 into the aforementioned system preference. Run the cron job with --list-invites defined: ./cleanup_database.pl --list-invites 10 -v 9. Confirm the following text is included in the output: "Purging unaccepted list share invites older than 10 days." 10. Clear the aforementioned system preference value and run the cron job without the --list-invites parameter: ./cleanup_database.pl -v 11. Confirm the following text is included in the output: "You did not specify any cleanup work for the script to do" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #24 from Alex Buckley --- Hi David, Thanks so much for your testing of this! I'll take a look at why the t/db_dependent/Circulation/issue.t tests are failing after running through the test plan, as I thought I'd fixed that up. Glad to hear that the t and xt unit tests are not failing because of these patches. Thanks again! Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #23 from David Nind --- Hi Alex. I ran the tests again, both before and after applying the patches, and running through the test plan: - prove xt: all pass both before and after patches applied, and after working through the test plan - prove t: the tests that fail are the same that fail BEFORE the patch is applied - prove t/db_dependent/Circulation/issue.t: tests pass after patches applied, tests fail after have worked through the test plan and run tests again * - prove t/db_dependent/Koha/Object.t: all pass both before and after patches applied I'm not sure how the tests that fail before the patches are applied get fixed up, but obviously not caused by the patches in this bug. David * Failed tests for prove t/db_dependent/Circulation/issue.t after patches applied and have walked through the test plan not ok 33 - UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0 # Failed test 'UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0' # at t/db_dependent/Circulation/issue.t line 440. not ok 50 - The reserve should have been correctly cancelled # Failed test 'The reserve should have been correctly cancelled' # at t/db_dependent/Circulation/issue.t line 529. # got: 'Koha::Hold=HASH(0x555f3aa32530)' # expected: undef # Looks like you failed 2 tests of 50. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/50 subtests Test Summary Report --- t/db_dependent/Circulation/issue.t (Wstat: 512 Tests: 50 Failed: 2) Failed tests: 33, 50 Non-zero exit status: 2 Files=1, Tests=50, 6 wallclock secs ( 0.03 usr 0.01 sys + 4.84 cusr 0.38 csys = 5.26 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 from Séverine Queune --- Hi Agustin, No "Processing" problem anymore ! But I now get this Software error trying to receive an order, whenever I use the current "Receive" link or the new checkbox : Can't locate Data/Printer.pm in @INC (you may need to install the Data::Printer module) (@INC contains: /var/repositories/koha /home/koha/perl5/lib/perl5/x86_64-linux-gnu-thread-multi /home/koha/perl5/lib/perl5 /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /home/koha/koha-dev/var/lib/plugins) at /var/repositories/koha/acqui/orderreceive.pl line 141. BEGIN failed--compilation aborted at /var/repositories/koha/acqui/orderreceive.pl line 141. No error when I switch back to master. I stop the test at step 12, but for step 14, could we imagine to ass the usual options "Check all / Uncheck all" we have on other Koha pages ? I know it would be useful, especially if we use it combined with filters on basket for example or author if a collection must be receipted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #111 from Emmi Takkinen --- (In reply to Joonas Kylmälä from comment #109) > Some things need a bit more work: > > If no patron email we get error > === > > 1. Add patron without email > 2. Go to cgi-bin/koha/opac-messaging.pl and select email checkbox for every > messaging setting > 3. Observe following error: > > > Patron has not set email address, cannot use email as message transport at > > /usr/share/perl5/Exception/Class/Base.pm line 88 > > 1. in Exception::Class::Base::throw at > > /usr/share/perl5/Exception/Class/Base.pm line 88 > > 2. in Koha::Patron::Message::Preference::_set_message_transport_types at > > /kohadevbox/koha/Koha/Patron/Message/Preference.pm line 409 > > 3. in Koha::Patron::Message::Preference::message_transport_types at > > /kohadevbox/koha/Koha/Patron/Message/Preference.pm line 224 > > 4. in Koha::Patron::Message::Preference::set at > > /kohadevbox/koha/Koha/Patron/Message/Preference.pm line 247 > > 5. in C4::Form::MessagingPreferences::handle_form_action at > > /kohadevbox/koha/C4/Form/MessagingPreferences.pm line 110 > > 6. in (eval) at /kohadevbox/koha/opac/opac-messaging.pl line 67 > > After fixing this it should be made sure also that removing email address in > a patron which had the messaging preferences removes the messaging > preferences (or handles it some proper way). > Same error occurs in the staff client if we have email as message transport type for patron (I'm guessing that error will also be raised if sms number isn't set but is chosen as message preference). However patron is still saved. I'm not sure if automatically removing message preference is a good approach. Maybe preventing form from sending and error message like 'Patron has email as message transport type but not email. Either provide valid email or change patrons messaging preferences.' is enough. Hmm, or error message next to input field. > More robust input handling in OPAC needed > = > > In the opac messaging preferences change with the HTML dev console the value > of "Days in advance" to be 50 and submit the request, you will then get > following error: > > > days_in_advance has to be a value between 0-30 for Advance_Notice. at > > /usr/share/perl5/Exception/Class/Base.pm line 88 > > Expected outcome: a nicer result is shown to the user about invalid > parameters, we should handle all errors in the code. > Again same occurs in the staff client. All in all we need better error handling with these changes. > What do the last two commits do > === > > Bug 18595: Disable digest checkbox when forced on: > - This one maybe I don't understand because of the first error caused by > missing email. Specifically I don't understand in which situation the digest > checkbox should be disabled. > > > Bug 18595: Validate days_in_advance > - What does this do exactly? I see it change days_in_advance=NULL but what > is the reason behind that? > Lari already commented these. With last one I agree some cleanup might be needed. First one I understand but I think it's worth checking other options... Could we e.g. disable checkbox with jQuery? > QA tool errors > == > > $ koha-qa.pl -v 2 -c 9 > > FAIL C4/Reserves.pm >FAIL critic > # Variables::ProhibitConditionalDeclarations: Got 1 > violation(s). >OK forbidden patterns >OK git manipulation >OK pod >OK pod coverage >OK spelling >OK valid > > FAIL circ/returns.pl >FAIL critic > # Variables::ProhibitConditionalDeclarations: Got 1 > violation(s). >OK forbidden patterns >OK git manipulation >OK pod >OK spelling >OK valid > > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >OK filters >OK forbidden patterns >OK git manipulation >OK js_in_body >OK spelling >FAIL tt_valid > lines 163, 169 >OK valid_template > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >OK filters >OK forbidden patterns >OK git manipulation >OK js_in_body >OK spelling >FAIL tt_valid > lines 131, 133 >OK valid_template > > For the critic qa errors see the details with for example using > > $ perlcritic circ/returns.pl > $ perlcritic C4/Reserves.pm > > Not quite sure how to fix the template issues. > My guess is that if statement isn't allowed to be used inside input tag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Alex Buckley changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #9 from Alex Buckley --- Hi Caroline and Séverine , Thanks both for testing! I've added a space in between the lock icon and the 'Locked' text which you should now see after running the yarn build command. Would you mind retesting now? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #8 from Alex Buckley --- Created attachment 112633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112633=edit Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Alex Buckley changed: What|Removed |Added Attachment #112516|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
