[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 Martin Renvoize changed: What|Removed |Added Attachment #112886|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 112889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112889=edit Bug 26853: Throw a fatal error if import_biblios insert fails Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 Martin Renvoize changed: What|Removed |Added Attachment #112885|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 112888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112888=edit Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||joonas.kylm...@helsinki.fi --- Comment #122 from Joonas Kylmälä --- The attached patch contains git merge conflict resolution hints. Also, if I understand correctly maxreserves is already checked in some other places in some other way, it would be really good idea to have a patch then to convert those calls to just use CanBookBeReserved(). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26895] Template process failed: file error - parse error - patron-title.inc line 37: unexpected token ('‘ %] at /usr/share/koha/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26895 --- Comment #2 from francesc --- But this happens with clean installation. I don't have written this character anywhere. This error is caused with installation. I use catalan language that contains this character. May be the default catalan templates use this character. But this character is common used in this language. So the site would be configured in order to process it. I guess it may be the problem. Any clues abiut the problem? Thank you very much. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #26 from Alex Buckley --- Hi David, I've attached a (hopefully!) fixed up unit tests patch. Would you mind re-testing the unit tests and see if the t/db_dependent/Circulation/issue.t test now passes for you? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #25 from Alex Buckley --- Created attachment 112887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112887=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #112492|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #20 from Alex Buckley --- Thank you Katrin and Owen! On reflection I agree with you that 'Locked' probably shouldn't be displayed in red as it is not an error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25026] RaiseError must be set for the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #3 from David Cook --- Note that Bug 26853 is an example where RaiseError would be really helpful because it would help surface edge cases that otherwise fail with silent errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #13 from David Cook --- (In reply to David Nind from comment #12) > > Everything appears to work now for me so I have signed off. Thanks, David. Much appreciated! I think is a really nasty bug that is easy to miss, especially when RaiseError is turned off. When Bug 25026 is pushed, it will make issues like this more obvious. > I did notice another error in the database - it happened both before and > after the patch was applied, but I don't think this is related to this bug: > > [Tue Nov 03 02:57:55.761624 2020] [cgi:error] [pid 3980] [client 172.18.0.1: > 58304] AH01215: [Tue Nov 3 02:57:55 2020] stage-marc-import.pl: Filehandle > STDOUT reopened as $fh only for input at /usr/share/perl5/DateTime/TimeZone/ > Local/Unix.pm line 146.: /kohadevbox/koha/tools/stage-marc-import.pl, refere > r: http://127.0.0.1:8081/cgi-bin/koha/tools/stage-marc-import.pl That's more of a warning than an error. It's not related to this bug, but I have been thinking of looking into it more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #20 from David Cook --- (In reply to David Cook from comment #17) > Actually, we have a customization that does something like this patch, and > it actually causes the problem to be worse. > > If you set the idx element value to '', the idx select elements don't get > sent, but the empty q input elements do. So you wind up with a mismatched > number of parameters. This isn't true *if* you provide an option in the select list with a value of ''. So adding that option element in the list would help, if we want to use the Javascript in the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > And if people are worried about ugly URLs, then I think they should open a > new bug report to remove unused search boxes in advanced search from the DOM > so they don't get submitted with the HTML form. Alternatively, we could only show 1 search box on the advanced search page, and make people add more search boxes as needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 David Cook changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #18 from David Cook --- (In reply to Jonathan Druart from comment #16) > If we have the change from bug 25548, this issue will get fixed. I agree. Bug 25548 would resolve Bug 7607. And if people are worried about ugly URLs, then I think they should open a new bug report to remove unused search boxes in advanced search from the DOM so they don't get submitted with the HTML form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #26 from David Cook --- I am tempted to move this back to "Passed QA" because it actually resolves the problem from Bug 7607. While it makes for uglier URLs, it is functionally superior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #25 from David Cook --- (In reply to Katrin Fischer from comment #23) > (In reply to Jonathan Druart from comment #22) > > Who is volunteering? > > Hm, just clearning the inputs won't fix the problem of bug 7607 I think? The > problem is, that people leave search fields empty so idx and search terms > don't match up. > > kw - no search term entered > title - some title words > > Turns into: kw search for some title words > > We have found this workaround from the other bug to be working, but I am not > sure if that will fix the ugliness of the URL. With the Apache change, you don't need to do the workaround. The URL is equally as ugly as well. At the moment, it looks like the only way of having a less ugly URL is by removing empty search boxes from the DOM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #24 from David Cook --- (In reply to Nick Clemens from comment #20) > Would it be reasonable to clear empty inputs with javascript before the > submission? On reflection, that won't work the way you think it would work. It would create the problems described in Bug 7607. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Status|BLOCKED |Failed QA --- Comment #17 from David Cook --- Actually, we have a customization that does something like this patch, and it actually causes the problem to be worse. If you set the idx element value to '', the idx select elements don't get sent, but the empty q input elements do. So you wind up with a mismatched number of parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #12 from David Nind --- Thanks David! I had tried to recreate the error first, but I had no luck. The record you provided really helped! I hadn't spotted that a database was required as well. Everything appears to work now for me so I have signed off. I did notice another error in the database - it happened both before and after the patch was applied, but I don't think this is related to this bug: [Tue Nov 03 02:57:55.761624 2020] [cgi:error] [pid 3980] [client 172.18.0.1: 58304] AH01215: [Tue Nov 3 02:57:55 2020] stage-marc-import.pl: Filehandle STDOUT reopened as $fh only for input at /usr/share/perl5/DateTime/TimeZone/ Local/Unix.pm line 146.: /kohadevbox/koha/tools/stage-marc-import.pl, refere r: http://127.0.0.1:8081/cgi-bin/koha/tools/stage-marc-import.pl David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What|Removed |Added Attachment #112658|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 112886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112886=edit Bug 26853: Throw a fatal error if import_biblios insert fails Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What|Removed |Added Attachment #112657|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 112885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112885=edit Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #7 from Andrew Fuerste-Henry --- See blocking bug, 26903. Turns out the behavior I ran into happens on master without this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26903] New: Imported authorities not added to ES indices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Bug ID: 26903 Summary: Imported authorities not added to ES indices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com Blocks: 26543 To recreate: - set your SearchEngine to Elastic - have an authority record - stage and import it - use link from completed import to see authority and confirm it exists in your system - search for authority, confirm you cannot find it Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||26903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 [Bug 26903] Imported authorities not added to ES indices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25026] RaiseError must be set for the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #2 from David Cook --- (In reply to David Cook from comment #1) > Yes! I am 100% in favour of turning on RaiseError for the UI. > > For what it's worth, I don't think that it will be a huge drama. > > When running on openSUSE, we have turned on RaiseError on the staff > interface for many years now, and while there is an occasional fatal > software error, which I try to clean up and upstream, for the most part it's > quite stable. Plus, we could look at moving forward on Bug 26048, so that any errors in the UI are much more user friendly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25026] RaiseError must be set for the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Yes! I am 100% in favour of turning on RaiseError for the UI. For what it's worth, I don't think that it will be a huge drama. When running on openSUSE, we have turned on RaiseError on the staff interface for many years now, and while there is an occasional fatal software error, which I try to clean up and upstream, for the most part it's quite stable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #9 from David Cook --- I've added a record with a long title. Without the patch, when I go to view the import batch (at /cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1), I see that the "Citation" says "null". If I go into the database, I can see 1 record in import_records, but there are 0 records in import_biblios. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #8 from David Cook --- Created attachment 112884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112884=edit Record with long title -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #14 from Owen Leonard --- (In reply to Lucas Gass from comment #13) > modal-wide didn't work for me but modal-lg did. Sorry, that's what I meant! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #13 from Lucas Gass --- Owen, modal-wide didn't work for me but modal-lg did. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #12 from Lucas Gass --- Created attachment 112883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112883=edit Bug 26804: (QA follow-up) add modal-lg class and intent markup correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #93 from Tomás Cohen Arazi --- Created attachment 112882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112882=edit Bug 20212: Controller changes regression tests This patchset did a copy and paste of the objects->search helper inside the controller, to handle a very special case that wasn't worth generalizing: the fact that the biblio object (that this patchset makes embeddable) is actually built from two tables, and we want to filter by fields in both tables. This requires us to translate: - Any filter reference to fields in biblioitems we allow to search on, through an allow list. - For filtering to work, we need to tweak the stashed 'embed' object so the prefetch is done correctly This patchset also adds a new query parameter: only_active. It is used to only request active orders (see the spec for more details). This patch adds tests for: - Filtering by a column in bilbioitems (this implies correctly prefetching the bilbio => biblioitems relation, and translating the filtering parameter. - Using the only_active query parameter to retrieve only active orders To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Verify the tests check for the explained behaviours. => SUCCESS: They do! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook changed: What|Removed |Added Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #7 from David Cook --- I don't think this is needed thanks to https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112814 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #7 from David Cook --- (In reply to David Nind from comment #6) > Hi David. > > Are you able to provide a sample file for import with records that will > trigger this? > > I tried by editing a record and making the title longer, then exporting; but > it still worked. > > Otherwise, I will have another go this evening. > > David Were you testing the patch or trying to reproduce the error? The problem is really difficult to spot, but I'll look at putting together a sample set of data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #7 from Blou --- Not exactly sure, but this occurred in the opening sequences of our testing of 20.05.05 - Default database - No modification of preferences - add a rule to allow all to put on reserve. - add one record with one item using "book" as itemtype - Search for it in the OPAC - click on Hold, select a library, save, boom! So this was through the UI, and I *presume* of normal usage by our librarian who gave me the steps to reproduce. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 --- Comment #4 from Katrin Fischer --- I tried adding a few -, but obviously not in the right spots :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer changed: What|Removed |Added Attachment #112865|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112881=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900
--- Comment #6 from Katrin Fischer ---
Is it possible that the if ($pickup_library) {} is dead code?
The only time we seem to be using the parameter is in a test in
t/db_dependent/Reserves.t.
Or... should we have been using it somewhere?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900
Katrin Fischer changed:
What|Removed |Added
Attachment #112870|0 |1
is obsolete||
--- Comment #5 from Katrin Fischer ---
Created attachment 112880
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112880=edit
Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm
Plain simple:
my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} );
This patch replaces 'Koka' by 'Koha'.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469
Katrin Fischer changed:
What|Removed |Added
Attachment #112862|0 |1
is obsolete||
--- Comment #5 from Katrin Fischer ---
Created attachment 112879
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112879=edit
Bug 25469: Typo: Item does not belongs to your library
This patch makes corrections to two strings in the batch delete template
to correct a typo. Before:
t("Item does not belongs to your library")
...after,
t("Item does not belong to your library")
To test, apply the patch and inspect the template to confirm that the
string is correct.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer changed: What|Removed |Added Attachment #112861|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 112878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112878=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 Katrin Fischer changed: What|Removed |Added Attachment #112867|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112877=edit Bug 26892: Remove warnings from Koha/Patrons.t Test plan: Confirm that the warnings "item-level_itypes set but no itemtype set for item" disappear after applying this patch Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What|Removed |Added Attachment #112797|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 112875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112875=edit Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24012] Display 'Locked' budget in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What|Removed |Added Attachment #112837|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 112876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112876=edit Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What|Removed |Added Attachment #112873|0 |1 is obsolete|| --- Comment #121 from Arthur Suzuki --- Created attachment 112874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112874=edit Bug 11999: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #120 from Arthur Suzuki --- Thanks david :) Patch did no longer apply because one of my other patch actually got into master, hurray! \o/ Re-posted all patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #119 from Arthur Suzuki --- Created attachment 112873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112873=edit Bug 11999: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #118 from Arthur Suzuki --- Created attachment 112872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112872=edit Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What|Removed |Added Attachment #111687|0 |1 is obsolete|| Attachment #111688|0 |1 is obsolete|| Attachment #111689|0 |1 is obsolete|| --- Comment #117 from Arthur Suzuki --- Created attachment 112871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112871=edit Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: -- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900
David Nind changed:
What|Removed |Added
Attachment #112864|0 |1
is obsolete||
--- Comment #4 from David Nind ---
Created attachment 112870
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112870=edit
Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm
Plain simple:
my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} );
This patch replaces 'Koka' by 'Koha'.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148
David Nind changed:
What|Removed |Added
Attachment #112866|0 |1
is obsolete||
--- Comment #2 from David Nind ---
Created attachment 112869
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112869=edit
Bug 26148: OpenLibrary "Preview" link target is unclear to patrons
This patch makes changes to the display of the Open Library "read" links
in the OPAC search results and detail page. The link is now grouped with
other details about the record ("Publisher," "Location(s)," etc. On the
detail page, the "Preview" link will no longer appear under the cover
image.
The label is changed to "Found in Open Library," and the link now opens
the Open Library reader in a new window.
The patch also changes the Open Library button image links so that they
use https and makes it so that the "Found in Open Library" information
is hidden until the availability information has loaded.
To test, apply the patch and enable the OpenLibrarySearch system
preference.
- Perform a search in the OPAC which will return results found in Open
Library, e.g. "poetry" in the sample data.
- Confirm that the "Read now" images from Open Library appear on some
search results.
- View the detail page for one of these titles.
- Confirm that the "Read now" button appears in the same format on the
detail page.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #92 from Tomás Cohen Arazi --- Katrin, I've submitted a follow-up for fixing the problem with remembering searches. As for the regression tests, what I did was embedding the objects->search code in the controller, so I can tweak the handling for biblioitems.* fields in the query, because biblio objects include the biblioitems columns, so a special handling is required until we merge those tables (or not). So my feeling was that the fact that running: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t was passing, was enough. I can try adding tests for filtering on biblioitems.* fields, but the general tests cover the routes already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #91 from Tomás Cohen Arazi --- Created attachment 112868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112868=edit Bug 20212: (QA follow-up) Remember current filter This patch restores the original behaviour: if you jump into receiving an order, and then go back to receiving, you want the page to remember your filters. This feature was overlooked. On fixing it, I wrapped some JS code in a function for reusing it and simplified it a bit as well. To test: 1. Enter a search term in either of the search fields 2. Add a note, receive or do another action => SUCCESS: The search term is kept 3. Apply this patch set 4. Repeat 2 => SUCCESS: The search term is kept Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #3 from Blou --- well, my maths suck. I guess I'm too used to work on 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Andrew Fuerste-Henry --- Failing on step 13. New authorities are created but don't come up in searches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #5 from Andrew Fuerste-Henry --- Updating test plan. Existing step 9 led to an error as one attempted to create items based on a 952 containing an existing itemnumber: To test: 0 - Be using Elasticsearch, apply patches, reindex 1 - Add multiple items to several records in your catalog 2 - Export those records 3 - Update the items on the records in Koha to be 'damaged' 4 - Import the file exported above, matchign on biblionumber and overlaying items 5 - Perform a search to return the imported records 6 - Confirm all items have damaged correctly removed in search results 7 - Import without matching and ignoring items to confirm new records are added 8 - Search to return records and verify they are indexed (shoudl see 2 copies) 9 - Alter exported records to remove itemnumber and barcode 10 - Import the file matching on biblionumber and adding items 11 - Search tp return records, confirm the new items are indexed 12 - Export some authority records 13 - Import them without matching and confirm new records are searchable 14 - Alter the existing records, and match on AuthID, you will need to create a matching rule for this 15 - Import and match and confirm the records are searchable and reflect the change back to original values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26902] Add ability to flag a patron email address as possibly invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26902 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26902] New: Add ability to flag a patron email address as possibly invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26902 Bug ID: 26902 Summary: Add ability to flag a patron email address as possibly invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be beneficial if there was a way to flag email addresses in Koha as possibly invalid. That way, if a library receives a bounce-back for a given email, Koha could flag that email address as questionable. At that point, Koha could show an alert when checking out to that patron so the librarian can confirm the address is correct with the patron. An API endpoint that would accept an email address, find any instance of that email address in patron records, and flag it as potentially invalid would be very useful to integrate automation of converting bounce-back emails into warning flags in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26901] New: Add ability to stop transfer slips to print if TrapHoldsOnOrder is set to Don't Trap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26901 Bug ID: 26901 Summary: Add ability to stop transfer slips to print if TrapHoldsOnOrder is set to Don't Trap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com With the introduction of the new system preference, TrapHoldsOnOrder, if a library sets this to "Don't Trap", they also would probably not want to get an alert to transfer the items. As libraries are continuing to quarantine their books, they are generally keeping them in the one library until the quarantine is over. However, clicking ignore with each transfer / hold slip for this workflow is a bit much. It would be nice to allow for a library to turn this off - as Koha is allowing with this other system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 David Nind changed: What|Removed |Added Attachment #112823|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112867=edit Bug 26892: Remove warnings from Koha/Patrons.t Test plan: Confirm that the warnings "item-level_itypes set but no itemtype set for item" disappear after applying this patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148
--- Comment #1 from Owen Leonard ---
Created attachment 112866
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112866=edit
Bug 26148: OpenLibrary "Preview" link target is unclear to patrons
This patch makes changes to the display of the Open Library "read" links
in the OPAC search results and detail page. The link is now grouped with
other details about the record ("Publisher," "Location(s)," etc. On the
detail page, the "Preview" link will no longer appear under the cover
image.
The label is changed to "Found in Open Library," and the link now opens
the Open Library reader in a new window.
The patch also changes the Open Library button image links so that they
use https and makes it so that the "Found in Open Library" information
is hidden until the availability information has loaded.
To test, apply the patch and enable the OpenLibrarySearch system
preference.
- Perform a search in the OPAC which will return results found in Open
Library, e.g. "poetry" in the sample data.
- Confirm that the "Read now" images from Open Library appear on some
search results.
- View the detail page for one of these titles.
- Confirm that the "Read now" button appears in the same format on the
detail page.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #2 from Blou --- this is also in 20.05, and I suppose 20.11. I'm checking and rechecking if I'm crazy. This would not have triggered for anybody else in 18 months?! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 David Nind changed: What|Removed |Added Attachment #112828|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112865=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- Hi David. Are you able to provide a sample file for import with records that will trigger this? I tried by editing a record and making the title longer, then exporting; but it still worked. Otherwise, I will have another go this evening. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Blou changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900
--- Comment #1 from Blou ---
Created attachment 112864
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112864=edit
Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm
Plain simple:
my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} );
This patch replaces 'Koka' by 'Koha'.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 David Nind changed: What|Removed |Added Attachment #112843|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112863=edit Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds It appears that at some point, the actual blocking of checkins on items with holds got lost from the patch set. This slipped by because the sip server still outputs everything correctly, but the unit tests don't actually test to see if the checkout still exists afterward! Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26900] New: Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900
Bug ID: 26900
Summary: Fixes Koka::Libraries typo in C4/Reserves.pm
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs@lists.koha-community.org
Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Plain simple:
my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} );
This patch replaces 'Koka' by 'Koha'.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469
David Nind changed:
What|Removed |Added
Attachment #112845|0 |1
is obsolete||
--- Comment #4 from David Nind ---
Created attachment 112862
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112862=edit
Bug 25469: Typo: Item does not belongs to your library
This patch makes corrections to two strings in the batch delete template
to correct a typo. Before:
t("Item does not belongs to your library")
...after,
t("Item does not belong to your library")
To test, apply the patch and inspect the template to confirm that the
string is correct.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 --- Comment #6 from Katrin Fischer --- (In reply to Martin Renvoize from comment #3) > What's the attached image for Katrin? Oops, obviously not the right picture, but at least just a strange bugzilla screenshot! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #15 from Katrin Fischer --- Must have messed up testing the before here as well :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 Katrin Fischer changed: What|Removed |Added Attachment #111775|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind changed: What|Removed |Added Attachment #112848|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 112861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112861=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 David Nind changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #116 from David Nind --- Patches no longer apply 8-( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26899] Pick up location defaults to first choice if patron's library is disabled as pick up location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26899
--- Comment #2 from Christopher Brannon ---
I updated the jQuery so it doesn't have to modified each time something
changes. It just checks the patron's home library against the dropdown
choices.
//Reroute Patron Pick-up Locations
//if($.inArray($('#opac-holds #members
span.loggedinusername').attr('data-branchcode'),
['LAKECITY','POSTFALLS','ATHOL','RATHDRUM']) != -1) {
if ( !$('#opac-holds select[name="branch"] option[value=' + $('#opac-holds
#members span.loggedinusername').attr('data-branchcode') + ']').length ) {
$('#opac-holds select[name="branch"]').prepend('BRANCH
CLOSED - CHOOSE PICK UP LOCATION').val('NONE').width('350px');
$('#opac-holds select[name="branch"]
option[value="NONE"]').prop('disabled', true);
$('#opac-holds input.placehold').prop('disabled', true);
$('#opac-holds select[name="branch"]').change(function() {
$('#opac-holds input.placehold').prop('disabled', false);
});
}
//End Reroute
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 Kyle M Hall changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #14 from Kyle M Hall --- (In reply to Martin Renvoize from comment #11) > Confirmed.. see the loop for 'messages' inside process_invoice within > Koha::EDI. > > It loops through messages in the invoice file and extracts a docmsg_number > for each one. Ok, I feel like a nut ;) The invoice links are definitely working in master now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26899] Pick up location defaults to first choice if patron's library is disabled as pick up location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26899
Christopher Brannon changed:
What|Removed |Added
Summary|Pick up location defaults |Pick up location defaults
|to first choice if patron |to first choice if patron's
||library is disabled as pick
||up location
--- Comment #1 from Christopher Brannon ---
If patron's home library is disabled as a pick up location, it defaults to the
first available location in the dropdown.
I'm not sure if this request should be under system administration or hold
requests.
I think that if their location is disabled, there should be a message in the
dropdown, and disable the Confirm hold button until another location is chosen.
This is what I did with jQuery:
//Reroute Patron Pick-up Locations
if($.inArray($('#opac-holds #members
span.loggedinusername').attr('data-branchcode'),
['LAKECITY','POSTFALLS','ATHOL','RATHDRUM']) != -1) {
$('#opac-holds select[name="branch"]').prepend('BRANCH
CLOSED - CHOOSE PICK UP LOCATION').val('NONE').width('350px');
$('#opac-holds select[name="branch"]
option[value="NONE"]').prop('disabled', true);
$('#opac-holds input.placehold').prop('disabled', true);
$('#opac-holds select[name="branch"]').change(function() {
$('#opac-holds input.placehold').prop('disabled', false);
});
}
//End Reroute
If the library is in the array, the button is disabled and they are forced to
choose a different location. I'm going to change this slightly and have it do
this if their logged in library is not in the dropdown, so we don't have to
edit this list. But you get the idea.
This should be a part of Koha, because this easily slips by the attention of so
many patrons, and holds route to the wrong library because of it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26899] New: Pick up location defaults to first choice if patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26899 Bug ID: 26899 Summary: Pick up location defaults to first choice if patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #13 from Kyle M Hall --- (In reply to Martin Renvoize from comment #11) > Confirmed.. see the loop for 'messages' inside process_invoice within > Koha::EDI. > > It loops through messages in the invoice file and extracts a docmsg_number > for each one. I think we can make it work with multiple messages! Let me see what I can do. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25759 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
