[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|martin.renvoize@ptfs-europe |koha-b...@lists.koha-commun
   |.com|ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26875] Allow printing of just one barcode

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875

David Nind  changed:

   What|Removed |Added

 Attachment #112726|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 112973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112973&action=edit
Bug 26875: Allow printing of just one barcode in batch

To test:
1- go to the Print Barcode Range page
2- enter From=1 and To=1
3- confirm error "Must be greater than from value."
4- apply patch, restart, reload page
5- enter From=1, To=1
6- confirm no error
7- change From to 2, error reappears

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26875] Allow printing of just one barcode

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

--- Comment #11 from David Cook  ---
(In reply to Mason James from comment #10)
>
> i'm happy with this idea, so i sign-off :)

Great!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

Mason James  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #10 from Mason James  ---
(In reply to David Cook from comment #8)
> Note that there are a lot of recommended packages that aren't installed when
> using "--no-install-recommends":
> 
> I think the original idea of using Suggests rather than Recommends might be
> the safest.

i'm happy with this idea, so i sign-off :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

Mason James  changed:

   What|Removed |Added

 Attachment #112012|0   |1
is obsolete||

--- Comment #9 from Mason James  ---
Created attachment 112972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112972&action=edit
Bug 26741: Remove rabbitmq-server requirements (replace with suggestions)

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

Mason James  changed:

   What|Removed |Added

Summary|Make rabbitmq-server a  |Make rabbitmq-server
   |'recommended' package   |suggested rather than
   ||required

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

Mason James  changed:

   What|Removed |Added

 Attachment #112091|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

Mason James  changed:

   What|Removed |Added

 Attachment #112083|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

Mason James  changed:

   What|Removed |Added

 Attachment #112012|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475

David Nind  changed:

   What|Removed |Added

 Attachment #112714|0   |1
is obsolete||

--- Comment #26 from David Nind  ---
Created attachment 112971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112971&action=edit
Bug 23475: Use localStorage to preserve simple search values

To test:
1 - Enable IntranetCatalogSearchPulldown
2 - Perform a search that brings you to a single title
3 - Note the search is not displayed on the details page
4 - Apply patch
5 - Repeat
6 - Note the search is retained on details page
7 - Try with different dropdown values and search terms
8 - Test search terms including accented characters etc

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #112951|0   |1
is obsolete||

--- Comment #7 from Andrew Fuerste-Henry  ---
Created attachment 112970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112970&action=edit
Bug 24863: QueryFuzzy syspref says it requires Zebra but ElasticSearch has some
support.

This patch updates the description of the QueryFuzzy system preference
to make it more clear how it works with Zebra and how Elasticsearch has
some amount of fuzzy available for searches.

To test:
1. Go to administration
2. Search for QueryFuzzy
3. Observe the current description, which only includes Zebra.
4. Apply patch
5. Repeat steps 1-2
6. Observe the updated description.
7. Sign off

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes - step 1:

1. Download one of the EDI plugins from
https://github.com/bywatersolutions/koha-plugin-edifact-enhanced/releases (it
doesn't matter which one).

2. Install the plugin (Koha administration > Plugins > Manage plugins > Upload
plugin > browse for the plugin you downloaded in step 1 > click upload - the
plugin will then show in the list of plugins).

Note: Plugins need to be enabled for your development environment - make sure
your plugin directory is set (KTD =
/var/lib/koha/kohadev/plugins) and it is enabled
(1) in the koha-conf.xml file for your
instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908

David Nind  changed:

   What|Removed |Added

 Attachment #112919|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 112969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112969&action=edit
Bug 26908: Restore ability to view and select EDI plugins for a vendor account

Test Plan:
1) Install an EDI plugin
2) Browse to edi_accounts.pl, create or edit an account
3) Note the plugins pulldown is missing
4) Apply this patch
5) Restart all the things!
6) Reload the page
7) Note the pulldown is back!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #345 from David Cook  ---
(In reply to David Cook from comment #344)
> I'm going to be testing out this version of RabbitMQ over the next few weeks
> on a few different servers.
> 
> Note that I have no issues running an older version of RabbitMQ on openSUSE
> Leap 15.1.

No issues running this on a backup server. 

Just started running the latest RabbitMQ on a prod Ubuntu 18.04 as per the
aforementioned installation steps.

I am using "+sbwt none" and very little CPU usage. I could add those other
anti-busy wait arguments, but I'm not too concerned at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26920] SPAM

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26920

Katrin Fischer  changed:

   What|Removed |Added

Summary|aenjeayeh   |SPAM
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

David Nind  changed:

   What|Removed |Added

 Attachment #112950|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 112968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112968&action=edit
Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ
rules

UPDATE: changed queries to not touch * values

To test:
 1 - Checkout 19.11.x and reset_all
 2 - Add a new patron category, itemtype, and branch to your system
 3 - Create issuing rules using thise 3 values, and others
 4 - Delete the new category, itemtype and branch
 5 - Checkout master
 6 - Restart_all
 7 - updatedatabase
 8 - you get errors
 9 - repeat 1-5
10 - apply patch
11 - restart_all
12 - updatedatabase
13 - no errors!

Signed-off-by: Nick Clemens 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #39 from David Cook  ---
(In reply to David Cook from comment #38)
> I like the idea that the Anonymous Patron cannot be deleted, but I think
> that this implementation is too narrowly cast. 
> 
> I think that we should consider doing Bug 26170 (Create "system" patrons
> that cannot be (easily) deleted via the web UI) instead of this one, since
> there are many scenarios where we don't want to be able to delete patron
> accounts that are important (e.g. SIP patron, REST API patron, etc.)

Admittedly, I don't have any patches on Bug 26170, and it's not high on my
priority list at the moment, so I don't see myself working on it any time soon.

Kyle has done all this great work, and really if it could be adapted to be more
generalizable for all kinds of "system" patrons, that would be amazing. It
would be a very useful development.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #38 from David Cook  ---
I like the idea that the Anonymous Patron cannot be deleted, but I think that
this implementation is too narrowly cast. 

I think that we should consider doing Bug 26170 (Create "system" patrons that
cannot be (easily) deleted via the web UI) instead of this one, since there are
many scenarios where we don't want to be able to delete patron accounts that
are important (e.g. SIP patron, REST API patron, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26920] New: aenjeayeh

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26920

Bug ID: 26920
   Summary: aenjeayeh
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: contribs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alvianyuliant...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 112967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112967&action=edit
:v1

jembot

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

--- Comment #5 from David Cook  ---
(In reply to Katrin Fischer from comment #2)
> A changed password can't be queried, I like the idea of an enable/disable
> functionality for the permissions. You would still want to allow OPAC
> logins, but  block staff.

We could query it if we changed the password field to "!". I feel that's
something that Koha sometimes does?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

--- Comment #4 from David Cook  ---
(In reply to David Cook from comment #3)
> Locally, I think that we block all expired users from logging in. 
> 
> We do already have the "debarred" column. We use that for some local
> customizations too where we want to block people from logging in.

Although I suppose being debarred until -12-31 isn't exactly the same as
"disabled" heh.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
Locally, I think that we block all expired users from logging in. 

We do already have the "debarred" column. We use that for some local
customizations too where we want to block people from logging in.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26919] SPAM

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26919

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
Summary|aenjeaye|SPAM
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26919] New: aenjeaye

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26919

Bug ID: 26919
   Summary: aenjeaye
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alvianyuliant...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 112966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112966&action=edit
aenjeaye

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26918] SPAM

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26918

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED
Summary|anjg|SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26918] New: anjg

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26918

Bug ID: 26918
   Summary: anjg
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alvianyuliant...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 112965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112965&action=edit
hai

jambu

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Cook  changed:

   What|Removed |Added

 Blocks||25548


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
[Bug 25548] Package install Apache performs unnecessary redirects
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548

David Cook  changed:

   What|Removed |Added

 Depends on||7607
 Status|In Discussion   |Passed QA

--- Comment #30 from David Cook  ---
Moving back to Passed QA and adding a dependency on Bug 7607. Just so that it
doesn't get lost.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
[Bug 7607] Advanced search: Index and search term don't match when leaving
fields empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548

--- Comment #29 from David Cook  ---
(In reply to Jonathan Druart from comment #27)
>
> I don't think we should push this patch without having both sides happy.

David Nind and I have signed off on Nick's patch on Bug 7607. Once QA pass it,
then we should all be happy ^_^.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Cook  changed:

   What|Removed |Added

 Attachment #111064|0   |1
is obsolete||
 Attachment #111065|0   |1
is obsolete||
 Attachment #112963|0   |1
is obsolete||

--- Comment #27 from David Cook  ---
Created attachment 112964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112964&action=edit
Bug 7607: [Alternate] Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 

Signed-off-by: David Cook 

https://bugs.koha-community.org/show_bug.cgi?id=7606

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #26 from David Cook  ---
Ok this issue is really annoying me, so let's get it sorted...

Test plan:
0. No patch
1. Go to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1
2. Change 2nd "Keyword" and 3rd "Keyword" to "Author"
3. Change 2nd search box to "Martin" and 3rd search box to "Humble"
4. Change 2nd op box (between Martin and Humble) to "or"
5. Click "Search"
6. Note the following URL: 
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=kw&op=and&idx=au&q=Martin&op=or&idx=au&q=Humble&sort_by=relevance
7. Note the HTML response:
No results match your search for 'kw,wrdl: Martin and au,wrdl: Humble'.

Test plan:
0. Apply Nick's patch and "koha-plack --restart kohadev"
1. Go to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1
2. Change 2nd "Keyword" and 3rd "Keyword" to "Author"
3. Change 2nd search box to "Martin" and 3rd search box to "Humble"
4. Change 2nd op box (between Martin and Humble) to "or"
5. Click "Search"
5b. If you have a quick eye, you'll see the empty search box was removed by
Javascript. Yay!
6. Note the following URL:
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=au&q=Martin&op=or&idx=au&q=Humble&sort_by=relevance
7. Note the HTML response:
12 result(s) found for 'au,wrdl: Martin or au,wrdl: Humble'.

Great patch, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548

--- Comment #28 from David Cook  ---
(In reply to Jonathan Druart from comment #27)
> (In reply to David Cook from comment #24)
> > (In reply to Nick Clemens from comment #20)
> > > Would it be reasonable to clear empty inputs with javascript before the
> > > submission?
> > 
> > On reflection, that won't work the way you think it would work. It would
> > create the problems described in Bug 7607.
> 
> It won't if you remove the related idx.
> 

What I meant was that if you set the idx value to '' (ie if you "clear empty
inputs"), it will actually create an inconsistency in the form submission where
the idx param is *not* sent in the form submission but the q param *is* sent.
That is, unless you include an option in the select list for the idx that has a
value of ''. It seems like glitchy/unexpected browser behaviour (at least in
Chrome). 

But, as you say, removing the elements from the HTML form all together would
work.

> I don't think we should push this patch without having both sides happy.

Sounds all right to me. I already applied these patches locally about 6 months
ago, so I don't mind too much. Happy to help with Bug 7607 and then we can push
this one once that's sorted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #24 from David Cook  ---
Comment on attachment 112912
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912
Bug 7607: [Alternate] Remove empty inputs when submitting search form

Review of attachment 112912:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7607&attachment=112912)
-

::: koha-tmpl/intranet-tmpl/prog/js/staff-global.js
@@ +140,5 @@
> +if( $(this).find('input[name="q"]').val() == "" ){
> +$(this).remove();
> +removedPrior = true;
> +}
> +});

I haven't tested the code but what about the idx? Wouldn't this code exacerbate
the problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Nind  changed:

   What|Removed |Added

 Attachment #112912|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 112963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112963&action=edit
Bug 7607: [Alternate] Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced
search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated
before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
Title: (leave blank)
Author: clinton
keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26917] New: Searching for patrons: member.pl vs circulation.pl

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26917

Bug ID: 26917
   Summary: Searching for patrons: member.pl vs circulation.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When searching for a partial name, you get a list of results.  Depending on
whether you start your search in check out or patron search, the results
differ.  The records are the same, but the layout and information shown is
different.  This is confusing to staff, as they don't remember which place to
search for the information they want to search through.

I would suggest that we standardize the results so they are consistent.  On top
of that, I would like to see the ability to pick what information is included
the table of results.  There are fields we don't need to see, and there are
fields we would like to see, in order to determine which patron is the right
one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #13 from David Nind  ---
The updated forms and pages as per the test plan look okay to me - I checked
using Firefox Developer Edition on Ubuntu 18.04.

I didn't do any HTML validation, but I think these two tools will be useful for
future UI/accessibility work to help pick up and fix errors:

- WAVE Toolbar (for both Firefox and Google Chrome):
https://wave.webaim.org/extension/
- HTML Validator (for Firefox):
https://addons.mozilla.org/en-US/firefox/addon/html-validator/:

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #96 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #95)
> (In reply to Katrin Fischer from comment #94)
> > There still appears to be some regression :( 
> > 
> > - The filters on the datatable are no longer kept
> 
> Is that a thing in master?? I don't recall seeing code related to that.

I tested and yes, it worked in my tests. I had also noted it in comment#89 "or
the table search".

>  
> > - and the column filters have vanished altogether
> 
> Do we miss them?

They allow filtering on aspects that cannot be searched otherwise - I believe
they would be missed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

David Nind  changed:

   What|Removed |Added

 Attachment #112761|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 112961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112961&action=edit
Bug 26727: Fix  appearing in the templates

The self-closing p is not valid in HTML5:

Error: Self-closing syntax (/>) used on a non-void HTML element.
Ignoring the slash and treating as a start tag.

To test:

1)
- Activate Article requests
- Search for a record to place an article request on in staff
- Look up the patron
- Verify the article request form looks ok
2)
- Search for a list of patrons
- Check 2 patrons and merge them using the button above the list
- Verify the distance between the button and the table looks ok
3)
- Create a new MARC modification template
- Create a new action
- Verify the distances between the first and second line of form
  elements looks ok
4)
- Place a hold in staff
- Click on the Suspend link in the holds table (not below)
- Verify the modal looks ok

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

David Nind  changed:

   What|Removed |Added

 Attachment #112945|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 112962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112962&action=edit
Bug 26727: (follow-up) More markup corrections

This patch makes more markup changes to the templates previously
modified in order to try to arrive at some agreeable solutions.

- In the value_builder EXAMPLE template, the  is unnecessary and is
  removed. Also removed is the script "type" attribute and obsolete
  CDATA markers.
- In the article request template an unnecessary  is removed.
- In the merge patrons template the submit button is now in a  as is consistent with other forms.
- In the MARC modifications template I've added s around each
  "line" in the form to add the line break, along with some CSS to add
  margins.
- The submit button is now inside a  and the
  "Cancel" link now has the "cancel" class.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #95 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #94)
> There still appears to be some regression :( 
> 
> - The filters on the datatable are no longer kept

Is that a thing in master?? I don't recall seeing code related to that.

> - and the column filters have vanished altogether

Do we miss them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #112901|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 112960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112960&action=edit
Bug 24665: Add support for filtering by cash register

This patch makes it possible to filter on cash register
on the cash register statistics page.

To test:
- Activate UseCashRegisters
- Create a cash register or more to use
- Create some manual fees and fines
- Pay some of them off
- Go to Tools > Cash register statistics
- Test if the new filter for cash registers works as it should

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #94 from Katrin Fischer  ---
There still appears to be some regression :( 

- The filters on the datatable are no longer kept 
- and the column filters have vanished altogether

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26895] Template process failed: file error - parse error - patron-title.inc line 37: unexpected token ('‘ %] at /usr/share/koha/

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26895

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED

--- Comment #3 from Katrin Fischer  ---
The mistake was in the translation files, I fixed them. It was:
‘ %%] [%%- span_end = ‘

https://translate.koha-community.org/ca/translate/#search=span&sfields=source,target,locations&soptions=exact,case&unit=6524062&offset=10

You can either fix the file mentioned by Owen in comment#1 manually or wait for
the next bug fix release when this will be fixed by an update to the
translation files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #112677|0   |1
is obsolete||
 Attachment #112680|0   |1
is obsolete||
 Attachment #112681|0   |1
is obsolete||
 Attachment #112682|0   |1
is obsolete||

--- Comment #84 from Alexis Ripetti  ---
Created attachment 112959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112959&action=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :


$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
#   Failed test 'This list comes from the cache and that is fine'
#   at t/db_dependent/XSLT.t line 122.
#  got: '1'
# expected: '2'
# Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
---
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL


This one works fine :


$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #112679|0   |1
is obsolete||

--- Comment #83 from Alexis Ripetti  ---
Created attachment 112958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112958&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #112678|0   |1
is obsolete||

--- Comment #82 from Alexis Ripetti  ---
Created attachment 112957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112957&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #112671|0   |1
is obsolete||

--- Comment #81 from Alexis Ripetti  ---
Created attachment 112956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112956&action=edit
Bug 17385: Add custom export XSLT

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

--- Comment #2 from Katrin Fischer  ---
A changed password can't be queried, I like the idea of an enable/disable
functionality for the permissions. You would still want to allow OPAC logins,
but  block staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #112911|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 112955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112955&action=edit
Bug 26886: Correct style of alert-error class in the OPAC

This patch makes a minor change to the OPAC SCSS so that instances of
"alert-error" classes are styled the same as messages with the Bootstrap
4 "alert-warning" class. This change is simpler than making multiple
changes to scripts and templates.

To test, apply the patch and try to view a single news item in the OPAC
which doesn't exist:

/cgi-bin/koha/opac-main.pl?news_id=XXX

- You should see a warning message with a pale yellow background, "This
  news item does not exist."
- Submit a suggestion, and then submit another suggestion with the
  same title.
  - You should see a warning message, "The suggestion has not been
  added. A suggestion with this title already exists."

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26916] New: Allow patron attributes in DefaultPatronSearchFields syspref and patron search dropdown

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916

Bug ID: 26916
   Summary: Allow patron attributes in DefaultPatronSearchFields
syspref and patron search dropdown
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 17374

following bug 17374, fields listed in DefaultPatronSearchFields also appear in
the patron search fields dropdown. It would be great to be able to get patron
attributes to show in that dropdown, too.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
[Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search fields dropdown
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||26916


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916
[Bug 26916] Allow patron attributes in DefaultPatronSearchFields syspref and
patron search dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26914] Advanced search "fewer options" hides boolean operator dropdowns

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914

--- Comment #3 from Katrin Fischer  ---
(In reply to Andrew Fuerste-Henry from comment #2)
> +1 to adding those to sysprefs. Katrin, did you mean OpacAdvSearchOptions
> and OpacAdvSearchMoreOptions?

Definitely - thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26914] Advanced search "fewer options" hides boolean operator dropdowns

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry  ---
+1 to adding those to sysprefs. Katrin, did you mean OpacAdvSearchOptions and
OpacAdvSearchMoreOptions?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #112683|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 112953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112953&action=edit
Bug 26804: Add modal content preview

This patch turns the 'News' column into a preview button. That preview button
displays a modal with content of that rows news item.

To test:
1. Apply patch
2. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and
this image set to 1000px. 'https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg";
width="1000" />'.
3. Make sure and have some content with a lot of width and some content with a
lot of height.
4. Test the Preview content button
5. Make sure you can scroll through long modals and across modals that are wide
6. Try at different screen sizes and with different combonations of News items

Signed-off-by: Kelly  

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #112883|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 112954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112954&action=edit
Bug 26804: (QA follow-up) add modal-lg class and intent markup correctly

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26804] News: Limit the size of the news content column in newst table

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804

Katrin Fischer  changed:

   What|Removed |Added

Summary|Limit the size of the news  |News: Limit the size of the
   |content column in newst |news content column in
   |table (News tool)   |newst table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #112869|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 112952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112952&action=edit
Bug 26148: OpenLibrary "Preview" link target is unclear to patrons

This patch makes changes to the display of the Open Library "read" links
in the OPAC search results and detail page. The link is now grouped with
other details about the record ("Publisher," "Location(s)," etc. On the
detail page, the "Preview" link will no longer appear under the cover
image.

The label is changed to "Found in Open Library," and the link now opens
the Open Library reader in a new window.

The patch also changes the Open Library button image links so that they
use https and makes it so that the "Found in Open Library" information
is hidden until the availability information has loaded.

To test, apply the patch and enable the OpenLibrarySearch system
preference.

 - Perform a search in the OPAC which will return results found in Open
   Library, e.g. "poetry" in the sample data.
 - Confirm that the "Read now" images from Open Library appear on some
   search results.
 - View the detail page for one of these titles.
 - Confirm that the "Read now" button appears in the same format on the
   detail page.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26815] QueryFuzzy should also fuzzy Elasticsearch searches when set to "try"

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26815

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
   ||, n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863

--- Comment #6 from Andrew Fuerste-Henry  ---
Created attachment 112951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112951&action=edit
Bug 24863: QueryFuzzy syspref says it requires Zebra but ElasticSearch has some
support.

This patch updates the description of the QueryFuzzy system preference
to make it more clear how it works with Zebra and how Elasticsearch has
some amount of fuzzy available for searches.

To test:
1. Go to administration
2. Search for QueryFuzzy
3. Observe the current description, which only includes Zebra.
4. Apply patch
5. Repeat steps 1-2
6. Observe the updated description.
7. Sign off

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886

Mason James  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #15 from Mason James  ---
(In reply to José Anjos from comment #14)
> Similar situation:
> 
> Description:  Ubuntu 16.04.7 LTS
> Release:  16.04
> Codename: xenial
> 


please follow the official community instructions at...
 https://wiki.koha-community.org/wiki/Koha_on_Debian

1.1.2.3 Support for Koha on older versions of Debian/Ubuntu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26914] Advanced search "fewer options" hides boolean operator dropdowns

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914

--- Comment #1 from Katrin Fischer  ---
Maybe the booleans could be added to the AdvancedSearchTypes system preference
options?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23507] Add ability to show and print change given on fee receipt from FinePaymentAutoPopup

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||26915


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915
[Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||23507


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507
[Bug 23507] Add ability to show and print change given on fee receipt from
FinePaymentAutoPopup
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26915] New: Koha explodes when writing off a fee with FinePaymentAutoPopup

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915

Bug ID: 26915
   Summary: Koha explodes when writing off a fee with
FinePaymentAutoPopup
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

- To test activate FinePaymentAutoPopup
- Create a manual fee
- Write it off using the write off button on the account line (not below table)
- Experience error on saving the writeoff

http://localhost:8081/cgi-bin/koha/members/printfeercpt.pl?action=print&accountlines_id=HASH(0x558152468290)&borrowernumber=51

Can't call method "unblessed" on an undefined value at
/home/vagrant/kohaclone/members/printfeercpt.pl line 64

This problem was first found in 20.05.03 so affects stable releases as well!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26914] New: Advanced search "fewer options" hides boolean operator dropdowns

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914

Bug ID: 26914
   Summary: Advanced search "fewer options" hides boolean operator
dropdowns
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org

In advanced search in both OPAC and staff client, choosing "fewer options"
removes the and/or/not dropdown choices.  Libraries would like to have the
minimized look of the "fewer options" search but need the boolean operator
choices to show.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #112949|0   |1
is obsolete||

--- Comment #5 from Andrew Fuerste-Henry  ---
Created attachment 112950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112950&action=edit
Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ
rules

UPDATE: changed queries to not touch * values

To test:
 1 - Checkout 19.11.x and reset_all
 2 - Add a new patron category, itemtype, and branch to your system
 3 - Create issuing rules using thise 3 values, and others
 4 - Delete the new category, itemtype and branch
 5 - Checkout master
 6 - Restart_all
 7 - updatedatabase
 8 - you get errors
 9 - repeat 1-4
10 - apply patch
11 - restart_all
12 - updatedatabase
13 - no errors!

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19133] Password recovery routes

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133

--- Comment #28 from Tomás Cohen Arazi  ---
(In reply to Lari Taskula from comment #27)
> (In reply to Tomás Cohen Arazi from comment #18)
> > This is also missing some tests for the Recovery.pm changes (url param).
> 
> Hi Tomas, and Kyle, nice to see you testing and QA'ing this. I can confirm
> the missing tests - Recovery.pm::SendPasswordRecoveryEmail() is missing
> tests for the changes introduced in the second and third patch (url and
> skip_mail parameters). The main functionality is tested in the REST tests
> but of course we should still add unit tests to SendPasswordRecoveryEmail
> itself.

We are almost on feature freeze. If the RM would consider this for inclusion (I
would include it, as it is not going to break any existing feature) I can help
with the missing tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19133] Password recovery routes

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133

--- Comment #27 from Lari Taskula  ---
(In reply to Tomás Cohen Arazi from comment #18)
> This is also missing some tests for the Recovery.pm changes (url param).

Hi Tomas, and Kyle, nice to see you testing and QA'ing this. I can confirm the
missing tests - Recovery.pm::SendPasswordRecoveryEmail() is missing tests for
the changes introduced in the second and third patch (url and skip_mail
parameters). The main functionality is tested in the REST tests but of course
we should still add unit tests to SendPasswordRecoveryEmail itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||and...@bywatersolutions.com

--- Comment #4 from Andrew Fuerste-Henry  ---
These delete statements would also delete rules where the value is *. That'd be
bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

didier  changed:

   What|Removed |Added

 CC||didier.gautheron@biblibre.c
   ||om

--- Comment #1 from didier  ---
Hi,

Isn't changing password good enough?

Doing it the Unix way , with an invalid password should be better though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

--- Comment #10 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #9)
> Thanks a lot, Owen! Wouldn't mind if you want to throw my patch out for 
> simplicity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

--- Comment #9 from Katrin Fischer  ---
Thanks a lot, Owen! Wouldn't mind if you want my patch out for simplicity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

Nick Clemens  changed:

   What|Removed |Added

 Attachment #112935|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 112949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112949&action=edit
Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ
rules

To test:
 1 - Checkout 19.11.x and reset_all
 2 - Add a new patron category, itemtype, and branch to your system
 3 - Create issuing rules using thise 3 values, and others
 4 - Delete the new category, itemtype and branch
 5 - Checkout master
 6 - Restart_all
 7 - updatedatabase
 8 - you get errors
 9 - repeat 1-4
10 - apply patch
11 - restart_all
12 - updatedatabase
13 - no errors!

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25334] Add generic 'phone' message transport type

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334

--- Comment #12 from Kyle M Hall  ---
Created attachment 112947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112947&action=edit
Bug 25334: (QA follow-up) Update opac messaging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |In Discussion
   Severity|major   |normal

--- Comment #4 from Nick Clemens  ---
To recreate:
1 - Remove any All/All rules from circulation rules
2 - Set a circ rule for a specific itemtype with Holds allowed (total) set to 5
3 - Attempt to place a hold on an itemtype without the rules
4 - Too many holds: Edna Acosta can only place a maximum of 0 total holds.

Turns out, this behaviour is consistent in my testing, so the problem was the
upgrade only

There is a question whether no rules set should allow unlimited holds, or 0
holds but that's not necessarily a bug.
Currently we set "" for unlimited, and the rule not existing means that holds
are not allowed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25334] Add generic 'phone' message transport type

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334

--- Comment #13 from Kyle M Hall  ---
Created attachment 112948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112948&action=edit
Bug 25334: (QA follow-up) Update overduerules.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25334] Add generic 'phone' message transport type

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25334] Add generic 'phone' message transport type

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #112119|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 112946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112946&action=edit
Bug 25334: Add generic 'phone' message transport type

As bug 25333 changed the 'phone' transport type to 'talkingtech', we can
now re-add 'phone' as a transport type again, and allow it to behave and
support the same notices as the email transport type.

Test Plan;
1) Apply this patch
2) Run updatedatabase
3) Restart all the things!
4) Disable TalkingTechItivaPhoneNotificationi if enabled
5) Enable new PhoneNotification system preference
6) Go to a patron's messaging preferences, not you can select the
   'phone' option for all the same notices as the 'email' option
7) Enable the phone option for all the message types
8) Browser to the Notices and slips editor
9) Add a phone notice version for each notice you wish to test
10) Test some notices ( CHECKIN, CHECKOUT, etc )
11) Notices should show in the patron's messages as 'phone' notices

Signed-off-by: Christopher Zorn 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

--- Comment #8 from Owen Leonard  ---
Created attachment 112945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112945&action=edit
Bug 26727: (follow-up) More markup corrections

This patch makes more markup changes to the templates previously
modified in order to try to arrive at some agreeable solutions.

- In the value_builder EXAMPLE template, the  is unnecessary and is
  removed. Also removed is the script "type" attribute and obsolete
  CDATA markers.
- In the article request template an unnecessary  is removed.
- In the merge patrons template the submit button is now in a  as is consistent with other forms.
- In the MARC modifications template I've added s around each
  "line" in the form to add the line break, along with some CSS to add
  margins.
- The submit button is now inside a  and the
  "Cancel" link now has the "cancel" class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #58 from Andrew Fuerste-Henry  ---
I applied your patches, updated the database, and restarted services.
I then edited my All/All rule for all libraries and saved it as Has Priority.
Then I copied my All/All rule for all libraries to one of my branches.
After doing that, I am unable to save changes to any of my circ rules. I cannot
save edits my branch rules or my all libraries rules. When I click Save, the
values revert back to their original values and I get this error in the plack
log:

[2020/11/03 17:19:17] [WARN] DBD::mysql::st execute failed: Unknown column
'me.has_priority' in 'field list' [for Statement "SELECT `me`.`id`,
`me`.`branchcode`, `me`.`categorycode`, `me`.`itemtype`, `me`.`has_priority`,
`me`.`rule_name`, `me`.`rule_value` FROM `circulation_rules` `me` WHERE ( (
`me`.`branchcode` IS NULL AND `me`.`rule_name` = ? ) )" with ParamValues:
0='refund'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19133] Password recovery routes

2020-11-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >