[Koha-bugs] [Bug 22579] Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

--- Comment #25 from Marcel de Rooy  ---
Did you see bug 23302 ?
We are working on the same thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938

David Nind  changed:

   What|Removed |Added

 Attachment #113115|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 113218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113218=edit
Bug 26938: Prevent flash of unstyled sales table

On the registers page the table has come complex data structures
embedded to allow for all the functionality we bring into the datatable.

We should hide the table on page load and only display it at DataTables
init time once the weird content has been beautified by DataTables.

Test plan
1/ Enable 'UseCashRegisters' and 'EnablePointOfSale'
2/ Add a cash register and make some transactions against it.
3/ Navigate to the 'Register details' page
4/ Note that some 'funky' JSON strings appear in the table briefly
before it is restyled when DataTables loads.
5/ Apply the patch
6/ Rebuild the CSS from the SCSS files
7/ Reload the page (hard reload to get the CSS changes)
8/ Note that the table now only appears once the nice formatting that
DataTables adds is applied.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

--- Comment #219 from Joonas Kylmälä  ---
This seems to cause incorrect double encoding in HOLD slip / pickup
notifications. Working on a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26945] New: new arrival plugin not working

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26945

Bug ID: 26945
   Summary: new arrival plugin not working
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ujjwalguptax...@gmail.com
QA Contact: testo...@bugs.koha-community.org

when i was trying to show my new arrival books on opacmainuserblock via plugin
i used both plugin by bywatersolution and carousel but none of them working in
my koha version 20.05 can you guys please helpme with proper step by step guide
in new version 20.05 please

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

David Nind  changed:

   What|Removed |Added

 Attachment #113212|0   |1
is obsolete||

--- Comment #37 from David Nind  ---
Created attachment 113217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113217=edit
Bug 25560: Unit tests

Test plan:
1. Run tests
sudo koha-shell 
prove xt
prove t
prove t/db_dependent/Circulation/issue.t
prove t/db_dependent/Koha/Object.t

Sponsored-By: Waikato Institute of Technology, NZ

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

David Nind  changed:

   What|Removed |Added

 Attachment #109565|0   |1
is obsolete||

--- Comment #36 from David Nind  ---
Created attachment 113216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113216=edit
Bug 25560: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

Adds a boolean flag itemtypes.updatenotforloanstatusoncheckin, enabled by
default.
When disabled (if the UpdateNoForLoanStatusOnCheckin syspref is
configured) when an item of the type if checked in the notforloan status
does not update.

This enhancement respects the 'item-level_itypes' syspref, so will look
at the authoritative item type when determining to update the notforloan
status.

Test plan:
1. Paste into UpdateNotForLoanStatusOnCheckin syspref
0 : 1
2. Issue and return an item and observe the item's notforloan status updates
3. Apply patch & update database
cd installer/data/mysql
sudo koha-shell 
./updatedatabase.pl
4. Restart plack
5. Go to BK (Book) item type page (Administration > Item types > BK).
6. Observe the 'Update not for loan status on check-in' checkbox is
selected by default. Untick it.
7. Make sure the 'item-level_itypes' syspref is set to 'specific item'
8. Issue and return a BK item (item level itype='BK') and observe item's
notforloan status does not update
9. Issue and return a CR (Continuing Resources) item (item level
itype='CR') and observe the item's notforloan status updates

10. Change 'item-level_itypes' syspref to 'bibliographic record'
11. Issue and return an item (with biblio-level itemtype='BK' &
item-level itype='CR') and observe the item's notforloan status does not
update
12. Issue and return an item (with biblio-level itemtype='CR' &
item-level itype='BK') and observe the item's notforloan status
updates

Sponsored-By: Waikato Institute of Technology, NZ

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

David Nind  changed:

   What|Removed |Added

 Attachment #109563|0   |1
is obsolete||

--- Comment #34 from David Nind  ---
Created attachment 113214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113214=edit
Bug 25560: Updated schema file

Sponsored-By: Waikato Institute of Technology, NZ

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

David Nind  changed:

   What|Removed |Added

 Attachment #109564|0   |1
is obsolete||

--- Comment #35 from David Nind  ---
Created attachment 113215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113215=edit
Bug 25560: Template & syspref yaml changes

Sponsored-By: Waikato Institute of Technology, NZ

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

David Nind  changed:

   What|Removed |Added

 Attachment #109562|0   |1
is obsolete||

--- Comment #33 from David Nind  ---
Created attachment 113213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113213=edit
Bug 25560: Database and installer changes

-- Adds boolean flag itemtypes.updatenotforloanstatusoncheckin

Sponsored-By: Waikato Institute of Technology, NZ

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

--- Comment #32 from David Nind  ---
Hi Alex.

Success! Now signing off!

I ran the tests again, both before and after applying the patches, and running
through the test plan:
- prove xt: the tests that fail are the same that fail BEFORE the patch is
applied, and after working through the test plan (xt/check_makefile.t is the
test that fails)
- prove t: the tests that fail are the same that fail BEFORE the patch is
applied, and after working through the test plan (t/Logger.t is the test that
fails)
- prove t/db_dependent/Circulation/issue.t: all pass both before and after
patches applied, and test plan worked through (also passes with changing
item-level_itypes)
- prove t/db_dependent/Koha/Object.t: all pass both before and after patches
applied, and test plan worked through (also passes with changing
item-level_itypes)

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22785] Manage Multiple Matches when importing through Stage Marc Record Import

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26936] sip2 allows the checkin the item was already checkin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26936

--- Comment #2 from Vihaan Gupta  ---
(In reply to Magnus Enger from comment #1)
> This can be configured with the checked_in_ok setting in the SIP2 config
> file:
> https://wiki.koha-community.org/wiki/SIP2_configuration#checked_in_ok

Thank you Magnus :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #635 from David Nind  ---
Hi Aleisha.

I went through the test plan again, ran the tests, and ran the qa scripts.

1. Test plan: there is only one minor item that isn't working as expected - I
noted previously, but didn't report it. I think it is pretty minor, so could
wait.

  Step 58. Need to refresh the page to see the change in status (from ready for
pickup TO Requested).

2. Tests: one test fails for prove -v t/db_dependent/Koha/Recalls.t

not ok 19 - Recall fulfilled with move_recall

#   Failed test 'Recall fulfilled with move_recall'
#   at t/db_dependent/Koha/Recalls.t line 173.
# Looks like you failed 1 test of 19.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/19 subtests 

Test Summary Report
---
t/db_dependent/Koha/Recalls.t (Wstat: 256 Tests: 19 Failed: 1)
  Failed test:  19
  Non-zero exit status: 1
Files=1, Tests=19,  3 wallclock secs ( 0.02 usr  0.01 sys +  2.75 cusr  0.26
csys =  3.04 CPU)
Result: FAIL

3. QA scripts: I ran the qa scripts (not something I normally do)

I've put the output from the test fail and qa output here:
http://paste.koha-community.org/26033

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7882] Add ability to move and reorder fields and subfields in MARC editor

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Father Vlasie  changed:

   What|Removed |Added

 CC||fv@spots.school

--- Comment #71 from Father Vlasie  ---
This feature does not work in Safari (tested with version 14). Perhaps we could
have the older arrow system for browsers that do not support this otherwise
some users are without a method to reorder subfields. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

--- Comment #31 from Alex Buckley  ---
Hi David, 

I've attached another unit test patch. This time I set a mock item-level_itypes
preference value before line 440. So now the unit test shouldn't care about
what value you have set in the item-level_itypes syspref on your Koha instance.

I've also added in a few more unit test checks in
t/db_dependent/Circulation/issue.t and have added more comments which will
hopefully help people know what the test is doing!

Could you please re-try testing now?

Many thanks
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Alex Buckley  changed:

   What|Removed |Added

 Attachment #113161|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

--- Comment #30 from Alex Buckley  ---
Created attachment 113212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113212=edit
Bug 25560: Unit tests

Test plan:
1. Run tests
sudo koha-shell 
prove xt
prove t
prove t/db_dependent/Circulation/issue.t
prove t/db_dependent/Koha/Object.t

Sponsored-By: Waikato Institute of Technology, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #4 from David Cook  ---
(In reply to Lucas Gass from comment #3)
> David, correct. I meant it DOES automatically take out HTML tags like...
> 
> 
> Thanks for clarifying.

Just to clarify again. I was saying that the TinyMCE behaviour was annoying and
not the typo heh. 

If you do a patch for this one, I'd be happy to test it. (Probably not
something I'll look at writing my own fix for any time soon thought.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #3 from Lucas Gass  ---
(In reply to David Cook from comment #2)
> (In reply to Lucas Gass from comment #1)
> > TinyMCE doesn't automatically takes out HTML tags like , 

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103425|0   |1
is obsolete||

--- Comment #140 from Aleisha Amohia  ---
Created attachment 113211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113211=edit
Bug 8367: Add holds_pickup_period circulation rule

So that pickup delay can have a different value per patron category,
   item type or branch.

To test:

1) Update database, restart services
2) Set ReservesMaxPickUpDelay syspref (if not already set)
3) Edit your circulation rules and set a value under 'Holds pickup
period (day) that is DIFFERENT from ReservesMaxPickUpDelay
4) Place a hold on a biblio
5) Check in an item from that biblio and confirm the hold as waiting
6) Confirm the expiration date is calculated using the 'Holds pickup
period' value instead of the ReservesMaxPickUpDelay syspref
7) Revert the waiting status and delete the hold
8) Re-place the hold on the biblio
9) Create a holiday with a date that will overlap with the 'Holds pickup
period'
10) Check in an item from that biblio and confirm the hold as waiting
11) Confirm the expiration date is calculated using the 'Holds pickup
period' value AND considers the special holiday
12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t

I've also added this to the TalkingTech_itiva_outbound.pl cronjob, I'm
not sure how to test this. Please test properly if you can, otherwise
maybe put some warns in and confirm the correct expiration date is
calculated.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #102336|0   |1
is obsolete||

--- Comment #41 from Aleisha Amohia  ---
Created attachment 113210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113210=edit
Bug 20844: (follow-up) Get working with transfers

Test:

1) Change branch to Branch B
2) Place a biblio-level hold at Branch B
3) Change branch to Branch A
4) Check in item at Branch A and set waiting and trigger transfer
5) Go to edit item and set item as lost
6) Check borrower's notices tab and confirm the lost_waiting_hold notice
was enqueued
7) Follow test plan again with item-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #102335|0   |1
is obsolete||

--- Comment #40 from Aleisha Amohia  ---
Created attachment 113209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113209=edit
Bug 20844: (follow-up) SendLostHoldNotices

This patch adds a new syspref SendLostHoldNotices

Test:
1) Update database and restart memcached
2) Enable the SendLostHoldNotices system preference
3) Place a hold on an item
4) Check in the item and set the hold to waiting
5) Go to edit the item and set an item lost status
6) Check the borrower's notices and confirm the notice has been enqueued
7) Confirm the notice is not sent twice when reverting or cancelling the
hold
8) Confirm notice enqueues as expected for a bib-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #102334|0   |1
is obsolete||

--- Comment #39 from Aleisha Amohia  ---
Created attachment 113208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113208=edit
Bug 20844: Revert or cancel lost holds

This patch introduces the RevertLostBibLevelHolds syspref. When an item
is marked as lost, if there is a bib-level hold on it waiting, the hold
is reverted. If there is an item-level hold on it waiting, there is an
alert box asking if the library would like to revert the hold or cancel
it.

Test:

1) Update database and restart memcached/plack
2) Place a hold on Biblio A
3) Check in Item A from Biblio A and set the hold as waiting
4) Edit Item A and give it a lost status (952$1, you may need to edit
your MARC frameworks to have this visible in the Editor)
5) Look at your hold. Notice it is still waiting.
6) Go to Administration -> System preferences. Find the
RevertLostBibLevelHolds system preference and enable it.
7) Cancel your hold and remove Item A's lost status. Place another biblio-level
hold on the same biblio
8) Check in Item A from Biblio A and set the hold as waiting
9) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
10) Edit Item A and give it a lost status
11) Once the page reloads, go to view your hold. It should no longer be
waiting and have no item allocated.
12) Cancel your hold and remove Item A's lost status. Place an item-level hold
on Item A
13) Check in Item A and set the hold as waiting
14) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
15) Give Item A a lost status and save changes
16) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
17) Confirm your hold is no longer waiting, but the item is still
allocated
18) Remove Item A's lost status
19) Check in Item A and set the hold as waiting
20) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
21) Give Item A a lost status and save changes
22) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
23) Confirm the hold is now cancelled
24) Remove Item A's lost status
25) Place an item-level hold on Item A
26) Check in Item A and set the hold as waiting
27) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
28) Give Item A a lost status and save changes
29) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
30) Confirm your hold is no longer waiting, but the item is still
allocated
31) Remove Item A's lost status
32) Check in Item A and set the hold as waiting
33) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
34) Give Item A a lost status and save changes
35) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
36) Confirm the hold is now cancelled
37) Remove Item A's lost status
38) Place an item-level hold on Item A. Check in Item A and set the hold
as waiting
39) Place an item-level hold on Item B (same biblio) for another borrower.
Check in
Item B and set the hold as waiting.
40) Give both Items A and B lost statuses.
41) Confirm that both Items are included in the alert box on page when
editing items (cataloguing/additem.pl)
42) Confirm that both Items have individual alert boxes on the Items tab
(catalogue/moredetail.pl)
43) Confirm tests pass t/db_dependent/Reserves.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
(In reply to Lucas Gass from comment #1)
> TinyMCE doesn't automatically takes out HTML tags like , 

[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854

--- Comment #9 from David Cook  ---
I should flag here for QA that I do something a bit cheeky in this patch.

I add a new log file called "background-jobs.log" to log any errors generated
by the child stage-marc-import.pl process. 

I'm happy to discuss what log file gets used, of course. And rather be upfront
about it rather than requiring someone to dig that out of the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692

--- Comment #22 from David Cook  ---
(In reply to Jonathan Druart from comment #21)
> Won't it open the door to generate someone else's barcode (easily)?

That's a good point. I hadn't looked at the mechanism.

Perhaps a better barcode image generator would be something like "GET
/svc/user/my_barcode" instead of "GET /svc/barcode?barcode=123456"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26932] Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26932

Aleisha Amohia  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #6 from David Cook  ---
(In reply to Mark Hofstetter from comment #4)
> OK I really like the idea to expose the data via an API route
> 
> so would you change the opac-detail.tt file, or add the whole tab via the js?

I would just add the whole tab via the JS. That way, you don't have to modify
Koha at all, and all of your functionality is self-contained in the Koha
Plugin.

(I did send an email out yesterday that suggested the Koha Community modify
opac-detail.pl (or an underlying library function) to allow Koha Plugins to
modify the $template variable.)

(Alternatively, it would be interesting to modify opac-detail.pl and
opac-detail.tt to build the tabs using Javascript instead of Perl-generated
HTML. But that's a separate development all together.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

--- Comment #29 from David Nind  ---
For prove -v t/db_dependent/Circulation/issue.t

1. If I run before and after the patches are applied - all tests pass!
2. If I run after running through the test plan - test 33 fails
not ok 33 - UpdateNotForLoanStatusOnCheckin does not update notforloan
value when itemtypes.updatenotforloanstatusoncheckin = 0

#   Failed test 'UpdateNotForLoanStatusOnCheckin does not update notforloan
value when itemtypes.updatenotforloanstatusoncheckin = 0'
#   at t/db_dependent/Circulation/issue.t line 440.
3. If I change item-level_itypes system preference back to 'specific item' -
everything passes!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #105055|0   |1
is obsolete||

--- Comment #23 from Aleisha Amohia  ---
Created attachment 113206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113206=edit
Bug 22579: Split actions in z3950 search results into a split button

Where 'Import' is the main button and the two card previews are in the
dropdown

Also show Card preview when clicking on title of record

To test:
1) Go to Cataloguing -> New from Z39.50/SRU
2) Search for a term that will produce results
3) Once results are shown, notice the split button
4) Click anywhere on results rows. Confirm the dropdown menu still shows
when you click anywhere, as normal
5) Confirm clicking the title pops up the Card preview
6) Confirm Import is the main button in the actions and still works as
expected

Sponsored-by: Horowhenua Library Trust

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #105056|0   |1
is obsolete||

--- Comment #24 from Aleisha Amohia  ---
Created attachment 113207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113207=edit
Bug 22579: (follow-up) Remove problematic whitespace

This patch removes some whitespace from the template which was causing
display problems with the "Import" split button.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22579] Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #5 from David Cook  ---
(In reply to Fridolin SOMERS from comment #3)
> No need to inject, there is a plugin hook opac_js :
> https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/blob/
> 450b145a09c358b0dc3eaa0ee97151643c1bbda6/Koha/Plugin/Com/ByWaterSolutions/
> KitchenSink.pm#L252
> 
> And hook opac_head for CSS

That's what I meant by inject, but thanks for providing those hooks. I was too
lazy to look them up .

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #33 from David Cook  ---
(In reply to Nick Clemens from comment #31)
> (In reply to Jonathan Druart from comment #28)
> > To prevent the values to be sent maybe we could disable the elements instead
> > of removing them from the DOM. What do you think?
> 
> It seems to work either way - I am not sure if there is any advantage in one
> method over the other, but I trust the RM

What's the effect when hitting the "Back" button in the browser? I have a
feeling that removing the elements might work better than disabling them in
that context, but I'm not 100% sure off the top of my head. (Just thinking of
different scenarios.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #32 from David Cook  ---
(In reply to Nick Clemens from comment #29)
> Signed-off-by: David Nind 
> 
> Signed-off-by: David Cook 
> 
> https://bugs.koha-community.org/show_bug.cgi?id=7606

Ooops I think I introduced an extra mistyped line to the bottom of the commit
message. Hope someone erases that later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #634 from Aleisha Amohia  ---
Thanks David and Victor, I have rebased and fixed the bug that David mentioned,
ready again for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #633 from Aleisha Amohia  ---
Created attachment 113205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113205=edit
Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112622|0   |1
is obsolete||

--- Comment #632 from Aleisha Amohia  ---
Created attachment 113204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113204=edit
Bug 19532: (follow-up) Fixing OPAC display and staff client errors

- fixes the displays of opac-recalls.pl and opac-recall.pl
- fix the error on Recalls to pull page
- fix JS error preventing Recalled link from showing in checkouts table
- fix cancelling of recall when checking out item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112619|0   |1
is obsolete||

--- Comment #629 from Aleisha Amohia  ---
Created attachment 113201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113201=edit
Bug 19532: Recalls on intranet

See recalls on Intranet
- old recalls (all inactive recalls)
- recalls queue (all active recalls) - cancel, expire, revert waiting status,
multiple cancel, mark overdue
- recalls to pull (available but not yet waiting) - cancel
- recalls awaiting pickup (awaiting pickup, awaiting pickup more than
RecallMaxPickUpDelay days) - expire, revert waiting status
- overdue recalls (overdue to be returned) - cancel, multiple cancel
- biblio recalls tab (all active recalls relevant to this bib) - cancel,
expire, revert waiting status, mark overdue
- patron recalls tab (all active recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- patron recalls history tab (all recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- log viewer

and the general circulation of recalls

== TEST PLAN FOR RECALLS ==

ADMINISTRATION

1. Apply all patches
2. Run database updates, update schema files and confirm everything applies
cleanly
3. Run tests and confirm everything passes:
t/db_dependent/Koha/Recall.t
t/db_dependent/Koha/Recalls.t
t/db_dependent/Stats.t
t/db_dependent/Circulation/CalcFine.t
t/db_dependent/Koha/Item.t
t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Patron.t
t/db_dependent/XSLT.t
t/db_dependent/Search.t
t/db_dependent/Holds.t
t/db_dependent/Circulation/transferbook.t
t/db_dependent/Circulation.t

4. Go to Administration -> system preferences. Find the UseRecalls system
preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by
default.
5. Go to Administration -> circulation rules. Confirm there are no recalls
circulation rules showing.
6. Test a few circulation flows: checking out, placing a reserve, checking in,
fulfilling a reserve, etc. Confirm everything works as normal.

7. Go to Administration -> system preferences. Enable the UseRecalls system
preference.
8. Go to Administration -> circulation rules. Set the following rules:
Recalls allowed (count) = 0
Recalls per record (count) = 0
On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any
unavailable
Recall due date interval (days) = 3
Recall overdue fine amount = (something different to your normal fine amount)
Recall pickup period (days) = 1

Throughout your testing, try with different combinations of these rules and
itemtype / branchcode / categorycode. Also try with null values. Keep the
circulation rules open in another tab so you can refer to and update these
easily. You should also have at least one other tab open for the staff client,
and a third tab open for the OPAC, for ease of testing.

9. Go to your account -> More -> Set permissions. Confirm the recalls
permission is checked.
10. Set up a test user with OPAC login details (Borrower A). This could also be
your own user, as long as you have OPAC login access.
11. Set up a test record (Biblio A) with at least two items (Item A and Item B)
of the same item type (or an item type with the same recall circ rules).

PLACING A RECALL

12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that
will return multiple results, including Biblio A.
13. Click on Biblio A.
14. Notice there is a 'Place recall' button on the sidebar menu. Click this
button. There will be a message saying that there are no items to recall - this
is because all items are available.

15. Check out Item A to another borrower (Borrower B).
16. Refresh the 'Place recall' page. You will still NOT be able to place a
recall - this is because Recalls allowed = 0 and Recalls per record = 0.

17. Edit the circulation rules to have the following values:
Recalls allowed (count) = 1
Recalls per record (count) = 1
18. Refresh the 'Place recall' page. You will now see the form to place a
recall.

BIBLIO-LEVEL RECALL, NO TRANSFER

19. Place a biblio-level recall.
Pickup location: Branch A, the set branch when you are logged into the staff
client
Recall not needed after (expiration date): whatever you want
Select 'recall next available item'
Click confirm
20. Confirm the recall is placed successfully. Confirm that the new due date
displayed is correctly calculated to be today's date, plus 3 days (taken from
the 'recall due date interval' circ rule)
21. In the staff client, look at Borrower B's account, and go to their Notices
tab. Confirm they have received a 'Notification to return recalled item'
notice.
22. Look at Borrower B's checkouts table. Notice the due date for their
checkout has been adjusted, and there is now a note 

[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112621|0   |1
is obsolete||

--- Comment #631 from Aleisha Amohia  ---
Created attachment 113203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113203=edit
Bug 19532: (follow-up) Fixing failing CalcFine.t test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112620|0   |1
is obsolete||

--- Comment #630 from Aleisha Amohia  ---
Created attachment 113202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113202=edit
Bug 19532: (follow-up) aria-hidden attr on OPAC, and more

- removing authnotrequired flag from scripts
- fixing opac buttons
- chmod +x for recalls test files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112618|0   |1
is obsolete||

--- Comment #628 from Aleisha Amohia  ---
Created attachment 113200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113200=edit
Bug 19532: Recalls on OPAC

- place a biblio-level or item-level recall via the biblio detail page, OPAC
search results, or course reserves
- view or cancel your active recalls from 'your summary' recalls tab
- view all active and inactive (and cancel active) recalls from 'your recall
history'
- stopped from placing a reserve on an item that the patron has already
recalled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112617|0   |1
is obsolete||

--- Comment #627 from Aleisha Amohia  ---
Created attachment 113199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113199=edit
Bug 19532: Other objects used in recalls feature

- biblio->recalls
- biblio->can_be_recalled
- item->recall
- item->can_be_recalled
- item->can_set_waiting_recall
- item->check_recalls
- patron->recalls
- Biblio.RecallsCount

and relevant tests
- t/db_dependent/Stats.t
- t/db_dependent/Koha/Item.t
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/Koha/Patron.t
- t/db_dependent/XSLT.t
- t/db_dependent/Search.t
- t/db_dependent/Holds.t
- t/db_dependent/Circulation/transferbook.t
- t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112616|0   |1
is obsolete||

--- Comment #626 from Aleisha Amohia  ---
Created attachment 113198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113198=edit
Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation

- misc/cronjobs/recalls/expire_recalls.pl
- misc/cronjobs/recalls/overdue_recalls.pl
- tests for overdue fines in t/db_dependent/Circulation/CalcFine.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112615|0   |1
is obsolete||

--- Comment #625 from Aleisha Amohia  ---
Created attachment 113197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113197=edit
Bug 19532: Recalls objects and tests

Koha/Recall.pm
- biblio
- item
- patron
- library
- checkout
- requested
- waiting
- overdue
- in_transit
- expired
- cancelled
- finished
- calc_expirationdate
- start_transfer
- revert_transfer
- set_waiting
- revert_waiting
- set_overdue
- set_expired
- set_cancelled
- set_finished
- should_be_overdue

Koha/Recalls.pm
- add_recall
- move_recall

and relevant tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112614|0   |1
is obsolete||

--- Comment #624 from Aleisha Amohia  ---
Created attachment 113196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113196=edit
Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112613|0   |1
is obsolete||

--- Comment #623 from Aleisha Amohia  ---
Created attachment 113195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113195=edit
Bug 19532: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944

--- Comment #1 from Andrew Fuerste-Henry  ---
Created attachment 113194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113194=edit
Bug 26944: Point help link to automatic item mod in manual

To test:
1 - go to automatic item mod, click help, end up at manual homepage
2 - apply patch, restart, reload page
3 - click link again, go to auto item mod in manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272

David Nind  changed:

   What|Removed |Added

 Attachment #113135|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 113193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113193=edit
Bug 24272: add check_sysprefs_cache.pl

This script ensure that no sysprefs have been changed directly in the database
and/or
that the cache has not become corrupted. We have occasionally seen this happen
on production sites

To test:
1 - In the staff interface go to Administration
2 - Search for system preference 'IntranetUserJS'
3 - Add content to the syspref:
console.log('Hi!');
4 - On the command line launch mysql
sudo koha-mysql kohadev
5 - Alter the syspref directly
UPDATE systempreferences SET value = "console.log('Bye!');" WHERE variable
= 'IntranetUserJS';
6 - run the script
perl misc/maintenance/check_syspref_cache.pl
7 - You are warned about the altered system preference

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272

--- Comment #6 from David Nind  ---
Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26944] New: Help link from automatic item modification by age should go to the relevant part of the manual

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944

Bug ID: 26944
   Summary: Help link from automatic item modification by age
should go to the relevant part of the manual
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The Help link from automatic_item_modification_by_age.pl just goes to the
manual home page. It should go to
https://koha-community.org/manual//latest/en/html/tools.html#automatic-item-modifications-by-age
(or the proper version).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112690|0   |1
is obsolete||

--- Comment #116 from Lari Taskula  ---
Created attachment 113192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113192=edit
Bug 18595: (follow-up) Disable transports if missing contact information

To test:
Make sure you have enabled the following system preferences:
- opacuserlogin
- EnhancedMessagingPreferences
- EnhancedMessagingPreferencesOPAC
- SMSSendDriver

 GENERAL 
1. Apply patch

 PREREQUISITES 
1. Select a patron to test this patch with
2. Remove patron's primary email
3. Remove patron's SMS number

 OPAC 
1. Login to OPAC with your test patron.
2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl).
3. Observe two warnings "Your user account is missing email address" and
   "Your user account is missing SMS number"
4. See that the SMS and Email checkboxes are disabled in the messaging
   preferences table.
5. At the bottom of the page, set SMS number
6. Refresh page, observe only one warning "Your user account is missing
   email address" and observe the SMS checkboxes are now clickable.
7. Give your test patron a primary email address
8. Refresh OPAC "your messaging" page
9. Observe all warnings are now gone and both SMS number and Email checkboxes
   in the messaging preferences table are clickable.
10. Set patron some messaging preferences and make sure your change applies.

 INTRANET 
1. Repeat "OPAC" steps but instead of "your messaging" page, use the
   "Modify patron" view.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #269 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #219)
> Hi Kyle,
> 
> tests pass, but there is a db error when you run them:
> 
> [2020-09-12 21:06:37.69672] [26709] [debug] POST
> "/api/v1/biblios/XXX/volumes" (57471cdc)
> [2020-09-12 21:06:37.69813] [26709] [debug] Routing to controller
> "Koha::REST::V1::Auth" and action "under"
> [2020-09-12 21:06:37.72833] [26709] [debug] Routing to controller
> "Koha::REST::V1::Biblios::Volumes" and action "add"
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> execute failed: Cannot add or update a child row: a foreign key constraint
> fails (`koha_kohadev`.`volumes`, CONSTRAINT `volumes_ibfk_1` FOREIGN KEY
> (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON
> UPDATE CASCADE) [for Statement "INSERT INTO `volumes` ( `biblionumber`,
> `created_on`, `description`, `display_order`, `updated_on`) VALUES ( ?,
> NOW(), ?, ?, current_timestamp )" with ParamValues: 0=0, 1="Vol 1", 2=1] at
> /home/vagrant/kohaclone/Koha/Object.pm line 166
> [2020-09-12 21:06:37.73397] [26709] [debug] 409 Conflict (0.037233s,
> 26.858/s)
> ok 5 - POST
> //jFfMRdUyfmSrbUO5TWioGEhp2HSDQXGSqy01hFdFW0DUU9utfXIyBXUNR:thePassword123@/
> api/v1/biblios/XXX/volumes
> ok 6 - SWAGGER3.2.1
> ok 2 - volumes add() tests
> 
> Can you please check?

That error is expected, as we are testing adding a volume for an invalid
biblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #267 from Kyle M Hall  ---
Created attachment 113190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113190=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26931] Volumes tab should show all volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26931

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Kyle M Hall  ---
Fixed in the parent bug patch set, as it has not yet been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #265 from Kyle M Hall  ---
Created attachment 113188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113188=edit
Bug 24857: (QA follow-up) Add volume to table settings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #268 from Kyle M Hall  ---
Created attachment 113191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113191=edit
Bug 24857: (QA follow-up) Fix unit tests and code for changes in
Koha::Item::delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #264 from Kyle M Hall  ---
Created attachment 113187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113187=edit
Bug 24857: Change button text from "Create new" to "New volume"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #266 from Kyle M Hall  ---
Created attachment 113189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113189=edit
Bug 24857: (QA follow-up) Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #263 from Kyle M Hall  ---
Created attachment 113186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113186=edit
Bug 24857: Fix sorting of new syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #260 from Kyle M Hall  ---
Created attachment 113183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113183=edit
Bug 24857: Add missing filter and move js to footer on additem.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #261 from Kyle M Hall  ---
Created attachment 113184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113184=edit
Bug 24857: Fix simple-quote string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #262 from Kyle M Hall  ---
Created attachment 113185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113185=edit
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #259 from Kyle M Hall  ---
Created attachment 113182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113182=edit
Bug 24857: Fix POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #257 from Kyle M Hall  ---
Created attachment 113180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113180=edit
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #258 from Kyle M Hall  ---
Created attachment 113181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113181=edit
Bug 24857: Fix license statements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #256 from Kyle M Hall  ---
Created attachment 113179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113179=edit
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #253 from Kyle M Hall  ---
Created attachment 113176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113176=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #251 from Kyle M Hall  ---
Created attachment 113174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113174=edit
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #255 from Kyle M Hall  ---
Created attachment 113178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113178=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #254 from Kyle M Hall  ---
Created attachment 113177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113177=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #252 from Kyle M Hall  ---
Created attachment 113175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113175=edit
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #249 from Kyle M Hall  ---
Created attachment 113172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113172=edit
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #250 from Kyle M Hall  ---
Created attachment 113173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113173=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #247 from Kyle M Hall  ---
Created attachment 113170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113170=edit
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #246 from Kyle M Hall  ---
Created attachment 113169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113169=edit
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #248 from Kyle M Hall  ---
Created attachment 113171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113171=edit
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #113137|0   |1
is obsolete||
 Attachment #113138|0   |1
is obsolete||
 Attachment #113139|0   |1
is obsolete||
 Attachment #113140|0   |1
is obsolete||
 Attachment #113141|0   |1
is obsolete||
 Attachment #113142|0   |1
is obsolete||
 Attachment #113143|0   |1
is obsolete||
 Attachment #113144|0   |1
is obsolete||
 Attachment #113145|0   |1
is obsolete||
 Attachment #113146|0   |1
is obsolete||
 Attachment #113147|0   |1
is obsolete||
 Attachment #113148|0   |1
is obsolete||
 Attachment #113149|0   |1
is obsolete||
 Attachment #113150|0   |1
is obsolete||
 Attachment #113151|0   |1
is obsolete||
 Attachment #113152|0   |1
is obsolete||
 Attachment #113153|0   |1
is obsolete||
 Attachment #113154|0   |1
is obsolete||
 Attachment #113155|0   |1
is obsolete||
 Attachment #113156|0   |1
is obsolete||
 Attachment #113157|0   |1
is obsolete||
 Attachment #113158|0   |1
is obsolete||
 Attachment #113159|0   |1
is obsolete||
 Attachment #113160|0   |1
is obsolete||

--- Comment #245 from Kyle M Hall  ---
Created attachment 113168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113168=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112607|0   |1
is obsolete||

--- Comment #116 from Aleisha Amohia  ---
Created attachment 113167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113167=edit
Bug 14242: (follow-up) Remove well class, weird gap, fix clear form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112606|0   |1
is obsolete||

--- Comment #115 from Aleisha Amohia  ---
Created attachment 113166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113166=edit
Bug 14242: Remove TT conditional from HTML tags

It brakes the translation script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112604|0   |1
is obsolete||

--- Comment #113 from Aleisha Amohia  ---
Created attachment 113164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113164=edit
Bug 14242: (follow-up) Adding publication year hint and fix js translations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112605|0   |1
is obsolete||

--- Comment #114 from Aleisha Amohia  ---
Created attachment 113165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113165=edit
Bug 14242: (QA follow-up) Fix buttons for new bootstrap version

Stole the mark-up from bug 26478.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112602|0   |1
is obsolete||

--- Comment #111 from Aleisha Amohia  ---
Created attachment 113162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113162=edit
Bug 14242: (follow-up) Move English strings out of JavaScript

In order for English strings to be translatable they must be defined in
the template, not in the JS file.

Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112603|0   |1
is obsolete||

--- Comment #112 from Aleisha Amohia  ---
Created attachment 113163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113163=edit
Bug 14242: Styling of buttons, get copyright date, fixing plugin comment

And other code-y bits. Addressing comments in Comment 59.

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

--- Comment #28 from Alex Buckley  ---
Created attachment 113161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113161=edit
Bug 25560: Unit tests

Test plan:
1. Run tests
sudo koha-shell 
prove xt
prove t
prove t/db_dependent/Circulation/issue.t
prove t/db_dependent/Koha/Object.t

Sponsored-By: Waikato Institute of Technology, NZ

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Alex Buckley  changed:

   What|Removed |Added

 Attachment #112887|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #244 from Kyle M Hall  ---
Created attachment 113160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113160=edit
Bug 24857: (QA follow-up) Fix unit tests and code for changes in
Koha::Item::delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #243 from Kyle M Hall  ---
Created attachment 113159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113159=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #242 from Kyle M Hall  ---
Created attachment 113158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113158=edit
Bug 24857: (QA follow-up) Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #240 from Kyle M Hall  ---
Created attachment 113156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113156=edit
Bug 24857: Change button text from "Create new" to "New volume"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #241 from Kyle M Hall  ---
Created attachment 113157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113157=edit
Bug 24857: (QA follow-up) Add volume to table settings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #239 from Kyle M Hall  ---
Created attachment 113155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113155=edit
Bug 24857: Fix sorting of new syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >