[Koha-bugs] [Bug 27084] Cron Daemon Email

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27084

--- Comment #13 from Faiz Ahmed  ---
Hello David,

I'm constantly receiving the below email at my email address.

From: Cron Daemon 
Sent: Wednesday, November 4, 2020 1:00 PM
To: root@catalog.localdomain 
Subject: Cron  cd /tmp && koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/process_message_queue.pl

Use of uninitialized value $mail{"Bcc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Bcc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 544,  chunk 13.
Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at
/usr/share/perl5/Mail/Sendmail.pm line 545,  chunk 13.
Use of uninitialized value $mail{"Bcc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Bcc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 253.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 254.
Use of uninitialized value $mail{"Cc"} in substitution (s///) at
/usr/share/perl5/Mail/Sendmail.pm line 544,  chunk 13.
Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at
/usr/share/perl5/Mail/Sendmail.pm line 545,  chunk 13.

I tried various things but none of them worked. 
Initially I installed 19.05.05.000, but then later migrated to the newer
verion, but still.. no solution..

Any clue would be extremely helpful for me, as it is extremely annoying to have
my inbox full with these email every morning.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27161] Base.pm complains about unitialized value

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161

--- Comment #3 from Alvaro Cornejo  ---
Comment on attachment 114295
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114295
test patch

>--- Base.pm.orig   2020-12-09 22:11:25.639834095 -0500
>+++ Base.pm2020-12-07 19:41:17.903081236 -0500
>@@ -179,7 +179,9 @@
> 
> #FIXME: Why another encoding issue? For metadata containing non latin 
> characters.
> my $metadata = $self->{metadata};
>+if ( $metadata  & $metadata !~ "")  {
>   utf8::decode($metadata->{$_}) for keys %$metadata;
>+  }
> return $metadata;
> }
>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27161] Base.pm complains about unitialized value

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161

--- Comment #2 from Alvaro Cornejo  ---
Created attachment 114295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114295=edit
test patch

Hope is OK.

It does not fully avoid the "uninitialized value in subroutine" error but
greatly reduces the number of errors.

Patch against 19.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27184] Make the circulation history use the API

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27184

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #5 from Kelly McElligott  ---
Hi,
I have gone through your test plan and at step 4- after checking the item in
and confirming the hold, the item does not get removed from the Holds Queue,
instead, the hold stays on the Holds queue, but the item also shows waiting for
the patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956

Kelly McElligott  changed:

   What|Removed |Added

 Attachment #114088|0   |1
is obsolete||

--- Comment #2 from Kelly McElligott  ---
Created attachment 114294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114294=edit
Bug 26956: Allow guarantor's controls to be set when a guarantee is created

With AllowStaffToSetCheckoutsVisibilityForGuarantor and
AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the
controls for these values in the patron record *after* the patron has been
saved
with a guarantor. That makes a frustrating 2-step process. We should be able to
set those values regardless of whether or not there is currently a guarantor on
the account.

Test plan:
Create a guarantee and confirm that the 2 options "Show checkouts to
guarantors" and "Show fines to guarantors" are displayed
Select Yes, save
Confirm that the values have been correctly saved

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956

Kelly McElligott  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27186] Identify specific Patron Categories to not be allowed to be renewed

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27186

Katharine Dixon  changed:

   What|Removed |Added

 CC||katha...@ci.salinas.ca.us

--- Comment #1 from Katharine Dixon  ---
We really would like this for Temporary card patrons, they don't yet have good
proof of address or have lost their ID.  We would give them time to return and
rectify the situation. But if they don't return in 6 months we would like to
not have that "easy click" to renew them.  We would like them to expire
quietly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953

Lucas Gass  changed:

   What|Removed |Added

 Attachment #114090|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 114293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114293=edit
Bug 26953: Hide phone and itiva from "Overdue notice/status triggers"

If the prefs are off we should not display the checkboxes

Test plan:
1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification
2. Go to the "Overdue notice/status triggers" and confirm that phone and
itiva columns are not displayed
3. Turn the prefs on and confirm the checkboxes are now displayed

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #5 from Lucas Gass  ---
> I don't *see* them in the notice editor if the prefs are off.

Confirmed, I do not see them either when the prefs are off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27168] Most popular doesn't always sort correctly

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27168

--- Comment #8 from Katrin Fischer  ---
Thx Lucas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27165] Online Resource link displays as HTML in OPAC MARC view

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27165

--- Comment #1 from Katrin Fischer  ---
How was the link catalogued in this case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27049] It would be helpful to have a bulk waive of debts tool

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #3 from Lucas Gass  ---
Martin,

This seems pretty handy! Is there a test plan I can follow?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153

--- Comment #4 from Katrin Fischer  ---
I don't mind a simple solution, but can you explain the difference?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #43 from David Cook  ---
(In reply to Jonathan Druart from comment #42)
>
> Changes to kohastructure.sql are still needed.

Ah, so is this change just about synchronizing kohastructure.sql with the
output of a schema only koha-dump? Mostly just so RMs can do a sanity check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #88 from David Cook  ---
Thanks, Jonathan. I've been swamped so hadn't gotten around to it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27160] Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160

--- Comment #2 from David Cook  ---
(In reply to Jonathan Druart from comment #1)
> I don't recreate on master. Please provide more detail if you do. What is
> the exact error?

Oh, I may have not described it correctly. Try deleting the
ReservesMaxPickUpDelay system preference completely. That was the actual
situation I was facing...

As for the exact error, it's one of those Plack errors where you just see
"Internal Server Error". 

It happens when $max_pickup_delay is undef in "$expirationdate->add(days =>
$max_pickup_delay);" in Koha::Hold I believe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27168] Most popular doesn't always sort correctly

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27168

Lucas Gass  changed:

   What|Removed |Added

 Attachment #114286|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 114292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114292=edit
Bug 27168: Sort most popular by number of issues desc

It seems that there is a weird behavior when the title is used as a
second sort

Test plan:
Turn on OpacTopissue
Make sure the table always displays entries sorted by number of issues
desc

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27168] Most popular doesn't always sort correctly

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27168

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245

--- Comment #57 from David Cook  ---
Regarding my above comments, while I have ambitions for a bespoke task
scheduler, Martin is correct that it is unlikely that I am going to write such
a task scheduler any time soon. (I'm really valuing my work-life balance.)

As a result, I suppose I'm open to ideas. This bug is immediately practical.

However, it would be nicer to have the plugins use a unified Koha scheduler
rather than one special for plugins. 

To that end, Martin's idea for a database table that tracks tasks and execution
time, and then having a scheduler (either cron-based or a separate daemon) to
poll that database table for tasks every 1 minute is probably reasonable. I'm
not going to work on it, but I can support that idea. 

It's a fine line between practical and technical debt but... I think we need
some kind of scheduling.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941

Lucas Gass  changed:

   What|Removed |Added

 Attachment #113303|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 114291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114291=edit
Bug 26941: Fix OPAC password recovery error messages

In OPAC password recovery perl opac/opac-password-recovery.pl
there are some error codes not in Template
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt

This patch fixes several bugs:
- remove 'use Koha::Patrons' defined twice
- remove vars $errTooManyEmailFound $errBadEmail, not used in any template
- add in template text for error 'errNoBorrowerEmail'

1) Create a patron A with login but no email
2) Create a patron B with login and valid email
3) Go to system preferences set 'OpacResetPassword' to ON
4) Make sure that OpacPasswordChange is also ON
5) Go to 'Forgot your password' in OPAC
6) Enter login if patron A and save
=> You get message 'This account has no email address we can send the email
to.'
7) Enter login if patron B and save
=> Password recovery is send, no error message

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941

--- Comment #6 from Lucas Gass  ---
> I think you need to set a real email adress into preference
> 'KohaAdminEmailAddress'.
> You may test without my patch first
> 
> Thanks a lot for testing :D

That is correct, if I use a real email address I get no such error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245

--- Comment #56 from David Cook  ---
Oh, another point about not using cron-based schedulers. Cron is a royal pain
when you're working with containers. It would nice not to be continually wedded
to a 1970s technology...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245

--- Comment #55 from David Cook  ---
(In reply to Martin Renvoize from comment #54)
> Yes, a task scheduler would be
> great, but I really didn't want to wait another 10 years whilst people made
> up their mind on how to implement one.

Very fair point.

> 
> Task Schedular != Task Queue
> 

Also very true.

> As for the task queue, now I've looked at it.. I'm rather disappointed that
> it's hardcoded to a list of tasks, doesn't allow for parallelism, doesn't
> offer retries or failure states, doesn't even allow for multiple workers? 

I'm disappointed by the same things, but no one (myself included) was willing
to work on those things. That said, it shouldn't be too hard to refactor (brand
new code...) to have a more dynamic list of potential tasks and using multiple
workers would be fairly trivial to add too. I haven't looked at the code
recently enough to remember how it handles retries/failures, but that's
something that would be fairly app specific anyway I think, so something that
can certainly grow over time.

These are changes I want to make at some point, but I don't have the resources
to do them. 

> Perhaps I was spoilt with Minion in previous projects.. personally I would
> have loved to have simply adopted it.. 

I wasn't super fond of Minion when it was first mentioned, although recently I
was re-reading the documentation and it is more full featured than I originally
thought. It probably would have been sufficient. In hindsight, we probably
should have gone that route. Considering the "sunk cost fallacy", perhaps we
should still go that way. Even in terms of sunk cost, we haven't actually
invested too much in RabbitMQ yet.

(Regarding RabbitMQ, I like how we can use a standard messaging protocol, which
gives us language agnosticism - it would be nice to use more task-appropriate
languages rather than just using Perl for everything. I like how it's scalable,
although few Koha instances need to scale. These days, you can use a managed
RabbitMQ via AWS, so you don't even have to maintain that infrastructure, if
you have the budget.)

> I thought the biggest thing against
> it was that it recommends the use or Mojo::Pg as the backend and we use
> MySQL 

I think that was one of the "cons", but when it was first mentioned I also
don't think that Koha had really adopted Mojolicious as fully as it has now. I
think there was still a fair bit of skepticism about Mojolicious at that point
in time.

> what's the difference in requiring people to install RabbitMQ vs
> requiring them to install Postgres?... 
> there is also a well maintained MySQL
> backend that implements a clever form of PubSub to get around the fact that
> MySQL doesn't do pubsub natively.
> 

I think it's a bit absurd to require 2 different relational databases on the
face of it, but that's a fair point from a technical perspective. I've noticed
the MySQL backend as well and it seems reasonable enough at a glance.

> As for a simpler scheduler.. why not just keep a list of tasks and execution
> times akin to cron in a table and query it every minute.. the exact same way
> cron does... and leave FIFO tasks to the queue implementation we've now got.

Many years ago, Galen and I talked about keeping a list of tasks and execution
times in a table and having a cronjob run every minute to examine the times and
run the tasks, but no one got around to doing it. Personally, I'm more
ambitious than that now and have had use cases that required scheduling
granularity of less than 1/minute. However, my ambitions certainly outstrip the
time/energy that I have available. Even though I have the technical ability, I
don't have the logistical resources to get it done in a timely way. 

Now I'm just being pedantic, but the simple scheduler proposal is different to
cron. If I recall correctly, cron keeps all the tasks in memory, and it only
does I/O when it detects a change to a crontab. But polling a database every
1/minute isn't a drama. It's a scheduler that wouldn't work for some of my use
cases, but it would meet the majority of Koha's needs, so it's probably the way
to go.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.07
released in||

--- Comment #7 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #230 from Andrew Fuerste-Henry  ---
New feature not backported to 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 CC||and...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #20 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Tomás Cohen Arazi  ---
I agree with the solution and also with the follow-up bug on 18729.

This is giving a weird error if the user doesn't have permissions. The right
thing would be to completely disable the dropdown IMHO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

--- Comment #50 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 Status|Pushed to master|Pushed to stable
 CC||and...@bywatersolutions.com

--- Comment #21 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||and...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.07
released in||

--- Comment #29 from Andrew Fuerste-Henry  ---
Backported to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #30 from Andrew Fuerste-Henry  ---
Doesn't apply cleanly to 20.05, please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #149 from Andrew Fuerste-Henry  ---
Enhancement, not backported to 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25313] Add optional skip_merge parameter to ModAuthority

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25313

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25313] Add optional skip_merge parameter to ModAuthority

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25313

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 Status|Pushed to master|Pushed to stable
 CC||and...@bywatersolutions.com

--- Comment #11 from Andrew Fuerste-Henry  ---
Backported to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27187] Cannot delete/update local cover image with LocalCoverImages off

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27187

Ed Veal  changed:

   What|Removed |Added

 CC||ev...@mckinneytexas.org

--- Comment #1 from Ed Veal  ---
If you use different sources for OPAC and staff side and there are cover images
that appear on the staff side but there is not one available for the OPAC you
have to turn both system preference on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27187] New: Cannot delete/update local cover image with LocalCoverImages off

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27187

Bug ID: 27187
   Summary: Cannot delete/update local cover image with
LocalCoverImages off
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When the LocalCoverImages syspref is set to "Don't display," Koha hides the
image itself as well as the Images tab on the bib details page. However, if a
library has OPACLocalCoverImages on, they'll likely want to access that Images
tab to delete or change the images they're displaying on the OPAC.

Could we hide the tab only if *both* sysprefs are off?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27186] New: Identify specific Patron Categories to not be allowed to be renewed

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27186

Bug ID: 27186
   Summary: Identify specific Patron Categories to not be allowed
to be renewed
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

All patron categories are renewable in Koha.  Once a patron has expired, the
staff can easily renew this patron.  

A library has a scenario that would like Koha to not allow a specific patron
category from being renewed. This patron category is temporary and they would
like to have staff not have the option to renew them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27185] Make the rotating collections list use the API

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27185

Michal Denar  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io,
   ||blac...@gmail.com,
   ||gmcha...@gmail.com,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||josef.mora...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com, r...@rbit.cz,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27185] New: Make the rotating collections list use the API

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27185

Bug ID: 27185
   Summary: Make the rotating collections list use the API
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Work with rotating collecion is slow with bigger numbers of records:
/cgi-bin/koha/rotating_collections/rotatingCollections.pl

API can solve this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||and...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.07
released in||

--- Comment #6 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #6 from Andrew Fuerste-Henry  ---
backported to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26846] serial-collections page should select the expected and late serials automatically

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26846

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26846] serial-collections page should select the expected and late serials automatically

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26846

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 Status|Pushed to master|Pushed to stable
 CC||and...@bywatersolutions.com

--- Comment #7 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code.

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #6 from Andrew Fuerste-Henry  ---
Missing dependencies, not backported to 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #6 from Andrew Fuerste-Henry  ---
Missing dependencies, not backporting to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27177] t/db_dependent/api/v1/holds.t failing after bug 26988

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177
Bug 27177 depends on bug 26988, which changed state.

Bug 26988 Summary: Defer loading the hold pickup locations until the dropdown 
is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27016] Make the pickup locations dropdowns use Select2

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016
Bug 27016 depends on bug 26988, which changed state.

Bug 26988 Summary: Defer loading the hold pickup locations until the dropdown 
is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27015] Add filtering options to the pickup_locations routes

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015
Bug 27015 depends on bug 26988, which changed state.

Bug 26988 Summary: Defer loading the hold pickup locations until the dropdown 
is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27002] Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002
Bug 27002 depends on bug 27021, which changed state.

Bug 27021 Summary: Chaining on Koha::Objects->empty should always return an 
empty resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27021

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27021] Chaining on Koha::Objects->empty should always return an empty resultset

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27021

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

--- Comment #11 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable
 Version(s)|20.11.00, 20.05.07  |20.11.00, 20.05.07,
released in||19.11.13

--- Comment #45 from Victor Grousset/tuxayo  ---
Backported to 19.11.x branch for 19.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27184] Make the circulation history use the API

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27184

Michal Denar  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io,
   ||blac...@gmail.com,
   ||frede...@tamil.fr,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||josef.mora...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com, r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26986] Second try to prevent Selenium's StaleElementReferenceException

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26986

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.11.00|20.11.00, 20.05.07
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26986] Second try to prevent Selenium's StaleElementReferenceException

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26986

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27184] New: Make the circulation history use the API

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27184

Bug ID: 27184
   Summary: Make the circulation history use the API
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Circulation history of heavy borrowers or anomym accounts can be very long
after couple of years, so it takes long time to load them. API pagination can
help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26903] Authority records not being indexed in Elasticsearch

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903

--- Comment #9 from Andrew Fuerste-Henry  ---
Doesn't apply cleanly to 20.05, please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27183] Make suggestions management use the API

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27183

Michal Denar  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io,
   ||blac...@gmail.com,
   ||frede...@tamil.fr,
   ||gmcha...@gmail.com,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||josef.mora...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com, r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27183] New: Make suggestions management use the API

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27183

Bug ID: 27183
   Summary: Make suggestions management  use the API
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Suggestions list can be very long after couple of years, so it takes long time
to load them. Especially
/cgi-bin/koha/suggestion/suggestion.pl?branchcode=__ANY__#ASKED. API pagination
can solve this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27002] Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002

--- Comment #18 from Andrew Fuerste-Henry  ---
Enhancement, not backporting to 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26516] Importing records with unexpected format of copyrightdate fails

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26516

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26516] Importing records with unexpected format of copyrightdate fails

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26516

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.07
released in||

--- Comment #9 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25471] Add DataTables to MARC subfield structure admin page for bibliographic frameworks

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25471

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27021] Chaining on Koha::Objects->empty should always return an empty resultset

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27021

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27021] Chaining on Koha::Objects->empty should always return an empty resultset

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27021

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 Status|Pushed to master|Pushed to stable
 CC||and...@bywatersolutions.com

--- Comment #10 from Andrew Fuerste-Henry  ---
Pushed to 20.05 for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.07
released in||

--- Comment #44 from Andrew Fuerste-Henry  ---
Backported to 20.05 for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27178] OPAC results and lists pages contain invalid attributes (xmlns:str="http://exslt.org/strings")

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27178

Martin Renvoize  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #18 from David Nind  ---
Hi Arthur. 

Apologies for taking so long to get back to this (and work out what this was
about!).

I've read the description properly now and bug 19294, so the aim is to make
sure that if using ILS-DI the "On shelf holds allowed" options for circulation
and fines rules are correctly applied - at the moment they aren't.

Here is an updated test plan - I've worked through it and everything works as
expected. (I'm not sure I've made the test plan better, but it covers both the
staff interface and using ILS-DI.)

Suggested updated test plan
===

The expected behaviour for "On shelf holds allowed" setting for the circulation
rules (Koha administration > Patrons and circulation > Circulation and fines
rules):
- Allow holds only on items that are currently checked out or otherwise
unavailable.
- If set to "Yes", patrons can place holds on items currently checked in.
- If set to "If any unavailable", patrons can only place holds on items that
are not unavailable.
- If set to "If all unavailable", patrons can only place holds on items where
*all* items on the record are unavailable.
(Adapted from
https://bywatersolutions.com/education/preparing-for-library-closures)

These rules should also work when using ILS-DI, but currently they don't. This
bug makes sure that the "On shelf holds allowed" rules work correctly when
using ILS-DI to place holds.

Test plan:

1. Enable ILS-DI (set the ILS-DI system preference to Enable).
2. Go to Koha administration > Patrons and circulation > Circulation and fines
rules.
3. Work through steps 4-5 for each of the settings for "On shelf holds allowed"
for all libraries/patron categories/item types:
   . "Yes", "If any unavailable", and "If all unavailable" 
4. Staff interface - place a hold on a record with items available for loan,
the rules should work as expected before and after the patch is applied:
   . "Yes"
  ==> information column in the item table displays "Not on hold", the hold
is placed, cancel the hold
   . "If any unavailable" and "If all unavailable"
  ==> the hold is not placed, message is "Cannot place hold. No items are
available to be placed on hold.", red "X" in the hold column and the
information column displays "Not on hold".
5. ILS-DI - place a hold on a record with items available for loan (note:
without the patch, holds can be placed):
   . Query to place a hold using ILS-DI on a title that have all its items
available, 
 example query:
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1_id=1_location=127.0.0.1
 ==> Without the patch the hold is placed but it shouldn't be allowed,
cancel the hold
   . Query to place a hold using ILS-DI on an available item, 
 example query:
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem_id=1_id=1_id=1)
 ==> Without the patch the hold is placed but it shouldn't be allowed,
cancel the hold
6. Run the tests prove t/db_dependent/Reserves.t - these should pass.
7. Apply the patch (and flush_memcached and restart_all if using
koha-testing-docker).
8. Run through steps 3-6 again, and note the changes when "If any unavailable"
and "If all unavailable" options are used:
   . For the staff interface: there should be no change in behavour and should
work as expected, for the red "X" in the items table additional text is added
"onShelfHoldsNotAllowed".
   . For ILS-DI: these should now work as expected, with holds not placed, and
this message in the results returned onShelfHoldsNotAllowed (check
to confirm no holds place for either the patron or the item)
   . Tests: should still pass.
9. Sign off.

Changes
===

Tests fail
~~

The number of tests need updating from 66 to 67 (the tests pass if I update
this myself):

ok 67 - MergeHolds
# Looks like you planned 66 tests but ran 67.
Dubious, test returned 255 (wstat 65280, 0xff00)
All 66 subtests passed 

Test Summary Report
---
t/db_dependent/Reserves.t (Wstat: 65280 Tests: 67 Failed: 1)
  Failed test:  67
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 66 tests but ran 67.
Files=1, Tests=67,  8 wallclock secs ( 0.05 usr  0.01 sys +  6.65 cusr  0.93
csys =  7.64 CPU)
Result: FAIL

Wording change suggestion
~

I didn't notice any change in behaviour except for Step 4 with the patch
applied, red "X onShelfHoldsNotAllowed".

I would prefer to see a human readable message for the staff interface, rather
than the code "onShelfHoldsNotAllowed", maybe "Holds not allowed for items on
shelves" or "Holds not allowed for items available".

Happy to sign off once tests fixed.

David

-- 
You are receiving this mail because:
You are 

[Koha-bugs] [Bug 27182] New: Add ability to rename a MARC modification template

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182

Bug ID: 27182
   Summary: Add ability to rename a MARC modification template
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org

It would be helpful to add the ability to rename a MARC modification template. 
There are times when the name originally assigned isn't as descriptive as
desired.  While it is currently possible to use the 'New template' button to
duplicate the template and give it a new name that's not very obvious.  And
then the old template would need to be deleted.  This takes time and it would
be more efficient to have a button or action from the main MARC modification
template screen for renaming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148

--- Comment #11 from Agustín Moyano  ---
Created attachment 114290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114290=edit
Bug 27148: (follow-up) Fix require_strong variable set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #4 from Victor Grousset/tuxayo  ---
It works :)

Testing notes:
https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup#Example

./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \
-l CPL --patron 23529001000463 -m checkout --item 301259

Same command for 1) and 2) and 6)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #109188|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 114289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114289=edit
Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message

If a renewal via SIP cannot be made because the patron has reached the maximum
number of renewals,
the AF screen message should read "Item has reached maximum renewals!",
instead we get "Item checked out to another patron".

Test Plan:
1) Check out an item to a patron
2) Using the SIP CLI tool, run checkout messages until the checkout has
   reached the maximum number of renewals
3) Note the incorrect message in the AF field
4) Apply this patch
5) Restart the SIP server
6) Run another SIP checkout message
7) Note the message is now correct!

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25033] Counts of suggestions are confusing

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033

Christopher Davis  changed:

   What|Removed |Added

 CC||tubaclari...@protonmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27181] New: Rotating collection holds control

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27181

Bug ID: 27181
   Summary: Rotating collection holds control
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently we have a library that is closed during COVID.  We have some of the
items from that library at our library as a rotating collection.  When we
stopped all holds using the default hold policy for that library, the items in
the rotating collection were not holdable.

We should consider an exception for items that are rotating.  I would suggest a
default hold policy for rotating collections that would supersede the default
hold policy.

Currently, our only work around for this is to either individually block holds
on specific rules for the library, or transfer ownership of the items.  Neither
are ideal.  A rotating collections hold policy would be preferred and easier to
manage.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27097] Make Koha version number and date of update more obvious in staff interface

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27097

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27097] Make Koha version number and date of update more obvious in staff interface

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27097

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #27 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26742] Add configuration for message broker

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26742] Add configuration for message broker

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26742] Add configuration for message broker

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113906|0   |1
is obsolete||

--- Comment #6 from Victor Grousset/tuxayo  ---
Created attachment 114288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114288=edit
Bug 26742: Add configuration to koha-conf.xml for message broker

The connection details for the message broker should be configurable.
This patch adds configuration options to koha-conf.xml. If they
are not specified, then default connection details will be used.

Signed-off-by: Michal Denar 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245

--- Comment #54 from Martin Renvoize  ---
Firstly, this bug was all about adding the ability to just run a task added by
a plugin at regular intervals.. it was added to resolve the need to set up all
sorts of additional cron jobs for the various plugins out in the wild that
document 'when you install this plugin you also need to go on the server and
add x, y and z cron tasks'.  Yes, a task scheduler would be great, but I really
didn't want to wait another 10 years whilst people made up their mind on how to
implement one.

I wasn't even attempting to resolve the need for adding tasks to the FIFO task
queue... to me, that's a different process and bug entirely...

Task Schedular != Task Queue

As for the task queue, now I've looked at it.. I'm rather disappointed that
it's hardcoded to a list of tasks, doesn't allow for parallelism, doesn't offer
retries or failure states, doesn't even allow for multiple workers?  Perhaps I
was spoilt with Minion in previous projects.. personally I would have loved to
have simply adopted it.. I thought the biggest thing against it was that it
recommends the use or Mojo::Pg as the backend and we use MySQL what's the
difference in requiring people to install RabbitMQ vs requiring them to install
Postgres?... there is also a well maintained MySQL backend that implements a
clever form of PubSub to get around the fact that MySQL doesn't do pubsub
natively.


As for a simpler scheduler.. why not just keep a list of tasks and execution
times akin to cron in a table and query it every minute.. the exact same way
cron does... and leave FIFO tasks to the queue implementation we've now got.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597

--- Comment #6 from Caroline Cyr La Rose  ---
What can we do to take this out of the "In Discussion" limbo? It was already
signed off twice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #33 from Victor Grousset/tuxayo  ---
Now it is, thanks Martin! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27180] Fines cronjob does not update fines on holidays when finesCalendar is set to ignore

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||and...@bywatersolutions.com
   ||,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27180] Fines cronjob does not update fines on holidays when finesCalendar is set to ignore

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180

--- Comment #1 from Nick Clemens  ---
Created attachment 114287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114287=edit
Bug 27180: Update fines on holidays

This patch removes code that prevents fines from being update on holidays.
The fines are already being calculated, and that takes the calendar into
account if
needed, so fines won't be assessed on holidays if they shouldn't.

To test:
 1 - set finesCalendar to 'ignore'
 2 - Checkout an item due yesterday
 3 - Ensure circ rules have a fine amount set
 4 - Make today a holiday
 5 - run fines.pl
 6 - No fine assessed
 7 - Apply patch
 8 - run fines.pl
 9 - Fine assessed!
10 - set finesCalendar to 'use'
11 - checkout an item, due yesterday
12 - run fines.pl
13 - no fine assessed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27180] Fines cronjob does not update fines on holidays when finesCalendar is set to ignore

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27180] New: Fines cronjob does not update fines on holidays when finesCalendar is set to ignore

2020-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180

Bug ID: 27180
   Summary: Fines cronjob does not update fines on holidays when
finesCalendar is set to ignore
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The fines cronjob currently skips updating fines if the date it is run is a
holiday for the applicable library.

This is problematic when an item is marked lost the day following a holiday as
we can end up missing a day of fines. Additionally it confuses things for
libraries who do not expect the calendar to affect fines.

This seems to have been done when dropbox mode used calculations on the 'last
update' of a fine to determine how much to refund.

Now that dropbox mode simply calculates the fine with a different return date
this code is no longer needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >