[Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #20 from Timothy Alexis Vass --- (In reply to Joonas Kylmälä from comment #19) > Hi, > > - can you explain why only RETURNED fees? It would probably good to have > this explanation in the help documentation too. Some other fees that might > need to be removed also could be RENEWED and LOST? Please see > installer/data/mysql/mandatory/account_debit_types.sql, although it doesn't > contain every type of fee Koha generates currently. Statute-barred is a legal term. It is proper to say: "The fees have become statute-barred." According to Swedish statutes "perussäännöt", fees for library material are forbidden to claim after 3 years if the material has been returned. They are thus "statute-barred" as in "blocked by the fundamental rules of law". In the other situations "Renewed" and "Lost", it is different. Then the debt has been handed over to "Kronofogdemyndigheten", which is the Swedish Enforcement Agency. All 60+ Swedish libraries using Koha are required by Swedish law to remove statute-barred fees. Very likely, something similar will be required in some of the other 1000+ (?) libraries using Koha around our planet. > - Depending on your answer to the above question, would it make sense to > make the name of this option something more generic, like --unpaid-fees? The only thing that makes sense is to call it --statute-barred-fees because that is exactly what it is. They are not --unpaid-fees, they are not --expired-fees, they are not --old-fees, they are fees that have been barred according to ruling statutes. > - The commit title is still too long, see comment #4. Thank you. > - The code is now not in a function, i.e. cannot be tested. Would something > like Koha::Account::Lines::statute_barred (depending on the scope of this > function maybe a different name) sound good to you? Then you can call > ->delete or ->count on those and the code will look super cool in the > script, wouldn't it? :) Easy to maintain, simple code is preferred. I would suggest removing all this insane complexity and do database maintenance in the database, such as: CREATE EVENT cleanup_statute_barred_fees ON SCHEDULE EVERY 1 DAY DO DELETE FROM accountlines WHERE date < date_sub(curdate(), INTERVAL 1095 DAY) AND status = 'RETURNED' AND amountoutstanding > 0 Quite seriously, if you want to make it redundnantly complex because you find that interesting, you are free to make it happen. If your purpose here on the planet is to make yourself busy in other's efforts and to waste time, I advice you to take some time to think about how you can be a beneficial force for our commonwealth and coexistence here on Earth. > - The whitespace changes would still be nice to have, just in a separate > patch. Tip: add it as last in the series so any rebase conflicts will be > easier to resolve when you only need to redo the whitespace patch and not > also the feature patch. I can add them as another patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 --- Comment #2 from David Cook --- Created attachment 114319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114319=edit Bug 27198: Fix syntax in marc21-retrieval-info-auth-dom.xml This patch fixes the syntax in marc21-retrieval-info-auth-dom.xml, so that one can use the Zebra special retrieval elements documented at https://software.indexdata.com/zebra/doc/special-retrieval.html These are very useful when troubleshooting issues with authority records in Zebra. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 --- Comment #1 from David Cook --- Before patch: root@kohadevbox:koha(bug27198)$ yaz-client unix:/var/run/koha/kohadev/authoritysocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.000754 Z> base authorities Z> format xml Z> elements zebra::snippet Z> find e Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 21, setno 1 SearchResult-1: term=e cnt=21 records returned: 0 Elapsed: 0.002167 Z> show 1 Sent presentRequest (1+1). Diagnostic message(s) from database: [25] Specified element set name not valid for specified database -- v2 addinfo 'zebra::snippet' nextResultSetPosition = 2 Elapsed: 0.000218 Z> exit See you later, alligator. After patch: root@kohadevbox:koha(bug27198)$ yaz-client unix:/var/run/koha/kohadev/authoritysocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.000840 Z> base authorities Z> format xml Z> elements zebra::snippet Z> find e Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 21, setno 1 SearchResult-1: term=e cnt=21 records returned: 0 Elapsed: 0.002212 Z> show 1 Sent presentRequest (1+1). Records: 1 Record type: XML http://www.indexdata.com/zebra/;> Gontarski, S. E nextResultSetPosition = 2 Elapsed: 0.013929 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Cook changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] New: Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 Bug ID: 27198 Summary: Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au ./debian/templates/marc21-retrieval-info-auth-dom.xml is out-dated and should be synchronized with ./etc/zebradb/retrieval-info-auth-dom.xml The main issue is that the XML retrieval syntax is wrong which prevents a person from using the Zebra special retrieval elements documented at https://software.indexdata.com/zebra/doc/special-retrieval.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Alvaro Cornejo changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |cornejo.alv...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27175] Jenkins instance exposed to public
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27175 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I don't think that this is a genuine issue. If there is a documented security vulnerability, it should be reported as a security bug instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #26 from David Cook --- However, I defer to those people who actually *do* the translation work. I am not pretending that I know what is best. These are just ideas I have encountered in my other non-Koha projects, and none of those projects support as many translations/translators as Koha. So feel free to tell me to shut up ;). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #25 from David Cook --- Regarding the Java method, look at "Fetch the Text from the ResourceBundle" at https://docs.oracle.com/javase/tutorial/i18n/intro/steps.html. In my mind, we'd fetch the relevant translated string using a msgId in the Perl, and then we'd pass the translated string via a variable to the template. I think it would make templates look much cleaner and I think that it would make it easier to handle translations on the backend too. It could also potentially allow plugins to override the output to the template, but that's a whole other thing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #24 from David Cook --- (In reply to David Cook from comment #22) > (In reply to Owen Leonard from comment #21) > > If you're referring to the question of syntax, other projects I've seen do > > something similar. For instance in Drupal: > > > > > > > > Translatable strings are wrapped in the t() function. > > Drupal is an old project as well, and that example looks worrying. Based on > https://en.wikipedia.org/wiki/Drupal#Themes, it looks like that example must > be one of those "hard-coded PHP" templates. I wonder what they do in Drupal > 8+ with Twig. Admittedly, https://metacpan.org/pod/Catalyst::Plugin::I18N uses a similar method using l() instead of t(). I suppose I wouldn't mind t() that much (although the Java way of doing it is still better I think) if that were the only macro we were required to use, but Bug 26392 introduces t(), tx(), tnx(), txn(), tp(), tpx(), tnp(), tnpx(). In my opinion, it's a bit absurd to expect developers to use 8 different macros which look almost exactly the same. I think that it'll make front-end developments take 10x* as long, as QA will constantly need to be telling people to re-do their templates. But I could be wrong. Maybe we'll all get used to the 8 different macros. I was going to say that I'll probably just stop contributing template changes to Koha, but I guess I'm on the QA team these days, so I should probably memorize them. *arbitrary order of magnitude -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #23 from David Cook --- (In reply to Jonathan Druart from comment #19) > (In reply to David Cook from comment #18) > > Overall, I'll do whatever other people decide needs to be done, but I just > > worry that we're trying to re-invent the wheel sometimes and do things a > > harder way, when other projects have already sorted out internationalization > > more gracefully. > > How could we do that better? Do you have any suggestions? Suggestion 1: Referring back to https://developer.atlassian.com/server/framework/atlassian-sdk/pluralising-internationalisation-strings/, I think that we could do easy things like "Simplify the Message into a Plural-Independent Phrase". Suggestion 2: Use a token based i18n scheme like Java (which has a huge history in internationalization as it was the origin of ICU): https://docs.oracle.com/javase/tutorial/i18n/intro/steps.html Suggestion 3: Look at what others have done in Perl: https://metacpan.org/pod/Catalyst::Plugin::I18N https://metacpan.org/pod/Mojolicious::Plugin::I18N -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #22 from David Cook --- (In reply to Owen Leonard from comment #21) > If you're referring to the question of syntax, other projects I've seen do > something similar. For instance in Drupal: > > > > Translatable strings are wrapped in the t() function. Drupal is an old project as well, and that example looks worrying. Based on https://en.wikipedia.org/wiki/Drupal#Themes, it looks like that example must be one of those "hard-coded PHP" templates. I wonder what they do in Drupal 8+ with Twig. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26742] Add configuration for message broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #7) > 1. Wouldn't it make sense to keep "login" instead of "username" in the > koha-conf.xml? > I don't think so, since "username" is more standard than "login". It correlates better with the RabbitMQ documentation for instance (https://www.rabbitmq.com/access-control.html), so I think sysadmins and such would find username more user-friendly. > 2. You are adding a die in the ->connect method, is it really useful? > If $stomp->connect fails we already get an exception. I am very sure that $stomp->connect does not raise an exception when it fails without my patch. Without my patch, when would you get that exception? When it tries to subscribe? if that's the case, I think that's raising an exception too late. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27160 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27160] Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8367 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27160] Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160 --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #5) > Created attachment 114296 [details] [review] > Bug 27160: Prevent 500 when checking an item in if ReservesMaxPickUpDelay > has been deleted > > We could default to 0 if the syspref does not exist. > However I don't think we should deal with that kind of issue, sysprefs > must be in DB. > The default in sysprefs.sql is 7, so we might prefer that over 0. I'm not sure that we should deal with this kind of issue either. As you say, sysprefs must be in the database. I'd probably be fine marking this as invalid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27160] Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160 --- Comment #6 from David Cook --- (In reply to Jonathan Druart from comment #4) > In which situation ReservesMaxPickUpDelay got removed entirely from the DB? A library had applied Bug 8367 to a customized production instance. The patches for that bug removed ReservesMaxPickUpDelay. They then exported their database and tried to load it into a new non-customized Koha 19.11.x instance, and that's where they encountered the issue. I will admit that it's an extreme edge case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27084] Cron Daemon Email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27084 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE Version|20.05 |19.05 Status|REOPENED|RESOLVED --- Comment #15 from David Cook --- (In reply to Faiz Ahmed from comment #13) > > Any clue would be extremely helpful for me, as it is extremely annoying to > have my inbox full with these email every morning. > If you followed our advice and still have this problem, then you've failed to upgrade your Koha properly. My suggestion would be to seek paid support (https://koha-community.org/support/paid-support/), since this bug has already been fixed in Bug 24826, as Jonathan noted in November. I'm marking this bug report as a duplicate, since there's no evidence that there's a problem in an up-to-date Koha. *** This bug has been marked as a duplicate of bug 24826 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826 --- Comment #11 from David Cook --- *** Bug 27084 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26922] SendAlerts does not correctly handle error on sending emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26922 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||and...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.07 released in|| --- Comment #32 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.07 released in|| CC||and...@bywatersolutions.com --- Comment #54 from Andrew Fuerste-Henry --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27062] pickup_location tests don't deal correctly with existing libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05, please rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25514] REST/Plugin/Objects.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25514] REST/Plugin/Objects.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||and...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.07 released in|| --- Comment #13 from Andrew Fuerste-Henry --- Backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- I tried even though I don't know well these places ^^" > - Basic MARC editor Is it cataloguing/addbiblio.pl ? Because I don't have the JS error before applying the patch. And I don't field a field that look like a Select2. > - Authority editor Which field? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.07 released in|| --- Comment #7 from Andrew Fuerste-Henry --- Decided to backport this after all. It's not strictly dependent on 26172, applies fine without it. Backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26903] Authority records not being indexed in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26903] Authority records not being indexed in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.07 released in|| --- Comment #11 from Andrew Fuerste-Henry --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01, 20.05.07 released in|| --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.07 released in|| Status|Pushed to master|Pushed to stable --- Comment #17 from Andrew Fuerste-Henry --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27197] Empty information in libraries table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 114318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114318=edit In comparison, the libraries table with the same information in 20.05.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27197] Empty information in libraries table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 114317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114317=edit Libraries table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27197] New: Empty information in libraries table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197 Bug ID: 27197 Summary: Empty information in libraries table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I added an email address to a library and it caused the display to display everything even if this particular library had no information. (Sorry, I can't find a way to explain it, see screen capture...) To replicate : 1- Go to Administration > Libraries 2- Edit a library 3- Enter an email address (the library name and address line 1 were already filled in my db) 4- Save 5- See table, it's all stretched with empty information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11443] Refactoring code sending basket from OPAC/intra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443 --- Comment #4 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12643] Emailing cart should send more details view instead of simple view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12643 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #55 from Agustín Moyano --- Created attachment 114316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114316=edit Bug 18532: (follow-up) Fix notice message, add notice to all installer languages and fix preference message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #1 from Nick Clemens --- Internal server error mentioned is: Can't call method "holdingbranch" on an undefined value at /kohadevbox/koha/reserve/request.pl line 654 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27196 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27196 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21020, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27166 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27196] New: Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196
Bug ID: 27196
Summary: Waiting title level hold checked in at wrong location
via SIP leaves hold in a broken state and drops
connection
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
The problem occurs when we find a hold during SIP checkin - we check the
message form AddReturn for the hold value - but for a waiting hold at wrong
location the hold has been reverted and, in the case of a title level hold, has
no itemnumber
We partially succeed in setting the hold to transit and leave the hold in limbo
This is due to passing $messages->{ResFound}->{itemnumber} to ModReserveAffect
rather than $item->itemnumber which we have available
To recreate:
1 - Place a next available hold for delivery at library A
2 - Check the item in at library A to set it waiting
3 - Check the item in via SIP at library B
perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1
--item BARCODE -l FPL -m checkin
4 - The SIP emulator dies:
Use of uninitialized value $data in concatenation (.) or string at
misc/sip_cli_emulator.pl line 344, chunk 1.
READ:
5 - Check the hold in the db:
SELECT * FROM reserves WHERE itemnumber IS NULL and found IS NOT NULL;
5 - Try to load the biblio - ISE
Can't call method holdingbranch on an undefined object
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #19 from Tomás Cohen Arazi --- Hi, I'd like to mention that: - The idea of having a route to change the pickup location *only*, was meant so we could have a more granular permission set. So I expect this route to require something like "reserveforothers": "modify_pickup_location". That permission should be set on an atomicupdate to all users having place_holds, as per bug 27117. - I liked the idea of calling them 'pickup locations' instead of the already used 'pickup_library' (see the hold objects definition). I like the fact that we prepare for some future in which there could be other pickup locations (shelves? special lockers for sanitized materials on this new world?). With this in mind, I have two other comments to make: - The PUT verb is accepting (and returning) a string, that actually represents what we already call pickup_library_id, but named generically 'pickup location'. I suggest we drop this and in turn expect a JSON object, with a 'pickup_library_id' attribute, replicating the already used terminology. It will also allow us to add new options for the future. - I regret not proposing this before, but we should really have a class abstracting pickup locations, that could initially just be a wrapper for libraries, but with a ->to_api method that makes it return the pickup_library_id and the name. If we need more things, we can solve that through embedding (e.g. embed the library object altogether). This will allow us to have simpler routes for dropdowns (right now we should take care of 'private' attributes for such dropdowns in the OPAC, for example). About this last comment, I haven't polished the idea. But the main message is 'do not put any design constraint ourselves at this point'. And I'm willing to have the full discussion when appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27195] Set focus for cursor to city input box when creating new cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Owen Leonard changed: What|Removed |Added Keywords||Academy Component|System Administration |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27193] Set focus for cursor to patron attribute type code input box when creating new patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Owen Leonard changed: What|Removed |Added Keywords||Academy Component|System Administration |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27192] Set focus for cursor to item type input box when creating new item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Owen Leonard changed: What|Removed |Added Component|System Administration |Templates Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27191] Set focus for cursor to category code input box when creating new patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27191 Owen Leonard changed: What|Removed |Added Component|System Administration |Templates Version|20.05 |master Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26694 Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26694] Set focus for cursor to search input box on guarantor_search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26694 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27191 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #21 from Owen Leonard --- (In reply to David Cook from comment #18) > when other projects have already sorted out internationalization > more gracefully. If you're referring to the question of syntax, other projects I've seen do something similar. For instance in Drupal: Translatable strings are wrapped in the t() function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27062] pickup_location tests don't deal correctly with existing libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Bug 27062 depends on bug 26984, which changed state. Bug 26984 Summary: Tests are failing if AnonymousPatron is configured https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #21 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27144] Cannot delete any patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Bug 27144 depends on bug 14708, which changed state. Bug 14708 Summary: The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 Bug 26984 depends on bug 14708, which changed state. Bug 14708 Summary: The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24483] When batch deleting patrons, report who was not deleted and why
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483 Bug 24483 depends on bug 14708, which changed state. Bug 14708 Summary: The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #51 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27027] Typo: has successfully been modified.. %s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27027 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #22 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, shouldn't affect it then. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in||19.11.13 --- Comment #30 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27164] Fix item search CSV export
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Fridolin Somers --- My bad ;) Test plan fixed : 4.0) Compare files with diff/meld => you see double quotes arround header cells -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27164] Fix item search CSV export
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What|Removed |Added Attachment #114262|0 |1 is obsolete|| --- Comment #11 from Fridolin Somers --- Created attachment 114315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114315=edit Bug 27164: Fix item search CSV export In item search CSV export, data cells are exported with double quotes. There should also be double quotes in header cells. Also some spaces can be removed. Delimiter must be from system preference 'delimiter'. TT filter must be $raw not html, only double quotes must be espaped by duplication of it. This may help to open the CSV with any table/calc software. Test plan : 1.0) Create a record with title : Laurel & "Hardy" 1.2) Create an item on this record 2.0) Without patch 2.1) Perform an item search on title 'Laurel' 2.2) Export as a CSV file and save the file locally 2.3) Open the file with a table/calc software 3.0) Apply patch 3.1) Perform same item search 3.2) Export as a CSV file and save the file locally 3.3) Open the file with a table/calc software 4.0) Compare files with diff/meld => you see double quotes arround header cells and removal of space after coma 4.1) Check that delimiter is from system preference 'delimiter' 4.2) In table/calc software they should look the same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #6 from Fridolin Somers --- (In reply to Katrin Fischer from comment #4) > I don't mind a simple solution, but can you explain the difference? Elision removes the text : l'europe = europe This apostrophe filter creates : l'europe = leurope Wrong in french but surely ranking will bet better for the exact match. I have to test combined with ellision. But : Maybe it is bad for authorities : "Pierre d'Anjou" and Pierre Danjou". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27158] software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Component|OPAC|Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27195] New: Set focus for cursor to city input box when creating new cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Bug ID: 27195 Summary: Set focus for cursor to city input box when creating new cities Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When adding a new city on cities.pl you have to click in the city input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the city input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27194] Using Batch Patron Modification from Reporting Module is not working correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27194 Kelly McElligott changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27194] New: Using Batch Patron Modification from Reporting Module is not working correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27194 Bug ID: 27194 Summary: Using Batch Patron Modification from Reporting Module is not working correctly Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Using Batch Patron Modification from the Reporting Module is not working correctly Steps: 1. Create a report where you query borrower information including cardnumber. 2. Click the option to use batch operations, choosing Batch Patron Modification. 3. Get an error "CardNumber not found" because Koha has actually combined the values of all the patrons in the report into one card number instead of separate ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27193] New: Set focus for cursor to patron attribute type code input box when creating new patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Bug ID: 27193 Summary: Set focus for cursor to patron attribute type code input box when creating new patron attributes Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When adding a new patron attribute type on patron-attr-types.pl you have to click in the patron attribute type code input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the patron attribute type code input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27192] New: Set focus for cursor to item type input box when creating new item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Bug ID: 27192 Summary: Set focus for cursor to item type input box when creating new item types Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When adding a new item type on itemtypes.pl you have to click in the item type input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the item type input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27191] New: Set focus for cursor to category code input box when creating new patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27191 Bug ID: 27191 Summary: Set focus for cursor to category code input box when creating new patron categories Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When adding a new patron category on categories.pl you have to click in the category code input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the category code input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27190] Debug REST API tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c ||ommunity.org CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com Status|NEW |In Discussion --- Comment #3 from Jonathan Druart --- That's pretty ugly, and we will certainly never push it. But at least I will remember next time I need it, hopefully! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27190] Debug REST API tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190 --- Comment #2 from Jonathan Druart --- Created attachment 114314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114314=edit Bug 27190: Test::Mojo - Always warn the error string on error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27190] Debug REST API tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190 --- Comment #1 from Jonathan Druart --- Created attachment 114313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114313=edit Bug 27190: [DO NOT PUSH] example of failure Apply patches from 18729 to test this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27190 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27190] New: Debug REST API tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190
Bug ID: 27190
Summary: Debug REST API tests
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: ch...@bigballofwax.co.nz
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
It can be tricky to debug REST API tests. You can get a "received 500 when 200
expected", but you don't have the error.
There is one manual way to do it:
$t->put_ok($url)->status_is(200)->json_is($expected_json)->or( sub { warn
$t->tx->res->to_string });
But could we provide a generic way to add a diag in case Test::Mojo fails?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Lucas Gass changed: What|Removed |Added Attachment #114309|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 114312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114312=edit Bug 24398: Fix 500 when viewing a single news item at the OPAC Test plan: 0. Set the NewsAuthorDisplay preference to 'OPAC' or 'Both OPAC and staff client.' 1. Open the OPAC main page and click on an individual news item Without this patch you get an ugly 500 Template process failed: undef error - The method Koha::NewsItem->author_title is not covered by tests! With this patch applied you see the news with the author's info Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #18 from Jonathan Druart --- Thanks Tomas! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729
Jonathan Druart changed:
What|Removed |Added
Attachment #114067|0 |1
is obsolete||
--- Comment #17 from Jonathan Druart
---
Created attachment 114311
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114311=edit
Bug 18729: Add PUT /holds/{hold_id}/pickup_priority
Bug 18729: Fix return type
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27165] Online Resource link displays as HTML in OPAC MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27165 --- Comment #3 from Owen Leonard --- opac-MARCdetail.pl checks whether a subfield should be a link, and outputs HTML if it is. The template assumes that the subfield value *doesn't* contain HTML and uses the "html" filter on the variable. The template needs a check on whether the subfield is a link in order to selectively use the "$raw" filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27165] Online Resource link displays as HTML in OPAC MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27165 --- Comment #2 from Owen Leonard --- I can confirm this in master too. Testing with a record that has 856u populated with a regular link, the MARC view shows HTML. An example from our catalog, currently at v19.11.08: https://search.myacpl.org/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=239528 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 --- Comment #5 from Tomás Cohen Arazi --- This works as expected (today), not sure what mistake I made yesterday. The QA script is happy, and the changes to the tests make sense (and they pass). Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Tomás Cohen Arazi changed: What|Removed |Added Attachment #114064|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 114310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114310=edit Bug 27117: Only place_holds permission is needed to adjust pickup locations The GET /pickup_locations route is requesting the whole reserveforothers permission whereas only the subpermission place_holds is needed. Test plan: 0. Don't apply this patch 1. Set the subpermission place_holds but modify_holds_priority 2. Edit a hold and click the pickup library dropdown list 3. You get a JS alert and log displays GET /api/v1/app.pl/api/v1/holds/5/pickup_locations 403 Forbidden 4. Apply this patch 5. Reload the page, click the dropdown list, modify the pickup location and save => Success! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25726 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27166 CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- possible cause on 27166 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25313] Add optional skip_merge parameter to ModAuthority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25313 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26742] Add configuration for message broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #7 from Jonathan Druart --- 1. Wouldn't it make sense to keep "login" instead of "username" in the koha-conf.xml? 2. You are adding a die in the ->connect method, is it really useful? If $stomp->connect fails we already get an exception. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com --- Comment #5 from Andrew Isherwood --- Hi Emmi I tried to sign this off but ran into a few problems, sorry! 1. prove -v t/db_dependent/Hold.t fails with: t/db_dependent/Hold.t .. 1/34 found extra parameters: []# Looks like your test exited with 2 just after 1. t/db_dependent/Hold.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 33/34 subtests Test Summary Report --- t/db_dependent/Hold.t (Wstat: 512 Tests: 1 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 34 tests but ran 1. Files=1, Tests=1, 4 wallclock secs ( 0.04 usr 0.01 sys + 3.28 cusr 0.42 csys = 3.75 CPU) Result: FAIL 2. In your test plan, you say "Holds expiration date should be set according your settings", this doesn't appear to be happening. The expiry date is not being populated according to the value in the DefaultHoldExpirationdatePeriod syspref. Maybe I'm misunderstanding the test plan? You can see what I mean here: https://nimb.ws/Sw048R 3. In the video I manually selected a date and the hold was created, however, if I leave the date selection blank I receive an error page (the relevant part of which is here https://nimb.ws/pWzZNO), I note the error is the same as the one in the failing test. Sorry to report bad news! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
