[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #51 from Arthur Suzuki --- Created attachment 115130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115130=edit Bug 25408: (QA follow-up) Added handling of calling context (staff or else) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #50 from Arthur Suzuki --- Created attachment 115129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115129=edit Bug 25408: More test (with staff context) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #49 from Arthur Suzuki --- Created attachment 115128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115128=edit Bug 25408: (QA follow-up) Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #48 from Arthur Suzuki --- Created attachment 115127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115127=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api) To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place hold on staff side 3 - Hold is still allowed 4 - Attempt to place hold from opac or api 5 - Hold is not allowed 6 - Change rule to 'force' 7 - Item-level hold can be placed in all interfaces 8 - Record-level hold cannot be placed in all interfaces Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What|Removed |Added Attachment #115125|0 |1 is obsolete|| --- Comment #47 from Arthur Suzuki --- Created attachment 115126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115126=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #46 from Arthur Suzuki --- Hi, I've rebased the patch and have added an error message on staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What|Removed |Added Attachment #111717|0 |1 is obsolete|| Attachment #111718|0 |1 is obsolete|| Attachment #111719|0 |1 is obsolete|| Attachment #111720|0 |1 is obsolete|| Attachment #111721|0 |1 is obsolete|| --- Comment #45 from Arthur Suzuki --- Created attachment 115125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115125=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 --- Comment #3 from David Cook --- Btw, we can't use ABS() here because it interprets exponents. For instance, "select abs(978e0143019375)" will actually create an error or "Inf" if it's already stored in a database column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- It's an interesting idea, but I think that it is incompatible with Bug 26328. Explicitly casting to an integer is needed in Bug 26328 because barcode may not be an integer even in a database with autoBarcode set to "incremental", which can cause lots of problems. Hmm one way to solve both Bug 26328 and Bug 27426 could be to use the following SQL: SELECT barcode FROM items WHERE CAST(barcode AS unsigned) ORDER BY CAST(barcode AS unsigned) DESC LIMIT 1; It's an ugly bit of SQL but it should work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #35 from David Cook --- I'm intrigued by this one but super busy at the moment, unfortunately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #7 from David Cook --- To play devil's advocate, what's the main reasons for removing the ILS-DI API? Is it due to security issues? Maintainability? Code duplication? Personally, I dislike how it's only IP restricted. I would like more robust authentication. While I know that third-parties use the ILS-DI API, I don't know the history there. Did they develop client tools for generic ILS-DI APIs or did they always develop specifically for Koha's implementation of ILS-DI? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #3) > I think the scope of ILS-DI and the REST-API is also different. > > This is an API for discovery interfaces that's supposed to not allow more > than the OPAC user should be able to do. They can place a hold... but they > cannot manipulate a holds data. They can look up a patron, but not change > their data etc. > > I believe the REST API as is might not serve well here as it allows too much > and you'd want to have something more limited to be used by external > catalog/discovery providers specifically`? Those are interesting points too. I have been thinking that Koha is due for a review of its authorization system... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #5 from David Cook --- Hmm, yeah maybe we should rebrand this one as "Reproduce ILS-DI functionality in REST API" and then have a separate bug for "Deprecate ILS-DI", which has Bug 27423 as a dependency. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Attachment #115122|0 |1 is obsolete|| --- Comment #9 from Aleisha Amohia --- Created attachment 115124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115124=edit Bug 15348: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Attachment #115121|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 115123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115123=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #7 from Aleisha Amohia --- Created attachment 115122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115122=edit Bug 15348: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Attachment #114623|0 |1 is obsolete|| --- Comment #6 from Aleisha Amohia --- Created attachment 115121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115121=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- > (In reply to Thomas Klausner from comment #0) > > * Is it neccessary to get the job-size before starting it? If yes, then I > > assume I'll have to first parse the MARC file to get the job size, throwing > > the results away (and this might not work, because we want to do the parsing > > in the background in the first place). Or is there an easy way to get the > > number of records? > > I had the same problem with bug 27344. If it get too complicated (or cause > perf issues) I'd say we can consider we are processing 1 file and so its > size would be 1 :) > At least for a first step. > I'd say use a job size of 1 since it's 1 file. As you say, Thomas, I think that it's unreasonable to parse the MARC file just to get the number of records. I think that "tools/stage-marc-import.pl" should just be responsible for uploading the file, enqueuing the background job, and then either showing/referring to a job management view to review the results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14004] Add ability to temporarily disable intranetuserjs / opacuserjs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004
Lucas Gass changed:
What|Removed |Added
Attachment #115064|0 |1
is obsolete||
--- Comment #4 from Lucas Gass ---
Created attachment 115120
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115120=edit
Bug 14004: Add ability to temporarily disable JS/CSS sysprefs
It would be *super* handy if intranetuserjs and/or opacuserjs could be
temporarily disabled via a check-box or syspref.
Right now, debugging issues in intranetuserjs usuaally starts with copying the
contents into a text file, blanking the syspref and re-testing.
This patch adds this feature by setting syspref via ENV OVERRIDE_SYSPREF
like override via Apache config.
Note that this only works for
Implemented only for preferences :
OPACUserCSS OPACUserJS IntranetUserCSS IntranetUserJS
=> replaced with ' '
intranetcolorstylesheet intranetstylesheet
=> replaced with 0
Test plan :
1) Set some CSS in IntranetUserCSS like : #breadcrumbs{color:red}
2) Go to staff interface home page like : /cgi-bin/koha/mainpage.pl
3) See CSS impact is visible
4) Edit URL : /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_IntranetUserCSS=1
5) See CSS impact is not visible
6) Check with the other preferences
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14004] Add ability to temporarily disable intranetuserjs / opacuserjs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14004] Add ability to temporarily disable intranetuserjs / opacuserjs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- Nice! This works well and its a great way to troubleshoot potential problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26985] Remove code for "Upcoming events" from codebase as not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- applied patch and greped for instances of "Upcoming events" or "Upcoming_events", outside of po files I found none -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26985] Remove code for "Upcoming events" from codebase as not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Lucas Gass changed: What|Removed |Added Attachment #115113|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 115119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115119=edit Bug 26985: Remove code for "Upcoming events" from codebase as not implemented This patch removes references to an unimplemented feature for "Upcoming events" notices. As far as I can tell the templates are the only files affected. To test, apply the patch and verify that no instances of "Upcoming events" or "Upcoming_events" are found in the codebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26985] Remove code for "Upcoming events" from codebase as not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --- Comment #5 from Phil Ringnalda --- 942$c, biblioitems.itemtype, (but not 942 itself) is already mandatory in every framework except ACQ, which makes it easy to see how toothless mandatory framework subfields are. Add a record in the default framework with the basic editor, you are required to have a 942$c to save the record. Add a record in the default framework with the advanced editor, you are only required to have a 942$c if you add a 942, but you aren't required to add a 942. Add a record in the default framework with batch import, you aren't required to have a 942$c even if you make 942 mandatory (and yes, that does also mean that making items.itype mandatory in the framework has no effect on items created by batch import). So this bug needs to depend on a bug to change batch import, either by respecting mandatory fields/subfields in frameworks (which would be a huge behavior change, requiring users to learn how to use MarcEdit to batch change records before importing them) or by adding a select list to the actual import step to choose a "Default itemtype if 942$c or 952$y is missing", and for mandatory biblioitems.itemtype to actually work with the advanced editor, the 942 field needs to also be mandatory. To me, that makes taking the patch from bug 24331 to stop throwing an ISE when a patron places a hold seem like a pretty good idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25026] RaiseError must be set for the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #21 from David Cook --- (In reply to Jonathan Druart from comment #20) > (In reply to Victor Grousset/tuxayo from comment #19) > > Applied the patch, reset_all => multiple errors > > Was another step needed? > > Yes, see comment 14. Why don't we just use the first patch here and then update populate_db.pl to trap the fatal errors like in comment 7? populate_db.pl could be updated before even testing this patch. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)|20.11.00|20.11.00,20.05.08 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Andrew Fuerste-Henry --- I went ahead and backported this to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)||20.05.08 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #5 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26397] opac.scss calls non-existent image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)||20.05.08 released in|| CC||and...@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)|20.11.00|20.11.00,20.05.08 released in|| Status|Pushed to master|Pushed to stable --- Comment #33 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26698] Hold can show as waiting and in transit at the same time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)||20.05.08 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18668] Add the column localuse to the items table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18668 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1, this would be handy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Kyle M Hall changed: What|Removed |Added Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #9 from Kyle M Hall --- Closing this bug out. At this point we've had the new behavior longer than we had the old behavior and I expect it's simpler for everyone to change their groups hierarchy rather than push this patch. For posterity, the fix is to make new root groups for each of your first tier sub-groups, and enable the search group feature for each of them. That means changing something like this: RootGroup: SearchGroup1: LibraryA LibraryB SearchGroup2: LibraryC LibraryD SearchGroup3: LibraryE LibraryF to this: RootSearchGroup1: LibraryA LibraryB RootSearchGroup2: LibraryC LibraryD RootSearchGroup3: LibraryE LibraryF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27427] Update the way form validation errors are displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27427 --- Comment #2 from Owen Leonard --- (In reply to Owen Leonard from comment #1) > Known issue: Although a "change" event fires when a datepicker input is > first populated, the normal validation event isn't triggered. I'm torn about whether this is a blocker. The validation behavior of datepicker inputs won't be any different than before the patch but they will be different than other validated fields. I could use another set of eyes on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27427] Update the way form validation errors are displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27427 --- Comment #1 from Owen Leonard --- Created attachment 115118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115118=edit Bug 27427: Update the way form validation errors are displayed This patch adds a global default configuration for the jQuery Validation plugin for handling how some error messages are displayed during the process of filling out a form. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff client, test pages which use the jQuery form validation plugin, e.g. Administration -> Libraries -> New library. - When the page first displays, the library code and name fields should have a "Required" label following the inputs. - Enter data in each of these fields. When you tab out of the field, the "Required" label should turn green and be prepended with a checkmark icon. - When you empty the field you should see the default error message for required field, "This field is required." - Entering data again should hide this error and redisplay the label with the "valid" class. - Trying to submit the form when it is an invalid state should still block form submission and put focus in the first invalid field. - Test other pages which use jQuery form validation: Patron entry, list creation, budget creation, etc. Known issue: Although a "change" event fires when a datepicker input is first populated, the normal validation event isn't triggered. I'm not sure why. This means that date inputs will still show the default red "Required" label unless they're set again or the form is submitted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27427] Update the way form validation errors are displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27427 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27049] Add a script to bulk writeoff debts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049 --- Comment #5 from Lucas Gass --- Martin, When I run the script I get the following error and no debts are written off: Can't locate object method "search" via package "Koha::Account::Lines" (perhaps you forgot to load "Koha::Account::Lines"?) at /kohadevbox/koha/misc/cronjobs/writeoff_debts.pl line 49. If I add 'use Koha::Account::Lines;' to the script and restart_all I can make it work. Is this missing or am I doing something wrong? I am running this in my Koha testing docker like so: perl /kohadevbox/koha/misc/cronjobs/writeoff_debts.pl --confirm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25129] Update German (de-DE) web installer files for 20.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25129 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] New: Show the number of records in the bibliographic record detail page with ElasticSearch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Bug ID: 27428 Summary: Show the number of records in the bibliographic record detail page with ElasticSearch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: ivan.dzi...@inlibro.com This preference only for OPAC to show the number of records next to search links in the bibliographic record detail page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27379] Autocomplete addresses for a patron using Google Places API (Maps).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 --- Comment #4 from Lucas Gass --- Hey Ivan, I think a lot of libraries would find this useful. When I apply the patch, and create an deveolpers API with Google, then attempt to test this patch I get the following console error: You must enable Billing on the Google Cloud Project at https://console.cloud.google.com/project/_/billing/enable Learn more at https://developers.google.com/maps/gmp-get-started Places API error: BillingNotEnabledMapError https://developers.google.com/maps/documentation/javascript/error-messages#billing-not-enabled-map-error Although I can get a 'free trial account' I still have to provide Google with a credit card and billing information, making this patch difficult to test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27289] Template tweaks for point of sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Owen Leonard changed: What|Removed |Added Depends on||27427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27427 [Bug 27427] Update the way form validation errors are displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27427] New: Update the way form validation errors are displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27427 Bug ID: 27427 Summary: Update the way form validation errors are displayed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Blocks: 27289 I would like to update the way form validation errors are shown by the jQuery validation plugin. The changes depend on the plugin's event handler for "valid" and "invalid" inputs. Upon being checked by the plugin, a valid input will have any following styled green and with a check mark to indicate validity. An invalid input will have any following hidden and the jQuery validation error shown instead. https://zivotdesign.com/n/index.php/s/6WrBe3G8mzoLXsN Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 [Bug 27289] Template tweaks for point of sale page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #114945|0 |1 is obsolete|| --- Comment #10 from Ivan Dziuba --- Created attachment 115117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115117=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he starting search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! We need do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). If need do 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 4. For add information in the index we need run script for indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find "AutocompleteElasticSearch". Value must be "Show". 7. Now we have Autocomplete for all search input (advanced search also) Bug 27113: ElasticSearch: Autocomplete in input search v.2.0 Bug 27113: ElasticSearch: Autocomplete on input search. Code change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27416] String 'Modify tag' in breadcrumb is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27416 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26950] Checkin failure messages are unclear or too specific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26950 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27416] String 'Modify tag' in breadcrumb is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27416 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27325] Fix singular/plural forms on the OPAC dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27325] Fix singular/plural forms on the OPAC dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)|This updates the messages |21.05.00 released in|used for the patron | |dashboard on the OPAC start | |page to use the proper | |singular and plural forms: | |1 hold, 2 holds, etc. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27263] Link to preferences mentioned in system preference descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27263 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27263] Link to preferences mentioned in system preference descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27263 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26962] Koha notice/slips/receipts should print in true black (#000000)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26962] Koha notice/slips/receipts should print in true black (#000000)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26962 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26950] Checkin failure messages are unclear or too specific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26950
--- Comment #7 from Jonathan Druart
---
Created attachment 115116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115116=edit
Bug 26950: Fix SIP/Message.t
t/db_dependent/SIP/Message.t .. 2/9
# Failed test 'DBIx error on duplicate issue_id'
# at t/db_dependent/SIP/Message.t line 643.
# found warning: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
DBD::mysql::st execute failed: Duplicate entry '1' for key 'PRIMARY' [for
Statement "INSERT INTO `old_issues` ( `auto_renew`, `auto_renew_error`,
`borrowernumber`, `branchcode`, `date_due`, `issue_id`, `issuedate`,
`issuer_id`, `itemnumber`, `lastreneweddate`, `note`, `notedate`, `noteseen`,
`onsite_checkout`, `renewals`, `returndate`, `timestamp`, `unseen_renewals`)
VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with
ParamValues: 0=0, 1=undef, 2=57, 3='m_HHGh', 4=undef, 5=1, 6=undef, 7=undef,
8=973, 9=undef, 10=undef, 11=undef, 12=undef, 13=0, 14=0, 15='2021-01-14
16:12:47', 16='2021-01-13 16:12:48', 17=0] at /kohadevbox/koha/Koha/Object.pm
line 169
# found carped warning: The checkin for the following issue failed, Please
go to the about page and check all messages on the 'System information' to see
if there are configuration / data issues (Duplicate ID)$VAR1 = {
# expected to find warning: (?^u:Duplicate entry)
# expected to find warning: (?^u:data corrupted)
# Looks like you failed 1 test of 35.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 --- Comment #1 from Jonathan Druart --- Created attachment 115115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115115=edit Bug 27426: Keep leading zeros for barcode plugin (incremental) If autoBarcode is set to incremental, we are generating the next barcode adding 1, but casting to integer. If you have "0001" "0002" the next barcode will be "3". Should not we keep the leading zeros and generate "0003" instead? This patch suggests to keep them. If this behaviour is not the expected one we could create another barcode plugin. Test plan: Create an item with barcode 0001, another one with 0002 Set autoBarcode=incremental Create another item and click the barcode input With this patch the new barcode will be 0003 Without this patch the barcode was cast to int and resulted in 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 Jonathan Druart changed: What|Removed |Added CC||ha...@orex.es Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] New: Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 Bug ID: 27426 Summary: Plugin barcode must keep leading zeros Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl If autoBarcode is set to incremental, we are generating the next barcode adding 1, but casting to integer. If you have "0001" "0002" the next barcode will be "3". Should not we keep the leading zeros and generate "0003" instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Jonathan Druart changed: What|Removed |Added Version|20.11 |unspecified Assignee|koha-b...@lists.koha-commun |d...@plix.at |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Yes, that's the idea. (In reply to Thomas Klausner from comment #0) > * Is it neccessary to get the job-size before starting it? If yes, then I > assume I'll have to first parse the MARC file to get the job size, throwing > the results away (and this might not work, because we want to do the parsing > in the background in the first place). Or is there an easy way to get the > number of records? I had the same problem with bug 27344. If it get too complicated (or cause perf issues) I'd say we can consider we are processing 1 file and so its size would be 1 :) At least for a first step. > * When I try to update job_size later, I get an exception (something like > "job_size not tested") The accessor is ->size > * Can I actually use BatchStageMarcRecords in BackgroundJob? Why not? Did you face a problem? > * I see I can pass a batch size to BatchStageMarcRecords. But this will not > result in more forking? This is "only" used to fire the progress callback? I don't understand the question. Isn't BatchStageMarcRecords used to import the record? No fork will be done if you are using Koha::BackgroundJob. > I'm also not sure if the bug tracker or the dev mailing list is the best > place to discuss my questions? Here it's perfect :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|In Discussion CC||n...@bywatersolutions.com --- Comment #2 from Jonathan Druart --- Nick, can you have a look at this patch please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 --- Comment #6 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27425] Koha as a CMS - software error when accessing static pages (problem with "GetDailyQuote")
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27425 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Isabel, pages.pl is a file that only exists in your installation as it's part of the CMS "hack", so we can't fix this in Koha itself. It needs to be fixed locally. As you are not using the DailyQuotes feature and if it works now, your fix should be ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26991] Add action logs to search engine administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27425] New: Koha as a CMS - software error when accessing static pages (problem with "GetDailyQuote")
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27425 Bug ID: 27425 Summary: Koha as a CMS - software error when accessing static pages (problem with "GetDailyQuote") Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: isabel.pin...@ds.edu.sv QA Contact: testo...@bugs.koha-community.org After updating to Koha 20.11, static pages (added at Global preferences -> local use) cannot be accessed anymore. The error message is: Software error: "GetDailyQuote" is not exported by the C4::Koha module Can't continue after import errors at /usr/share/koha/opac/cgi-bin/opac/pages.pl line 27. BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/pages.pl line 27. Temporary solution: In the file /usr/share/koha/opac/cgi-bin/opac/pages.pl I commented all lines that mention the functionality "GetDailyQuote". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26541] Apply discount button misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26542] Apply Discount button appears when it can't be used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26542 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #4 from Arthur Suzuki --- Hi Nick, Although no new functionality are added to ILS-DI, it's in use by a lot of software, most discovery tools and frontend softwares including : - VuFind - BlackLight - Summon (Proquest) - EDS (Ebsco) - Bokeh (AFI-BibLibre) So it would break backward compatibility with those. Also, no new functionality but quality gets improved (like, circulation rules which used not to behave like OPAC are now taken into account when using ILS-DI). I fear this testing and quality assessment job is lost, and some instability brought instead. For me, it's ok to say we won't bring new features in, but maintenance and access to the API has to be kept for backward compatibility reason, eventually forwarding ILS-DI calls to the API when all functions are replicated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26542] Apply Discount button appears when it can't be used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26542 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #3 from Katrin Fischer --- I think the scope of ILS-DI and the REST-API is also different. This is an API for discovery interfaces that's supposed to not allow more than the OPAC user should be able to do. They can place a hold... but they cannot manipulate a holds data. They can look up a patron, but not change their data etc. I believe the REST API as is might not serve well here as it allows too much and you'd want to have something more limited to be used by external catalog/discovery providers specifically`? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #2 from Katrin Fischer --- AFAIK ILS-DI is used in the available VUfind-Driver among other things. I'd be careful to remove it until we have something that is as well documented and feature complete to replace it. There has also been a steady stream of patches still for ILS-DI over the last years, even some enh beyond the scope of the initial documentation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Caroline Cyr La Rose changed: What|Removed |Added Keywords|Academy |Manual CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #1 from Julian Maurice --- I found https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.1.pdf The fact that it can only be found on an "old." domain tells a lot about its status... :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What|Removed |Added CC||d...@plix.at -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Blocks||27424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 [Bug 27424] One should be able to assign an SMTP server as the default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What|Removed |Added Depends on||22343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add configuration options for SMTP servers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] New: One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Bug ID: 27424 Summary: One should be able to assign an SMTP server as the default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Bug 22343 adds the ability to defined SMTP servers via the UI; But to then utilise them you have to go to each individual library via the libraries admin area and select the SMTP server. We should have a way to override the fallback/default SMTP server right from the SMTP servers administration page.. setting one of our defined SMTP Servers as the system default rather than using the hard coded fallback options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27420] A mistake in bug 5161 leads to some patron attributes appearing without a fieldset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27420 Jonathan Druart changed: What|Removed |Added Attachment #115110|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 115114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115114=edit Bug 27420: Use object accessor for $attr_type->class() We introduced a bug in the patron attribute forms with bug 5161. Test plan 1/ Create two PA_CLASS authorized values 2/ Create two corresponding patron attribute types referencing the above classes. 3/ Edit a patron, both attributes should appear within their own fieldsets at the bottom of the member entry form. 4/ Set a value for the first of the two patron attributes and save 5/ Edit the patron again, note that the first attribute no longer resides within it's own fieldset 6/ Apply the patch 7/ Edit the patron again, note that the first attribute now resides inside it's own fieldset again 8/ Signoff Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27420] A mistake in bug 5161 leads to some patron attributes appearing without a fieldset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27420 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 Nick Clemens changed: What|Removed |Added CC||dc...@prosentient.com.au, ||fridolin.som...@biblibre.co ||m, ||jonathan.dru...@bugs.koha-c ||ommunity.org, ||julian.maur...@biblibre.com ||, katrin.fisc...@bsz-bw.de, ||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] New: ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 Bug ID: 27423 Summary: ILS-DI should be deprecated and functions moved to REST API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org This is just to start a discussion. I was trying to find the specifications for ILS-DI, but it seems that they don't exist? https://www.diglib.org/project-update-ils-di/ The links on that page indicate that no updates have been made since 2011? There seems to be a fair amount of use of ILS-DI so I don't think we can disable it until it is replicated, but I do think we should indicate that it will not be updated and eventually should be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #58 from Nick Clemens --- (In reply to Jonathan Druart from comment #57) > I don't think my concerns have been taken into account. QA please have a > look at bug 24841 comment 4. I think this fix is okay. Current code for this check exists in the opac scripts and not the modules. Possibly these checks should be moved to the modules, but that is a larger refactoring. ILS-DI behaviour vs REST API behaviour I think are expected to be different. ILS-DI is unprivileged but meant to act as the OPAC itself (these functions live in Level 3: Elementary OPAC alternative) and presumes the caller has sorted out the rights etc. The REST API is called by a user - that user's privileges decide whether the action can be completed or not. Moving the check into CanItemBeReserved means we need to make that function interface aware and is a bigger change TL/DR: BlockExpiredOpacActions should affect the opac only, ILS-DI is the OPAC, REST API is not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26985] Remove code for "Upcoming events" from codebase as not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26985] Remove code for "Upcoming events" from codebase as not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26985 --- Comment #1 from Owen Leonard --- Created attachment 115113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115113=edit Bug 26985: Remove code for "Upcoming events" from codebase as not implemented This patch removes references to an unimplemented feature for "Upcoming events" notices. As far as I can tell the templates are the only files affected. To test, apply the patch and verify that no instances of "Upcoming events" or "Upcoming_events" are found in the codebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26051] Elasticsearch field local-classification must be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |In Discussion --- Comment #5 from Nick Clemens --- Victor and Frido, can you look at my alternate patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27416] String 'Modify tag' in breadcrumb is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27416 Nick Clemens changed: What|Removed |Added Attachment #115111|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 115112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115112=edit Bug 27416: Make "Modify tag" and "Add tag" translatable Those two strings are not translatable as they are passed from the controller. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27416] String 'Modify tag' in breadcrumb is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27416 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27422] New: HTML5Media is http by default but Youtube is https only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27422 Bug ID: 27422 Summary: HTML5Media is http by default but Youtube is https only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gauthe...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Hi Unless 856 indicator is 7 and you set 856$2 to https koha is using http not htpps even if 856$u is like https://youtube.com/xxx. But it seems youtube isn't using http anymore. if HTML5MediaEnabled is true there's a media tab but it's empty eg: -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26292] HTML5 Media doesn't display in 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26292 Didier Gautheron changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #1 from Didier Gautheron --- Hi Could you check again ? I think it's fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Marjorie Barry-Vila changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #148 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #147) > Tomas, if you agree with this last patch please reset the status to NSO. A proper solution should be implemented in Koha::REST::Plugin::Query, in the merge_q_params and dbic_merge_prefetch helpers. They both have the resultset object available, so if we added the mapping at Koha::Object level, we could make the translations there, and thus have a 'global' solution in a fairly easy way. To do: - Add the attribute mapping hash in Koha::Biblio and make it available in Koha::Biblios too. A sample mapping would be isbn => biblioitem.isbn. It could be hardcoded (as the table doesn't change, or calculated. - Add a way for Koha::Biblio(s) to tell 'biblioitem' needs to be prefetch (a way for a Koha::Object to tell which other tables need to be prefect). - Make Koha::REST::Plugin::Query::_parse_prefetch add those prefetches using the above. Note that the 'biblio' name in this case is used because x-koha-embed calls it 'biblio' but it could (a) not exist, as in /biblios, where the biblio is top level (b) it could be named in a different way, as happens to (say) 'biblio.suggestions.suggester' which is a Koha::Patron object, but it is not called 'patron'. - Make Koha::REST::Plugin::Query::_parse_dbic_query accumulate the translations to be done while building the query. Then merge_q_params should call a new helper that applies those translations to the already created DBIC query (pretty much a copy and paste of fix_query). That said, we could move forward with the ugly-but-simple implementation. And once I'm back I can work on the above, unless someone does it first ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27416] String 'Modify tag' in breadcrumb is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27416 Owen Leonard changed: What|Removed |Added Attachment #115106|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 115111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115111=edit Bug 27416: Make "Modify tag" and "Add tag" translatable Those two strings are not translatable as they are passed from the controller. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
