[Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 Matthias Meusburger changed: What|Removed |Added Assignee|gmcha...@gmail.com |matthias.meusburger@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8865] Re-logging in needs to pass POST & GET arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8865 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850
--- Comment #75 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #74)
> From the RFC:
>time-second = 2DIGIT ; 00-58, 00-59, 00-60 based on leap second
> ; rules
>
> And the code:
> +
> (\.\d{1,3})?(([Zz])|((?[\+|\-])(?[01][0-9]|2[0-3]):
> (?[0-5][0-9])))
>
> No blocker, just noting
No, thats fine. Looking at seconds..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850
--- Comment #74 from Marcel de Rooy ---
From the RFC:
time-second = 2DIGIT ; 00-58, 00-59, 00-60 based on leap second
; rules
And the code:
+
(\.\d{1,3})?(([Zz])|((?[\+|\-])(?[01][0-9]|2[0-3]):(?[0-5][0-9])))
No blocker, just noting
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #73 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show incorrect number of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show incorrect number of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Marcel de Rooy changed: What|Removed |Added Assignee|l...@wgc.school.nz |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show incorrect number of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #16 from Marcel de Rooy --- Not sure if this is a bug btw or just reading the documentation or so ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27633] New: Double indication of a reference when indicating a series.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27633 Bug ID: 27633 Summary: Double indication of a reference when indicating a series. Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: koha_har...@mhlkg.de QA Contact: testo...@bugs.koha-community.org When a reference is specified in 440 $v, it is displayed twice in the OPAC and in the search list. Once in the linked title and additionally as a reference. Example: Series: Hannah Arendt Institute for Research on Totalitarianism: Reports and Studies Volume 69 ; Volume 69 This is displayed correctly within the administration interface: Series: Hannah Arendt Institute for Research on Totalitarianism: Reports and Studies ; Volume 69 https://bibo.saw-leipzig.de/cgi-bin/koha/opac-detail.pl?biblionumber=162 Regards Michael -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show incorrect number of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy --- -"bPaginate": false +"bPaginate": false, -"bPaginate": false +"paginate": false, Two very small patches. But not the same ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show incorrect number of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #14 from Marcel de Rooy --- git grep -E "bPaginate.*true" koha-tmpl/intranet-tmpl/lib/datatables/datatables.js: "bPaginate": true, koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt: "bPaginate" : true, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25632] Update MARC21 frameworks to update Nr. 30 (May 2020)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25632] Update MARC21 frameworks to update Nr. 30 (May 2020)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Marcel de Rooy changed: What|Removed |Added Attachment #116084|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 116354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116354=edit Bug 25632: Update MARC21 frameworks to update Nr. 30 (May 2020) New subfields 0 1 2 in 310 and 321 Changes 310 change to repeatable 883 renamed 883 a d q renamed To test: 1) Remove bibliographic frameworks 2) Check mandatory bibliographic fw load without problem misc/load_yaml.pl --load --file=installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml 3) Check new/renamed fields/subfields Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25632] Update MARC21 frameworks to update Nr. 30 (May 2020)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 --- Comment #20 from Ere Maijala --- Thanks for the comments and review! Indeed, things will be easier when deleted records are included in the normal tables, but for now this is quite alright, and there's no need to union them all together. I think there's an advantage with tracking the different timestamps even if it's more complicated. When item data is not included, it wouldn't be useful to harvest biblios as updated when an item changes, since the biblio record would be identical. If you meant that we could have another timestamp that would indicate the latest change for the logical record that OAI-PMH would provide, yeah, that'd work, but trying to track latest item changes in biblios would complicate other functionality and could also have unintended consequences such as increased overhead for batch operations. Also, I'm still optimistic that we can get bug 20447 merged somewhere in the future, and that would add to the complexity. As I see it, the "proper" solution would be to have a publishing process that would run in background to create sets of records for harvesting. With published sets we could handle inclusion of items, deletions etc. in the publishing process, and the OAI-PMH provider would only need to serve the results. However, this would be a whole lot more complicated than what we currently do, and there'd be a fair chance that the publishing process would do a lot of work to create result sets that nobody ever harvests. Additionally, it would make quick (semi-realtime) incremental harvesting impossible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date and availability in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #3 from Aleisha Amohia --- Created attachment 116353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116353=edit Bug 17748: [WIP] Not ready for testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #1 from wainuiwitikap...@catalyst.net.nz --- Created attachment 116352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116352=edit Bug 27631: Changed around logo to To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside and not Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27282] Printing broken in some versions of Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- (In reply to Lucas Gass from comment #10) > (In reply to Timothy Alexis Vass from comment #9) > > I tried to sign off but the printing worked in this version of Chrome. > > Version 88.0.4324.146 (Official Build) (64-bit) > > This was last happening for me in Chrome 78.0.3904.97 According to https://en.wikipedia.org/wiki/Google_Chrome_version_history, Chrome 78 has been discontinued. Versions 87 and 88 are stable. (I've actually been playing with Chromium 90 lately too as Playwright uses it but that's a dev build. Puppeteer uses Chromium 88.) I reckon it should be safe to target only stable versions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #23 from David Cook --- (In reply to Lucas Gass from comment #21) > Yes, we need to add auth.tt next and there is a bit more to untangle with > cas, shib, and GoogleOpenIDConnect. I file another bug to do so. Sounds good to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 David Cook changed: What|Removed |Added Attachment #116350|0 |1 is obsolete|| --- Comment #22 from David Cook --- Created attachment 116351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116351=edit Bug 25405: clean up some CSS Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #21 from Lucas Gass --- > Oh, although opac-auth.tt still shows Shibboleth without the span, and it > could use the same HTML construct as the modal... mmm maybe that can just be > a follow-up bug, as it would be nice to get this one in... > > Yes, we need to add auth.tt next and there is a bit more to untangle with cas, shib, and GoogleOpenIDConnect. I file another bug to do so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #20 from Lucas Gass --- Created attachment 116350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116350=edit Bug 25405: clean up some CSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #19 from David Cook ---
With my patch, I tested out relabeling the option in the console:
$(".shibboleth_login_name").text('Keycloak');
Worked so nicely.
--
Oh, although opac-auth.tt still shows Shibboleth without the span, and it could
use the same HTML construct as the modal... mmm maybe that can just be a
follow-up bug, as it would be nice to get this one in...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #18 from David Cook --- I've signed off your patch, Lucas. So if you sign off mine, I think we can move this to Signed Off. :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #17 from David Cook --- Created attachment 116349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116349=edit Bug 25405: Make it easier to add additional identity providers Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 David Cook changed: What|Removed |Added Attachment #116346|0 |1 is obsolete|| --- Comment #16 from David Cook --- Created attachment 116348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116348=edit Bug 25405: clearly define local login and shib login sections This patch attempts to clearly seperate local login from shibboleth login in the OPAC loginModal. It includes seperate id's for local and shibboleth to make it easier to customize this login To test: 1. Enable shibboleth in your koha-conf.xml by changng the value of to 1. 2. I also add the following to my koha-conf: email 3. Look at the loginModal in the OPAC by clicking 'Log in to your account' in the top right corner. 4. Apply patch, restart all, and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 5. Look at the loginModal again the shibboleth section should be underneath the local login stuff. 6. Inscept the loginModal and make sure there is a for both local_login and external_login 7. Make sure it all works. 8. Turn Shibboleth back off and restart all. 9. Make sure everything still works and looks good without Shibboleth off. 10. Check HTML elements #external_login, #external_login_button, #external_login_name, and #external_login_icon. There were added to allow for further customization with css/js Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #15 from David Cook --- This is looking so good! I'm sorry but I just have a couple more things. This is so so close. In "div#external_login", the "a" element should be encapsulated within "div#external_login_button". I think that might just be a typo in the current patch. I think that "external_login_button" should be "shibboleth_login_button" and "external_login_icon" should be "shibboleth_login_icon" and "external_login_name" should be "shibboleth_login_name". My reasoning here is that we could add additional external login buttons for different external auth providers. I have an OpenID Connect local extension that I would add here, for instance. This would also be a good place for authentication plugins to advertise. In fact, if you don't mind, I might just provide a little follow-up and see what you think... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date and availability in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 David Cook changed: What|Removed |Added Attachment #116343|0 |1 is obsolete|| --- Comment #3 from David Cook --- Created attachment 116347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116347=edit Bug 27632: add data-biblionumber attr to OPAC results To test: -Apply patch and do an OPAC search that returns several results -Inscept and look for the class bibiocol -Make sure it contains a data-biblionumber attr with a value that matches the biblionumber Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632
--- Comment #2 from David Cook ---
My test plan:
0) Use koha-testing-docker
1) Apply patch
2) Go to
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx==test_search=1
3) Open browser console
4) Run the following: $(".bibliocol").each( function(){
console.log($(this).attr('data-biblionumber')) });
5) Observe output of "29", "114", and "134".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What|Removed |Added Attachment #114754|0 |1 is obsolete|| --- Comment #14 from Lucas Gass --- Created attachment 116346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116346=edit Bug 25405: clearly define local login and shib login sections This patch attempts to clearly seperate local login from shibboleth login in the OPAC loginModal. It includes seperate id's for local and shibboleth to make it easier to customize this login To test: 1. Enable shibboleth in your koha-conf.xml by changng the value of to 1. 2. I also add the following to my koha-conf: email 3. Look at the loginModal in the OPAC by clicking 'Log in to your account' in the top right corner. 4. Apply patch, restart all, and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 5. Look at the loginModal again the shibboleth section should be underneath the local login stuff. 6. Inscept the loginModal and make sure there is a for both local_login and external_login 7. Make sure it all works. 8. Turn Shibboleth back off and restart all. 9. Make sure everything still works and looks good without Shibboleth off. 10. Check HTML elements #external_login, #external_login_button, #external_login_name, and #external_login_icon. There were added to allow for further customization with css/js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 --- Comment #19 from David Cook --- As a tester, I'm not really commenting on performance. I'm just confirming that the code doesn't break anything and works as a user would expect. For what it's worth, on a small database, it's quite quick. I don't have a big enough test database on hand at this moment to test the code on. But at a glance it looks like it should be fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26693] Add option to update dateaccessioned when receiving an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Andrew Fuerste-Henry from comment #3) > (In reply to Tomás Cohen Arazi from comment #2) > > What about a checkbox about this when adding the items to the orderlines? > > When you say "adding items to orderlines" do you mean when adding an order > to a basket and creating items then? Or do you mean when creating items on > receiving? We've got at least those two possible workflows that need to be > accommodated. And it really needs to have some global default selection. I mean in the context items are created, I was thinking when adding items to a basket, but really meant any step in the workflow there items are created. So the user marks the order marked to update the items on receiving. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 David Cook changed: What|Removed |Added Attachment #116310|0 |1 is obsolete|| --- Comment #18 from David Cook --- Created attachment 116345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116345=edit Bug 27584: Refactor OAI-PMH paging to improve performance Includes the following optimizations: - Use next biblionumber instead of large offset in the queries. - Use unions instead of subqueries - Avoid fetching item timestamps when items are not included. Test plan: 1. Without the patch, try harvesting a Koha database with (and without for good measure) `include_items: 1` in the OAI-PMH configuration file pointed to by preference OAI-PMH:ConfFile and take note of performance. For useful metrics the database must be large enough to not fit in InnoDB buffers or OS file cache. 2. Apply the patch. 3. Run tests: prove -v t/db_dependent/OAI 4. Try again the harvesting from step 1 and compare performance with step 1. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 --- Comment #17 from David Cook --- My test plan: 0) Use koha-testing-docker 1) Enable "OAI-PMH" 2) Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords=oai_dc 3) Apply patch 4) koha-plack --restart kohadev 5) Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords=oai_dc 6) Note that the result lists are the same 7) Set OAI-PMH:ConfFile to "/kohadevbox/koha/oai-conf.yml" 8) Create oai-conf.yml* 9) Go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords=marcxml 10) Note that identifiers are same as previous list 11) Note that items (952 fields) are included in metadata * --- format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 oai_dc: metadataPrefix: oai_dc metadataNamespace: http://www.openarchives.org/OAI/2.0/oai_dc/ schema: http://www.openarchives.org/OAI/2.0/oai_dc.xsd xsl_file: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2OAIDC.xsl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26693] Add option to update dateaccessioned when receiving an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 --- Comment #3 from Andrew Fuerste-Henry --- (In reply to Tomás Cohen Arazi from comment #2) > What about a checkbox about this when adding the items to the orderlines? When you say "adding items to orderlines" do you mean when adding an order to a basket and creating items then? Or do you mean when creating items on receiving? We've got at least those two possible workflows that need to be accommodated. And it really needs to have some global default selection. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 --- Comment #16 from David Cook --- At a glance, I think that your code is probably an improvement. However, looking at Koha::OAI::Server::ListBase makes me wonder if we shouldn't denormalize a bit though. If we had a timestamp in a biblio table that included a timestamp for the last item activity, that would remove the need for a lot of these complex SQL queries. If we fetched all the biblio metadata in our first query, we'd also save overhead. But... both of those would involve more work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26693] Add option to update dateaccessioned when receiving an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- What about a checkbox about this when adding the items to the orderlines? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #24 from Lari Taskula --- (In reply to Lari Taskula from comment #21) > What about using DBIx to determine the chain of relations to the > borrowers-table? This way we could keep it dynamic, only relying on the > foreign keys in our database schema. Example of this in comment #23. I have also created an RFC for the endpoint, see https://wiki.koha-community.org/wiki/Public_patrons_export_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #23 from Lari Taskula --- Created attachment 116344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116344=edit Bug 20028: Add Koha::Patron->takeout To test: 1. prove t/db_dependent/Koha/Patron.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 Lari Taskula changed: What|Removed |Added Blocks||20028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 [Bug 20028] Export all patron related personal data in one package -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula changed: What|Removed |Added Depends on||27630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 [Bug 27630] TestBuilder real number precision to use column's size -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #11 from Agnes Rivers-Moore --- There are still confusing hold messages in the OPAC. I know this bug is closed. Adding this as information for others who may come across a similar situation: Test: logged into your account on Koha, search the catalogue for a title, forgetting that you already have a hold on it, and then try to place a hold on that title, the message that comes up is: "There are no items that can be placed on hold." No indication why not. This exists in versions up to 20.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Ed Veal changed: What|Removed |Added CC||ev...@mckinneytexas.org --- Comment #7 from Ed Veal --- This is an issue for us as well, we allow extra time for patron's to pick up ILLs so we would like to be able to edit the field as appropriate. Ed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 --- Comment #15 from David Cook --- After reviewing the code again, I'm only now realizing that we're not even trying to do a UNION of biblios and deleted biblios, so the results aren't in date order... Although after reviewing the OAI-PMH spec, it actually explicitly says that date ordering should not be assumed: "The protocol does not define the semantics of incompleteness. Therefore, a harvester should not assume that the members in an incomplete list conform to some selection criteria (e.g., date ordering)." You learn something new every day... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 Lucas Gass changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 --- Comment #1 from Lucas Gass --- Created attachment 116343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116343=edit Bug 27632: add data-biblionumber attr to OPAC results To test: -Apply patch and do an OPAC search that returns several results -Inscept and look for the class bibiocol -Make sure it contains a data-biblionumber attr with a value that matches the biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27632] New: Add a more easily javascript accessible biblionumber to each record in OPAC results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 Bug ID: 27632 Summary: Add a more easily javascript accessible biblionumber to each record in OPAC results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It would be handy to have an easily accessible biblionumber for each record in the OPAC results. I think .bibliocol would be an appropriate place -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 Lari Taskula changed: What|Removed |Added Attachment #116340|0 |1 is obsolete|| --- Comment #5 from Lari Taskula --- Created attachment 116342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116342=edit Bug 27630: Add test to prove different behavior with floats To test: 1. prove t/db_dependent/TestBuilder.t 2. It might or might not pass all tests - if it passes, run it again until you get the following error (always with either the "float" or "double" steps): ok 5 - decimal - Builder builds same precision as DBIx returns. not ok 6 - float - Builder builds same precision as DBIx returns. Failed test 'float - Builder builds same precision as DBIx returns.' at t/db_dependent/TestBuilder.t line 112. got: '51.7080' expected: '51.708' Looks like you failed 1 test of 7. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11257] Document <> for DUEDGST and PREDUEDGST and update sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #26 from Andrew Fuerste-Henry --- Enhancement, not backporting to 20.05. Please request if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27029] Detail page missing Javascript accessible biblionumber value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27029 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #17 from Andrew Fuerste-Henry --- Agreed, this seems small and handy. Pushed t0 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27525] 'wich' instead of a 'with' in a sentence
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27547] Typo in parcel.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27547 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #6 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27446] Markup errors in suggestion/suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27508] Can't duplicate the MARC field tag with JavaScript if option "advancedMARCeditor" is set to "Don't display"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27508 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #6 from Andrew Fuerste-Henry --- Cannot recreate error on 20.05. Not backporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27531] Remove type attribute from script tags: Cataloging plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| CC||and...@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25614] "Clear filter" button permanently disabled on ILL request list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #8 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27333] Wrong exception thrown in Koha::Club::Hold::add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27333 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #8 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| CC||and...@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27606] Breadcrumbs on parcel.pl should include a link to the vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27606 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27543] Tooltip on opac-messaging.pl obscured by table headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27543 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Can't recreate on 20.05, therefore not backporting. I looked at this in both Firefox and Chrome and the tooltip is working as intended. Please let me know if you're seeing something else in 20.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608 Lucas Gass changed: What|Removed |Added Attachment #116288|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 116341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116341=edit Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27098] Rename 'Relatives fines' to 'Relatives charges' in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27098 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Enhancement, not backported to 20.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22152] Hide printing the tools navigation when printing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22152 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|RESOLVED CC||and...@bywatersolutions.com Resolution|--- |FIXED --- Comment #7 from Andrew Fuerste-Henry --- Not backported to 20.05. Feel free to ask if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27022] Publisher number 028 does not display according to framework settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27022 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27179] Misspelling of Method in REST API files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27179 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #6 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 --- Comment #4 from Lari Taskula --- Created attachment 116340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116340=edit Bug 27630: Add test to prove different behavior with floats To test: 1. prove t/db_dependent/TestBuilder.t 2. It might or might not pass all tests - if it passes, run it again until you get the following error (always with the "float" step): ok 5 - decimal - Builder builds same precision as DBIx returns. not ok 6 - float - Builder builds same precision as DBIx returns. Failed test 'float - Builder builds same precision as DBIx returns.' at t/db_dependent/TestBuilder.t line 112. got: '51.7080' expected: '51.708' Looks like you failed 1 test of 6. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27210] Typo in patron-attr-types.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27210 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27606] Breadcrumbs on parcel.pl should include a link to the vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27606 --- Comment #1 from Lucas Gass --- Created attachment 116339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116339=edit Bug 27606: Add link back to vendor in breadcrumbs for parcel.tt To Test: 1. recieve an order: When receiving, we get these breadcrumbs: Home › Acquisitions › Receive orders from My Vendor 2. apply patch Now we get these breadcrumbs: Home › Acquisitions › My Vendor› Receive orders from My Vendor 3. Make sure the link sends you back to the correct vendor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27606] Breadcrumbs on parcel.pl should include a link to the vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27606 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 Lari Taskula changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Lari Taskula --- There's something I'm missing. When column type is "decimal", DBIx returns the trailing decimal zeroes, but when it's "float", it returns only the numbers until the significant precision. So if column size for decimals is 4, and the number being 1.0100, I get the following results from DBIx: decimal: 1.0100 float: 1.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24811] French SQL files for "news" contain broken link to the wiki
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24811 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24810] French SQL files for "news" contain "Welcome into Koha 3!"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24810 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #4 from wainuiwitikap...@catalyst.net.nz --- (In reply to Lucas Gass from comment #2) > Should we do the same thing in the staff client? (In reply to wainuiwitikapark from comment #3) > (In reply to Lucas Gass from comment #2) > > Should we do the same thing in the staff client? > > Yes definitely, I will make a bug report for it now. Please see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 for the Staff Client version of this bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] New: Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Bug ID: 27631 Summary: Accessibility: Staff Client - on each page is Logo but should be page description/title Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The main heading of each page in Koha should describe the topic or purpose of the page. At the moment, the of each page looks like: Library Name It makes more sense and would be more helpful to ensure the heading has a descriptor of the page that they're on, rather than no description surrounding a link containing the name of the library. The following WCAG2.1 page explains this further: https://www.w3.org/WAI/WCAG21/Techniques/general/G130 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155#c12 raises a question of what navigation items should be if h1 is move to the main content, and here is a page which shows that it is acceptable to have h2 that come before the h1 in the content, see example 2: https://www.w3.org/WAI/tutorials/page-structure/headings/ First, let's remove the tag from around the Logo link This bug will depend on correcting the headings on each page of the Staff Client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27586] Import patrons script has a confirm switch that doesn't do anything!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586 David Nind changed: What|Removed |Added Text to go in the||This fixes the release notes||misc/import_patrons.pl ||script so that patrons are ||not imported unless the ||--confirm option is used. ||Currently, if the script is ||run without "--confirm" ||option it reports that it ||is "Running in dry-run ||mode, provide --confirm to ||apply the changes", however ||it imports the patrons ||anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #3 from wainuiwitikap...@catalyst.net.nz --- (In reply to Lucas Gass from comment #2) > Should we do the same thing in the staff client? Yes definitely, I will make a bug report for it now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 --- Comment #11 from Joe Sikowitz --- I would also like to be able to do add an item this way. It would be very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 Joe Sikowitz changed: What|Removed |Added CC||j...@flo.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 Lari Taskula changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|lari.task...@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27586] Import patrons script has a confirm switch that doesn't do anything!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): - created a CSV file with sample data using the Starter CSV file from Tools > Patrons and circulation > Import patrons - commands to run the import: . misc/import_patrons.pl --file /kohadevbox/koha/patron-sample-import.csv --matchpoint cardnumber -v . misc/import_patrons.pl --file /kohadevbox/koha/patron-sample-import.csv --matchpoint cardnumber -v --confirm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27586] Import patrons script has a confirm switch that doesn't do anything!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586 David Nind changed: What|Removed |Added Attachment #116179|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 116338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116338=edit Bug 27586: Import patrons script has a confirm switch that doesn't nothing! If the script misc/import_patrons.pl is run without "--confirm" it reports that it is "running in dry-run mode" but it is not! Test Plan: 1) Import a CSV of patrons using import_patrons.pm *without* the --confirm parameter 2) Note that it does actually import the patrons 3) Apply this patch 4) Note that this time the patrons are not actually imported 5) Import again with --confirm 6) Note that the patrons were actually imported this time! Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27586] Import patrons script has a confirm switch that doesn't do anything!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 --- Comment #2 from Lari Taskula --- Created attachment 116337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116337=edit Bug 27630: Allow more TestBuilder decimal places than 2 To test: 1. prove t/db_dependent/TestBuilder.t 2. Observe success Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 --- Comment #1 from Lari Taskula --- Created attachment 116336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116336=edit Bug 27630: Add tests To test: 1. prove t/db_dependent/TestBuilder.t 2. Observe failing test t/db_dependent/TestBuilder.t .. 3/13 Failed test 'There can be more decimals when the column size allows it.' at t/db_dependent/TestBuilder.t line 101. got: '67631.42' expected: '67631.42' Looks like you failed 1 test of 4. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 Lari Taskula changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27630] New: TestBuilder real number precision to use column's size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630
Bug ID: 27630
Summary: TestBuilder real number precision to use column's size
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: ch...@bigballofwax.co.nz
Reporter: lari.task...@hypernova.fi
QA Contact: testo...@bugs.koha-community.org
t::lib::TestBuilder::_gen_real() always returns 2 decimal places no matter the
column's size definition.
> TestBuilder.pm _gen_real()
> printf("%.2f", rand($max-0.1));
Our database has decimal type columns with higher than 2 decimal places. This
makes comparing structures with Test::More::is_deeply impossible when the other
object is built by TestBuilder, and the other fetched from database, as seen
here:
# Structures begin differing at:
# $got->[0]{amount} = '90203.71'
# $expected->[0]{amount} = '90203.71'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27618] Don't show dropdown if PatronSelfRegistrationLibraryList only has one library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27618 Lucas Gass changed: What|Removed |Added Attachment #116314|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 116335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116335=edit Bug 27618: Don't show dropdown if PatronSelfRegistrationLibraryList only has one library This patch modifies the patron entry form in the OPAC so that if there is only one library to choose from, the input is hidden and the single library displays as text. To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27618] Don't show dropdown if PatronSelfRegistrationLibraryList only has one library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27618 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27627] Fix invalid HTML in OPAC results XSLT: change spans to divs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Lucas Gass changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
