[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #246 from David Cook --- Looking good, Aleisha! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117130|0 |1 is obsolete|| --- Comment #245 from David Cook --- Created attachment 117133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117133=edit Bug 15565: Place multiple holds on one record on OPAC Test plan: 1) Apply patch and restart services 2) Set the maxreserves system preference to 3 3) Set the following circulation rules: holds allowed (total) = 10 holds allowed (daily) = 10 holds per record (count) = 10 3) Set up a record with 4 items 4) Go to place a hold on this record 5) Notice that the items table under 'Place a hold on a specific item' now uses checkboxes instead of radio buttons 6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox, an alert pops up warning the you've reached the maximum. Confirm that when you close the alert, the checkbox unchecks itself. 7) Try setting different values for the above circulation rules that are lower than the number of items on this record. Confirm the alert pops up as expected. 8) Set the circulation rules and syspref all to 4+. Check some items and confirm the holds. 9) Confirm that item-level holds are placed on all selected items. Sponsored-by: Catalyst IT Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117129|0 |1 is obsolete|| --- Comment #244 from David Cook --- Created attachment 117132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117132=edit Bug 15565: Place multiple holds on one record on staff client Test plan: 1) Apply patch and restart services 2) Set the maxreserves system preference to 3 3) Set the following circulation rules: holds allowed (total) = 10 holds allowed (daily) = 10 holds per record (count) = 10 3) Set up a record with 4 items 4) Go to place a hold on this record 5) Notice that the items table under 'Place a hold on a specific item' now uses checkboxes instead of radio buttons 6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox, an alert pops up warning the you've reached the maximum. Confirm that when you close the alert, the checkbox unchecks itself. 7) Try setting different values for the above circulation rules that are lower than the number of items on this record. Confirm the alert pops up as expected. 8) Set the circulation rules and syspref all to 4+. Check some items and confirm the holds. 9) Confirm that item-level holds are placed on all selected items. Sponsored-by: Catalyst IT Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117128|0 |1 is obsolete|| --- Comment #243 from David Cook --- Created attachment 117131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117131=edit Bug 15565: Koha::Biblio->allowed_holds and tests Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #242 from Aleisha Amohia --- Created attachment 117130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117130=edit Bug 15565: Place multiple holds on one record on OPAC Test plan: 1) Apply patch and restart services 2) Set the maxreserves system preference to 3 3) Set the following circulation rules: holds allowed (total) = 10 holds allowed (daily) = 10 holds per record (count) = 10 3) Set up a record with 4 items 4) Go to place a hold on this record 5) Notice that the items table under 'Place a hold on a specific item' now uses checkboxes instead of radio buttons 6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox, an alert pops up warning the you've reached the maximum. Confirm that when you close the alert, the checkbox unchecks itself. 7) Try setting different values for the above circulation rules that are lower than the number of items on this record. Confirm the alert pops up as expected. 8) Set the circulation rules and syspref all to 4+. Check some items and confirm the holds. 9) Confirm that item-level holds are placed on all selected items. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #241 from Aleisha Amohia --- Created attachment 117129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117129=edit Bug 15565: Place multiple holds on one record on staff client Test plan: 1) Apply patch and restart services 2) Set the maxreserves system preference to 3 3) Set the following circulation rules: holds allowed (total) = 10 holds allowed (daily) = 10 holds per record (count) = 10 3) Set up a record with 4 items 4) Go to place a hold on this record 5) Notice that the items table under 'Place a hold on a specific item' now uses checkboxes instead of radio buttons 6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox, an alert pops up warning the you've reached the maximum. Confirm that when you close the alert, the checkbox unchecks itself. 7) Try setting different values for the above circulation rules that are lower than the number of items on this record. Confirm the alert pops up as expected. 8) Set the circulation rules and syspref all to 4+. Check some items and confirm the holds. 9) Confirm that item-level holds are placed on all selected items. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #87979|0 |1 is obsolete|| Attachment #87980|0 |1 is obsolete|| Attachment #87981|0 |1 is obsolete|| Attachment #87982|0 |1 is obsolete|| Attachment #87983|0 |1 is obsolete|| Attachment #87984|0 |1 is obsolete|| Attachment #87985|0 |1 is obsolete|| Attachment #87986|0 |1 is obsolete|| Attachment #87987|0 |1 is obsolete|| Attachment #87988|0 |1 is obsolete|| Attachment #87989|0 |1 is obsolete|| Attachment #87990|0 |1 is obsolete|| Attachment #87991|0 |1 is obsolete|| --- Comment #240 from Aleisha Amohia --- Created attachment 117128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117128=edit Bug 15565: Koha::Biblio->allowed_holds and tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27744] New: Can't call method "branchcode" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 712.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27744 Bug ID: 27744 Summary: Can't call method "branchcode" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 712. Change sponsored?: --- Product: Koha Version: 20.05 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: s24434a...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com While circulation an item .. following error is shown Can't call method "branchcode" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 712. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27422] HTML5Media is http by default but Youtube is https only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27422 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #12) > > Please backport it. It is a broken feature without it. Thanks > > Ok, I didn't understood that from the severity and description. Done! :) > > Though I'm still confused as in my testing it still works without the patch. It might be related to some specific browsers not accepting http on iframes. I'm not sure. We've been having reports since December and we ground this bug. I usually try Firefox, Chrome and Safari. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #16 from David Cook --- (In reply to Martin Renvoize from comment #15) > Other queuing systems appear to use 'queues' as a second distinction > instead.. so we could have a 'default' queue that the non-elastic indexing > tasks go onto and another for the elastic one.. that way we can > differentiate into groups rather than having to list all types.. Agreed. I think nominating queues rather than job types for workers makes more sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25078] Gracefully stop updatedatabase/installer when a database change cannot be applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #25 from David Cook --- (In reply to Julian Maurice from comment #24) > I think that having another alternative is good for discussion. +1 I like the idea of moving towards database migrations. I think that I'd posted about this previously, but now I can't find my comments. A lot of modern software uses database migrations. Kong uses its own Lua-based system, Keycloak uses Liquibase for database migrations, and the other day I wrote a simple PHP-based migrations system for a legacy app. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27422] HTML5Media is http by default but Youtube is https only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27422 --- Comment #13 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #12) > Though I'm still confused as in my testing it still works without the patch. Same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27422] HTML5Media is http by default but Youtube is https only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27422 --- Comment #12 from Victor Grousset/tuxayo --- > Please backport it. It is a broken feature without it. Thanks Ok, I didn't understood that from the severity and description. Done! :) Though I'm still confused as in my testing it still works without the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27422] HTML5Media is http by default but Youtube is https only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27422 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in||19.11.15 --- Comment #11 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Blocks||27741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Depends on||27631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Blocks||27740 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Depends on||27610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #12 from Victor Grousset/tuxayo --- > POD is missing for 'store' Something like that would do: -Overloaded I method to apply DefaultHoldExpirationdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | --- Comment #11 from Victor Grousset/tuxayo --- QA tools: FAIL pod coverage POD is missing for 'store' Fixed a typo and phrasing : settimg default expiration => setting the default expiration Other than that, it work (hence the signoff) and the code looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114663|0 |1 is obsolete|| --- Comment #10 from Victor Grousset/tuxayo --- Created attachment 117127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117127=edit Bug 26498: Set default expiration date for holds Koha doesn't automatically set expiration date for holds so they can live in the system forever. This patch adds new sysprefs to control setting of default expiration date for holds. Note that expiration date is only set if input field for it is left blank. To test: 1. Apply patch and update database. 2. Enable syspref "DefaultHoldExpirationdate" and set some values to "DefaultHoldExpirationdatePeriod" and "DefaultHoldExpirationdateUnitOfTime". 3. Add some holds for patron from staff client or OPAC and leave expiration date input field blank. => Holds expiration date should be set according your settings 4. Disable "DefaultHoldExpirationdate" and repeat step 3. => Expiration date shouldn't be set. Also prove prove t/db_dependent/Hold.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Isherwood Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27743] Accessibility: Staff Client - Page titles should have unique information first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27743 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27743] New: Accessibility: Staff Client - Page titles should have unique information first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27743 Bug ID: 27743 Summary: Accessibility: Staff Client - Page titles should have unique information first Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Koha has good and descriptive page titles, but according to https://www.w3.org/WAI/tips/writing/ the unique information should be first, before the name of the website (Koha). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27742] Accessibility: OPAC - Page titles should have unique information first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Assignee|oleon...@myacpl.org |wainuiwitikapark@catalyst.n ||et.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27742] New: Accessibility: OPAC - Page titles should have unique information first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 Bug ID: 27742 Summary: Accessibility: OPAC - Page titles should have unique information first Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Koha has good and descriptive page titles, but according to https://www.w3.org/WAI/tips/writing/ the unique information should be first, before the name of the website (Koha). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #8 from David Nind --- Can confirm that before the patch is applied on master using koha-testing-docker that there is a system error when clicking on Circulation > Holds ratios. Tested Koha 20.11.x and it works then, so something has broken it. The same error is recorded in Bug 21941 but that was created in 2018! I'm not smart enough to figure out what bug was introduced after 20.11.x that is causing it... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] New: Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 Bug ID: 27741 Summary: Accessibility: Staff Client - Headings should have correct tags and hierarchy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Each page of the Staff Client should contain correct headings with correct heading tags and hierarchy. Please see https://www.w3.org/WAI/tutorials/page-structure/headings/ for more information. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 dealt with changing the logo on each page to be a instead of an and then ensuring each page has one that tells users what the page is about. This bug will deal with ensuring the rest of the headings in each page follow the correct heading hierarchy, and headings don't skip a level. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |wainuiwitikapark@catalyst.n ||et.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] New: Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Bug ID: 27740 Summary: Accessibility: OPAC - Headings should have correct tags and hierarchy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Each page of the OPAC should contain correct headings with correct heading tags and hierarchy. Please see https://www.w3.org/WAI/tutorials/page-structure/headings/ for more information. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 dealt with changing the logo on each page to be a instead of an and then ensuring each page has one that tells users what the page is about. This bug will deal with ensuring the rest of the headings in each page follow the correct heading hierarchy, and headings don't skip a level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 --- Comment #4 from David Nind --- This now works if there is only one result. Thanks for updating to address that behaviour! However, pressing the back button after multiple results for a letter now results in: - the URL changing to members-home.pl - the page remaining with "Patrons found for: begins with 'D'" - the current list of results remaining (D used in this example) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 --- Comment #2 from Phil Ringnalda --- Bah, forgot the last two steps, 6. Set DefaultCountryField008 to abc 7. Repeat steps 2-3 and verify that the value for 15-17 is abc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 --- Comment #1 from Phil Ringnalda --- Created attachment 117126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117126=edit Bug 27738: Set fallback for unset DefaultCountryField008 to |||, "no attempt to code" Current code intended to set a fallback of xxu, an unknown state in the US, but because the preference is always defined, just sometimes unset, it actually falls back to three spaces, an invalid value. This patch instead uses the fallback value ||| which means no attempt to code. Test plan: 1. Without the patch, verify that the value of the system preference DefaultCountryField008 is empty. 2. Cataloging - New record - Default framework (if you have the Advanced editor enabled, Settings - Switch to basic editor, this only applies to the basic editor) 3. On tab 0, click in the text input for field 008 which fills in default values, then click the Tag editor button at the end of the field 4. In the popup window, verify that the value for 15-17 is shown as ### indicating three spaces 5. Apply patch, repeat the steps above, verify that the value is now ||| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 Phil Ringnalda changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27739] Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Phil Ringnalda changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 Phil Ringnalda changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 Phil Ringnalda changed: What|Removed |Added Blocks||27739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 [Bug 27739] Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27739] New: Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Bug ID: 27739 Summary: Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: p...@chetcolibrary.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 27738 cateditor-widgets-marc21.inc uses DefaultLanguageField008 for the initial value of the language in 008/35-37, but just hardcodes xxu rather than using the companion pref DefaultCountryField008 for 008/15-17. Since using the pref requires a fallback when it's unset, and bug 27738 proposes changing the current fallback in the basic editor, this bug should wait on an outcome there before being fixed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 Owen Leonard changed: What|Removed |Added Summary|Fix fallback for unset |Set fallback for unset |DefaultCountryField008 |DefaultCountryField008 to |system preference , "no attempt to code" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13912] Add syspref for default place of publication (country code) for field 008, range 15-17
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Phil Ringnalda changed: What|Removed |Added Blocks||27738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 [Bug 27738] Fix fallback for unset DefaultCountryField008 system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27738] New: Fix fallback for unset DefaultCountryField008 system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738
Bug ID: 27738
Summary: Fix fallback for unset DefaultCountryField008 system
preference
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs@lists.koha-community.org
Reporter: p...@chetcolibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
Depends on: 13912
Bug 13912 added DefaultCountryField008 to allow defaulting the place of
publication to something other than the previous default of xxu ("somewhere in
the United States, but I don't know what state"). Trying to follow the Koha
Way of never changing existing behavior, only adding a preference to fix it, it
intended to fall back to xxu, but
https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=cataloguing/value_builder/marc21_field_008.pl;h=b3c5d0c47f908edaa376b397a3bae5ecf8013c9e;hb=HEAD#l80
thought the preference would be undefined if it wasn't set, and then a QA
followup updated the DB to add it so it's always defined, and the // "xxu" is
unreached and the default value of the pref, '', gets space-padded to three
characters long, ' '.
Since we've now gone 3.3 years with the default having switched from the
unfortunate choice of 'xxu' to the invalid ' ' without anyone filing a bug
about it, I assert that the Koha Way is wrong in this case, that nobody
actually wanted to retain the behavior of defaulting to saying that every book
was published in an unknown US state (or if they did exist, they already fixed
it by using that as their DefaultCountryField008), and we can fix the bug of
defaulting to an invalid value by choosing a new default when
DefaultCountryField008 isn't set, the value "|||" which is "no attempt to code"
which is precisely the case when the cataloger doesn't change it and the system
adminstrator doesn't say it should have a particular value whether or not that
value is correct.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912
[Bug 13912] Add syspref for default place of publication (country code) for
field 008, range 15-17
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 --- Comment #11 from Owen Leonard --- Created attachment 117125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117125=edit Bug 27607: (QA follow-up) Make label match patron form: ZIP/Postal code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 Owen Leonard changed: What|Removed |Added Attachment #117090|0 |1 is obsolete|| Attachment #117091|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 117124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117124=edit Bug 27607: Add the ability to compare patron records during merge process This patch adds an option to compare two patron records during the patron merge process. It can't work with more than two patrons, so the option only appears if one has selected only two patrons to merge. This patch also adds links to the patron names for opening the patron record in a new tab. To test, apply the patch and perform a search for patrons in the staff client Patrons module. - Select two patrons in the list of search results and click "Merge selected patrons." - On the merge patron records page, confirm that the two patron names are links which, when clicked, open the patron details in another tab. - Click a radio button to select the patron whose record will be the basis of the merge. The "Compare patrons" button and "Merge patrons" should go from disabled to enabled. - Click the "Compare patrons" button. A modal window should display highlighting the differences in some selected values in the patron record. The patron you selected as the basis for the merge should appear on the left. - Close the modal and select the other patron as the basis of the merge. "Compare patrons" again. The other patron should now appear in the left pane of the comparison. - Test that the "Merge patrons" button in the modal window works correctly to submit the merge form and that the correct patron is used as the basis for merging. - Repeat the same process above but select more than two patrons for merging. The "Compare patrons" button should not appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 Owen Leonard changed: What|Removed |Added Attachment #117009|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 117123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117123=edit Bug 27725: Use JavaScript to set history state during patron search This patch modifies the patron search page so that clicks on the "Browse by last name" letters add an entry to the browser history, allowing the user to click back and forth from results while preserving their search. To test, apply the patch and go to Patrons in the staff interface. - Click one of the "Browse by last name" letters. - The table of search results should load the correct data. - In the browser's location bar you should see a query string added to the URL, e.g. /cgi-bin/koha/members/members-home.pl?firstletter=Q - Click another letter. - Click the back button. You should be returned to the search results for your first letter choice. - Clicking the forward button should work correctly as well. - Other patron searches (header search, sidebar search) should continue to work as expected. EDIT: Clear single-letter querystring history item if only one result was returned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27699] Add register information to responsive staff interface header menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27699 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes: - Also need to set UseCirculationDesks to Use. - With Firefox you can also use Ctrl+Shift+M to test with different screen sizes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27699] Add register information to responsive staff interface header menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27699 David Nind changed: What|Removed |Added Attachment #116847|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 117122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117122=edit Bug 27699: Add register information to responsive staff interface header menu This patch adds register information to the version of the header menu shown when the browser width is narrower. To test, apply the patch and enable the UseCashRegisters system preference. - If necessary, create at least one cash register for your library under Administration -> Cash registers. - From any page in the staff interface you should see a menu in the header showing your username and logged-in branch. - Expand the menu and choose "Set library, desk and register." - Select a cash register and save. - The cash register information should now appear in the header menu. - Narrow the width of the browser until the menu collapses and shows only a user icon. - When you expand this version of the menu you should see the currently-suggested register. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27699] Add register information to responsive staff interface header menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27699 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #16 from David Nind --- Patch no longer applies 8-( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27071: Fix Hold pickup library when using hold groups Applying: Bug 27071: Code simplification error: sha1 information is lacking or useless (Koha/Library.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27071: Code simplification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||p...@chetcolibrary.org --- Comment #4 from Phil Ringnalda --- A space is an invalid character in some positions, a character with a particular meaning in some positions, and only rarely a synonym for "dunno what should be here." | is closer to the mark, since it's defined as "no attempt to code" for every position except 0-5. However, just pipe-padding instead of space-padding won't work except in the case where value.length going into the plugin was 39, because if it's 38 or less, the plugin is *broken*. If the length going in is 37 (delete everything back to and including position 37, the last letter of the language) and you then use the plugin to change the value for one of the last two positions, your value will actually be put into position 37 rather than where it belongs. Do what seems reasonable until you try it, type 210220s in the text input and then trigger the plugin, and fill things in in random order, first setting the Cataloging source so you don't forget, then seeing that Index and Literary form and Biography are wrong and changing them, then going back up to put in your single date without realizing you're also supposed to put in spaces for the second date, then go back down and put in the language, then back up for the place of publication. You now have a random-length 008 with random letters in random spots. So, three cases: The value going into the plugin is 0 characters long. That is already handled by creating a value with some imperfect default values The value going into the plugin is 1 to 5 characters long. That's a broken date-entered, which can't be fixed with pipes, it can only be deleted and treated the same as 0 characters. The value going into the plugin is 6-39 characters long, which can be fixed by either applying our somewhat imperfect default values to any missing characters, or less-imperfectly by pipe-filling. Inconveniently, you can't just pad with either pipes or the remaining characters from our default blindly, since filling position 35-39 with pipes is just fine, but filling position 36-39 is invalid, since "e||" is not a valid language code. So it's an awkward case of length 6-7 you can pad, 8-11 you have to truncate to 7 and pad, 12 you can pad, 13-15 you have to truncate to 12 and pad, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
