[Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Fridolin Somers --- Ah good point -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 --- Comment #14 from Jonathan Druart --- Before: https://snipboard.io/38blZ0.jpg After : https://snipboard.io/u0JDBm.jpg It was a bit nicer before as it was centered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Martin Renvoize changed: What|Removed |Added CC||ian.b...@ptfs-europe.com, ||jon.tur...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize --- This works well in my testing, signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27695] Fix style of messages on Elasticsearch configuration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #11 from Martin Renvoize --- (In reply to Owen Leonard from comment #10) > I agree. I was going to suggest that the distinction be made between > "requires the user to make a choice in order to proceed," and "the operation > cannot be completed at all for some reason." I've added it to the dev meeting agenda, thanks Owen :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #32 from Martin Renvoize --- Great to see this one in.. , I'm going to spend some time on bug 22824 today. It'll be fantastic to get Koha onto one consistent yaml handler :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690
--- Comment #47 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #46)
> (In reply to Jonathan Druart from comment #44)
> > -if ( $res->{'itemnumber'} && $res->{'itemnumber'} ==
> > $itemnumber && $res->{'priority'} == 0) {
> >
> > Why did you remove that test?
>
> Thanks for asking. The reason I removed the line is because it equivalent of
> a reserve being found / attached and now we finally handle all the different
> cases so doing the check twice is not necessary. If you look at the patch
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67411 (bug
> 19116) then it should be really clear. Previously the "Reserved" return
> value had double usage/meaning, firstly it could mean an unattached hold
> (biblio or item level) or secondly it could have meant an attached hold in
> transfer. Please see the explanation also in the commit message.
And to explain even a bit more verbosely: The "$res->{'priority'} == 0" makes
the hold found/attached (when combined together with itemnumber).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690
--- Comment #46 from Joonas Kylmälä ---
(In reply to Jonathan Druart from comment #44)
> -if ( $res->{'itemnumber'} && $res->{'itemnumber'} ==
> $itemnumber && $res->{'priority'} == 0) {
>
> Why did you remove that test?
Thanks for asking. The reason I removed the line is because it equivalent of a
reserve being found / attached and now we finally handle all the different
cases so doing the check twice is not necessary. If you look at the patch
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67411 (bug 19116)
then it should be really clear. Previously the "Reserved" return value had
double usage/meaning, firstly it could mean an unattached hold (biblio or item
level) or secondly it could have meant an attached hold in transfer. Please see
the explanation also in the commit message.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Mason James changed: What|Removed |Added Priority|P5 - low|P1 - high Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #41 from Mason James --- Created attachment 117630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117630=edit Bug 26363: Remove tmp file during package build (follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Mason James changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Mason James changed: What|Removed |Added Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 Bug 27844 depends on bug 26363, which changed state. Bug 26363 Summary: Provide a systemd unit file for background_jobs_worker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Mason James changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 Bug 27844 depends on bug 26363, which changed state. Bug 26363 Summary: Provide a systemd unit file for background_jobs_worker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Mason James changed: What|Removed |Added Keywords||additional_work_needed Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Mason James changed: What|Removed |Added Status|Pushed to stable|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27742] Accessibility: OPAC - Page titles should have unique information first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 --- Comment #1 from wainuiwitikap...@catalyst.net.nz --- Created attachment 117629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117629=edit Bug 27740: Corrected tags & hierarchy of headings Bug 27610 corrected the tags in each of the OPAC files. This patch corrects the hierarchy of the rest of the headings on each of the pages. To test: 1) Go to the OPAC 2) Apply Bug 27610 patch 3) Apply patch (Bug 27740) 4) Go to each of the pages and check that the headings under are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27814] Improve responsive behavior of the user page in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27814 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- Owen, Two things I encountered here: On smaller screens (500px or less) the .dt-buttons within the toolbar become hard to see. This is only on the checkout's tab. Also the iCal button ins't inside of a button element so it doesn't line up nicely with the other buttons inside that toolbar. https://snipboard.io/O0Qkvd.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16700] Quick spine label creator: Make css configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 --- Comment #5 from Lucas Gass --- Already you can add CSS to the IntranetUserCSS system preference and it will effect labels on spinelabel-print.tt. Is there any reason why we should have a separate pref? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #32 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #26) > Mojolicious uses pretty standard semantic versioning.. jump a major and you > can't really expect things to work. > > The latest combination of dependencies I found to work with current Koha is: > > Mojolicous 8.73 > JSON::Validator 4.05 > Mojolicious::Plugin::OpenAPI 3.39 > > If we wanted to jump beyond that we'll need to change the Koha codebase to > accommodate the changes in the libraries. > > What's easier, backporting new libraries to older Debian (and updating our > codebase for the newer libraries) or downgrading/pinning older libraries on > newer Debian? > > > Or, dare I say it.. shipping a local clone of the Mojo stack inside Koha. We should do that. And jump to current versions of the OpenAPI plugin and Mojolicious 8.x. if not possible to package them, of course. I think there was a Perl version issue with stretch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #31 from Mason James --- (In reply to David Cook from comment #28) > (In reply to Jonathan Druart from comment #27) > > The short term solution is to package a 4.99+really3.25-koha > > Why? > > We should be able to provide the right dependency in the Koha apt repo and > specify the right dependency in the control file. no, it's impossible for us to do this because the version we want (3.25) is *lower* than the version available (4.13) in the debian.net/bullseye repo see... https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893#c16 ps: i would love to be proven incorrect on this info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #30 from Mason James --- (In reply to Jonathan Druart from comment #27) > The short term solution is to package a 4.99+really3.25-koha hi Jonathan, this is done $ cat /etc/apt/sources.list.d/koha.list deb http://debian.koha-community.org/koha-staging dev main bullseye $ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 4.99+really3.25-koha1 Candidate: 4.99+really3.25-koha1 Version table: *** 4.99+really3.25-koha1 500 500 http://debian.koha-community.org/koha-staging dev/bullseye amd64 Packages 100 /var/lib/dpkg/status 4.13+dfsg-1 500 500 http://apt.kohaaloha.com:3142/ftp.nz.debian.org/debian testing/main amd64 Packages 3.25+dfsg-1+koha3 500 500 http://debian.koha-community.org/koha-staging dev/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #117626|0 |1 is obsolete|| --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 117628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117628=edit Bug 27837: Add unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rhonda Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #117625|0 |1 is obsolete|| --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 117627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117627=edit Bug 27837: Update permanent location if passed into ModItemFromMarc Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #117570|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 117625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117625=edit Bug 27837: Update permanent location if passed into ModItemFromMarc Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #117572|0 |1 is obsolete|| --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 117626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117626=edit Bug 27837: Add unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #7 from Andrew Fuerste-Henry --- Talked to Kyle, clarified expected behavior. Tests pass with patch applied but permanent_location not mapped in Koha to MARC Mapping. Once it's added to Koha to MARC Mapping, tests fail. This is expected behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Andrew Fuerste-Henry --- Tests fail if permanent_location is mapped to something in Koha to MARC Mapping. root@kohadevbox:koha(master)$ prove t/db_dependent/Items.t t/db_dependent/Items.t .. 11/14 # Failed test 'new permanent location set as expected' # at t/db_dependent/Items.t line 1057. # got: 'A' # expected: 'B' # Failed test 'permanent location remains unchanged as expected' # at t/db_dependent/Items.t line 1078. # got: 'A' # expected: 'B' # Looks like you failed 2 tests of 6. # Failed test 'permanent_location' # at t/db_dependent/Items.t line 1079. # Looks like you failed 1 test of 6. # Failed test 'ModItemFromMarc' # at t/db_dependent/Items.t line 1082. # Looks like you failed 1 test of 14. t/db_dependent/Items.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/14 subtests Test Summary Report --- t/db_dependent/Items.t (Wstat: 256 Tests: 14 Failed: 1) Failed test: 14 Non-zero exit status: 1 Files=1, Tests=14, 5 wallclock secs ( 0.02 usr 0.00 sys + 3.11 cusr 0.47 csys = 3.60 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4037] Inventory tool missing item type filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4037 Caroline Cyr La Rose changed: What|Removed |Added Keywords|Manual | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- Test plan: 1 - Map permanent_location to a marc field 2 - Expose that field in the item editor 3 - Edit an item, changing location to X and permanent location to Y, save 4 - confirm record shows location=x, permanent_location=y 5 - Edit item again, change location to Z, do not change permanent location, save 6 - confirm location and permanent_location both equal Z 7 - apply patch, restart 8 - repeat steps 3-5 9 - confirm location=Z, permanent location=Y 10 - prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27854] Clean GET /patrons controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27855 [Bug 27855] Allow embedding extended_attributes on /patrons routes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27855] Allow embedding extended_attributes on /patrons routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27855 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27854 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 [Bug 27854] Clean GET /patrons controller -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27855] New: Allow embedding extended_attributes on /patrons routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27855 Bug ID: 27855 Summary: Allow embedding extended_attributes on /patrons routes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27854] Clean GET /patrons controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27854] Clean GET /patrons controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 117624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117624=edit Bug 27854: Clean GET /patrons controller The controller method was written a lot of time before the enhancements we added to the objects.search helper, and it is now much easier to handle the 'restricted' param use case. No need to do it like that anymore. This patch fetches the 'restricted' param from the query parameters and cleans it from the validated data, so we can just pass the resultset to $c->objects->search as in all other controllers. And we had tests for the expected behavior, so testing this is as easy as: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! Of course! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27853] POST /patrons doesn't enforce mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 [Bug 27854] Clean GET /patrons controller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27854] Clean GET /patrons controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27853 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853 [Bug 27853] POST /patrons doesn't enforce mandatory extended attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27854] Clean GET /patrons controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27854] Clean GET /patrons controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27854] New: Clean GET /patrons controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27854 Bug ID: 27854 Summary: Clean GET /patrons controller Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com The controller has a hardcoded version of objects.search and should be cleaned up, to gain superpowers and make it extendable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #2 from Caroline Cyr La Rose --- After rereading the test plan, I realize it's not very clear... For step 1, I first deleted everything from the default (and ACQ) framework in marc_subfield_structure and marc_tag_structure delete from marc_subfield_structure where frameworkcode = ""; delete from marc_subfield_structure where frameworkcode = "ACQ"; delete from marc_tag_structure where frameworkcode = ""; delete from marc_tag_structure where frameworkcode = "ACQ"; Then, I used the load_yaml script to reload the marc21_framework_DEFAULT.yml file ./misc/load_yaml.pl -f ../installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 117623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117623=edit Bug 27852: Link YES_NO authorized value category to 942dev in Default framework This patch add the YES_NO authorised value category to 942dev in the Default framework and sets the default value to 0 (No). To test: 1) Load the yaml file (I used the load_yaml.pl script after deleting the values from my database) 2) Go to cataloging and open an empty cataloging form using the Default framework 3) Go to 942$n: the value should read No and there should be a drop down choice between Yes and No -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- If there are multiple values for a field, then the link/search only picks up the first item. For example: 260$a with two values Beijing ; Sebastopol, CA : ==> single link, not linked individually, search is http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=pl:%22Beijing%20%3B%22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366 --- Comment #19 from Martin Renvoize --- And rebasing then testing bug 25260 is next on my list :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26959] Reindent batch item modification template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 --- Comment #13 from Owen Leonard --- (In reply to Owen Leonard from comment #12) > Current status: Failed QA Sorry, git-bz mistake -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26959] Reindent batch item modification template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 --- Comment #12 from Owen Leonard --- Created attachment 117622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117622=edit Bug 26959: (follow-up) Fix CSS for column selection labels This patch modifies the staff interface SCSS in order to fix the display of column selection checkbox labels on the batch item modification page. Even though the style of the elements defines the "white-space" as "nowrap," adding whitespace within the element (as was done to correct indentation) still created problems. Changing the display property of the elements to "inline-block" corrects this. Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26959] Reindent batch item modification template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 Owen Leonard changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27853] POST /patrons doesn't enforce mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853
--- Comment #1 from Martin Renvoize ---
How about an array of extended_attribute objects?
"extended_attributes": [
{ "type": "whatever", "code": "yup" },
{ "type": "another", "code": "top" }
]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 --- Comment #13 from Owen Leonard --- Created attachment 117621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117621=edit Bug 25846: (follow-up) Show "No cover image available" message This patch restores the use of a "No cover image available" message in staff interface search results when no cover image was found by any image service. The patch also corrects markup in the search results template which was preventing the "Adlibris cover image" text from being correctly hidden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #4 from Kyle M Hall --- (In reply to Jonathan Druart from comment #1) > Can you have a look at bug 27545? I feel like the second patch will fix this. It does not. I ran some manual tests that failed, and also ran the unit tests from this patch set, which also failed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27853] POST /patrons doesn't enforce mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27853] POST /patrons doesn't enforce mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add API route for additional patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27853 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27853] POST /patrons doesn't enforce mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23666 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27853] New: POST /patrons doesn't enforce mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853
Bug ID: 27853
Summary: POST /patrons doesn't enforce mandatory extended
attributes
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
If there are extended attributes types that are mandatory, the POST /patrons
route should fail if the request doesn't meet this requirement.
Unfortunately, we have no way (yet) to pass extended attributes on the POST. So
to solve this bug, we need to add a way to pass extended attributes along with
the patron object.
I propose:
POST /patrons
{
"first_name": "Tomasito",
...
"extended_attributes": {
"SHOW_BCODE": [ 1 ],
"COURSES": [ "ALGO1", "DATABASES" ]
}
}
I choose to force them to be arrays for simplicity (they can be repeatable),
but we can check the data type on the controller (i.e. if (
ref($extended_attributes) eq 'ARRAY') { # loop case } else { # scalar case } ).
I'm open for opinions.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Can you update the wiki page please? > > (In reply to Tomás Cohen Arazi from comment #0) > > It would be handy to have, for rendering patron's holds tables. > > So you had in mind reserves AND old_reserves? > What would be a route for hold's history? My idea was that once bug 25260 got pushed, we could easily add a query param (like include_completed=1) to retrieve all of them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --- Comment #12 from Jonathan Druart --- We lost the "No cover image available" thumbnails. Owen, can you have a look at it please? You can attach a follow-up fix here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27851] Add Koha::Old::Checkouts->filter_by_todays_checkins method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24309] Holds on multiple in the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24309 --- Comment #3 from Marie-Luce Laflamme --- there is another bug about the OPAC side https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366 --- Comment #17 from Jonathan Druart --- Can you update the wiki page please? (In reply to Tomás Cohen Arazi from comment #0) > It would be handy to have, for rendering patron's holds tables. So you had in mind reserves AND old_reserves? What would be a route for hold's history? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27852] New: Link YES_NO authorized value category to 942$n in Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Bug ID: 27852 Summary: Link YES_NO authorized value category to 942$n in Default framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When OpacSuppression is set to Hide, a value of 1 in 942$n will hide the record from the OPAC, whereas a value of 0 or empty will show the record in the OPAC. I think it would be logical to link the authorized value category "YES_NO" to the 942$n field in the Default framework. I usually add the link manually for all new installations (and sometimes I forget), but I feel like it's a normal use. Maybe we could add it to master? And also add 0 as default value, just to make sure the Yes is not selected by default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #17 from Jonathan Druart --- The store method should be improved to set expirationdate only if reservedate has been modified, to avoid unnecessary processing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #45 from Jonathan Druart --- I am a bit tired right now to deep into the whole changes, but basically the line you removed was making sure we returned there for item-level holds, but @reserves can contain biblio-level holds (line 1766 AND (reserves.itemnumber IS NULL OR reserves.itemnumber = ?)). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #44 from Jonathan Druart
---
-if ( $res->{'itemnumber'} && $res->{'itemnumber'} == $itemnumber
&& $res->{'priority'} == 0) {
Why did you remove that test?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add API route for additional patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #4 from Tomás Cohen Arazi --- I'm submitting an RFC proposal, to sumarize: GET/patrons/:patron_id/extended_attributes POST /patrons/:patron_id/extended_attributes PUT/patrons/:patron_id/extended_attributes <- to overwrite them all DELETE /patrons/:patron_id/extended_attributes/:extended_attribute_id Extended attributes could be queried by 'extended_attribute_type' to address the original 'more granular' approach. I would add that the POST /patrons route needs to be extended to allow passing an 'extended_attributes' attribute, and that if there are some 'mandatory' extended attributes missing, patron creation should fail. GET /patrons/:patron_id could be extended to be able to 'embed' the extended attributes as well. The last two proposals should belong to their own bugs. I will file them once I have everything settled. There's also the need to implement: GET/extended_attribute_types GET/extended_attribute_types/:extended_attribute_type_id POST /extended_attribute_types PUT/extended_attribute_types/:extended_attribute_type_id DELETE /extended_attribute_types/:extended_attribute_type_id And as types can be constrained by branch/library and patron category, we could think of a route for fetching types so we can use it to render forms. I still didn't find a suitable layout, will file a bug once I clear my mind, unless someone beats me to it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #72 from Jonathan Druart --- Should not we format the date (today) using the $KohaDates TT filter? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #71 from Jonathan Druart --- Created attachment 117620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117620=edit Bug 12224: Some code improvements * Use Koha::Patrons->old_checkouts * perltidy * Make sure $today_start and $today_end will always be on the same day (we never know!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Martin Renvoize changed: What|Removed |Added CC||ere.maij...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Martin Renvoize changed: What|Removed |Added Attachment #113501|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27851] Add Koha::Old::Checkouts->filter_by_todays_checkins method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Jonathan Druart changed: What|Removed |Added Depends on||12224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 [Bug 12224] Allow easy printing of patron check-in slip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Jonathan Druart changed: What|Removed |Added Blocks||27851 --- Comment #70 from Jonathan Druart --- I opened bug 27851. Please help testing it when patches will be attached! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 [Bug 27851] Add Koha::Old::Checkouts->filter_by_todays_checkins method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Martin Renvoize changed: What|Removed |Added Attachment #114229|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 117619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117619=edit Bug 26312: (follow-up) Reset buffers even if commit fails Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #10 from Martin Renvoize --- Created attachment 117618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117618=edit Bug 26312: Catch ES Client errors, log, and continue indexing when error encountered This catches a timeout response from the ES server, logs this, and continues the indexing To test: 1 - perl misc/search_tools/rebuild_elasticsearch.pl 2 - Make the ES server timeout (I don't have good instruction yet) 3 - Watch the job crash 4 - Apply patches 5 - perl misc/search_tools/rebuild_elasticsearch.pl 6 - Make the server timeout 7 - Note the job reports failed commit, and continues Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27851] New: Add Koha::Old::Checkouts->filter_by_todays_checkins method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Bug ID: 27851 Summary: Add Koha::Old::Checkouts->filter_by_todays_checkins method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Bug 12224 is adding code in the controller to retrieve today's checkins. There is already kind of the same code in members/readingrec.pl (op=export_barcodes). We should provide a Koha::Old::Checkouts->filter_by_todays_checkins method, provide tests, and use it in both places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #69 from Jonathan Druart --- (In reply to Martin Renvoize from comment #68) > I would love to see the database call moved into Koha::Patron as a method > (->todays_checkins perhaps) and as such have a unit test associated with > it.. but we can handle that in another bug. That's (almost) exactly what I was coming to write. There is already kind of the same code in members/readingrec.pl (op=export_barcodes). We should provide a Koha::Old::Checkouts->filter_by_todays_checkins method and use it in both places. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add API route for additional patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add API route for additional patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add API route for additional patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added CC||lari.task...@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add API route for additional patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #3 from Martin Renvoize --- *** Bug 26674 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26674] Extended patron attributes REST endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26674 Martin Renvoize changed: What|Removed |Added Status|NEW |RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |DUPLICATE --- Comment #2 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 23666 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 --- Comment #5 from Tomás Cohen Arazi --- Tested this patches and they work as expected: - Tests pass - Adding/editing an item has the expected behavior - Creating items from Acquisitions (on placing the order) also follows the default - QA script is happy Note about serials: when it comes to serials, the new subscription form doesn't default to the syspref. I believe this is the correct behavior so we don't change people's workflow. The location dropdown works as a local-to-the-subscription default for items, which is respected in the following steps, the edge case would be setting it to 'None' and checking the item is not defaulting to the NewItemsDefaultLocation value. TL;DR Works as expected, if someone really needs the serial subscription form default the Location option to some value, it should be discussed on an enhancement bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 Jonathan Druart changed: What|Removed |Added Attachment #117452|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart --- Created attachment 117617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117617=edit Bug 27048: (follow-up) Correction to elapsed printing JD Amended patch: Remove perlcritic error "$d" is declared but not used at line 839, column 5. Unused variables clutter code and make it harder to read. (Severity: 3) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 117616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117616=edit Bug 27545: Keep the location if passed Change in behaviour here, but expect. We must keep the location value if passed to store. Same for the permanent_location Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 117615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117615=edit Bug 27545: Use NewItemsDefaultLocation from places where an item is created The syspref NewItemsDefaultLocation is used to set a default value for item's location. But it seems that there are some weirdness in the behaviour: 1. It's only used from additem. It seems that it should be used from acq and serial modules as well. And maybe for the items import too. 2. It set the location even if another one has been picked from the UI => We UI must preselect the syspref's value, but the controller must pick what has been selected on the UI This patch is adding the default to the UI and extend the use of the pref to other areas. Test plan: Set a value to NewItemsDefaultLocation Catalogue a new item and confirm that the syspref's value is picked to selected the default value on the add item form Same behaviour should apply to the acquisition and serial modules When importing items, the default location must be used if the imported items did not have a location defined. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 Tomás Cohen Arazi changed: What|Removed |Added Attachment #115775|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 Tomás Cohen Arazi changed: What|Removed |Added Attachment #115776|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Blocks||23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Patron restrictions should be user definable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Depends on||24975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 [Bug 24975] Refactor database translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #74 from Martin Renvoize --- The customer requires being able to change the hard coded values.. as such this bug is blocked until we have translatable authorized values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27430] Use minimum length for patron category on password hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Caroline Cyr La Rose changed: What|Removed |Added Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27745] Use of uninitialized value in hash element error at C4/Search.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27745
Didier Gautheron changed:
What|Removed |Added
Attachment #117554|0 |1
is obsolete||
--- Comment #5 from Didier Gautheron ---
Created attachment 117614
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117614=edit
Bug 27745: prevent warning for uninitialized value as a hash key
When you edit and save items with an empty "c - Shelving location"
field, it gets stored into the database as "NULL",
which is allowed in the database, and the field is not "required",
so this seems expected.
But when the search page is rendered, it gets value by location key
($shelflocations->{ $item->{location} }) which gives undef warning.
Solved by checking if $item->{location} is perl true.
To reproduce:
1) Edit the book or create new one with an empty shelving location.
2) Use the search feature to have that book in the searched list.
3) Check plack-intranet-error.log to find "Use of uninitialized
value in hash element" error.
4) Apply the patch.
5) Repeat the search and check the logs again to ensure that error
didn't appear again.
Signed-off-by: Didier Gautheron
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
