[Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

--- Comment #6 from Victor Grousset/tuxayo  ---
Works, QA tools ok, code looks good but just one question about plugin stuff:

Why is [% PROCESS plugin_pars %] needed?
And what does $plugin? ( public => 1 ): (), do?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #115373|0   |1
is obsolete||

--- Comment #5 from Victor Grousset/tuxayo  ---
Created attachment 118882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118882=edit
Bug 25476: Add ability to browse file uploads by category

This patch adds the ability to search/browse files by category.
(Note it doesn't include temporary uploads since they don't have
 a "category" per se.)

Test Plan:
0) Apply patch
1) Go to /cgi-bin/koha/admin/authorised_values.pl
2) Create "UPLOAD" authorized value category
3) Create "test" authorized value in "UPLOAD" category
4) Go to /cgi-bin/koha/tools/upload.pl
5) Note "Search uploads by category" fieldset
6) Upload new file to "test" category
7) Click "Back"
8) Choose "test" category in "Search uploads by category"
9) Click "Search"
10) Note that your file upload is displayed in result list

Signed-off-by: Mazen Khallaf 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #16 from Victor Grousset/tuxayo  ---
Somehow the default value displayed in the UI is "Don't hide". The DB shows
that the value is '1'.
When toggling the syspref, the value is 'yes' and 'no'.
So I tried with 'yes' instead of '1' in atomicupdate/bug_18989.sql but the
default value is still '1' in the DB and "Don't hide" in the UI.

Any hints?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA

--- Comment #23 from Victor Grousset/tuxayo  ---
It works, tested with various values for edge cases.
Code looks good
QA script ok

Passed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #115908|0   |1
is obsolete||

--- Comment #22 from Victor Grousset/tuxayo  ---
Created attachment 118881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118881=edit
Bug 25429: Script should be able to run with only return claims

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #115907|0   |1
is obsolete||

--- Comment #21 from Victor Grousset/tuxayo  ---
Created attachment 118880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118880=edit
Bug 25429: Cleanup Database - remove resolved claims returned from db after X
days

Add option to cleanup_database script to removed 'resolved' return claims from
the database after a specified number of days.

Test Plan:
1) Apply this patch
2) Set the new syspref CleanUpDatabaseReturnClaims to a number of days
3) Run cleanup_database.pl
4) Note resolved claims older than the specified number of days are removed
from the database

Bug 25429: Implement system preference, remove command line switch

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28030] searching is not working

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28030

--- Comment #2 from PTFS Europe Sandboxes  ---
Created attachment 118879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118879=edit
Bug 27835: DBRev 20.12.00.025

Signed-off-by: Amarangi  

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26129] Add a new 'configurations' table

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #12 from David Nind  ---
Patches no longer apply 8-(..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24000] Some modules do not return 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #12 from David Nind  ---
Tested by running prove t/db_dependent/Koha/Item/Search/Field.t before and
after applying patches. Hope that is sufficient.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24000] Some modules do not return 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000

David Nind  changed:

   What|Removed |Added

 Attachment #115290|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 118878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118878=edit
Bug 24000: Some modules do not return 1

This patch adds "1;" to the end of the following perl files:
Koha/Filter/MARC/EmbedItemsAvailability.pm
Koha/Filter/MARC/EmbedSeeFromHeadings.pm
Koha/Filter/MARC/Null.pm
Koha/Item/Search/Field.pm
Koha/SearchEngine.pm
misc/translator/VerboseWarnings.pm
t/lib/Koha/Plugin/Test.pm

This indicates the succesful execution of the initialization code.

Test plan:
Ensure that there are no other perl files that need "1;", but dont have
it.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24000] Some modules do not return 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000

David Nind  changed:

   What|Removed |Added

  Attachment #95199|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 118877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118877=edit
Bug 24000: Koha::Item::Search::Field does not return 1

Test plan:
Run t/db_dependent/Koha/Item/Search/Field.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24000] Some modules do not return 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28043] Some patron clubs operations don't work from later pages of results

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043

--- Comment #1 from Owen Leonard  ---
Created attachment 118876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118876=edit
Bug 28043: Some patron clubs operations don't work from later pages of results

This page changes the way event handlers are defined for some operations
on the patron clubs page. These changes make it possible for the
controls to work on multi-page tables of clubs.

To test, apply the patch and got to Tools -> Patron clubs.

- If necessary, add enough patron club templates and patron clubs that
  there are more than 10 of each.
- Click to the second page of club templates and try to delete a
  template. It should work correctly.
- Click to the second page of clubs and try to delete a club. It should
  work correctly.
- Add one or more patrons to a club (from the checkout or patron details
  page).
- Click to the second page of clubs and try the "Search to hold" menu
  item. It should redirect you to the search page.
- After entering a search, the results page should include "Place hold
  for " links with each result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28043] Some patron clubs operations don't work from later pages of results

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

David Nind  changed:

   What|Removed |Added

 Attachment #118866|0   |1
is obsolete||

--- Comment #16 from David Nind  ---
Created attachment 118875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118875=edit
Bug 15788: Use delete_borrowers permission

Link the new delete_borrowers sub-permission to the delete actions.

Test plan
1/ Remove the delete_borrowers permission from a staff user
2/ Check that the user cannot use the 'Delete' option from the members
menu.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

David Nind  changed:

   What|Removed |Added

 Attachment #118865|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 118874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118874=edit
Bug 15788: Add delete_borrowers permission

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27749] Phase out jquery.cookie.js: Search to hold

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749

Owen Leonard  changed:

   What|Removed |Added

 Depends on||28043


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043
[Bug 28043] Some patron clubs operations don't work from later pages of results
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28043] New: Some patron clubs operations don't work from later pages of results

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043

Bug ID: 28043
   Summary: Some patron clubs operations don't work from later
pages of results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Blocks: 27749

On the patron clubs page, the clubs and club templates are each displayed in a
paginated DataTable. JavaScript-driven controls in these tables don't work
because the event handler doesn't take into account that the HTML elements may
not be present in the initial page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27749
[Bug 27749] Phase out jquery.cookie.js: Search to hold
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28033] Minor capitalization corrections

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28033

David Nind  changed:

   What|Removed |Added

 Attachment #118823|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 118873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118873=edit
Bug 28033: Fix minor capitalization errors

This patch corrects capitalization in two templates:

- Administration -> Desks:
  "Modify Desk" / "New Desk" -> "Modify desk", "New desk" in breadcrumbs
  menu.
- Reports -> Most-circulated items:
  "Most-circulated Items" -> "Most-circulated items" in breadcrumbs.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28033] Minor capitalization corrections

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28033

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28035] Improve breadcrumbs of cataloging search page

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28035

David Nind  changed:

   What|Removed |Added

 Attachment #118832|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 118872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118872=edit
Bug 28035: Improve breadcrumbs of cataloging search page

This patch expands the logic around the cataloging search page's
breadcrumbs so that more context is provided in the breadcrumbs menu.

The page title should also reflect this change.

Some markup in the body of the page has been updated to clarify the page
structure using headings.

To test, apply the patch and go to Cataloging.

 - The page title and breadcrumbs menu should show "Home > Cataloging"
 - Perform a search which will return results from the catalog, from the
   reservoir, or both. The page title and breadcrumbs menu should show:
   "Home > Cataloging > Search results."
 - Perform a search which will return no results. The page
   title and breadcrumbs should be: "Home > Cataloging > No results
   found."

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28035] Improve breadcrumbs of cataloging search page

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28035

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28036] Improve breadcrumbs of serial claims page

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036

Lucas Gass  changed:

   What|Removed |Added

 Attachment #118835|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 118871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118871=edit
Bug 28036: Improve breadcrumbs of serial claims page

This patch modifies the serial claims script and templates so that
better context can be shown in the page title and page breadcrumbs when
a vendor has been selected.

To test, apply the patch and go to Serials -> Claims.

- The initial state of the page title and breadcrumbs should show
  "Serials > Claims."
- Select a vendor. The page title and breadcrumbs show show "Serials >
  Claims > Claims for ."

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28036] Improve breadcrumbs of serial claims page

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28041] Improve breadcrumbs and headings on label creator pages

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28041

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #3 from Lucas Gass  ---
In the test plan you say the breadcrumbs should be:

- New -> Label template: "Label creator -> New label template."
- New -> Printer profile: "Label creator -> New printer profile."

In fact they are

- New -> Label template: "Label creator -> Templates -> New label template."
- New -> Printer profile: "Label creator -> Profiles -> New printer profile."


But I think the later is actually correct, therefore I'm signing off. 

I like these improvements to the breadcrumbs!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28041] Improve breadcrumbs and headings on label creator pages

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28041

Lucas Gass  changed:

   What|Removed |Added

 Attachment #118850|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 118870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118870=edit
Bug 28041: Improve breadcrumbs and headings on label creator pages

This patch changes various label creator templates so that breadcrumbs
menus and headings are more specific to each operation.

To test, apply the patch and confirm that headings, page titles, and
breadcrumbs menus are correct for the various pages:

- New -> Label batch: "Label creator -> Batches -> New label batch."
- New -> Layout: "Label creator -> Layouts -> New label layout."
- New -> Label template: "Label creator -> New label template."
- New -> Printer profile: "Label creator -> New printer profile."
- New -> Barcode range: "Label creator -> Print barcode range."
- Manage -> Label batch -> Edit: "Label creator -> Batches -> Edit
  label batch X."
- Manage -> Layout -> Edit: "Label creator -> Layouts -> Edit label
  layout X."
- Manage -> Label templates -> Edit: "Label creator -> Templates -> Edit
  label template X."
- Manage -> Printer profiles -> Edit: "Label creator -> Profiles -> Edit
  printer profile X."

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28041] Improve breadcrumbs and headings on label creator pages

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28041

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #242 from Tomás Cohen Arazi  ---
Martin and I are working heavily on this one for QA. Marking as assigned just
in case, to avoid overlapping with others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" on navigation menu

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

Owen Leonard  changed:

   What|Removed |Added

 Attachment #118857|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 118869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118869=edit
Bug 28006: Restore "Additional fields" on navigation menu

This patch adds a link to the "Additional fields" page in Administration
to the sidebar menu shown on Serials pages.

To test, apply the patch and go to Serials.

- In the sidebar menu you should see a "Manage subscription fields"
  link.
- The link should take you directly to the "Additional fields for
  'subscription'" page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" on navigation menu

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" on navigation menu

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
(In reply to Séverine Queune from comment #2)

> For a staff user without the 'manage_additionnal_fields' permission

Thanks Séverine, I looked for and missed that permission in the script!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28034] Add DataTables to lists of clubs in "Clubs" tabs on patron account

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28034

Owen Leonard  changed:

   What|Removed |Added

 Attachment #118864|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 118868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118868=edit
Bug 28034: Make club enrollment tables in to DataTables

To test:
-Add some clubs
-Go to a patron record and enroll them in some clubs but not in others.
-There should be two table under the clubs tab, Clubs currently
 enrolled in and Clubs not enrolled in
-Neither are DataTables
-Apply patch
-With the same patron check the clubs tab, they should be datatables
 now
-Make sure all the controls, pagination works good

https://bugs.koha-community.org/show_bug.cgi?id=28033

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28034] Add DataTables to lists of clubs in "Clubs" tabs on patron account

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28034

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #10 from Lucas Gass  ---
(In reply to Kyle M Hall from comment #9)
> It looks like we could optionally disable validation in TinyMCE:
> https://stackoverflow.com/questions/7058623/tinymce-completely-disable-
> validation

verify_html: false is already set when initializing TinyMCE. Maybe we should
add these other lines to the config:


cleanup_on_startup: false,
trim_span_elements: false,
cleanup: false,
convert_urls: false

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

--- Comment #14 from Martin Renvoize  ---
Thanks for testing David.. I found the issue, I'd neglected to add one of the
files to the final commit!

All sorted now, should be working this time around.. Doh!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #115092|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 118866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118866=edit
Bug 15788: Use delete_borrowers permission

Link the new delete_borrowers sub-permission to the delete actions.

Test plan
1/ Remove the delete_borrowers permission from a staff user
2/ Check that the user cannot use the 'Delete' option from the members
menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #115091|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 118865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118865=edit
Bug 15788: Add delete_borrowers permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #9 from Kyle M Hall  ---
It looks like we could optionally disable validation in TinyMCE:
https://stackoverflow.com/questions/7058623/tinymce-completely-disable-validation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" on navigation menu

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

--- Comment #2 from Séverine Queune  ---
(In reply to Owen Leonard from comment #1)
> - In the sidebar menu you should see a "Manage subscription fields"
>   link.
> - The link should take you directly to the "Additional fields for
>   'subscription'" page.

For a staff user without the 'manage_additionnal_fields' permission, the link
leads to a login window.
I don't know if this behaviour is the best one, or if the link should be hidden
when you're not supposed to access to this menu.
Except that point, it works fine (as always) :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28034] Add DataTables to lists of clubs in "Clubs" tabs on patron account

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28034

Lucas Gass  changed:

   What|Removed |Added

 Attachment #118834|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 118864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118864=edit
Bug 28034: Make club enrollment tables in to DataTables

To test:
-Add some clubs
-Go to a patron record and enroll them in some clubs but not in others.
-There should be two table under the clubs tab, Clubs currently enrolled in and
Clubs not enrolled in
-Neither are DataTables
-Apply patch
-With the same patron check the clubs tab, they should be datatables now
-Make sure all the controls, pagination works good

https://bugs.koha-community.org/show_bug.cgi?id=28033

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28034] Add DataTables to lists of clubs in "Clubs" tabs on patron account

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28034

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

--- Comment #13 from Kyle M Hall  ---
Created attachment 118863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118863=edit
Bug 28031: (follow-up) Cache type instead of passing

We should cache the 'type' instead of passing it around. That way we're
not changing the signature further for external users of the methods.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

--- Comment #12 from Kyle M Hall  ---
Created attachment 118862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118862=edit
Bug 28031: (follow-up) Clarify check methods

The check methods were positioned under the 'Internal methods' section
of the meodule but are used externally.

It also felt strange to have a noop or die method. Instead, I propose
renaming them to `repeatable_ok` and `unique_ok` and returning a
boolean denoting their state.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

--- Comment #11 from Kyle M Hall  ---
Created attachment 118861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118861=edit
Bug 28031: (follow-up) Retrieve type only once

The current implementation of store+check_repeatable+check_unique_id
notably retrieves the related Koha::Patron::Attribute::Type object three
times.

This can be easily solved by retrieving it once and reusing. This patch
does that.

This changes the signature for the helper methods.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron/Attribute.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass!
4. Verify the old _check_repeatable method is not used anywhere
   $ git grep _check_repeatable
=> SUCCESS: It is not!
5. Verify check_unique_id is not used anywhere, so no risk changing the
   signature
   $ git grep check_unique_id
=> SUCCESS: It is safe to update it!
6. Sign off :-D

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

--- Comment #10 from Kyle M Hall  ---
Created attachment 118860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118860=edit
Bug 28031: Avoid wrong exception on saving updated attribute

In the case a non-repeatable attribute for a patron is being updated
(its value) the routines that check the type is repeatable should
exclude its own id from the search for things to work.

This patch solves that.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron/Attribute.t
=> FAIL: Tests explode! An unexpected exception is thrown!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #118828|0   |1
is obsolete||
 Attachment #118829|0   |1
is obsolete||
 Attachment #118830|0   |1
is obsolete||
 Attachment #118831|0   |1
is obsolete||
 Attachment #118833|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 118859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118859=edit
Bug 28031: Regression tests

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

Owen Leonard  changed:

   What|Removed |Added

 Attachment #118837|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 118858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118858=edit
Bug 27740: Corrected tags & hierarchy of headings

Bug 27610 corrected the  tags in each of the OPAC files. This patch
corrects the hierarchy of the rest of the headings on each of the pages.

To test:
1) Go to the OPAC
2) Apply Bug 27610 patch
3) Apply patch (Bug 27740)
4) Go to each of the pages and check that the headings under  are in
   the correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10846] Add preference for naming OverDrive collection

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
*** Bug 28038 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28038] Allow for customization of overdrive-results string

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28038

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Lucas Gass  ---
(In reply to Owen Leonard from comment #1)
> I wonder if this would be solved by Bug 10846, Add preference for naming
> OverDrive collection

Yes, that this seems like a duplicate of Bug 10846, closing this one in favor
of that one.

*** This bug has been marked as a duplicate of bug 10846 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" on navigation menu

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

--- Comment #1 from Owen Leonard  ---
Created attachment 118857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118857=edit
Bug 28006: Restore "Additional fields" on navigation menu

This patch adds a link to the "Additional fields" page in Administration
to the sidebar menu shown on Serials pages.

To test, apply the patch and go to Serials.

- In the sidebar menu you should see a "Manage subscription fields"
  link.
- The link should take you directly to the "Additional fields for
  'subscription'" page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" on navigation menu

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" on navigation menu

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Martin Renvoize  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Martin Renvoize  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #117852|0   |1
is obsolete||

--- Comment #150 from PTFS Europe Sandboxes  ---
Created attachment 118856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118856=edit
Bug 17656: QA warnings fixes

Signed-off-by: Amarangi  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #8 from Michael Sutherland  ---
If this is meant to fix those issues with the WYSIWYG editing code then it
should be a higher priority. What I intended to say is that the WYSIWYG making
coding changes is not helpful, especially when it does not have a way to log
and recover lost code due to those changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28034] Add DataTables to lists of clubs in "Clubs" tabs on patron account

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28034

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
Could you add the "NoSort" class to the "Actions" table header?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26205] News Changes aren't Logged

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

--- Comment #7 from Michael Sutherland  ---
I apologize.  What I meant to say is that moving the ability to edit the HTML
out of system preferences and into the news without a way to track changes and
the WYSIWYG editor doing automatic code changes is an awful, horrible idea and
change.  If this bug is meant to address those issues, then this should be a
higher priority and fixed. Especially for those users that do not know HTML and
how to recover from lost code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28042] Button corrections in OAI set mappings template

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28042

--- Comment #1 from Owen Leonard  ---
Created attachment 118855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118855=edit
Bug 28042: Button corrections in OAI set mappings template

This patch makes minor markup changes in the OAI set mappings template
so that the "Add" button looks consistent with other buttons in the
table.

Also changed: Removed unnecessary inline style attributes.

To test, apply the patch and go to Administration -> OAI sets
configuration

- If necessary, create an OAI set.
- Click the "Actions" button and choose "Define mappings."
- In the table of form fields, confirm that the "Add" button is styled
  similarly to the "Delete" button.
- Confirm that the "Add" button works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28042] Button corrections in OAI set mappings template

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28042

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Michael Sutherland  changed:

   What|Removed |Added

 CC||sudrl...@vt.edu

--- Comment #7 from Michael Sutherland  ---
This is plainly awful. As a web developer, I do not want some WYSIWYG editor
telling me I do not know how to write HTML and start taking out HTML I put in
for a reason, such as a  or 

[Koha-bugs] [Bug 26205] News Changes aren't Logged

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

--- Comment #6 from Owen Leonard  ---
(In reply to Michael Sutherland from comment #5)
> This is a horrible idea and not an enhancement.

What's a horrible idea? That News changes should be logged (the purpose of this
bug) or that TinyMCE shouldn't be doing automatic code changes (which is what
Bug 26942 is about).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26205] News Changes aren't Logged

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

Michael Sutherland  changed:

   What|Removed |Added

 CC||sudrl...@vt.edu

--- Comment #5 from Michael Sutherland  ---
This is a horrible idea and not an enhancement.  If the idea to clean up code,
as the idea behind Bug 26942 suggests, is because users do not know what
they're doing writing HTML then they should be able to have a history that they
can revert back to when they lose content.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #25 from Martin Renvoize  ---
Nice one.. works great.  Signing off the last patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118818|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 118854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118854=edit
Bug 23666: Add PATCH
/patron/:patron_id/extended_attributes/:extended_attribute_id

This patch adds the described route. It is designed to use the
underlying libraries' methods to update an existing attribute.

The tests cover the use cases.

Note: I added handling for two exceptions that can only occur on bad
data (i.e. not by using our codebase). This are:
- Koha::Exceptions::Patron::Attribute::InvalidType
- Koha::Exceptions::Patron::Attribute::NonRepeatable

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons_extended_attributes.t
=> SUCCESS: Tests pass!
3. PLay with the route
=> SUCCESS: Expected behavior!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27980] Replace obsolete title-string sorting: Catalog templates

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27980] Replace obsolete title-string sorting: Catalog templates

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #10 from Martin Renvoize  ---
Nice one.. I spotted one last case which I've address in a QA follow-up.

Passing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27980] Replace obsolete title-string sorting: Catalog templates

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980

--- Comment #9 from Martin Renvoize  ---
Created attachment 118853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118853=edit
Bug 27980: (QA follow-up) Add missing case

We missed one last case ;)

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27980] Replace obsolete title-string sorting: Catalog templates

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118799|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 118852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118852=edit
Bug 27980: (follow-up) Address missing instance

- Search history -> Current and previous catalog searches

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27980] Replace obsolete title-string sorting: Catalog templates

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118581|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 118851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118851=edit
Bug 27980: Replace obsolete title-string sorting: Catalog templates

This patch modifies several catalog templates to replace the use of
the "title-string" DataTables sorting method with the newer
"data-order" attribute.

To test, apply the patch and view the following pages to confirm that
columns containing dates sort correctly when using any setting of the
"dateformat" system preference:

 - Catalog -> Search -> Bibliographic detail page
 - Catalog -> Search -> Bibliograhpic detail page -> Checkout history
 - Search history
   - Current and previous catalog search sessions
   - Current and previous authority search sessions

Signed-off-by: Amit Gupta 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28042] New: Button corrections in OAI set mappings template

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28042

Bug ID: 28042
   Summary: Button corrections in OAI set mappings template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org

The OAI set mappings page has inconsistencies in how the buttons are marked up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27983] Replace obsolete title-string sorting: Acquisitions templates part 2

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27983

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #9 from Martin Renvoize  ---
Applied 27982 and 27983 together.  Grepped for title-string in the acqui dir
and in js includes.

No further cases found.. well caught on the extra's Owen.

Passing QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27982] Replace obsolete title-string sorting: Acquisitions templates part 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #11 from Martin Renvoize  ---
Applied 27982 and 27983 together.  Grepped for title-string in the acqui dir
and in js includes.

No further cases found.. well caught on the extra's Owen.

Passing QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28041] Improve breadcrumbs and headings on label creator pages

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28041

--- Comment #1 from Owen Leonard  ---
Created attachment 118850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118850=edit
Bug 28041: Improve breadcrumbs and headings on label creator pages

This patch changes various label creator templates so that breadcrumbs
menus and headings are more specific to each operation.

To test, apply the patch and confirm that headings, page titles, and
breadcrumbs menus are correct for the various pages:

- New -> Label batch: "Label creator -> Batches -> New label batch."
- New -> Layout: "Label creator -> Layouts -> New label layout."
- New -> Label template: "Label creator -> New label template."
- New -> Printer profile: "Label creator -> New printer profile."
- New -> Barcode range: "Label creator -> Print barcode range."
- Manage -> Label batch -> Edit: "Label creator -> Batches -> Edit
  label batch X."
- Manage -> Layout -> Edit: "Label creator -> Layouts -> Edit label
  layout X."
- Manage -> Label templates -> Edit: "Label creator -> Templates -> Edit
  label template X."
- Manage -> Printer profiles -> Edit: "Label creator -> Profiles -> Edit
  printer profile X."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28041] Improve breadcrumbs and headings on label creator pages

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28041

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27983] Replace obsolete title-string sorting: Acquisitions templates part 2

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27983

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118782|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 118849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118849=edit
Bug 27983: (follow-up) Address missing instances

This patch cleans up some instances I missed on the first round:

- Acquisitions -> Vendor -> Receive shipments
- Acquisitions -> "All available funds" table
  -> Click an "Ordered" value
  -> Click a "Spent" value
- Acquisitions -> Vendor
 -> test sorting of contracts in the "Contracts" table

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27983] Replace obsolete title-string sorting: Acquisitions templates part 2

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27983

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118579|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 118848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118848=edit
Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2

This patch modifies several acquisitions templates to replace the use of
the "title-string" DataTables sorting method with the newer "data-order"
attribute.

To test, apply the patch and view the following pages to confirm that
columns containing dates sort correctly when using any setting of the
"dateformat" system preference:

- Acquisitions -> Late orders
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a
  subscription
- Acquisitions -> "All available funds" table
  -> Click an "Ordered" value
  -> Click a "Spent" value
- Acquisitions -> Vendor -> Receive shipments
- Acquisitions -> Vendor
  -> test sorting of contracts in the "Contracts" table

Signed-off-by: Amit Gupta 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27982] Replace obsolete title-string sorting: Acquisitions templates part 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118787|0   |1
is obsolete||

--- Comment #10 from Martin Renvoize  ---
Created attachment 118847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118847=edit
Bug 27982: (follow-up) Address another missing instance

Remove "title-string" option from staged file dataTable
initialization.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27982] Replace obsolete title-string sorting: Acquisitions templates part 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118783|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 118846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118846=edit
Bug 27982: (follow-up) Address missing instances

- Acquisitions -> Invoices
  - With AcqEnableFiles enabled, attach some files to an invoice:
- Invoice details

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27982] Replace obsolete title-string sorting: Acquisitions templates part 1

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #118580|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 118845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118845=edit
Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1

This patch modifies several acquisitions templates to replace the use of
the "title-string" DataTables sorting method with the newer "data-order"
attribute.

To test, apply the patch and view the following pages to confirm that
columns containing dates sort correctly when using any setting of the
"dateformat" system preference:

- Acquisitions -> Vendor search
- Acquisitions -> Vendor -> Basket -> Add to basket
   -> From a staged file
   -> From existing orders (copy)
- Acquisitions -> EDIFACT messages
- Acquisitions -> Order search
- With AcqEnableFiles enabled, attach some files to an invoice:
  - Acquisitions -> Invoices
Acquisitions -> Invoices -> Manage invoice files

Signed-off-by: Amit Gupta 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846

Owen Leonard  changed:

   What|Removed |Added

 Blocks||28041


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28041
[Bug 28041] Improve breadcrumbs and headings on label creator pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28041] New: Improve breadcrumbs and headings on label creator pages

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28041

Bug ID: 28041
   Summary: Improve breadcrumbs and headings on label creator
pages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 27846

The breadcrumbs menu and page headings can be improved on several label creator
pages to better describe the context of various operations.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846
[Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

--- Comment #21 from Katrin Fischer  ---

> Sorry I meant, the serial biblionumber is always the same, i.e.:
> Create subscription on biblionumber 1 and recieve a serial, it uses
> biblionumber1
> Edit subscription to use biblionumber 2 and receive a serial, it uses
> biblionumber 1
> Edit subscription to use biblionumber 3 and receive a serial, it uses
> biblionumber on
> Edit subscription to use biblionumber 4...and so on
> 
> We are not keeping a history of the biblionumber, but rather keeping only
> the original biblionumber
> 
> I don't see that storing 'NULL' or one older biblionumber gains us much over
> storing the current bibloionumber

Thx for clearing this up! In that case I see no issue in changing the data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28031] Koha::Patron::Attribute->_check_repeatable doesn't exclude the object's ID

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28031

Martin Renvoize  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28039] SPAM

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28039

Katrin Fischer  changed:

   What|Removed |Added

Summary|email and password issue|SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28038] Allow for customization of overdrive-results string

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28038

--- Comment #1 from Owen Leonard  ---
I wonder if this would be solved by Bug 10846, Add preference for naming
OverDrive collection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28036] Improve breadcrumbs of serial claims page

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #3 from Owen Leonard  ---
Depends on Bug 27846.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #8 from Andrew Isherwood  ---
Revised test plan:

- Ensure you have at least two "partners" set up. These are patrons in the
category defined in  ->  in koha-conf.xml,
the patrons must also have a primary email address defined.
- Ensure the ILLLOG syspref is turned on
- Create an ILL request using the FreeForm backend
- From the "Manage ILL request" screen, select "Place request with partners"
- In "Select partner libraries" choose one partner library, then click "Send
email"
- Go to the "Manage ILL request" screen
=> TEST: Observe that the request "Status" is "Requested from partners :
first_partner_email_address_here"
=> TEST: Observe that the first_partner_email_address links to the appropriate
patron screen
- From the "Manage ILL request" screen, select "ILL request log"
=> TEST: Observe that the status was changed *to* "Requested from partners
(first_partner_email_address_here)
- From the "Manage ILL request" screen, select "Place request with partners"
- In "Select partner libraries" choose a different partner library, then click
"Send email"
- From the "Manage ILL request" screen, select "ILL request log"
=> TEST: Observe that the status was changed *from* "Requested from partners
(first_partner_email_address_here)
=> TEST: Observe that the status was changed *TO* "Requested from partners
(second_partner_email_address_here)
=> TEST: Observe that the email addresses displayed link to the appropriate
patron page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #86744|0   |1
is obsolete||

--- Comment #7 from Andrew Isherwood  ---
Created attachment 118844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118844=edit
Bug 22531: Add unit tests

Add tests for new and modified methods

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #86723|0   |1
is obsolete||

--- Comment #6 from Andrew Isherwood  ---
Created attachment 118843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118843=edit
Bug 22531: Add logging & display of req partners

This patch adds:

- The ability to send request to partners multiple times.
- Logging of requested partners
- Display of requested partners in "ILL Request Log" display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28039] email and password issue

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28039

Owen Leonard  changed:

   What|Removed |Added

URL|http://ikman.lk |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28039] email and password issue

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28039

Owen Leonard  changed:

   What|Removed |Added

 Status|CLOSED  |RESOLVED
 Resolution|FIXED   |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28040] http://landfill.bugzilla.org/ not loading

2021-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28040

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|ASSIGNED|RESOLVED

--- Comment #1 from Owen Leonard  ---
This is not a bug tracker for Bugzilla. It is a bug tracker that uses Bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >