[Koha-bugs] [Bug 28063] New: Minor change to OpacAuthorities description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28063 Bug ID: 28063 Summary: Minor change to OpacAuthorities description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: r.delahu...@arts.ac.uk QA Contact: testo...@bugs.koha-community.org Selecting Do not allow for the system preference OpacAuthorities does hide the Authority Search tab on the Simple Search page but authority searches remain possible on the Advanced Search page by selecting More options to expose Subject and Author searches. The description of the system preference should explain that the change to the preference affects the Simple Search page only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28062] New: Allow batch removal of waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28062 Bug ID: 28062 Summary: Allow batch removal of waiting holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In the "Holds Awaiting Pickup" button in "Circulation", it would be nice if there could be a batch delete function - if a user has to cancel a lot of holds they can only be done one at a time and the screen has to rebuild between each deletion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26205] News Changes aren't Logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #13 from David Cook --- (In reply to Lucas Gass from comment #3) > I think this needs to be higher priority. Combined with Bug 26942 librarians > are losing large sections of HTML because the WYSIWYG is doing automatic > code clean up. Without logs there is no way to recover the old data. Agreed about it being a higher priority. I had to restore some HTML news from a backup because Bug 26942 had wiped out the CSS that they'd used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28061] Cash Register Stats table (cash_register_stats.pl) should include a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28061 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28061] Cash Register Stats table (cash_register_stats.pl) should include a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28061 --- Comment #1 from Lucas Gass --- Created attachment 119028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119028=edit Bug 28061: Add timestamp to date column in cash_register_stats.tt To test: -Have some configuared cash registers. -Do some transactions -Go to the reports module > Statistic wizards > Cash register -Generate the table and look at the 'Transaction date' column, no timestamp -Apply patch and look again -You should see the timestamp -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28061] Cash Register Stats table (cash_register_stats.pl) should include a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28061 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Victor Grousset/tuxayo --- Still work, QA tools happy, code ok :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #118980|0 |1 is obsolete|| --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 119027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119027=edit Bug 26459: (follow-up) Clarify language and remove duplicated code Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #113066|0 |1
is obsolete||
--- Comment #7 from Victor Grousset/tuxayo ---
Created attachment 119026
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119026=edit
Bug 26459: Add hold-mode option to sip_cli_emulator
To test:
1 - Apply patch
2 - Restart all
3 - Place an item level hold for a patron via the staff client
4 - Cancel the hold using the sip_cli_emulator with hold-mode: -
perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --patron
{cardnumber} --item {BARCODE} -m hold -l CPL --hold-mode -
5 - Run the sip_cli_emulator with no params
6 - Verify help text is understandable
Signed-off-by: David Nind
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28061] New: Cash Register Stats table (cash_register_stats.pl) should include a timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28061 Bug ID: 28061 Summary: Cash Register Stats table (cash_register_stats.pl) should include a timestamp Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It would be handy if on the cash register stats page the table column 'Transaction date' would include not just a date but also a timestamp. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 --- Comment #6 from Victor Grousset/tuxayo --- Thanks for the fixes :) > 2. > I can rebuild if there is strong preference, I just wanted a quikc way to do > this It's ok, I was just surprised by the params but they also make sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25183] cleanup-database.pl --del-exp-selfreg fully deletes borrowers - should go into deleted-borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25183 --- Comment #12 from Victor Grousset/tuxayo --- > Worked as expected in testing for me Is the following the right syntax? ./cleanup_database.pl --del-exp-selfreg --del-exp-selfreg-type soft -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27546] Add option to search within results on the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 --- Comment #17 from Victor Grousset/tuxayo --- ok, current behavior looks good for me. Code ok, QA script ok, it works. Will retest and pass QA when the dep (bug 22605) will be passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27546] Add option to search within results on the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #118958|0 |1 is obsolete|| --- Comment #16 from Victor Grousset/tuxayo --- Created attachment 119025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119025=edit Bug 27546: Add 'Search within results' search box This enhancement adds a new input above the search results allowing one to search within the results. The search box will take a query and add it as a limit to the previous search These patches make a slight change to the search header, passing the dropdown selection as a parameter rather thandirectly. Searching this way is functionally equivaled to adding 'AND' with the new term to original results. To test: 1 - Apply patch 2 - Search on staff client wiht a term that returns results 3 - Note the new 'Search within results box' 4 - Add a search term 5 - Note new results and confirm they are as expected 6 - Enable IntranetCatalogSearchPulldown and confirm the dropdown works as expected 7 - Edit your search - the reinfements appear in the limits section and can be removed Signed-off-by: Barbara Johnson Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28060] New: Point of sale debits should not automatically sort when edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28060 Bug ID: 28060 Summary: Point of sale debits should not automatically sort when edited Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: esth...@sodaspringsid.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When editing debits in the point of sale, the debit costs automatically sort from lowest to highest cost amount. This can cause an error because the debit changes places on the screen. When training staff, I observed numerous errors because of the auto shifting of debits. To repeat: 1. Add multiple debits to point of sale. 2. Click on the debit cost and change the cost. The debit will automatically move up and down the list depending on the price. If you are also editing the quantity, you now have to pay attention to the debit location to make sure you are editing the correct line item. It would be better if the auto sorting was turned off by default. In addition it would be nice if there was a setting to choose whether the list is sorted by debit name or cost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28059] Move OPAC news block to new protected area
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28059 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26205] News Changes aren't Logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #12 from Esther Melander --- I created a separate bug (Bug 28059) for the separation of news and OPAC customizations since this is a different topic from logging. Though OPAC customizations are also not logged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26205] News Changes aren't Logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #11 from Michael Sutherland --- (In reply to Lisette Scheer from comment #10) > However we might want > to let individual libraries set their own news for their patrons and not > give them access to the OPAC customizations. > > Lisette I heartily, emphatically agree. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27722] Eliminate 'All' as an option from display location in OPAC and Koha news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27722 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #2 from Lisette Scheer --- (In reply to Katrin Fischer from comment #1) > Could we rename it "OPAC and staff interface" instead? I believe part of the issue is that it will add that code to each of the OPAC content areas that are now edited via the news section, which might not be expected. Perhaps instead of an "all" it could be "OPAC, Staff Interface, and Slips" since that is what "all" used to mean until the OPAC customizations got moved in there? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26205] News Changes aren't Logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #10 from Lisette Scheer --- (In reply to Michael Sutherland from comment #9) > (In reply to Esther Melander from comment #8) > > > I would recommend that OPAC customizations be moved to an entirely new place > > that is protected with permissions. The ability to accidentally delete > > something forever from a live web page can be extremely problematic. > > Esther, I believe there is a system setting that protects news with > permissions. Someone please correct me if I'm mistaken. If you go to 'Use > all tools', under that branch is the permission 'Write news for the OPAC and > staff interfaces (edit_news)'. I have not tested this to see if users may > not actually access this if they do not have this permission marked. This does work for stopping ALL news editing/creation. However we might want to let individual libraries set their own news for their patrons and not give them access to the OPAC customizations. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26205] News Changes aren't Logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #9 from Michael Sutherland --- (In reply to Esther Melander from comment #8) > I would recommend that OPAC customizations be moved to an entirely new place > that is protected with permissions. The ability to accidentally delete > something forever from a live web page can be extremely problematic. Esther, I believe there is a system setting that protects news with permissions. Someone please correct me if I'm mistaken. If you go to 'Use all tools', under that branch is the permission 'Write news for the OPAC and staff interfaces (edit_news)'. I have not tested this to see if users may not actually access this if they do not have this permission marked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28059] New: Move OPAC news block to new protected area
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28059 Bug ID: 28059 Summary: Move OPAC news block to new protected area Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: esth...@sodaspringsid.com QA Contact: testo...@bugs.koha-community.org The OPAC news block items should be separated out to a new permission protected area. It is too easy to forever delete OPAC customizations by library staff who otherwise should be able to use the news tool. Our consortium recently experienced this when someone accidentally deleted all the OPAC news blocks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 --- Comment #2 from Owen Leonard --- Created attachment 119024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119024=edit Bug 28058: Move javascript out of columns_settings.inc into separate file This patch moves the JavaScript contained in a
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26205] News Changes aren't Logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Esther Melander changed: What|Removed |Added CC||esth...@sodaspringsid.com --- Comment #8 from Esther Melander --- Our consortium is using Koha in a multi-branch setup. We recently had someone in the consortium go through and clear out nearly all of the news items including the OPAC customizations without knowing the impact it would have. This resulted in the OPAC headers being deleted. We were able to restore things without too much trouble but I foresee it happening again. I would recommend that OPAC customizations be moved to an entirely new place that is protected with permissions. The ability to accidentally delete something forever from a live web page can be extremely problematic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 --- Comment #1 from Owen Leonard --- I'm also moving the contents of table_filters.js into the new JS file (tablesettings.js). table_filters.js contained only two functions and was only used on pages which already include columns_settings.inc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28055] Convert DataTables option names to current version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Owen Leonard changed: What|Removed |Added Blocks||28058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 [Bug 28058] Move javascript out of columns_settings.inc into separate file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] New: Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Bug ID: 28058 Summary: Move javascript out of columns_settings.inc into separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 28055 Having a separate file for JavaScript makes the file cache-able and lint-able. This patch will move the
[Koha-bugs] [Bug 20596] Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #2 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #1) > Hi Marjorie, > have you checked that control-number exists for authority indexing? It does > exist for bibliographic, but the index sets don't match up. > > https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ > zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > > This suggests 035 is not indexed at all for authorities :( Hi Katrin, Thank you for your reply and sorry for my delay. I am amazed that zone 035 does not appear in the list of indexed zones. Also I am surprised that zone 016 does not appear in the authority-koha-indexdefs.xml file either, whereas for this field the search with the index control-number works. Is there another file that lists potentially indexed zones for authorities where zone 016 would be found? Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20596] Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #2 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #1) > Hi Marjorie, > have you checked that control-number exists for authority indexing? It does > exist for bibliographic, but the index sets don't match up. > > https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ > zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > > This suggests 035 is not indexed at all for authorities :( Hi Katrin, Thank you for your reply and sorry for my delay. I am amazed that zone 035 does not appear in the list of indexed zones. Also I am surprised that zone 016 does not appear in the authority-koha-indexdefs.xml file either, whereas for this field the search with the index control-number works. Is there another file that lists potentially indexed zones for authorities where zone 016 would be found? Regards, Marjorie --- Comment #3 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #1) > Hi Marjorie, > have you checked that control-number exists for authority indexing? It does > exist for bibliographic, but the index sets don't match up. > > https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ > zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > > This suggests 035 is not indexed at all for authorities :( Hi Katrin, Thank you for your reply and sorry for my delay. I am amazed that zone 035 does not appear in the list of indexed zones. Also I am surprised that zone 016 does not appear in the authority-koha-indexdefs.xml file either, whereas for this field the search with the index control-number works. Is there another file that lists potentially indexed zones for authorities where zone 016 would be found? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Owen Leonard changed: What|Removed |Added Summary|Highlight patrons from |Highlight patrons from |logged-in library on|logged-in library in patron |checkout search |searches Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10902] Highlight patrons from logged-in library on checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #1 from Owen Leonard --- Created attachment 119023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119023=edit Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10902] Highlight patrons from logged-in library on checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #3 from Agustín Moyano --- Created attachment 119022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119022=edit Bug 27944: Add "requested" stage in article request process This patch adds the stage "requested" in article request process, which is previous to pending stage. To test: 1. apply this patch 2. updatedatabase 3. enable ArticleRequests syspref 4. from staff inteface and from opac search for a record and place an article request 5. koha-mysql kohadev 6. query: select subject, content, letter_code from message_queue; CHECK => There is a message for each article request with code AR_REQUESTED => In opac-user.pl, in "Article requests" tab you should see a row in the table with "Requested" status 5. in staff go to Circulation -> Article Requests SUCCESS => You should see 3 tabs, one for Requested stage (with two requests), one for Pending stage and one for Processing stage. 6. play with actions buttons CHECK => you should see a new action called "Set request as pending" SUCCESS => All action buttons behave as expected, and tab counts updates correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #2 from Agustín Moyano --- Created attachment 119021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119021=edit Bug 27944: Add AR_REQUESTED message in sample_notices.yml and modify AR_PENDING -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #1 from Agustín Moyano --- Created attachment 119020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119020=edit Bug 27944: Add new letter in atomicupdate, and modify status column in article_requests table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Blou changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |alexis.ripe...@inlibro.com |u | --- Comment #43 from Blou --- I suppose we could extend the patch to catch all cases where profile_id is set to '' instead of 0 The errors comes from save(), which seems called by label-edit-template.pl and patroncards/edit-template.pl which are very loose with their assignments of profile_id. But beside that, you'll have to be specific. We coded (and use) this patch in its simplest form, to avoid the problems. But we're not rearchitecturing the underlying issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||joonas.kylm...@helsinki.fi, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] New: Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057
Bug ID: 28057
Summary: Confusion of biblionumber and biblioitemnumber in
request.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
We have seen issues on sites where biblionumber and biblioitemnumbers are not
the same - we hit an ISE for missing itemypes for items on record B when
placing a hold on record A
biblionumber and biblioitemnumber are not guaranteed to be the same
I don't understand what is happening around this code, but I am certain this is
not right:
447 $items_any_available = ItemsAnyAvailableAndNotRestricted( {
biblionumber => $biblioitemnumber, patron => $patron })
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28048] Can't import patrons without checkprevcheckout and autorenew_checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28048 --- Comment #3 from Owen Leonard --- (In reply to Nitesh Kumar Verma from comment #2) > I have upgraded from koha version from 16.05 to 16.11. I'm sorry but 16.11 is a very old Koha version and isn't supported anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 --- Comment #11 from Martin Renvoize --- Still on the case here Nick? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #42 from Martin Renvoize --- Still able to work on this Blou? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25183] cleanup-database.pl --del-exp-selfreg fully deletes borrowers - should go into deleted-borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25183 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Failed QA |Signed Off --- Comment #11 from Martin Renvoize --- Worked as expected in testing for me.. hope the QA person can work out where Victor may have gone wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25183] cleanup-database.pl --del-exp-selfreg fully deletes borrowers - should go into deleted-borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25183 Martin Renvoize changed: What|Removed |Added Attachment #103784|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 119019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119019=edit Bug 25183: cleanup-database.pl --del-exp-selfreg fully deletes borrowers - should go into deleted-borrowers The cleanup database job for deleting expired self registrations fully deletes borrowers instead of transferring them to deleted borrowers. This is a problem when libraries think they are deleting email unverified patrons instead of ones that haven't moved out of the category, an easy thing to be confused about. Test Plan: 1) Apply this patch 2) Try running cleanup_database.pl with the new -del-exp-selfreg-type parameters 'soft' and 'hard' 3) Param value 'soft' should move patrons to deletedborrowers 4) Param value 'hard' should follow existing behavior 5) Leave our -del-exp-selfreg-type, you should get the existing behavior Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 --- Comment #4 from Owen Leonard --- Created attachment 119018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119018=edit Bug 27883: (follow-up) Make label match input id This change alters the list of columns under "Preserve existing values," changing the label for each checkbox can be clicked to trigger the checkbox change. To test, apply the patch and refresh the patron import page. Expand the "Preserve existing values" section and click any label in the list. The corresponding checkbox should be checked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 --- Comment #5 from Nick Clemens --- Created attachment 119017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119017=edit Bug 26326: (follow-up) Add ability to check for existence of any primary key Before dropping a primary key we need to see if one exists - this updates the installer method to allow searching for existence of key -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 --- Comment #3 from Owen Leonard --- The QA tool shows this failure: FAIL misc/import_patrons.pl FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). FAIL valid Global symbol "@preserve_fields" requires explicit package name (did you forget to declare "my @preserve_fields"?) Global symbol "@preserve_fields" requires explicit package name (did you forget to declare "my @preserve_fields"?) misc/import_patrons.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #102 from Julian Maurice --- Patches rebased and squashed. Back to needs signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What|Removed |Added Attachment #68375|0 |1 is obsolete|| Attachment #68376|0 |1 is obsolete|| Attachment #68377|0 |1 is obsolete|| Attachment #68378|0 |1 is obsolete|| Attachment #68379|0 |1 is obsolete|| Attachment #68380|0 |1 is obsolete|| --- Comment #101 from Julian Maurice --- Created attachment 119016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119016=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #38 from Martin Renvoize --- Is still relevant? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Sorry, I can't get this to work! The interface says that my CSV has been imported successfully and that my patron was overwritten, but the expected changes are not made to the existing record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Failed QA |RESOLVED CC||martin.renvoize@ptfs-europe ||.com --- Comment #14 from Martin Renvoize --- Pretty sure with is fixed now.. bug 10876 perhaps.. Either way, I can't replicate the bug so I think we're safe to close :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #4 from Owen Leonard ---
I get an error when running updatedatabase:
DEV atomic update: bug_26326.perl
Atomic update generated errors: {UNKNOWN}: DBI Exception: DBD::mysql::db do
failed: Can't DROP 'PRIMARY'; check that column/key exists [for Statement
"ALTER TABLE import_record_matches DROP PRIMARY KEY"] at
/usr/share/perl5/DBIx/Class/Schema.pm line 1118.
DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x55bbeee34d60),
"DBI Exception: DBD::mysql::db do failed: Can't DROP 'PRIMARY'"...) called at
/usr/share/perl5/DBIx/Class/Storage.pm line 113
DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x55bbee117670),
"DBI Exception: DBD::mysql::db do failed: Can't DROP 'PRIMARY'"...) called at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501
DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed: Can't
DROP 'PRIMARY'; check that co"..., DBI::db=HASH(0x55bbef809d70), undef) called
at (eval 1457) line 7
eval '$DBversion = \'XXX\';
if( CheckVersion( $DBversion ) ) {
unless(
primary_key_exists(\'import_record_matches\',\'import_record_id\') &&
primary_key_exists(\'import_record_matches\',\'candidate_match_id\')
){
$dbh->do( "ALTER TABLE import_record_matches DROP PRIMARY KEY" );
$dbh->do( "ALTER TABLE import_record_matches ADD PRIMARY KEY
(import_record_id,candidate_match_id)" );
}
NewVersion( $DBversion, 26326, "Add primary key to import_record_matches");
}
' called at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23755
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27546] Add option to search within results on the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #15 from Nick Clemens --- (In reply to Victor Grousset/tuxayo from comment #14) > Wait, the first thing happens because of the second. i.e. chaining means > that emptying the field will chain the empty string. > > Is that needed to easily "unrefine" the search? Like to fix a typo or > something too specific. There is always the back button of the browser. Leaving the 'Search within' blank and pressing search should not change anything - it will not clear previous refinements, that is done via 'Edit this search' Future enhancement could be to list the limits and allow for unchecking on the results page, but I do not think that is necessary for this stage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize --- Works well, passes QA script.. I added some unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #18 from Martin Renvoize --- Created attachment 119015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119015=edit Bug 25946: (QA follow-up) Add Unit tests Add a unit test for the empty relationship availability. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28048] Can't import patrons without checkprevcheckout and autorenew_checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28048 --- Comment #2 from Nitesh Kumar Verma --- Owen Sir, I am using ../cgi-bin/koha/tools/import_borrowers.pl to import patron in .CSV format. I have upgraded from koha version from 16.05 to 16.11. After upgrading I am facing this error. I am using the same method as I have used earlier. Running KOHA since 2015 and have more than 8000 patron records. CSV Headers I am using: cardnumber,surname,patron_attributes,phone,address,branchcode,categorycode,email,password,userid. I am stuck in between as it is not possible to manually enter the details of 3000-4000 patron details on KOHA. Any help in this regard is highly appreciated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #18 from Nick Clemens --- Created attachment 119014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119014=edit Bug 26312: (follow-up) Fix whitespace and missing semicolon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28048] Can't import patrons without checkprevcheckout and autorenew_checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28048 Owen Leonard changed: What|Removed |Added Summary|Getting Internal Server |Can't import patrons |Error while importing |without checkprevcheckout |Patrons |and autorenew_checkouts Version|unspecified |master Priority|P1 - high |P5 - low Severity|critical|major OS|Linux |All Hardware|HP |All --- Comment #1 from Owen Leonard --- I don't know if this is the same issue, but I'll take over this bug since there are no other details: Although they're not mentioned on the page as required field, it doesn't seem to be possible to import a CSV of patrons without putting a value in the checkprevcheckout and autorenew_checkouts columns. An error appears in the log if you omit them: [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'autorenew_checkouts' cannot be null [for Statement "UPDATE `borrowers` SET `autorenew_checkouts` = ?, `checkprevcheckout` = ?, `dateexpiry` = ?, `dateofbirth` = ?, `debarred` = ?, `flags` = ?, `gonenoaddress` = ?, `lang` = ?, `lost` = ?, `password` = ?, `relationship` = ?, `updated_on` = current_timestamp, `userid` = ? WHERE ( `borrowernumber` = ? )" with ParamValues: 0=undef, 1=undef, 2='2024-03-30T00:00:00', 3=undef, 4=undef, 5=undef, 6=undef, 7=undef, 8=undef, 9='!', 10=undef, 11='test.test', 12='65581'] at /kohadevbox/koha/Koha/Object.pm line 169 [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'checkprevcheckout' cannot be null [for Statement "UPDATE `borrowers` SET `checkprevcheckout` = ?, `dateexpiry` = ?, `dateofbirth` = ?, `debarred` = ?, `flags` = ?, `gonenoaddress` = ?, `lang` = ?, `lost` = ?, `password` = ?, `relationship` = ?, `updated_on` = current_timestamp, `userid` = ? WHERE ( `borrowernumber` = ? )" with ParamValues: 0=undef, 1='2024-03-30T00:00:00', 2=undef, 3=undef, 4=undef, 5=undef, 6=undef, 7=undef, 8='!', 9=undef, 10='test.test', 11='65581'] at /kohadevbox/koha/Koha/Object.pm line 169 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #17 from Martin Renvoize --- Created attachment 119013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119013=edit Bug 25946: borrowerRelationship can be empty Do not show the empty dropdown with no options if borrowerRelationship is disabled (empty) in the syspref. To reproduce: 1) Go to system preferences and disable borrowerRelationship. 2) Create a new patron or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select different patron to act as guarantor. 4) Observe that there's empty dropdown for the relation type. 5) Apply the patch. 6) Repeat steps above. 7) Observe that dropdown is no longer there. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #16 from Martin Renvoize --- Created attachment 119012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119012=edit Bug 25946: borrowerRelationship can be empty When borrowerRelationship is empty in system preferences, Relationship dropdown is not required and we accept empty value. Also fixes bug that didn't let you to pick empty value even when you specified that it should be possible in system preferences but in the end of the string (i.e. "|father|mother" worked, but "father|mother|" don't). To reproduce (borrowerRelationship can be empty): 1) Go to system preferences and make borrowerRelationship empty. 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Try to save your changes. 4) Observe that relationship field is required in order to save but you can't actually choose anything as it doesn't contain anything. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it allows you to save the form now. To reproduce (can't choose empty value bug): 1) Go to system preferences and set borrowerRelationship exactly to "father|mother|". 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. 4) Observe that there's no option to leave relationship field empty. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it has empty option that you can choose and save the form. Mentored-by: Andrew Nugged Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Martin Renvoize changed: What|Removed |Added Attachment #118997|0 |1 is obsolete|| Attachment #118998|0 |1 is obsolete|| Attachment #118999|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 119011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119011=edit Bug 25946: borrowerRelationship can be empty Do not split the config using comma. From syspref description of borrowerRelationship preference: > Guarantors can be the following of those they guarantee: > (input multiple choices separated by |). Leave empty to deactivate. As it doesn't mention comma at all, I removed ',' from split. Of course if comma is actually a viable way to split separate choices, I can obsolete this patch and append to the syspref description that it also can be separated by comma. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28052] keys omitted in check for system preference override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 Nick Clemens changed: What|Removed |Added Attachment #119000|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 119010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119010=edit Bug 28052 Do not check SYSENV values only keys in loop Loop is only interested in key values, because 'keys' is omitted it is checking values as well. This can lead to misleading errors being logged (e.g. key is undefined) Extract keys only to loop array as in the other loops below this Testing: 1 - tail /var/lib/koha/kohadev/sip-output.log 2 - in another tab use the sip cli tester: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m checkin --item CHESS1 3 - Note errors: Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, line 1. Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, line 2. 4 - Apply patch and restart all the things 5 - Repeat 2 6 - Errors mentioned are gone Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28052] keys omitted in check for system preference override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 119009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119009=edit Bug 27857: (use-it-in-real-life follow-up) Use a more fine-grained exception for mandatory attributes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 119008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119008=edit Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute This trivial patch adds a new exception for more fine-grained control on the errors when dealing with patrons and their extended attributes. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 119007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119007=edit Bug 28056: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27857 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 [Bug 27857] Koha::Patron->extended_attributes skips checks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28056] New: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 Bug ID: 28056 Summary: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttr ibute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org We need such exception to use it in Koha::Patron->extended_attributes. Right now we use the generic FKContraint one, that makes it hard to tell the caller what the problem is (as this is also a valid exception when adding a patron with an invalid (say) categorycode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard changed: What|Removed |Added Attachment #119006|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #46 from Owen Leonard --- Created attachment 119006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119006=edit Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Owen Leonard Signed-off-by: Michael Adamyk Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard changed: What|Removed |Added Attachment #118956|0 |1 is obsolete|| --- Comment #45 from Owen Leonard --- Created attachment 119005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119005=edit Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Michael Adamyk Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28055] Convert DataTables option names to current version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 --- Comment #1 from Owen Leonard --- Created attachment 119004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119004=edit Bug 28055: Convert DataTables option names to current version This patch makes changes the two global DataTables files in the staff interface, replacing older 1.9.x option names with the current 1.10.x version. To test, apply the patch and confirm that default DataTables behaviors continue to work correctly: Table information, "Show XX entries" controls, pagination, search. - Test tables which use the default DataTables configuration from datatables.js: - Administration -> Z39.50/SRU servers - Administration -> MARC frameworks -> MARC structure - Test tables which use the DataTables configuration in columns_settings.inc, including column visibility and export controls. - Administration -> Libraries - Patrons -> Patron search results - Circulation -> Holds queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28055] Convert DataTables option names to current version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Martin Renvoize changed: What|Removed |Added Attachment #45526|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #45525|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 --- Comment #5 from Martin Renvoize --- Created attachment 119003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119003=edit Bug 15338: Fix indentation and comments in SIPServer Supplemental patch which takes advantage of the relocation of the program to apply a consistent indentation to the code also removes comments arising from the confusion resulting from the program's name and location Add a comment indicating that this code will work under other flavours of Net::Server as well as PreFork -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 --- Comment #4 from Martin Renvoize --- Created attachment 119002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119002=edit Bug 15338: Move SIPServer to bin directory SIPServer should reside like other programs in the bin directory rather than lurking in modules removed the pm suffix which confused some users sip_run.sh can now be simplified and not fail because of misuse of path definition as a directory removed the unnecessary sourcing of .bash_profile in shutdown (what if you dont have a bash_profile?) SIP modules are now in standard lib path so Server does not need to set its own lib -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Agustín Moyano changed: What|Removed |Added Summary|Add a 'new' requests tab to |Add new stages to the |Article requests|article request process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #20 from Martin Renvoize --- *** Bug 15729 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Martin Renvoize changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 25541 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27916] Fee paid message can crash SIP server if paying fee that is not "renewable"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916 --- Comment #6 from Martin Renvoize --- Any chance of a unit test here Kyle? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Martin Renvoize changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Martin Renvoize changed: What|Removed |Added Attachment #99533|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 119001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119001=edit Bug 12169 Use pid file in sipserver shutdown Change sample SIPConfig to request server writes a pid file Use this pid in shutdown rather than the current open to error method. Have also added to the Config parameters to ensure that the sipserver runs as the correct user and sets its own session id. These are always useful but makes it easier for users to run up the sipserver as root at boot time similarly to apache, mysql etc Added to the sample config where to locate other server parameter documentation. Removed from the sample config the unedifying, unwanted and purely historical http example Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #11 from Martin Renvoize --- (In reply to Larry Baerveldt from comment #2) > This patch hardcodes the user and group as "koha" and "koha". You should not > hardcode the user and group in the SIPConfig.xml file; those need to be > gathered at the Koha creation phase, either through koha-create and > koha-enable-sip for package, or with Makefile.PL for git sites. As far as I can tell, the file modified here is A) only an example file and B) only used for dev/standard installs and isn't referenced in the Makefile at all. So, I don't think it affects packages at all, it just makes sip work more reliably for Dev/Standard installs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28052] keys omitted in check for system preference override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28052] keys omitted in check for system preference override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28052] keys omitted in check for system preference override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28052] keys omitted in check for system preference override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
