[Koha-bugs] [Bug 27465] Add column visibility to the admin/cities.pl

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #3 from Lucas Gass  ---
I have the same problem as Pascale, the TableSettings do not hide the columns.
Also to be consistent the 'Actions' column should include:

cannot_be_toggled: 1
cannot_be_modified: 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27739] Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739

David Nind  changed:

   What|Removed |Added

 Attachment #119092|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 119146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119146=edit
Bug 27739: Advanced editor should use DefaultCountryField008 preference

Uses the system preference DefaultCountryField008, falling back to ||| (no
attempt to code) if it is not set, for 008/15-17 place of publication in
the advanced cataloging editor..

Test plan:
1) Apply patch and restart all the things, something's over-cached here
2) Administration - Toggle the preference  EnableAdvancedCatalogingEditor
   to "Enable", verify the preference DefaultCountryField008 is empty
3) Cataloging - Advanced editor
4) In field 008, verify that the three characters after the two sets of
   four blank spaces are |||
5) Administration - Set DefaultCountryField008 to fr
6) Cataloging - Advanced editor
7) In field 008, verify that the three characters after the two sets of
   four blank spaces are "fr " (including the space, so following
   characters haven't shifted left, and the last character is still d)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27739] Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28083] Add system preference that allows users to insert HTML in the on all staff pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28083

--- Comment #1 from Lucas Gass  ---
Created attachment 119145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119145=edit
Bug 28083: Add IntranetHTMLHead system preference

To tes:
-Apply patch
-Look for the syspref IntranetHTMLHead
-If you insert HTML it should be present inside the  on all pages in the
staff interface
-An easy way to test is to add something like this: body{ background:
red !important } 
-All staff interface pages should then have a red background

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28083] Add system preference that allows users to insert HTML in the on all staff pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28083

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27746] Use of uninitialized value $oclc in pattern match (m//) error at C4/Koha.pm

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746

David Nind  changed:

   What|Removed |Added

 Attachment #117139|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 119144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119144=edit
Bug 27746: prevent regexp undefined warning when checking subfield contents
($oclc)

Some of the books have subfield "a" of field "035" absent
and it's possible to have such
(it doesn't says "Require" in the interface),
which causes "Use of uninitialized value $oclc in pattern match (m//)"
error.

Solved by screening regex with check for empty variables before the
match.

To reproduce:
1) Edit existing book or create a new one with empty marc
subfield "a" of field "035"
2) Use the search feature that will find it along with some other
books.
3) Check /var/log/koha/kohadev/plack-intranet-error.log to find
"Use of uninitialized value $oclc in pattern match (m//)" error.
4) Apply the patch.
5) Repeat the search and check the logs again to ensure
that error didn't appear again.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27746] Use of uninitialized value $oclc in pattern match (m//) error at C4/Koha.pm

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28083] Add system preference that allows users to insert HTML in the on all staff pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28083

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28083] New: Add system preference that allows users to insert HTML in the on all staff pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28083

Bug ID: 28083
   Summary: Add system preference that allows users to insert HTML
in the  on all staff pages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Like Bug 28080 but for the staff client.

It would be nice if there was a system preference to allow librarians to insert
HTML into the document  on the staff cleint. Currently there is no way to
add custom scripts or meta content, links to Google fonts, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28081] Make card number a label in patron search results

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28081

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #1 from Lucas Gass  ---
+1, good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078

David Nind  changed:

   What|Removed |Added

 Attachment #119124|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 119143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119143=edit
Bug 28078 - Add 'ignore_hold_counts' param to CanItemBeReserved

This patch adds an optional param 'ignore_hold_counts' to the routine, while
still forbidding holds when 0 are allowed

To test:
1 - prove -v t/db_dependent/Holds.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #16 from Lucas Gass  ---
(In reply to Michael Sutherland from comment #7)
> This is plainly awful. As a web developer, I do not want some WYSIWYG editor
> telling me I do not know how to write HTML and start taking out HTML I put
> in for a reason, such as a  or 

[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080

--- Comment #1 from Lucas Gass  ---
Created attachment 119142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119142=edit
Bug 28080: Add OPACHTMLHead system preference

To test:
-Apply patch
-Look for the syspref OPACHTMLHead
-If you insert HTML it should be present inside the  on all pages in the
OPAC
-An easy way to test is to add something like this: body{ background:
red !important } 
-All OPAC pages should then have a red background

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28082] New: Add acquisitions toolbar to vendors on vendor search page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082

Bug ID: 28082
   Summary: Add acquisitions toolbar to vendors on vendor search
page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

We can improve consistency and expand functionality be adding inclusion of the
acquisitions toolbar include on the vendor search results page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28081] New: Make card number a label in patron search results

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28081

Bug ID: 28081
   Summary: Make card number a label in patron search results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I would like to modify patron search results in the patrons module so that each
patron card number is wrapped in a label tag which controls the state of the
corresponding checkbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28080] New: Add system preference that allows users to insert HTML in the on all OPAC pages

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080

Bug ID: 28080
   Summary: Add system preference that allows users to insert HTML
in the  on all OPAC pages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be nice if there was a system preference to allow librarinans to
insert HTML into the document . Currently there is no way to add custom
scripts or meta content, links to Google fonts, etc. 

Many already insert this in the OPACHeader but since that has moved to the News
Tool it is less than ideal to do it this way. ( see bug 26942 )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852

David Nind  changed:

   What|Removed |Added

 Attachment #117623|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 119141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119141=edit
Bug 27852: Link YES_NO authorized value category to 942dev in Default framework

This patch add the YES_NO authorised value category to
942dev in the Default framework and sets the default value
to 0 (No).

To test:
1) Load the yaml file
1) Load the yaml file
(I used the load_yaml.pl script after deleting the values from my database)
2) Go to cataloging and open an empty cataloging form
using the Default framework
2) Go to 942dev: the value should read No and there should
be a drop down choice between Yes and No

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852

--- Comment #5 from David Nind  ---
Thanks Caroline for the updated test plan, everything is working now - sign off
on the way!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28079] Set focus to search box field when adding an order to basket

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Failed QA

--- Comment #7 from Séverine Queune  ---
I also noticed an issue with the age alert, which appears only if there is
another alert.
I wasn't able to test holds message, feature was broken on sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16628] Patrons requesting modifications link behaves differently on the home page than the members-home.pl page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16628

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Christopher Brannon  ---
This does not look to be an issue any longer.  There is no conflicting
information on the members-update.pl page any longer.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28066] Remove select tag's size attribute where it is 1

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066

--- Comment #5 from Katrin Fischer  ---
Created attachment 119140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119140=edit
Bug 28066: (QA follow-up) Fix some single quote occurences

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28066] Remove select tag's size attribute where it is 1

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #119049|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 119139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119139=edit
Bug 28066: Remove select tag's size attribute where it is 1

This patch removes the "size" attribute from  tags where the
value of the attribute is 1. The attribute is unnecessary because the
default value when the attribute is undefined is 1.

This will allow for more careful sizing of  tags without a size
attribute while preserving the desired behavior of  tags which
have a size greater than 1.

The patch modifies 83 files but makes the same minor corrections to
each. I think examining the diff is sufficent, or testing a
representative set of pages:

 - Administration -> MARC frameworks -> MARC structure -> Edit tag:
   The "Authorized value" select.
 - Patrons -> New patron: The "Library" select.
 - Reports -> Patrons with no checkouts: The "Into an
   application" selects.

If anyone would like help testing any particular template I can
follow-up.

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28066] Remove select tag's size attribute where it is 1

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28044] Calendar: Tables with closed days are no longer color coded

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #119058|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 119138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119138=edit
Bug 28044: Increase specificity of calendar tables CSS

This patch adds increased specificity to the CSS which should add colors
to the tables of holidays. The default DataTable CSS was overriding the
custom color-coding.

This patch also moves the calendar CSS into a separate file.

To test, apply the patch and go to Tools -> Calendar.

If necessary, add at least one of the following:
- Unique holiday
- Holiday repeating weekly
- Holiday repeating monthly
- Holiday exception

In the table listing each kind of holiday, the color of the table header
should match the colors in the "Key" section under Hints. The color
should be correct regardless of how the table is sorted.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28044] Calendar: Tables with closed days are no longer color coded

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #119104|0   |1
is obsolete||

--- Comment #8 from PTFS Europe Sandboxes  ---
Created attachment 119137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119137=edit
Bug 24564: Use the same tab as the other subfields within a field

For each subfield added, we check if other subfields exists in the same
field. If that's the case we use the same tab as the first subfield
found.

Test plan:
1. Find a biblio subfield in
   misc/migration_tools/ifla/data/biblio/default.yml that doesn't exist
   in your default biblio MARC framework (or delete one). The field
   should exist and have other subfields with a tab set.
2. Change the tab of all subfields within that field it's different from
   what's in the .yml file
3. Run misc/migration_tools/ifla/update.pl
4. Verify that the subfield has been added and have the same tab as
   others subfields
5. Do the same for authorities (files are in
   misc/migration_tools/ifla/data/auth/)

Signed-off-by: Koha team 

Signed-off-by: sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #119103|0   |1
is obsolete||

--- Comment #7 from PTFS Europe Sandboxes  ---
Created attachment 119136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119136=edit
Bug 24564: Do not modify the tab of existing subfield in ifla/update.pl

Test plan:
1. Find a biblio subfield in
   misc/migration_tools/ifla/data/biblio/default.yml that you have in
   your default biblio MARC framework (or create one).
2. Change the tab of this subfield so that it's different from what's in
   the .yml file
3. Run misc/migration_tools/ifla/update.pl --force
4. Verify that the tab of this subfield has not been changed.
5. Do the same for authorities (files are in
   misc/migration_tools/ifla/data/auth/)

Signed-off-by: sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #7 from Katrin Fischer  ---
Owen, can you please check?

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
   FAIL   filters
asset_must_be_raw at line 8 ([% Asset.css("css/calendar.css")
%])

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900

--- Comment #8 from Katrin Fischer  ---
Created attachment 119135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119135=edit
Bug 27900: (QA follow-up) Rephrase link text

See discussion on IRC from today :)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900

--- Comment #7 from Katrin Fischer  ---
Created attachment 119134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119134=edit
Bug 27900: (QA follow-up) Add missing filter

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #119107|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 119133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119133=edit
Bug 27900: Add a link back to the basket view if no result

Since bug 24347 the neworderbiblio view has been removed and we now
display the usual search result.
When adding a new order from a search, if there is no result we should
let the user get back to the basket view.

Test plan:
Add to basket from an existing record
Do a search with no results and confirm that there is a new "Go to the
basket view" link

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852

--- Comment #4 from Caroline Cyr La Rose  ---
Hi David!

Thanks for testing this!

I think I forgot to add that you have to also delete the frameworks... sorry
about that

Here's the updated test plan, hopefully this time it works!

1) Apply patch

2) In the database

delete from marc_subfield_structure where frameworkcode = "";

delete from marc_subfield_structure where frameworkcode = "ACQ";

delete from marc_tag_structure where frameworkcode = "";

delete from marc_tag_structure where frameworkcode = "ACQ";

delete from biblio_framework where frameworkcode in ("", "ACQ");

2) Load the yaml file

./misc/load_yaml.pl -f
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
--load

3) In Koha, go to cataloging and open an empty cataloging form
using the Default framework

4) Go to 942$n: the value should read No and there should
be a drop down choice between Yes and No

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #6 from Caroline Cyr La Rose  ---
So I added a restriction to my user, with the patch in the Details tab, there
is no restriction, but in the Checkout tab, there is a restriction.

To test :
1) WITHOUT the patch, add a manual restriction to a user.
2) In the details page, click on the Restrictions tab, the tab should say 1
Restriction and the restriction should appear 
3) In the checkout page, click on the Restrictions tab, the tab should say 1
Restriction and the restriction should appear 
4) Apply the patch and rebuild yarn + Ctrl+F5
5) In the details page, click on the Restrictions tab, the tab should only says
"Restrictions" (no number) and the restriction is not in the tab
6) In the checkout page, click on the Restrictions tab, the tab should only
says "Restrictions" (no number) but the restriction is in the tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28079] New: Set focus to search box field when adding an order to basket

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079

Bug ID: 28079
   Summary: Set focus to search box field when adding an order to
basket
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

When adding an order to a basket, you have to click in the input box before
searching for an existing record.
It could be usefull if the cursor was focused on the search box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

--- Comment #6 from Katrin Fischer  ---
Sorry, this is BLOCKED right now, we still need a sign-off on bug 27873!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

--- Comment #4 from Katrin Fischer  ---
Thx Severine!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #119121|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 119132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119132=edit
Bug 28077: Add a colon after the 'Reason' label on edit suggestion page

This patch corrects the missing colon on the 'Edit purchase suggestion'
page.
To test :
- go to Acquistions > Suggestions
- edit a suggestion
- on 'Suggestion management' bloc, see the colon missing after the
'Reason' label
- apply patch
- refresh the page
- colon should now be displayed

Happy sign off !

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5242] Import patrons directly from Excel

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242

--- Comment #7 from Katrin Fischer  ---
(In reply to Pascale Nalon from comment #6)
> I think this bug is not really one ... this one could be closed

As you had filed it, you are also ok to close it :) Just move it to RESOLVED
and pick one of the reasons shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27776] Point of Sale 'This sale' table should not be sorted by default

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27776

Katrin Fischer  changed:

   What|Removed |Added

 CC||esth...@sodaspringsid.com

--- Comment #12 from Katrin Fischer  ---
*** Bug 28060 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28060] Point of sale debits should not automatically sort when edited

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28060

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---
Hi Esther, I belive this has been fixed quite recently with bug 27776.

*** This bug has been marked as a duplicate of bug 27776 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28068] Cash register should not record writeoff as cash received

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28068

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243

Séverine Queune  changed:

   What|Removed |Added

 Attachment #105493|0   |1
is obsolete||

--- Comment #15 from Séverine Queune  ---
Created attachment 119131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119131=edit
Bug 23243: (follow-up) Update wording as requested

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243

Séverine Queune  changed:

   What|Removed |Added

 Attachment #105492|0   |1
is obsolete||

--- Comment #14 from Séverine Queune  ---
Created attachment 119130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119130=edit
Bug 23243: Adjust previous patch

Signed-off-by: Martin Renvoize 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243

Séverine Queune  changed:

   What|Removed |Added

 Attachment #105491|0   |1
is obsolete||

--- Comment #13 from Séverine Queune  ---
Created attachment 119129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119129=edit
Bug 23243: Restore filtering out historic expired subscriptions

The 'Check Expiration' page in Serials is now hardcoded to display all
expired subscriptions before the entered date. This patch restores the
ability to limit the results to just those expiring between 'today'
and the date entered.

Original code taken from bug 6968 autored by Maxime Pelletier, rebased
by Charles Farmer and then moved to a new report and rebased again by
Martin Renvoize.

Test plan:
1) Without the patch any results after a search from this page will
   result in matches both before after todays date (but before the date
   you entered).
2) With the patch you should see a 'Show historic expirations' checkbox
   which will allow you to limit the results to just those that expire
   between the date you enter and today.

Sponsored-by: CCSR
Rescued-by: Charles Farmer 
Rescued-by: Martin Renvoize 
Signed-off-by: Martin Renvoize 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127

Katrin Fischer  changed:

   What|Removed |Added

Summary|Can't blacklist MARC21 500  |Can't hide MARC21 500 and
   |with NotesToHide|others with NotesToHide

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9495] Split NotesToHide in to two prefs for staff and OPAC

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495

Katrin Fischer  changed:

   What|Removed |Added

Summary|Split NotesBlacklist in to  |Split NotesToHide in to two
   |two prefs for staff and |prefs for staff and OPAC
   |OPAC|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17906] Add possibility to hide MARC subfield with NotesToHide

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17906

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add possibility to  |Add possibility to hide
   |blacklist MARC subfield |MARC subfield with
   |with notesblacklist |NotesToHide

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17127] Can't blacklist MARC21 500 with NotesToHide

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127

Katrin Fischer  changed:

   What|Removed |Added

 CC||pierre.ge...@biblibre.com

--- Comment #5 from Katrin Fischer  ---
*** Bug 28067 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28067] Syspref NotestoHide - some notes still appear

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28067

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 17127 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17127] Can't blacklist MARC21 500 with NotesToHide

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127

Katrin Fischer  changed:

   What|Removed |Added

Summary|Can't blacklist MARC21 500  |Can't blacklist MARC21 500
   |with NotesBlacklist |with NotesToHide

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25708] [OMNIBUS] Use allow/disallow terminology in code

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25708
Bug 25708 depends on bug 25709, which changed state.

Bug 25709 Summary: Rename systempreference from NotesBlacklist to NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

   What|Removed |Added

 Status|Pushed to oldoldstable  |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesToHide

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldoldstable  |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013

--- Comment #11 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #7)
> I don't manage to convince myself it's correct.
> There is an edge case, looking at the code:
> 
> The patron iterator is set before the ITEM loop. On the second item, it
> won't be reset and we won't iterate over all the patrons.
> 
> Nick and/or Joonas, can you double check it please?

Indeed, simply resetting after the loop should cover that.

Adding test to prove that, however, uncovered additional problems. I filed bug
28078 and updated code here.

I set to SO for another QA round to check what I added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28063] Minor change to OpacAuthorities description

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28063

--- Comment #1 from Katrin Fischer  ---
The options on the advanced search for subject and author search in the
bibliographic data by text and not in any authority data. They are completely
independent of using authorities. Unless we are talking about different things?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27940] Fix missing email in OpacMaintenance page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940

--- Comment #6 from Katrin Fischer  ---
I'd like to open a new bug here - could we agree to display the address from 
ReplytoDefault when set instead of KohaAdminEmailAdress?
In some setups the KohaAdminEmailAdress nees to be set to noreply (same known
issue as always with some mail servers being very strict about possible spam)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Séverine Queune  ---
Problem was on my devbox, works perfectly on sandbox !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #119118|0   |1
is obsolete||

--- Comment #4 from PTFS Europe Sandboxes  ---
Created attachment 119128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119128=edit
Bug 28073: Patron modifications should auto-open panel for referring patron
record

This patch makes it possible to link directly to the correct panel on
the "Update patron records" page. The link on the checkout and patron
details screen has been updated to read "Patron has pending
modifications."

Also changed: Moved the "Patron's address in doubt" message so that it
is above the table of changed fields.

To test, apply the patch and if necessary submit patron modification
requests from multiple patrons via the OPAC.

 - Open the checkout page for one of these patrons.
   - If you are logged in as a user with permission to edit patron
 records you should see a message, "Pending modifications: Review
 pending modifications," which links to the pending modifications
 page.
 - Clicking the link should open the page for reviewing pending
   patron modifications, and the correct panel should be
   automatically expanded.
   - If you are logged in as a user without permission to edit patrons
 you should see the message "Pending modifications: Patron has
 pending modifications," which isn't linked.
 - The process should work exactly the same from the patron detail page.
 - Following the "Pending modifications" link from the staff interface
   home page or the patrons home page should work as before: The page
   opens with the first panel expanded.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27917] Make it clear that standing orders cannot create items at point of ordering

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27917

--- Comment #5 from Katrin Fischer  ---
Hope I understood it all correctly:

- The standing order checkbox needs to remain editable in the basket. At the
moment I know of no other way to "close" out a standing order than to make it
no longer a standing order first. 

- It makes sense to only offer cataloguing and on receive as options when
standing order is checked.

Should we include a database update maybe to set all the standing orders with
"on order" to "cataloguing"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #11 from Katrin Fischer  ---
Another thing: I believe you currently need to fill in password in order to
have the notice generated at all - we should remove that check as well if I am
correct.

Thinking about this line:

https://git.koha-community.org/Koha-community/Koha/src/commit/02d82b142d998f1544fbab6e7f35f6f0fceef084/members/memberentry.pl#L468

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812

--- Comment #10 from Katrin Fischer  ---
> Would you like me to add a follow-up to modify the templates in the database?

I think this is meant well but won't really work for translated notices - so we
can't really fix this automatically. 

But I agree with Kyle about the need to remove this 'non-feature', so we just
need to figure out how to do it best.

- Change the default notice templates - check!
- Are we sure we will remove all translated installers? Then they can be
ignored.
- Deal with existing installations using the feature
  - Add well visible note to the release notes
  - Make sure the notices are still processed, just password will not be output
  - Add a note to the pref?
  - Remove password from field list to add to a notice template?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013

--- Comment #10 from Nick Clemens  ---
Created attachment 119127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119127=edit
Bug 28013: (follow-up) Reset the patron loop

To test:
1 - Apply all other patches and dependencies
2 - prove -v t/db_dependent/Circulation.t
3 - It fails
4 - Apply this patch
5 - It passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013

--- Comment #9 from Nick Clemens  ---
Created attachment 119126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119126=edit
Bug 28013: Unit tests

Cover the case of multiple patrons and multiple items that can fill them

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013

--- Comment #8 from Nick Clemens  ---
Created attachment 119125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119125=edit
Bug 28013: (follow-up) Correct and update call to CanItemBeReserved

The current call checks for truth against a returned hash, we need
to check the 'status' value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078

--- Comment #1 from Nick Clemens  ---
Created attachment 119124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119124=edit
Bug 28078 - Add 'ignore_hold_counts' param to CanItemBeReserved

This patch adds an optional param 'ignore_hold_counts' to the routine, while
still forbidding holds when 0 are allowed

To test:
1 - prove -v t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013

Nick Clemens  changed:

   What|Removed |Added

 Depends on||28078


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078
[Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Blocks||28013


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013
[Bug 28013] Improvements to CanBookBeRenewed
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28078] New: Add option to ignore hold counts when checking CanItemBeReserved

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078

Bug ID: 28078
   Summary: Add option to ignore hold counts when checking
CanItemBeReserved
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In 'CanBookBeRenewed' we call 'CanItemBeReserved' to see if an item is
available to fill a hold - this doesn't work because:
1 - We call it wrong (bug 28013)
2 - We count the current hold against the limit

This bug adds an optional param 'ignore_hold_counts' to the routine, while
still forbidding holds when 0 are allowed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

--- Comment #5 from Thomas Klausner  ---
Created attachment 119123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119123=edit
only show subfield "9" if subfield "a" is visibile (bug 28022)

Amend the workaround (from but 2206) to only show subfield "9" in editor if
subfield "a" has the editor-visibility bit set

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16628] Patrons requesting modifications link behaves differently on the home page than the members-home.pl page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16628

Owen Leonard  changed:

   What|Removed |Added

Version|3.22|master
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16628] Patrons requesting modifications link behaves differently on the home page than the members-home.pl page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16628

--- Comment #1 from Owen Leonard  ---
Is this bug still valid? Here's how I tested:

- Turn on IndependentBranches 
- Set IndependentBranchesPatronModifications to "Yes"
- Log in as a non-superlibrarian
- On the staff interface home page I see "Patrons requesting modifications: 2"
- On the patron module home page I see "Patrons requesting modifications: 2"

Both links take me to a page which shows the 2 patrons requesting modification
out of a 4 total for all libraries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #3 from Owen Leonard  ---
(In reply to Séverine Queune from comment #2)
> On the checkout page, the message (without link) is the same for users with
> and without the patron modification permission.

I can't reproduce this problem. Can you double-check that the "edit_borrowers"
permission is the one you're setting, and that you're logging that user out and
back in after changing permissions?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27726] OPACProblemReports cuts off message text

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726

--- Comment #15 from Owen Leonard  ---
Same error:

DEV atomic update: bug_27726.perl
Atomic update generated errors: {UNKNOWN}: DBI Exception: DBD::mysql::db do
failed: BLOB/TEXT column 'content' can't have a default value [for Statement
"ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT ''"]  at
/usr/share/perl5/DBIx/Class/Schema.pm line 1118.
DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x562f6298c240),
"DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'co"...) called at
/usr/share/perl5/DBIx/Class/Storage.pm line 113
   
DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x562f62b267c8),
"DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'co"...) called at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501
DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed:
BLOB/TEXT column 'content' can't ha"..., DBI::db=HASH(0x562f631329c0), undef)
called at (eval 1457) line 3
eval '$DBversion = \'XXX\'; # will be replaced by the RM
if( CheckVersion( $DBversion ) ) {
$dbh->do("ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT
\'\'");

NewVersion( $DBversion, 27726, "Increase field size for
problem_reports.content");
}
' called at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23755

Server version: 10.1.48-MariaDB-1~bionic mariadb.org binary distribution

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20596] Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl)

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596

--- Comment #4 from Katrin Fischer  ---
Hi Marjorie, this should be the only file listing all indexes for the
authorities. You might have local changes of course. And maybe it falls back to
a keyword search if the index is unknown or so? I have no proof of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #155 from Katrin Fischer  ---
Thx for all the testing going on here!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Séverine Queune  ---
>  - Open the checkout page for one of these patrons.
>- If you are logged in as a user with permission to edit patron
>  records you should see a message, "Pending modifications: Review
>  pending modifications," which links to the pending modifications
>  page.

On the checkout page, the message (without link) is the same for users with and
without the patron modification permission.
Except that point, the patch works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #154 from Koha Team University Lyon 3  ---
Hello,
I testes this time on Ptfx Sandbox. no more message "Renewal cancelled". Sorry,
I think this was template problem on my instance.

It's OK now for startdate error message.

Everything works as expected as for daily and monthly frequencies.
Exceptions are kept. date are skipped when receiving as well.

But unfortunately weekly frequency does not work. Irregularities are not
retained :
my parameters :
first issue publ. date  01/01/2021
startdate 01/01/2021
issues 52
enddate 31/12/2021

I checked 8 and 15 feb 2021
They are recorded ok
I multireceived 50 issues and click on Renew button but no weeks are no more
checked on the form.

Olivier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28074] Browse controls in staff details are sometimes weird

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28074] Browse controls in staff details are sometimes weird

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074

Owen Leonard  changed:

   What|Removed |Added

 Attachment #119090|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 119122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119122=edit
Bug 28074: Make current_search.offset an integer instead of string

To test:
1. Do a search with 3-4 results, go to the record and use the browse
   controls, when you get to the last record if you attempt to go to the
   'next' you'll end up on a page which says 'record not found.'
2. Do a search with exactly 10 results. Click on the first record, the
   'next' arrow is not a link, you cannot move to the next result.
3. Apply patch
4. Repeat steps 1-2 and the problems should be gone.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
This would be useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

Owen Leonard  changed:

   What|Removed |Added

 Attachment #119119|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 119121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119121=edit
Bug 28077: Add a colon after the 'Reason' label on edit suggestion page

This patch corrects the missing colon on the 'Edit purchase suggestion'
page.
To test :
- go to Acquistions > Suggestions
- edit a suggestion
- on 'Suggestion management' bloc, see the colon missing after the
'Reason' label
- apply patch
- refresh the page
- colon should now be displayed

Happy sign off !

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing)

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390

--- Comment #23 from Alex Arnaud  ---
Created attachment 119120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119120=edit
Bug 20390: mappings according to last IFLA updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

--- Comment #1 from Séverine Queune  ---
Created attachment 119119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119119=edit
Bug 28077: Add a colon after the 'Reason' label on edit suggestion page

This patch corrects the missing colon on the 'Edit purchase suggestion'
page.
To test :
- go to Acquistions > Suggestions
- edit a suggestion
- on 'Suggestion management' bloc, see the colon missing after the
'Reason' label
- apply patch
- refresh the page
- colon should now be displayed

Happy sign off !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

Séverine Queune  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28077] Missing colon on suggestion modification page

2021-04-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077

Séverine Queune  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |severine.que...@bulac.fr
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >