[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #15 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 119547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119547=edit
Bug 27631: Hidden  on intranet-main.tt

This patch visually hides a  on intranet-main.tt so that the heading
is available to be read out by screenreaders in the summary of headings on the
page.

Test plan:

1) Ensure the  "Koha home" heading on the staff client main/home page is
hidden visually, but in the source code you can see it

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #14 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 119546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119546=edit
Bug 27631: acqui folder

Changed each of the pages in the acqui folder to have one  tag
showing that describes the page, rather than the  describing the
logo.

The hierarchy of heading tags may be broken in many pages, but this will
be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the acqui folder and check that they have
an obvious and descriptive heading
4) Ensure that the heading in the page is 

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #13 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 119545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119545=edit
Bug 27631: cataloguing folder

Changed each of the pages in the cataloguing folder to have one  tag
showing that describes the page, rather than the  describing the
logo.

The hierarchy of heading tags may be broken in many pages, but this will
be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the cataloguing folder and check that they have
an obvious and descriptive heading
4) Ensure that the heading in the page is 

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] Historical OVERDUE fines may not have an issue_id

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

Nick Clemens  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #12 from David Cook  ---
I don't see any obvious advantage to including Cucumber tests but happy to be
convinced otherwise. 

Is the idea that the test reports are prettier and the scenarios more verbose?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #12 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 119544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119544=edit
Bug 27631: reports and serials folders

Changed each of the pages in the reports and serials folders to
have one  tag showing that describes the page, rather than the 
describing the logo.

The hierarchy of heading tags may be broken in many pages, but this will
be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the reports and serials folders and
check that they have an obvious and descriptive heading
4) Ensure that the heading in the page is 

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26861] Indicate that a record is using OpacHiddenItems in staff client

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

--- Comment #4 from Rebecca Coert  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

--- Comment #1 from Rebecca Coert  ---
+1 This would be very useful for all types of notices.  Setting a "send time"
for each notice type would make this fully customizable for a multitude of
reasons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28128] Uploading Process of New Cataloging Records Stalls When 952 $9 Is Filled In

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28128

Elaine Bradtke  changed:

   What|Removed |Added

 CC||e...@efdss.org

--- Comment #1 from Elaine Bradtke  ---
We have had uploads fail due to one faulty record (which passed muster in
MARCedit as a valid MARC record). It took me hours of splitting to find the bad
record.

 I would like to add my support to this statement "It would be nice if instead
of stalling, the uploader would write the MARC record to some sort of upload
log with a reason; and then try uploading the next record."

Even spitting out the bad record to a log file without a reason, and moving on
with the import would be a vast improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20533] Call Number Search plugin functionality

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20533

Rhiana  changed:

   What|Removed |Added

 CC||rmcomp...@arlingtonva.us

--- Comment #3 from Rhiana  ---
I was just thinking about this kind of functionality! It would be hugely
beneficial to our cataloging team to be able to scroll or select NEXT pages in
call number search to review additional results.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

--- Comment #11 from Barbara Johnson  ---
Great suggestion.  We really need this functionality at our library.  As it is
now, staff has to use a clunky workaround which is not efficient.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026

--- Comment #7 from Mark Hofstetter  ---
I doubt that call() is sufficient, and as call_recursive() just adds
functionality and does not interfere with the rest of teh plugin system. I'll
try to QA it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026

--- Comment #6 from Kyle M Hall  ---
(In reply to Julian Maurice from comment #5)
> I suggested something that would not require adding a new method nor
> modifying the 'call' method
> (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351#c7)
> What do you think of it ?

There's a decent amount of code utilizing call_recursive now, so I'm a bit
hesitant to make changes to code that has passed qa. If you want to submit your
idea is a dependency on 26352 I'd absolutely take a look!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195

--- Comment #5 from Séverine Queune  ---
I never noticed that problem, very nice catch !
Thanks Nick for the good fix !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195

Séverine Queune  changed:

   What|Removed |Added

 Attachment #119467|0   |1
is obsolete||

--- Comment #4 from Séverine Queune  ---
Created attachment 119543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119543=edit
Bug 23195: Always count shipping costs as 'spent'

As shipping costs are created when an invoice is created, and creation
of an invoice implies that items have been received, the shipment costs
are always assumed to be 'spent'

This logic is true in GetBudgetSpent/GetBudgetOrdered, however,
GetBudgetHierarchy
treats open invoices shipping costs as 'ordered' and closed invoice shipping
costs
as 'spent'

This leads to inconsistencies in acqui-home vs spent.pl and ordered.pl

To test:
 1 - Find a vendor
 2 - Click 'Receive shipments'
 3 - Create a new invoice with a shipping cost on budget A
 4 - Repeate and create a new invoice with a shipping cost on budget B
 5 - Close the second invoice
 6 - View acquisitions ome
 7 - Note budget A includes the shipping under ordered
 8 - Note budget B includes the shipping under spent
 9 - Click the 'ordered' column on budget A - no shipping is listed on ordered
page
10 - Click the spent column on budget A - the shipping is listed here
11 - Apply patch
12 - Both budgets list the shipping as 'spent'
13 - Both 'spent' pages include the shipping
14 - Neither 'ordered' page includes shipping

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195

Séverine Queune  changed:

   What|Removed |Added

 Attachment #119466|0   |1
is obsolete||

--- Comment #3 from Séverine Queune  ---
Created attachment 119542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119542=edit
Bug 23195: Unit tests

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23195] Shipping costs are inconsistent in where displayed

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28145] New: Patron Attribute Class field allows for free text OR if PA_CLASS defined no blank value available

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28145

Bug ID: 28145
   Summary: Patron Attribute Class field allows for free text OR
if PA_CLASS defined no blank value available
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: erica.roh...@equinoxoli.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In versions 20.05 and 20.11

If a PA_CLASS authorized value has not been defined, when the user creates a
new patron attribute type, the "Class" field is now a free text box. In
previous versions, this field would be a blank dropdown. If the user writes in
a "Class" when creating an attribute, Koha is recognizing the grouping on the
patron account. However, writing in a Class on the patron attribute type screen
does not automatically create an authorized value for the PA_CLASS.

If an authorized value for PA_CLASS has been defined, then that is the only
option for a user to select when creating a patron attribute type. In previous
versions, the user would still have the ability to select the "blank" option
from the Class dropdown (if that attribute is not being categorized into a
class). Now, if a PA_CLASS value exists, the user must put the attribute into a
Class. 

To Recreate:

1. Make sure no PA_CLASS values are previously defined
2. Administration › Patron attribute types > New Patron Attribute Type
3. Scroll down to the last field, "Class"
4. Observe that the Class box allows for free text
5. Save your patron attribute
6. Administration › Authorized values > select PA_CLASS
7. Observe that the free text class you created is not an authorized value
8. Now create an authorized value for PA_CLASS
9. Go back to Administration › Patron attribute types > New Patron Attribute
Type
10. Scroll down to the last field, "Class" and observe that the PA_CLASS value
you just created is your only option in the dropdown (no blank option) - which
groups your patron attribute type into a class

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Eric Swenson  changed:

   What|Removed |Added

 CC||t...@salinapublic.org

--- Comment #10 from Eric Swenson  ---
I also would like to add my support to this request. All the complications with
holds pickup in the time of COVID have made this something that would be very
helpful!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26656] Expiration date on waiting holds appears as editable but changes aren't saved

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26656

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

--- Comment #9 from Rebecca Coert  ---
+1 this would be very helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25631] Adding ability to alter the expiration date of the hold from the patron's account in staff

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25631

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] Historical OVERDUE fines may not have an issue_id

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] Historical OVERDUE fines may not have an issue_id

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

--- Comment #1 from Nick Clemens  ---
Created attachment 119541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119541=edit
Bug 28144: Check if issue_id defined

Historical OVERDUE fines may not have an issue_id - this causes
flooding of the logs when calling update fine

Trivial change, reading the code should be enough, but test plan below

To test:
1 - Create some fines without an issue_id
  - Either checkout an old version of Koha and add manually or
  - Checkout some items (backdated) to a patron, run fines.pl then
UPDATE accountlines SET issue_id = NULL;
2 - Checkout a backdated item with fines in the circ rule to the same patron
3 - Run fines.pl
4 - Note the errors
5 - Apply patch
6 - Repeat and note no errors

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] Historical OVERDUE fines may not have an issue_id

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] New: Historical OVERDUE fines may not have an issue

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

Bug ID: 28144
   Summary: Historical OVERDUE fines may not have an issue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] Historical OVERDUE fines may not have an issue_id

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

Nick Clemens  changed:

   What|Removed |Added

Summary|Historical OVERDUE fines|Historical OVERDUE fines
   |may not have an issue   |may not have an issue_id

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27921] Timestamp in holds log is out of date when a hold is marked as waiting

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27921

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.05.00|21.05.00,20.11.05
released in||

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28017] Allow non-FQDN and IP addresses in emails

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28017

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|21.05.00|21.05.00,20.11.05
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #20 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26999] "Any library" not translatable on the hold list

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26999

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.05.00|21.05.00,20.11.05
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28043] Some patron clubs operations don't work from later pages of results

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.05.00|21.05.00,20.11.05
released in||
 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27999] Display the description of authorized values category

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27999

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.05.00|21.05.00,20.11.05
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27566] CSS rule not applying to HTML select / option - displays with serif font ignoring rules

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #18 from Fridolin Somers  ---
Oh I wait for backport then.

We may revert from master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28003] Invoice adjustments using inactive budgets do not indicate that status

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28003

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.05.00|21.05.00,20.11.05
released in||

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.05.00|21.05.00,20.11.05
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #10 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27928] FindDuplicate is hardcoded to use Zebra

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.05.00|21.05.00,20.11.05
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

Fridolin Somers  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

Fridolin Somers  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Fridolin Somers  ---
Depends on Bug 26481 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.05.00|21.05.00,20.11.05
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #13 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125

--- Comment #7 from Andrew Fuerste-Henry  ---
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #119539|0   |1
is obsolete||

--- Comment #6 from Andrew Fuerste-Henry  ---
Created attachment 119540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119540=edit
Bug 28125: Display a warning on the about page for OPACHiddenItems is needed

If OPACHiddenItems is containing badly construct it will lead to
inconsistent behaviours. For instance the holds view will not display
any items, when the detail page will display all of them (because we are
not using the same code, we are in transition to merge it).

This patch suggests to add a warning to the about page in case the query
generated by Koha::Items->filter_by_visible_in_opac produces a warning

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240

Henry Bolshaw  changed:

   What|Removed |Added

   Keywords||accessibility

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142

Henry Bolshaw  changed:

   What|Removed |Added

   Keywords||accessibility

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125

--- Comment #5 from Jonathan Druart  
---
(In reply to Andrew Fuerste-Henry from comment #3)
> I've got a really picky display complaint, though. On Chrome, the warning
> message ends up a little longer than the table itself and doesn't look good.
> Can you make the table resize to fit the message?

There was a td instead of a th, should be fixed now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #119513|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 119539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119539=edit
Bug 28125: Display a warning on the about page for OPACHiddenItems is needed

If OPACHiddenItems is containing badly construct it will lead to
inconsistent behaviours. For instance the holds view will not display
any items, when the detail page will display all of them (because we are
not using the same code, we are in transition to merge it).

This patch suggests to add a warning to the about page in case the query
generated by Koha::Items->filter_by_visible_in_opac produces a warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21260] Improve the Availability line of OPAC XSLT search results

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260

--- Comment #41 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #40)
> (In reply to Jonathan Druart from comment #39)
> > I overlooked this one, I didn't notice the use of the "local pref".
> > 
> > Why didn't we create a "real" system preference here?
> 
> Comment12
> Do you need a follow-up here?

Yes please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28114] OPAC Results availability line does not show homebranch/holding branch correctly

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28114

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #4 from Nick Clemens  ---
Trivial obvious fix, passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28114] OPAC Results availability line does not show homebranch/holding branch correctly

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28114

Nick Clemens  changed:

   What|Removed |Added

 Attachment #119340|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 119538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119538=edit
Bug 28114: Fix error in MARC21slim2OPACResults

To test:
-Look at search results and see something like: Availability: Items available
for loan: 1 , 1 , 2 .
-Apply patch
-See something like: Availability: Items available for loan: Midway (1),
Centerville (1), Fairview (2)

Signed-off-by: David Nind 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28114] OPAC Results availability line does not show homebranch/holding branch correctly

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28114

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #18 from Jonathan Druart  
---
Test plan:
1. Create a patron category that is not limited to any libraries
2. Create a patron category limited to a couple a libraries
3. Edit it and confirm that the select is selected with the libraries you
picked
4. Modify the choice and save again, confirm it has been saved correctly
5. Confirm that the patron's category is visible only from those libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #17 from Jonathan Druart  
---
Created attachment 119537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119537=edit
Bug 23271: Remove 'selecteds' from Branches

Restoring the first version of this from the first patch and reverting
what hit master first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

--- Comment #29 from Alexis Ripetti  ---
Created attachment 119536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119536=edit
Bug 11361 - (QA follow-up) Add filters and change forbidden patterns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #113334|0   |1
is obsolete||

--- Comment #28 from Alexis Ripetti  ---
Created attachment 119535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119535=edit
Bug 11361 - Fixing database and merge conflicts

Bug 11361 - Fixing z3950servers.tt problems

Bug 11361 - Re-adding the 'Attributes' column

Bug 11361 - Fixing z3950servers.tt problems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21260] Improve the Availability line of OPAC XSLT search results

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260

--- Comment #40 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #39)
> I overlooked this one, I didn't notice the use of the "local pref".
> 
> Why didn't we create a "real" system preference here?

Comment12
Do you need a follow-up here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21260] Improve the Availability line of OPAC XSLT search results

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Keywords||release-notes-needed

--- Comment #39 from Jonathan Druart  
---
I overlooked this one, I didn't notice the use of the "local pref".

Why didn't we create a "real" system preference here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28143] @INC filled with duplicates of opachtdocs and intrahtdocs

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28143

Julian Maurice  changed:

   What|Removed |Added

 CC||didier.gautheron@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28143] New: @INC filled with duplicates of opachtdocs and intrahtdocs

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28143

Bug ID: 28143
   Summary: @INC filled with duplicates of opachtdocs and
intrahtdocs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Steps to reproduce:
1. Have a $KOHA_CONF with at least 2 'pluginsdir' entries. You need at least
one plugin with a 'tool', 'report', or 'configure' method. This will be useful
to trigger the loading of Koha::Plugins::Handler. The KitchenSink module is
perfect for that.
2. Start starman with only 1 worker (not necessary but it's easier to reproduce
the problem that way)
3. Load staff client home page multiple times
4. Run the plugin method of your choice
5. Go to the About page, you should see the template directories in "Perl @INC"

The problem is located in C4::Templates::badtemplatecheck, which push
'opachtdocs' and 'intrahtdocs' config entries directly into the 'pluginsdir'
key of global variable $context

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27995] Koha::Account::Line->apply should return the update Koha::Account::Line object

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27995

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #10)
> Tree re-arranged slightly to put bugs that need backporting before these
> enhancements that don't.
> 
> Rebased to accommodate the above.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240

Henry Bolshaw  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28142

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142

Henry Bolshaw  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25240

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240

--- Comment #3 from Henry Bolshaw  ---
I can't replicate this bug exactly either but it sounds like a similar issue to
bug 28142

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #16 from Tomás Cohen Arazi  ---
Jonathan, I submitted what I had in mind for you to ponder.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125

--- Comment #3 from Andrew Fuerste-Henry  ---
Created attachment 119534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119534=edit
Message larger than table

Seems reasonable! The real pain here is that it took a while to figure out that
this system preference was the cause of the error, so a warning is definitely
helpful. 
I've got a really picky display complaint, though. On Chrome, the warning
message ends up a little longer than the table itself and doesn't look good.
Can you make the table resize to fit the message?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 119533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119533=edit
Bug 23271: (QA follow-up) Minor POD fix

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 119532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119532=edit
Bug 23271: Replace search_limited with search_with_library_limits

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 119531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119531=edit
Bug 23271: Use Koha::Object::Limit::Library for Koha::Patron::Categories

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28142] New: Accessibility: OPAC Cart/basket checkboxes are not labelled

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142

Bug ID: 28142
   Summary: Accessibility: OPAC Cart/basket checkboxes are not
labelled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The checkboxes on the OPAC cart ("Basket") pages are not labelled. this makes
it hard for users of screen readers to determine their purpose. This applies to
both the brief and verbose displays.

e.g. the checkbox appears in NVDA as:

"Unlabeled; check box; not selected"

We should add distinct labels so that users can identify the purpose of the
checkboxes without visual context.

The labels should include the title of the item so that users can decide which
items to select from a list e.g. "Select [Title]" rather than "Select item".

From what I've read it is better to use  with the .sr-only class rather
than using aria-label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 119530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119530=edit
Bug 23271: Improve library limitation selection for item types

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 119529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119529=edit
Bug 23271: (QA follow-up) Make search_with_library_limits fallback to userenv
if required

This patch makes  the generic method rely on C4::Context->userenv if the
library_id is not passed.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #119503|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #119505|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #119504|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28141] New: Accessibility: OPAC Advanced Search fields aren't labelled

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28141

Bug ID: 28141
   Summary: Accessibility: OPAC Advanced Search fields aren't
labelled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The OPAC advanced search page has unlabelled search fields making them
inaccessible to users of screen readers. This is a complicated page to get
right and I'm not entirely sure how best to fix this. Here are some of the
issues with the page currently:

Example issue 1:
When using NVDA to access the search form fields out of context, it is hard to
tell which index (keyword, author, title etc.) you are searching. This is an
issue when searching multiple fields at once.

"Enter search terms; edit; has auto complete"

It would be better if the search form field was linked to the index combo box.
We could use aria-labelledby but there may be better ways to do this.

Example Issue 2:
The label for "search-field_0" is blank.

Example Issue 3:
The search terms are linked by 'and' but this isn't entirely clear out of
context using a screen reader:
"  ;combo box; collapsed; Subject"
"and;combo box; collapsed; Title"
"and;combo box; collapsed; Publisher Location"
"Location and availability:; combo box; collapsed; All Libraries"
"Sort by:; combo box; collapsed; Relevance"
"Language; combo box; collapsed; No Limit"

Example Issue 4:
The remove field buttons aren't programmatically linked to the field they are
removing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28140] Accessibility: OPAC - "sort_by" select isn't labelled on search results page

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28140

Henry Bolshaw  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #10 from Tomás Cohen Arazi  ---
The changes assume ->search_with_library_limits implicitly falls back to
C4::Context->userenv->{branch} if no library_id is passed.

While that could be convenient, it is not the case right now. So failing it
until it passes the right library_id or this/a new bug introduces the fallback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21549] Lock expired patron accounts

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549

Marcel de Rooy  changed:

   What|Removed |Added

  Text to go in the||This report adds pref
  release notes||LockExpiredDelay. When you
   ||enter a value there, the
   ||cleanupdatabase cron job
   ||will lock the accounts of
   ||patrons that expired at
   ||least the specified number
   ||of days.
   ||This follows the
   ||same pattern as existing
   ||code that already allows
   ||you to anonymize or delete
   ||locked patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28140] Accessibility: OPAC - "sort_by" select isn't labelled on search results page

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28140

--- Comment #1 from Henry Bolshaw  ---
Created attachment 119528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119528=edit
Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search
results page

This patch adds a label to the sort function on the OPAC
results page to provide context to screen readers and improve
accessibility.

The label is visually hidden and does not change how the page
displays.

To test:
- Search for something on the OPAC
- Change how the results are sorted and confirm sort still works
- Confirm that there are no visual changes to the page
- Inspect the sort function to confirm it now has a label
- Ideally confirm the label works with a screenreader

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28140] Accessibility: OPAC - "sort_by" select isn't labelled on search results page

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28140

Henry Bolshaw  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21549] Lock expired patron accounts

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549

--- Comment #38 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #34)
> Do you agree with those 3 patches, Marcel?

Sure, thanks. Found a solution in the middle ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21549] Lock expired patron accounts

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #119464|0   |1
is obsolete||

--- Comment #37 from Marcel de Rooy  ---
Created attachment 119527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119527=edit
Bug 21549: Make filter_by_last_update returns a Koha::Objects-based object

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21549] Lock expired patron accounts

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #119463|0   |1
is obsolete||

--- Comment #36 from Marcel de Rooy  ---
Created attachment 119526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119526=edit
Bug 21549: Rename filter_by_dateexpiry with filter_by_expiration_date

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21549] Lock expired patron accounts

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #119462|0   |1
is obsolete||

--- Comment #35 from Marcel de Rooy  ---
Created attachment 119525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119525=edit
Bug 21549: Use filter_by_last_update from filter_by_dateexpiry

To not reengineer the patch this patch does not remove the new
subroutine but make it use the logic from
Koha::Objects->filter_by_last_update

It also adds a new parameter "days_inclusive"

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21549] Lock expired patron accounts

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21549

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28135] Replace use of input type number in additem.js

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135

David Nind  changed:

   What|Removed |Added

Summary|Replace use of input type   |Replace use of input type
   |number in onboarding|number in additem.js
   |templates   |
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28140] Accessibility: OPAC - "sort_by" select isn't labelled on search results page

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28140

Henry Bolshaw  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |bolsh...@parliament.uk
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28140] New: Accessibility: OPAC - "sort_by" select isn't labelled on search results page

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28140

Bug ID: 28140
   Summary: Accessibility: OPAC - "sort_by"  select isn't labelled
on search results page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The  element used to sort search results on the OPAC search results
page (opac-search.pl) isn't labelled. This makes it harder for users of screen
readers and other assistive technologies to identify the purpose of the sort
function.




should become:

Sort by:


We should add a  with class .sr-only to identify this to screenreaders
only because the purpose of the sort function is clear from visual context. (We
could use an aria-label instead of  but the 'first rule of ARIA' is to
use native HTML where possible:

"2.1 First Rule of ARIA Use
If you can use a native HTML element [HTML51] or attribute with the semantics
and behavior you require already built in, instead of re-purposing an element
and adding an ARIA role, state or property to make it accessible, then do so."
(From https://www.w3.org/TR/using-aria/#firstrule)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #5 from Thomas Klausner  ---
Hi!

No, it's not ready for testing yet, mostly because I realized that I also need
to port the second step of the import process; plus, I was distracted by other
projects...

I'll try to finish this feature this month. Or do you have any sooner (release)
deadlines?

Greetings,
domm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28028] fix_onloan.pl broken by bug 23463

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28028

--- Comment #8 from Joonas Kylmälä  ---
(In reply to Joonas Kylmälä from comment #7)
> Hmm, strange:
> 
> If I look ModItem() subroutine on revision
> 0c8d8e867b18b61f39381d2061cd2124fe1c5ed3 (which is just before it was
> deleted from codebase it has not fetched issues.date_due value as far as I
> can see, I checked all the code paths in ModItem() to my best ability.
> 
> So this would conflict with what both Martin and Katrin are remembering.

Yup, I now checked out Koha version just before Bug 23463 was merged:

$ git reset --hard f04e77c7e5411ca7dcf761e7e1177d7362a10654

and the fix_onloan.pl script didn't update the items.onloan value to be same as
in issues table.

Here is the steps I used to test this:

> $ git reset --hard f04e77c7e5411ca7dcf761e7e1177d7362a10654
> $ reset_all
> # Checkout an item to patron and then:
> $ koha-mysql kohadev
> > update items SET onloan = "2020-01-01" WHERE itemnumber=549
> $ koha-shell kohadev
> $ (inside koha-shell) perl fix_onloan.pl
> $ koha-mysql kohadev
> > select * from items WHERE itemnumber=549 # and notice it didn't update

So I strongly think this script has been doing nothing after bug 5579 has been
merged and we stopped storing items in MARC format.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #4 from Jonathan Druart  
---
Hi Thomas, any news from this? Is it ready for testing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28028] fix_onloan.pl broken by bug 23463

2021-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28028

--- Comment #7 from Joonas Kylmälä  ---
Hmm, strange:

If I look ModItem() subroutine on revision
0c8d8e867b18b61f39381d2061cd2124fe1c5ed3 (which is just before it was deleted
from codebase it has not fetched issues.date_due value as far as I can see, I
checked all the code paths in ModItem() to my best ability.

So this would conflict with what both Martin and Katrin are remembering.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >