[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #40 from David Cook --- Only realising now that Mojolicious::Plugin::OpenAPI is only in Bullseye: https://packages.debian.org/bullseye/libmojolicious-plugin-openapi-perl It's version 3.41 and requires JSON::Validator 4.11+ and Mojolicious 8.67+. Ubuntu 18.04 Bionic - Mojolicious 7.59 - Mojolicious::Plugin::OpenAPI N/A Ubuntu 20.04 Focal - Mojolicious 8.33 - Mojolicious::Plugin::OpenAPI 2.21 - JSON::Validator 3.15+ - Mojolicious 8+ I don't know that Mojolicious::Plugin::OpenAPI 2.x can work with JSON::Validator 4.x... I see that with Koha on Ubuntu 20.04 we're using a JSON::Validator marked as 3.25+dfsg-1+koha3 Overall, I like Mojolicious, but I do not like this dependency hell. -- It looks like Mojolicious::Plugin::OpenAPI 3.41 is compatible with either Mojolicious 8.0 or Mojolicious 8.67. Depends on if you trust the META.json/cpanfile or the Changes file more. It claims to work with JSON::Validator 4.11... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #39 from David Cook --- (In reply to Martin Renvoize from comment #26) > Mojolicious uses pretty standard semantic versioning.. jump a major and you > can't really expect things to work. > > The latest combination of dependencies I found to work with current Koha is: > > Mojolicous 8.73 > JSON::Validator 4.05 > Mojolicious::Plugin::OpenAPI 3.39 > > If we wanted to jump beyond that we'll need to change the Koha codebase to > accommodate the changes in the libraries. > > What's easier, backporting new libraries to older Debian (and updating our > codebase for the newer libraries) or downgrading/pinning older libraries on > newer Debian? > > > Or, dare I say it.. shipping a local clone of the Mojo stack inside Koha. I'm still investigating, but I'd be interested in getting at least JSON::Validator 4.10. At a glance, it looks like it will work with Mojolicious 7.28. Wow... Mojolicious::Plugin::OpenAPI and JSON::Validator have very different ideas about Mojolicious dependencies. JSON::Validator 4.x is OK with Mojolicious 7, but Mojolicious::Plugin::OpenAPI 2.x+ wants Mojolicious 8 and lower JSON::Validator versions... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 --- Comment #3 from wainuiwitikap...@catalyst.net.nz --- Please refer to Bug 27846 for discussion around the styling of breadcrumbs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 --- Comment #2 from wainuiwitikap...@catalyst.net.nz --- Created attachment 119934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119934=edit Bug 28101: changed breadcrumbs in the OPAC Modified breadcrumbs to be accessible, in particular for a screen-reader. Also ensured the breadcrumbs were all consistent. Made the block of breadcrumbs to be a with an ordered list inside. The last breadcrumb also has aria-current="page" to specify that it is the current page. To test: 1) Apply patch 2) Build scss file 3) Ensure each of the files have breadcrumbs that are in a block 4) Ensure that there is an ordered list in the block of breadcrumbs 5) Ensure that the last breadcrumb has aria-current="page" 6) Ensure that the breadcrumbs on each page of the OPAC looks basically the same as before, but the '>' symbol is more bold, and the last breadcrumb has bold text 7) Ensure that when the last breadcrumb is clicked it takes you to the page you are currently on Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 --- Comment #1 from wainuiwitikap...@catalyst.net.nz --- Created attachment 119933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119933=edit Bug 28101: changed styling for breadcrumbs Updates opac.scss file so the breadcrumbs will appear the same as Bug 27846 (Staff Client breadcrumbs). This works but the file may need to be changed/cleaned up so that there is not unnecessary information in it. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28155] Guided report save goes to 403
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28155 --- Comment #3 from Kim Colbourne --- (In reply to Katrin Fischer from comment #1) > Hi Kim, thx for reporting. Could you add a bit more detail? Are you creating > a new guided report when this occurs? What is your exact Koha version? This > can be found on the first tab of the About page. Creating a new guided report. Wondering if it's a permissions problem on the folder that's stopping me saving a new report? Previously created reports all run fine. Version is 20.05.10. Also wondering if it's a newly installed WAF causing issues as I haven't created any reports since installing it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #10 from David Cook --- (In reply to Rudolf Byker from comment #9) > Do you mean that they are only stripped out when displayed in the browser? > In that case, all is well. Yes, the XSLT is sent in the browser response, and the browser applies the XSLT to the XML to generate a HTML document. That XSLT strips out the 'T' and the 'Z'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #4 from Owen Leonard --- This works really well overall, but there is a problem when there is a language toolbar in the footer. The toolbar completely obscures the footer for the gallery. I have some CSS update suggestions but I'm not sure what is the best way to modify the CSS... Change the original, since we're already using a modified version of the JS? Add a second CSS file to override? Use a copy of the original which we track separately? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28185] Allow staff to add or reset OPAC renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28185 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 David Nind changed: What|Removed |Added Attachment #119927|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 119932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119932=edit Bug 28157: Add handling for the x-koha-library header This patch introduces a new header handling. The key idea is that on Koha's base classes there's broad usage of C4::Context->userenv to determine the current library and make decisions based on that. API requests, on the other hand, might not be tied to sessions (stateless) which is the way current library is retrieved. So we need a way to properly specify what library the request is trying to act as coming from. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass! 3- Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 David Nind changed: What|Removed |Added Attachment #119926|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 119931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119931=edit Bug 28157: Regression tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 David Nind changed: What|Removed |Added Attachment #119925|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 119930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119930=edit Bug 28157: Add Koha::Patron->can_log_into This patch adds a new method that tells if the patron is allowed to be logged into certain library. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28185] New: Allow staff to add or reset OPAC renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28185 Bug ID: 28185 Summary: Allow staff to add or reset OPAC renewals Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: pnavarr...@cca.edu QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be useful for staff to have the ability to add OPAC renewals to checked out items. For example, if a patron is allowed 4 renewals and has used them all up, staff could either add a specified number of renewals, or reset the renewals to 4. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28037] Improve breadcrumbs of CSV profiles page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 --- Comment #12 from David Nind --- (In reply to Katrin Fischer from comment #8) > This makes me wonder a few things: > > - Should we be using Edit or Modify? Do we have a preferred term or does it > not matter? > > - It now reads: "Modify a CSV profile" Looking at other pages, should this > just be "Modify CSV profile"? (see news) > > - Or should we even try to include the name of the profile we also do > sometimes? "Edit CSV profile '...' (see itemtypes) > > Still going to pass QA as this is definitely a step in the right direction > and an improvement. I have added Bug 28184 for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28184] New: Terminology: Edit or Modify on forms for changing information in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28184 Bug ID: 28184 Summary: Terminology: Edit or Modify on forms for changing information in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: da...@davidnind.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In the OPAC staff interface we use a mix of 'Edit' and 'Modify' on forms for changing information in Koha. Should we be using Edit or Modify for editing forms? Do we have a preferred term or does it not matter? Should we be more consistent? Some examples: - Cataloging for a record: Edit > Edit record, Edit items, Edit items in batch; form is labelled 'Editing [title]', 'Edit Item #XXX', 'Edit items' - Administration > Z39.50/SRU servers administration: Edit for action menu, on the form 'Modify Z39.50 server' - Administration > Libraries: Edit for the action menu, on the form we use 'Modify library' - Tools > Patron lists: Edit for action menu, on the form 'Modify patron list' - Tools > News: Edit for action menu, 'Edit news item' for the form - Patrons: Edit for the action, 'Modify patron [name...]' - Acquisitions > Vendor edit: 'Edit vendor' button, 'Update: [vendor name]' - Acquisitions > Baskets: 'Edit basket' button, 'Edit basket [basket name]' - Tools > CSV profiles: Edit for the action menu, 'Modify a CSV profile' Whatever way is decided (if anything) we should al least be consistent in the future, both from a user interface point of view and to help with translation. (Raised following comment 8 for bug 28037) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28183] New: retain patron-deleted suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28183 Bug ID: 28183 Summary: retain patron-deleted suggestions Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org In the purchase suggestions process, when a patron deletes their suggestion, the data is gone from all elements. For instance, a patron makes a purchase suggestion, the library orders the item and notifies the patron it has been ordered, if the patron then deletes the suggestion, there is no record/information for the library about who wanted it, etc. It is completely removed from the purchase suggestion process. This is information that libraries need to be able to view, even if it is only available via reports on deleted tables or something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #12 from Nick Clemens --- This certainly improves things, however, the initial problem reported still exists - a search for '1st to die' searches the isbn field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533 Nick Clemens changed: What|Removed |Added Blocks||28182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28182 [Bug 28182] Elastic search exact authorities search includes punctuation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28182] Elastic search exact authorities search includes punctuation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28182 Nick Clemens changed: What|Removed |Added Depends on||26533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533 [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28182] New: Elastic search exact authorities search includes punctuation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28182 Bug ID: 28182 Summary: Elastic search exact authorities search includes punctuation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com Bug 26533 fixes the 'exact' search option to search exactly This reveals that the ES search includes punctuation In koha testing docker search for: Addison-Wesley professional computing series And then: Addison-Wesley professional computing series. You get different records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533 Nick Clemens changed: What|Removed |Added Attachment #118257|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 119929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119929=edit Bug 26533: Fix 'is exactly' search for authorities The exact search 6=3 is implemented, but it isn't used as expected when you select 'is exactly' from the authorities search dropdown. This patch remedies that. To test: 1) Ensure you have an authority with more than one word in the name, i.e. Electric power production 2) Go to Authorities in the staff client. 3) Change the dropdown to 'is exactly' and search for one of the words in your record's title, i.e. 'power' in the 'main heading' search 4) Confirm your authority shows in the results, even though it is not an exact match. 5) Search for a biblio record and go to edit the record. 6) Go to Tab 6 and click the plugin button next to one of the 6xx$a fields to trigger the authority finder plugin 7) Repeat Step 3 and Step 4 8) Go to the OPAC and go to Authority Search 9) Repeat Step 3 and Step 4 Apply patch 10) Repeat Steps 1 to 9, confirm that this time the record does NOT show in search results. 11) Repeat Steps 1 to 9 but this time search for the authority record's full title, i.e. 'Electric power production'. Confirm the record does show in the search results because the search term now matches title exactly. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Cook Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 --- Comment #30 from David Nind --- Created attachment 119928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119928=edit Bug 11361 - Screenshots of pop-up window display I've quickly tested again. Screenshots attached from using Firefox Developer Edition on Ubuntu 18.04. The pop-up window for the display for searching doesn't look right. This may be because of the Bootstrap update changes. I'm assuming that if it is setup to search another Koha catalog, then the MARC and Card links will work (instead of page not found errors) and that the Show link will work as well (currently links to http://cgi-bin/koha/opac-detail.pl?biblionumber=). To test properly, does anyone have the details for a Koha catalog which would work? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28002] Add optional extended_attributes param to POST /patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28002 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28002] Add optional extended_attributes param to POST /patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28002 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 Tomás Cohen Arazi changed: What|Removed |Added Blocks||28002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28002 [Bug 28002] Add optional extended_attributes param to POST /patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28002] Add optional extended_attributes param to POST /patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28002 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28157 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 [Bug 28157] Add the ability to set a library from which an API request pretends to come from -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add routes for extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Depends on|28161 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28161 [Bug 28161] Allow Koha::Patron->extended_attributes be passed a library_id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28161] Allow Koha::Patron->extended_attributes be passed a library_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28161 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|In Discussion Blocks|23666 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23666 --- Comment #1 from Tomás Cohen Arazi --- With bug 28157 I'm not going forward with this one. Not closing it, as it might be handy in a near future. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 [Bug 23666] Add routes for extended patron attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #6 from Tomás Cohen Arazi --- My attempt to this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 119927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119927=edit Bug 28157: Add handling for the x-koha-library header This patch introduces a new header handling. The key idea is that on Koha's base classes there's broad usage of C4::Context->userenv to determine the current library and make decisions based on that. API requests, on the other hand, might not be tied to sessions (stateless) which is the way current library is retrieved. So we need a way to properly specify what library the request is trying to act as coming from. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass! 3- Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 119926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119926=edit Bug 28157: Regression tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 119925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119925=edit Bug 28157: Add Koha::Patron->can_log_into This patch adds a new method that tells if the patron is allowed to be logged into certain library. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28181] New: Archived debit type still shows as available in Point of Sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28181 Bug ID: 28181 Summary: Archived debit type still shows as available in Point of Sale Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: esth...@sodaspringsid.com QA Contact: testo...@bugs.koha-community.org I archived a debit type, however when I return to the point of sale page, the archived debit still shows as available. This means the archived debit could still be used for transactions. The archived debit still had the library selected in library limitations. I restored the debit, deselected the library, saved the debit, then re-archived the debit. With a multi-branch configuration, this led to the debit being made available to all libraries despite being archived. I went back, restored the debit and have temporarily assigned the debit to the Placeholder branch so that it is only available there. I assumed an archived debit would no longer be made available making it impossible to continue to use. To duplicate: 1. Create a debit with library limitation of logged in library. 2. Archive the debit 3. Go to Point of Sale page. Archived debit will be visible and available for use by the library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
--- Comment #38 from Bohdan ---
(In reply to Mason James from comment #37)
> (In reply to Bohdan from comment #36)
> > Hello. I've installed Koha 20.11.04 on latest Debian 10 and the API is
> > broken. I cannot get the list of available branches as it uses API.
> >
> > Got the following in api error logs:
> > [ERROR] Warning: Could not load REST API spec bundle: Can't use string
> > ("parameters.json") as a HASH ref while "strict refs" in use at
> > /usr/share/perl5/JSON/Validator/OpenAPI/Mojolicious.pm line 272.
>
> hi Bohdan,
> are you using 64-bit debian? it is recommended
Of course, it is x64.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24023] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 --- Comment #24 from Martin Renvoize --- Also.. I'm interested to know how/if this plays nicely with our existing analytics and multi-part biblio support.. EasyAnalytics and UseControlNumber preferences. Adding 774's seems OK, but I also wonder if we aught to be updating/ensureing the leader's are set correcting (position 7 being set to 'c' for 'Collection' for example.. and the corresponding XSLT linking fields set for display for such host records?) However, I don't see this comment as a blocker.. more an nice to have, interesting question.. Thanks for looking at a move to Koha::.. it didn't look too crazy hard when I investigated.. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24023] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #23 from Julian Maurice --- (In reply to Martin Renvoize from comment #22) > Any chance of updating this to Koha:: space Julian? I note it's lacking > unit tests and a move to Koha:: objects would be nice for future maintenance > too. Ah yes, tests are certainly needed. And I suppose it shouldn't be too hard to move it to Koha:: namespace while writing tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24023] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #22 from Martin Renvoize --- Any chance of updating this to Koha:: space Julian? I note it's lacking unit tests and a move to Koha:: objects would be nice for future maintenance too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #7 from Jonathan Druart --- Created attachment 119924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119924=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #6 from Jonathan Druart --- Created attachment 119923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119923=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #5 from Jonathan Druart --- Created attachment 119922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119922=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #4 from Jonathan Druart --- Created attachment 119921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119921=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #3 from Jonathan Druart --- Created attachment 119920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119920=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180
--- Comment #2 from Jonathan Druart
---
Created attachment 119919
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119919=edit
Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC
interface
This patch is the OPAC version of
Bug 28179: Add a lightbox gallery to display cover images - detail page,
staff interface
But there were several difficulties as the staff and OPAC code diverged
a lot.
First we are going to apply the different enhancements that have been
made staff-side:
- Display all the local cover image on the bibliographic detail pages
(before this patch only the first one was displayed)
- The slider functionality added by bug 25031
Test plan:
All the cover images are affected, all the different sources will be
tested.
All the steps will be done on the same bibliographic record.
1. Local cover images
a. Turn on OPACLocalCoverImages and AllowMultipleCover
b. Add several local cover images to a bibliographic record
c. Add several local cover images to an item
d. Click on an image and confirm that it is displayed in a gallery and
you can navigate see all the images attached to the bibliographic
record
e. Same for items
2. Adlibris
a. Turn on AdlibrisCoversEnabled
b. Edit the biliographic record and add an ISBN that will return a
cover image for this service (9780670026623 for instance)
c. Display the cover images in the gallery
d. Note the link to the adlibris.com website at the bottom
3. Amazon
a. Turn on OPACAmazonCoverImages
b. Display the cover images in the gallery
4. Coce
a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080;
and select some values for CoceProviders.
b. Display the cover images in the gallery
5. Custom cover images
a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to
https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg
of anything else meaningful
b. Display the cover images in the gallery
QA Note: Other sources have been removed by this patch but will be
re-added by follow-ups
Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #1 from Jonathan Druart --- Created attachment 119918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119918=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26927] Add the ability to advance search Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26927 Rhiana changed: What|Removed |Added CC||rmcomp...@arlingtonva.us --- Comment #5 from Rhiana --- Similarly, it would be beneficial to view the source (MARC |2) of the Authority record, namely lcgft and gsafd. Right now, the only way to view is in edit (accessing Authorities via Advanced editor) and then you can't go back to select one or the other. Also - search doesn't return any results when lcgft (etc) remains in Main Headings search parameters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 jmbroust changed: What|Removed |Added CC||jean-manuel.broust@univ-lyo ||n2.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9589] Authorities to authorities linker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9589 Rhiana changed: What|Removed |Added CC||rmcomp...@arlingtonva.us --- Comment #3 from Rhiana --- Interested :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28169] Reverting waiting hold causes holds page Javascript stop functioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28169
Owen Leonard changed:
What|Removed |Added
Attachment #119853|0 |1
is obsolete||
--- Comment #2 from Owen Leonard ---
Created attachment 119917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119917=edit
Bug 28169: Add quotes around value in template to render proper JS
There is code in request.tt:
homebranch: "[% ... %]",
holdallowed: [% ... %]
There only digits where expected earlier in holdallowed
but now it can be string value ('from_any_library' for example),
so it should be in quotes.
To reproduce the problem:
1. Add circulation rules which allow 1 hold only to the itemtype
2. Make sure AllowHoldPolicyOverride syspref enabled
3. Make 1 hold to patron for any biblio which has a few items available,
for example on "reset_all dev db set":
/cgi-bin/koha/reserve/request.pl?biblionumber=4=1
(this biblio record has 4 items)
4. Start another hold for same patron on any biblio record or the same,
and keep browser's JS console open,
for example on "reset_all dev db set":
/cgi-bin/koha/reserve/request.pl?biblionumber=4=1
5. You should see now JS error in browser console:
Uncaught ReferenceError: from_any_library is not defined
Uncaught ReferenceError: columns_settings_borrowers_table is not defined
6. Apply the patch
7. Repeat the steps 4-5 (reload the page) and now the JS error should be gone
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28169] Reverting waiting hold causes holds page Javascript stop functioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28169 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Change sponsored?|--- |Unsponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #3 from Jonathan Druart --- Created attachment 119916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119916=edit Bug 28179: Adjust chocolat.js to display href In order to display link in the description we need to adjust chocolat.js Maybe this needs to be reported upstream Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179
--- Comment #2 from Jonathan Druart
---
Created attachment 119915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119915=edit
Bug 28179: Add a lightbox gallery to display cover images - detail page, staff
interface
This patch adds the ability to display the cover images of a
bibliographic record in a gallery. Cover images attached to items can
also be displayed in separated galleries.
Test plan:
All the cover images are affected, all the different sources will be
tested.
All the steps will be done on the same bibliographic record.
1. Local cover images
a. Turn on LocalCoverImages and AllowMultipleCovers
b. Add several local cover images to a bibliographic record
c. Add several local cover images to an item
d. Click on an image and confirm that it is displayed in a gallery and
you can navigate see all the images attached to the bibliographic
record
e. Same for items
2. Adlibris
a. Turn on AdlibrisCoversEnabled
b. Edit the biliographic record and add an ISBN that will return a
cover image for this service (9780670026623 for instance)
c. Display the cover images in the gallery
d. Note the link to the adlibris.com website at the bottom
3. Amazon
a. Turn on AmazonCoverImages
b. Display the cover images in the gallery
4. Coce
a. Turn on IntranetCoce, set CoceHost to "http://coce.tamil.fr:8080;
and select some values for CoceProviders.
b. Display the cover images in the gallery
5. Custom cover images
a. Turn on CustomCoverImages and set CustomCoverImagesURL to
https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg
of anything else meaningful
b. Display the cover images in the gallery
Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #1 from Jonathan Druart --- Created attachment 119914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119914=edit Bug 28179: Add the Chocolat gallery lightbox JS library Chocolat is a lightbox JS library. https://chocolat.insipi.de https://github.com/nicolas-t/Chocolat https://chocolat.gitbook.io Why Chocolat? It's released under the GPL v3 license, easy to use, configure and extend, and is still maintained/active. (and it has a nice name) Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Owen Leonard changed: What|Removed |Added Attachment #119910|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 119913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119913=edit Bug 28178: Display the correct image in the image viewer When there are several images attached to a bibliographic record, one can click an image and see it in the image viewer. But the first image is always displayed. Test plan: 0. Turn on LocalCoverImages and AllowMultipleCovers 1. Attach at least two images to a bibliographic record 2. Go to the detail page, click the "Images" tab and click the second image. => With this patch applied you should see the image you selected Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't show Suppress in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Andrew Fuerste-Henry changed: What|Removed |Added Version|19.05 |master --- Comment #9 from Andrew Fuerste-Henry --- I've just confirmed that this problem exists in master and 20.05. To recreate: - set OpacSuppression to Hide - Edit a bib, set 942$n=1 - confirm bib shows "Suppressed in OPAC" in the intranet and will not open on OPAC - Edit the framework used by this bib, connect the 942$n to the YES_NO auth value - Reload the bib without editing it, confirm "Suppressed in OPAC" message no longer shows - try to open record in OPAC, confirm it's still suppressed - edit record, set 942$n to No, confirm no apparent change on intranet, record now opens on opac - edit record, set 942$n to Yes, confirm no apparent change on intranet, record is now suppressed on opac - Edit the framework again, unlink the auth value - reload bib without editing, confirm bib shows "Suppressed in OPAC" in the intranet and will not open on OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #4 from Owen Leonard --- I'm glad to have your detailed feedback, because I don't have good serials data to test with and I wasn't sure I was mocking it up correctly. I don't know the answer to whether the grouped sorting is better, so I defer to your opinion. What feature do you mean when you say it isn't documented? The data-order sorting option is documented here: https://datatables.net/examples/advanced_init/html5-data-attributes.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #19 from Martin Renvoize --- I believe this works as described.. I did a little followup to clean up the code a little whilst I was wrapping my head around the various failure clauses. Signing off so Joonas can move on to QA ;).. He's certainly the expert in these parts at the moment and looks to be progressing nicely with a code review.. so I'll encourage him to continue :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #18 from Martin Renvoize --- Created attachment 119912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119912=edit Bug 25711: (QA follow-up) Refactor to clarify logic At the point where 'ExpireReservesMaxPickUpDelayCharge' can/should kick in, we should already have an item waiting (else what's triggered a pickup delay). As such we can drop the fall through default of using the syspref when we don't yet have an item. We can also save us some calculations and database hits by only calculating the charge value when we've actually been asked to charge. So we also move the block inside the 'charge_cancel_fee' block. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
Martin Renvoize changed:
What|Removed |Added
Attachment #119851|0 |1
is obsolete||
--- Comment #17 from Martin Renvoize ---
Created attachment 119911
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119911=edit
Bug 25711: add ExpireReservesMaxPickUpDelayCharge to circulation rules
Add a feature that allows to define ExpireReservesMaxPickUpDelayCharge
in circulation rules per specific items/patron categories.
When value not found in circulation rules it uses global
ExpireReservesMaxPickUpDelayCharge, as it was before this smart-rules
feature was introduced.
To check the feature after applying the patch:
1) Go to /cgi-bin/koha/admin/preferences.pl and set
ExpireReservesMaxPickUpDelay to allow.
1) Go to /cgi-bin/koha/admin/smart-rules.pl circulation rules table
and notice the newly added "Expire reserve charge" row.
2) In that row add numerical values to type/patron categories
that you will be using later to test this feature.
3) Prepare an item for our next step, pick a biblio that has item
with the same item type you altered in smart rules and check it out.
3) Place a hold on that item and set the expiration date as the
next day.
4) Check in it after that.
5) Do SQL request to change expiration date manually to "yesterday":
in "reserves" table, find the id of the hold that you placed and
"UPDATE reserves SET `expirationdate`='2020-07-19' WHERE
`reserve_id`=329;"
Or alternatively:
5) Wait for tomorrow, change server time or invent a time machine.
6) Run cancel_expired_holds.pl cron job.
7) Check that patron got charged in "accounting" left tab and
"transactions" upper tab: your patron should have debt of that amount
of fee you assigned in that rule
(/cgi-bin/koha/members/boraccount.pl?borrowernumber=...YourPatronID...)
8) You can repeat this with other rules and different
numbers/biblio/item types to check that different fees apply according
to smart rules.
9) If there's no matching smart rule or smart rule have an empty
string as a fee - global ExpireReservesMaxPickUpDelayCharge variable
value will be used.
10) But in case if matching rule has zero ("0") as a value - that
allows to have no-fee smart-rule results, as a feature.
IMPORTANT:
Smart-rules filters only applied to item-level holds when item-type
for items is known. If there's biblio-level hold, in that case global
ExpireReservesMaxPickUpDelayCharge value will be used).
Mentored-by: Andrew Nugged
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart changed: What|Removed |Added Blocks||28180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] New: Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Bug ID: 28180 Summary: Use a lightbox gallery to display the images - detail page, OPAC interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 28179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] New: Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Bug ID: 28179 Summary: Use a lightbox gallery to display the images - detail page, staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 28178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 [Bug 28178] Image viewer does not select the correct image -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Jonathan Druart changed: What|Removed |Added Blocks||28179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 --- Comment #1 from Jonathan Druart --- Created attachment 119910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119910=edit Bug 28178: Display the correct image in the image viewer When there are several images attached to a bibliographic record, one can click an image and see it in the image viewer. But the first image is always displayed. Test plan: 0. Turn on LocalCoverImages and AllowMultipleCovers 1. Attach at least two images to a bibliographic record 2. Go to the detail page, click the "Images" tab and click the second image. => With this patch applied you should see the image you selected Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] New: Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Bug ID: 28178 Summary: Image viewer does not select the correct image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org When there are several images attached to a bibliographic record, one can click an image and see it in the image viewer. But the first image is always displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #13 from Martin Renvoize --- This is just a starting point so far.. not complete yet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #12 from Martin Renvoize --- Created attachment 119909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119909=edit Bug 3492: Begginings of moving holds_fee rule to circulation rules -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #3 from Joonas Kylmälä --- Hmm, the proposed solution here is not like it was before bug 27980. Before we sorted either with publisheddate alone if one of the items had it at least, but now with this we would sort both of the values. This seems okay because how this seems to work now is that the ones with the data-order attribute set (so publisheddate) are sorted as one group and then the ones without data-order are sorted as another group. So both get sorted, but separately. Owen, do you think this change in sorting order is okay? Previously the ones without publisheddate didn't get sorted so this might actually be improvement but want to hear your opinion as well. Also I didn't find any documentation for this in DataTables manual so we might also want to consider if we should depend on this and whether the sorting order will possibly change in future if DataTables changes some code because it seems undocumented feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #11 from Martin Renvoize --- (In reply to Martin Renvoize from comment #10) > Aha, GetReservesControlBranch deals with this for us already.. so it's a > non-issue. Humm.. actually, it doesn't. `GetReservesControlBranch` requires an item (for the case where `ReservesControlBranch` is set to 'ItemHomeLibrary'). However, at the time of reserve we don't always have that information yet (Bib level holds).. so for the case where we charge at the point of placing a hold and we allow biblio level holds.. we would explode. Rethink needed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26116] Allow multiple suppression values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26116 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #2 from Sarah Cornell --- +1! In order to make it easier for staff to assign the suppression value, I redefined 1 to "Suppressed in OPAC" but now the line "Suppressed in OPAC" doesn't display on search results or detail pages. More flexibility in defining suppression values, please! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #10 from Martin Renvoize --- Aha, GetReservesControlBranch deals with this for us already.. so it's a non-issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28064] Transits are not created at check in despite user responding 'Yes, print slip' to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #15 from Kyle M Hall --- *** Bug 28176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Kyle M Hall changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 28064 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 --- Comment #2 from Owen Leonard --- I think this is a duplicate of Bug 28064 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #9 from Martin Renvoize --- Looking into this... Moving to the circulation rules adds an additional question.. Whilst I can understand the want to add rules at itemtype and patron category levels.. would there also be a need to do this at a branch level too... and if that is the case.. which branch would govern the looking.. the pickup location, the items home library, the items current holding library?.. it opens a bit of a can of worms ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Owen Leonard changed: What|Removed |Added Blocks||28177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 [Bug 28177] Add date column and column configuration to uploads -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28177] New: Add date column and column configuration to uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 Bug ID: 28177 Summary: Add date column and column configuration to uploads Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 28175 I think it would be useful to add a date column to the table showing uploaded files. Adding column configuration at the same time will let us hide the column by default. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 [Bug 28175] Usability improvements to uploads page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 --- Comment #1 from Kyle M Hall --- Created attachment 119908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119908=edit Bug 28176: Transfer not created for items returning home if confirmed with "Yes, print slip" button If an items is to be transferred home after being checked out at a different branch, the "Yes, print slip" button does not generate the transfer, but the "Yes" button does. Test Plan: 1) Set AutomaticItemReturn to "Don't" 2) Place a hold for pickup at a different branch 3) Check in the item, confirm the hold and transfer 4) Check in the item at the pickup branch 5) Check the item out to the patron 6) Check the item in at the pickup branch 7) Confirm the transfer back to the home library with the "Yes, print slip" button 8) Check the branchtransfers table, not there is not open transfer 9) Apply this patch, repeat steps 1-8 10) Note the branch transfer was created! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] New: Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Bug ID: 28176 Summary: Transfer not created for items returning home if confirmed with "Yes, print slip" button Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If an items is to be transferred home after being checked out at a different branch, the "Yes, print slip" button does not generate the transfer, but the "Yes" button does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 --- Comment #1 from Owen Leonard --- Created attachment 119907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119907=edit Bug 28175: Usability improvements to uploads page This patch makes a variety of changes to the uploads page in order to improve usability: - Add a toolbar with an "Upload" button so that it can be accessed from the upload results or search results views - On views other than the "main" view, add search forms to the sidebar - The search form markup has been modified somewhat in order to make it work well in both the sidebar and the main body of the page. - Show the upload category description instead of the code - Link the upload category in search results to a search for that category The "enctype" attribute has been removed from the search forms because it is unnecessary and causes form resubmission errors in some browsers (Firefox at least). To test, apply the patch and make sure you have at least one entry under Authorized values for the category UPLOAD. - Go to Tools -> Upload. - Upload a file, adding a category as you do so. - On the upload results page, test that the "Upload file" button returns you to the main upload page. - On the upload results or search results view, confirm that the "Search uploads by category" and "Search uploads by name" forms work correctly. - When viewing upload or search results, confirm that the category discription is shown instead of the code. Confirm that the category is a link to a search for other files in that category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
--- Comment #37 from Mason James ---
(In reply to Bohdan from comment #36)
> Hello. I've installed Koha 20.11.04 on latest Debian 10 and the API is
> broken. I cannot get the list of available branches as it uses API.
>
> Got the following in api error logs:
> [ERROR] Warning: Could not load REST API spec bundle: Can't use string
> ("parameters.json") as a HASH ref while "strict refs" in use at
> /usr/share/perl5/JSON/Validator/OpenAPI/Mojolicious.pm line 272.
hi Bohdan,
are you using 64-bit debian? it is recommended
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28170] Downloading some files via Tools - Upload is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Owen Leonard changed: What|Removed |Added Blocks||28175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 [Bug 28175] Usability improvements to uploads page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] New: Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Bug ID: 28175 Summary: Usability improvements to uploads page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 28170 I propose a few changes to the uploads page to make it easier to work with: - Add a toolbar with an "Upload" button so that it can be accessed from the upload results or search results views - On views other than the "main" view, add search forms to the sidebar - Show the upload category description instead of the code - Link the upload category in search results to a search for that category Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 [Bug 28170] Downloading some files via Tools - Upload is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Attachment #119398|0 |1 is obsolete|| --- Comment #20 from Owen Leonard --- Created attachment 119906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119906=edit Bug 27594: (follow-up) Check for secure context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #19 from Owen Leonard --- (In reply to Owen Leonard from comment #18) > If anyone is able to test this I'd appreciate it. Never mind, something is still broken... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #18 from Owen Leonard --- I was hoping to test this last followup on a sandbox, but the PTFS-E sandboxes don't appear to accept uploads, and the ByWater sandboxes have been down for ages. I don't know how else to test this in an environment that isn't considered by the browser to be secure for the purposes of copy and paste operations (as local addresses are). If anyone is able to test this I'd appreciate it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
