[Koha-bugs] [Bug 28245] Language dropdown in advanced search should be sorted

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28245

--- Comment #1 from David Cook  ---
(In reply to David Cook from comment #0)
> I'm not sure what to do about non-alphabetic languages like Chinese that
> don't do alphabetic sorting...

From what I've seen, Chinese just gets sorted by byte order.

I tried Unicode::Collate::Locale->new(locale => 'zh__pinyin'), but that didn't
work. 

So no idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28245] New: Language dropdown in advanced search should be sorted

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28245

Bug ID: 28245
   Summary: Language dropdown in advanced search should be sorted
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

The Language dropdown in the advanced search should be sorted. It should be
sorted according to the locale of the user. 

For instance, sorting by iso 629-2 codes favours English. Take for example
"German". The code is "ger" and in English it's "German" but in French it's
"Allemand", and in German it's "Deutsch". The alphabetical sort should be done
to align with the expectations of the language of the user/interface.

I'm not sure what to do about non-alphabetic languages like Chinese that don't
do alphabetic sorting...

Also, this is neat https://perldoc.perl.org/Unicode::Collate::Locale. A core
module which adds support for locales. That said, sort for French is weird. The
first is normal sort() and the second is Unicode::Collate::Locale sort.

$VAR1 = [
  'a',
  'e',
  'ç',
  'é',
  'ï'
];
$VAR1 = [
  'a',
  'ç',
  'ï',
  'é',
  'e'
];

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

--- Comment #103 from David Cook  ---
(In reply to David Cook from comment #102)
> Note that Chinese sorts using radical and stroke count. So English, French,
> and Chinese would be sorted as '中文','法文','英文' (Chinese, French, English
> respectively). 
> 
> That doesn't correspond to the more western-centric language codes.

Then again maybe it is just doing a byte order sort...

中 = e4b8ad
法 = e6b395
英 = e88bb1

So I guess that theory is out the window. I think users without alphabets just
suffer with Koha?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27246] Remove apache only code from C4::Context BEGIN

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27246

--- Comment #4 from David Cook  ---
Thumbs up for removing all that stuff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28244] Ukrainian is misspelled in language tables for English

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28244

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28244] Ukrainian is misspelled in language tables for English

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28244

--- Comment #2 from David Cook  ---
Created attachment 120251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120251=edit
Bug 28244: Fix typo in Ukrainian in language tables in English

This changes the English of Ukranian to Ukrainian.

1) Apply patch
2) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl
3) Click on "Language" drop-down
4) Note near the bottom it says "Ukrainian" instead of "Ukranian"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28244] Ukrainian is misspelled in language tables for English

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28244

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28244] Ukrainian is misspelled in language tables for English

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28244

David Cook  changed:

   What|Removed |Added

Summary|Ukrainian is misspelled in  |Ukrainian is misspelled in
   |language tables |language tables for English

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28244] Ukrainian is misspelled in language tables

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28244

--- Comment #1 from David Cook  ---
In installer/data/mysql/mandatory/subtag_registry.sql, it should be Ukrainian
and not Ukranian for English.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28244] New: Ukrainian is misspelled in language tables

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28244

Bug ID: 28244
   Summary: Ukrainian is misspelled in language tables
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27246] Remove apache only code from C4::Context BEGIN

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27246

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #3 from Victor Grousset/tuxayo  ---
Not worth a signoff but here is some random testing:

applied patch
restarted services (in koha-testing-docker)
ran the GUI tests: prove -r t/db_dependent/selenium/
went to OPAC
went to staff interface
did a checkout, showed it in the patrons page (to test the related API call)

restarted koha-testing-docker to see an eventual difference compared to 
applying when already started

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Blocks||28243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243
[Bug 28243] Accessibility: Staff Client - add captions/legends/labels to
elements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Blocks||28243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243
[Bug 28243] Accessibility: Staff Client - add captions/legends/labels to
elements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Blocks||28243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243
[Bug 28243] Accessibility: Staff Client - add captions/legends/labels to
elements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Depends on||27631, 27741, 27877


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
[Bug 27631] Accessibility: Staff Client -  on each page is Logo but should
be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741
[Bug 27741] Accessibility: Staff Client - Headings should have correct tags and
hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877
[Bug 27877] Accessibility: Staff Client - Reduce heading redundancy
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n
   |ity.org |et.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Blocks||28242


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242
[Bug 28242] Accessibility: OPAC - add captions/legends/labels to elements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Blocks||28242


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242
[Bug 28242] Accessibility: OPAC - add captions/legends/labels to elements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Depends on||27610, 27740, 27876


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610
[Bug 27610] Accessibility: OPAC -  on each page is Logo but should be page
description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740
[Bug 27740] Accessibility: OPAC - Headings should have correct tags and
hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876
[Bug 27876] Accessibility: OPAC - Reduce heading redundancy
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Blocks||28242


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242
[Bug 28242] Accessibility: OPAC - add captions/legends/labels to elements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |wainuiwitikapark@catalyst.n
   ||et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876

--- Comment #17 from wainuiwitikap...@catalyst.net.nz ---
(In reply to Henry Bolshaw from comment #15)

> Wainui, are you going to create a separate bug for table captions? Let me
> know if you weren't and I'll submit one.

Please see Bug 28242 and Bug 28243 for dealing with table captions as well as
other elements that need labels/legends. It will be useful for many of these to
be "sr-only" so that they don't interfere with other headings and don't create
redundancy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

--- Comment #102 from David Cook  ---
Note that Chinese sorts using radical and stroke count. So English, French, and
Chinese would be sorted as '中文','法文','英文' (Chinese, French, English
respectively). 

That doesn't correspond to the more western-centric language codes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28243] New: Accessibility: Staff Client - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243

Bug ID: 28243
   Summary: Accessibility: Staff Client - add
captions/legends/labels to elements
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wainuiwitikap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Many of the tables, forms and other elements do not have a caption, legend or
label. This is not accessible and makes it hard for navigation when using a
screen-reader. However, adding these things to elements can create redundancy
and appear unnecessary.

Therefore, it would be beneficial for these captions/legends/labels to be in
the class "sr-only" so that they are not visible, they are just available for
those who use screen readers.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

--- Comment #101 from David Cook  ---
Comment on attachment 40288
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40288
Bug 12017: 4 - Change language changers

Review of attachment 40288:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12017=40288)
-

::: koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc
@@ +5,4 @@
>  
>  
>  
> +[% FOREACH languages_loo IN languages_loop.sort('rfc4646_subtag') %]

It seems to me the ideal way would be to sort by the user's chosen language.

That said, I'm not sure that translated names are always provided, so maybe a
system preference for ordering language makes sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] New: Accessibility: OPAC - add captions/legends/labels to elements

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

Bug ID: 28242
   Summary: Accessibility: OPAC - add captions/legends/labels to
elements
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: wainuiwitikap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Many of the tables, forms and other elements do not have a caption, legend or
label. This is not accessible and makes it hard for navigation when using a
screen-reader. However, adding these things to elements can create redundancy
and appear unnecessary.

Therefore, it would be beneficial for these captions/legends/labels to be in
the class "sr-only" so that they are not visible, they are just available for
those who use screen readers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0.

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

--- Comment #10 from Victor Grousset/tuxayo  ---
Both patches do what they advertise. Including the difference on step 7 (I
missed it the first when testing)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0.

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #120052|0   |1
is obsolete||

--- Comment #9 from Victor Grousset/tuxayo  ---
Created attachment 120250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120250=edit
Bug 27203: [alternate] Calculate tax based on ecost if unitprice not set

There is code in populate_order_with_prices that is intended to use ecost over
unitprice,
it just doens't seem to be working.

Making it more explicit seems to take care of the issue.

To test:
1 - Create a basket
2 - Add an order line, don't set 'Actual cost: ', but use vendor price
and a discount.
3 - Save
4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set.
5 - Apply batch
6 - Redo 1,2, 3
7 - Display all columns, GST is calculated correctly, unitprice remains 0.

Signed-off-by: Marjorie 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0.

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #120051|0   |1
is obsolete||

--- Comment #8 from Victor Grousset/tuxayo  ---
Created attachment 120249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120249=edit
Bug 27203: (Bug 23294 follow up) set unitprice to ecost if it's 0.

Test plan:
1 - Create a basket
2 - Add an order line, don't set 'Actual cost: ', but use vendor price
and a discount.
3 - Save
4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set.
5 - Apply batch
6 - Redo 1,2, 3
7 - Display all columns, pre 23294 behaviour is back columns are set.

Signed-off-by: Marjorie 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0.

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

--- Comment #7 from Victor Grousset/tuxayo  ---
Wait, IIUC sandboxes don't allow to apply only one patch. Retest results
coming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0.

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #6 from Victor Grousset/tuxayo  ---
Looks signed-off

Should the choice between the two alternatives be done now? Or is it for QA to
make it?
Maybe there was talk about this ticket elsewhere?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28217] Several non-repeatable attributes when merging patrons

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217

--- Comment #3 from Victor Grousset/tuxayo  ---
Works great, message quite clear :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876

--- Comment #16 from wainuiwitikap...@catalyst.net.nz ---
(In reply to Henry Bolshaw from comment #15)
> This is great. I have followed the test plans and signed off. I also checked
> the pages using the NVDA screenreader: the change on the tags page makes the
> table much easier to understand!
> 
> Wainui, are you going to create a separate bug for table captions? Let me
> know if you weren't and I'll submit one.

Hi Henry, thanks so much! Yeah I can submit a bug for that :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28217] Several non-repeatable attributes when merging patrons

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28217] Several non-repeatable attributes when merging patrons

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #120165|0   |1
is obsolete||

--- Comment #2 from Victor Grousset/tuxayo  ---
Created attachment 120248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120248=edit
Bug 28217: Prevent several non-repeatable attributes to be merged

When using the patron merge feature it's possible to generate a patron
with several non-repeatable attributes.

This patch prevents that.

Test plan:
Create 2 patron attribute types, one repeatable and one non-repeatable
Create 2 patrons and add them repeatable attributes
Add a non-repeatable attribute to one of them
Merge the 2 patrons
=> It succeeds, the resulting patron has all the repeatable attribute
and the non-repeatable one.

Do it again but this time add non-repeatable to both patrons
Merge them
=> It fails, you should see an error on the UI
  Merge failed! The following error was reported: Tried to add more than one
non-repeatable attributes. type=TYPE value=VALUE.

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #5 from Henry Bolshaw  ---
Thanks Alex, this is a real improvement! I followed the test plan and
everything worked as you said it would.

Option to Remove items from list?
---
This patch allows other library staff to add items to the list but it doesn't
give them the ability to remove items. Is this functionality you are planning
to add as a subsequent patch or do you see that as a separate bug? Without the
ability to remove items, the interface is slightly confusing because both the
OPAC and staff interface still give library staff the option to remove items -
but if they try then there's an error, "no record was removed".


Update Edit list hint message
---
On the staff interface when creating or editing a list, if you select "Allow
changes to contents from: Staff Only" while the category is still private, you
get this hint: "The Anyone permission has no actual effect while this list is
strictly private." Can you tweak this to reflect the new staff permission
options?

No staff only option in OPAC
-
The staff only option doesn't appear in the OPAC, so if the list owner edits a
list from the OPAC - e.g. to edit the name - the list permissions will change.
I don't know if this is easily fixable because you wouldn't want the staff only
option appearing for all users but I thought I'd mention it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #52 from Aleisha Amohia  ---
(In reply to Martin Renvoize from comment #51)
> Sorry Aliesha, I didn't spot this one in the tree... else I'd have tried to
> fold it into the now pushed bug 26734.. it was only upon going to update the
> wiki pages at Katrins request I saw a link to this bug.
> 
> Would you like me to have a go at rebasing for you or are you OK to take a
> look.. it appears that it stopped applying prior to my patch but I feel a
> bit guilty having made it even harder.

No worries. Yes please if you can try rebasing that would be awesome, I'm not
sure when I'll have time to revisit this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28241] OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241

--- Comment #1 from Lucas Gass  ---
Created attachment 120247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120247=edit
Bug 28241: Fix regex to allow for content before and after comma

1. Set up the OPACNoResultsFound with the {QUERY_KW} placeholder.
2.Do a search with a comma that will return no results. Like "King, Martin
Luther". If the returns results add some additional characters to the search
until no results are returns.
3. Look at the #noresultsfound HTML element. Anything before (or after) the
comma is omitted. So the placeholder looks something like 'Martin Luther'
instead of 'King, Martin Luther'.
4. Apply patch
5. Try the search again, you should see the content before and after a comma

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28241] OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28241] OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |trivial
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28241] OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28241] New: OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241

Bug ID: 28241
   Summary: OPACNoResultsFound {QUERY_KW} placeholder doesn't
always match the search terms when commas are included
in the search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The OPACNoResultsFound sys pref allows for the  use of a the {QUERY_KW}
placeholder but it doesn't always work right when commas are used in the search
string. 

To recreate:

Set up the OPACNoResultsFound with the {QUERY_KW} placeholder.

Do a search with a comma that will return no results. Like "King, Martin
Luther". If the returns results add some additional characters to the search
until no results are returns. 

Look at the #noresultsfound HTML element. Anything before (or after) the comma
is omitted. So the placeholder looks something like 'Martin Luther' instead of
'King, Martin Luther'.


The regular expression in opac-search.pl can be tweaked to allow the content
before or after commas to display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28240] Some classes in register.tt are translatable

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28240

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 120246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120246=edit
Screenshot of register.pl in French

See the "undefined" where the amount should be

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28240] Some classes in register.tt are translatable

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28240

--- Comment #1 from Caroline Cyr La Rose  ---
I noticed it also prevents the sum to be displayed... (see attached screenshot)
So it's VERY important to NOT translate that line. It's not just a question of
colours, but actual data...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28240] New: Some classes in register.tt are translatable

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28240

Bug ID: 28240
   Summary: Some classes in register.tt are translatable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Hiya!

I usually whine because things are not translatable, but today I will whine
because something is translatable. Hehe! 

I don't know if this is something that is meant to be this way or not, but the
classes for "debit" and "credit" in register.tt are translatable, which means
that, if translated, it prevents the colours from appearing. It's not the end
of the world, but I was surprised when I switched to English and saw the red
and green for debits and credits. 

To test:
1) Set up your system to use cash registers
(mine was already set up, so I'm doing this from memory)
  - In system preferences, enable UseCashRegisters
  - In Administration > Cash registers, set up a cash register
  - In Administration > Authorized values > PAYMENT_TYPE, add some payment
types
2) Make some transactions
  - In a patron's file add some manual fees
  - Pay some fees, write off some others
3) Go to Tools > Cashup registers 
4) Click on the register name <-- Notice debits are red and credits are green
5) Install a new language
(again, mine was already installed, so doing this from memory)
  - In the terminal, go to misc/translator
  - gulp po:update
  - ./translate install xx-XX
6) Translate the line that looks like
"{ \"type\": \"credit\", \"identifier\": \"%s\", \"description\": \"%s "
"(%s)\", \"amount\": \"%s\" }"
Remove the "fuzzy" line if needed
7) Update your translation
  - ./translate install xx-XX
8) Go back to Koha, change the language
9) Go to Tools > Cashup registers 
10) Click on the register name <-- Notice credits are black

Again, it's not the end of the world, we'll just have to tell translators not
to translate those lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567

--- Comment #20 from Victor Grousset/tuxayo  ---
@Martin is that actually needed for 19.11.x?

 1 - Have Koha using ES
 2 - Search for:
ti:chess AND chess
 3 - You should get a result in sample data, otherwise replace 'chess' with
a title in your catalogue
 4 - Search for:
ti:chess AND kw:chess
 5 - No result

I actually have results.
19.11.17, koha-testing-docker, marc21, ES enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797

--- Comment #19 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #17)
> Then maybe it should be part of Can*BeReserved return.

We faced this with the API and pickup locations: we really need a way to notify
the caller that * can be reserved, but because we are overriding X situation
because AllowHoldsPolicyOverride is enabled and we have permissions, etc...

As I said in a previous comment, I see us adding

Koha::{Biblio|Item}->add_hold

and probably rely on Koha::Object::Message to pass this information to the
controllers/callers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864

--- Comment #23 from Tomás Cohen Arazi  ---
Thank you, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567

--- Comment #19 from Victor Grousset/tuxayo  ---
Should the patch "Use dollar sign to refer to captures" be pushed to master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864

--- Comment #22 from Nick Clemens  ---
Created attachment 120245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120245=edit
Bug 27864: (QA follow-up) Remove size=1 on selects (28066 follow-up)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864

--- Comment #21 from Nick Clemens  ---
Created attachment 120244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120244=edit
Bug 27864: Correct dropdown size

This patch makes the dropdown width inherit the existing style.

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864

Nick Clemens  changed:

   What|Removed |Added

 Attachment #120014|0   |1
is obsolete||
 Attachment #120015|0   |1
is obsolete||
 Attachment #120170|0   |1
is obsolete||

--- Comment #20 from Nick Clemens  ---
Created attachment 120243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120243=edit
Bug 27864: Visual feedback on overridden pickup locations when placing hold

This patch makes the form for placing a hold, use the API to retrieve
the valid pickup locations for a biblio.

To test:
1 - In Circulation and fines rules > Default checkout, hold and return policy,
change 'Hold pickup library match' to 'item's home library'
2 - Set AllowHoldPolicyOverride system preference to Allow
3 - Try placing a hold on a biblio with several items.
Ensure that there is one item with homebranch of the patrons branch and
one at another branch
4 - Note the pickup location dropdown lists all branches, even those not
matching the policy (Item's home library)
5 - FAIL: There's no sign they are overrides to rules
6 - Apply the patch
7 - Repeat 3
8 - SUCCESS: Same behavior as before all libraires listed, but there's a sign
+ tooltip for overridden ones.
9 - Sign off :-D

Note: styling follow-up coming

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16994] Import and export MARC modification templates

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16994

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #4 from Barbara Johnson  ---
I just had an instance where being able to export and import a MARC
Modification template would have been helpful.  We'd love to have this
functionality.  And being able to discover templates from other libraries would
be great.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0.

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28239] New: Include the ability to add Course Reserve information to labels

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28239

Bug ID: 28239
   Summary: Include the ability to add Course Reserve information
to labels
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

An academic library would to be able to print labels in the label creator that
include course reserve information and currently this is not possible.

For example, this library would like to print labels for items that are on the
course which include the ability of printing course #, department, section,
etc- would be ideal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

--- Comment #12 from Martin Renvoize  ---
This applies nicely again now as is :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #102 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #100)
> (In reply to Katrin Fischer from comment #99)
> > And it would be great to have some documentation for the new
> > templates/changes to look out for. I think these are the wiki pages, that
> > could be good to add to:
> > 
> > https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit
> > (especially last section)
> > 
> > And here:
> > https://wiki.koha-community.org/wiki/
> > Notices_and_Slips_Library#Notices_and_slips_using_template_toolkit
> 
> Martin, can you deal with that please? Adding the "additional_work_needed",
> remove it when done.

All done :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Koha Team University Lyon 3  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Koha Team University Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #1 from Koha Team University Lyon 3  ---
Created attachment 120242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120242=edit
Add itemcallnumber to ilsdi GetAvailability output

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #51 from Martin Renvoize  ---
Sorry Aliesha, I didn't spot this one in the tree... else I'd have tried to
fold it into the now pushed bug 26734.. it was only upon going to update the
wiki pages at Katrins request I saw a link to this bug.

Would you like me to have a go at rebasing for you or are you OK to take a
look.. it appears that it stopped applying prior to my patch but I feel a bit
guilty having made it even harder.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] New: Add itemcallnumber to ils-di GetAvailability output

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

Bug ID: 28238
   Summary: Add itemcallnumber to ils-di GetAvailability output
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@univ-lyon3.fr
QA Contact: testo...@bugs.koha-community.org

Many libraries use discover tools as front-end to their resources.
These tools are not dealing very well with item specific data such as
itemcallnumber. In any case, that's what we observe with Summon, Ex-libris tool
wich is not able to map different items with different itemcallnumbers.
That problem can have a solution through GetAvailability method.

After checking availability and getting the location of the document, patrons
often don't go further in their search.
When they arrived on the site they are missing only one data : the
itemcallnumber.
That would be perfect to add it to the method and so give all minimal but
sufficient data to find the document on the place.

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||This patch changes the
  release notes||pickup location dropdown,
   ||when placing biblio-level
   ||holds, so it renders a
   ||sign, alerting that
   ||circulation rules would be
   ||overridden if the pickup
   ||location is chosen.
   ||
   ||It
   ||relies on new API routes.
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25885] Wait for OverDrive results before redirecting to single Koha result

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885

--- Comment #4 from Christopher Brannon  ---
Well, there we have it.  A great reason for a separate pref.  :)  Thanks for
that.  I'm on board with a separate pref then.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864

--- Comment #19 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #18)
> Please provide a full test plan, I don't see the visual feedback.
> 
> > => FAIL: There's no sign they are overrides to rules
> 
> I don't understand what this means.

Without the patch, you have a dropdown with the pickup_location=1 branches.
With the patch, you have the same [1], but there's a visual sign indicating
that choosing some of the pickup locations implies an override to rules.

This is affected by circulation rules, so you need to make sure the item
homebranch, the patron branch, and the rules make some of the pickup locations
invalid (and thus require AllowHoldsPolicyOverride to be picked).

[1] The same, but using Select2 and API routes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 120241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120241=edit
Bug 27842: (follow-up) Correct existing serail/subscriptionhistory before
deletion

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

--- Comment #27 from Tomás Cohen Arazi  ---
Created attachment 120240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120240=edit
Bug 27842: Update serial.biblionumber when a subscription is linked with
another record

It seems that a librarian can edit the biblionumber for a given subscription,
however, when receiving serials the biblionumber is pulled from the existing
serials, so all new received issues are received on the old biblionumber.

This is problematic in light of bug 21901 - you can change the biblionumber,
the serials still point to the old biblionumber - and deleting the biblio
deletes the serials. Additionally, the update will delete serials where this
was the case

Test plan:
1 - Create a new subscription
2 - Receive an issue
3 - Edit the subscription and change the biblionumber
4 - Receive another issue
5 - SELECT biblionumber FROM serial
=> the biblionumber link must have been updated

Signed-off-by: Petro Vashchuk 

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 120239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120239=edit
Bug 27842: Add tests

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117698|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117697|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117712|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|tomasco...@gmail.com
 CC||tomasco...@gmail.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28198] Sample notices SQL fails on HOLD_REMINDER: Column count doesn't match value count

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_05_candidate |
 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

--- Comment #6 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28198] Sample notices SQL fails on HOLD_REMINDER: Column count doesn't match value count

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28198] Sample notices SQL fails on HOLD_REMINDER: Column count doesn't match value count

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28198

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28223] Total for budgets is incorrect when child funds have negative values

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28223

--- Comment #5 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28223] Total for budgets is incorrect when child funds have negative values

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28223

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28221] Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28221

--- Comment #4 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28221] Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28221

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28193] OpacLoginInstructions news block broken by Bug 20168

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193

--- Comment #10 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28193] OpacLoginInstructions news block broken by Bug 20168

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28178] Image viewer does not select the correct image

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178

--- Comment #4 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28178] Image viewer does not select the correct image

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] Historical OVERDUE fines may not have an issue_id

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

--- Comment #5 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28144] Historical OVERDUE fines may not have an issue_id

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28144

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27995] Koha::Account::Line->apply should return the update Koha::Account::Line object

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27995

--- Comment #21 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27995] Koha::Account::Line->apply should return the update Koha::Account::Line object

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27995

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27790] Possibility to filter Holds to pull list using pickup place

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27790

--- Comment #6 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27790] Possibility to filter Holds to pull list using pickup place

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27790

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27636] Replace Koha::Account::pay with a simpler method

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636

--- Comment #22 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27636] Replace Koha::Account::pay with a simpler method

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986

--- Comment #73 from Jonathan Druart  ---
Follow-up pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27455] Add focus to branch code when a new library is added

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27455

--- Comment #17 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27455] Add focus to branch code when a new library is added

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27455

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734

--- Comment #101 from Jonathan Druart  ---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter

2021-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >