[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |dc...@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120572|0 |1 is obsolete|| --- Comment #51 from David Cook --- Created attachment 120580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120580=edit Bug 21249: (follow-up) Adding parentheses to fix query Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120571|0 |1 is obsolete|| --- Comment #50 from David Cook --- Created attachment 120579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120579=edit Bug 21249: (follow-up) Implement SearchLibraryLimit for individual library before this patch, the limit only applies to groups of libraries Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120570|0 |1 is obsolete|| --- Comment #49 from David Cook --- Created attachment 120578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120578=edit Bug 21249: (follow-up) Fixing syspref name, description, get working with OPAC masthead search Syspref is now called SearchLimitLibrary, and the description better explains what the feature does. It works with the advanced search on the staff client and OPAC, and the masthead search on the OPAC when OpacAddMastheadLibraryPulldown is enabled. Sponsored-by: Catalyst IT Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120569|0 |1 is obsolete|| --- Comment #48 from David Cook --- Created attachment 120577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120577=edit Bug 21249: Code cleaning Trying to make the code a bit more readable removing unecessary variables and parenthesis. Code is duplicated but no idea where we could move it to. Signed-off-by: Jonathan Druart Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120568|0 |1 is obsolete|| --- Comment #47 from David Cook --- Created attachment 120576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120576=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library, Australia Signed-off-by: Amandine Zocca Signed-off-by: Jonathan Druart Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120567|0 |1 is obsolete|| --- Comment #46 from David Cook --- Created attachment 120575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120575=edit Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search This commit allows librarians to choose whether they want to query the homebranch, holdingbranch or homebranch AND holdingbranch when they set a library or library group search condition in the staff client and OPAC advanced searches. Test plan: 1. Apply patches, update database, restart services 2. Set up a record with one item. Edit the item so that: home branch = Branch A holding/current branch = Branch B. Note the barcode of your item. 3. Go to Administration -> Library Groups. Create a library group that only contains Branch A. = homebranch and holdingbranch = 4. Go to Administration -> System preferences and find the new SearchLimitLibrary syspref. Confirm it is set to 'homebranch and holdingbranch' by default. Keep this tab open. 5. Go to Advanced Search in the staff client in another tab. Under 'location and availability', select your library group from the dropdown. Under 'search for', select the barcode option and enter your item's barcode. 6. Submit the search and confirm you are taken to your item as expected. 7. Go back to Advanced Search. Under 'location and availability', select Branch A from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 8. Submit the search and confirm you are taken to your item as expected. 9. Go back to Advanced Search. Under 'location and availability', select Branch B from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 10. Submit the search and confirm you are taken to your item as expected. = homebranch only = 11. Go back to your System preferences tab. Set the SearchLimitLibrary syspref to 'homebranch'. keep this tab open. 12. Go to Advanced Search in the staff client in another tab. Under 'location and availability', select your library group from the dropdown. Under 'search for', select the barcode option and enter your item's barcode. 13. Submit the search and confirm you are taken to your item as expected, because the syspref is set to homebranch and the library group contains our item's homebranch. 14. Go back to Advanced Search. Under 'location and availability', select Branch A from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 15. Submit the search and confirm you are taken to your item as expected. 16. Go back to Advanced Search. Under 'location and availability', select Branch B from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 17. Submit the search and confirm you are NOT taken to your item and your item does not show in the search results. = holdingbranch only = 18. Go back to your System preferences tab. Set the SearchLimitLibrary syspref to 'holdingbranch'. keep this tab open. 19. Go to Advanced Search in the staff client in another tab. Under 'location and availability', select your library group from the dropdown. Under 'search for', select the barcode option and enter your item's barcode. 20. Submit the search and confirm you are NOT taken to your item and your item does not show in the search results, because the syspref is set to holdingbranch and the library group does not contain our item's holdingbranch. 21. Go back to Advanced Search. Under 'location and availability', select Branch B from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 22. Submit the search and confirm you are taken to your item as expected. 23. Go back to Advanced Search. Under 'location and availability', select Branch A from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 24. Submit the search and confirm you are NOT taken to your item and your item does not show in the search results. 25. Repeat the above test plan but do your searching with the OPAC advanced search. Sponsored-By: Brimbank Library Signed-off-by: Amandine Zocca Signed-off-by: Jonathan Druart Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #45 from David Cook --- I am getting 1 fail in the QA tools but it seems minor to me. I'm leaving it to the RM to squash if necessary. -- root@kohadevbox:koha(bug_21249)$ qa testing 6 commit(s) (applied to 640ba47 'cf Bug 28288: Prevent XSISBN.t to fai') Processing files before patches |>| 4 / 4 (100.00%) Processing files after patches |>| 4 / 4 (100.00%) OK catalogue/search.pl FAIL installer/data/mysql/atomicupdate/bug_21249-Branch_to_limit_advanced_search_results.sql FAIL git manipulation The file has been added and deleted in the same patchset OK installer/data/mysql/mandatory/sysprefs.sql OK opac/opac-search.pl Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #22 from Aleisha Amohia --- I'm stuck on that JS error, and it looks like the internal note and vendor note also no longer open in pop up windows. Any thoughts on the datatables error? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #254 from David Cook --- Going to set this back to "Needs Signoff" so it's clearer that someone other than me should test it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- Andreas, Sadly, this patch no longer applies cleanly to master. Is there any chance for a rebase? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel display of new titles on OPAC home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #312 from Aleisha Amohia --- Created attachment 120574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120574=edit Bug 15516: (follow-up) Fixes for qa tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 --- Comment #1 from Lucas Gass --- Created attachment 120573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120573=edit Bug 28229: Only show clubs on request.tt if clubs exist 1. Have no existing clubs 2. Apply patch 3. Go to request.tt and you will not see the club tab or any mention of clubs 4. Create at least 1 club 5. Go back to request.tt and now see the tab for clubs 6. Make sure you can place holds as an individual with and without clubs. 7. Make sure you can place holds for clubs. 8. rejoice and sign-off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #44 from Victor Grousset/tuxayo --- It works! :D Oops forgot to edit the test plan. Testing note: > 3. Go to Administration -> Library Groups. Create a library group that > only contains Branch A. Tick the checkbox to have it visible in staff and OPAC adv search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117223|0 |1 is obsolete|| --- Comment #41 from Victor Grousset/tuxayo --- Created attachment 120570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120570=edit Bug 21249: (follow-up) Fixing syspref name, description, get working with OPAC masthead search Syspref is now called SearchLimitLibrary, and the description better explains what the feature does. It works with the advanced search on the staff client and OPAC, and the masthead search on the OPAC when OpacAddMastheadLibraryPulldown is enabled. Sponsored-by: Catalyst IT Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120481|0 |1 is obsolete|| --- Comment #43 from Victor Grousset/tuxayo --- Created attachment 120572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120572=edit Bug 21249: (follow-up) Adding parentheses to fix query Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117224|0 |1 is obsolete|| --- Comment #42 from Victor Grousset/tuxayo --- Created attachment 120571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120571=edit Bug 21249: (follow-up) Implement SearchLibraryLimit for individual library before this patch, the limit only applies to groups of libraries Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117222|0 |1 is obsolete|| --- Comment #40 from Victor Grousset/tuxayo --- Created attachment 120569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120569=edit Bug 21249: Code cleaning Trying to make the code a bit more readable removing unecessary variables and parenthesis. Code is duplicated but no idea where we could move it to. Signed-off-by: Jonathan Druart Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117221|0 |1 is obsolete|| --- Comment #39 from Victor Grousset/tuxayo --- Created attachment 120568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120568=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library, Australia Signed-off-by: Amandine Zocca Signed-off-by: Jonathan Druart Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117220|0 |1 is obsolete|| --- Comment #38 from Victor Grousset/tuxayo --- Created attachment 120567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120567=edit Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search This commit allows librarians to choose whether they want to query the homebranch, holdingbranch or homebranch AND holdingbranch when they set a library or library group search condition in the staff client and OPAC advanced searches. Test plan: 1. Apply patches, update database, restart services 2. Set up a record with one item. Edit the item so that: home branch = Branch A holding/current branch = Branch B. Note the barcode of your item. 3. Go to Administration -> Library Groups. Create a library group that only contains Branch A. = homebranch and holdingbranch = 4. Go to Administration -> System preferences and find the new SearchLimitLibrary syspref. Confirm it is set to 'homebranch and holdingbranch' by default. Keep this tab open. 5. Go to Advanced Search in the staff client in another tab. Under 'location and availability', select your library group from the dropdown. Under 'search for', select the barcode option and enter your item's barcode. 6. Submit the search and confirm you are taken to your item as expected. 7. Go back to Advanced Search. Under 'location and availability', select Branch A from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 8. Submit the search and confirm you are taken to your item as expected. 9. Go back to Advanced Search. Under 'location and availability', select Branch B from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 10. Submit the search and confirm you are taken to your item as expected. = homebranch only = 11. Go back to your System preferences tab. Set the SearchLimitLibrary syspref to 'homebranch'. keep this tab open. 12. Go to Advanced Search in the staff client in another tab. Under 'location and availability', select your library group from the dropdown. Under 'search for', select the barcode option and enter your item's barcode. 13. Submit the search and confirm you are taken to your item as expected, because the syspref is set to homebranch and the library group contains our item's homebranch. 14. Go back to Advanced Search. Under 'location and availability', select Branch A from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 15. Submit the search and confirm you are taken to your item as expected. 16. Go back to Advanced Search. Under 'location and availability', select Branch B from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 17. Submit the search and confirm you are NOT taken to your item and your item does not show in the search results. = holdingbranch only = 18. Go back to your System preferences tab. Set the SearchLimitLibrary syspref to 'holdingbranch'. keep this tab open. 19. Go to Advanced Search in the staff client in another tab. Under 'location and availability', select your library group from the dropdown. Under 'search for', select the barcode option and enter your item's barcode. 20. Submit the search and confirm you are NOT taken to your item and your item does not show in the search results, because the syspref is set to holdingbranch and the library group does not contain our item's holdingbranch. 21. Go back to Advanced Search. Under 'location and availability', select Branch B from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 22. Submit the search and confirm you are taken to your item as expected. 23. Go back to Advanced Search. Under 'location and availability', select Branch A from the individual libraries dropdown. Under 'search for', select the barcode option and enter your item's barcode. 24. Submit the search and confirm you are NOT taken to your item and your item does not show in the search results. 25. Repeat the above test plan but do your searching with the OPAC advanced search. Sponsored-By: Brimbank Library Signed-off-by: Amandine Zocca Signed-off-by: Jonathan Druart Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git :
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #294 from Katrin Fischer --- Seeing the last status change - what happened? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #9 from Tomás Cohen Arazi --- Your patch changes the merge method so it raises an exception. That would be a good start. The caller doesn't wrap things in a try/catch block yet, but I'm wondering: shouldn't we do it all inside a transaction for each patron? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23215] Remove PayPal logic from Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28202] Pickup libraries not sorted by name when placing hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28202 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #13 from Nick Clemens --- *** Bug 26925 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #7 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 28202 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #32 from Nick Clemens --- (In reply to Katrin Fischer from comment #26) > (In reply to Jonathan Druart from comment #20) > > Can you explain this follow-up, Kyle? > > What's the use case, how did you find it? > > We certainly need a couple of tests to cover it. > > I read this as that we need 2 more unit tests that cover some more cases? > Setting to failed QA to alert Kyle. I added Unit tests, but neither the tests nor testing in the staff client pass - it seems the followup doesn't fix the issue. Can you look Kyle? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #31 from Nick Clemens --- Created attachment 120566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120566=edit Bug 27837: Permanent location to be empty string, check if key exists Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #30 from Nick Clemens --- Created attachment 120565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120565=edit Bug 27837: Unit tests for blank permanent location -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #29 from Nick Clemens --- Created attachment 120564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120564=edit Bug 27837: Prevent the tests to fail is the field is mapped Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #28 from Nick Clemens --- Created attachment 120563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120563=edit Bug 27837: Add unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rhonda Kuiper Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Nick Clemens changed: What|Removed |Added Attachment #120361|0 |1 is obsolete|| Attachment #120362|0 |1 is obsolete|| Attachment #120363|0 |1 is obsolete|| Attachment #120364|0 |1 is obsolete|| --- Comment #27 from Nick Clemens --- Created attachment 120562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120562=edit Bug 27837: Update permanent location if passed into ModItemFromMarc Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rhonda Kuiper Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 --- Comment #13 from Nick Clemens --- Created attachment 120561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120561=edit Bug 24154: Adjust assignment The code seems to work either way We have a mix in our code: git grep "}) %]" Using '=>' over '=' does look nicer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27577] Autolink bibs after generating the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27577 Nick Clemens changed: What|Removed |Added Attachment #116854|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 120560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120560=edit Bug 27577: Autolink biblio after biblionumber is generated If BiblioAddsAuthorities and AutoCreateAuthorities are enabled, a new record is auto linked when saving and authorities generated with a 670 field that indicates which record generated the new authority. The code to do this is called before the biblionumber is generated, so the variable that adds the biblionumber to the citation is empty This patch moves the linking code to after the biblionumber is generated To recreate: 1 - Enable BiblioAddsAuthorities and AutoCreateAuthorities 2 - Import or create a new record 3 - Ensure the record has controlled fields that do not have authorities before saving, i.e.: Add a 650 with "test_bug_27577_01" 4 - Search for the authority record 5 - Note the 670 field does not contain the biblionumber 6 - Apply patch, restart all the things 7 - Repeat 2-4 8 - Note the 670 now has the biblionumber Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27577] Autolink bibs after generating the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27577 --- Comment #6 from Nick Clemens --- Created attachment 120559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120559=edit Bug 27577: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27577] Autolink bibs after generating the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27577 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #47 from Katrin Fischer --- (In reply to Nick Clemens from comment #46) > Rebased, but I think we need an update here - the current patches rely on > _koha_notify_hold to send the message to the library. That routine is not > called when the hold is transferred, I think we need a unique subroutine for > that message that is called whenever the hold is changed, whether > transferred or waiting Thx Nick, also for noticing this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #6 from Katrin Fischer --- (In reply to David Cook from comment #4) > (In reply to Owen Leonard from comment #3) > > (In reply to David Cook from comment #2) > > > I feel like the non-XSLT view was deprecated just not removed? > > > > I don't understand what you're saying. > > Deprecated just means that it's not endorsed/recommended anymore but it is > still available in the system. The XSLT view has been the default and the > recommended view for quite a few years now. Even if we never explicitly said > it was deprecated it has been deprecated in practice. > > If you look at ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt, > there are about 152 lines of non-XSLT view. I think at this point that we > could safely remove those lines. We did officially deprecate it, check the coding guidelines: https://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-XSLT_search_results_and_bib_display_templates_deprecated The problems are features not implemented for the non-XSLT view that have been considered as blockers for final removal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi changed: What|Removed |Added Attachment #120432|0 |1 is obsolete|| --- Comment #35 from Tomás Cohen Arazi --- Created attachment 120558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120558=edit Bug 18989: Restore hidding items on detail Signed-off-by: Tomas Cohen Arazi Good catch. I forgot this file didn't get the hiding logic refactoring yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120556|0 |1 is obsolete|| --- Comment #293 from Martin Renvoize --- Created attachment 120557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120557=edit Bug 14957: (QA follow-up) Fix template indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #292 from Martin Renvoize --- Created attachment 120556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120556=edit Bug 14957: (QA follow-up) Fix template indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #291 from Martin Renvoize --- Created attachment 120555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120555=edit Bug 14957: (QA follow-up) Update for bug 27846 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #17 from Thomas Dukleth --- A much improved version of code and Koha Wiki files to test migrating the database and upgrading the wiki in a now much more manageable 123 MiB archive including automated support for copying wiki files to configured locations eliminating redundancy from the previous version is currently available at , https://test01.agogme.com/koha_migrate_mwiki_db_and_upgrade_test.tgz . The migration and update code is still a work in progress for having every both detail correct and known to be correct. Migration to a proper MediaWiki supported MySQL binary character encoding database runs without errors or warnings as it had at the end of 2019 but with some minor 2020 improvements and major 2021 improvements in managing database column types. The wiki upgrade code from 2021 works but the upgrade instance needs some evident configuration, etc. improvements to take advantage of features in the current MediaWiki version whether outdated content is maintained as a static archive or as a dynamic archive with mass tagging of outdated pages in the same wiki along with current pages with a distinct search query page for accessing old content as I am preparing to test. All changes from the previously posted version are improvements to automation and sharing in a useful manner. Improvements for the resulting migrated upgrade are forthcoming after some more changes improving automation of the installation. Anyone interested in testing would need to separately obtain a full dump of the Koha Wiki to avoid publicly compromising Koha Wiki usernames and passwords which are not contained in the published archive. Similarly as I should have mentioned previously, the issue of resetting wgSecretKey in LocalSettings.php could be avoided by obtaining a copy of the Koha Wiki LocalSettings.php . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #290 from Martin Renvoize --- I fixed the QA issues with follow-ups.. the only remaining ones flagged up are git manipulation errors (and some executable bit errors that are actually resolved by the manipulations anyway).. I did not squash commits as I didn't want to lose author attribution.. there's been a few people working on this one over the duration of its development life. I feel this is ready for push myself.. yes it has a few sharp edges and I'd love to see some of the templates indented more nicely for example.. if you agree I could do that indent fix at the least as a follow-up here. Hoping this could be one of the last ones for this release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #14 from Nick Clemens --- (In reply to Jonathan Druart from comment #11) > Nick, can you confirm your patch is independent from the first one? > > Tests are missing. They are independent, I obsoleted the first and added tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #289 from Martin Renvoize --- Created attachment 120554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120554=edit Bug 14957: (QA follow-up) Update for bug 17858 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #288 from Martin Renvoize --- Created attachment 120553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120553=edit Bug 14957: (QA follow-up) Update for bug 20053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #13 from Nick Clemens --- Created attachment 120552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120552=edit Bug 27203: [alternate] Calculate tax based on ecost if unitprice not set There is code in populate_order_with_prices that is intended to use ecost over unitprice, it just doens't seem to be working. Making it more explicit seems to take care of the issue. To test: 1 - Create a basket 2 - Add an order line, don't set 'Actual cost: ', but use vendor price and a discount. 3 - Save 4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set. 5 - Apply batch 6 - Redo 1,2, 3 7 - Display all columns, GST is calculated correctly, unitprice remains 0. Signed-off-by: Marjorie Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #287 from Martin Renvoize --- Created attachment 120550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120550=edit Bug 14957: (QA follow-up) Update for bug 20054 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Nick Clemens changed: What|Removed |Added Attachment #120249|0 |1 is obsolete|| Attachment #120250|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 120551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120551=edit Bug 27203: Adjust unit tests It seems the issue here is that the price passed in is a string, and not a number, so the tax value is not calculated when no unitprice is provided -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #286 from Martin Renvoize --- Created attachment 120548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120548=edit Bug 14957: (QA follow-up) Update for bug 26703 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #8 from Jonathan Druart --- Created attachment 120549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120549=edit Bug 28220: Deal with merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118946|0 |1 is obsolete|| --- Comment #283 from Martin Renvoize --- Created attachment 120545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120545=edit Bug 14957: (QA follow-up) Rename and move admin link This patch renames 'MARC overlay rules' to 'Record overlay rules' and moves it up the list to just below 'Record matching rules' to make it more contextually ordered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #285 from Martin Renvoize --- Created attachment 120547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120547=edit Bug 14957: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118945|0 |1 is obsolete|| --- Comment #282 from Martin Renvoize --- Created attachment 120544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120544=edit Bug 14957: (QA follow-up) Fix translation issues This patch fixes all the translation issues I could spot in the marc-overlay-rules template. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118957|0 |1 is obsolete|| --- Comment #284 from Martin Renvoize --- Created attachment 120546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120546=edit Bug 14957: (QA follow-up) Comment 'bulkmarcimport' temporarily It appears this patchset doesn't fully support bulkmarcimport (see bug 25539 for details). At this time, to get this bug moving I think we should comment out the ability to define rules that affect bulkmarcimport and then we can fix and re-enable that feature at a later date. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118944|0 |1 is obsolete|| --- Comment #281 from Martin Renvoize --- Created attachment 120543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120543=edit Bug 14957: (QA follow-up) Fix syntax error in atomicupdate Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118943|0 |1 is obsolete|| --- Comment #280 from Martin Renvoize --- Created attachment 120542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120542=edit Bug 14957: (QA follow-up) Clarify 'context' param This patch renames the (passed through) 'context' param for 'overlay_context'. I propose doing so, because in Koha-land 'context' has a special meaning, related to C4::Context and it reads ambigous. The patch itself is pretty trivial. Tests should pass: 1. Run: $ kshell k$ prove t/db_dependent/Biblio/MarcOverlayRules.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118942|0 |1 is obsolete|| --- Comment #279 from Martin Renvoize --- Created attachment 120541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120541=edit Bug 14957: (follow-up) marc_merge_rules_modules removed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118941|0 |1 is obsolete|| --- Comment #278 from Martin Renvoize --- Created attachment 120540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120540=edit Bug 14957: DBIC changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118940|0 |1 is obsolete|| --- Comment #277 from Martin Renvoize --- Created attachment 120539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120539=edit Bug 14957: Feature hidden in menues if no other 'cagaloguing' permissions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118936|0 |1 is obsolete|| --- Comment #273 from Martin Renvoize --- Created attachment 120535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120535=edit Bug 14957: fix context for batchmod and batchimport Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118939|0 |1 is obsolete|| --- Comment #276 from Martin Renvoize --- Created attachment 120538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120538=edit Bug 14957: (QA follow-up) Rename 'merge' => 'overlay' This patch acknowledges the fact that 'merging' has a different meaning in Koha than the behavior this great patchset introduces. The more idiomatic way of describing the behavior is to talk about 'overlay rules'. This patch also: - Fixes kohastructure.sql missing table encoding a collation - Fixes the atomic update completely missing a table - Moves the syspref entry to 'Importing', probably a rebase issue Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118938|0 |1 is obsolete|| --- Comment #275 from Martin Renvoize --- Created attachment 120537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120537=edit Bug 14957: (QA follow-up) Add tooltips This patch adds an info-tooltip to the field rules in the table header to expand on their meaning to reduce the need to read the documentation each time you come to use the configuration tool Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118935|0 |1 is obsolete|| --- Comment #272 from Martin Renvoize --- Created attachment 120534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120534=edit Bug 14957: Updated schema files Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118937|0 |1 is obsolete|| --- Comment #274 from Martin Renvoize --- Created attachment 120536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120536=edit Bug 14957: (QA follow-up) Button styling This patch updates the action buttons to include btn-default and switched from btn-sm to btn-xs to match other similar UI's found in datatable based admin pages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #118934|0 |1 is obsolete|| --- Comment #271 from Martin Renvoize --- Created attachment 120533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120533=edit Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 --- Comment #7 from Martin Renvoize --- I think the work here is a solid first step. Whilst I think I understand Phil's concerns, I think those should be addressed as their own bugs after this one... improving adherence of the advanced editor and adding defaults to bulk imports deserve a bug each. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28291] koha-translate install script producing incorrectly encoded YAML translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28291 Joonas Kylmälä changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Joonas Kylmälä --- Moving this to needs sign-off given there is a manual test plan and the LangInstaller module modified here is only used by misc/translator/translate perl script... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Bug 25439 depends on bug 27043, which changed state. Bug 27043 Summary: Add to number_of_replicas and number_of_shards to index config https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 What|Removed |Added Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Fridolin Somers changed: What|Removed |Added Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27623] Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #20 from Joonas Kylmälä --- I have now fix for that as well in bug 28291 but tests still missing... -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28291] koha-translate install script producing incorrectly encoded YAML translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28291 --- Comment #1 from Joonas Kylmälä --- Created attachment 120532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120532=edit Bug 28291: Make koha-translate script produce valid UTF-8 YAML files We had two problems in the LangInstaller.pm module: 1) the PO file was read as bytes instead of as a UTF-8 text stream 2) The YAML file being outputted was double encoded, once by setting the file handle to output UTF-8 and other time in the DumpFile function internally To test: 1. Before applying patch do the following $ cd misc/translator $ ./translate update pl-PL $ ./translate install pl-PL $ cd - $ less installer/data/mysql/pl-PL/marcflavour/marc21/mandatory/authorities_normal_marc21.yml 2. Notice the output of the authorities_normal_marc21.yml contains invalid looking UTF-8 characters 3. $ git clean -d -f # to remove the old translation files 4. Apply patch and repeat the steps and notice the authorities_normal_marc21.yml contains valid looking UTF-8 characters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117983|0 |1 is obsolete|| --- Comment #112 from Nick Clemens --- Created attachment 120531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120531=edit Bug 23260: (follow-up) Add anonymise_last_borrowers method to Patrons.pm This patch adds the method anonymise_last_borrowers in Patrons.pm. To test: 1) apply this patch and the previous ones 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/anonymise_last_borrowers.pl CHECK => borrower number in items_last_borrower is not anonymised yet. 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in items_last_borrower to three days eralier. 9) set AnonymiseLastBorrower to 'Anonymise' and AnonymiseLastBorrowerDays to 2 days. 10) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 11) repeat step 8 12) set AnonymousPatron preference to 0 13) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to null 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117982|0 |1 is obsolete|| --- Comment #111 from Nick Clemens --- Created attachment 120530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120530=edit Bug 23260: (follow-up) Add new cron job -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117981|0 |1 is obsolete|| --- Comment #110 from Nick Clemens --- Created attachment 120529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120529=edit Bug 23260: (follow-up) Update test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117980|0 |1 is obsolete|| --- Comment #109 from Nick Clemens --- Created attachment 120528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120528=edit Bug 23260: (follow-up) Add AnonymiseLastBorrower and AnonymiseLastBorrowerDays sysprefs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117979|0 |1 is obsolete|| --- Comment #108 from Nick Clemens --- Created attachment 120527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120527=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117978|0 |1 is obsolete|| --- Comment #107 from Nick Clemens --- Created attachment 120526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120526=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117977|0 |1 is obsolete|| --- Comment #106 from Nick Clemens --- Created attachment 120525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120525=edit Bug 23260: (follow-up) Remove last_borrower updates from issues count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117975|0 |1 is obsolete|| --- Comment #104 from Nick Clemens --- Created attachment 120523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120523=edit Bug 23260: Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 5 and 6 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117974|0 |1 is obsolete|| --- Comment #103 from Nick Clemens --- Created attachment 120522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120522=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Attachment #117976|0 |1 is obsolete|| --- Comment #105 from Nick Clemens --- Created attachment 120524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120524=edit Bug 23260: Simplify tests Use build_sample_item and build_object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
