[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28305] Remove doc reference to XML::Simple in C4::Context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28305] Remove doc reference to XML::Simple in C4::Context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 --- Comment #1 from David Cook --- Created attachment 120751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120751=edit Bug 28305: Remove doc reference to XML::Simple in C4::Context We don't need a See Also reference to XML::Simple in the C4::Context, especially since Bug 28278 replaced the parsing of koha-conf.xml with XML::LibXML. Test plan: 1. Apply patch 2. perldoc C4/Context.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28305] Remove doc reference to XML::Simple in C4::Context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28305] Remove doc reference to XML::Simple in C4::Context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 David Cook changed: What|Removed |Added Summary|Remove doc reference to |Remove doc reference to |XML::Simple in C4::Config |XML::Simple in C4::Context -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28305] Remove doc reference to XML::Simple in C4::Config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 David Cook changed: What|Removed |Added Depends on||28278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 David Cook changed: What|Removed |Added Blocks||28305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 [Bug 28305] Remove doc reference to XML::Simple in C4::Config -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28305] New: Remove doc reference to XML::Simple in C4::Config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 Bug ID: 28305 Summary: Remove doc reference to XML::Simple in C4::Config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Developer documentation Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org C4::Config doesn't need a doc reference to XML::Simple, especially not since Bug 28278 was pushed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #3 from David Cook --- https://bugs.launchpad.net/ubuntu/+source/libcgi-compile-perl/+bug/1927882 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- (In reply to Julian Maurice from comment #0) > Warning for Ubuntu Focal users: the packaged version of CGI::Compile is 0.24 Yikes... According to https://packages.ubuntu.com/search?keywords=libcgi-compile-perl=names, the only bad one is focal 20.04. I'll raise an issue with Ubuntu. I don't think forbidding CGI::Compile 0.24 is going to be practical for Koha users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #260 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #259) > Is that expected that Holds allowed (total) isn't taken into account? > my $lowestvalue = min( $maxreserves, $remaining_holds_for_record, > $remaining_holds_allowed_today ); Sounds like a bug to me. Aleisha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #325 from David Cook --- (In reply to David Cook from comment #324) > That's an interesting point. On one hand, you might want to limit the number > of group members. On the other hand, it doesn't make sense to count the > group as 1 hold but then also consider group members in terms of max > reserves. > > Aleisha: What are your thoughts? Oh I think I might be conflating 15565 and 15516. I think Victor's comment is still relevant though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #324 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #321) > Note: maxreserves counts the number of holds in the group hold, i.e. it > doesn't count it as one. It seems that was intentional. But highlighting > that for QA to review. > Holds per day and holds total circ rules count the group as 1. That's an interesting point. On one hand, you might want to limit the number of group members. On the other hand, it doesn't make sense to count the group as 1 hold but then also consider group members in terms of max reserves. Aleisha: What are your thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #29 from Aleisha Amohia --- I couldn't reproduce your bug. Is someone else about to reproduce it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #21 from Katrin Fischer --- To me the table with the prices (basket summary) looks exactly the same with and without patch...so that's why I am confused. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #20 from Victor Grousset/tuxayo --- > The "Actual cost" (incl. or excl.) look exactly the same to me, both showing > 0.00. IIUC it's what the patch does. It's different from the 1st patch which not only made the GST to be set but also the Actual cost tax inc. === Something I'm not sure is: > 7 - Display all columns, GST is calculated correctly, unitprice remains 0. unitprice? I expected "Actual cost tax inc." to be mentioned instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27623] Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #24 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #22) > Hm, this might be the same problem Victor already saw, but using the branch, Which problem? It seems I didn't get a problem each time I tried. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27624] Remove ru-RU installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27624 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27624] Remove ru-RU installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27624 --- Comment #7 from Katrin Fischer --- Same issue here I had on the pl-PL patch :( YAML::XS::Load Error: The problem: control characters are not allowed was found at document: 0 at /usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/XS.pm line 51 in YAML::XS::LoadFile at /usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/XS.pm line 51 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25760] Holds ratio report is not reporting on records with 1 hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Katrin Fischer changed: What|Removed |Added Attachment #119385|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 120750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120750=edit Bug 25760: [Alternate] (bug 15422 follow-up) Display record with hold ratio greater than or equal to the value entered On bug 15422 we made it so that only holds with copies to buy to acheive the holds ratio showed Users have reported that they want to see record where there are 0 copies to buy i.e. the holds ration matches the value entered This patch changes the criteria for returning holds to be if the ratio for a given title is equal to or greater then the ratio specified in the form I also renamed 'ratiocalc' to 'copies_to_buy' since that is what is contains Test plan: 1. Create bibliographic records with 1, 2 and 3 items 2. Place 1 hold on each of them 3. Go to the Hold ratios report and search with ratio = 1, 2 then 3 4. You expect to see: the title with 1 item with ratio 1 nothing otherwise 5. Place another hold on each of the record 6. Repeat 3 you expect to see: titles with 1 or 2 items with ratio 1 title with 1 item for ratio 2 nothing with ratio 3 7. Place another hold on each of the record 8. Repeat 3 you expect to see: titles with 1 or 2 or 3 items with ratio 1 title with 1 item or 2 items for ratio 2 nothing with ratio 3 9. Make sure there is no regression in the test plan of bug 15422 Comments from Frank Hansen: Some comments. When I adding the third hold on each record in step 7, It will result in the following result: titles with 1 or 2 or 3 items with ratio 1 title with 1 items with ratio 2 because the title with 2 items will get a ratio of 1.50 and not 2. title with 1 items with with ratio 3 Signed-off-by: Frank Hansen Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25760] Holds ratio report is not reporting on records with 1 hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25760] Holds ratio report is not reporting on records with 1 hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Katrin Fischer changed: What|Removed |Added Summary|Holds Ratio report is not |Holds ratio report is not |reporting on records with 1 |reporting on records with 1 |hold|hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28108] LetterLog/Acquistions/Claims: Logging filters are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #12 from Katrin Fischer --- Created attachment 120749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120749=edit Bug 28108: (QA follow-up) Add actions to log viewer The following actions were missing from the template, so the code showed instead of a translatable description: * ACQUISITION CLAIM * ACQUISITION ORDER * SERIAL ORDER -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28108] LetterLog/Acquistions/Claims: Logging filters are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #11 from Katrin Fischer --- Created attachment 120748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120748=edit Bug 28108: (QA follow-up) Make the system preference description more precise There has been some confusion on what the pref really covers, so I hope this helps to resolve. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28108] LetterLog/Acquistions/Claims: Logging filters are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Katrin Fischer changed: What|Removed |Added Attachment #119548|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 120747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120747=edit Bug 28108: Fix filtering Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28108] LetterLog/Acquistions/Claims: Logging filters are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28108] LetterLog/Acquistions/Claims: Logging filters are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal --- Comment #9 from Katrin Fischer --- (In reply to David Nind from comment #7) > If claims is a subset of the acquisitions module, then how about > "Acquisitions - Claims"? This is actually not only about acq claims - it also covers serial issue claims and acq orders: WHERE module = 'ACQUISITIONS' AND ( action = 'SERIAL CLAIM' OR action = 'ACQUISITION ORDER' OR action = 'ACQUISITION CLAIM') Ultimately, that's a bit of a weird mix, especially since orders are not claims... we might want to split them up at some point. But let's fix this bug first :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Katrin Fischer changed: What|Removed |Added Attachment #120453|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 120746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120746=edit Bug 26995: (QA follow-up) Fix logic in database update The logic was reversed.. if the column exists we want to delete it ;) Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Katrin Fischer changed: What|Removed |Added Attachment #120452|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 120745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120745=edit Bug 26995: Remove references to relationship column Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Katrin Fischer changed: What|Removed |Added Attachment #120451|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 120744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120744=edit Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Katrin Fischer changed: What|Removed |Added Summary|Authorized Value for|When using an authorised |Suppression when added to |value for suppression, |Frameworks doesn't show |record doesn't show as |Suppress in Staff Client|suppressed in staff ||interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't show Suppress in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #12 from Katrin Fischer ---
I am sorry, but I don't believe this is a good solution.
This will fail the second someone translates the authorised value (trust me, we
do that! :) )
Looking at this, I wonder if we should handle this differently:
We run into this issue because as soon as something is linked to an authorised
value, the code will be replaced by the description in the XSLT. And this
should not happen:
XSLT.pm (see bug 14377):
+ # Replace the field value with the authorised value *except* for
MARC21/NORMARC field 942$n (suppression in opac)
if ( !( $tag eq '942' && $subfield eq 'n' ) || $marcflavour eq 'UNIMARC' ) {
$value = GetAuthorisedValueDesc( $tag, $letter, $value, '', $tagslib )
So even when linked to an authorised value, we should still be seeing a 1 and
the check should be working.
Please check why this is not working as expected.
I also feel like the depends on bug 26116 is wrong here - should be a blocks.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Katrin Fischer changed: What|Removed |Added Attachment #120561|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 120743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120743=edit Bug 24154: Adjust assignment The code seems to work either way We have a mix in our code: git grep "}) %]" Using '=>' over '=' does look nicer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Katrin Fischer changed: What|Removed |Added Attachment #120047|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 120742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120742=edit Bug 24154: (follow-up) Make parameter and variable more explicit, add tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Katrin Fischer changed: What|Removed |Added Attachment #119950|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 120741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120741=edit Bug 24154: Get rules rather than values to determine if set or not Template plugin CirculationRules.Search returns "" if a rule doesn't exist or if the rule exists but is set to "" To get more info, we add a 'want_rule' parameter and use that to test if defined but blank To test: 1 - In circulation rules set the 'Default checkout, hold and return policy' without setting values 2 - Unset it 3 - Notice there is no visual difference 4 - Apply patch 5 - Reload the page 6 - note there is no 'Unset button' and first column says 'Not set' 7 - Save the rule with no values 8 - Now 'Defaults' is displayed and the unset button exists Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 --- Comment #18 from Katrin Fischer --- Thx for putting in the tooltip! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Katrin Fischer changed: What|Removed |Added Attachment #120081|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 120740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120740=edit Bug 13613: (follow-up) Add tooltip when disabled This patch adds a tooltip to the digest checkboxes when disabled. When enabled the tooltip is hidden Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Katrin Fischer changed: What|Removed |Added Attachment #119333|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 120739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120739=edit Bug 13613: (follow-up) Use more unique classes This resolves the issue of being unable to save email as it was being hit by the validator Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Katrin Fischer changed: What|Removed |Added Attachment #119332|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 120738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120738=edit Bug 13613: (Bug 22744 follow-up) Remove js handling for 'none' There was a function and a set of onclick events to handle the 'Do not notify' checkboxes. Those have been removed, so should this code To test: 1 - Sign in to opac 2 - Click on 'your messaging' tab from 'your account' 3 - Check/uncheck some boxes 4 - Note error in the console: Uncaught TypeError: document.opacmessaging.none2 is undefined 5 - Apply patch 6 - repeat 7 - no more error Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Katrin Fischer changed: What|Removed |Added Attachment #119331|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 120737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120737=edit Bug 13613: Don't allow digest to be selected without a digest-able transport selected By default, only the email transport is enabled. This gives the messaging preferences the look of having email and digest and two options. I.E. to some users it appears that you check email for single emails, *or* you check digest for a digest email. To help remove this possible confusion, the digest mode checkbox should be disabled if no digest-able transports are checked for a given notice. Test Plan: 1) Apply this patch 2) For both the staff interface and the opac, note that the digest checkbox is disabled any time that no digest enabled transport ( email, sms if enabled ) is checked for the patron editor. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer --- I really like this and always happy to have new contribs, but I am worried about something in the behaviour of this plugin. I've also tried linking it to 050$a. When I import a record with a 050$a set already or open a record that already has it and click into the field or tab through the fields, the plugin is immediately triggered, killing the original value. I think we need this to trigger only 'on demand' or when the field is empty to avoid unintentional data loss. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #19 from Katrin Fischer --- I am sorry, but I fail to understand the problem here :( I assume that we are looking at the basket summary page. Correct? I created 2 orders, one pre-patch and one post-patch, actual cost was left empty. The "Actual cost" (incl. or excl.) look exactly the same to me, both showing 0.00. Can you please help me figure this one out? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] 'Quantity received' should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] 'Quantity received' should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Signed Off Summary|`Quantity received` should |'Quantity received' should |have inputmode="numeric"|have inputmode="numeric" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Katrin Fischer changed: What|Removed |Added Attachment #120687|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 120736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120736=edit Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive This patch adds an inputmode to the quantity field on the order receive page in acquisitions. Test plan 1. Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt page -> Receive. 2. Note that the 'Quantity received' input has an inputmode now. 3. Note that the 'Quantity received' input also has a pattern attribute. 4. Note that you should not be able to enter non-integer values. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- I am seeing a failure in the QA script, can you please check: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters FAIL forbidden patterns forbidden pattern: console.log (line 1754) Also and more importantly, with this patch covers on result list are broken: Uncaught ReferenceError: NO_LOCAL_JACKET is not defined GetCoverFromBibnumber http://localhost:8080/opac-tmpl/bootstrap/js/localcovers_20.1200047.js:25 jQuery 2 GetCoverFromBibnumber http://localhost:8080/opac-tmpl/bootstrap/js/localcovers_20.1200047.js:21 http://localhost:8080/cgi-bin/koha/opac-search.pl?idx==perl_search=1:3137 jQuery 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #30 from Katrin Fischer --- Overall this works pretty great, but I am seeing something confusing in my testing: I've uploaded 2 local bib level covers. I've activated AdLibris covers. Looking at the detail page, I have 3 dots below the first cover and can swith back and forth, so far so good. When I click on the "second" dot, that is the second local cover and the one before the Adlibris one there is a "loading" icon that is not going away. I've tried changing the sequence of covers and services, it appears to remain showing on the "last" local cover one. And it's only on record level, not on the item level covers. ... And it remains without the patch set, so I am inclined to move this forward, but maybe worth looking at? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer changed: What|Removed |Added Attachment #120463|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 120735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120735=edit Bug 28179: (follow-up) Remove console.log This patch removes a "console.log" from detail.tt and replaces it with similar output to the user. It will probably never be triggered, but better to handle it gracefully than have a hidden log. Signed-off-by: Owen Leonard Signed-off-by: Rasmus Leißner Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer changed: What|Removed |Added Attachment #120462|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 120734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120734=edit Bug 28179: (follow-up) Updates to styling of lightbox controls This patch fixes a bug and adds some style changes which I think are nice. The bugfix is to change the z-index of the lightbox footer so that it isn't hidden when there is a language menu in the footer. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. License information about Bootstrap Icons has been added to the About page. Signed-off-by: Jonathan Druart Signed-off-by: Owen Leonard Signed-off-by: Rasmus Leißner Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer changed: What|Removed |Added Attachment #120461|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 120733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120733=edit Bug 28179: Adjust chocolat.js to display href In order to display link in the description we need to adjust chocolat.js Maybe this needs to be reported upstream Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard Signed-off-by: Rasmus Leißner Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179
Katrin Fischer changed:
What|Removed |Added
Attachment #120460|0 |1
is obsolete||
--- Comment #26 from Katrin Fischer ---
Created attachment 120732
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120732=edit
Bug 28179: Add a lightbox gallery to display cover images - detail page, staff
interface
This patch adds the ability to display the cover images of a
bibliographic record in a gallery. Cover images attached to items can
also be displayed in separated galleries.
Test plan:
All the cover images are affected, all the different sources will be
tested.
All the steps will be done on the same bibliographic record.
1. Local cover images
a. Turn on LocalCoverImages and AllowMultipleCovers
b. Add several local cover images to a bibliographic record
c. Add several local cover images to an item
d. Click on an image and confirm that it is displayed in a gallery and
you can navigate see all the images attached to the bibliographic
record
e. Same for items
2. Adlibris
a. Turn on AdlibrisCoversEnabled
b. Edit the biliographic record and add an ISBN that will return a
cover image for this service (9780670026623 for instance)
c. Display the cover images in the gallery
d. Note the link to the adlibris.com website at the bottom
3. Amazon
a. Turn on AmazonCoverImages
b. Display the cover images in the gallery
4. Coce
a. Turn on IntranetCoce, set CoceHost to "http://coce.tamil.fr:8080;
and select some values for CoceProviders.
b. Display the cover images in the gallery
5. Custom cover images
a. Turn on CustomCoverImages and set CustomCoverImagesURL to
https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg
of anything else meaningful
b. Display the cover images in the gallery
Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)
Signed-off-by: Owen Leonard
Signed-off-by: Rasmus Leißner
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer changed: What|Removed |Added Attachment #120459|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 120731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120731=edit Bug 28179: Add the Chocolat gallery lightbox JS library Chocolat is a lightbox JS library. https://chocolat.insipi.de https://github.com/nicolas-t/Chocolat https://chocolat.gitbook.io Why Chocolat? It's released under the GPL v3 license, easy to use, configure and extend, and is still maintained/active. (and it has a nice name) Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard Signed-off-by: Rasmus Leißner Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27623] Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- Trying again with 28281 applied as well, but got stuck with the same error again :( Help? -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27623] Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #22 from Katrin Fischer --- Hm, this might be the same problem Victor already saw, but using the branch, I got stuck at this: YAML::XS::Load Error: The problem: control characters are not allowed was found at document: 0 at /usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/XS.pm line 51 in YAML::XS::LoadFile at /usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/XS.pm line 51 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 --- Comment #7 from Katrin Fischer --- Really nice enh for libraries not using the club feature - cutting down on confusion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Katrin Fischer changed: What|Removed |Added Attachment #120715|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 120730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120730=edit Bug 28229: (follow-up) Adjust for easier translation I think moving the [% IF %] out of the HTML tag makes for easier translation. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Katrin Fischer changed: What|Removed |Added Attachment #120681|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 120729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120729=edit Bug 28229: Only show clubs on request.tt if clubs exist 1. Have no existing clubs 2. Apply patch 3. Go to request.tt and you will not see the club tab or any mention of clubs 4. Create at least 1 club 5. Go back to request.tt and now see the tab for clubs 6. Make sure you can place holds as an individual with and without clubs. 7. Make sure you can place holds for clubs. 8. rejoice and sign-off Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28266] Misspelled word: recieved in cashup confirmation pop-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28266 Katrin Fischer changed: What|Removed |Added Attachment #120676|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 120728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120728=edit Bug 28266: fix spelling mistake on registers.tt TO test: 1. look at the cashup modal, see the wrong spelling of 'recieved' 2. Apply patch and see the right spelling Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28266] Misspelled word: recieved in cashup confirmation pop-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28266 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
