[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369 --- Comment #11 from Ere Maijala --- (In reply to Tomás Cohen Arazi from comment #6) > (In reply to Joonas Kylmälä from comment #5) > > (In reply to Tomás Cohen Arazi from comment #4) > > > Yes! Can certainly do! > > > > > > But as I mentioned, the PUT route is using (in the code) different > > > attribute > > > names than the API spec, so you need to check if it isn't broken already > > > (20.11). I couldn't find the references to the API routes on that PHP > > > code. > > > > The code is in the function changePickupLocation. The code in > > changePickupLocation uses the attribute names that work (instead of broken > > ones). > > Ok, I'm fine with fixing the spec and adding a deprecation warning, and > adding PATCH as a duplicate for PUT. > > Do you agree? Works for me (I'm responsible for the KohaRest PHP module). As a side note, it would be really nice if PATCH was able to modify priority, suspension and suspension end date as well as pickup location. From an API user's standpoint modifying several attributes of a hold is typically a single operation, and having to make several API calls makes using it convoluted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 --- Comment #1 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121140=edit Bug 28242: added captions to tables and legends to forms Ensured that in the OPAC, all tables have relevant captions and all forms have relevant legends. Many of these have class="sr-only" so they are not visible but will be available for people who use screen-readers. To test: 1) Go to OPAC 2) Apply patch and dependencies 3) Check that on all pages, any tables have a caption (many of them will not be visible, but will be in the markup code) 4) Check that on all pages, any forms have a legend (many of them will not be visible, but will be in the markup code) 5) Check that the captions are appropriate and relevant 6) Check that the legends are appropriate and relevant Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions and legends to tables and forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Summary|Accessibility: Staff Client |Accessibility: Staff Client |- add |- add captions and legends |captions/legends/labels to |to tables and forms |elements| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Summary|Accessibility: OPAC - add |Accessibility: OPAC - add |captions/legends/labels to |captions and legends to |elements|tables and forms -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #33 from Arthur Suzuki --- Hi David, just pushed a new version of the test patch with number of tests updated. Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What|Removed |Added Attachment #121100|0 |1 is obsolete|| --- Comment #32 from Arthur Suzuki --- Created attachment 121139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121139=edit Bug 20985: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Victor Grousset/tuxayo --- Not ready for QA, the two tests on sandboxes can't have ran the test and the test on comment 7 was a failure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle subfield in the default title index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This enhancement adds the release notes||245$b (subtitle) and 245$p ||(part name) subfields to ||the default title index ||mappings for Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle subfield in the default title index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 David Nind changed: What|Removed |Added Attachment #120907|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 121138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121138=edit Bug 27848: Elasticsearch - include 245p to default title index mappings Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle subfield in the default title index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 David Nind changed: What|Removed |Added Attachment #120906|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 121137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121137=edit Bug 27848: Elasticsearch - include 245b subtitle subfield in the default title index mappings Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle subfield in the default title index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 --- Comment #4 from Victor Grousset/tuxayo --- Unrelated, while I'm at it likely for a follow-up ticket: Is that expected that for free stuff where it's useful to track the "sales" like stock management; that an order with only free stuff just refreshes the page and does nothing? (including the Register details) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Victor Grousset/tuxayo --- It works, thanks :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121114|0 |1 is obsolete|| --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 121136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121136=edit Bug 28368: Add fallback language for anonymous payment receipts This adds a fallback for when a payment is made anonymously to allow printing a receipt in the staff members current session language. Test plan 1. Set `EnablePointOfSale` and `UseCashRegisters` 2. Add new cash register` 3. New debit type that 'can be sold' 4. Make a sale (via Point of Sale) using the above debit type. 5. Attempt to 'print receipt' from the subsequent prompt 6. Not the ISE: Can't call method "lang" 7. Apply patch 8. Attempt to 'print receipt' again, this time it should work. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #60 from David Nind --- Hi Aleisha. I'm using koha-testing-docker: * apply patch * databaseupdate * dbic * flush_memcached * restart_all * edit a record (tried a few different records) * save (without making any changes) David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 121135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121135=edit Bug 28381: Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) This patch adds fields 710$a and 711$a to the default author mappings for elasticsearch indexing. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for an author name found only in 710 using the Author index in advanced search 4) Repeat search for an author name in 711 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #59 from Aleisha Amohia --- That's weird I am totally not getting that error. What steps are you taking to reproduce? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28381] New: Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 Bug ID: 28381 Summary: Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com Currently, the author index for MARC21 contains 100a, 110a, 111a, 245c and 700a. I propose we also add 710a and 711a since 110a and 111a are there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28370] Routes still missing additionalProperties in spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28370 David Nind changed: What|Removed |Added Attachment #121110|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 121134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121134=edit Bug 28370: Add missing additionalProperties in spec This patch adds missing attribute to the object definitions in the spec. We wrongly supposed it was the default, but it proved not. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1 => SUCCESS: Tests pass, nothing breaks! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28370] Routes still missing additionalProperties in spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28370 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369
David Nind changed:
What|Removed |Added
Attachment #121119|0 |1
is obsolete||
--- Comment #10 from David Nind ---
Created attachment 121133
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121133=edit
Bug 28369: (QA follow-up) Restore PUT with deprecation message
This patch restores the PUT route, but adding a deprecation message. The
controller method is the same, and relevant patch tests are duplicated
but calling PUT, so it still gets tested.
To test:
1. Apply this patch
2. Reload plack
3. Open https://<>/api/v1/.html and find the PUT /holds/{hold_id} route
=> SUCCESS: There's a deprecation wargning!
4. Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369 David Nind changed: What|Removed |Added Attachment #121106|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 121132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121132=edit Bug 28369: Set additionalProperties: false and fix things This patch performs a cleanup on the holds routes: - It adds additionalProperties: false to all missing routes - It syncs the spec with the guidelines - additionalProperties: false highlighted some attributes read in the controlled weren't declared on the spec, adding them - PUT /holds/:hold_id is moved to PATCH, as it makes more sense and gathered opinions lean towards that To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Lots of things are wrong with the API 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369 David Nind changed: What|Removed |Added Attachment #121105|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 121131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121131=edit Bug 28369: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 121130
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121130=edit
Bug 28377: (follow-up) Remove svc/hold/{resume|suspend}
This files are no longer used and thus removed. Their functionality is
already present on the API
POST /holds/:hold_id/suspension
DELETE /holds/:hold_id/suspension
To test:
1. Apply this patch
2. Run:
$ git grep 'hold/suspend'
$ git grep 'hold/resume'
=> SUCCESS: No references to the scripts
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 121129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121129=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 121128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121128=edit Bug 28380: Elasticsearch - correct 024aa in mappings (MARC21) This patch corrects a typo in the mappings.yaml file To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for a standard number found in 024$a using the Standard number index in the advanced search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #31 from David Nind --- Hi Arthur. I quickly ran through the test plan. Everything works as expected, except the tests fail. If I manually update the number of tests to 68, everything passes. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Caroline Cyr La Rose changed: What|Removed |Added Summary|Elasticsearch - correct |Elasticsearch - correct |024aa in mappings |024aa in mappings (MARC21) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28380] New: Elasticsearch - correct 024aa in mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Bug ID: 28380 Summary: Elasticsearch - correct 024aa in mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com In the mappings.yaml file, under the identifier-other index, the field 024aa is listed. I don't know if the double a can cause a problem, or if it's simply a typo without consequence. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24678] Add missing search fields to Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28379 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24678 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 121127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121127=edit Bug 28379: Elasticsearch - Add 710 to author-name-corporate index (MARC21) This patch adds 710 to the default author-name-corporate index mappings for elasticsearch. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for an author name found only in 710 using the Author (Corporate name) index in advanced search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Caroline Cyr La Rose changed: What|Removed |Added Summary|Elasticsearch - Add 710 to |Elasticsearch - Add 710 to |author-name-corporate index |author-name-corporate index ||(MARC21) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28379] New: Elasticsearch - Add 710 to author-name-corporate index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Bug ID: 28379 Summary: Elasticsearch - Add 710 to author-name-corporate index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com 710 is missing from the default mappings for author-name-corporate (it currently contains 110, 111, 711, 810, and 811). This is clearly a simple omission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24678 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24678] Add missing search fields to Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28378 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 121126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121126=edit Bug 28378: Elasticsearch - Add 264c to default copydate mappings (MARC21) This patch adds 264$c to the default mapping for the copydate index. To test: 1) Apply patch 2) Reindex using rebuildelasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for a copyright date found in 264$c -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28378] New: Elasticsearch - Add 264c to default copydate mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 Bug ID: 28378 Summary: Elasticsearch - Add 264c to default copydate mappings (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com In the current default index mappings, copydate only includes 260$c. I think it should also include 264$c which is used as much as, if not more than, 260$c. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28377] New: Use the API to suspend/resume holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Bug ID: 28377 Summary: Use the API to suspend/resume holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com We have routes for suspending and resuming holds. We can deprecate the svc/holds/* scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 121125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121125=edit Bug 28339: Elasticsearch - Add 8XX to default title-series index mappings (MARC21) This patch adds series added entries titles (800 $t, 810 $t, 811 $t, and 830 $a) in the default title-series index mappings. To test: 1) Apply patch 2) Reindex using rebuildelasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration and click "Reset mappings" and confirm 2b) Then reindex 3) Search for a series title found only in and added entry field https://bugs.koha-community.org/show_bug.cgi?id=23853 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle subfield in the default title index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 --- Comment #5 from Caroline Cyr La Rose --- Hi Lucy, You can see them if you click on "Reset mappings" in the mapping administration page. I think they don't appear right away because the sandbox is created with the current file, THEN the patch is applied, which changes the file. So we have to "refresh" the mappings. To test: 1) Apply patch 2) Reindex using rebuildelasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration and click "Reset mappings" and confirm 2b) Then reindex 3) Search for a subtitle or part name using the title index -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #20 from David Nind --- Hi Yolanda. I don't think your query relates to this bug, which is about updating the version of the software used for wiki.koha-community.org I don't know the answer to your query, but others on the general mailing list (https://koha-community.org/support/koha-mailing-lists/), or IRC (https://koha-community.org/get-involved/irc/) may be able to help. It does sound odd.. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Nick Clemens changed: What|Removed |Added Attachment #121123|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 121124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121124=edit Bug 28375: Inefficiencies in fetching COinS This patchset adds an 'interface' parameter to XSLTParseForDisplay to avoid fetching coins when not needed Additionally we move some logic from the scripts to searchResults to avoid an extra fetch fo the biblio object To test: 1 - Enable COinSinOPACResults syspref 2 - Also enable OPACShowOpenURL and OPACOpenURLItemTypes - adding an itemtype that you can find 3 - Perform a search on the OPAC and confirm coins are included and openurl shown 4 - Perform a search on staff client and confirm openurls do not show 5 - Apply patch 6 - Results should be the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #27 from Victor Grousset/tuxayo --- > And the hold tab says that it's in transfer, where is that even stored... A diff on database dump before and after the transfer shows that the info is from the reserves table. found = T => Hold is in transit and the reserves table stores the pickup library so here we have the data behind the message. And nothing added in the branchtransfers table. Puzzling. Should we switch to need signoff to have more chances of someone else trying this out? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28353] regression: Batch Item Deletion no longer shows which items were not removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #5 from LeeAnn Nilsson --- Yes that is helpful. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #26 from Victor Grousset/tuxayo --- Likely nothing to do with these changes, but maybe I did something wrong in testing. Is that expected that 1. be in library A 2. have an item in library C 3. start a transfer to library B 4. record detail view still says that it's in library C. Should scanning of it's barcode in lib A means that it's in lib A? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #25 from Victor Grousset/tuxayo --- > 15 - Hold is in transit and transfer is generated correctly I'm still not getting a record added to the branchtransfers table >_< And the hold tab says that it's in transfer, where is that even stored... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28351] Cannot set restrictions when 'dateformat' is other than 'us'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28351 Tomás Cohen Arazi changed: What|Removed |Added Summary|Cannot set restrictions |Cannot set restrictions |when dateformat is other|when 'dateformat' is other |than mm/dd/ |than 'us' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28351] Cannot set restrictions when dateformat is other than mm/dd/yyyy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28351 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28376 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28351 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] New: Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Bug ID: 28376 Summary: Replace obsolete jquery-ui-timepicker-addon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The latest jquery-ui-timepicker-addon version dates back to 2016, and we are using one dated 2014. We should replace it with something that's maintained. 'flatpickr' [1] could be used to replace timepickers and also datepickers. It is flexible enough for us to customize things, including date formatting and translations. [1] https://flatpickr.js.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion Information filter in Suggestions Management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994 Margaret Hade changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28351] Cannot set restrictions when dateformat is other than mm/dd/yyyy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28351 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #15 from Tomás Cohen Arazi --- Lucas and I have tried to SO this patch, but: $ git bz edit 28351 Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2705, in do_edit(*args) File "/usr/local/bin/git-bz", line 2377, in do_edit edit_bug(bug) File "/usr/local/bin/git-bz", line 2181, in edit_bug lines = edit_template(template.getvalue()) File "/usr/local/bin/git-bz", line 820, in edit_template f.write(template) UnicodeEncodeError: 'ascii' codec can't encode character u'\xa0' in position 703: ordinal not in range(128) Not sure what's going on with BZ. If you can, Jonathan, please stamp our signatures on pushing. Signed-off-by: Lucas Gass Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27916] Fee paid message can crash SIP server if paying fee that is not "renewable"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916 Kyle M Hall changed: What|Removed |Added Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 27916, which changed state. Bug 27916 Summary: Fee paid message can crash SIP server if paying fee that is not "renewable" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916 What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 --- Comment #1 from Nick Clemens --- Created attachment 121123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121123=edit Bug 28375: Inefficiencies in fetching COinS This patchset adds an 'interface' parameter to XSLTParseForDisplay to avoid fetching coins when not needed Additionally we move some logic from the scripts to searchResults to avoid an extra fetch fo the biblio object To test: 1 - Enable COinSinOPACResults syspref 2 - Also enable OPACShowOpenURL and OPACOpenURLItemTypes - adding an itemtype that you can find 3 - Perform a search on the OPAC and confirm coins are included and openurl shown 4 - Perform a search on staff client and confirm openurls do not show 5 - Apply patch 6 - Results should be the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28375] New: Inefficiencies in fetching COinS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Bug ID: 28375 Summary: Inefficiencies in fetching COinS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In XSLTParseForDisplay we fetch the coins for the OPAC even on the staff interface On opac results we fetch the biblio object, this is already fetched in the searchResults subroutine Additionally - we can fetch the coins in the searchResults to move logic out of the scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Lucas Gass changed: What|Removed |Added Attachment #121118|0 |1 is obsolete|| --- Comment #13 from Lucas Gass --- Created attachment 121122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121122=edit Bug 28346: (QA follow-up) Correct silly mistake with details-action This patch moves the details-action class introduced in the first commit from the font-icon to the button where it should be. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Lucas Gass changed: What|Removed |Added Attachment #121109|0 |1 is obsolete|| --- Comment #12 from Lucas Gass --- Created attachment 121121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121121=edit Bug 28346: (QA follow-up) Correct silly mistake with cancel-action This patch moves the cancel-action class introduced in the previous commit from the font-icon to the button where it should be. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #11 from Lucas Gass --- Created attachment 121120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121120=edit Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #24 from Victor Grousset/tuxayo --- (In reply to Victor Grousset/tuxayo from comment #18) > > 15 - Hold is in transit and transfer is generated correctly > > Ok I have "Item is now in transit to Fairfield" > > Shouldn't this create a record in branchtransfers ? note from IRC, to not forget: Martin: «for your issue with step 15.. I get a line in branchtransfers.. so a little confused» > Shouldn't this be shown in the biblio record details? > In addition to "There is an item level hold on this item (priority = 0)." from IRC: Martin: «yes, once you've clicked to transfer you should then see the line set and the biblio should view should include that info.» There is the info about the hold. But should there also be an info about the transit? There is none as of yesterday's test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369
--- Comment #7 from Tomás Cohen Arazi ---
Created attachment 121119
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121119=edit
Bug 28369: (QA follow-up) Restore PUT with deprecation message
This patch restores the PUT route, but adding a deprecation message. The
controller method is the same, and relevant patch tests are duplicated
but calling PUT, so it still gets tested.
To test:
1. Apply this patch
2. Reload plack
3. Open https://<>/api/v1/.html and find the PUT /holds/{hold_id} route
=> SUCCESS: There's a deprecation wargning!
4. Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #10 from Martin Renvoize --- Clearly I was having a bad day when I wrote this patch!.. Two simple follow-ups later, hopefully I've got it this time! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #9 from Martin Renvoize --- Created attachment 121118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121118=edit Bug 28346: (QA follow-up) Correct silly mistake with details-action This patch moves the details-action class introduced in the first commit from the font-icon to the button where it should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What|Removed |Added Attachment #121116|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #2 from Martin Renvoize --- Created attachment 121117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121117=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1/ Try printing a point of sale receipt before and after applying the patch 2/ No change should result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #1 from Martin Renvoize --- Created attachment 121116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121116=edit Bug 28373: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1/ Try printing a point of sale receipt before and after applying the patch 2/ No change should result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28373] Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #3 from Nick Clemens --- Note: I say "slightly", however, that is a function of how many items are on your records. The perf increase is small on the sample database, but very large on a consortium site with many items per record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > Yes! Can certainly do! > > > > But as I mentioned, the PUT route is using (in the code) different attribute > > names than the API spec, so you need to check if it isn't broken already > > (20.11). I couldn't find the references to the API routes on that PHP code. > > The code is in the function changePickupLocation. The code in > changePickupLocation uses the attribute names that work (instead of broken > ones). Ok, I'm fine with fixing the spec and adding a deprecation warning, and adding PATCH as a duplicate for PUT. Do you agree? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #8 from Lucas Gass --- (In reply to Martin Renvoize from comment #7) > Did I miss a case... 'details-action' looks like that one to me. Ah, yes I see 'details-action' but it on the icon element, not the button: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28373] Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28371 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Nick Clemens changed: What|Removed |Added Depends on||28371 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 [Bug 28371] Improve performance of XSLTParse4Display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28373 Blocks||15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Nick Clemens changed: What|Removed |Added Depends on||28373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 [Bug 28373] Items fields not used in default XSLT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28373] Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens changed: What|Removed |Added Blocks||15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28373] Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #2 from Nick Clemens --- Created attachment 121115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121115=edit Bug 28373: Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28373] Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Martin Renvoize changed: What|Removed |Added Blocks||28374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 Martin Renvoize changed: What|Removed |Added Blocks||28374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What|Removed |Added Depends on||28374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What|Removed |Added Depends on||26734, 28368 Blocks||13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 [Bug 28368] Error when printing receipt of point of sale -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] New: Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Bug ID: 28374 Summary: Convert pos/printreceipt.pl to use GetPreparedLetter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org It looks like somehow a patch got dropped from bug 26734 that converted the POS receipt printer to use GetPrepparedLetter too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369 --- Comment #5 from Joonas Kylmälä --- (In reply to Tomás Cohen Arazi from comment #4) > Yes! Can certainly do! > > But as I mentioned, the PUT route is using (in the code) different attribute > names than the API spec, so you need to check if it isn't broken already > (20.11). I couldn't find the references to the API routes on that PHP code. The code is in the function changePickupLocation. The code in changePickupLocation uses the attribute names that work (instead of broken ones). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Martin Renvoize changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 --- Comment #1 from Martin Renvoize --- Created attachment 121114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121114=edit Bug 28368: Add fallback language for anonymous payment receipts This adds a fallback for when a payment is made anonymously to allow printing a receipt in the staff members current session language. Test plan 1. Set `EnablePointOfSale` and `UseCashRegisters` 2. Add new cash register` 3. New debit type that 'can be sold' 4. Make a sale (via Point of Sale) using the above debit type. 5. Attempt to 'print receipt' from the subsequent prompt 6. Not the ISE: Can't call method "lang" 7. Apply patch 8. Attempt to 'print receipt' again, this time it should work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
