[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #346 from Aleisha Amohia  ---
I decided to amend count_grouped() to count_holds() so it sounds more like the
standard subroutine it will become. It needs to use count() which is why I
couldn't just overwrite count().

Left the OPAC count_holds() in because borrowers might get group holds placed
in the staff client then try to place holds via the OPAC so they need that
count to calculate their limit.

I imagine the most recent patch doesn't catch all of the staff interface cases
for placing a hold so feel free to tell me what I've missed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #345 from Aleisha Amohia  ---
Created attachment 121623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121623=edit
Bug 15516: (follow-up) Count group holds always

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620

--- Comment #9 from David Cook  ---
Note though that this proxying of Z39.50 via a HTTP proxy will only work if
your HTTP proxy allows connections to Z39.50 ports (like 210, 7090) and doesn't
restrict them to 80 and 443.

But still... this has been very illuminating.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620

--- Comment #8 from David Cook  ---
(In reply to Galen Charlton from comment #2)
> Depending on the nature of the proxy involved, it may not be necessary to
> use YAZProxy. In particular, the YAZ toolkit supports a special connection
> syntax to direct Z39.50 and SRU traffic through a proxy.
> 
> For example, suppose you have a Squid proxy running on localhost and
> listening on port 210, and further suppose that the proxy is configured to
> allow connecting to the target Z39.50 server(s).  In that case, with
> yaz-client you can do something like this:
> 
> yaz-client connect:localhost:3128,tcp:lx2.loc.gov:210/LCDB
> 
> and that will get you a proxied Z39.50 connection to the Library of Congress.

It took a bit of digging but I found some information about that syntax that
Galen mentioned:

https://github.com/indexdata/yaz/blob/master/NEWS#L2365

So in that case you'd be doing "yaz-client
connect:EDUPROXY:PROXYPORT,tcp:lx2.loc.gov:210/LCDB".

Now ZOOM doesn't explicitly mention support for this syntax
(https://metacpan.org/pod/distribution/Net-Z3950-ZOOM/lib/ZOOM.pod). Of course,
neither does yaz-client (https://linux.die.net/man/1/yaz-client). As I said,
the documentation leaves something to be desired.

I'm waiting to hear back from Adam Dickmeiss about that. 

But looking at C4::Breeding::_create_connection... it looks like Koha would
need a little patch to change how we pass in the connection string.

Instead of '$obj->connect( $server->{host}, $server->{port} )', we'd want to
use something like '$obj->connect($host)' where $host is constructed based on
whether or not there is a proxy. (See
https://metacpan.org/pod/distribution/Net-Z3950-ZOOM/lib/ZOOM.pod#new())

I could keep digging through source code but I think it'll just be easier to
wait for Adam's response.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620

--- Comment #7 from David Cook  ---
It looks like the "proxy" connect option expects the target to be a Z39.50
proxy.

However... maybe you could tunnel Z39.50 through HTTP...depending on the
proxy...

https://en.wikipedia.org/wiki/HTTP_tunnel
https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/CONNECT
https://datatracker.ietf.org/doc/html/rfc7231#section-4.3.6

It looks like the YAZ toolkit added something for that in 5.10.0 in 2015:
https://github.com/indexdata/yaz/blob/master/NEWS#L457

https://github.com/indexdata/yaz/commit/9021ba4aa6fcdbdd177073d44edd03a86d70198f

I'm finding the YAZ documentation to be quite poor... so I'm going to reach out
to Indexdata and see what they have to say on the topic.

This might actually be possible...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741

--- Comment #29 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 121622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121622=edit
Bug 27741: tools folder

Bug 27631 corrected the  tags in each of the pages in the staff client.
This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under  are in the correct
order and hierarchy

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #6 from David Cook  ---
This is an interesting one, and Dan is in Australia as well, so I'm extra
interested.

I'd need to know more about the network ecosystem at the school, but it sounds
like all outbound network traffic is blocked, unless it uses a HTTP forward
proxy. Of course, that means that they'll be restricted to only using HTTP (or
maybe just ports 80 and 443 depending on the type of proxy). 

Since Z39.50 tends to use ports 210 or 7090, that's not going to be an option. 

SRU could be an option, since it uses HTTP, but the SCIS website seems to
suggest it only has Z39.50 for programmatic access
(https://www.scisdata.com/products/scis-data/). 

Looking at https://metacpan.org/pod/ZOOM and
https://software.indexdata.com/yaz/doc/zoom.html, there is a proxy option, so
if it's not a HTTP forward proxy and is just a TCP proxy... then that could be
investigated as an option. 

Happy to chat with Dan in any case.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28373] Items fields not used in default XSLT

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27761] Koha is reporting deleted items when a pickup is done by OAI

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27761

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #1 from Katrin Fischer  ---
Hi Jonathan, do you delete the items or mark them withdrawn?
What is the setting of your OAI-PMH:DeletedRecord system preference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27720] Print Holds List slip

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27720

--- Comment #1 from Katrin Fischer  ---
Hi Daniel, could you explain a bit how this slip would be used in the library?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #134 from David Cook  ---
Checking hold limits has been driving me crazy lately.

It seems to me that these functions should check all the different hold limits
and report back specifically why the book or item can't be reserved. For
example, exceeded max reserves, exceeded total holds for the day, exceeded
total holds for record, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27964] Link to subscription in serial collections view is broken - the field subscriptionid is undefined in the subscription object.

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964

--- Comment #2 from Katrin Fischer  ---
Hi Andreas, could you please include a test plan and problem description in
your commit message? Should this be Needs Signoff?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Katrin Fischer  ---
Hi Lucas,

with the new additions in 21.05 we also need to fix AUTO_RENEWALS_DGST now. And
for new installations we need sample_notices.yml fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #121 from Katrin Fischer  ---
(In reply to Gérard Simon Voyer from comment #120)
> Hi Alex!
> 
> I'm trying my hand at sign offs. On a koha-docker-testing CT using master
> branch, I seem to fall on this error upon entering the ElasticSearch
> mappings setup : https://pastebin.com/8Mj7LzvM
> 
> Something I'm doing wrong? I remember this message being addressed in one of
> the obsoleted patches.
> 
> Thanks a lot!

Hi, you can try Actions > Refresh Schema to see if this fixes the issue. An
Actions > Restart services also sometimes doesn't hurt (restarts Plack,
Memcached, Apache etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined)

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488

--- Comment #4 from David Cook  ---
(In reply to Katrin Fischer from comment #3)
> __() is used in .js files, _() in TT files.

Ahh interesting. I wish I remembered where I saw the combo..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #48 from David Cook  ---
(In reply to Blou from comment #46)
> Ivan has already recoded it without sessions in our codebase.  But before
> pushing that change, we'll be waiting for Tomas' instructions regarding the
> svc/

I'll mostly leave it to Tomas, but it might be worth looking over
https://wiki.koha-community.org/wiki/Rest_Api_HowTo

Basically, the "svc/" API scripts are legacy, so we don't want to be adding new
ones. We just want to build up the Mojolicious-based REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28265] Add option to include and calculate sales tax in Point of Sale

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28265

Katrin Fischer  changed:

   What|Removed |Added

Version|20.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28335] Making patron attributes required can cause issues in multi branch systems

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28335

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28335] Making patron attributes required can cause issues in multi branch systems

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28335

Katrin Fischer  changed:

   What|Removed |Added

Summary|Making Patron Attributes|Making patron attributes
   |Required Can cause issues   |required can cause issues
   |in multi branch systems |in multi branch systems

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422

--- Comment #5 from David Cook  ---
(In reply to Katrin Fischer from comment #4)
> I get a strong feeling that we should centralize the code for this check...
> but as a bug fix this works really well.

Agreed. Holds are a total mess.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined)

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488

--- Comment #3 from Katrin Fischer  ---
__() is used in .js files, _() in TT files.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined)

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488

--- Comment #2 from David Cook  ---
I was wondering that as well. 

What's the difference between __() and _()? I've noticed some cases where
they'll both be used close to each other.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28482] Floating point math prevents items from being returned

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24855] Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28482

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24855] Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855

--- Comment #6 from Katrin Fischer  ---
Is this possibly a duplicate of bug 28482?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348

David Nind  changed:

   What|Removed |Added

 Attachment #114903|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 121621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121621=edit
Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348

David Nind  changed:

   What|Removed |Added

 Attachment #114902|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 121620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121620=edit
Bug 27348: Fix test on INDEXER_PARAMS in koha-indexer

koha-indexer doesn't test INDEXER_PARAMS correctly which causes errors
to display when stopping/starting the daemon.

This patch fixes the test so that the variable is tested as a string,
so that no errors are created and the params are passed correctly.

Test plan:
0. Apply patch
1. vi /etc/default/koha-common
2. Add the following to the bottom of the file:
INDEXER_PARAMS="-daemon -sleep 6"
3. cp debian/scripts/koha-indexer /usr/sbin/koha-indexer
4. koha-indexer --stop kohadev
5. Note no errors
6. koha-indexer --start kohadev
7. Note no errors
8. ps -efww | grep "indexer"
9. Note that rebuild_zebra.pl has the arguments "-daemon -sleep 6"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|fridolin.som...@biblibre.co |katrin.fisc...@bsz-bw.de
   |m   |

--- Comment #4 from Katrin Fischer  ---
Stealing this one, Frido ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191

--- Comment #3 from Katrin Fischer  ---
Created attachment 121619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121619=edit
Bug 28191: Upate wording on batch patron deletion

This adds another point to the list of things that prevent patron
deletion:

They have permissions assigned to them.

In order to test:
- Go to tools > patron deletion and anonymization
- Verify the new condition shows at the top of the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23908] Require patrons to confirm their email address

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908

--- Comment #6 from David Cook  ---
(In reply to Lari Taskula from comment #2)
> Also, we should keep using their old email for messaging until patron has
> verified the new one. So this requires some thought for the design. Perhaps
> the whole messaging system should be redesigned so that patron can add n
> number of email addresses (that can actually be used for messaging according
> to patron's choice) instead of the so-confusing email, emailpro, B_email and
> so on. But maybe this is outside the scope of this Bug.

This is something I've been saying for years. I haven't found an existing bug
for it, but I also haven't looked super heard.

Interesting that people used to pack multiple emails into some of these email
fields though (see Bug 16786).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23908] Require patrons to confirm their email address

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908

--- Comment #5 from David Cook  ---
So Keycloak (the open source Identity and Access Management software) has an
"Email verified" attribute for users, and there are several ways that it can be
enabled.

Administrators can manually enable it, a registration email can include an
email verification link, you can update it using a REST API. Those are the
methods I know of but there might be more.

--

In theory, when importing patrons, any patron may or may not have a verified
email address. So I think you just include it as a patron attribute when
importing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420

--- Comment #19 from David Cook  ---
I'll keep working on my different auth patches as well.

At this point, I think that I could probably do a generic OpenID Connect client
just using a Koha Plugin, but I'd like to make some Koha changes too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467

David Nind  changed:

   What|Removed |Added

  Text to go in the||This improves the wording
  release notes||for the
   ||TrackLastPatronActivity
   ||system preference to
   ||reflect that the 'last
   ||seen' date updates when a
   ||patron logs into the OPAC
   ||or connects using SIP.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420

--- Comment #18 from David Cook  ---
(In reply to mark.jaroski from comment #17)
> In any case, this is probably not the *right* way to do it. But it's fast,
> and probably does no real harm since whatever problems it has are the same
> as the ones with the google version.
> 
> Make sense?

Oh yes I understand that. Personally, I was always against the Google version
;). But I hadn't prioritized upstreaming my own OpenID Connect client (which
itself isn't perfect either of course), so I couldn't complain too much. 

Personally, I'm not really keen to have a Google version and an Azure version.
I rather just have 1 generic version. But I won't stand in the way of someone
else signing off and QAing this enhancement. 

You might want to sign up to the koha-devel listserv if you haven't already
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel. That can
be a good place to try to generate interest for patches. 

In the meantime, if you update your patch to do your database update as per
https://wiki.koha-community.org/wiki/Database_updates your patch will have a
better chance of making it through.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

David Nind  changed:

   What|Removed |Added

  Text to go in the||This updates the 'lastseen'
  release notes||date for a patron when
   ||items are checked out (when
   ||TrackLastPatronActivity is
   ||enabled). (The last seen
   ||date is displayed on the
   ||patron details page.)
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

David Nind  changed:

   What|Removed |Added

 Attachment #121609|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 121618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121618=edit
Bug 28455: Update wording on TrackLastPatronActivity

This patch updates the wording on TrackLackPatronActivity to maintain the
corrections from bug 28467 and also reflect the change made in this bug. It
should now read: The first time each day that a patron either logs into the
OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will
update with the current date and time.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

David Nind  changed:

   What|Removed |Added

 Attachment #121481|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 121617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121617=edit
Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is
enabled

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24539] Build generic authentication module interface

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539

--- Comment #23 from David Cook  ---
(In reply to mark.jaroski from comment #22)
> I don't know enough about Koha to comment on internal workings, but wouldn't
> you always want a session in most authentication situations?

Yep.

> I guess in the Shibboleth scenario you don't need a session because every
> request comes with the server variable or header, but for things like
> OpenID-Connect you don't want to do the handshake for every page load.

I haven't used the built-in Koha Shibboleth integration. I've implemented my
own custom Koha Shibboleth integration, so I can't comment on how Koha does it
by default. But I just do a once off call to the SAML IdP, create a Koha
session, and then use that from there on out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328

--- Comment #1 from Katrin Fischer  ---
What would be the best solution here? 

I think we could limit the max size of 010a via the frameworks. 

But if the LCCN really can be longer than we give them space for now, we should
probably change the data type of the column?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26461] Incorrect handling of hold levels in SIP2 code

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26461

--- Comment #3 from Katrin Fischer  ---
*** Bug 28311 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28311] Holds always placed at biblio level

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28311

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 26461 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503

David Nind  changed:

   What|Removed |Added

 Attachment #121544|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 121616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121616=edit
Bug 28503: Clarify what ReservesControlBranch controls

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503

David Nind  changed:

   What|Removed |Added

 Attachment #121543|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 121615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121615=edit
Bug 28503: Compare item homebranch to patron branch when hold policy set to
'from_home_library'

This fixes an issue in the way we calculate the check for hold policy
'from_home_library'

Currently we change the comparison based on ReservesControlBranch, however,
that should
only control the rule we fetch, not how we compare

When ReservesControlBranch is set to "patron's home library" we compare the
patron's branch to
the patron's branch, this is useless and means we pass the check for all
branches all of the time

We should instead compare the patron's branch to the item's branch, and only
fetch the rule using ReservesControlBranch

To test:
 1 - Have a record with an item from library A and library B
 2 - Set the 'Default checkout, hold and return policy'->Hold policy->From home
library for all libraries
 and ensure you have no branch specific/itemtype specific rules set
 3 - Attempt to place a hold on the record for a patron from library B
 4 - Note that only the library B item is holdable - place a title level hold
(do not choose an item)
 5 - Check in the item from library A
 6 - It fills the hold - This is incorrect - ignore the hold
 7 - Apply patch
 8 - Restart all the things
 9 - Check in the item from library A
10 - No hold found
11 - Check in the item from library B
12 - Hold found, correctly

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503

David Nind  changed:

   What|Removed |Added

 Attachment #121542|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 121614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121614=edit
Bug 28503: Unit tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852

--- Comment #1 from Katrin Fischer  ---
Verified in master, that HTML is still escaped in messages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852

Katrin Fischer  changed:

   What|Removed |Added

Version|17.05   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336

--- Comment #4 from Katrin Fischer  ---
I imagine a different fix could be on pl side - we could set the variable when
handling an authority import. Not sure if this would be more practical?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #120893|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 121613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121613=edit
Bug 28336: Add missing input for item_action

To test:
1 - Stage a marc file of authorities
2 - Manage the staged file
3 - Attempt to change the matching rule
4 - 500 Error, in intranet-error.log:
[Wed May 12 16:53:03.046652 2021] [cgi:error] [pid 52072] [client
172.19.0.1:50580] AH01215: C4::ImportBatch::SetImportBatchItemAction(): DBI
Exception: DBD::mysql::st execute failed: Column 'item_action' cannot be null
[for Statement "UPDATE import_batches SET item_action = ? WHERE import_batch_id
= ?" with ParamValues: 0=undef, 1="1"] at
/kohadevbox/koha/tools/manage-marc-import.pl line 160:
/kohadevbox/koha/tools/manage-marc-import.pl, referer:
http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1
5 - Apply patch
6 - Reload page and change matching rule
7 - Success!

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336

--- Comment #2 from Katrin Fischer  ---
I could not replicate the database error, but I can confirm that this warn is
fixed by the patch and the behaviour is improved:

[Thu Jun 03 22:49:45.840349 2021] [cgi:error] [pid 12799] [client
10.0.2.2:55280] AH01215: Use of uninitialized value $item_action in string ne
at /home/vagrant/kohaclone/tools/manage-marc-import.pl line 159.:
/home/vagrant/kohaclone/tools/manage-marc-import.pl, referer:
http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12733] Interactive inventory tool

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733

--- Comment #7 from Katrin Fischer  ---
(In reply to Hannah Co from comment #6)
> I created a plugin that does scan-as-you-go shelf reading and inventory
> updating. https://github.com/hmconorthwestu/koha-plugin-shelfreading
> 
> The sorting is across the whole group of scanned items, not a simple
> comparison to previous or next items, which can mark order incorrectly when
> shelves get too scrambled. The plugin probably needs DDC sorting added, as
> my library only uses LCC and alphanumeric classification.
> 
> I have a brief description on github, with more details, but I'm happy to
> answer any questions about it.

Hi Hannah, I've added your plugin to the plugin list on the wiki:
https://wiki.koha-community.org/wiki/Koha_plugins#Plugins
Please feel free to add more!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #133 from David Nind  ---
Created attachment 121612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121612=edit
Test fails for holds - 2021-06-04

I've attached the test results for prove -v t/db_dependent/Holds.t after the
patch is applied - it passed before the patch was applied.

I'm testing on a MARC21 installation, does this need to be a UNIMARC setup?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22956] Omnibus: Remove type attribute from script tags

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Katrin Fischer  ---
Looks like we are done here? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23908] Require patrons to confirm their email address

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908

--- Comment #4 from Katrin Fischer  ---
(In reply to Christopher Brannon from comment #0)
> Dead e-mails are a pain to deal with.
> 
> It would be great if e-mail notifications were verified, regardless of
> registering online or in person.  If an e-mail address is entered by staff,
> Koha should have a flag to indicate if the address has been verified.  When
> an account is saved or updated, it should check if an e-mail address has
> been entered.  If so, if it has not been verified, it should send a
> verification e-mail to the address.  When the patron receives it, they
> should have to click something or login to complete the verification.  The
> address is marked in their account as verified.  If the address is changed
> at all, they have to re-verify.
> 
> Staff who receive notice that the e-mail has problems (dead, full, etc)
> should have a flag they can set on the account to mark the address as bad,
> and the reason why.  The patron would then have to supply a new e-mail
> address and verify again.  While the account is flagged with a bad e-mail,
> notifications to that address should be turned off.  If they have another
> form of notification, Koha could send them a notification that the e-mail
> address they supplied is no longer working, and needs to be corrected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23908] Require patrons to confirm their email address

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908

Katrin Fischer  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Katrin Fischer  ---
*** Bug 28357 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28357] E-mail Verification

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28357

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer  ---
I believe this is very similar to bug 23908 and both have good ideas. I am
copying the comment from here to there and mark them as duplicate.

*** This bug has been marked as a duplicate of bug 23908 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28360] Link to make article reqests should display on detail page when user is not logged in

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360

--- Comment #1 from Katrin Fischer  ---
I just retested this in 20.11:

ArticleRequestsLinkControl = Always show

- Result list: Article request link always shows
- Detail page: Article request link only shows when logged in

I think this is because of the check on the artreqpossible template variable -
I suspect it can only be 1 if the user is logged in:

my $artreqpossible = $patron
? $biblio->can_article_request( $patron )
: $itemtype
? $itemtype->may_article_request
: q{};
$template->param( artreqpossible => $artreqpossible );

The code for the same variable in the result list is certainly different, but
completely mysterious to me:

# BZ17530: 'Intelligent' guess if result can be article requested
$res->{artreqpossible} = ( $art_req_itypes->{ $res->{itemtype} // q{} } ||
$art_req_itypes->{ '*' } ) ? 1 : q{};

I am not sure how to fix this :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220

--- Comment #8 from Katrin Fischer  ---
Sorry, Matts, I can't get this to work.

- I've made sure to search for all different terms
- The field I want to delete is still there after I imported the record

We really need someone else to give this a try.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28373] Items fields not used in default XSLT

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

--- Comment #12 from Katrin Fischer  ---
Tested OPAC, intranet and list result lists. 

You might want to add a unit test for QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28373] Items fields not used in default XSLT

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

--- Comment #11 from Katrin Fischer  ---
Created attachment 121611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121611=edit
Bug 28373: (QA follow-up) Fix typo in system preference description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28373] Items fields not used in default XSLT

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #121115|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 121610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121610=edit
Bug 28373: Add PassItemMarcToXSLT system preference

Default stylesheets do not reference item fields for XSLT display, however, we
spend time translating the values in the item fields.

This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we
remove
item fields before processing

To test:
1 - Perform some search on the staff client and opac
2 - Use the console (F12) to view the time spent on the network tab
3 - Note performance
4 - Apply patch, updatedatabase, restart_all
5 - Repeat searches
6 - Note that display has not changed
7 - Note performance, results should display slightly faster

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28373] Items fields not used in default XSLT

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

Katrin Fischer  changed:

   What|Removed |Added

Version|20.11   |master

--- Comment #1 from Katrin Fischer  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

--- Comment #25 from Katrin Fischer  ---
*** Bug 27774 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27774] Always remove hyphens from ISBN when cataloging

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 6590 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

--- Comment #6 from Andrew Fuerste-Henry  ---
I added a patch to update the syspref and set this back to Needs Signoff.
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Katrin Fischer  changed:

   What|Removed |Added

Summary|Removing hyphens from isbn  |Removing hyphens from ISBN
   |and issn when cataloging a  |and ISSN when cataloging a
   |biblio  |biblio

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

--- Comment #5 from Andrew Fuerste-Henry  ---
Created attachment 121609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121609=edit
Bug 28455: Update wording on TrackLastPatronActivity

This patch updates the wording on TrackLackPatronActivity to maintain the
corrections from bug 28467 and also reflect the change made in this bug. It
should now read: The first time each day that a patron either logs into the
OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will
update with the current date and time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28439] Add ability to suspend club enrollments

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28439

--- Comment #1 from Katrin Fischer  ---
I had a similar request for routing lists a while ago - linking as see also.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28439] Add ability to suspend club enrollments

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28439

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22591

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22591] Allow to temporarily suspend patrons from routing lists

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22591

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28439
Summary|Allow to temporarily|Allow to temporarily
   |exclude patrons from|suspend patrons from
   |routing lists   |routing lists

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Katrin Fischer  ---
Hi Nick, this reads well. Could you please change the OPAC results file as
well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27949] Batch printing of article request slips

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

--- Comment #1 from Agustín Moyano  ---
Created attachment 121608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121608=edit
Bug 27949: Allow multiple article requests print slip

This bug allows for batch printing of multiple article requests slips

To test:
1. apply this patch
2. restart_all
3. enable ArticleRequests preference
4. create multiple article requests
5. go to circ/article-requests.pl in staff interface
6. print a single slip from a row
CHECK => it works as expected
7. select all rows and print slip from general actions menu (above the table)
SUCCESS => all article requests slips are printed
8. select multiple rows (not all) and print slip from general actions menu
(above the table)
SUCCESS => only selected article requests slips are printed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27949] Batch printing of article request slips

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Agustín Moyano  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28497] Display city and zipcode as part of address on user search summary

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Katrin Fischer  ---
No problem at all! I sometimes file bugs for older versions too to
check/confirm later, better than to have things get lost.

Acosta, Edna

7896 Library Rd.
Portland, OR 44240

Is what I see in the list now - I'll mark the bug as resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25614] "Clear filter" button permanently disabled on ILL request list

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||28444


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28444
[Bug 28444] Filter/search box missing above main ILL table on 20.11
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28444] Filter/search box missing above main ILL table on 20.11

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28444

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED
 Depends on||25614

--- Comment #3 from Katrin Fischer  ---
I can confirm the change on a 20.11.06 installation as well.

I think this was an intentional change caused by bug 25614:

 - The table of requests should display without a search form or "clear
   filter" button at the top.
 - The left-hand sidebar form should now have a "keyword" filter option
   which searches any column in the table.
 - Other filter fields should work as before.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614
[Bug 25614] "Clear filter" button permanently disabled on ILL request list
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28497] Display city and zipcode as part of address on user search summary

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497

--- Comment #2 from David Roberts  ---
Hi Katrin, actually you might be right. I was working on this page:

https://snipboard.io/ANyRQE.jpg

However, this is on a 19.11 system so it looks like it might have been fixed in
later versions. Sorry about that - I should have checked better!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28446] Fix encoding of OverDrive content on Your summary, OverDrive Account

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446

--- Comment #2 from Katrin Fischer  ---
Hm, not sure how this can be tested easily - those with Overdrive accounts
might not have the required material with special characters. Magnus, do you
have someone who could test this maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28458] Prefill vendor in "Add from subscription" form

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28458

--- Comment #1 from Katrin Fischer  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12316] Can't put text and other information on barcode labels

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12316

Katrin Fischer  changed:

   What|Removed |Added

Summary|Can't put text on barcode   |Can't put text and other
   |label   |information on barcode
   ||labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12316] Can't put text on barcode label

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12316

Katrin Fischer  changed:

   What|Removed |Added

Summary|can't put text on barcode   |Can't put text on barcode
   |label   |label
   Severity|normal  |enhancement

--- Comment #3 from Katrin Fischer  ---
It appears that 'barcode' only prints a barcode and the number below and
nothing else which is set up in the list of fields, may it be text or a field
from the database.

So I am changing this to an enhancement request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Katrin Fischer  changed:

   What|Removed |Added

  Component|Cataloging  |Searching - Elasticsearch
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined)

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #1 from Katrin Fischer  ---
Confirmed on /cgi-bin/koha/sco/sco-main.pl

I wonder if this could affect translations, as __( is used for Javascript
translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28491] field 003 not updated after import

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491

Katrin Fischer  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #1 from Katrin Fischer  ---
I am adding Marcel as I know he has been working some on the code we talk about
here. 

My opinion would be to overwrite with MarcOrgCode or empty 003 when we add the
Koha number there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28497] Display city and zipcode as part of address on user search summary

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497

--- Comment #1 from Katrin Fischer  ---
Hi David, I just checked on master and the city and zip code do show for me in
the patron search result list. But I am a little confused by the path you gave,
am I looking in the wrong place?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27949] Batch printing of article request slips

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28440] Inventory tool tries to put a time into DateLastSeen

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28440

--- Comment #4 from Katrin Fischer  ---
I've tried to replicate the issue on master, but it all seemed to work alright.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28367] Wrong plack condition in C4/Auth_with_shibboleth.pm

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12,
released in|19.11.18-2  |19.11.19

--- Comment #10 from Victor Grousset/tuxayo  ---
And I mixed up the patches. It will be for v19.11.19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28506] Editing purchase suggestion with no library or item type does not save edits

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28506

--- Comment #1 from Katrin Fischer  ---
I don't manage to add a suggestion without a library in the staff interface, it
always reverts the pull down to my logged in library (I think it shouldn't and
feel like we had fixed that before?)

The Document type list doesn't offer an empty entry by default.

Otherwise, all changes I made to the suggestion, did save.

Donna, can you share more details on your configuration?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12,
released in|19.11.18|19.11.18-2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28367] Wrong plack condition in C4/Auth_with_shibboleth.pm

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12,
released in|19.11.18|19.11.18-2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28367] Wrong plack condition in C4/Auth_with_shibboleth.pm

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367

--- Comment #9 from Victor Grousset/tuxayo  ---
Actually it was for v19.11.18-2, a micro release to contain this last moment
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >