[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Lucas Gass changed: What|Removed |Added Attachment #122188|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Lucas Gass changed: What|Removed |Added Attachment #122189|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 122191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122191=edit Bug 28604: Prevent double encoding of MARC::Record::MiJ->to_mij output This patch fixes a double-encoding issue with MiJ output. Mojolicious' *text* renderer encodes the passed information according to the request context. [1] MARC::Record::MiJ->to_mij, conveniently encodes the string before output [2]. This causes double encoding. So the solution to this situation, is to use the *data* renderer, which doesn't perform any encoding [3]. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests contain diacritics and fail! 3. Have a record with diacritics 4. Try the API routes for fetching a biblio: $ curl --location --request GET 'http://localhost:8080/api/v1/public/biblios/144' \ --header 'Accept: application/marc-in-json' (replace the record id with the one you've chosen) => FAIL: Boo, double encoding 5. Bonus point: you can try it on the non-public route, but you need more configuration boilerplate (basic auth, permissions). If you look at the fix, you will understand the tests cover it and no need to complicate yourself. 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! 8. Repeat 4 (and maybe 5) => SUCCESS: No double encoding! Yay! 9. Sign off :-D [1] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-text [2] https://metacpan.org/dist/MARC-File-MiJ/source/lib/MARC/Record/MiJ.pm#L111 [3] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-data Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #3 from Lucas Gass --- Created attachment 122190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122190=edit Bug 28604: Regression tests This patch introduces regression tests for the encoding issue with MiJ output. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Tomás Cohen Arazi changed: What|Removed |Added Summary|bad encoding when using |Bad encoding when using |marc-in-json|marc-in-json -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 122189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122189=edit Bug 28604: Prevent double encoding of MARC::Record::MiJ->to_mij output This patch fixes a double-encoding issue with MiJ output. Mojolicious' *text* renderer encodes the passed information according to the request context. [1] MARC::Record::MiJ->to_mij, conveniently encodes the string before output [2]. This causes double encoding. So the solution to this situation, is to use the *data* renderer, which doesn't perform any encoding [3]. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests contain diacritics and fail! 3. Have a record with diacritics 4. Try the API routes for fetching a biblio: $ curl --location --request GET 'http://localhost:8080/api/v1/public/biblios/144' \ --header 'Accept: application/marc-in-json' (replace the record id with the one you've chosen) => FAIL: Boo, double encoding 5. Bonus point: you can try it on the non-public route, but you need more configuration boilerplate (basic auth, permissions). If you look at the fix, you will understand the tests cover it and no need to complicate yourself. 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! 8. Repeat 4 (and maybe 5) => SUCCESS: No double encoding! Yay! 9. Sign off :-D [1] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-text [2] https://metacpan.org/dist/MARC-File-MiJ/source/lib/MARC/Record/MiJ.pm#L111 [3] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-data Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122188=edit Bug 28604: Regression tests This patch introduces regression tests for the encoding issue with MiJ output. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What|Removed |Added Attachment #122091|0 |1 is obsolete|| --- Comment #167 from David Nind --- Created attachment 122187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122187=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali Signed-off-by: Salman Ali Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What|Removed |Added Attachment #122090|0 |1 is obsolete|| --- Comment #166 from David Nind --- Created attachment 122186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122186=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What|Removed |Added Attachment #122089|0 |1 is obsolete|| --- Comment #165 from David Nind --- Created attachment 122185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122185=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What|Removed |Added Attachment #122088|0 |1 is obsolete|| --- Comment #164 from David Nind --- Created attachment 122184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122184=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 David Nind changed: What|Removed |Added Attachment #122135|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 122183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122183=edit Bug 28598: Update DateFormat and TimeFormat descriptions to remove warnings To test, confirm that the warnings are present without the patch and gone with it. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 David Nind changed: What|Removed |Added Attachment #122177|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 122182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122182=edit Bug 28603: Encode spaces in urls in url checker To test: 1 - Add a url to a record like: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street%20shuffle 2 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street shuffle 596 Connection timed out 5 - Apply patch 6 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 7 - grep shuffle test.txt 8 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street%20shuffle 200 OK Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] New: bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Bug ID: 28604 Summary: bad encoding when using marc-in-json Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com There are some UTF-8 encoding problems when using marc-in-json that have diacritics in them, I encountered this when using the '/api/v1/public/biblios/' API route. To recreate: -Add some diacritics to a MARC field, I am using the 538$a and added the note 'Tést nöte'. -Look at the what the API returns, I used this: curl --location --request GET 'http://localhost:8080/api/v1/public/biblios/144' \ --header 'Accept: application/marc-in-json' The 538$a note comes out looking like this: Tést nöte -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What|Removed |Added Attachment #122176|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 122181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122181=edit Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What|Removed |Added Attachment #122175|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 122180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122180=edit Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What|Removed |Added Attachment #122174|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 122179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122179=edit Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 David Nind changed: What|Removed |Added Text to go in the||Previously overdue notices release notes||exclusively used the ||default language, but bug ||26420 changed this to the ||opposite - to exclusively ||use the language chosen by ||the patron. || ||However, if ||there is no translation for ||the overdue notice for the ||language chosen by the ||patron then no message is ||sent. || ||This fixes this so ||that if there is no ||translation of the overdue ||notice for the language ||chosen by the patron, then ||the default language notice ||is used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28597] Opac suggestions do not display news for logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 David Nind changed: What|Removed |Added Attachment #122133|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 122178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122178=edit Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions To test: 1 - Set two news items with location 'OpacSuggestioninstructions' 2 - One should be for all libraries 3 - One should be for a specific library 4 - Sign in to opac with user from the specific library 5 - Add a suggestion 6 - The instructions only show the all libraries item 7 - Apply patch 8 - Reload 9 - All libraries and specific library items are shown 10 - Allow anonymous suggestions: AnonSuggestions - Allow 11 - Sign out of opac 12 - Add a suggestion 13 - Only all librares news is visible Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28597] Opac suggestions do not display news for logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 --- Comment #1 from Nick Clemens --- Created attachment 122177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122177=edit Bug 28603: Encode spaces in urls in url checker To test: 1 - Add a url to a record like: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street%20shuffle 2 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street shuffle 596 Connection timed out 5 - Apply patch 6 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 7 - grep shuffle test.txt 8 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street%20shuffle 200 OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 122176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122176=edit Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 122175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122175=edit Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122174=edit Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Blocks||28593, 28595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] New: check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Bug ID: 28603 Summary: check-url-quick.pl does not encode spaces in urls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz To recreate: 1 - Add an 856$u to a record with: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street shuffle 2 - perl misc/cronjobs/check-url-quick.pl > test.txt 2>&1 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street shuffle 596 Connection timed out 'URL' => 'http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street shuffle' 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti=street shuffle 596 Connection timed out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 Tomás Cohen Arazi changed: What|Removed |Added Depends on|28271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Tomás Cohen Arazi changed: What|Removed |Added Depends on|28271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What|Removed |Added Blocks|28593, 28595| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 David Nind changed: What|Removed |Added Attachment #122039|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 122173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122173=edit Bug 28571: Remove C4::Auth::_session_log It's not used and must be removed Test plan: % git grep _session_log must not return any result. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes the breadcrumb release notes||link to the the staff ||interface home page from ||the circulation area - it ||now links correctly to the ||staff interface home page, ||rather than the circulation ||page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 David Nind changed: What|Removed |Added Attachment #122165|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 122172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122172=edit Bug 28601: Fix 'Home' breadcrumd on circulation-home.pl To test: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home 4 - Apply patch 5 - reload page 6 - Click 'Home' 7 - Success! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28600] Variable "$patron" is not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 122171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122171=edit Bug 28600: Resolve variable scope issue This patch fixes a scope issue. Originally, a variable declared as our $borcat was replaced by my $patron This patch makes the method not rely on global variables, but have a parameter for the patron, and thus things are clearer. To test: 1. Open the OPAC detail page for a record => FAIL: The logs show some errors about the $patron variable not available in the scope 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--- Comment #2 from David Nind ---
I attempted to test this.
With MySQL 8 I was able to get this to work following the test plan (starting
KTD with ku=my8).
However, if I change back to MariaDB (starting KTD with ku) I get a different
error message:
CGI::Compile::ROOT::kohadevbox_koha_reports_bor_issues_top_2epl::calculate():
DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.borrowers.surname'
isn't in GROUP BY [for Statement "SELECT CONCAT_WS('', borrowers.surname ,
",\t", borrowers.firstname), COUNT(*) AS `RANK`, borrowers.borrowernumber AS
ID FROM `old_issues`
LEFT JOIN borrowers USING(borrowernumber)
LEFT JOINitemsUSING(itemnumber)
LEFT JOIN biblioitems USING(biblioitemnumber)
WHERE old_issues.borrowernumber IS NOT NULL
AND old_issues.issuedate > '2021-06-01' AND
old_issues.issuedate < '2021-06-30' AND old_issues.returndate > '2021-06-01'
AND old_issues.returndate < '2021-06-30' GROUP BY borrowers.borrowernumber
ORDER BY `RANK` DESC LIMIT 5"] at /kohadevbox/koha/reports/bor_issues_top.pl
line 70
at /usr/share/perl5/DBIx/Class/Exception.pm line 77
Testing notes (koha-testing-docker):
- Start KTD with MySQL 8 (rather than MariaDB): ku-my8
- Turn off strict mode
(https://www.linode.com/community/questions/17070/how-can-i-disable-mysql-strict-mode):
. access database container: docker exec -it koha_db_1 bash
. mysql -uroot -ppassword
. SET GLOBAL sql_mode = 'NO_ENGINE_SUBSTITUTION';
. SELECT @@GLOBAL.sql_mode;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #1 from Tomás Cohen Arazi --- This should be done on top of bug 28588, for sure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28600] Variable "$patron" is not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600
--- Comment #1 from Tomás Cohen Arazi ---
Ha, $borcat (which I replaced with $patron) was defined as (our)
-our $borcat= q{};
-if ( C4::Context->preference('OpacHiddenItemsExceptions') ) {
-$borcat = $patron ? $patron->categorycode : q{};
-}
I guess I overlooked it. Patch coming.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26838] Improve styling of checkin message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Nick Clemens changed: What|Removed |Added Attachment #121809|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 122170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122170=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26838] Improve styling of checkin message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28586] Cannot resolve a claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind changed: What|Removed |Added Text to go in the||This fixes an issue with release notes||the 'Returned claims' ||feature (enabled by setting ||a value for ||ClaimReturnedLostValue)- ||resolving returned claims ||now works as expected. || ||Before this fix, an attempt ||to resolve a claim resulted ||in the page hanging and the ||claim not being able to be ||resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28602] New: Circulate multiple items with one barcode in a bookbag or kit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28602 Bug ID: 28602 Summary: Circulate multiple items with one barcode in a bookbag or kit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Some libraries group multiple items into one kit or bag. Scanning one barcode for the kit into circulation results in a checkout for each attached item. Items grouped into a kits are not assumed to be on the same bib record. Individual items may or may not also have their own barcodes and could be checked out individually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What|Removed |Added Attachment #122117|0 |1 is obsolete|| --- Comment #12 from Andrew Isherwood --- Created attachment 122169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122169=edit Bug 27170: Fix bug fix This commit fixes the incorrect bug fix from the previous commit Signed-off-by: Holly Cooper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What|Removed |Added Attachment #122115|0 |1 is obsolete|| --- Comment #11 from Andrew Isherwood --- Created attachment 122168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122168=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. Signed-off-by: Holly Cooper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What|Removed |Added Attachment #122114|0 |1 is obsolete|| --- Comment #10 from Andrew Isherwood --- Created attachment 122167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122167=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. Signed-off-by: Holly Cooper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 --- Comment #7 from Lucas Gass --- Created attachment 122166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122166=edit Bug 28127: [20.05.x] Add transaction timestamp to register details tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #63 from Martin Renvoize --- This has moved a bit.. looking good. I wonder about the --force option we've introduced a little.. might be good to have a 'force_once' or something so allow the user to pick to ignore the first error but have subsequent errors still catch. Generally, I think I'm happy here.. I do think Julians $report way of doing multi-line description blocks is cleaner looking somehow.. and I can see his point about passing dbh rather than suggesting we rely on C4::Context.. it is somewhat future-proofing (and it's a familiar concept to me to pass dbh around this way as it's how DBIx::Class::DeploymentHandler does it (though in that case.. they often also pass a dbic schema for the before and after upgrade step so you can use dbic during upgrades.. takes some getting used to, but is pretty cool) Also, bug 27880 looks really interesting too.. I hope we could quickly work through that after this.. feels like they lend themselves to being pushed in quick sucession. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 --- Comment #1 from Nick Clemens --- Created attachment 122165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122165=edit Bug 28601: Fix 'Home' breadcrumd on circulation-home.pl To test: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home 4 - Apply patch 5 - reload page 6 - Click 'Home' 7 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] New: Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Bug ID: 28601 Summary: Wrong breadcrumb for 'Home' on circulation-home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To recreate: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.01 released in|| Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com --- Comment #24 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Nick Clemens changed: What|Removed |Added Attachment #121894|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 122164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122164=edit Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You do not even need a NULL value in a authorised value controlled item field, a zero in damaged or withdrawn is enough to trigger the warnings. (Because only the 1 is linked to an authvalue.) Check your plack-opac-error.log before and after applying this change. Signed-off-by: Marcel de Rooy Without the patch I had at least four warnings per item: withdrawn, lost, damaged and notforloan. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Nick Clemens changed: What|Removed |Added Attachment #122145|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 122163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122163=edit Bug 28570: Remove log to /tmp file from bor_issues_top.pl This is unusual and must not be done. Removing it. Test plan: Use the "Home > Reports > Patrons with the most checkouts" report and confirm that it is working correctly after you applied this patch Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #107 from Nick Clemens --- I ran through all I could think of, things look good after these patches and tests pass, code reads well, this is a good early candidate to push for further testing Nice work, Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Nick Clemens changed: What|Removed |Added Attachment #122017|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 122162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122162=edit Bug 28421: Unit Tests This patch adds test test cases for both a Voided Payment and Voided Writeoff. These cases need special handling in the refund process. Test plan 0/ Don't apply 1/ Run t/db_dependent/Koha/Items.t 2/ Prior to this commit the test should pass 3/ Apply this commit but not the dependency(bug 22435) 3/ The test should fail 4/ Bug 22435 should make the test pass again. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #106 from Nick Clemens --- Created attachment 122161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122161=edit Bug 22435: (QA follow-up) Fix test file and adjust test Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121972|0 |1 is obsolete|| --- Comment #105 from Nick Clemens --- Created attachment 122160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122160=edit Bug 22435: Alternative Three - Account Details Another alternative to try, feedback welcome. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121971|0 |1 is obsolete|| --- Comment #104 from Nick Clemens --- Created attachment 122159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122159=edit Bug 22435: Further refinements to account-details table Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121970|0 |1 is obsolete|| --- Comment #103 from Nick Clemens --- Created attachment 122158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122158=edit Bug 22435: Improve database update Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121969|0 |1 is obsolete|| --- Comment #102 from Nick Clemens --- Created attachment 122157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122157=edit Bug 22435: Update accountline-details page to show all history The accountline-details page took a simplistic approach to displaying the history of an accountline. This patch drops the now defunct offset_type_description template block from it's respective include files, and then updates the accountline-details teplate and controller to show a full history of what's happend to the accountlines passed, including creation, increment/decrement, payments, cancellation and voids. Test plan 1/ Create some credits and debits and apply them to each other in various combinations 2/ View the 'Details' page for some of the debit/credits 3/ Compare before patch and after for the Details page. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121968|0 |1 is obsolete|| --- Comment #101 from Nick Clemens --- Created attachment 122156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122156=edit Bug 22435: Update for bug 27049 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121967|0 |1 is obsolete|| --- Comment #100 from Nick Clemens --- Created attachment 122155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122155=edit Bug 22435: Fix _set_found_trigger The _set_found_trigger utilised the 'Writeoff' offset type to distinguish between the application of a writeoff and any other form of offset application. This patch updates the trigger to use the full link through from offset to account credit line to get the credit type being offset. Test plan 1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch, but passes after applying this patch. 2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121966|0 |1 is obsolete|| --- Comment #99 from Nick Clemens --- Created attachment 122154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122154=edit Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121965|0 |1 is obsolete|| --- Comment #98 from Nick Clemens --- Created attachment 122153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122153=edit Bug 22435: Update unit tests This patch updates the unit tests to reflect the changes we have made to offset types. We do two things: 1) Clean up calls to 'apply' to drop passing offset_type 2) Update test code to look for APPLY and CREATE instead of specific offset types. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121964|0 |1 is obsolete|| --- Comment #97 from Nick Clemens --- Created attachment 122152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122152=edit Bug 22435: ->apply() should always use 'APPLY' for offset_type Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121963|0 |1 is obsolete|| --- Comment #96 from Nick Clemens --- Created attachment 122151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122151=edit Bug 22435: Add 'APPLY' to account_offset_types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121962|0 |1 is obsolete|| --- Comment #95 from Nick Clemens --- Created attachment 122150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122150=edit Bug 22435: Use 'CREATE' offset type in Koha::Account::Line This patch updates the Koha::Account::Line methods that result in new account lines to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121961|0 |1 is obsolete|| --- Comment #94 from Nick Clemens --- Created attachment 122149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122149=edit Bug 22435: Use 'CREATE' offset type in Koha::Account This patch updates the Koha::Account methods for adding debits and credits to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Attachment #121960|0 |1 is obsolete|| --- Comment #93 from Nick Clemens --- Created attachment 122148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122148=edit Bug 22435: Update CREATE offset types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #16 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- I'd love to see this backported to 20.05 if possible. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|21.11.00|21.11.00,21.05.01 released in|| --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.01 released in|| Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Version(s)|21.11.00|21.11.00,21.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.01 released in|| Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com Version(s)|21.11.00|21.11.00,21.05.01 released in|| --- Comment #47 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27903] Script to move atomic updates to updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27903 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Very cool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #70 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28589] Move C4 and Koha to lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #5 from Martin Renvoize --- I'd love to see this.. it would certainly move us towards being a bit more 'normal' in the perl world.. might mean we can start adopting other more widely supported perl solutions for other things too.. not sure what, but there's loads of perl tooling out there that expects to find things in '/lib' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart --- (In reply to Fridolin Somers from comment #4) > (In reply to Jonathan Druart from comment #2) > > Please remember: > > - The title of the bug report describes shortly what the *problem is* > > - The title of the patch describes shortly what the *patch does* > > > > https://wiki.koha-community.org/wiki/Commit_messages > > Arf indeed, i'll try to do better Do it please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #8 from Martin Renvoize --- No regressions found.. I went through the patches inspecting what had been removed/replaced and I agree with all the decisions Jonathan made.. be great to get a second opinion from QA, but I don't think there's anything controversial here.. it'll be great to see this go and hopefully it'll encourage a little more use of Koha::Logger by hiding dropping this alternative.. would be great to see more of the bare warns updated too at some point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Great work.. signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
