[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522

--- Comment #12 from Owen Leonard  ---
Created attachment 122933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122933=edit
Bug 27522: (follow-up)  Adding new itemtype info image to carredart

This patch adds a new version of the info icon which was created from
scratch based on the previous version's design.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521

--- Comment #8 from Owen Leonard  ---
Created attachment 122932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122932=edit
Bug 27521: (follow-up) Adding new itemtype headset image for carredart

This patch adds new version of the image which was created based on a
CC0-licensed public domain image:

https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520

--- Comment #9 from Owen Leonard  ---
Created attachment 122931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122931=edit
Bug 27520: Adding new itemtype images boardgame, zoom-in, and zoom-out to
carredart

This patch adds new versions of the images which were created based on
CC0-licensed public domain images:

https://commons.wikimedia.org/wiki/File:Zoom_in_out,_Magnifier_icons.svg
https://commons.wikimedia.org/wiki/File:Domino_tile_vertical-00-05.svg
https://commons.wikimedia.org/wiki/File:Domino_tile_vertical-00-03.svg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #122924|0   |1
is obsolete||

--- Comment #16 from sandbo...@biblibre.com  ---
Created attachment 122930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122930=edit
Bug 25619: Unit Tests

Signed-off-by: Abbey Holt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #122923|0   |1
is obsolete||

--- Comment #15 from sandbo...@biblibre.com  ---
Created attachment 122929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122929=edit
Bug 25619: Add ability to adjust expiration date for waiting holds

There are times when an item that is waiting for pickup needs to have the
expiration date extended. This would give staff the ability to modify one by
one, as needed, the reserves.expirationdate for a given item awaiting pickup.

Test Plan:
1) Place a hold, trap an item for it such that is is waiting
2) Attempt to update the expiration date
3) Note the new date is not saved
4) Apply this patch, restart all the things!
5) Attempt to update the expiration date
6) The new date should be saved!

Signed-off-by: Abbey Holt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679

--- Comment #3 from Lucas Gass  ---
Created attachment 122928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122928=edit
Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is
enabled

This patch corrects the login link in the OPAC when GoogleOpenIDConnect
is enabled. It removes modal-related markup which was causing the link
to fail.

To test, apply the patch and enable the GoogleOpenIDConnect system
preference.

- In the OPAC, click the "Log in to your account" link in the header.
  You should be redirected to a Google authentication form.
- Disable the GoogleOpenIDConnect preference. The login link in the OPAC
  should trigger a modal login form.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Attachment #122921|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 122927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122927=edit
Bug 28717: Add logging logic to koha-news.pl

To test:
1. have some news items
2. make sure NewsLog is turned on
3. Add, modify, and delete some news
4. Check the action logs, nothing is logged
5. Apply patch
6. do step 3 again
7. now changes should be logged
8. make sure you try deleting multiple news items at once and confirm that all
deletions are logged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073

Owen Leonard  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617

--- Comment #6 from Galen Charlton  ---
If you're interested in the history, make yourself a hot beverage of your
choice and read

http://koha.1045719.n5.nabble.com/RFC-installer-changes-td3065475.html

Time marches on, and one of the motivations for having kohalib.pl - making it
possible to install Koha without setting a single environment variable - has
been obviated by the vast improvements in the ease of installing Koha.

Consequently, I think kohalib.pl can go away.

As far as upgrade worries are concerned, a release note advising anybody who is
still actively upgrading ancient Koha systems from tarballs that they should
double-check that PERL5LIB is set in crontabs should suffice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

--- Comment #6 from Lucas Gass  ---

> I think one of the major reasons to log news changes, especially deletions,
> is to offer a means of recovering a deleted entry. Because of that I think
> the full text of the news item should be logged.


Yes, very true. Marking this as FQA and coming back with another patch ASAP :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

--- Comment #5 from Owen Leonard  ---
(In reply to Lucas Gass from comment #4)

> Upon deletion I am just sending
> the ID to the logs. Do we need to also log the content of the deleted news
> item?

I think one of the major reasons to log news changes, especially deletions, is
to offer a means of recovering a deleted entry. Because of that I think the
full text of the news item should be logged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720

--- Comment #1 from Owen Leonard  ---
Created attachment 122926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122926=edit
Screenshot of updated checkout note confirmation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28720] New: Update the process of adding a checkout note in the OPAC

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720

Bug ID: 28720
   Summary: Update the process of adding a checkout note in the
OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 122925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122925=edit
Screenshot of checkout note modal

I'd like to make some changes to the way checkout notes are submitted in the
OPAC:

- The "add note" button will trigger a modal where the user can submit or edit
their message.
- The modal window will contain text explaining that the note will be shown to
staff when the item is checked in.
- The message about a successfully submitted message will have text formatting
added to improve clarity, and include an edit link for re-editing a message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

--- Comment #14 from Kyle M Hall  ---
Created attachment 122924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122924=edit
Bug 25619: Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #122922|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 122923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122923=edit
Bug 25619: Add ability to adjust expiration date for waiting holds

There are times when an item that is waiting for pickup needs to have the
expiration date extended. This would give staff the ability to modify one by
one, as needed, the reserves.expirationdate for a given item awaiting pickup.

Test Plan:
1) Place a hold, trap an item for it such that is is waiting
2) Attempt to update the expiration date
3) Note the new date is not saved
4) Apply this patch, restart all the things!
5) Attempt to update the expiration date
6) The new date should be saved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #147 from Victor Grousset/tuxayo  ---
Does this need more testing? More review?

(it's passed QA)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
   Severity|enhancement |minor
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

--- Comment #12 from Kyle M Hall  ---
Created attachment 122922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122922=edit
Bug 25619: Add ability to adjust expiration date for waiting holds

There are times when an item that is waiting for pickup needs to have the
expiration date extended. This would give staff the ability to modify one by
one, as needed, the reserves.expirationdate for a given item awaiting pickup.

Test Plan:
1) Place a hold, trap an item for it such that is is waiting
2) Attempt to update the expiration date
3) Note the new date is not saved
4) Apply this patch, restart all the things!
5) Attempt to update the expiration date
6) The new date should be saved!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26656] Expiration date on waiting holds appears as editable but changes aren't saved

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26656

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26656] Expiration date on waiting holds appears as editable but changes aren't saved

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26656

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

--- Comment #4 from Lucas Gass  ---
(In reply to Jonathan Druart from comment #2)
> Sorry about that, Lucas!
> 
> I think there is something missing in your patch, the $lang won't be set for
> DELETE. Can you have another look please?

Thanks Jonathan! I submitted a new patch. Upon deletion I am just sending the
ID to the logs. Do we need to also log the content of the deleted news item?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

Lucas Gass  changed:

   What|Removed |Added

 Blocks||28717


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717
[Bug 28717] NewsLog doesn't work
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Depends on||28718


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718
[Bug 28718] Can't delete multiple news items at once
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Depends on|28718   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718
[Bug 28718] Can't delete multiple news items at once
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

Lucas Gass  changed:

   What|Removed |Added

 Blocks|28717   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717
[Bug 28717] NewsLog doesn't work
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

Lucas Gass  changed:

   What|Removed |Added

 Blocks||28717


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717
[Bug 28717] NewsLog doesn't work
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Depends on||28718


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718
[Bug 28718] Can't delete multiple news items at once
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Attachment #122864|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 122921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122921=edit
Bug 28717: Add logging logic to koha-news.pl

To test:
1. have some news items
2. make sure NewsLog is turned on
3. Add, modify, and delete some news
4. Check the action logs, nothing is logged
5. Apply patch
6. do step 3 again
7. now changes should be logged
8. make sure you try deleting multiple news items at once and confirm that all
deletions are logged

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #122919|0   |1
is obsolete||

--- Comment #2 from Alexis Ripetti  ---
Created attachment 122920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122920=edit
Bug 28719: Change somes links in the serials page to avoid them leading to
nothing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719

--- Comment #1 from Alexis Ripetti  ---
Created attachment 122919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122919=edit
Bug 28719: Change somes links in the serials page to avoid them leading to
nothing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719

Alexis Ripetti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28719] New: Cannot edit serials when deleted the selected issues

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719

Bug ID: 28719
   Summary: Cannot edit serials when deleted the selected issues
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexis.ripe...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When you delete the selected issues in the serials page, the 'Edit serials'
button lands to nothing. 
The link becomes '/cgi-bin/koha/serials/serials-collection.pl/serials-edit.pl'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #189 from Martin Renvoize  ---
Just a quick rebase ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122586|0   |1
is obsolete||

--- Comment #188 from Martin Renvoize  ---
Created attachment 122918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122918=edit
Bug 22435: (follow-up) Set CREATE offset for credits to positive

The history view of an accountline shows increases and decreases in the
amount outstanding from the perspective of the credit/debit line you are
inspecting.

Apply creates a negative offset amount which acts to 'reduce' both the
outstanding 'debt' for the debit line and the outstanding 'credit' for
the credit line.  Starting with a negative offset for the credit thus
makes this nonsenical.

Void creates positive offset amounts which act to 'restore' both the
outstanding 'debt' for the debit line and the outstanding 'credit' for
the credit line.

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122571|0   |1
is obsolete||

--- Comment #187 from Martin Renvoize  ---
Created attachment 122917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122917=edit
Bug 22435: (QA follow-up) More test updates

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122570|0   |1
is obsolete||

--- Comment #186 from Martin Renvoize  ---
Created attachment 122916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122916=edit
Bug 22435: (QA follow-up) Fix returned offsets in moredetail

This patch updates the offsets query for lost item returns displayed in
the catalogue/moredetail controller.

Test plan (Same as bug 19919)
Test plan:
1) Pay off a LOST item
2) Check for the associated display of 'Paidfor?:' on the itemdetails page
3) Writeoff a LOST item
4) Check that a 'Paidfor?:' is not displayed on the itemdetails page.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122569|0   |1
is obsolete||

--- Comment #185 from Martin Renvoize  ---
Created attachment 122915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122915=edit
Bug 22435: Update DBIC Schema's

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122568|0   |1
is obsolete||

--- Comment #184 from Martin Renvoize  ---
Created attachment 122914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122914=edit
Bug 22435: (QA follow-up) Fix test for offset total

This patch updates the test for the offset total method to adhere to the
new restricted set of offset types available.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122567|0   |1
is obsolete||

--- Comment #183 from Martin Renvoize  ---
Created attachment 122913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122913=edit
Bug 22435: (QA follow-up) Add missing test for manager relation

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122566|0   |1
is obsolete||

--- Comment #182 from Martin Renvoize  ---
Created attachment 122912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122912=edit
Bug 22435: (follow-up) Drop account_offset_types table

This patch drops the now defunkt account_offset_types table and ensure
the type field in account_offsets is instead an enum type column.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122565|0   |1
is obsolete||

--- Comment #181 from Martin Renvoize  ---
Created attachment 122911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122911=edit
Bug 22435: (follow-up) Update POS for reduced offset types

This patch updates the Koha::Charges::Sales class to use the 'CREATE'
and 'APPLY' offset types.

Test plan
1/ Run t/db_dependent/Koha/Charges/Sales.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122564|0   |1
is obsolete||

--- Comment #180 from Martin Renvoize  ---
Created attachment 122910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122910=edit
Bug 22435: (QA follow-up) Fix test file and adjust test

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122563|0   |1
is obsolete||

--- Comment #179 from Martin Renvoize  ---
Created attachment 122909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122909=edit
Bug 22435: Improve database update

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122562|0   |1
is obsolete||

--- Comment #178 from Martin Renvoize  ---
Created attachment 122908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122908=edit
Bug 22435: Update accountline-details page to show all history

The accountline-details page took a simplistic approach to displaying
the history of an accountline. This patch drops the now defunct
offset_type_description template block from it's respective include
files, and then updates the accountline-details template and controller
to show the full history of what's happend to the accountline passed.
This includes the creation, any increments/decrements (for fines), and
finally any offsets against the total (payments, cancellations, voids).

Test plan
1/ Create some credits and debits and apply them to each other in
various combinations.
2/ View the 'Details' page for some of the debit/credits
3/ Compare before patch and after for the Details page.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122561|0   |1
is obsolete||

--- Comment #177 from Martin Renvoize  ---
Created attachment 122907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122907=edit
Bug 22435: Update for bug 27049

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122560|0   |1
is obsolete||

--- Comment #176 from Martin Renvoize  ---
Created attachment 122906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122906=edit
Bug 22435: Fix _set_found_trigger

The _set_found_trigger utilised the 'Writeoff' offset type to
distinguish between the application of a writeoff and any other form of
offset application.

This patch updates the trigger to use the full link through from offset
to account credit line to get the credit type being offset.

Test plan
1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch,
but passes after applying this patch.
2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both
before and after applying this patch.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122559|0   |1
is obsolete||

--- Comment #175 from Martin Renvoize  ---
Created attachment 122905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122905=edit
Bug 22435: Fix CREATE offset amounts

Updateing the tests highlighted a mistake in the original code.. the
offsets for the cancel and reduce creation lines were incorrectly
signed.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122558|0   |1
is obsolete||

--- Comment #174 from Martin Renvoize  ---
Created attachment 122904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122904=edit
Bug 22435: Update unit tests

This patch updates the unit tests to reflect the changes we have made to
offset types.  We do two things:

1) Clean up calls to 'apply' to drop passing offset_type
2) Update test code to look for APPLY and CREATE instead of specific
   offset types.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122557|0   |1
is obsolete||

--- Comment #173 from Martin Renvoize  ---
Created attachment 122903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122903=edit
Bug 22435: ->apply() should always use 'APPLY' for offset_type

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122556|0   |1
is obsolete||

--- Comment #172 from Martin Renvoize  ---
Created attachment 122902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122902=edit
Bug 22435: Add 'APPLY' to account_offset_types

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122555|0   |1
is obsolete||

--- Comment #171 from Martin Renvoize  ---
Created attachment 122901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122901=edit
Bug 22435: Use 'CREATE' offset type in Koha::Account::Line

This patch updates the Koha::Account::Line methods that result in new account
lines to use the 'CREATE' offset type for the creation record.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122554|0   |1
is obsolete||

--- Comment #170 from Martin Renvoize  ---
Created attachment 122900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122900=edit
Bug 22435: Use 'CREATE' offset type in Koha::Account

This patch updates the Koha::Account methods for adding debits and
credits to use the 'CREATE' offset type for the creation record.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122553|0   |1
is obsolete||

--- Comment #169 from Martin Renvoize  ---
Created attachment 122899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122899=edit
Bug 22435: Update CREATE offset types

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27583] Clarify how cash management fits together

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This enhancement serves to
  release notes||clarify the parts of the
   ||cash management module by
   ||updating the names or pages
   ||and embellishing the
   ||breadcrumb navigation for
   ||these pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Amanda Campbell  changed:

   What|Removed |Added

 CC||acampb...@hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

--- Comment #1 from Lucas Gass  ---
Created attachment 122898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122898=edit
Bug 28718: handle multiple deletions from news

To test:
1. have multiple news
2. check several of them and and click 'Delete selected'
3. see ugly error
4. apply patch
5. try again
6. no error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Lucas Gass  changed:

   What|Removed |Added

 Blocks||28718


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718
[Bug 28718] Can't delete multiple news items at once
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

Lucas Gass  changed:

   What|Removed |Added

 Depends on||22544


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
[Bug 22544] Move C4:NewsChannels to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28718] New: Can't delete multiple news items at once

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718

Bug ID: 28718
   Summary: Can't delete multiple news items at once
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

1. have multiple news
2. check several of them and and click 'Delete selected'
3. see ugly error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #505 from Martin Renvoize  ---
OK, Prior to bug 17600 I found this working.. so signed off.. but having
rebased it for bug 17600 (so I could work on bug 28715 I couldn't get it
working again.

I can
1) Enable the new preference
2) Add a holding record to an existing bib
3) Add an item to the bib...

But.. I can no longer pick the 'Holding' to relate the item to.. either via
editing an existing item or adding a new one.

I'm stuck, can't see in the code where this is going wrong.

Marking as FQA to get authors attention.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #504 from Martin Renvoize  ---
Created attachment 122897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122897=edit
Bug 20447: Fixes for bug 17600

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122856|0   |1
is obsolete||

--- Comment #503 from Martin Renvoize  ---
Created attachment 122896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122896=edit
Bug 20447: (QA follow-up) Update for bug 26703

Reverse the title element content as per updated guidelines.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122855|0   |1
is obsolete||

--- Comment #502 from Martin Renvoize  ---
Created attachment 122895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122895=edit
Bug 20447: DBIX schema changes

Rebased-by: Andrew Nugged 
Rebased-by: Joonas Kylmälä 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122854|0   |1
is obsolete||

--- Comment #501 from Martin Renvoize  ---
Created attachment 122894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122894=edit
Bug 20447: Add import/export support for holdings

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Adds support for importing and exporting biblios with interleaved holdings.

Test plan:

1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

2.) Verify that the holdings records were imported.

3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings

4.) Verify that both bibliographic and holding records are exported.

5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122853|0   |1
is obsolete||

--- Comment #500 from Martin Renvoize  ---
Created attachment 122893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122893=edit
Bug 20447: Add a batch rebuild script for holdings table

This script can be used to update the columns in the holdings table from the
MARC record using the rules in the framework. In practice this will only be
required if the koha link field is changed in the framework.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122852|0   |1
is obsolete||

--- Comment #499 from Martin Renvoize  ---
Created attachment 122892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122892=edit
Bug 20447: Add holding_id to REST API item definition

Allows items to be properly returned, including the holding_id field.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122851|0   |1
is obsolete||

--- Comment #498 from Martin Renvoize  ---
Created attachment 122891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122891=edit
Bug 20447: MARC Holdings support

Enable by setting "SummaryHoldings" option to "Use".

Sponsored-by: The National Library of Finland
Co-authored-by: Joonas Kylmälä 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #497 from Jonathan Druart  ---
Provide a full test plan and release notes please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28618] Move t/lib modules to lib/Koha/Test

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618
Bug 28618 depends on bug 28636, which changed state.

Bug 28636 Summary: t:lib::Mocks is missing POD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 CC||k...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #5 from Kyle M Hall  ---
Not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28177] Add date column and column configuration to uploads

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||k...@bywatersolutions.com
 Status|Pushed to master|RESOLVED

--- Comment #8 from Kyle M Hall  ---
Enhancement not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28177] Add date column and column configuration to uploads

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177
Bug 28177 depends on bug 28175, which changed state.

Bug 28175 Summary: Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175

   What|Removed |Added

 Status|Pushed to master|CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28175] Usability improvements to uploads page

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|CLOSED
 Resolution|--- |FIXED

--- Comment #11 from Kyle M Hall  ---
Enhancement not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073
Bug 28073 depends on bug 27873, which changed state.

Bug 27873 Summary: Make display of patron restrictions, charges, notes, etc. 
consistent for check out and patron details screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from Kyle M Hall  ---
Not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28662] Not possible to log out of patron account in OPAC with JavaScript disabled

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662
Bug 28662 depends on bug 27445, which changed state.

Bug 27445 Summary: OPAC header tweaks for non-JavaScript users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27445] OPAC header tweaks for non-JavaScript users

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Kyle M Hall  ---
Not pushed for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Performance patch, backported to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27985] Add option for using a MARC modification template on a single record from the details page

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27985

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||k...@bywatersolutions.com
 Status|Pushed to master|RESOLVED

--- Comment #5 from Kyle M Hall  ---
Not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27662] Can't send list e-mail from OPAC / Unable to parse OpacHiddenItems syspref

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27662

--- Comment #23 from Jonathan Druart  ---
If your error is: "opac-sendshelf.pl: Error sending mail: Connection error from
srvrelay.urosario.edu on port 25" then I bet you know what you should do. There
is a connection error with your SMTP server.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record?

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

--- Comment #72 from Kyle M Hall  ---
Not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27662] Can't send list e-mail from OPAC / Unable to parse OpacHiddenItems syspref

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27662

--- Comment #22 from Jonathan Druart  ---
(In reply to Jonathan Cuéllar from comment #21)
> Hello,
> 
> The 500 error continues, it tells me that the requested page is not
> available, when I try to send a list by mail.

Run
  % tail -f /var/log/koha/$KOHA_INSTANCE/*.log

Then hit the problematic page and copy here the relevant error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606

Jonathan Druart  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #20 from Jonathan Druart  ---
*** Bug 28699 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||jonathan.druart+koha@gmail.
   ||com
 Status|Passed QA   |RESOLVED

--- Comment #5 from Jonathan Druart  ---
I fixed that earlier this week with a follow-up on bug 28606
  commit af7e41d1142573666d302a8475274ea58e5c99f4
  Bug 28606: Remove warning from C4::Auth 887

*** This bug has been marked as a duplicate of bug 28606 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #496 from Jonathan Druart  ---
Starting a new script (addholding.pl) copying addbiblio.pl was not the best
idea ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27662] Can't send list e-mail from OPAC / Unable to parse OpacHiddenItems syspref

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27662

--- Comment #21 from Jonathan Cuéllar  ---
Hello,

The 500 error continues, it tells me that the requested page is not available,
when I try to send a list by mail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >