[Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #15 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||

--- Comment #10 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00|21.11.00,21.05.03
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28662] Not possible to log out of patron account in OPAC with JavaScript disabled

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Ah dependency Bug 27445 is not in 21.05.x but this one is.

In any case I dont push to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||

--- Comment #9 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||

--- Comment #14 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02,20.11.09  |21.11.00,21.05.02
released in||
 Status|Pushed to oldstable |ASSIGNED

--- Comment #13 from Fridolin Somers  ---
Arf breaks test suite :

t/db_dependent/api/v1/patrons.t .. 
#   Failed test 'exact match for JSON Pointer "/0/cardnumber"'
#   at t/db_dependent/api/v1/patrons.t line 66.
#  got: '1'
# expected: 'O_HBrhYpvfsZOtvfyC'
# Looks like you failed 1 test of 16.

#   Failed test 'librarian access tests'
#   at t/db_dependent/api/v1/patrons.t line 84.
# Looks like you failed 1 test of 2.
t/db_dependent/api/v1/patrons.t .. 1/7 
#   Failed test 'list() tests'
#   at t/db_dependent/api/v1/patrons.t line 85.
t/db_dependent/api/v1/patrons.t .. 5/7 # Looks like you failed 1 test of 7.
t/db_dependent/api/v1/patrons.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 

Test Summary Report
---
t/db_dependent/api/v1/patrons.t (Wstat: 256 Tests: 7 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=7,  7 wallclock secs ( 0.03 usr  0.00 sys +  6.59 cusr  0.54
csys =  7.16 CPU)
Result: FAIL

So I revert from 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
Did you put "No" as a value in the 942$n?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28801] New: OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

Bug ID: 28801
   Summary: OpacSuppression prevents retrieval of non-suppressed
titles that contain punctuation
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: Other
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: tasha.kea...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Overview: OpacSuppression toggled to "hide" reliably prevents results from
being retrieved in the OPAC when titles (245$a) contain punctuation (in my
catalog, these are mostly hyphens/dashes and parentheses).  Punctuated titles
are retrievable until I toggle OpacSuppression to "hide", despite having their
942$n set to "n Suppress in OPAC No" (Titles that do have 942$n set to "yes"
are suppressed as expected and labelled as such in the intranet).  


Steps to Reproduce:

Note: I was working in a clean Koha install, with no MARC records, where the
only Global System Preference toggled was SearchEngine (to use Elasticsearch).

1. I created a record using the Fast Add framework, with title "Test punctuated
(TST-123) title", and only required fields populated

2. In the OPAC, I searched for and successfully retrieved the title using the
"Library catalog" search option

3. I toggled OpacSuppression to "Hide", then used Ctrl+F5 to refresh the
browser

4. In the OPAC, I repeated the "Library catalog" search

Actual Results: 

"No results found!
No results found for that in catalog."

Expected Results: 

I expected the title to be retrieved.

Build Date & Hardware: 
I believe you're looking for this info:  Linux 5.4.17-2011.6.2.el7uek.x86_64 #2
SMP Thu Sep 3 14:09:14 PDT 2020 x86_64

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to adv search

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622

--- Comment #18 from Fridolin Somers  ---
Depends on Bug 23271 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||28622


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622
[Bug 28622] Selected branchcode incorrectly passed to adv search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to adv search

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Depends on||23271

--- Comment #17 from Fridolin Somers  ---
Depends on Bug 23271 which added do_not_select_my_library param


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271
[Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||

--- Comment #20 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

Viva Elasticsearch ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28747] Clarify wording on RestrictionBlockRenewing syspref

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #11 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator - Patron Search

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

--- Comment #3 from Michael Hafen  ---
Test plan:

1. start a new batch in the patron card creator (Tools -> Patron card creator
-> New -> card batch)
2. click the Add patron(s) button.  Observe that Category and Library are the
only options.
3. Close search for patron window.
4. Apply patch.
5. click the Add patron(s) button.  Observe that you can now search for patrons
by their sort1 and sort2 values.
6. perform a search and observe the 'Select all | Clear all | Add selected
patrons' links and button.
7. use the Select all link to select all the patrons found by the search.
8. use the Add selected patrons button to add the selected patrons to the card
batch's Add by borrowernumber(s) text input field.
9. close the search for patron window.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303

--- Comment #3 from Michael Hafen  ---
Test plan:

1. edit a koha instance's koha-conf.xml to set enable_plugins to 1
1.a   restart memcached service as necessary
2. upload plugin in Administration -> Manage plugins -> Upload plugin
3. plugin will be listed in the Manage plugins page
4. create a directory, for example `mkdir -p /var/lib/koha-common/plugins`
5. edit koha-conf.xml to add a pluginsdir tag pointing to the directory created
in step 4
5.a   restart memcached service as necessary
6. uninstall plugin
7. try to upload plugin again.  Observe error message to verify that the Apache
user can write to the plugins directory.
8. apply patch
9. try to upload plugin again.  It should succeed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28631] Holds History title link returns "not found" error

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.03   |21.11.00,21.05.03,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

> This patch also corrects the breadcrumb markup which didn't conform to the 
> new Bootstrap 4 pattern.
I did not include this change, only fixed the href.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28745] Batch item modifications no longer displayed modified items

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28745

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin Somers  ---
Depends on Bug 28158 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #30 from Fridolin Somers  ---
Depends on Bug 21325 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25515] Remove warnings and errors from tests output

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515
Bug 25515 depends on bug 28483, which changed state.

Bug 28483 Summary: Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Fridolin Somers  ---
Depends on Bug 21260 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #11 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27908] Add support for circulation status 1 ( other ) for damaged items

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27908

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #11 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27907] Add support for circulation status 2 ( on order )

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27907

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #10 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27906] Add support for circulation status 9 ( waiting to be re-shelved )

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27906

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||

--- Comment #11 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26760] Redirect to paycollect.pl when clicking on "Save and pay"

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin Somers  ---
I propose we do not impact older versions behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an undefined value at C4/Reserves.pm line 607

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||

--- Comment #15 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction'

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #10 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28597] OPAC suggestions do not display news for logged in branch

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Fridolin Somers  ---
Depends on Bug 26630 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26630] Allow custom text for each library on the purchase suggestion page

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||28597


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
[Bug 28597] OPAC suggestions do not display news for logged in branch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28597] OPAC suggestions do not display news for logged in branch

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||26630
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Depends on Bug 26630


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630
[Bug 26630] Allow custom text for each library on the purchase suggestion page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #17 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #16 from Fridolin Somers  ---
In this case i my opinion we should rename Koha::Patron::track_login into
track_activity, same for C4::Auth::track_login_daily.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736

David Nind  changed:

   What|Removed |Added

 Attachment #123181|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 123404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123404=edit
Bug 28736: fix requirements for the correct error message to show up

There is existing error message in the code stating:
"Unable to understand your search query, please rephrase and try again."
which fits perfectly but because it looks for "ParseException" in the
warning output it doesn't show up on this page as it's actually
"parse_exception".

This patch makes that it's also checked if "parse_exception" is present
in the warning output.

To reproduce:
1) using ES search for something like "// ^ ! { } [ ] .. , <>" that
will for sure break the syntax of ES.
2) after the search query fails note that the error is
"Unable to perform your search. Please try again."
3) apply the patch
4) search for the same thing again
5) error message should be "Unable to understand your search query,
please rephrase and try again." now.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28611] Incorrect Select2 width

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #9 from Fridolin Somers  ---
It is a big visual change on items editor.
I propose not to impact older versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28299] OpacHiddenItems not working in OPAC lists

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299

--- Comment #29 from Fridolin Somers  ---
Depends on Bug 18989 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #22 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #6 from Fridolin Somers  ---
I think we should not impact olders versions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Fridolin Somers  ---
Depends on Bug 27846 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||28601


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601
[Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||27846
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Introduced by Bug 27846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846
[Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #10 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #40 from Fridolin Somers  ---
Depends on Bug 15986 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26205] News changes aren't logged

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

--- Comment #32 from Fridolin Somers  ---
Does not apply on 20.11.x , mainly because of Bug 14233.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14233] Add logging support to notices and slips management

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26205

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26205] News changes aren't logged

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14233
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798

--- Comment #4 from Lucas Gass  ---
(In reply to Andrew Fuerste-Henry from comment #3)
> I can see the utility of forcing a choice. As Lucas says, I've talked to
> libraries that want this.
> 
> If we're creating a new syspref and monkeying with this field, could we go a
> step further and make the syspref something like OPACHoldPickupDefault with
> the options (Patron home library / Item home library / Item holding library
> / Force a choice).

+1, I like this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #3 from Andrew Fuerste-Henry  ---
I can see the utility of forcing a choice. As Lucas says, I've talked to
libraries that want this.

If we're creating a new syspref and monkeying with this field, could we go a
step further and make the syspref something like OPACHoldPickupDefault with the
options (Patron home library / Item home library / Item holding library / Force
a choice).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Fridolin Somers  ---
I see it is in 21.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds an
  release notes||initial optional
   ||implementation of
   ||two-factor authentication
   ||(2FA) to improve security
   ||when logging into the staff
   ||interface.
   ||
   ||This
   ||implementation uses
   ||time-based, one-time
   ||passwords (TOTP) as the
   ||second factor, letting
   ||librarians use an
   ||application to handle it
   ||and provide them the code
   ||they need when logging in.
   ||
   ||It is enabled using the new
   ||system preference
   ||"TwoFactorAuthentication".
   ||
   ||Librarians can then enable
   ||2FA for their account from
   ||More > Manage Two-Factor
   ||authentication. To setup:
   ||1) Scan the QR code with an
   ||authenticator app. 2) Enter
   ||the one time code
   ||generated. For future
   ||logins, librarians are
   ||prompted to enter the
   ||authenticator code after
   ||entering their normal login
   ||credentials.
   ||
   ||Any
   ||authenticator app, such as
   ||Google Authenticator,
   ||andOTP, and many others can
   ||be used. Applications that
   ||enable backup of their 2FA
   ||accounts (either
   ||cloud-based or automatic)
   ||are recommended.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #9 from Fridolin Somers  ---
Missing dependancies, not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28418] Show template_id of MARC modification templates

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28418

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #9 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #25 from Fridolin Somers  ---
I prefer not impact display on oldstable 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #22 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28264] Transaction type is empty in cash register statistics wizard report

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #14 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #15 from David Nind  ---
Testing notes (koha-testing-docker):
- Tested with Google Authenticator app
- Tested with andOTP app (https://github.com/andOTP/andOTP)
- Everything work as per the test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Attachment #123381|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 123403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123403=edit
Bug 28786: DBIC schema changes

Sponsored-by: Orex Digital

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Attachment #123380|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 123402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123402=edit
Bug 28786: Improve readability in C4::Auth::checkauth

Sponsored-by: Orex Digital

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Attachment #123379|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 123401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123401=edit
Bug 28786: Two-factor authentication for staff client - TOTP

This patchset introduces the Two-factor authentication (2FA) idea in
Koha.

It is far for complete, and only implement one way of doing it, but at
least it's a first step.
The idea here is to offer the librarian user the ability to
enable/disable 2FA when logging in to Koha.

It will use time-based, one-time passwords (TOTP) as the second factor,
an application to handle that will be required.

https://en.wikipedia.org/wiki/Time-based_One-Time_Password

More developements are possible on top of this:
* Send a notice (sms or email) with the code
* Force 2FA for librarians
* Implementation for OPAC
* WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/

Test plan:
 0.
  a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all
  b. To test this you will need an app to generate the TOTP token, you can
 use FreeOTP that is open source and easy to use.
 1. Turn on TwoFactorAuthentication
 2. Go to your account, click 'More' > 'Manage Two-Factor authentication'
 3. Click Enable, scan the QR code with the app, insert the pin code and
 register
 4. Your account now requires 2FA to login!
 5. Notice that you can browse until you logout
 6. Logout
 7. Enter the credential and the pincode provided by the app
 8. Logout
 9. Enter the credential, no pincode
10. Confirm that you are stuck on the second auth form (ie. you cannot
access other Koha pages)
11. Click logout => First login form
12. Enter the credential and the pincode provided by the app

Sponsored-by: Orex Digital

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Attachment #123378|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 123400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123400=edit
Bug 28786: Add controller script and template

Sponsored-by: Orex Digital

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Attachment #123377|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 123399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123399=edit
Bug 28786: Add new DB column borrowers.auth_method

Sponsored-by: Orex Digital

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Attachment #123376|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 123398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123398=edit
Bug 28786: Add new DB column borrowers.secret

Sponsored-by: Orex Digital

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Attachment #123375|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 123397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123397=edit
Bug 28786: Add new syspref TwoFactorAuthentication

Sponsored-by: Orex Digital

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28616] Remove Data::Printer dependency

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616

--- Comment #9 from Fridolin Somers  ---
(In reply to Katrin Fischer from comment #8)
> (In reply to Fridolin Somers from comment #7)
> > For 20.11 waiting for Bug 28220
> 
> Hi Frido, was this pushed to 20.11.x now?

Sorry no, Bug 28220 does not apply on 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798

--- Comment #2 from Lucas Gass  ---
(In reply to Owen Leonard from comment #1)
> I'm curious, what is the motivation for forcing patrons to select a library?
> Under what circumstances is the user's home library not an appropriate
> default?

Some librarians in multi-branch systems want users to consciously make a
decision about where they will pickup the hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Libabry list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

--- Comment #2 from Manos PETRIDIS  ---
Errors in console are:

jquery-2.2.3.min_21.0501003.js:4 GET
http://192.168.1.148:8081/api/v1/libraries?_page=1&_per_page=20=%5B%5D&_match=contains&_order_by=%2Bme.name
404 (Not Found)

send @ jquery-2.2.3.min_21.0501003.js:4
ajax @ jquery-2.2.3.min_21.0501003.js:4
sa @ datatables.min_21.0501003.js:75
lb @ datatables.min_21.0501003.js:75
P @ datatables.min_21.0501003.js:67
T @ datatables.min_21.0501003.js:69
ha @ datatables.min_21.0501003.js:86
e @ datatables.min_21.0501003.js:131
(anonymous) @ datatables.min_21.0501003.js:131
each @ jquery-2.2.3.min_21.0501003.js:2
each @ jquery-2.2.3.min_21.0501003.js:2
n @ datatables.min_21.0501003.js:121
$.fn.api @ datatables_21.0501003.js:774
(anonymous) @ branches.pl:29830
i @ jquery-2.2.3.min_21.0501003.js:2
fireWith @ jquery-2.2.3.min_21.0501003.js:2
ready @ jquery-2.2.3.min_21.0501003.js:2
J @ jquery-2.2.3.min_21.0501003.js:2

and 

datatables_21.0501003.js:515 DataTables warning: table id=libraries - Ajax
error. For more information about this error, please see
http://datatables.net/tn/7

jQuery.fn.dataTable.ext.errMode @ datatables_21.0501003.js:515
K @ datatables.min_21.0501003.js:113
error @ datatables.min_21.0501003.js:74
i @ jquery-2.2.3.min_21.0501003.js:2
fireWith @ jquery-2.2.3.min_21.0501003.js:2
z @ jquery-2.2.3.min_21.0501003.js:4
(anonymous) @ jquery-2.2.3.min_21.0501003.js:4
load (async)
send @ jquery-2.2.3.min_21.0501003.js:4
ajax @ jquery-2.2.3.min_21.0501003.js:4
sa @ datatables.min_21.0501003.js:75
lb @ datatables.min_21.0501003.js:75
P @ datatables.min_21.0501003.js:67
T @ datatables.min_21.0501003.js:69
ha @ datatables.min_21.0501003.js:86
e @ datatables.min_21.0501003.js:131
(anonymous) @ datatables.min_21.0501003.js:131
each @ jquery-2.2.3.min_21.0501003.js:2
each @ jquery-2.2.3.min_21.0501003.js:2
n @ datatables.min_21.0501003.js:121
$.fn.api @ datatables_21.0501003.js:774
(anonymous) @ branches.pl:29830
i @ jquery-2.2.3.min_21.0501003.js:2
fireWith @ jquery-2.2.3.min_21.0501003.js:2
ready @ jquery-2.2.3.min_21.0501003.js:2
J @ jquery-2.2.3.min_21.0501003.js:2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #94 from Tomás Cohen Arazi  ---
Created attachment 123396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123396=edit
Bug 25260: Fix pendingreserves.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Libabry list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

--- Comment #1 from Owen Leonard  ---
Can you check the browser console to see if there are JavaScript errors on the
page? It seems likely that an error is preventing the API from passing the
information to the DataTable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798

--- Comment #1 from Owen Leonard  ---
I'm curious, what is the motivation for forcing patrons to select a library?
Under what circumstances is the user's home library not an appropriate default?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] New: Libabry list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

Bug ID: 28800
   Summary: Libabry list at /cgi-bin/koha/admin/branches.pl
appears empty
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: egpetri...@yahoo.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I've noticed that the list of libraries comes up empty, although libraries have
been defined.
When trying to create a new library with the same code as an existing one, the
expected error message appears, however one is left unable to manage the
existing libarries.

Video recording (54MB) available at 
https://emedgroupgr-my.sharepoint.com/:v:/g/personal/mpetridis_emedgroup_gr/EcSNYW0Y_YxPoWnr2wkohWMBFABMw6-X2wbVyvXcV0o0KA?e=Cvnchg

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28799] New: Action logs should capture lost items found

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799

Bug ID: 28799
   Summary: Action logs should capture lost items found
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Transaction logs
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

*Mark item lost
*Check action log for item to show lost status change
*Check item back in
*Action log doesn't update with lost status change

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28798] New: Allow ability to make OPAC hold pick-up location mandatory

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798

Bug ID: 28798
   Summary: Allow ability to make OPAC hold pick-up location
mandatory
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently, when placing a hold on the OPAC the pickup location defaults to
users branch, unless OPACHoldsIfAvailableAtPickup is set to 'don't allow'.

Many libraries like to force the user to make a branch selection and make this
field required. This can be done with JS but it would be nice if it was a
system preference. 

I'd like to see a system preference like 'OPACHoldBranchMandatory' which would
add an empty value like: --Please choose-- and upon
submission check to make sure something besides the empty value is selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel'

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626

--- Comment #5 from Owen Leonard  ---
I don't have a patch, so please attempt!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

--- Comment #13 from Owen Leonard  ---
Created attachment 123395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123395=edit
Bug 28785: Don't send SessionRestrictionByIP to template

It's not used.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

--- Comment #12 from Owen Leonard  ---
Created attachment 123394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123394=edit
Bug 28785: Add skip_version_check for checkauth

We could have this patch but we also could decide to skip it. The idea
is to avoid 2 checks of the version when we are coming from checkauth.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

--- Comment #11 from Owen Leonard  ---
Created attachment 123393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123393=edit
Bug 28785: Adjust check_cookie_auth calls

The previous patch makes check_cookie_auth return the session instead of
$sessionID, so we are adjusting the different calls to prevent
confusion.
However they are mainly used to check the authentication status and
don't care about this second variable.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

Owen Leonard  changed:

   What|Removed |Added

 Attachment #123320|0   |1
is obsolete||
 Attachment #123321|0   |1
is obsolete||
 Attachment #123322|0   |1
is obsolete||
 Attachment #123323|0   |1
is obsolete||

--- Comment #10 from Owen Leonard  ---
Created attachment 123392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123392=edit
Bug 28785: Centralize cookie auth check in check_cookie_auth

This code is duplicated in 3 different places, we must call
check_cookie_auth instead.

It makes check_cookie_auth returns a 'restricted' when
SessionRestrictionByIP is set and the IP changed.
It also returns a third parameters contained the old and new IP, to fill
the "info" hash in checkauth but apparently the oldip and newip
variables are not even used from the template. We may want to remove it
completely.

No change is expected with this patch, the different authentication
methods should still work as before.

Test plan:
Log in the staff and OPAC interfaces, logout.
Log in and call script that call the 3 different subroutines modified by
this patch. For instance you can list checkouts (that is using
check_cookie_auth) and display a patron's image (using check_api_auth).

QA with good knowledge of the C4::Auth module and the different
authentication methods is required.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #63 from Nick Clemens  ---
Slight rebase and small follow-up to record when fund is not changed upon
receipt.

While I would like to see fuller logging of objects these patches add more
information and will help track acquisitions so I think further enhancements
can be on follow up bugs.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #62 from Nick Clemens  ---
Created attachment 123391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123391=edit
Bug 24190: (QA follow-up) record unchanged bookfund and fix typo

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #61 from Nick Clemens  ---
Created attachment 123390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123390=edit
Bug 24190: (follow-up) Rename AcqLog

As requested in comment #49, renamed uses of AcqLog to AcquisitionLog

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #60 from Nick Clemens  ---
Created attachment 123389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123389=edit
Bug 24190: (follow-up) Modify order of logging

Basket creation involves two steps in Koha, creating the basket then
modifying its header. We were logging these two steps in the wrong
order. This commit fixes that.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #59 from Nick Clemens  ---
Created attachment 123388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123388=edit
Bug 24190: (follow-up) Add tests

In response to Jonathan's request for tests, I have now added additional
tests for the methods in C4/Budgets.pm that do logging

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #58 from Nick Clemens  ---
Created attachment 123387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123387=edit
Bug 24190: (follow-up) Respond to QA feedback

This commit makes changes in response to Jonathan's feedback in comment

- Moved from using zero padded strings to store log data to a JSON
object
- Stopped storing formatted dates in logged data

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >