[Koha-bugs] [Bug 28864] The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 --- Comment #1 from Michael Hafen --- Created attachment 123848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123848=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28864] New: The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Bug ID: 28864 Summary: The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: michael.ha...@washk12.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The patron search results in the patron card creator card batch doesn't include the value of the PatronsPerPage system preference in the per page drop down, which means it isn't using the system preference. Also, on the Patrons page, the patron search includes the PatronsPerPage value, but doesn't use it as the default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #7 from Michael Hafen --- (In reply to Katrin Fischer from comment #6) > Hi Michael, > > as David pointed out, currently with IndependentBranches the records are > shared and there are no limitations to editing them. A record doesn't belong > to any library, everyone can edit. I think this is a too big change to > existing behavior that will be unwanted by many, so it should be made > strictly optional. > > I also believe we might not want to add a new concept like this on top of > IndependentBranches. In my opinion it needs more hashing out and it would > look better in the new library group settings that I hope will replace > IndependentBranches at some point in the not too soon future. > > Also there are a lot of edge cases here I am not sure about: > > * If shared records cannot be edited by libraries using it, who can edit it > to fix issues? > * What about records for electronics, serials etc. that don't need to > necessarily have items? > * What about the Advanced cataloguing editor? > > There is also no test plan here, please add one to your commit message. Also > take a look at how the subject etc. should look like: > https://wiki.koha-community.org/wiki/Commit_messages Should be easy to implement this with a new type of library group. I haven't done that before though, so I'd have to go through the code to figure that out. The point of a record not belonging to any library (or library group) is pivotal here. The best I can think of would be adding a column to the biblio(items) table to hold either the branch or branch group claiming the record, or maybe that could be added through the biblio_metadata. This would cover your second edge case too, as electronics and serials could be given an owner that way. I used C4::Context->only_my_library() in the patch, so SuperLibrarians would still be able to edit shared records, which addresses your first edge case. The third edge case is also a bit sticky for me. It would mean, to me, greatly increasing the size of the patch, as I would also want to expand this to the cataloging search and import batch record matching. I figure once we start declaring that a branch group owns a record, then we'd want to limit cataloging to only records owned by the group or with no owner. That would pretty much eliminate the cases of shared records between library groups, but also reduce the ability to reuse records. Or, in cataloging, limit actions on records owned by another library group to just duplicating the record. I feel that to fully flesh-out the feature that would be the way to go, but maybe I'm over-thinking it. If there is some interest in the feature I could work on the library groups and advanced editor points, at least. I'm also willing to withdraw the bug (I don't see a "Won't Fix" status, so push it to "In Discussion" I guess), if there isn't any interest. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #24 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #17)
> I am a little worried about the short list here:
>
> +sub api_privileged_attrs {
> +return [
> +'checked_out_date',
> +'checkouts_count',
> +'holds_count',
> +'internal_notes',
> +'extended_subfields',
> +];
> +}
> +
>
> Can you help me? Just wondering if it also uses the framework visibility,
> then I'd be happy already :)
If we leave more_subfields_xml/frameworks out of the item representation (we
have plans for that), would y'all help me refine this deny-list for the items?
I have just rebased this work and it still works nicely. If I don't get
feedback in a few days, I will move the 'public' layer work to another
(simpler) table, so other devs see the benefit from this and can work on top of
it.
My feeling is we can have a list of 'hidden in opac' attributes from the
'items' table, and then we can sort visibility in the views. I might be wrong,
though. Looking for feedback.
Please PM me if you feel like there's a good use case that could be simpler
than this (I'm thinking accountlines).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28863] New: Cancel a Pending Notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863 Bug ID: 28863 Summary: Cancel a Pending Notice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: rco...@arlingtonva.us QA Contact: testo...@bugs.koha-community.org We would like the ability to cancel any notice that is currently "Pending" on the Notices tab in a user's account. Also, a record of which librarian cancelled the notice and date/time stamp would be very useful. Use Case: Item is discharged, hold is trapped, & notice is generated. Staff then realizes that the item is badly damaged and reverts the hold to obtain another copy. However, the notice for the original item is now Pending in the account and the email will be sent - even though the item is not on the Hold Shelf. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #9 from Fridolin Somers --- Actually Zebra as a rule in words-icu.xml : But it may not be optimal to do the exact same thing in Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #12 from Christopher Brannon --- Could someone just simply start off by adding a middle name field in the borrower tables, and putting the field on the patron edit page??? That would be a start. Please, lets get this ball rolling at least! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 123847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123847=edit Bug 27358: Unit tests for public items retrieval Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 123846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123846=edit Bug 27358: Add GET /public/biblios/:biblio_id/items This patch introduces a route to fetch items belonging to a biblio. It is expected to return the 'public' representation of the Koha::Item objects. It is also enforcing the visibility rules, by using Koha::Items->filter_by_visible_in_opac. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Test pass and they cover all the cases! 3. Try your favourite REST tool against the new route. 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 123845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123845=edit Bug 27358: Teach objects.search about public requests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 123844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123844=edit Bug 27358: Make is_public stashed on public routes This patch makes the API authentication code stash the 'is_public' value when public routes are hit. This will be particularly useful to have $c->objects->search generically pass this info down to the ->to_api method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass! When a public route is reached, the controller has the 'is_public' value stashed 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358
--- Comment #19 from Tomás Cohen Arazi ---
Created attachment 123843
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123843=edit
Bug 27358: Add a generic way to handle API privileged access attributes
deny-list
This patch introduces a way for Koha::Object(s)->to_api to filter out
attributes that require privileged access. It is done in a way that the
'public' parameter is recursively passed to nested objects in recursive
to_api() calls.
This way, Koha::Object-based classes can determine how they will render
depending on this parameter. For example, for implementing a
route for fetching an item looks like:
GET /items
The controller will look like:
my $item = Koha::Items->find( $c->validation->param('item_id') );
return $c->render(
status => 200,
openapi => $item->to_api
);
Implementing an unprivileged (public) route would look like:
GET /public/items/:item_id
The controller will look like:
my $item = Koha::Items->find( $c->validation->param('item_id') );
return $c->render(
status => 200,
openapi => $item->to_api({ public => 1 })
);
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object*.t
=> SUCCESS: Tests pass (i.e. current behaviour is kept, new behaviour
passes the tests)
3. Sign off :-D
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What|Removed |Added Attachment #116191|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What|Removed |Added Attachment #116190|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What|Removed |Added Attachment #116189|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What|Removed |Added Attachment #116188|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What|Removed |Added Attachment #116187|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #19 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Depends on Bug 28179 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||fridolin.som...@biblibre.co ||m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28813] Fix recording and display of delivery errors for patron notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #19 from Fridolin Somers --- Depends on Bug 14723 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Another funny behavior. With only edit_items you have access and links to "Cataloguing" home page, but its empty. It is for another bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26036] Suggestion for the "Batch extend due dates" result screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26036 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25995] Log changes to due date using bulk edit tool in circulation log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25995 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28861] Item type column always hidden in holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123842=edit Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What|Removed |Added Blocks||28861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 [Bug 28861] Item type column always hidden in holds history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28861] Item type column always hidden in holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #12 from Nick Clemens --- Created attachment 123841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123841=edit Bug 28847: Only apply JS to branch/multibranch selection if there are search groups -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Depends on Bug 25026 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Attachment #123839|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 123840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123840=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28611] Incorrect Select2 width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in|| --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28611] Incorrect Select2 width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #14 from Fridolin Somers --- (In reply to Katrin Fischer from comment #13) > (In reply to Fridolin Somers from comment #12) > > Oh crap, a real ergonomic bug then. I backport. > > > > The backport on 20.11 actually fails because there is on select tag the > > attribute size="1". > > This has been removed in 21.05.x by Bug 28066. > > > > Should we keep it or remove it ? > > I believe removing it would be ok, but leaving it in probably won't cause > issues right away either. Ok I choose to keep it. Thanks for your help ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #11 from Rebecca Coert --- +1 I agree with the group that this would be an extremely useful field to have in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28862] New: Add suffix to name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28862 Bug ID: 28862 Summary: Add suffix to name field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: rco...@arlingtonva.us QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Requesting the addition to the name field for suffix entries (Jr., Sr. III, etc.). Ideally it would be a drop-down box that could be prepopulated (auth_value?) with common entries; allowing for cleaner data and easier account viewing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28861] Item type column always hidden in holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Tomás Cohen Arazi changed: What|Removed |Added Assignee|oleon...@myacpl.org |tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28861] New: Item type column always hidden in holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Bug ID: 28861 Summary: Item type column always hidden in holds history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The page replicated the behavior from the holds history page on staff and added: [% IF show_itemtype_column %] Requested item type [% END %] but 'show_itemtype_column' is never set. To reproduce: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26860] Add search limit for records without items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #20 from Fridolin Somers --- (In reply to Kyle M Hall from comment #17) > Created attachment 120994 [details] [review] > Bug 26860: facets.inc refactor availability facet > Oh crap, only first patch has been QA and others set obsolete. So only first patch is in master : > git log --online --grep=26860 origin/master 63d6c1d8c5 Bug 26860: facets.inc refactor availability facet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28860] New: Add system setting to mark Patron fields important
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28860 Bug ID: 28860 Summary: Add system setting to mark Patron fields important Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: esth...@sodaspringsid.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be nice to add a system setting similar to the BorrowerMandatoryField for the patron form to mark fields important. This would give a visual clue for fields that should be filled in but are not necessarily required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Andrew Fuerste-Henry --- Sorry, just noticed the same issue exists on the OPAC. If there is no search group in place for use on the OPAC, the Libraries dropdown is erroneously disabled. Kicking back to FQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What|Removed |Added Attachment #123816|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 123839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123839=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Nick Clemens changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What|Removed |Added Attachment #123834|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 123838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123838=edit Bug 28819: (follow-up) Use stacked icons for different searches This patch modifies the staff interface home page so that the "Advanced search" and "Item search" links are differentated using stacked Font Awesome icons. To test, apply the patch and view the staff interface home page. The icons associated with advanced and item searches should be different: - The Advanced search link should have a magnifying glass icon on top of a grey book icon. - The Item search link should have a magnifying glass icon on top of a grey list icon. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #4 from Autoparallel --- Since this is what came out from the committee we will consider it as the official scope for this project and what will be built. Please be aware that any changes to this scope will have to be re-discussed in the committee and if approved would have to be treated as a new development, which would require a new work agreement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #8 from Owen Leonard --- I talked Fridolin out of doing this in Bug 24088, but I guess this is a sign it really is wanted. I hope my follow-up helps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123833|0 |1 is obsolete|| --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 123837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123837=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123808|0 |1 is obsolete|| --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 123836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123836=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123807|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 123835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123835=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #7 from Owen Leonard --- Created attachment 123834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123834=edit Bug 28819: (follow-up) Use stacked icons for different searches This patch modifies the staff interface home page so that the "Advanced search" and "Item search" links are differentated using stacked Font Awesome icons. To test, apply the patch and view the staff interface home page. The icons associated with advanced and item searches should be different: - The Advanced search link should have a magnifying glass icon on top of a grey book icon. - The Item search link should have a magnifying glass icon on top of a grey list icon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What|Removed |Added Attachment #123832|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 123833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123833=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What|Removed |Added Attachment #123830|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 123832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123832=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Owen Leonard changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #4 from Owen Leonard --- (In reply to Barbara Johnson from comment #3) > > 2. ...However, clicking on the Edit > dropdown on this screen gives them the ability to edit the record using a > MARC mod template even though they do not have the permission for editing > these templates. This sounds like it needs a new bug report. > 3. ... Based on this > comment it seems she would question whether a view option is even needed. The view option was always there, it was just unclear what it was because the link was just a number. Marking "Failed QA" in order to address issue 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 123831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123831=edit Bug 28850: Reword AllFinesNeedOverride To test: Apply patch, look up AllFinesNeedOverride, confirm it now says that checkouts will be blocked via the web-based selfcheck and SIP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What|Removed |Added Attachment #123809|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 123830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123830=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123789|0 |1 is obsolete|| --- Comment #34 from Tomás Cohen Arazi --- Created attachment 123829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123829=edit Bug 28026: Add call_recursive() as a supplement for call() The method call() is not sufficient for all plugin hook types. It's possible that more than one plugin will be installed that wants to return the arguaments passed in an updated form. These transformation plugins need to work recursively rather than independantly. This patch adss a `call_recursive()` method that takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the arguament list and modify it as necessary. Test plan 1/ Run the included tests - t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #8 from Barbara Johnson --- This is a constant problem for our patrons who are used to searching Amazon or Google without having to worry about apostrophes. Fixing this issue would really improve the ability for our patrons to find items in our catalog. The status of this bug is listed as Needs Signoff. Is there a test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||and...@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- I stumbled into a problem: - create a library group for use for OPAC searching BUT NOT staff searching - go to advanced search in the intranet - confirm you can select an individual library but no groups are shown - apply patch - reload adv search on the intranet - individual library selector is disabled (incorrect), groups selector doesn't show (correct) - edit your group, make it usable on the intranet - reload adv search - the group picker is now showing and the libraries picker is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Barbara Johnson changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #3 from Barbara Johnson --- I originally signed off on this bug, but had some concerns so I revisited it and changed the status to In Discussion. 1. A staff member who does not have edit permissions still sees the edit button. Clicking on the edit button takes them to a Koha login screen. It would be better if the staff member did not see the edit button at all if they can't edit anything. 2. When a staff member that does not have bib editing permissions clicks on the View button from manage-marc-import.pl they are taken to a view only display on detail.pl which seems correct. However, clicking on the Edit dropdown on this screen gives them the ability to edit the record using a MARC mod template even though they do not have the permission for editing these templates. A staff member with view only permissions should not be able to edit the bib record at all. 3. In discussing this issue with an expert cataloger she had the following to say: "I can't think of a single reason why I'd allow someone to load files without any editing permissions, frankly--looking at a loaded file is a quality control step, and if someone doesn't have the expertise to edit MARC (bib or aut), how are they going to have the expertise to, e.g., troubleshoot something that should have overlaid but didn't?" Based on this comment it seems she would question whether a view option is even needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #3 from Christopher Brannon --- The koha-US development committee met and has determined the following criteria for this new feature: * A new field (ie patron_read) will be added to the messages table to record that the patron has read the message. * If a message is set to display on the OPAC for the patron, the patron will have a 'Dismiss' or 'Mark as read' button next to the message. * When the patron marks the message as read, the message_type field will change from B (patron) to L (librarian), and the new field (ie patron_read) will have a value, indicating that they read the message. * If this new field is true (showing the patron has read the message), it will now have the message_type set to L (librarian), and the message will show on the patron account. Because the new field has a value, it will also display some form of label next to the message indicating that the patron has read the message. The label could say something like 'Patron acknowledged', or something similar. This functionality will not delete the message. It will allow staff to see that the patron has read the message, and staff will still have the ability to delete the message at their discretion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123799|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123828=edit Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #2 from Christopher Brannon --- (In reply to George Williams (NEKLS) from comment #1) > We have AllowAllMessageDeletion set to "Don't allow" so I'd like to see a > system preference that can turn this feature on or off if added. After reviewing the intended functionality of this feature and the purpose of AllowAllMessageDeletion, we have determined that this feature will not change anything with this permission. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Trivial, passing QA, understand if RM wants outside opinion :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What|Removed |Added Attachment #123703|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 123827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123827=edit Bug 28819: Add item search to intranet-main.tt To test: 1. Apply patch 2. Go to staff main page ( intranet-main.tt ) 3. Now you should see an 'Item search' button and icon. Signed-off-by: kelly mcelligott Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexis.ripe...@inlibro.com |ity.org | QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719
Nick Clemens changed:
What|Removed |Added
Attachment #123704|0 |1
is obsolete||
--- Comment #5 from Nick Clemens ---
Created attachment 123826
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123826=edit
Bug 28719: Change somes links in the serials page to avoid them leading to
nothing
To test:
1- Search for a serial
2- Pick one
3- Go to 'Serial collection' on the left
4- An issue should be selected if you're expected a new issue
5- delete it using 'Delete selected issues'
6- Confirm deletion
7- If you're supposed to receive more issues the next one should now be there
8- Now edit the serial ('Edit serials')
9- See that the link leads to nothing
10- Apply patch and redo steps 1 to 8
11- See that the link now leads to something
Signed-off-by: kelly
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Autoparallel changed: What|Removed |Added CC||ivan.marquez@autoparallel.c ||om Assignee|oleon...@myacpl.org |ivan.marquez@autoparallel.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28859 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Sally changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23916 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28858] Table Settings should control Checked out by field in Circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 Sally changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28859 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Sally changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28858 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28859] New: Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Bug ID: 28859 Summary: Table Settings should control Checked out by field in Checkout history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: sally.hea...@cheshiresharedservices.gov.uk QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users. 'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Note that 'Checked out by' is not an option This also has the effect of targeting the wrong field via Table Settings. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'renewed' - Reload the item's Checkout history - Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Renewed' is not This is because 'Checked out by' is sitting in the original 'Renewed' position in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28858] Table Settings should control Checked out by field in Circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 --- Comment #1 from Sally --- This also has the effect of targeting the wrong field via Table Settings. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to that patron's Circulation history - cgi-bin/koha/members/readingrec.pl - Note that 'Checked out by' is visible and populated - Go to Koha > Administration > Table Settings - Choose Patrons - Choose Page: checkouthistory - Choose Table id: checkouthistory-table - Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'date_due' - Reload the patron's Circulation history - Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Date due' is not This is because 'Checked out by' is sitting in the original 'Date due' position in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28858 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28858] Table Settings should control Checked out by field in Circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 Sally changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23916 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28858] New: Table Settings should control Checked out by field in Circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 Bug ID: 28858 Summary: Table Settings should control Checked out by field in Circulation history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: sally.hea...@cheshiresharedservices.gov.uk QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users. 'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to that patron's Circulation history - cgi-bin/koha/members/readingrec.pl - Note that 'Checked out by' is visible and populated - Go to Koha > Administration > Table Settings - Choose Patrons - Choose Page: checkouthistory - Choose Table id: checkouthistory-table - Note that 'Checked out by' is not an option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #2 from Owen Leonard --- (In reply to Owen Leonard from comment #0) > dragging the image file into the local cover images > tab on the bibliographic detail page. This patch doesn't do this (you still have to go to the "Upload local cover images" page), but it lays the framework for making it possible. I'm putting it back to ASSIGNED because there is a problem with the way the page displays item information when you upload an image at the item level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 --- Comment #1 from Owen Leonard --- Created attachment 123825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123825=edit Bug 25025: Drag-and-drop cover image upload This patch updates the Upload local cover image page so that the user has the option of dragging a file from a folder on their computer instead of using a file upload button. The patch also adds a preview of uploaded single images and display of existing images on the record you're adding to. To test, apply the patch and make sure the LocalCoverImages system preference is enabled. - Go to Tools -> Upload local cover image and test the following processes: - Upload single cover image, specifying a biblionumber - Test dragging an image from a file on your computer - Test clicking the "Drop files here or click..." link. - You should see a preview of the image file on the screen, with information about the file: file name, image type, file size. - Click "Process images" - with "Existing covers will be replaced" checked - with "Existing covers will be replaced" unchecked When the upload process completes you should see information about the title in the page heading and a thumbnail of the cover in the sidebar. - Test that the image can be deleted from this page. You should be redirected back to this page with the same title still selected. - Upload a zip file of images - Test dragging an image from a file on your computer - Test clicking the "Drop files here or click..." link. - A zip file can't be previewed onscreen but you should see the same file information and a Font Awesome "zip file" icon. - Click "Process images" From the bibliographic detail page, click the "Images" tab, and click "Upload." With this workflow the field asking for a biblionumber should not appear. Test with AllowMultipleCovers enabled and disabled to confirm that the "Existing covers will be replaced" checkbox is enabled only when multiple covers are possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Peter Vashchuk changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |stalkern...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Nice fix, no typos or spelling issues. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Martin Renvoize changed: What|Removed |Added Attachment #123810|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 123824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123824=edit Bug 28842: A summary to the /items/:item_id/pickup_locations route This patch simply adds a summary to the route. This will be picked by the API docs. It also removes the 'pickup_locations' tag, as we did in bug 28461. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28857] Allow hold to be suspended at point of creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28857 Andrew Fuerste-Henry changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28857] New: Allow hold to be suspended at point of creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28857 Bug ID: 28857 Summary: Allow hold to be suspended at point of creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Holds with a future start date and an element of complexity that some libraries would like to avoid. Instead, they use suspensions to delay the fulfilling of holds. However, there's no way to suspend a hold as you place it -- you need to place the hold and then suspend it from another screen. We should make it possible to set a suspension on a hold as you place it. But we should make is easy to hide the option to do so, so this probably means a new system preference, something like SuspendHoldsAtCreation, with options for No / Intranet / OPAC / Both Intranet and OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
