[Koha-bugs] [Bug 28324] Pagination displays weirdly when there are more than 10 pages

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28324

Hayley Pelham  changed:

   What|Removed |Added

 CC||hayleypel...@catalyst.net.n
   ||z

--- Comment #2 from Hayley Pelham  ---
I can confirm this is an annoying display issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and punctuation in XSLT display

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Hayley Pelham  changed:

   What|Removed |Added

 Attachment #124060|0   |1
is obsolete||

--- Comment #16 from Hayley Pelham  ---
Created attachment 124129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124129=edit
Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21)

At the moment the punctuation entered for $n $p and is
removed in the part template, which leads to displaying the subfields
without any punctuation and spaces in between.

To test:
- Catalog records with various combinations of 8xx series added
  entry fields. Subfield a, t, n, p and v are the most important.
- Verify the display in OPAC and staff is not great.
- Apply the patch.
- Verify the display in OPAC and staff is improved.

For examples see:
https://www.loc.gov/marc/bibliographic/bd80x83x.html

Important note: At the moment 8xx series added entry fields will only display,
when
there is also a 490 ind. 1 = 1 field present.

Signed-off-by: Hayley Pelham 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and punctuation in XSLT display

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Hayley Pelham  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #385 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #384)
> (In reply to Tomás Cohen Arazi from comment #383)
> > This code implements the groups. There's a separate bug that implements hold
> > fulfillment by group items. That one will need some changes after the
> > refactoring we made.
> > 
> > It would be great if you could go QA this one so we can build the rest on
> > top of this.
> 
> With 33 patches, I think this might make it on the TODO list that I just
> feel guilty about and never action :(.

If you apply them, and do a git diff, things are pretty clear and simple.

I hesitated to squash everything because it wasn't my dev.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #384 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #383)
> This code implements the groups. There's a separate bug that implements hold
> fulfillment by group items. That one will need some changes after the
> refactoring we made.
> 
> It would be great if you could go QA this one so we can build the rest on
> top of this.

With 33 patches, I think this might make it on the TODO list that I just feel
guilty about and never action :(.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #48 from David Cook  ---
If I recall correctly, consideration of hold rules is a mess across the board.
I keep thinking that we need to do something that covers them all otherwise all
the changes will always just be Band-Aids.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #383 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #382)
> I'm really glad to see Volume change to Item Group, because we've had a
> number of times when we've wanted to have Item Group holds where library
> staff could group together items. 
> 
> I haven't looked through the code in a long time. Is it just for holds or
> does it handle aspects of circulation too like checkouts? That's just a
> question and by no means a comment on the patches. Just curious.

This code implements the groups. There's a separate bug that implements hold
fulfillment by group items. That one will need some changes after the
refactoring we made.

It would be great if you could go QA this one so we can build the rest on top
of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901

--- Comment #2 from David Cook  ---
(In reply to Jonathan Druart from comment #1)
> Not affecting master? Steps to recreate?

It'll probably be affecting master. It might affect other versions after 19.11,
but I haven't gotten around to looking yet. I've just fixed it locally for
20.11.

I'll have a think about drafting up some steps. I'll probably do something with
injecting a HTML element above the navbar using Javascript. 

I wasn't supposed to be working on Koha yesterday, and today after I get
through my emails I'm going to work on something else. But i'll make a note to
come back to this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #382 from David Cook  ---
I'm really glad to see Volume change to Item Group, because we've had a number
of times when we've wanted to have Item Group holds where library staff could
group together items. 

I haven't looked through the code in a long time. Is it just for holds or does
it handle aspects of circulation too like checkouts? That's just a question and
by no means a comment on the patches. Just curious.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

--- Comment #2 from Henry Bolshaw  ---
Created attachment 124128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124128=edit
Bug 28188: Accessibility: OPAC contrast ratio for text is insufficient

This patch makes minor changes to the OPAC SCSS
files to improve the contrast ratio for text on
the OPAC, including the main navigation links
and buttons. These issues were identified using
the WebAIM WAVE accessibility browser extension,
Chrome's Lighthouse tool, and Khan Academy's
Tota11y bookmarklet (the results using the three
tools were very similar).

To Test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse Tool or WebAim's Wave Extension) to
   test the contrast ratio for text.
2. Confirm that the OPAC has contrast ratio issues
   affecting the main navigation links, the buttons,
   and the text of search results.

3. Apply the patch and rebuild the OPAC CSS:
   yarn build --view opac
4. Use the accessibility tool to confirm the
   contrast ratio issues have been fixed
5. Check that the OPAC still looks ok
   after the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #119114|0   |1
is obsolete||

--- Comment #24 from Fridolin Somers  ---
Created attachment 124127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124127=edit
Bug 26860: (follow-up) case requesting zebra with ccl query

When calling a ccl syntax query, code must be added like for
availability facet.
See Bug 17278: Use available limit when requesting zebra when ccl query is used

This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne
'available' } @limits".
Following the logic of :
Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}

Test plan :
1) Use Zebra search engine
2) Perform a search on staff interface with explicit index, for example
'ti:history'
3) This search must return some records with and some without items
4) Click on 'Limit to records without items'
5) Check you see only records without items
6) Click on 'Show all records'
7) Check you see all records again
8) Check availability facet is also working

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #119113|0   |1
is obsolete||

--- Comment #23 from Fridolin Somers  ---
Created attachment 124126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124126=edit
Bug 26860: Add without items facet

Many libraries ask for a way to search biblio records without items.
In order to clean the catalogue or acquire items.
I propose to add a search limit and facet.
Only in staff interface for start.

I choose to use homebranch index, should always be defined on items.
Looks like itemnumber index can not be used because of its configuration in
ccl.properties.

Test plan :
1) Check with both Zebra and Elasticsearch
2) Perform a search on staff interface returning some records with and some
without items
3) Click on 'Limit to records without items'
4) Check you see only records without items
5) Click on 'Show all records'
6) Check you see all records again

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26860] Add search limit for records without items

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #120994|0   |1
is obsolete||

--- Comment #22 from Fridolin Somers  ---
Created attachment 124125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124125=edit
Bug 26860: facets.inc refactor availability facet

To prepare new facet, this patch refactors the availability facet,
without any change in restult.
Appart from an id 'facet-availability', like other facets.

Test plan:
1) Perform a search in staff interface
2) Check availability facet displays well
3) Click on it
4) Check availability facet displays well

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||28908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908
[Bug 28908] Bug 18017 removed indexing field 245
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28908] Bug 18017 removed indexing field 245

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||18017


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017
[Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities
zebra configuration
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28908] New: Bug 18017 removed indexing field 245

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908

Bug ID: 28908
   Summary: Bug 18017 removed indexing field 245
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Before bug 18017 there was in
etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml :

  
  
Title-uniform:w
...

Indexing of 245, 445, ... is now missing.

Is this on purpose ?

Note that Title-uniform was used in authorities fields 230, 235 and 245.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28905] Make it possible to hide export column in table configuration in checkouts

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28905

--- Comment #2 from Katrin Fischer  ---
I could be sold on this :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294

Fridolin Somers  changed:

   What|Removed |Added

 Depends on|20985   |
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
[Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf
holds allowed' policy
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

Fridolin Somers  changed:

   What|Removed |Added

 Blocks|19294   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294
[Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds
allowed" setting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

--- Comment #27 from Nick Clemens  ---
Created attachment 124124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124124=edit
Bug 25619: Adjust POD and move date check before logging

Potentially we could have logged a change when no date was passed.

This patch moves the test before logging and updates POD

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Nick Clemens  changed:

   What|Removed |Added

 Attachment #123779|0   |1
is obsolete||

--- Comment #26 from Nick Clemens  ---
Created attachment 124123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124123=edit
Bug 25619: Adjust POD

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Nick Clemens  changed:

   What|Removed |Added

 Attachment #123695|0   |1
is obsolete||

--- Comment #25 from Nick Clemens  ---
Created attachment 124122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124122=edit
Bug 25619: (QA follow-up) Fix subtest description

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Nick Clemens  changed:

   What|Removed |Added

 Attachment #123694|0   |1
is obsolete||

--- Comment #24 from Nick Clemens  ---
Created attachment 124121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124121=edit
Bug 25619: Unit Tests

Signed-off-by: Abbey Holt 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Nick Clemens  changed:

   What|Removed |Added

 Attachment #123693|0   |1
is obsolete||

--- Comment #23 from Nick Clemens  ---
Created attachment 124120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124120=edit
Bug 25619: Add ability to adjust expiration date for waiting holds

There are times when an item that is waiting for pickup needs to have the
expiration date extended. This would give staff the ability to modify one by
one, as needed, the reserves.expirationdate for a given item awaiting pickup.

Test Plan:
1) Place a hold, trap an item for it such that is is waiting
2) Attempt to update the expiration date
3) Note the new date is not saved
4) Apply this patch, restart all the things!
5) Attempt to update the expiration date
6) The new date should be saved!

Signed-off-by: Abbey Holt 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

--- Comment #26 from Christopher Brannon  ---
Unexpectedly misspelling!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #18 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #14)
> Tomas, see the last 2 patches.
> 
> It seems that matching the regex is not enough (last patch fixes a test).
> 
> However there is still a test failing, root@localhost is considered valid
> (FQDN no longer required).

On it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

--- Comment #7 from Manos PETRIDIS  ---
(In reply to Jonathan Druart from comment #5)
> What's your version of JSON::Validator? Are you using Debian 11?

JSON::Validator (0.97)  0.97
JSON (2.07) 2.90
Template::Plugin::JSON::Escape (0.02)   0.02

I'm using Debian 9, wasn't aware that koha is now compatible with later Debian
releases.

Koha version:   21.05.02.000
OS version ('uname -a'):Linux koha 4.9.0-16-amd64 #1 SMP Debian
4.9.272-2 (2021-07-19) x86_64
Perl interpreter:   /usr/bin/perl
Perl version:   5.024001
MySQL version:  mysql Ver 15.1 Distrib 10.4.19-MariaDB, for debian-linux-gnu
(x86_64) using readline 5.2
Apache version: Server version: Apache/2.4.25 (Debian)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #99 from Jonathan Druart  ---
The way this enhancement is implemented sounds weird to me. Why are you using
perl when it can be done using Datatables (client-side)?

Having the ability to define a list of word to ignore is great, but it can be
done (at first glance) easily by extending the 'anti-the' plugin (and it will
apply to *all* tables of Koha).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28017] Allow non-FQDN and IP addresses in emails

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28017

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28870

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28017

--- Comment #17 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #15)
> (In reply to Jonathan Druart from comment #14)
> > Tomas, see the last 2 patches.
> > 
> > It seems that matching the regex is not enough (last patch fixes a test).
> > 
> > However there is still a test failing, root@localhost is considered valid
> > (FQDN no longer required).
> 
> Shoudl it not be valid since bug 28017?

I forgot that one!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #16 from Jonathan Druart  ---
Created attachment 124119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124119=edit
Bug 28870: non-FQDN addresses are valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #15 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #14)
> Tomas, see the last 2 patches.
> 
> It seems that matching the regex is not enough (last patch fixes a test).
> 
> However there is still a test failing, root@localhost is considered valid
> (FQDN no longer required).

Shoudl it not be valid since bug 28017?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #14 from Jonathan Druart  ---
Tomas, see the last 2 patches.

It seems that matching the regex is not enough (last patch fixes a test).

However there is still a test failing, root@localhost is considered valid (FQDN
no longer required).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #13 from Jonathan Druart  ---
Created attachment 124118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124118=edit
Bug 28870: Use Email::Address->parse

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #12 from Jonathan Druart  ---
Created attachment 124117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124117=edit
Bug 28870: Move email address validation to a specific class method

To ease testing and future changes if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775

Jonathan Druart  changed:

   What|Removed |Added

 CC||christofer.zorn@ajaxlibrary
   ||.ca

--- Comment #14 from Jonathan Druart  ---
*** Bug 26570 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26570] Search Functionality in Borrowing History

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26570

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #2 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 25775 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #5 from Jonathan Druart  ---
(In reply to Owen Leonard from comment #1)
> If that's correct, it looks like the tab key difference can be changed by
> setting a new default in select2.js: "selectOnClose" -> true

Pierre, does Owen's suggestion answer your need?

> In terms of having the same number of interactions (key presses or clicks),
> it would be nice if one didn't have to hit ENTER to activate a Select2 menu.
> I don't think that's currently configurable.

You can open the dropdown list hitting "space" in both situations. So if we
turn selectOnClose on, we are good. Am I missing something?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Add ability to create   |Add ability to group items
   |"Volumes" for records, and  |for records
   |assign items to volumes |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_05_candidate |rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_05_candidate
 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28812] Authority tag editor only copies $a

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

--- Comment #10 from Didier Gautheron  ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Didier Gautheron from comment #7)
> > 4- Apply patch 
> 
> Which one? :)

The one I forgot to add :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28812] Authority tag editor only copies $a

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

Didier Gautheron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |didier.gautheron@biblibre.c
   |ity.org |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28812] Authority tag editor only copies $a

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

--- Comment #9 from Didier Gautheron  ---
Created attachment 124116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124116=edit
Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor

To test:
1- Create a notice with a 700$a and 700$d
2- Click on 700 $a field Tag Editor
3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up
4- Apply patch
5- Redo 2
6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in
'Search main heading'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28812] Authority tag editor only copies $a

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

Didier Gautheron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903

--- Comment #4 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #3)
> I don't understand your comment Marcel. The change would be harder to
> explain?

Yeah too short. The fact that one form has a dropdown type A and another one
dropdown type B, and you should press X on form A but press Y on form B is
harder to explain. For users it may just be a dropdown..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28812] Authority tag editor only copies $a

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

--- Comment #8 from Jonathan Druart  ---
(In reply to Didier Gautheron from comment #7)
> 4- Apply patch 

Which one? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28800

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28811] Cant receive orders

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28800

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28811,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26893

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

--- Comment #6 from Jonathan Druart  ---
See http://irc.koha-community.org/koha/2021-08-16#i_2371014

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

--- Comment #5 from Jonathan Druart  ---
What's your version of JSON::Validator? Are you using Debian 11?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903

--- Comment #3 from Owen Leonard  ---
I don't understand your comment Marcel. The change would be harder to explain?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567

Jonathan Druart  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #30 from Jonathan Druart  ---
*** Bug 27197 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27197] Empty information in libraries table

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 28567 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903

--- Comment #2 from Marcel de Rooy  ---
From a keyboard user perspective may be harder to explain?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28812] Authority tag editor only copies $a

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

--- Comment #7 from Didier Gautheron  ---
(In reply to Katrin Fischer from comment #5)
> Maybe I am testing the wrong thing. 
> 
> Do you mean copying a repeatable field or are we talking about the authority
> linker?
> Authority editor or editing bibliographic records?
Authority search Window.


1- Create a notice with a 700$a and 700$d
2- Click on 700 $a field Tag Editor 
3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up

4- Apply patch 
5- Redo 2
6- as in 19.11 700$a is copied in 'Search main heading ($a only)' and $d is
copied in 'Search main heading'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903

--- Comment #1 from Owen Leonard  ---
If I understand correctly, this is the difference between how an HTML 
behaves and how a Select2 dropdown (like on additem.pl) works:

HTML :

1. Tab to .
2. Use arrow key to highlight option.
3. Hit tab key -> Option is selected.
   * ENTER key also works.
4. Hit tab key -> Focus moves to next input.

Select2 dropdown:

1. Tab to field.
2. Hit ENTER.
3. Use arrow key to highlight option.
4. Hit ENTER -> Option is selected.
   * TAB key does NOT work to select an option.
5. Hit tab key -> Focus moves to next input.

If that's correct, it looks like the tab key difference can be changed by
setting a new default in select2.js: "selectOnClose" -> true

In terms of having the same number of interactions (key presses or clicks), it
would be nice if one didn't have to hit ENTER to activate a Select2 menu. I
don't think that's currently configurable.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28905] Make it possible to hide export column in table configuration in checkouts

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28905

--- Comment #1 from Owen Leonard  ---
If we add this column to the table configuration can the ExportCircHistory
preference be removed? If the administrator can hide the column by default and
make it un-togglable that's the same thing?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #124114|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 124115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124115=edit
Bug 28906: (26223 follow-up) Remove use of as_list

This bug makes Koha::Items->filter_by_visible_in_opac honour list
context, so this explicit call is not needed.

To test:
1. Pick a biblio in the OPAC
2. Go to the ISBD view
=> SUCCESS: It renders correctly
3. Apply this patch and restart Plack
4. Refresh the ISBD view page
=> SUCCESS: It doesn't break!
5. Check opac-reserve.pl doesn't break either
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #98 from Jonathan Druart  ---
You need to amend the commits and fix their title:

% git rebase -i HEAD~X (with X the number of commit)
Replace "pick" with "r" (reword), save.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 124114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124114=edit
Bug 28906: (26223 follow-up) Remove use of as_list

This bug makes Koha::Items->filter_by_visible_in_opac honour list
context, so this explicit call is not needed.

To test:
1. Pick a biblio in the OPAC
2. Go to the ISBD view
=> SUCCESS: It renders correctly
3. Apply this patch and restart Plack
4. Refresh the ISBD view page
=> SUCCESS: It doesn't break!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 124113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124113=edit
Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context

This patch makes the method honour list context.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> FAIL: Tests fail! It returns [Koha::Items]. Boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 124112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124112=edit
Bug 28906: Regression tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

--- Comment #4 from Manos PETRIDIS  ---
My koha installation is a plain Jane one, installed via packages on debian 9.
The database though has been restored a couple of times, during migrations from
previous installations.  

I have rebooted the server, yet the problem persists. 
Have since upgraded to the latest package version -was already at 21.05 though-
however the library list still comes up empty. 

MP

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com,
   ||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28906

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||28906


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906
[Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28883
 Depends on||26223


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223
[Bug 26223] The OPAC ISBD view does not display item information
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28906] New: Koha::Items->filter_by_visible_in_opac doesn't honour list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Bug ID: 28906
   Summary: Koha::Items->filter_by_visible_in_opac doesn't honour
list context
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #97 from Alexis Ripetti  ---
(In reply to Jonathan Druart from comment #88)
> Alexis, did you run the QA script on those patches?

Yes I did.
I missed one.
I just fixed it. But the other one is just a git manipulation error and I don't
know how to fix it.
There are some spelling errors too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124097|0   |1
is obsolete||

--- Comment #96 from Alexis Ripetti  ---
Created attachment 124111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124111=edit
Bug 19368 - Deleting useless variables in datatables.inc

I tried to understand where it was used but I finally came to the conclusion
that this is useless.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124096|0   |1
is obsolete||

--- Comment #95 from Alexis Ripetti  ---
Created attachment 124110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124110=edit
Bug 19368 - (QA follow-up) Correction on QA feedback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124095|0   |1
is obsolete||

--- Comment #94 from Alexis Ripetti  ---
Created attachment 124109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124109=edit
Bug 19368 - Added missing closing bracket at the end of serials-search.pl

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124094|0   |1
is obsolete||

--- Comment #93 from Alexis Ripetti  ---
Created attachment 124108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124108=edit
Bug 19368 - clearly state, in the pref's desc, that the comparison is done
against unaccented title

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124093|0   |1
is obsolete||

--- Comment #92 from Alexis Ripetti  ---
Created attachment 124107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124107=edit
Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left
hanging in serials.pref

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124092|0   |1
is obsolete||

--- Comment #91 from Alexis Ripetti  ---
Created attachment 124106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124106=edit
Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124091|0   |1
is obsolete||

--- Comment #90 from Alexis Ripetti  ---
Created attachment 124105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124105=edit
Bug 19368 - Correction on QA feedback

* I removed the IGNORE in the atomicupdate SQL. There is currently no other
systempreference by that name in Master so that should work fine
- Removed leftover test values from syspref.sql
- Removed extra $ in serial-search.tt
- Removed leftover warn in serial-search.pl

Passes QA test tool
Signed-off-by: Alex Buckley 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #124090|0   |1
is obsolete||

--- Comment #89 from Alexis Ripetti  ---
Created attachment 124104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124104=edit
Bug 19368 - Ignore words when sorting serial search

This adds the 'SerialSortIgnoreWords' system preference.
It is empty by default, since words to ignore are very much language-specific.

The functionality is achieved by adding a hidden column to the table, and
sorting by this column by default. The downfall of this solution is that if the
user sorts by another column, they cannot go back to this sorting without
refreshing the page.

To test:
0) Apply patch
1) Run updatedatabase.pl
2) Add test subscriptions if you have none.
Make sure to have subscriptions starting with "The An A" or similar
3) Go to system preferences and edit the SerialSortIgnoreWords pref
Add the words "The An A" or the ones you used in your subscriptions
4) Go to Serials
5) Search serials (empty field will return all serials)
6) Result table should be sorted ignoring leading "The An A..."

Followed test plan, patch works as described
Signed-off-by: Alex Buckley 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #124102|0   |1
is obsolete||

--- Comment #16 from Tomás Cohen Arazi  ---
Created attachment 124103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124103=edit
Bug 26223: (QA follow-up) Fix filter order

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #13)
> (In reply to Marcel de Rooy from comment #7)
> > Seems to work as it is, but I am just wondering if we should force scalar
> > context within the map statement of _wrap ?
> 
> This is nonsense. We are going to the singular class

Been there, heh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 124102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124102=edit
Bug 26223: (QA follow-up) Fix filter order

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #124099|0   |1
is obsolete||

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 124101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124101=edit
Bug 26223: include item information in OPAC ISBD view

The ISBD view in the OPAC interface does not display item information.

This patch fixes that.

Test plan:
0) Have a biblio with at least one item attached to it and include one
   of the following snippets in the OPACISBD system preference,
   depending on your MARC flavour:

   MARC21:
   #952|ItemsCopy numberShelving
   locationKoha item typeBarcodeCall number
   (Full call number)Materials specified (bound volume or
   other part)|{952t}  {952c}  {952y}
{952p}  {952o}  {9523}|

   UNIMARC:
   #995|ItemsCopy numberShelving
   locationKoha collectionBarcodeCall number
   (Full call number)Numbering (volume or other part)|
   {9956}  {995e}  {995h}  {995f}
{995k}  {995l}|

   Switch to the OPAC ISBD view for your biblio; notice how it does
   not display item information.
1) Apply the patch, and restart Plack/memcached if necessary.
2) Refresh the OPAC ISBD view page, this time you should see item
   information as per the OPACISBD system preference setting.

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

--- Comment #13 from Tomás Cohen Arazi  ---
Well, and I would do:

my @items = $biblio->items->filter_by_visible_in_opac;

it will save lots of CPU cycles in some cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

--- Comment #12 from Tomás Cohen Arazi  ---
It seems to me that the order in which the filters are listed should be
swapped. We want the items to be embedded and THEN their subfields filtered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28902] Grey color should be on label for record metadata

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902

Owen Leonard  changed:

   What|Removed |Added

 Attachment #124098|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 124100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124100=edit
Bug 28902: Grey color on label for record metadata

Actually looking at a record search or details, we see a black label
(for example "Author:") and a grey metadata (for example "J.R.R Tolkien").

Seems bad for accessibility.
In my opinion the most important to see is the metadata not the label.

It is possible to change with a custom CSS but I open this report to
propose to change default display.

Test plan :
1) Apply patch and build CSS in OPAC and staff interface
2) Search for any record in OPAC/Staff interface
3) You see grey label and black metadata

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28902] Grey color should be on label for record metadata

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28905] New: Make it possible to hide export column in table configuration in checkouts

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28905

Bug ID: 28905
   Summary: Make it possible to hide export column in table
configuration in checkouts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When ExportCircHistory is enabled, there is an extra column "Export" visible in
the table of checkouts on the details and checkouts tabs in staff.

This column/functionality is not needed often and it would be great if it could
be set to hidden by default via the table configuration options.

At the moment the column is explicitly set so it cannot be hidden/toggled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904

--- Comment #2 from Katrin Fischer  ---
Sorry for the typo!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904

--- Comment #1 from Michael Kuhn  ---
My name is Michael Kuhn :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of button plus/less

2021-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

Marcel de Rooy  changed:

   What|Removed |Added

  Component|Searching   |OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >