[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|NEW |ASSIGNED Assignee|kyle.m.h...@gmail.com |alei...@catalyst.net.nz --- Comment #4 from Aleisha Amohia --- Hi all, this is a required feature for one of our libraries so I will give it a go! Just wanting to clarify some behaviour - would we prefer for the item to be due at closing time, or does their loan period get extended to opening time the following open day? For example, my library closes at midnight (12am) and opens at 8am tomorrow. If I issue a 2 hour loan at 11pm, should the item be due in one hour at 12am (closing time), or at 8am tomorrow (opening time)? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28710] Formatting values startng with 0 in numbering patterns are confusing to users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28710 --- Comment #3 from Andrew Fuerste-Henry --- +1! This would be a huge help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28940] IntranetUserJS is called twice on spinelable-print.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940 Lucas Gass changed: What|Removed |Added Summary|IntranetUserJS will fire|IntranetUserJS is called |off twice |twice on ||spinelable-print.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28940] IntranetUserJS will fire off twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940
--- Comment #1 from Lucas Gass ---
Created attachment 124415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124415=edit
Bug 28940: In spinelabel-print.tt call IntranetUserJS only once
1. In IntranetUser add some JS that will target spinelabel-print.tt, I used
this:
if ( $('#labels_spinelabel-print').length ) {
$('#labels_spinelabel-print').append('TEST');
console.log('TEST');
}
2. Generate a quick spine label
3. Once you have entered a barcode the JS will go off 2x. With the jQuery added
you will see 2 div's with the word 'TEST'. Look at the console and you will
also see TEST console logged 2x.
4. Apply patch
5. Try seto 2 and 3 again, the JS should only be called once.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28940] IntranetUserJS will fire off twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28940] IntranetUserJS will fire off twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940 Lucas Gass changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |lu...@bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #9 from Fridolin Somers --- (In reply to Martin Renvoize from comment #8) > I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower > level by cleaning the search query so you yield the right results rather > than hiding any results. OK maybe we just keep this fix for versions < 21.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28908] Bug 18017 removed indexing field 245
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908 --- Comment #2 from Fridolin Somers --- (In reply to Jonathan Druart from comment #1) > Fridolin, you are the author of bug 18017! Yes but I ask for a non-technic point of view. People are discussing it at Biblibre, I will report it here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28940] New: IntranetUserJS will fire off twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940
Bug ID: 28940
Summary: IntranetUserJS will fire off twice
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Label/patron card printing
Assignee: cnighswon...@foundations.edu
Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
TO recreate:
Add some IntranetUserJS that will target spinelabel-print.tt. I added this:
if ( $('#labels_spinelabel-print').length ) {
$('#labels_spinelabel-print').append('TEST');
console.log('TEST');
}
Try to do a quick spine label. Once you have entered a barcode the JS will go
off 2x. With the jQuery added you will see 2 div's with the word 'TEST'.
Look at the console and you will also see TEST console logged 2x.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28710] Formatting values startng with 0 in numbering patterns are confusing to users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28710 Katrin Fischer changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 28939 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28939] Subscription formatting should not start at 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28939 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 28710 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28939] Subscription formatting should not start at 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28939 Andrew Fuerste-Henry changed: What|Removed |Added CC||bwsdo...@gmail.com, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com, ||sbr...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28939] New: Subscription formatting should not start at 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28939 Bug ID: 28939 Summary: Subscription formatting should not start at 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In subscription numbering patterns, one can set Koha to sub in season, month, or day of week in place of a number. But those substitutions all start with zero (so for months, 0=January, 1=February, and so on). This adds extra confusion to what's already an complicated module. We should make these values start at 1, as human counting works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard changed: What|Removed |Added Blocks||28937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard changed: What|Removed |Added Depends on||28938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard changed: What|Removed |Added Depends on|28928 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 Owen Leonard changed: What|Removed |Added Blocks|28937 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard changed: What|Removed |Added Blocks|28938 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 Owen Leonard changed: What|Removed |Added Blocks||28938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard changed: What|Removed |Added Depends on|28937 |28928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
--- Comment #1 from Owen Leonard ---
Created attachment 124414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124414=edit
Bug 28938: Correct Flatpickr's default 12hr time formatting
This patch corrects Flatpickr's default 12 time formatting so that it
uses the formatting token "G" ("Hours, 2 digits with leading zeros")
instead of "h" ("Hours, 2 digits without leading zeros").
This will prevent incorrect times from being saved when the submitted
time is before 12.
- To test, apply the patch go to Administration -> System preferences.
- Set the TimeFormat system preference to "12 hour"
- Find an item which is checked out and renewable.
- Go to Circulation -> Renew and use the date picker to select a time <
12, e.g. 9:00 AM
- Submit the barcode for renewal.
- Check the patron's account to see the due date of the renewed item: It
should match the date and time you selected.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Owen Leonard changed: What|Removed |Added Blocks||28938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28938] New: Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Bug ID: 28938 Summary: Correct Flatpickr's default 12hr time formatting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: jonathan.druart+k...@gmail.com, testo...@bugs.koha-community.org Depends on: 28937 In calendar.inc we define the variable "flatpickr_timeformat_string" using this string: "h:i K" This results in times which don't include a leading zero (https://flatpickr.js.org/formatting/), a format which doesn't seem to be expected by the Perl script. It should be "G" To reproduce: - Set the TimeFormat system preference to "12 hour" - Find an item which is checked out and renewable. - Go to Circulation -> Renew and use the date picker to select a time < 12, e.g. 9:00 AM - Submit the barcode for renewal. - Check the patron's account to see the due date: Instead of being due on your selected date at 9:00AM it will be due on your selected date at 12:00AM. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in BorrowerUnwantedField and related sysprefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in BorrowerUnwantedField and related sysprefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936 --- Comment #1 from Lucas Gass --- Created attachment 124413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124413=edit Bug 28936: Add sort1/sort2 to borrowers.json To Test: 1. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences, sort1 and sort2 cannot be hidden or required 2. Apply patch 3. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences again, you should see sort1 and sort2 4. Since sort1 and sort2 are now added to borrowers.json we must also check the system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields 5. They should both now include sort1 and sort2, check to make sure they work with these two system preferences 6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField, PatronSelfRegistrationBorrowerUnwantedField, and PatronSelfModificationBorrowerUnwantedField 7. sort1 and sort2 should be disabled in these OPAC system preferences This patch does not attempt to add sort1 or sort2 to the self reg or borrower mod pages. If they should be added, which I am not sure they should, we should do so in a seperate bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in BorrowerUnwantedField and related sysprefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 124412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124412=edit Bug 26080: (QA follow-up) Add POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 124411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124411=edit Bug 26080: (QA follow-up) Minor template issues Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 124410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124410=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 124409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124409=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Signed-off-by: Fridolin Somers Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 124408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124408=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123991|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123990|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123989|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Tomás Cohen Arazi --- There's an XML problem I noticed with the syntax highlighter: ✔ ~/git/koha [qa_25716 ↑·2|✚ 1⚑ 33] 12:57 $ xmllint etc/koha-conf.xml etc/koha-conf.xml:271: parser error : Double hyphen within comment:
[Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28682 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28484 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28682 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28316 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower level by cleaning the search query so you yield the right results rather than hiding any results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Martin Renvoize changed: What|Removed |Added Blocks||26314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What|Removed |Added Depends on||28484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Martin Renvoize changed: What|Removed |Added Blocks||11175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Depends on||28484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Blocks||11175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Depends on||28316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 [Bug 28316] Fix ES crashes related to various punctuation characters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #323 from Martin Renvoize --- Created attachment 124404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124404=edit Bug 11175: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124155|0 |1 is obsolete|| --- Comment #322 from Martin Renvoize --- Created attachment 124403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124403=edit Bug 11175: (QA follow-up) Fixes for bug 12561 Bug 12561 changed the prototype for XSLTParse4Display so this patcha accounts for the additional calls to that method introduced in this patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124154|0 |1 is obsolete|| --- Comment #321 from Martin Renvoize --- Created attachment 124402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124402=edit Bug 11175: (QA follow-up) Rename back to get_marc_components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124153|0 |1 is obsolete|| --- Comment #320 from Martin Renvoize --- Created attachment 124401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124401=edit Bug 11175: Display components in own tab This patch updates the display so that rather than displaying the components using the main XSLT and then using CSS to move them into a box on the right side for display, which causes issues with RTL records; We instead add them in a new tab beneath the rest of the record details alongside holdings and other details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124152|0 |1 is obsolete|| --- Comment #319 from Martin Renvoize --- Created attachment 124400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124400=edit Bug 11175: (QA follow-up) Fix queries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124151|0 |1 is obsolete|| --- Comment #318 from Martin Renvoize --- Created attachment 124399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124399=edit Bug 11175: (QA follow-up) Only get biblio once Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124150|0 |1 is obsolete|| --- Comment #317 from Martin Renvoize --- Created attachment 124398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124398=edit Bug 11175: (QA follow-up) Move get_component_part_query This patch removes Koha::Util::Search in preference to embedding the search query builder in Koha::Biblio as get_analytics_query. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124149|0 |1 is obsolete|| --- Comment #316 from Martin Renvoize --- Created attachment 124397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124397=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124148|0 |1 is obsolete|| --- Comment #315 from Martin Renvoize --- Created attachment 124396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124396=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124147|0 |1 is obsolete|| --- Comment #314 from Martin Renvoize --- Created attachment 124395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124395=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124146|0 |1 is obsolete|| --- Comment #313 from Martin Renvoize --- Created attachment 124394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124394=edit Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124145|0 |1 is obsolete|| --- Comment #312 from Martin Renvoize --- Created attachment 124393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124393=edit Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124144|0 |1 is obsolete|| --- Comment #311 from Martin Renvoize --- Created attachment 124392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124392=edit Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124143|0 |1 is obsolete|| --- Comment #310 from Martin Renvoize --- Created attachment 124391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124391=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124142|0 |1 is obsolete|| --- Comment #309 from Martin Renvoize --- Created attachment 124390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124390=edit Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124141|0 |1 is obsolete|| --- Comment #308 from Martin Renvoize --- Created attachment 124389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124389=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124140|0 |1 is obsolete|| --- Comment #307 from Martin Renvoize --- Created attachment 124388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124388=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124139|0 |1 is obsolete|| --- Comment #306 from Martin Renvoize --- Created attachment 124387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124387=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124138|0 |1 is obsolete|| --- Comment #305 from Martin Renvoize --- Created attachment 124386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124386=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124137|0 |1 is obsolete|| --- Comment #304 from Martin Renvoize --- Created attachment 124385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124385=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124136|0 |1 is obsolete|| --- Comment #303 from Martin Renvoize --- Created attachment 124384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124384=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124135|0 |1 is obsolete|| --- Comment #302 from Martin Renvoize --- Created attachment 124383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124383=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #124134|0 |1 is obsolete|| --- Comment #301 from Martin Renvoize --- Created attachment 124382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124382=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #8 from Martin Renvoize --- Created attachment 124381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124381=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What|Removed |Added Attachment #124367|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 124380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124380=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Blocks||26314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What|Removed |Added Depends on||28316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 [Bug 28316] Fix ES crashes related to various punctuation characters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28326] If ElasticSearch enable is not possible to edit or save records with ' ES reserved charset' like []
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326 --- Comment #12 from Martin Renvoize --- Sorry.. bug 28484 which uses the work from bug 28316 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Martin Renvoize changed: What|Removed |Added CC||ha...@orex.es --- Comment #9 from Martin Renvoize --- *** Bug 28326 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28326] If ElasticSearch enable is not possible to edit or save records with ' ES reserved charset' like []
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326 --- Comment #11 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 28484 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added CC||ha...@orex.es --- Comment #90 from Martin Renvoize --- *** Bug 28326 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28326] If ElasticSearch enable is not possible to edit or save records with ' ES reserved charset' like []
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326 Martin Renvoize changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from Martin Renvoize --- I think this is now superseded by bug 28316 *** This bug has been marked as a duplicate of bug 28316 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Trivial patch after the work carried out by bug 28316.. passing QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Martin Renvoize changed: What|Removed |Added Attachment #123607|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 124379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124379=edit Bug 28484: ES clean title in biblio detail Test plan: - Create a biblio with title like "osteuropa:" or "osteuropa!" - Go the this biblio detail pages (cgi-bin/koha/catalogue/detail.pl) => Error - Apply bug 28316 and this one - test again Signed-off-by: Alex Buckley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #89 from Martin Renvoize --- Wow, this is a pretty rigorous treatment.. I'm impressed. I've tested to the extent of my knowledge and am really happy with the results. No regressions found, but I'd love to see it pushed and tested with various configurations in the wild with quick fixes to follow. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #88 from Martin Renvoize --- Created attachment 124378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124378=edit Bug 28316: (QA follow-up) Make clean_search_term public With all the work that's gone into improving the internal _clean_search_term method I feel we should expose it publically as it's going to be more widely helpful Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Attachment #123606|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 124377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124377=edit Bug 28316: escape ES ranges if QueryAutoTruncate is enabled if QueryAutoTruncate enabled we will have any special operators ruined for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]" so no reason to keep ranges when QueryAutoTruncate set to "enabled" 1) enable QueryAutoTruncate at your sysprefs. 2) perform a search using range, for example: "[1999 TO 2020]", it shouldn't work the way it's supposed to. 3) apply the patch. 4) perform the same search with range, ensure that it works correctly. Signed-off-by: Alex Buckley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Attachment #123605|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 124376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124376=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. Signed-off-by: Alex Buckley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Attachment #123604|0 |1 is obsolete|| --- Comment #85 from Martin Renvoize --- Created attachment 124375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124375=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Attachment #123603|0 |1 is obsolete|| --- Comment #84 from Martin Renvoize --- Created attachment 124374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124374=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning. To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Attachment #123602|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize --- Created attachment 124373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124373=edit Bug 28316: screen unquoted semicolons and all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that remove the colons at the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Martin Renvoize changed: What|Removed |Added Attachment #123601|0 |1 is obsolete|| --- Comment #82 from Martin Renvoize --- Created attachment 124372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124372=edit Bug 28316: add tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28392] streettype and B_streettype cannot be hidden via BorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #124370|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 124371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124371=edit Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField To test: 1. Add values to the AV ROADTYPE 2. Go to the BorrowerUnwantedField system preference and attempt to hide streettype and B_streettype. 3. It doesn't work, the fields still show. 4. Apply patch 5. Repeat step 2, it should work now. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28392] streettype and B_streettype cannot be hidden via BorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #6 from Martin Renvoize --- Regarding the eval Fridolin mentions.. I'm tempted to switch the get_volumes_query routine to using build_query_compat internally instead which should yield us a more reliably constructed search query string with special characters removed. That way, with bug 28316 work progressing we will get the advantages it brings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13371] Add filters to the supplier list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28922 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28922] Vendor search has poor performance when system has many vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28922 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13371 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28392] streettype and B_streettype cannot be hidden via BorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
