[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added Attachment #124830|0 |1 is obsolete|| --- Comment #5 from Hayley Pelham --- Created attachment 124852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124852=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27432] Add report run to action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #26 from David Cook --- (In reply to Fridolin Somers from comment #25) > We need a unit test. > Maybe in t/db_dependent/Log.t. > > Actually there are no test for other reports actions right ? That's what I was wondering too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29000] Create a display of patrons with permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 --- Comment #5 from David Cook --- (In reply to Fridolin Somers from comment #4) > (In reply to David Cook from comment #3) > > I have it in the Tools module with the label "User Audit", but I suppose it > > should be in the "Patrons" module? Maybe next to "Patron lists" we could > > have a "Permission audit" or "Permission review" button? > > Yep. > Maybe a link "Patrons with permissions" ;) Well, all patrons have permissions though, even if it's minimal permissions. That would also take up a lot of room on the screen on a Patrons toolbar. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28990] Allow changes for a configurable subset of systempreferences by superlibrarian only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 --- Comment #11 from David Cook --- (In reply to Fridolin Somers from comment #10) > In my opinion storing security settings inside database is not good. I think it's arguable about whether an Identity Provider counts as a security setting per se. Or are you referring to different settings? > We often copy database from a production server to a test server, where > security is on purpose lower. That sounds like an internal problem? What's the risk that you're worried about here? Data breach? > For me the best place is koha-conf.xml, it already contains major security > settings (authentication, path, ...) As a vendor, I like storing things in configuration files (although I hate the bloated koha-conf.xml), since they're more secure and easier to deploy programmatically. But as a consumer, we'd be removing functionality from Koha. I think that's the point that Donna is making. Unless you have the wealth to pay for a vendor or internal staff, you might not be able to configure those settings anymore. (Of course, one could argue there are many settings in Koha that already work that way.) -- Ultimately, it doesn't matter to me, as I have power. I'm just thinking about removing options from people who don't have as much power. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29000] Create a display of patrons with permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 --- Comment #4 from Fridolin Somers --- (In reply to David Cook from comment #3) > I have it in the Tools module with the label "User Audit", but I suppose it > should be in the "Patrons" module? Maybe next to "Patron lists" we could > have a "Permission audit" or "Permission review" button? Yep. Maybe a link "Patrons with permissions" ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27432] Add report run to action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #25 from Fridolin Somers --- We need a unit test. Maybe in t/db_dependent/Log.t. Actually there are no test for other reports actions right ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #25) > (In reply to Marcel de Rooy from comment #24) > > (In reply to Joonas Kylmälä from comment #18) > > > > > This patch does not alter the message we are giving out, we already say > > > before this patch explicitly in the OPAC GUI whether a list is Public or > > > not. So I wouldn't take that into consideration whether to accept this > > > patch > > > or not. If we want to use another naming it can be done even after this > > > patch, this patch doesn't make it any harder as far as I can tell. > > > > So, we implicitly already have three categories. And some requests show that > > people are still shaking the tree. Might extending categories solve that? > > Not sure. But we choose to put that aside here and make it a boolean. I have > > no strong arguments against it but just have the intuitive feeling that this > > may not be the right direction :) > > I also had the feeling we could keep a place for a third value. > But the need here is for API routes to know if datas can be open to the > public or not. That is binary. Isn't the fact that a list is shared just another boolean? What if we decided to make lists shareable with specific patrons or categories? We need stop doing things implicitly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28990] Allow changes for a configurable subset of systempreferences by superlibrarian only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 --- Comment #10 from Fridolin Somers --- In my opinion storing security settings inside database is not good. We often copy database from a production server to a test server, where security is on purpose lower. For me the best place is koha-conf.xml, it already contains major security settings (authentication, path, ...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #25 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #24) > (In reply to Joonas Kylmälä from comment #18) > > > This patch does not alter the message we are giving out, we already say > > before this patch explicitly in the OPAC GUI whether a list is Public or > > not. So I wouldn't take that into consideration whether to accept this patch > > or not. If we want to use another naming it can be done even after this > > patch, this patch doesn't make it any harder as far as I can tell. > > So, we implicitly already have three categories. And some requests show that > people are still shaking the tree. Might extending categories solve that? > Not sure. But we choose to put that aside here and make it a boolean. I have > no strong arguments against it but just have the intuitive feeling that this > may not be the right direction :) I also had the feeling we could keep a place for a third value. But the need here is for API routes to know if datas can be open to the public or not. That is binary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #10 from Fridolin Somers --- Thanks for the info David :) I mean here : https://git.koha-community.org/Koha-community/Koha/src/commit/a5a3a330cfc7c7d6c35db13326745dabf8fe0df3/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt#L115 We must replace with "Log in" right ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #13 from Agustín Moyano --- Created attachment 124851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124851=edit Bug 27947: Add cancellation reason to article request This bug adds a cancellation reason authorised values to article requests To test: 1. apply this patch 2. updatedatabase 3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl CHECK => AR_CANCELLATION category should appears 4. place several article requests 5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl 6. select multiple requests, or just one and cancel them SUCCESS => a modal pops up offering to select a cancellation reason CHECK => message_queue table has messages with cancellation reason included 7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl 8. cancelling article requests from opac interface should work just as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #12 from Agustín Moyano --- Created attachment 124850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124850=edit Bug 27947: [DO NOT PUSH] update ArticleRequest schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Agustín Moyano changed: What|Removed |Added Attachment #124063|0 |1 is obsolete|| Attachment #124064|0 |1 is obsolete|| Attachment #124065|0 |1 is obsolete|| --- Comment #11 from Agustín Moyano --- Created attachment 124849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124849=edit Bug 27947: Add authorised values list in article requests cancellation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28864] The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- Micheal, I'm happy to test this if you could add a test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Lucas Gass changed: What|Removed |Added Attachment #124453|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 124848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124848=edit Bug 28942: Use Flatpickr on acquisitions pages This patch modifies several acquisitions pages replacing jQuery datepickers with Flatpickr widgets. To test, apply the patch and test datepickers on the following Acquisitions pages: - Acquisitions -> Late orders (linked date fields in the sidebar) - Acquisitions -> Invoices (linked date fields in the sidebar) - Acquisitions -> Invoices -> Invoice details (shipment date and billing date) - Acquisitions -> Vendor -> Receive shipment (shipment date) - Acquisitions -> Vendor -> Receive shipment -> Receive (on order line) -> Date received field under "Accounting details - Acquisitions -> Orders search tab in the header -> Advanced search: Linked date fields in the search form." Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Lucas Gass changed: What|Removed |Added Blocks||28942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 [Bug 28942] Use Flatpickr on acquisitions pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Depends on||28937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #43 from Jonathan Druart --- Created attachment 124847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124847=edit Bug 28786: Add tests for checkauth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #42 from Jonathan Druart --- Created attachment 124846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124846=edit Bug 28786: Correctly inherit from Auth::GoogleAuth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27887] Patrons should not receive overdue notices for claimed returns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27887 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #1 from Rebecca Coert --- We would absolutely, 100% like to see this function. Staff have told us that they spend a lot of time discussing this with patrons, who are sometimes irate for having us contact them regarding an item that they've already told us they've RETURNED. We search our locations several times for these items, and receiving these notices creates extra work for everyone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25825] Allow Claim Return function to be controlled by permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #5 from Rebecca Coert --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #41 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #34) > +package Koha::Auth::TwoFactorAuth; > +=head1 NAME > + > +Koha::Encryption - Koha class to encrypt or decrypt strings > > Hmm Oops, fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Attachment #124771|0 |1 is obsolete|| --- Comment #40 from Jonathan Druart --- Created attachment 124845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124845=edit Bug 28786: Improve readability in C4::Auth::checkauth Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Attachment #124770|0 |1 is obsolete|| --- Comment #39 from Jonathan Druart --- Created attachment 124844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124844=edit Bug 28786: Two-factor authentication for staff client - TOTP This patchset introduces the Two-factor authentication (2FA) idea in Koha. It is far for complete, and only implement one way of doing it, but at least it's a first step. The idea here is to offer the librarian user the ability to enable/disable 2FA when logging in to Koha. It will use time-based, one-time passwords (TOTP) as the second factor, an application to handle that will be required. https://en.wikipedia.org/wiki/Time-based_One-Time_Password More developements are possible on top of this: * Send a notice (sms or email) with the code * Force 2FA for librarians * Implementation for OPAC * WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/ Test plan: 0. a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all b. To test this you will need an app to generate the TOTP token, you can use FreeOTP that is open source and easy to use. 1. Turn on TwoFactorAuthentication 2. Go to your account, click 'More' > 'Manage Two-Factor authentication' 3. Click Enable, scan the QR code with the app, insert the pin code and register 4. Your account now requires 2FA to login! 5. Notice that you can browse until you logout 6. Logout 7. Enter the credential and the pincode provided by the app 8. Logout 9. Enter the credential, no pincode 10. Confirm that you are stuck on the second auth form (ie. you cannot access other Koha pages) 11. Click logout => First login form 12. Enter the credential and the pincode provided by the app Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26865] Double quotes in patron's data breaks patron searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26865 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #38 from Jonathan Druart --- Martin and Marcel, thank you for your interest in this patch set! As you noted, C4::Auth is not an easy place, and we all know that. It was hard to write code that followed the different "check auth" methods, I reworked the code to make the code isolated enough to be located in only one place (checkauth). And I wrote it, it was the best solution I found without having to rewrite more parts. There are more to implement but, as said in the commit message, the idea was to provide a first step, without reworking the whole C4::Auth code. I would like to get more funding to work on follow-up bugs, but as of today I have already exploded the time I could dedicate to this bug. (In reply to Martin Renvoize from comment #33) > So, personally, I would pass around a 'varified' state linked to the session > (as you do I believe). Then, for any get_template_and_user calls I'd have > checked the verification status and redirected to a self-contained > verification controller for the MFA check... rather than folding the check > into Auth.pm and the login pages themselves. In this way you open up the > option to invalidate the verification without invalidating the session > entirely for things like patron modification for example (when we add this > to the opac.. I can see it being most helpful to not require the > verification step at first login but rather upon taking higher privilege > actions). > > Anywho.. I'll continue down the QA route but wanted to flag it in case you > had any feedback as to why you took this particular route rather than any > others? I don't follow what you suggest. A check in get_template_and_user is not enough, we need to catch other auth calls as well. (In reply to Marcel de Rooy from comment #37) > There was discussion about moving the secret to another table. I tend to > follow Tomas here. Two factor authentication now only includes TOTP, but we > could extend that. If we have several methods, they would (probably) have > their own secrets. So yes a separate table would be better. IMO it's out of the scope. That would put this bug in a dead-end situation. > In terms of security I wonder if we should let the user choose to enable > 2FA. If the library switches 2FA on, I would opt for enforcing it. How would > you let a user register at that point? Might be that you need some > verification mail mechanism here to allow access to the register page > exposing the shared key (QR). It's part of the enhancement I suggested in the commit message :) "* Force 2FA for librarians" > As for code, Koha/Auth/TwoFactorAuth.pm should be a folder or base class. > And the TOTP code should move deeper then? It's a first step, no need to make it more complex. We can still create the base class we will need it. > There is a Selenium test, but not a regular one? What tests would make you happy? I could add tests for Koha::Auth::TwoFactorAuth but it's based on Auth::GoogleAuth and only overwrite the constructor. Or are you asking for C4::Auth::checkauth tests? With selenium tests we are testing the whole workflow, they are robust and I am very happy with them as they helped me a lot during the development process. > The "Improve readability" patch triggers this remark ;) The code in C4::Auth > is very essential, but already a pain. The maintenance of it by adding the > 2FA will be even harder. No one volunteers to rewrite it, but wouldnt this > be a great opportunity? Just hoping.. The current changes with a nice "ugly > trick" are not the greatest base for confidence. I am open to suggestions to improve the code I've added, and isolate more the code. But I spent a lot of time and tried different approaches before ending with that one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #4 from David Nind --- > What options did you use to generate that error? I'm not able to reproduce > it. This was with and without selecting any date ranges, With koha-testing-docker (started with ku) it is using MariaDB 10.1 with Debian 9. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28940] IntranetUserJS is called twice on spinelable-print.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #124415|0 |1
is obsolete||
--- Comment #2 from Andrew Fuerste-Henry ---
Created attachment 124843
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124843=edit
Bug 28940: In spinelabel-print.tt call IntranetUserJS only once
1. In IntranetUser add some JS that will target spinelabel-print.tt, I used
this:
if ( $('#labels_spinelabel-print').length ) {
$('#labels_spinelabel-print').append('TEST');
console.log('TEST');
}
2. Generate a quick spine label
3. Once you have entered a barcode the JS will go off 2x. With the jQuery added
you will see 2 div's with the word 'TEST'. Look at the console and you will
also see TEST console logged 2x.
4. Apply patch
5. Try seto 2 and 3 again, the JS should only be called once.
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28940] IntranetUserJS is called twice on spinelable-print.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Michael Hafen changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #3 from Michael Hafen --- (In reply to David Nind from comment #2) > I had a go at testing with koha-testing-docker (KTD), but was unable to get > this to work. > > - KTD = started with ku > - Strict mode already set in /etc/koha/sites/kohadev/koha-conf.xml > > Error before patch applied, no change after (with a flush_memcached and > restart_all): > > CGI::Compile::ROOT::kohadevbox_koha_reports_cat_issues_top_2epl::calculate(): > DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.biblio.title' > isn't in GROUP BY at /kohadevbox/koha/reports/cat_issues_top.pl line 64 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 > > I think I will leave the testing to someone who understands how this all > works a bit better than I do! What options did you use to generate that error? I'm not able to reproduce it. I didn't test this report thoroughly, so I'm sure there is more work to be done here. Now that I'm playing with it a bit more the "distinct" is causing trouble too with Mysql 8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 [Bug 29007] Prompt for reason when cancelling waiting hold via popup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29007] New: Prompt for reason when cancelling waiting hold via popup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Bug ID: 29007 Summary: Prompt for reason when cancelling waiting hold via popup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 25534 To recreate: - have a HOLD_CANCELLATION auth value - have an item waiting for pickup for a hold - check the item in, prompting the "item is already waiting" popup - on that popup, select "Cancel" - the hold is cancelled and you are not given a chance to apply a reason Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to specifying and store a reason when cancelling a hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #3 from Kyle M Hall --- (In reply to Katrin Fischer from comment #2) > Will it still be possible to print the whole queue over multiple pages? Yes, you can choose the number of results per page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 --- Comment #8 from Kyle M Hall --- Created attachment 124842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124842=edit Bug 28510: Remove unused variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #36 from Kyle M Hall --- Started an API Users Guide on the Wiki: https://wiki.koha-community.org/wiki/Koha_REST_API_Users_Guide -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Owen Leonard changed: What|Removed |Added Blocks||29006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 [Bug 29006] Make GoogleOpenIDConnect options consistent in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29006] New: Make GoogleOpenIDConnect options consistent in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Bug ID: 29006 Summary: Make GoogleOpenIDConnect options consistent in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 10988 In the OPAC, when GoogleOpenIDConnect is enabled, the login options are inconsistent: - The "Log in to your account" link in the header takes you straight to a Google form. - The login form on the main page doesn't offer a link to Google login, just the standard login form. - The login page offers both a GoogleOpenIDConnect link and a standard login form. If GoogleOpenIDConnect is enabled, all login options should offer both Google and Koha login. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29005] New: Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Bug ID: 29005 Summary: Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be helpful to add automatic email to users on patron imports. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 --- Comment #1 from Owen Leonard --- Created attachment 124841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124841=edit Bug 29004: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only This patch modifies the description of the GoogleOpenIDConnect and related preferences to make it clear that GoogleOpenIDConnect affects OPAC logins and that the preferences are related. To test, apply the patch and go to Administration -> System preferences. Search for "google," and confirm that the descriptions of GoogleOpenIDConnect and related preferences look clear and correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Owen Leonard changed: What|Removed |Added Blocks||29004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 [Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29004] New: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 Bug ID: 29004 Summary: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 10988 GoogleOpenIDConnect and related system preferences only affect the OPAC, but the system preference descriptions don't make that explicit. The description should be modified to mention that it only applies to the OPAC. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28935 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #23 from Kyle M Hall --- (In reply to Fridolin Somers from comment #18) > This bug is now even more relevant for security reasons Given that, I've rebased this patch set. I haven't tested it at all yet. Please let me know if it any issue! Given the age of the patches, I think a fresh sign-off is in order! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #22 from Kyle M Hall --- Created attachment 124836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124836=edit Bug 20813: Remove deleted table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #21 from Kyle M Hall --- Created attachment 124835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124835=edit Bug 20813: Revamp user permissions system Koha's current user permissions system is a bit convoluted and limited due to it's legacy where the permissions system was a simple set of flags. A second layer of sub-permissions were later added complication and obfuscation to the system. We should revamp the permissions system to be a more modern system and open the path to having unlimited nesting of sub-permissions instead of shoe-horning sub-permissions into the limited system we have. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Koha should still enforce user permissions as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Attachment #75542|0 |1 is obsolete|| Attachment #75543|0 |1 is obsolete|| Attachment #75544|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 124834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124834=edit Bug 20813: Update db schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29003] Apply different reasons via cancel_expired_holds cron based on found value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003 --- Comment #1 from Andrew Fuerste-Henry --- Actually, reiterating the importance of this a bit, if a library is using ExpireReservesMaxPickUpDelayCharge then an auto-cancelled waiting hold will result in a fee but an auto-cancelled non-waiting hold will not. That's not new behavior or anything, but it definitely would be helpful to be able to easily know that in the notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Allow a CANCELLATION_REASON to be specified on the cancel_expired_holds.pl job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003 [Bug 29003] Apply different reasons via cancel_expired_holds cron based on found value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29003] New: Apply different reasons via cancel_expired_holds cron based on found value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003 Bug ID: 29003 Summary: Apply different reasons via cancel_expired_holds cron based on found value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 12656 Bug 12656 allows one to define a cancellation reason when running the cancel_expired_holds cron. That reason is recorded for later reporting and also triggers a notice. That cron cancels both holds that have simply never had an item captured *and* holds where the item has been waiting on the hold shelf past the pickup delay. Ideally, we'd be able to tell the cron to apply two different reasons in these two very distinct cases. Maybe the cron could take a pair of [found value]=[reason]? So you could set it with something like: 'W'='TOO_LONG' NULL='UNFILLED' Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 [Bug 12656] Allow a CANCELLATION_REASON to be specified on the cancel_expired_holds.pl job -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--- Comment #26 from Kyle M Hall ---
Is the last patch failing to apply for anyone else?
Applying: Bug 28803: (follow-up) Error details improvement
.git/rebase-apply/patch:71: trailing whitespace.
Koha::Exceptions::BadParameter->throw({ parameter => $address, error =>
error: sha1 information is lacking or useless (C4/Letters.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 28803: (follow-up) Error details improvement
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #37 from Marcel de Rooy --- Not a complete QA, but at least some remarks: Nice development! Would like to see 2FA in Koha. There was discussion about moving the secret to another table. I tend to follow Tomas here. Two factor authentication now only includes TOTP, but we could extend that. If we have several methods, they would (probably) have their own secrets. So yes a separate table would be better. In terms of security I wonder if we should let the user choose to enable 2FA. If the library switches 2FA on, I would opt for enforcing it. How would you let a user register at that point? Might be that you need some verification mail mechanism here to allow access to the register page exposing the shared key (QR). As for code, Koha/Auth/TwoFactorAuth.pm should be a folder or base class. And the TOTP code should move deeper then? There is a Selenium test, but not a regular one? The "Improve readability" patch triggers this remark ;) The code in C4::Auth is very essential, but already a pain. The maintenance of it by adding the 2FA will be even harder. No one volunteers to rewrite it, but wouldnt this be a great opportunity? Just hoping.. The current changes with a nice "ugly trick" are not the greatest base for confidence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #22 from Nick Clemens --- Created attachment 124831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124831=edit Bug 28847: Remove dead code and make regex consistent This updates the regex code to match throughout the routine and removes code that would no longer be reached. Note that the code to update library name in the query descruiption was broken before this patch, so removal does not change behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #1 from Donna --- I think this is a great idea, and I have had other libraries ask about being able to do this. It will be well received! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard changed: What|Removed |Added Attachment #124322|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 124830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124830=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29002 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24718 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] New: Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Bug ID: 29002 Summary: Add ability to book items ahead of time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Normal loans allow a patron to pick an item and take it out immediately. Reserves allow a patron to add themselves to a queue for the item should it already be checked out to someone. We have a library that wishes to allow patrons to book items for a specific date and loan period and have the item guaranteed to be available to them for that period. This bug intends to introduce that functionality, adding a bookable option to items and exposing a calendar with bookable loan slots. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Patch doesn't apply --- Comment #51 from Martin Renvoize --- This looks interesting.. could we get a rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #36 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #35) > Template process failed: undef error - The method Koha::Patron->auth_method > is not covered by tests! No DBIx schema change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #35 from Marcel de Rooy --- Template process failed: undef error - The method Koha::Patron->auth_method is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries REST endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 --- Comment #15 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #14) > And have AllowList just read the library's defined lists... I mean not > implementing a new AllowList class for each thing Bug 28999 centralizes attributes lists in the schema file for the table. In the ColumnSet concept. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #34 from Marcel de Rooy --- +package Koha::Auth::TwoFactorAuth; +=head1 NAME + +Koha::Encryption - Koha class to encrypt or decrypt strings Hmm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What|Removed |Added Attachment #124746|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #25 from Martin Renvoize --- My final patch is an alternative to Jonathans.. it tries to improve the feedback given to the end user by embedding the parameter that failed validation into the error code and then adding this to the template output. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #24 from Martin Renvoize --- Created attachment 124829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124829=edit Bug 28803: (follow-up) Error details improvement This patch updates the exceptions thrown by Koha::Email to include the parameter that failed email validation and then updates the failure code to include this parameter and finally display this field in the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries REST endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 --- Comment #14 from Tomás Cohen Arazi --- Please, keep in mind that the API already has input/output validation, specified in the OpenAPI spec. That's why this dev was originally simple and only included a list of attributes for the 'public' context. Also, this allowed for easy implementation of calculated lists: frameworks telling what item structure to hide? Sysprefs? Also, keep in mind that public and staff are not the only representations we might want for resources: we could have a 'brief' representation to be used in dropdowns (id+name). I mention it, because that's where the simplicity came from. For what is worth, I think we should do use base wq(Koha::Object Koha::Object::AllowList) And have AllowList just read the library's defined lists... I mean not implementing a new AllowList class for each thing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #21 from Marcel de Rooy --- Changing status for comment17 and comment20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762
--- Comment #20 from Marcel de Rooy ---
So from this perspective looking at a new include, I see things like:
[% IF item.isa('Koha::Item') %]
..
[% IF NOT ( item.isa('Koha::Item') ) AND item.transfertwhen %]
Which is awful. Yes, I know that it comes from the opac include, but we should
really solve its twisted usage.
When we are starting at staff here, please use one consistent approach. Either
always pass a Koha object, or do something else. But keep it consistent.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy changed: What|Removed |Added Attachment #124744|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Comment on attachment 124744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124744 Bug 28762: (QA follow-up) A first attempt to sync the includes Coming here again, I think we are asking too much when insisting on a synced item status include. So I am obsoleting this follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #9 from Marcel de Rooy --- Please add feedback on especially the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999
--- Comment #8 from Marcel de Rooy ---
Created attachment 124828
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124828=edit
Bug 28999: {CONCEPT] Introduce Koha::Object::ColumnSet
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Summary|group floating rules|Add option to define float ||groups and rules for float -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Emmi Takkinen changed: What|Removed |Added Blocks|9525| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 [Bug 9525] group floating rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Emmi Takkinen changed: What|Removed |Added Blocks|9525| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 [Bug 9525] group floating rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on|13906, 13995| --- Comment #45 from Emmi Takkinen --- Attached new patches, removed dependencies on bug 13906 and bug 13995. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #44 from Emmi Takkinen --- Created attachment 124827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124827=edit Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #43 from Emmi Takkinen --- Created attachment 124826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124826=edit Bug 9525: DO NOT PUSH! Schema update Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #40102|0 |1 is obsolete|| Attachment #40103|0 |1 is obsolete|| Attachment #112550|0 |1 is obsolete|| Attachment #112551|0 |1 is obsolete|| Attachment #112552|0 |1 is obsolete|| Attachment #112553|0 |1 is obsolete|| --- Comment #42 from Emmi Takkinen --- Created attachment 124825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124825=edit Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Assignee|olli-antti.kivila...@jns.fi |emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #41 from Emmi Takkinen --- We are currently working on upcoming version update and have decided to ditch this floating matrix feature. Instead we've decided use float groups which work like hold groups introduced in bug 22284. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #7 from David Cook --- I spent a lot of time thinking this morning, and I'm not sure I see a purpose for filtering outbound data besides for the public API. And on the flipside the API has its own input validation so it wouldn't need an inbound data filter whereas the HTML UI does. I just wonder if we're trying to make this all too generic/comprehensive. The original premise was just filtering input from HTML forms. Maybe it makes more sense to do a RFC? I think this might be the 3rd or 4th report now for allow lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999
--- Comment #6 from Marcel de Rooy ---
The code for AllowList is generic now. But we need the ColumnSet to apply it to
Koha objects in various ways.
This is the idea:
Say $city is a Koha object.
$city->filter('opac_ui') returns city data through the opac_ui filter which is
just a set of columns for some purpose.
$city->filter('staff') could return some other subset or even nothing when the
set does not exist.
The sub filter calls Koha::Object::ColumnSet with the requested column set
name. The module calls the corresponding DBIx schema where we add a sub called
column_set_info containing the lists we need like a list for opac_ui.
ColumnSet runs a Koha::AllowList based on that list over the object data.
Hang on a little bit. Submitting some concept code shortly.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Marcel de Rooy changed: What|Removed |Added Summary|Add module for Allowlist / |Add Koha::AllowList, |ColumnFilter|DenyList and ||Koha::Object::ColumnSet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #5 from Marcel de Rooy --- Created attachment 124824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124824=edit Bug 28999: Add Koha::DenyList as counterpart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #4 from Marcel de Rooy --- Created attachment 124823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124823=edit Bug 28999: Remove (un)load, add reset; apply returns result now Remove load but add $defaults in new. Replace unload by reset, restoring defaults. Replace warn en verbose by a dump variable in apply. Do not return $blocked anymore but return the filtered input in apply. New check method returns true when no entries were blocked. New keys method to list current allow list entries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #3 from Marcel de Rooy --- Created attachment 124822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124822=edit Bug 28999: Additional check method, some parameter changes License for module. Remove interface parameter in new. Add dry_run parameter to apply. Add arrayref as input for apply. Add check as shortcut for apply with dry_run. Add tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
