[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #41 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #39)
> Sorry guys.. little more needed here.
>
> My first followup drops the 'reserveforothers' permission requirement as I
> don't think that relates to this functionality.. but it makes the API tests
> fail.. and I can't see why.. code blind on a Friday.
The permissions were wrong.
You just missed the fact that privileged routes require at least one permission
(catalogue: 1 being the bare minimum). I think we never fixed this:
https://gitlab.com/koha-community/qa-test-tools/-/issues/11
> My second followup highlights an issue with the public route. Although
> moving the route under /public/patrons/{patron_id} ensure we do a patron
> identity check.. there isn't actually a later check anywhere that the
> article your trying to delete actually belongs to the patron ;)
There's an implicit check by doing:
$article_requests = $patron->article_requests->find( $article_request_id );
I clarified this with a comment in the code on the latest patch. I agree with
returning 404 there, as 403 would 'leak' the fact that the ID exists... Not
sure how important it is, but I think it is correctly tested to avoid security
issues.
> This final one is actually why I preferred the original
> /article_requests/{request_id} approach.. though of course that would
> require the addition of a routine to handle checking borrowernumber in the
> article request against the user as per the other routines for checking
> allow-owner.
allow-owner falls short. It feels like with routes with multiple ids in the
path we need to think a bit more [1]. I think object 'ownership' validation
should be baked into the objects in a declarative way. But that's for another
day/bug.
[1] I tried adding a validator for article requests in Koha::REST::V1::Auth,
but it failed randomly depending on which 'key' was picked first (patron_id vs.
article_request_id). It feels like a big refactoring is needed there. Or just
keep the patron_id from the path and leave the rest to the controllers, as in
this bug.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 125016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125016=edit Bug 27947: (QA follow-up) Clarify permissions Privileged routes need permissions defined. This patch adds the minimum required permission until there are article request-specific permissions in Koha: circulate: circulate_remaining_permissions It is also clarified that interacting with an article request from another patron, but having your own patron_id in the path would return 404 instead of 403, as technically the resource (an article request from the patron, identified.by the supplied id) doesn't exist. Tests are tweaked. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 --- Comment #1 from Owen Leonard --- Created attachment 125015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125015=edit Bug 28438: Capitalization: Various corrections This patch makes capitalization corrections to many templates in the OPAC and staff interface. A exhaustive test plan would be huge, so I recommend examining the patch to confirm that it contains correct case changes. If you want to make it easier to examine changes you can try: https://github.com/so-fancy/diff-so-fancy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #63 from Martin Renvoize --- To clarify, the followups here that converted from string note to translatable code broke the feature entirely ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #62 from Martin Renvoize --- See bug 28813 where I fixed the issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29052] Make consistent use of spans and div with hint class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 --- Comment #1 from Owen Leonard --- Created attachment 125014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125014=edit Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in or . To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29052] Make consistent use of spans and div with hint class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29052] New: Make consistent use of spans and div with hint class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Bug ID: 29052 Summary: Make consistent use of spans and div with hint class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org When adding help text alongside input fields in staff interface forms the text should be wrapped in or . This patch will make corrections to several pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 [Bug 29051] Seen renewal methods incorrectly blocked -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29051] New: Seen renewal methods incorrectly blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Bug ID: 29051 Summary: Seen renewal methods incorrectly blocked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 24083 To recreate: 1 - turn on UnseenRenewals 2- confirm AllowRenewalLimitOverride is off 3- set your all/all rule to allow 1 unseen renewal, more than 1 regular renewal 4- check item out to patron, make sure you're following the all/all rule 5- renew item from OPAC as patron 6- confirm OPAC and intranet tell you next renewal must be at library but that you have renewals remaining 7- try to renew with the Renew Selected button in the Checkouts tab, you cannot select this checkout 8- try to renew with the Renew All button in the Checkouts tab, the item does not renew 9- try to check the item out to the patron again, get message "No more renewals possible" 10 - try to renew by putting the barcode in the big Renew box at the top of the page, get message "E Street shuffle : ( 1 ) has been renewed the maximum number of consecutive times without being seen by the library )" That leaves staff with no way to perform a Seen renewal and reset the count un Unseen renewals, which means the patron is stuck and the item must be returned, which makes this feature deeply flawed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 [Bug 24083] Koha should support "seen" vs "unseen" renewals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28895] Don't fill in items.location with NewItemsDefaultLocation if blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895 Hannah Co changed: What|Removed |Added CC||hannah...@northwestu.edu --- Comment #6 from Hannah Co --- (In reply to Andrew Fuerste-Henry from comment #5) > Actually, testing this on master this morning it's very much not working as > intended. > > I have NewItemsDefaultLocation set to PROC. > On additem.pl, when I create a load the new item page, location is > automatically set to PROC. If I create my item without changing it, the item > has both location and shelving_location set to PROC. > There is no reason to set the default to PROC here, but I guess it doesn't > hurt anything. > > On additem.pl, if I change the shelving location to any value other than > PROC before I create my item, both the location and permanent location are > set to whatever new value I've selected. > Whatever I've selected should go into permanent_location, but location > should be PROC. > > If I delete PROC without selecting something else on creating my item, then > location and permanent_location end up as PROC anyway. > This bug asserts that in this case I should get location=PROC and > permanent_location=NULL. I support that change. > > This could debatably be a new bug, but there are a lot of old bugs around > this syspref already. In order for UpdateItemLocationOnCheckin to work correctly for items with no shelving location, the NewItemsDefaultLocation needs to stay out of the permanent_location field. If NewItemsDefaultLocation is set to PROC, and UpdateItemLocationOnCheckin has the line "PROC: _PERM_" items with no shelving location remain in processing and don't get shelving location changed to NULL on checkin, as they should. I agree that at item creation, if a shelving location is not selected then the item should have location=PROC and permanent_location=NULL. When editing an item, the NewItemsDefaultLocation currently replaces a NULL value. If the shelving location is NULL, NewItemsDefaultLocation should not replace the NULL upon editing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 [Bug 29050] Add punctuation in Unseen Renewals message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29050] New: Add punctuation in Unseen Renewals message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Bug ID: 29050 Summary: Add punctuation in Unseen Renewals message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 24083 In the Checkouts tab of the patron record, the counts of renewals and unseen renewals need some punctuation. Right now they say something like "(W of X renewals remainingY of Z unseen renewals remaining." That needs at least a comma and a space in the middle, for ""(W of X renewals remaining, Y of Z unseen renewals remaining." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 [Bug 24083] Koha should support "seen" vs "unseen" renewals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #13 from Andrew Fuerste-Henry --- Hannah, just making sure you saw bug 28895. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28895] Don't fill in items.location with NewItemsDefaultLocation if blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895 --- Comment #5 from Andrew Fuerste-Henry --- Actually, testing this on master this morning it's very much not working as intended. I have NewItemsDefaultLocation set to PROC. On additem.pl, when I create a load the new item page, location is automatically set to PROC. If I create my item without changing it, the item has both location and shelving_location set to PROC. There is no reason to set the default to PROC here, but I guess it doesn't hurt anything. On additem.pl, if I change the shelving location to any value other than PROC before I create my item, both the location and permanent location are set to whatever new value I've selected. Whatever I've selected should go into permanent_location, but location should be PROC. If I delete PROC without selecting something else on creating my item, then location and permanent_location end up as PROC anyway. This bug asserts that in this case I should get location=PROC and permanent_location=NULL. I support that change. This could debatably be a new bug, but there are a lot of old bugs around this syspref already. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28895] Don't fill in items.location with NewItemsDefaultLocation if blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- Agreed, I would like to be able to set a blank shelving location on a new item, have it go to the location set in NewItemsDefaultLocation, then go to a blank shelving location on a later checkin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29049] Holds page shows too many priority options in pulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049 --- Comment #2 from Nick Clemens --- Created attachment 125013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125013=edit Bug 29049: (follow-up) Reduce number of line returns in page While moving the dropdown to a block, I noticed the page size was very large when there are many holds This patch chomps a large amoutn of whitespace, from the block and elsewhere and drecreased the paeg from about 400k lines to 25k lines for a record with ~200 holds To test: 1 - Apply previous patch 2 - Load holds tab for a biblio 3 - Save the page as html from your browser, note the size of the file 4 - Apply patch this 5 - Reload and repeat 6 - Note the size is much smaller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #12 from Hannah Co --- (In reply to Andreas Roussos from comment #9) > (In reply to Hannah Co from comment #6) > > I don't believe this patch catches items in "processing" that should end up > > with no shelving location. I have a freshly updated 21.05, with this patch > > included. My system pref UpdateItemLocationOnCheckin contains "PROC: > > _PERM_". Check-in does not make any changes to a record with "PROC" location > > and no other shelving location assigned. > > > > New items are automatically created with location AND permanent_location > > both set as PROC. It seems that "PROC" and "CART" should never populate > > permanent_location. Can we prevent "PROC" from populating the > > permanent_location? > > > > Or, can we handle the situation where "PROC" exists in both > > permanent_location AND location, so the location is completely removed and > > replaced with NULL? > Hi Hannah! > Perhaps I've misunderstood what you're describing in your comment, but to me > it looks like it's a different scenario than the one in the Description of > this bug report. Perhaps your report deserves to be submitted as a new bug? Hi Andreas, I can certainly start a new bug report - I can report a bug for my situation, but would it be better to create a bug that covers the whole issue of "UpdateItemLocationOnCheckin not updating items where location is null"? The _ALL_: CART issue discussed above is another highly specific case, and I don't quite understand why the fix for that doesn't help in my situation. I feel like there's a larger issue of location = NULL needing to be handled in all situations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #124989|0 |1 is obsolete|| --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 125012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125012=edit Bug 28472: (follow-up) add unit test for the case where location = NULL This patch adds an extra unit test, to cover the case where the UpdateItemLocationOnCheckin System Preference is set to "_ALL_: CART" and the item being returned has no shelving location set. Test plan: 1) Apply the patch provided earlier 2) prove -v t/db_dependent/Circulation/issue.t ...and sign off if all tests pass. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #122749|0 |1 is obsolete|| --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 125011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125011=edit Bug 28472: handle items with NULL shelving location The UpdateItemLocationOnCheckin System Preference can be set to update the location of ALL items during check in, regardless of their shelving location. However, this does not currently work 100% as it is excluding items with no shelving location (i.e. value of NULL in the corresponding database field). This patch, based on the comment made by Nick Clemens, fixes that. Test plan (based on the original Bug Description by Andrew Fuerste-Henry): 1) Have a shelving location CART 2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes) 3) Check in an item that has a shelving location, confirm it changes to CART 4) Check in an item with a NULL shelving location, confirm it doesn't go to CART 5) Apply this patch 6) Repeat step 4): this time the item should move to the CART shelving location Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europe
||.com
Status|Signed Off |Failed QA
--- Comment #39 from Martin Renvoize ---
Sorry guys.. little more needed here.
My first followup drops the 'reserveforothers' permission requirement as I
don't think that relates to this functionality.. but it makes the API tests
fail.. and I can't see why.. code blind on a Friday.
My second followup highlights an issue with the public route. Although moving
the route under /public/patrons/{patron_id} ensure we do a patron identity
check.. there isn't actually a later check anywhere that the article your
trying to delete actually belongs to the patron ;)
This final one is actually why I preferred the original
/article_requests/{request_id} approach.. though of course that would require
the addition of a routine to handle checking borrowernumber in the article
request against the user as per the other routines for checking allow-owner.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #38 from Martin Renvoize --- Created attachment 125010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125010=edit Bug 27947: (QA follow-up) Update test to highlight issue This addition to the tests highlights a permissions/security check error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #37 from Martin Renvoize --- Created attachment 125009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125009=edit Bug 27947: (QA follow-up) Remove incorrect permission check The API was checking for 'reserverforothers' permission, but that doesn't make sense to apply here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Martin Renvoize changed: What|Removed |Added Attachment #124999|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 125008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125008=edit Bug 27947: Add regression tests for routes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Martin Renvoize changed: What|Removed |Added Attachment #124998|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 125007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125007=edit Bug 27947: (QA follow-up) Refactor routes This patch refactors the route specs a bit, and also reorganizes code for easier tracking. Unused exceptions that were added earlier are removed for now. A follow-up patch will add tests to this routes. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Martin Renvoize changed: What|Removed |Added Attachment #124997|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 125006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125006=edit Bug 27947: (follow-up) Add OPAC cancellation as new reason too Something that currently comes up now already too: If the user cancels from the OPAC page, there is no reason in the notice. We could simply add one now. Test plan: Run dbrev to add the OPAC authval. Create new AR and cancel it from OPAC. Verify notice created for the user. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Martin Renvoize changed: What|Removed |Added Attachment #124996|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 125005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125005=edit Bug 27947: (follow-up) Improve atomic update We do not need to replace the whole notice text, we only need to replace the reference to article_requests.notes. Test plan: Run the dbrev. Verify result for notice AR_CANCELED. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Martin Renvoize changed: What|Removed |Added Attachment #124995|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 125004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125004=edit Bug 27947: Add cancellation reason to article request This bug adds a cancellation reason authorised values to article requests To test: 1. apply this patch 2. updatedatabase 3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl CHECK => AR_CANCELLATION category should appears 4. place several article requests 5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl 6. select multiple requests, or just one and cancel them SUCCESS => a modal pops up offering to select a cancellation reason CHECK => message_queue table has messages with cancellation reason included 7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl 8. cancelling article requests from opac interface should work just as before Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Martin Renvoize changed: What|Removed |Added Attachment #124994|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 125003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125003=edit Bug 27947: [DO NOT PUSH] update ArticleRequest schema Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Martin Renvoize changed: What|Removed |Added Attachment #124993|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 125002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125002=edit Bug 27947: Add authorised values list in article requests cancellation Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 --- Comment #3 from Owen Leonard --- Created attachment 125001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125001=edit Bug 28537: (follow-up) Correct and improve OverDrive checkout modal This patch corrects the markup of the modal which is displayed when the user clicks the "Download as" button in their list of OverDrive checkouts. The modal markup had not been updated in the conversion to Bootstrap 4. I have also modified the markup generated when listing the download format options so that they use some standard Bootstrap 4 classes, improving the layout a little. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - In the list of current checkouts, click the "Download as" button for one of the titles. - A modal window should display with a list of radio buttons for each available format. - Confirm that the format text acts as the label for the radio button. - Confirm that closing the modal without making a selection works correctly. - Confirm that making a selection and submitting the form closes the modal and submits your choice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Owen Leonard changed: What|Removed |Added Attachment #121748|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 125000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125000=edit Bug 28537: Improve HTML generated by OverDrive integration This patch makes changes to the way HTML is generated when showing output from OverDrive integration: - Buttons have Bootstrap button classes - Layout of information is improved. - Handling of cover image thumbnails is improved, especially in cases where images were much larger than expected. - An OverDrive-specific CSS file is added. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display well, with item thumbnails showing in a column to the left, and item information showing to the right. - Controls should be styled with standard Bootstrap style. - Confirm that operations work correctly: Acessing titles, checking in, canceling holds, etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, especially thumbnails. - Confirm that operations work correctly: Checking out and placing holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Owen Leonard changed: What|Removed |Added Blocks||28537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 [Bug 28537] Improve HTML generated by OverDrive integration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Owen Leonard changed: What|Removed |Added Depends on||20168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 124999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124999=edit Bug 27947: Add regression tests for routes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 124998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124998=edit Bug 27947: (QA follow-up) Refactor routes This patch refactors the route specs a bit, and also reorganizes code for easier tracking. Unused exceptions that were added earlier are removed for now. A follow-up patch will add tests to this routes. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 124997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124997=edit Bug 27947: (follow-up) Add OPAC cancellation as new reason too Something that currently comes up now already too: If the user cancels from the OPAC page, there is no reason in the notice. We could simply add one now. Test plan: Run dbrev to add the OPAC authval. Create new AR and cancel it from OPAC. Verify notice created for the user. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 124996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124996=edit Bug 27947: (follow-up) Improve atomic update We do not need to replace the whole notice text, we only need to replace the reference to article_requests.notes. Test plan: Run the dbrev. Verify result for notice AR_CANCELED. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 124995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124995=edit Bug 27947: Add cancellation reason to article request This bug adds a cancellation reason authorised values to article requests To test: 1. apply this patch 2. updatedatabase 3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl CHECK => AR_CANCELLATION category should appears 4. place several article requests 5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl 6. select multiple requests, or just one and cancel them SUCCESS => a modal pops up offering to select a cancellation reason CHECK => message_queue table has messages with cancellation reason included 7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl 8. cancelling article requests from opac interface should work just as before Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 124994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124994=edit Bug 27947: [DO NOT PUSH] update ArticleRequest schema Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 124993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124993=edit Bug 27947: Add authorised values list in article requests cancellation Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124956|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124955|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124954|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124953|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124952|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27949] Batch printing of article request slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949
--- Comment #8 from Agustín Moyano ---
Hi Marcel, the following code worked for me
hr {
page-break-after: always;
border: 0px solid black !important;
}
First times did not work, but I believe it was browser's cache or memcached
Could you try again, please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #60 from Phil Ringnalda --- https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;h=02cf864ddd7f0f2ca6a921ae2a9045a18e1375f6;hb=HEAD#l4987 - type is 20, no? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28412] Add supported authentication methods documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29049] Holds page shows too many priority options in pulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29049] Holds page shows too many priority options in pulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049 --- Comment #1 from Nick Clemens --- Created attachment 124992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124992=edit Bug 29049: Simply holds priorty dropdown logic on request.pl This patch makes a few changes: 1 - If we are not splitting the queue ( HoldsSplitQueue == 'nothing' ) then there are no changes for 'virtual' vs 'actual' numbering 2 - If we are splitting the queue you cannot use the dropdown, so we do not need to process the options 3 - If the hold is 'found' we do not need to process the options 4 - We can simply use the 'last priority' to build the options, we do not need to process in the script 5 - We can use a block to build the options 6 - Remove a stray holds.index To test: 1 - Place 5 holds on a bib 2 - 'Find' two of the holds i.e. check them in to set status to 'transit' or 'waiting' 3 - View the holds page for the biblio 4 - Inspect the priorty dropdown for the found holds, note they have options for 1-5 but are disabled 5 - Note the dropdowns for other holds have options 1-5 6 - Note options 4&5 in the dropdowns have no effect 7 - Apply patch 8 - Inspect the priority dopdowns on the found holds 9 - Note they only show their found status 10 - Note the other dropdowns only show options 1-3 11 - Test with other HoldsSplitQueue options and HoldsSplitQueueNumbering 12 - When holds queue is split, no dropdowns should be active and should show only their current priority 13 - When HoldsSplitQueueNumbering is 'virtual' the dropdown should be disabled and correctly count the number of unfound holds in the list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29049] Holds page shows too many priority options in pulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138
--- Comment #59 from David Gustafsson ---
(In reply to Phil Ringnalda from comment #57)
> Fails for me in koha-testing-docker startup, with
>
> koha_1 | C4::Installer::load_sql returned the following errors while
> attempting to load
> /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql:
> koha_1 | DBD::mysql::st execute failed: Data too long for column
> 'type' at row 588 at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}>
> line 1.
> koha_1 | Something went wrong loading file
> /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql ([SQL ERROR]:
> INSERT INTO systempreferences ( `variable`, `value`, `options`,
> `explanation`, `type` ) VALUES
>
> Looks like at 22 characters, modification-templates doesn't quite fit in a
> 20 character column.
That column has length 50 for me, and also in kohastructure.sql. Don't know if
you created this table using a different version of Koha. If this can be
reproduced will address the issue.
Some things in the patch needed adjustment after changing to using template ids
instead of name. There is a problem with Elasticsearch in my devbox for recent
version of Koha which had not had time to fix, so was not able to properly test
the code. Meanwhile submitting and hoping for the best, will get back to
properly testing this once this issue has been sorted out.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Andreas Roussos changed: What|Removed |Added CC||gvera...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #9 from Andreas Roussos --- (In reply to Hannah Co from comment #6) > I don't believe this patch catches items in "processing" that should end up > with no shelving location. I have a freshly updated 21.05, with this patch > included. My system pref UpdateItemLocationOnCheckin contains "PROC: > _PERM_". Check-in does not make any changes to a record with "PROC" location > and no other shelving location assigned. > > New items are automatically created with location AND permanent_location > both set as PROC. It seems that "PROC" and "CART" should never populate > permanent_location. Can we prevent "PROC" from populating the > permanent_location? > > Or, can we handle the situation where "PROC" exists in both > permanent_location AND location, so the location is completely removed and > replaced with NULL? Hi Hannah! Perhaps I've misunderstood what you're describing in your comment, but to me it looks like it's a different scenario than the one in the Description of this bug report. Perhaps your report deserves to be submitted as a new bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #58 from David Gustafsson --- Created attachment 124991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124991=edit Bug 18138: Refactor after using template id instead of name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #8 from Andreas Roussos --- (In reply to Jonathan Druart from comment #5) > The change is missing test coverage. Hi Jonathan! I think I managed to write a test that covers this case, see my follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Owen Leonard changed: What|Removed |Added Attachment #124986|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 124990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124990=edit Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #7 from Andreas Roussos --- Created attachment 124989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124989=edit Bug 28472: (follow-up) add unit test for the case where location = NULL This patch adds an extra unit test, to cover the case where the UpdateItemLocationOnCheckin System Preference is set to "_ALL_: CART" and the item being returned has no shelving location set. Test plan: 1) Apply the patch provided earlier 2) prove -v t/db_dependent/Circulation/issue.t ...and sign off if all tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Andreas Roussos changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29049] New: Holds page shows too many priority options in pulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049 Bug ID: 29049 Summary: Holds page shows too many priority options in pulldown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To recreate: 1 - Place 5 holds on a biblio 2 - 'Find' two holds i.e. check them in to set them as transit or waiting 3 - Load the holds page for the biblio 4 - Check the pull down for priority 5 - Note holds has priority 1-3 but dropdown is 1-5 6 - Click 4 or 5 and note nothing happens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27949] Batch printing of article request slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949
--- Comment #7 from Agustín Moyano ---
(In reply to Marcel de Rooy from comment #5)
> (In reply to Agustín Moyano from comment #4)
> > Hi Marcel, sorry for the delay. For what I've seen, printslip.tt uses
> > SlipCSS stylesheet (if defined) where you may say, for example
> >
> > hr {
> > display: none;
> > page-break-after: always;
> > }
>
> Did you test this yourself?
>
> I already did some testing with page-break-after but couldnt get it to work.
> I now inserted the exact lines above in a stylesheet for SlipCSS but it does
> not work either.
Hi Marcel, I did not test it, but my point was that printslip.tt includes a
css, just as print-notices.tt where you can define page breaking conditions.
Let me play around a bit, and I'll post a working example
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #8 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Julian Maurice changed: What|Removed |Added Attachment #64263|0 |1 is obsolete|| --- Comment #7 from Julian Maurice --- Created attachment 124988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124988=edit Bug 18796: Allow to print notice while claiming serials It can be useful to have a printable version of a claim notice, for testing purposes or for when supplier has no email address for example Test plan: 1. Go to Serials > Claims and select a vendor 2. Select some serials by clicking on checkboxes 3. Click to the little arrow next to 'Send notification' button and click on 'Print notification' 4. Verify that the downloaded PDF contains the content of the selected notice 5. Verify that the 'Send notification' button still works as before 6. Run `prove t/db_dependent/Letters.t` Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 --- Comment #1 from Owen Leonard --- Created attachment 124987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124987=edit Bug 28910: Correct eslint errors in OPAC basket.js This patch corrects eslint errors in the OPAC copy of basket.js: Indentation inconsistencies, undeclared variables, unused functions, etc. To test, apply the patch and test the "Cart" functionality in the OPAC: - In the OPAC, add an item to the cart. - A popup message should appear telling you the item has been added. - The "Add to cart" link should update to read "In your cart." - The count if cart items in the header should be updated. - The "In your cart (remove)" link should work correctly. - Test this process from both the search results and detail pages. - Open the cart. - The cart should open correctly. - In the cart, test all the controls: - More details - Send - Download - Empty and close - Hide window - Print - Select all / clear all - With checked items: - Remove - Add to list - Place hold - Tag The following unused functions were removed: readCookieValue, AllAreChecked, SelectAll, and quit. A search of the Koha codebase should return no results from the opac-tmpl directory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29048] New: Authorities search results - related records link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 Bug ID: 29048 Summary: Authorities search results - related records link Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: vitorfernande...@gmail.com QA Contact: testo...@bugs.koha-community.org The related records link in the authorities search results searches for "an=authid", which returns all records with an started with authid (after clicking the link). This causes a difference between the number of related records and the number of records retrieved in the search (using Elasticsearch). The link should change from: q=an=[% resul.authid | uri %] To: q=[% resul.authid | uri %]idx=an,phr in the following line: https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt#L110 Test plan: - Create 10 authority with similar values - Relate some record with authority 1 - Relate some record with authority 10 - Search authorities (authority 1 should have 1 related record) - Click the related records link - You should get 2 related records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 --- Comment #6 from Julian Maurice --- (In reply to Fridolin Somers from comment #3) > Rebase looks easy ;) (In reply to Fridolin Somers from comment #5) > Needs a huge rebase :D What two years of changes can do... :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 --- Comment #3 from Andrew Isherwood --- Created attachment 124986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124986=edit Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription batch edit tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice changed: What|Removed |Added Status|BLOCKED |Needs Signoff --- Comment #8 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription batch edit tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice changed: What|Removed |Added Attachment #91429|0 |1 is obsolete|| --- Comment #7 from Julian Maurice --- Created attachment 124985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124985=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #22 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #9)
> > > [5] Why do you add cancel_article_request to Koha/REST/V1/Patrons.pm ?
> > > Apart
> > > from checking existence of the patron id, what is its use ?
> >
> > As I was making API endpoints for cancelling article requests from staff
> > interface (we should move away from svc in any chance we've got), I thought
> > it would be good to add the same for opac.. the endpoint that opac uses is
> > DELETE /api/v1/public/patrons/{patron_id}/article_requests/{ar_id}, so It
> > seemed natural to place it in Koha/REST/V1/Patrons.pm
>
> I dont really mind. Maybe ask Tomas? But it seemed more logical (or
> consistent) to me that deleting an article request from OPAC or staff have
> similar end points.
I generally prefer context-specific routes, so:
/patrons/:patron_id/article_requests/1
over
/article_requests/1
in the particular case of the public routes, this allows us to use the
'allow-owner' permission feature from our API framework.
What I don't like, is having the controller methods so sparse. I will submit a
follow-up reorganizing that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18783] Allow automatic claims for serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18783] Allow automatic claims for serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 Julian Maurice changed: What|Removed |Added Attachment #91428|0 |1 is obsolete|| --- Comment #11 from Julian Maurice --- Created attachment 124984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124984=edit Bug 18783: Allow automatic claims for serials This patch adds a new script misc/cronjobs/serialsClaim.pl which send email notification to all suppliers that have late or missing issues. This is configurable per subscription and is disabled by default. Test plan: 1. Create a new bookseller B1 with a delivery time of 5 days 2. Create a new daily subscription with bookseller B1 and enable automatic claims (new checkbox on the first page of subscription-add.pl) 3. Generate some late serials with an expected date in the past (some with more than 5 days in the past, some with less) 4. Create a notice for module "Claim serial issue" CLAIMSERIAL and write something in the 'Email' template 5. Run `misc/cronjobs/serialsClaims.pl --letter-code CLAIMSERIAL` and verify that it sends an email notification only for serials that were expected more than 5 days ago -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21217] No error when doing Renewals for expired borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21217 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 --- Comment #8 from Nick Clemens --- Created attachment 124983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124983=edit Bug 28667: (QA follow-up) Fetch preference once Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 Nick Clemens changed: What|Removed |Added Attachment #123805|0 |1 is obsolete|| Attachment #124981|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 124982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124982=edit Bug 28667: Check damaged item can be reserved in OPAC detail pages In OPAC detail pages, damaged items must impact the "place hold" link. This behavior depends on preference AllowHoldsOnDamagedItems. Test plan : 1) Create a record with one damaged item 2) Set AllowHoldsOnDamagedItems to 'Allow' 3) Go to OPAC record detail page : opac-detail.pl 4) Check you see "Place hold" link 5) Set AllowHoldsOnDamagedItems to 'Don't allow' 6) Refresh page 7) Check you don't see "Place hold" link Same tests 2 to 7 for pages opac-ISBDdetail.pl and opac-MARCdetail.pl Signed-off-by: Barbara Johnson Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 --- Comment #6 from Nick Clemens --- Created attachment 124981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124981=edit Bug 15156: Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. Signed-off-by: David Nind Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood changed: What|Removed |Added Attachment #122644|0 |1 is obsolete|| --- Comment #14 from Andrew Isherwood --- Created attachment 124980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124980=edit Bug 22531: Add unit tests Add tests for new and modified methods Signed-off-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood changed: What|Removed |Added Attachment #122643|0 |1 is obsolete|| --- Comment #13 from Andrew Isherwood --- Created attachment 124979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124979=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Nick Clemens changed: What|Removed |Added Attachment #124876|0 |1 is obsolete|| --- Comment #37 from Nick Clemens --- Created attachment 124978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124978=edit Bug 15156: Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. Signed-off-by: David Nind Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944
--- Comment #80 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #68)
> If bug 27945 might pass before this one, we could add here:
>
> +++ b/Koha/Patron.pm
> @@ -975,7 +975,7 @@ sub can_request_article {
>
> -{ borrowernumber => $self->borrowernumber, status => { '!=' =>
> ['CANCELED','COMPLETED'] } },
> +{ borrowernumber => $self->borrowernumber, status => { '!=' =>
> ['PENDING', 'CANCELED', 'COMPLETED'] } },
>
> It feels better to not count the PENDING reqs here.
The bugs do not apply on top of each other - one will need to be rebased to be
pushed before the other, Agustin, can you take care of that and add the
follow-up?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in Additional Contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041 David Nind changed: What|Removed |Added Attachment #124940|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 124977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124977=edit Bug 29041: Improve specificity of breadcrumbs in Additional Contents This patch adds a link to news or HTML customizations in the breadcrumbs navigation depending on which category of content you're adding or editing. To test, apply the patch and go to Tools -> News. - Begin the process of adding a news item. - In the breadcrumbs menu you should see: Additional contents > News > Add additional content - Clicking "News" should return you to the view of news items. - Test the same process in "HTML customizations." Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in Additional Contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #75 from Andrew Isherwood ---
(In reply to Nick Clemens from comment #64)
> Error in :
> installer/data/mysql/atomicupdate/bug_27378_add_CookieConsentPopup_syspref.
> perl
> (shoudl quote with q{} so the | doesn't break it)
Thanks, fixed.
> In testing I was never able to get the cookies to set - can you provide some
> values in the test plan that work on koha testing docker - I got complaints
> of bad domain for cookies
It was developed on KTD and I just ran through the test plan on the same and it
worked perfectly. For step 12 of the test plan are you using the domain you use
to access the KTD in your browser?
> Question: Should you be able to keep using the site before clicking 'Accept'
> on the necessary cookies?
I think so, I've yet to encounter a site that wouldn't let me use it before I
agreed to cookies.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #79 from Nick Clemens --- Created attachment 124976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124976=edit Bug 27944: (QA follow-up) Add span to fix pipe separator Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123952|0 |1 is obsolete|| --- Comment #78 from Nick Clemens --- Created attachment 124975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124975=edit Bug 27944: (QA follow-up) Make staff home page show new article requests As exposed on comment 29, the current code is showing the 'pending' requests when it should display 'requested' ones (i.e. the new ones). This patch changes that accordingly. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123951|0 |1 is obsolete|| --- Comment #77 from Nick Clemens --- Created attachment 124974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124974=edit Bug 27944: (QA follow-up) Rename ->open for ->set_pending Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123950|0 |1 is obsolete|| --- Comment #76 from Nick Clemens --- Created attachment 124973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124973=edit Bug 27944: REQUESTED is the new default status Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123949|0 |1 is obsolete|| --- Comment #75 from Nick Clemens --- Created attachment 124972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124972=edit Bug 27944: (follow-up) Move statuses to constants Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
