[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976

--- Comment #4 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29943] Fix typo in notices yaml file

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29943

--- Comment #6 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29943] Fix typo in notices yaml file

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29943

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

--- Comment #49 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

--- Comment #11 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Fridolin Somers  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

--- Comment #10 from Fridolin Somers  ---
(In reply to David Nind from comment #8)
> I have tested on top of bug 15067.
> 
> After applying 29956 I ran databaseupdate several times (x4) - this makes
> the language appear multiple times (x4) as well.
> 
> I'm not sure that is what you meant though...

I reproduce.
I think we must have Bug 29605 to have constraints.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||29596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
[Bug 29596] Add Yiddish language
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||29605
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
[Bug 29605] DB structure may not be synced with kohastructure.sql
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #129988|0   |1
is obsolete||

--- Comment #5 from Fridolin Somers  ---
Created attachment 130058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130058=edit
Bug 29975: (bug 21729 follow-up) Fix api/v1/holds.t

Unknown column 'patron_expiration_date' in 'field list'
The REST API routes don't need to be aware of the new column
patron_expiration_date

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6986] Update perltidyrc file

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6986

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30002

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=6986

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2269] add a perltidyrc configuration file for perltidy

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2269

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30002

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=2269

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30002] New: Remove unused xt/perltidyrc

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002

Bug ID: 30002
   Summary: Remove unused xt/perltidyrc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vic...@tuxayo.net
QA Contact: testo...@bugs.koha-community.org

It doesn't influence the tests at all.
After emptying it or removing or setting the max line length to 40 char no
error pops.

So it was proposed for removal in last dev meeting:
http://irc.koha-community.org/koha/2022-01-19#i_2400452

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #14 from Fridolin Somers  ---
Oupsy :

> Indeed we should be go back to direct SQL even if faster.
Indeed we should not go back to direct SQL even if faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Fridolin Somers  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #14 from Fridolin Somers  ---
Ah I forgot to obsolete a patch after commit message change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #129519|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29992] Default Apache config should contain CGIPassAuth directive

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
That's interesting, although why are you running the API as CGI and not as PSGI
through Starman?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9097] 'Welcome mail' for new library users

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #8 from David Cook  ---
This would be good for self-registered patrons too. I feel like there is a
separate bugzilla ticket for that...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@hypernova.fi

--- Comment #12 from Lari Taskula  ---
As Tomas proposed, I've added a new column illrequests.date_due and it now
replaces the attribute/syspref introduced in Magnus's original patch. Populated
by backend, and if defined, AddIssue will use it as the due date, but if left
null (default behavior), default due date calculation will be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

--- Comment #11 from Lari Taskula  ---
Created attachment 130057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130057=edit
Bug 24239: Replace syspref with illrequests column date_due

This patch replaces system preference introduced in previous patch with
a column "date_due" for table illrequests.

To test:
1. prove t/db_dependent/Circulation.t

Sponsored-by: imCode Partner AB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Lari Taskula  changed:

   What|Removed |Added

 Attachment #106409|0   |1
is obsolete||

--- Comment #10 from Lari Taskula  ---
Created attachment 130056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130056=edit
Bug 24239: Let the ILL module set ad hoc hard due dates

The Swedish Libris ILL backend lets librarians store a specific due date
when an ILL loan is received. This is stored as a ILL request attribute.

This patch adds a syspref that can take the name of the
illrequestattribute used to store the specific date. If the syspref is
set, and if an item is connected to an ILL request, the due date will be
taken from the illrequestattribute, instead of being calculated in the
regular way, based on patroncategory and itemtype.

To test:
- Apply the patch and make sure the atomic database update is run
- Use the FreeForm backend to add one ILL request. Take note  of the
  illrequest_id of the request you created. We refer to this as
  "x" below.
- Connect a biblio (with biblionumber y), that has an item with a
  barcode, to the ILL request directly in the database:
  UPADTE illrequests SET biblio_id = y WHERE illrequest_id = x;
- Add an attribute to the ILL request directly in the database:
  INSERT INTO illrequestattributes SET illrequest_id = x, type =
  'illduedate', value = '2023-01-01';
- Enter 'illduedate' as a value for the ILLUseExactDueDate syspref.
- Go to circulation and issue the barcode of the item to the
  patron associated with the FreeForm ILL request. Verify that the
  loan gets a due date of 2023-01-01.
- Ideally: return the item and issue it again through SIP2 and SCO,
  and verify that the due date is still 2023-01-01.
  (I don't think the REST API supports issuing yet?)
- Verify that there are no regressions, so that regular calculation
  of due dates still work, if ILLUseExactDueDate is empty or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #14 from David Cook  ---
(In reply to Blou from comment #9)
> Unfortunate, I was so happy to find this bz after such a lenghty search to
> understand why our biblios with big notes (505$a) indexed on zebra would
> give us crappy results entries with no title or bib number, where notes is
> not even considered in results.tt
> 
> Do you have a suggestion?  Where is the  limit, in the end?  Because I
> don't see it anywhere in the code, nor in MARC perl libraries.

Yeah... I can't see why the  limit would necessarily cause a problem in
Koha unless one was exporting as "usmarc"? 

If you can provide more details, I can have a think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29995] Rest API Authentication

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29995

--- Comment #1 from Katrin Fischer  ---
Hi Lokesh, this is likely to be a configuration issue or similar, please
consider asking on the mailing list or on IRC where you will reach many more
users. Bugzilla should only be used for filing bugs or enhancement requests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #13 from Katrin Fischer  ---
(In reply to Blou from comment #12)
> Damn, I said Zebra out of habit.  I meant Elastic Search.  We moved most of
> our users to ES already.  I've never seen that error before when using
> zebra, btw...

We've recently managed to have some that Zebra would not index. I haven't read
about any limitations on size with Elastic, maybe it's another issue there?
Filing a separate bug or an email to the mailing list might turn up some ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #12 from Blou  ---
Damn, I said Zebra out of habit.  I meant Elastic Search.  We moved most of our
users to ES already.  I've never seen that error before when using zebra,
btw...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #11 from Katrin Fischer  ---

> Do you have a suggestion?  Where is the  limit, in the end?  Because I
> don't see it anywhere in the code, nor in MARC perl libraries.

This here looks helpful:
https://git.koha-community.org/Koha-community/Koha/commit/2660cc8f0bbb7f8d0903aa2145095a43c84c5a8e

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #10 from Katrin Fischer  ---
I think I was told you could change the 'record size limit' somewhere in the
Zebra config files, but I don't remember where exactly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

Blou  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

--- Comment #9 from Blou  ---
Hello David,
I read through this thread... which ended on an ellipsis.  Amusingly quite on
point.

I find the discussion on the standard fascinating (exchange is stretched, I
realized it was only you keeping notes), but I was lazingly hoping for
something practical.  

Unfortunate, I was so happy to find this bz after such a lenghty search to
understand why our biblios with big notes (505$a) indexed on zebra would give
us crappy results entries with no title or bib number, where notes is not even
considered in results.tt

Do you have a suggestion?  Where is the  limit, in the end?  Because I
don't see it anywhere in the code, nor in MARC perl libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||30001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30001
[Bug 30001] Bridge icons change missing in authorized values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30001] Bridge icons change missing in authorized values

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30001

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||23148


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148
[Bug 23148] Replace Bridge icons with transparent PNG files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30001] New: Bridge icons change missing in authorized values

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30001

Bug ID: 30001
   Summary: Bridge icons change missing in authorized values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Bug 23148 changed bridge icons from GIF to PNG, with an update on database on
itemtypes table.
Those images can also be used in authorized values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #3 from Lucas Gass  ---
Note: To get this to look right it was necessary for me clear my cache after
running 'yarn build'. 

Once I did it looks and feels exactly the same as when using jQueryUI tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Lucas Gass  changed:

   What|Removed |Added

 Attachment #130053|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 130055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130055=edit
Bug 2: Replace the use of jQueryUI tabs on authorized values administration
page

This patch updates the authorized values edit interface so that it uses
Bootstrap tabs instead of jQueryUI tabs for displaying icon sets.

Normally Bootstrap tabs don't have to be initiated via JavaScript, but
this page requires some JS to select the first tab as active if no other
tabs are active. Because of the way the template works it's not simple
to do it via template logic, so in this case some JS helps.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> Authorized values in the staff interface.
- Select a category and then add or edit an authorized value in that
  category.
  - On the edit page you should see tabs under "Choose an icon."
  - Confirm that the tabs look correct and work correctly.
  - If you did not previously have any icon selected, the "None" tab
should be active.
  - If you had an icon selected, that icon set's tab should be
active.
  - Confirm that changing icons works correctly and that the
selected icon's tab is always active when you return to the edit
page.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576

The Minh Luong  changed:

   What|Removed |Added

 CC||the-minh.lu...@inlibro.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576

--- Comment #16 from The Minh Luong  ---
Created attachment 130054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130054=edit
Bug 28576: Update the maximum size of an image.

This patch modifies the maximum size of a patron's image, from 500KB to
2MB. Also, in Home/Patrons/anyPatron, when you try to add an image to a
patron, you can now see the supported file types AND the maximum size.

The following places are affected by this patch:
- Home/Patrons/anyPatron
- Home/Tools/Upload patron images
- Home/Tools/Patron card creator/Images

To test:
1)Search for any patron and go to his page.
2)Hover over the image area on the left and click on the "Add" button.
3)Notice that the message above the choose file button only specifies
file types without the maximum size.
4)Add an image bigger than 500KB.
5)Nothing happens. (This is because the maximum size is 5KB)
6)Apply the patch.
7)Repeat steps from 1 to 3.
8)Notice that the message now includes the maximum size.
9)Add an image bigger than 500KB, but smaller than 2MB.
10)The image is succesfully uploaded.
11)Add an image bigger than 2MB.
12)Nothing happens. (The maximum size is now 2MB)
13)Repeat the steps 9 to 12 in "Home/Tools/Upload patron images" and
"Home/Tools/Patron card creator/Images".
14)Notice that the maximum size is updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

--- Comment #1 from Owen Leonard  ---
Created attachment 130053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130053=edit
Bug 2: Replace the use of jQueryUI tabs on authorized values administration
page

This patch updates the authorized values edit interface so that it uses
Bootstrap tabs instead of jQueryUI tabs for displaying icon sets.

Normally Bootstrap tabs don't have to be initiated via JavaScript, but
this page requires some JS to select the first tab as active if no other
tabs are active. Because of the way the template works it's not simple
to do it via template logic, so in this case some JS helps.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> Authorized values in the staff interface.
- Select a category and then add or edit an authorized value in that
  category.
  - On the edit page you should see tabs under "Choose an icon."
  - Confirm that the tabs look correct and work correctly.
  - If you did not previously have any icon selected, the "None" tab
should be active.
  - If you had an icon selected, that icon set's tab should be
active.
  - Confirm that changing icons works correctly and that the
selected icon's tab is always active when you return to the edit
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

--- Comment #13 from Lucas Gass  ---
Sorry to say, I cannot get this patchset to apply cleanly to master now. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

--- Comment #36 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #34)
> About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure
> about it, I always privileged iterator over retrieving the whole set.
> If this is what we really want it needs to be deeply investigated and that
> we agree on it.

Another option would've been to calculate the count and add a new template
param. I decided to minimize the changes to your patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29881] Remove SQLite2 dependency

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881

Mason James  changed:

   What|Removed |Added

   Severity|major   |blocker
   Priority|P5 - low|P1 - high

--- Comment #5 from Mason James  ---
bump severity to fix ktd/jenkins

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement enables
  release notes||customising the authority
   ||search results summary in
   ||the staff interface using
   ||XSLT (for MARC21 and
   ||UNIMARC).
   ||
   ||Key features;
   ||-
   ||Use the new system
   ||preference
   ||AuthorityXSLTResultsDisplay
   ||to set the location of the
   ||XSLT file, either the full
   ||path to a file on the Koha
   ||server or a URL.
   ||- The
   ||system preference value can
   ||contain {langcode} and
   ||{authtypecode} which will
   ||be replaced by the
   ||appropriate value.
   ||- If
   ||errors occur, the custom
   ||XSLT file is ignored and
   ||the default summary is
   ||displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

   What|Removed |Added

 Depends on||3


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3
[Bug 3] Replace the use of jQueryUI tabs on the search engine configuration
page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277

Owen Leonard  changed:

   What|Removed |Added

 Blocks||3


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3
[Bug 3] Replace the use of jQueryUI tabs on the search engine configuration
page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30000] New: Replace the use of jQueryUI tabs on the search engine configuration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

Bug ID: 3
   Summary: Replace the use of jQueryUI tabs on the search engine
configuration page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 29277
Blocks: 29226

As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should
replace the use of the jQueryUI tabs component on the search engine
configuration  (Elasticsearch) page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277
[Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

   What|Removed |Added

 Depends on||2


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2
[Bug 2] Replace the use of jQueryUI tabs on authorized values
administration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277

Owen Leonard  changed:

   What|Removed |Added

 Blocks||2


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2
[Bug 2] Replace the use of jQueryUI tabs on authorized values
administration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29999] New: Replace the use of jQueryUI tabs on authorized values administration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Bug ID: 2
   Summary: Replace the use of jQueryUI tabs on authorized values
administration page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 29277
Blocks: 29226

As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should
replace the use of the jQueryUI tabs component on the authorized values
administration page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277
[Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

   What|Removed |Added

 Depends on||29998


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998
[Bug 29998] Replace the use of jQueryUI tabs on item types administration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277

Owen Leonard  changed:

   What|Removed |Added

 Blocks||29998


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998
[Bug 29998] Replace the use of jQueryUI tabs on item types administration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29998] New: Replace the use of jQueryUI tabs on item types administration page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998

Bug ID: 29998
   Summary: Replace the use of jQueryUI tabs on item types
administration page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 29277
Blocks: 29226

As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should
replace the use of the jQueryUI tabs component on the item types administration
page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277
[Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #10 from David Nind  ---
Testing notes (koha-testing-docker):

- Tested using provided example XSLT files for MARC21 and UNIMARC.

- Visual differences in the authority search results that I noticed:
  . MARC21: removes the summary text
  . UNIMARC: adds bullet points in front of the summary text

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

David Nind  changed:

   What|Removed |Added

 Attachment #128913|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 130052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130052=edit
Bug 11083: Add sample XSLT for UNIMARC authorities

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

David Nind  changed:

   What|Removed |Added

 Attachment #121537|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 130051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130051=edit
Bug 11083: Add ability to generate authority summary using XSLT

This patch only affects authority search results in the staff interface.
It adds a new system preference AuthorityXSLTResultsDisplay. If set,
each authority search result MARCXML will be transformed using the XSLT
at the given filename or URL. The output will be displayed in place of
the default summary.
If errors occur, the XSLT is ignored and the default summary is
displayed.

The syspref value can contain {langcode} and {authtypecode} which will
be replaced by the appropriate value (resp. current language and
authority type code)

Test plan:
1. Apply patch and run updatedatabase
2. Verify that authority search results are not affected yet.
3. Create an XSLT file (for instance in
/home/koha/xslt/en/GEOGR_NAME.xsl)
4. Set AuthorityXSLTResultsDisplay syspref value to
/home/koha/xslt/{langcode}/{authtypecode}.xsl
5. Do an authority search that returns GEOGR_NAME results. Verify that
the summary matches what you expect from your XSLT
6. Do an authority search that returns authorities of other types.
Verify that the default summary is displayed.

Example of a minimal XSLT:


http://www.loc.gov/MARC21/slim;
 xmlns:xsl="http://www.w3.org/1999/XSL/Transform;>
  
  

  
authority-summary
  
  

  


Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982

--- Comment #8 from Lucas Gass  ---
OK, my apologies Magnus. As soon as I cleared my cache everything looks fine.
It must have been the JS. 

The only thing now is the QA tool would git you to rename your commit message:

"Bug 29982 - Show itemtype in holds table on patron details"

* Commit title does not start with 'Bug X: ' - 55787708a3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277

--- Comment #4 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #3)

> We are loosing some borders and the tabs are less obvious. Is that expected?

No, I think you are seeing cached CSS. Please clear the browser cache and try
again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713

Owen Leonard  changed:

   What|Removed |Added

 Attachment #129815|0   |1
is obsolete||

--- Comment #6 from Owen Leonard  ---
Created attachment 130050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130050=edit
Bug 29713: Make item table when placing an item level hold sortable

This patch modifies the holds page in the OPAC so that users selecting a
specific item to place a hold on can sort the table of items.

Note: This patch includes some whitespace changes, so diff accordingly.

To test, apply the patch and go to Administration -> Circulation and
fine rules to make sure at least one item type in your system has
"OPAC item level holds" set to "allow."

- Log in to the OPAC as a user who can place holds.
- Search the catalog for items which will accept item-level holds.
- Place a hold on one of the results, and click the "Show more options"
  link on the holds page.
- Check the "specific item" radio button.
- A table of items should be displayed. Confirm that the table is
  sortable.
- Perform the same test when placing a hold on multiple titles. Confirm
  that each table of items is sortable.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #68 from Caroline Cyr La Rose  ---
Patch doesn't apply :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

--- Comment #35 from Jonathan Druart  ---
Created attachment 130049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130049=edit
Bug 23991: Fix conflict with bug 28941

Well, this patchset fixed the security bug...
Redoing on top of bug 28941

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

--- Comment #34 from Jonathan Druart  ---
About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure
about it, I always privileged iterator over retrieving the whole set.
If this is what we really want it needs to be deeply investigated and that we
agree on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29997] Allow to send email notification when a serial issue is late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29997] Allow to send email notification when a serial issue is late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997

--- Comment #1 from Julian Maurice  ---
Created attachment 130048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130048=edit
Bug 29997: Allow to send email notification when a serial issue is late

This patch adds the ability to define, for each subscription, a letter
that will be sent whenever an issue is automatically marked as late by
the script misc/cronjobs/serialsUpdate.pl.
If no letter is defined for a subscription, then no letter will be sent.

The letter will be sent to the subscription's manager (the staff
member who created or last modified the subscription).

Test plan:
1. Create a letter in Tools › Notices & slips for module "Serials". Fill
   the Email template.
2. Create a new subscription, with a grace period of 1 day, and set the
   new field "Late issue notification" to the letter you just created.
   Set the first issue publication date and subscription start date to
   two days ago
3. Run `misc/cronjobs/serialsUpdate.pl -v -c`.
4. The first serial issue of your subscription should have been
   automatically marked as late. Now verify that the table message_queue
   contains a new message corresponding to this serial issue. The
   message's contents should be what you defined in step 1.
   The message should be addressed to the subscription's manager (you)

Technical note:
   The "subscription" table contained a column named "librarian", which
   contained the userid of the patron who created or last modified the
   subscription, but there was no foreign key constraint referencing the
   borrowers table. So this patch also adds a new column "manager_id"
   which contains the borrowernumber of the patron who created or last
   modified the subscription, and it also adds the foreign key
   constraint.  The atomicupdate script tries to fill the new
   "manager_id" column by searching patrons by their "userid", which
   might fail, so it's normal to have some NULL values in "manager_id"
   at the end. The "librarian" column is removed at the end of the
   script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29997] New: Allow to send email notification when a serial issue is late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997

Bug ID: 29997
   Summary: Allow to send email notification when a serial issue
is late
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29832] Make library column in desk list sortable

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832

--- Comment #4 from Jonathan Druart  ---
Created attachment 130047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130047=edit
Bug 29832: Use KohaTable

NoSort is defined in KohaTable

Also add noExport

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29832] Make library column in desk list sortable

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #129284|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 130046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130046=edit
Bug 29832: Make library column in desk list sortable

This patch makes minor updates to the DataTable configuration on the
Circulation Desks Administration page. Redundant options are removed and
existing options are updated to use current DataTables syntax.

To test, apply the patch and make sure that the UseCirculationDesks
system preference is enabled.

- Go to Administration -> Circulation desks.
- Add multiple circulation desks if necessary, at multiple libraries.
- The "Desk" column should be sorted by default, and the "Actions"
  column should not be sortable.
- The "Library" column should be sortable.

Signed-off-by: Lucas Gass 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29832] Make library column in desk list sortable

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Status|Signed Off  |Patch doesn't apply

--- Comment #5 from Jonathan Druart  ---
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #3 from Jonathan Druart  ---
Before: https://snipboard.io/HLlery.jpg
After : https://snipboard.io/gjpMyc.jpg

We are loosing some borders and the tabs are less obvious. Is that expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #1 from Julian Maurice  ---
Created attachment 130045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130045=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library and
   enable "Warn when late"
3. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
4. Go back to the main page. You should see an alert with a link to your
   subscription
5. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
6. Set your library back to its original value to make the alert
   reappear.
7. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] New: Show an alert on main page when serial issues are late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Bug ID: 29996
   Summary: Show an alert on main page when serial issues are late
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #16 from Jonathan Druart  ---
Next steps? Is there a plan here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #6 from Jonathan Druart  ---
Please have a look at https://wiki.koha-community.org/wiki/Commit_messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|22.05.00|22.05.00,21.05.09
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17748] Show due date in item search results

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Jonathan Druart  ---
Tests are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #128162|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  ---
Created attachment 130044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130044=edit
Bug 29230: Add Koha::Patron->messages

Add methods to return the messages attached to a patron.

It will add the capability to access them from notice templates.

Test plan:
Define some messages for a given patron
Go to the circulation page of the patron and confirm that they are still
displayed

Test the notice templates:
Add to HOLD_SLIP the following content
"""
[% SET messages = borrower.messages %]
[% IF messages.count %]
Messages:

  [% FOR m IN messages.search( message_type => 'L' ) %]
[% m.message %]
  [% END %]

[% END %]
"""

To display all the messages from staff ('L')

Adapt following your needs.

Signed-off-by: Fridolin Somers 

Signed-off-by: Stina Hallin 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #4 from Jonathan Druart  ---
I don't really understand the change. Isn't it weird to force the submission
when the button has a data-dismiss="modal"?

Shouldn't we remove this "dismiss" attribute instead?

We had lot of regressions on this page, I am a bit reluctant to submit when we
were supposed not to...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |nicolas.legr...@bulac.fr
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #130018|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 130043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130043=edit
Bug 29785: Rename Koha::Object->message with ->object_messages

It will conflict with other ->messages methods, it's too generic.

Bug 29230 needs Koha::Patron->messages to return Koha::Patron::Messages for
instance.

Test plan:
Confirm that the tests modified by this patch still pass

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #6 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Marcel de Rooy from comment #4)
> This looks correct to me, Koha::Result::Boolean is not inheriting from
> Koha::Object.

Okay

> > Kind of strange btw that we add a lot of code there?
> > Koha::Result::Boolean->new(0)->add_message({ message => $error });
> 
> Can you detail what you mean here?

Forget that. Result here confused me a bit. Surely it not a Schema::Result, but
what is a Koha::Result actually?
No answer needed here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458

--- Comment #23 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #22)
> Change status to ?

No need to, there is the additional_work_needed keyword.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|29136   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136
[Bug 29136] Patron search on request.pl has performance and display issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29136


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136
[Bug 29136] Patron search on request.pl has performance and display issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 Depends on|29660   |28782


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782
[Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660
[Bug 29660] reserve/request.pl should not deal with biblioitem
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >