[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
Martin Renvoize changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--- Comment #68 from Martin Renvoize ---
Right... that's my branch rebased and a few bugs fixed and all uploaded to
here.
This includes the work I did on translation_key as an example.. i'm envisaging
something along the lines of below for AV's as another example.
sub translation_key {
return $self->code . ":" . C4::Context->interface;
}
In the itemtypes case I've cheated slighty with translation key stuff.. as it
is just retunring itemtype behind the scenes I didn't go ahead and expose it
more widely in C4::Search for example.
Still need to expose the 'fuzzy' flagging in the UI... but that should be
trivial to do.
I think the 'code' vs 'description' issues may have gone away with the
frameworks having been moved into pootle translations now.
Hopefully this gives us a point to delve back in.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132520|0 |1 is obsolete|| --- Comment #67 from Martin Renvoize --- Created attachment 132533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132533&action=edit Bug 24975: Pass transation_key in GetItemsInfo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132519|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 132532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132532&action=edit Bug 24975: Fix bugs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132518|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 132531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132531&action=edit Bug 24975: DBIC Build -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132517|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 132530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132530&action=edit Bug 24975: Add to Koha::UI::Form::Builder::Item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132516|0 |1 is obsolete|| --- Comment #63 from Martin Renvoize --- Created attachment 132529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132529&action=edit Bug 24975: Use translation_key in preference to description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132515|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 132528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132528&action=edit Bug 24975: Add translation_key method example -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132514|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 132527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132527&action=edit Bug 24975: Re-introduce translated_description accessor method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132513|0 |1 is obsolete|| --- Comment #60 from Martin Renvoize --- Created attachment 132526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132526&action=edit Bug 24975: Use 'key' for translation lookup This patch switches from using the original text as a key for translations to using a dedicated 'key' field. We also add in a 'fuzzy' flag to denote when the source text has changed and as such the pre-existing translations may be incorrect. ToDo: 1/ Expose 'Fuzzy' on the 'Localization' admin page 2/ Add a 'translation_key' method to Koha::Itemtype to encourage the adoption of a standardly names accessor to get the 'translation_key' from a Koha::Object derived class. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132512|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 132525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132525&action=edit Bug 24975: (follow-up) Rebase for bug 21946 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132511|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 132524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132524&action=edit Bug 24975: Fix syntax issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132510|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 132523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132523&action=edit Bug 24975: Fix l10n_source definition in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
Martin Renvoize changed:
What|Removed |Added
Attachment #132509|0 |1
is obsolete||
--- Comment #56 from Martin Renvoize ---
Created attachment 132522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132522&action=edit
Bug 24975: Keep the translations, prevent duplicates, and other fixes
Translations are no longer lost when you change an itemtype's
description, thanks to a new `l10n_source.key` column which must be
unique within it's "text group" ('itemtype' is a text group)
This also prevent duplicate entries in l10n_source
Columns were renamed to better match their purpose:
* context -> group
* source -> text
Use Koha::Cache::Memory::Lite if other caching systems are not available
Prepend 'l10n:' to the cache key to avoid conflicts
Test plan:
1. DROP TABLE IF EXISTS l10n_target, l10n_source
2. Follow the test plan from previous patch
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
Martin Renvoize changed:
What|Removed |Added
Attachment #132508|0 |1
is obsolete||
--- Comment #55 from Martin Renvoize ---
Created attachment 132521
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132521&action=edit
Bug 24975: Refactor database translations
This is an attempt to make the process of translating database strings
(like itemtype descriptions) easier for developers and translators.
For developers by reducing the amount of code needed to enable
translations for a new kind of object (authorised values, letters, news,
...).
For translators by providing a single entry point for all translatable
strings
Table `localization` is replaced by two new tables `l10n_source` and
`l10n_target`. `l10n_source` contains the original text while
`l10n_target` contains the corresponding translations
`l10n_source` is automatically updated whenever an itemtype is
inserted, updated, or deleted, so it is always up to date (this is done
in Koha::Schema::Result::ItemType).
It means that if you delete an itemtype, translations get deleted too.
It also means that if you change an itemtype's description, translations
are lost (not sure if this should be fixed, since if description
changes, translations should probably be changed too)
It adds a new subroutine in Koha::I18N, `db_t`, which returns the
translation for a given context and string, according to the current
language. Translations are stored in memcached (if enabled).
So instead of having to declare a new subroutine
Koha::ItemType::translated_description, you can write
db_t('itemtype', $itemtype->description)
In templates you can write
[% ItemTypes.t(itemtype.description) %]
There's also a new page, accessible from the administration main page,
"Localization". It displays all translatable strings and allow to
translate them for all enabled languages.
Test plan:
1. Before applying the patch, make sure you have translated some
itemtypes. Translations should be kept by the updatedatabase script.
Before applying the updatedatabase you may want to comment the
'DROP TABLE localization' statement if you want to keep this table
2. Apply patch, run updatedatabase.pl, run update_dbix_class_files.pl
and reload starman
3. Go to Admin » Localization, verify that you have your itemtypes and
their translations.
4. Verify that the filter is working (it filters on the source column
only).
5. Translate some strings by clicking on one of the 'Translate' link,
entering some text and clicking on the 'Save' button. You can remove
a translation by emptying the text box.
6. Add a new item type. Verify that it appears in the Localization page
7. Change the description of this item type. Verify that the new
description appears in Localization page and that the old description
is gone
8. Delete this item type and verify that its description no longer
appears in Localization page
9. Navigate through Koha (intranet and opac) in multiple languages and
verify that item types are translated (if not, please verify in
master too, not all occurrences were translated)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132499|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132500|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132501|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132502|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132503|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132504|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132505|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132506|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132507|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #54 from Martin Renvoize --- Created attachment 132520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132520&action=edit Bug 24975: Pass transation_key in GetItemsInfo https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #132388|0 |1 is obsolete|| --- Comment #53 from Martin Renvoize --- Created attachment 132519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132519&action=edit Bug 24975: Fix bugs https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #52 from Martin Renvoize --- Created attachment 132518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132518&action=edit Bug 24975: DBIC Build https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #51 from Martin Renvoize --- Created attachment 132517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132517&action=edit Bug 24975: Add to Koha::UI::Form::Builder::Item https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132498|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #50 from Martin Renvoize --- Created attachment 132516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132516&action=edit Bug 24975: Use translation_key in preference to description https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #49 from Martin Renvoize --- Created attachment 132515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132515&action=edit Bug 24975: Add translation_key method example https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132497|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #48 from Martin Renvoize --- Created attachment 132514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132514&action=edit Bug 24975: Re-introduce translated_description accessor method https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #47 from Martin Renvoize --- Created attachment 132513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132513&action=edit Bug 24975: Use 'key' for translation lookup This patch switches from using the original text as a key for translations to using a dedicated 'key' field. We also add in a 'fuzzy' flag to denote when the source text has changed and as such the pre-existing translations may be incorrect. ToDo: 1/ Expose 'Fuzzy' on the 'Localization' admin page 2/ Add a 'translation_key' method to Koha::Itemtype to encourage the adoption of a standardly names accessor to get the 'translation_key' from a Koha::Object derived class. https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #46 from Martin Renvoize --- Created attachment 132512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132512&action=edit Bug 24975: (follow-up) Rebase for bug 21946 https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132496|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #102701|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 132511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132511&action=edit Bug 24975: Fix syntax issues https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What|Removed |Added Attachment #102688|0 |1 is obsolete|| --- Comment #44 from Martin Renvoize --- Created attachment 132510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132510&action=edit Bug 24975: Fix l10n_source definition in kohastructure.sql https://bugs.koha-community.org/show_bug.cgi?id=24875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
Martin Renvoize changed:
What|Removed |Added
Attachment #102514|0 |1
is obsolete||
--- Comment #43 from Martin Renvoize ---
Created attachment 132509
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132509&action=edit
Bug 24975: Keep the translations, prevent duplicates, and other fixes
Translations are no longer lost when you change an itemtype's
description, thanks to a new `l10n_source.key` column which must be
unique within it's "text group" ('itemtype' is a text group)
This also prevent duplicate entries in l10n_source
Columns were renamed to better match their purpose:
* context -> group
* source -> text
Use Koha::Cache::Memory::Lite if other caching systems are not available
Prepend 'l10n:' to the cache key to avoid conflicts
Test plan:
1. DROP TABLE IF EXISTS l10n_target, l10n_source
2. Follow the test plan from previous patch
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/show_bug.cgi?id=24875
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
Martin Renvoize changed:
What|Removed |Added
Attachment #102513|0 |1
is obsolete||
--- Comment #42 from Martin Renvoize ---
Created attachment 132508
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132508&action=edit
Bug 24975: Refactor database translations
This is an attempt to make the process of translating database strings
(like itemtype descriptions) easier for developers and translators.
For developers by reducing the amount of code needed to enable
translations for a new kind of object (authorised values, letters, news,
...).
For translators by providing a single entry point for all translatable
strings
Table `localization` is replaced by two new tables `l10n_source` and
`l10n_target`. `l10n_source` contains the original text while
`l10n_target` contains the corresponding translations
`l10n_source` is automatically updated whenever an itemtype is
inserted, updated, or deleted, so it is always up to date (this is done
in Koha::Schema::Result::ItemType).
It means that if you delete an itemtype, translations get deleted too.
It also means that if you change an itemtype's description, translations
are lost (not sure if this should be fixed, since if description
changes, translations should probably be changed too)
It adds a new subroutine in Koha::I18N, `db_t`, which returns the
translation for a given context and string, according to the current
language. Translations are stored in memcached (if enabled).
So instead of having to declare a new subroutine
Koha::ItemType::translated_description, you can write
db_t('itemtype', $itemtype->description)
In templates you can write
[% ItemTypes.t(itemtype.description) %]
There's also a new page, accessible from the administration main page,
"Localization". It displays all translatable strings and allow to
translate them for all enabled languages.
Test plan:
1. Before applying the patch, make sure you have translated some
itemtypes. Translations should be kept by the updatedatabase script.
Before applying the updatedatabase you may want to comment the
'DROP TABLE localization' statement if you want to keep this table
2. Apply patch, run updatedatabase.pl, run update_dbix_class_files.pl
and reload starman
3. Go to Admin » Localization, verify that you have your itemtypes and
their translations.
4. Verify that the filter is working (it filters on the source column
only).
5. Translate some strings by clicking on one of the 'Translate' link,
entering some text and clicking on the 'Save' button. You can remove
a translation by emptying the text box.
6. Add a new item type. Verify that it appears in the Localization page
7. Change the description of this item type. Verify that the new
description appears in Localization page and that the old description
is gone
8. Delete this item type and verify that its description no longer
appears in Localization page
9. Navigate through Koha (intranet and opac) in multiple languages and
verify that item types are translated (if not, please verify in
master too, not all occurrences were translated)
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/show_bug.cgi?id=24875
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 Martin Renvoize changed: What|Removed |Added Attachment #132495|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #24 from Martin Renvoize --- Created attachment 132507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132507&action=edit Bug 24975: Pass transation_key in GetItemsInfo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #23 from Martin Renvoize --- Created attachment 132506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132506&action=edit Bug 24975: Fix bugs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #22 from Martin Renvoize --- Created attachment 132505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132505&action=edit Bug 24975: DBIC Build -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #21 from Martin Renvoize --- Created attachment 132504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132504&action=edit Bug 24975: Add to Koha::UI::Form::Builder::Item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #20 from Martin Renvoize --- Created attachment 132503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132503&action=edit Bug 24975: Use translation_key in preference to description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #19 from Martin Renvoize --- Created attachment 132502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132502&action=edit Bug 24975: Add translation_key method example -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #18 from Martin Renvoize --- Created attachment 132501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132501&action=edit Bug 24975: Re-introduce translated_description accessor method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #17 from Martin Renvoize --- Created attachment 132500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132500&action=edit Bug 24975: Use 'key' for translation lookup This patch switches from using the original text as a key for translations to using a dedicated 'key' field. We also add in a 'fuzzy' flag to denote when the source text has changed and as such the pre-existing translations may be incorrect. ToDo: 1/ Expose 'Fuzzy' on the 'Localization' admin page 2/ Add a 'translation_key' method to Koha::Itemtype to encourage the adoption of a standardly names accessor to get the 'translation_key' from a Koha::Object derived class. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #16 from Martin Renvoize --- Created attachment 132499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132499&action=edit Bug 24975: (follow-up) Rebase for bug 21946 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #15 from Martin Renvoize --- Created attachment 132498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132498&action=edit Bug 24975: Fix syntax issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875 --- Comment #14 from Martin Renvoize --- Created attachment 132497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132497&action=edit Bug 24975: Fix l10n_source definition in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875
--- Comment #13 from Martin Renvoize ---
Created attachment 132496
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132496&action=edit
Bug 24975: Keep the translations, prevent duplicates, and other fixes
Translations are no longer lost when you change an itemtype's
description, thanks to a new `l10n_source.key` column which must be
unique within it's "text group" ('itemtype' is a text group)
This also prevent duplicate entries in l10n_source
Columns were renamed to better match their purpose:
* context -> group
* source -> text
Use Koha::Cache::Memory::Lite if other caching systems are not available
Prepend 'l10n:' to the cache key to avoid conflicts
Test plan:
1. DROP TABLE IF EXISTS l10n_target, l10n_source
2. Follow the test plan from previous patch
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24875] Remove extra punctuation from tools home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24875
--- Comment #12 from Martin Renvoize ---
Created attachment 132495
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132495&action=edit
Bug 24975: Refactor database translations
This is an attempt to make the process of translating database strings
(like itemtype descriptions) easier for developers and translators.
For developers by reducing the amount of code needed to enable
translations for a new kind of object (authorised values, letters, news,
...).
For translators by providing a single entry point for all translatable
strings
Table `localization` is replaced by two new tables `l10n_source` and
`l10n_target`. `l10n_source` contains the original text while
`l10n_target` contains the corresponding translations
`l10n_source` is automatically updated whenever an itemtype is
inserted, updated, or deleted, so it is always up to date (this is done
in Koha::Schema::Result::ItemType).
It means that if you delete an itemtype, translations get deleted too.
It also means that if you change an itemtype's description, translations
are lost (not sure if this should be fixed, since if description
changes, translations should probably be changed too)
It adds a new subroutine in Koha::I18N, `db_t`, which returns the
translation for a given context and string, according to the current
language. Translations are stored in memcached (if enabled).
So instead of having to declare a new subroutine
Koha::ItemType::translated_description, you can write
db_t('itemtype', $itemtype->description)
In templates you can write
[% ItemTypes.t(itemtype.description) %]
There's also a new page, accessible from the administration main page,
"Localization". It displays all translatable strings and allow to
translate them for all enabled languages.
Test plan:
1. Before applying the patch, make sure you have translated some
itemtypes. Translations should be kept by the updatedatabase script.
Before applying the updatedatabase you may want to comment the
'DROP TABLE localization' statement if you want to keep this table
2. Apply patch, run updatedatabase.pl, run update_dbix_class_files.pl
and reload starman
3. Go to Admin » Localization, verify that you have your itemtypes and
their translations.
4. Verify that the filter is working (it filters on the source column
only).
5. Translate some strings by clicking on one of the 'Translate' link,
entering some text and clicking on the 'Save' button. You can remove
a translation by emptying the text box.
6. Add a new item type. Verify that it appears in the Localization page
7. Change the description of this item type. Verify that the new
description appears in Localization page and that the old description
is gone
8. Delete this item type and verify that its description no longer
appears in Localization page
9. Navigate through Koha (intranet and opac) in multiple languages and
verify that item types are translated (if not, please verify in
master too, not all occurrences were translated)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359
--- Comment #3 from Johanna Räisä ---
(In reply to Nick Clemens from comment #2)
> One this page we are calling GetBudgetHierarchy in a loop on al the budget
> periods - this seems to be extra work.
>
> Compare this to the way things are handled in neworderempty.pl:
> 333 my $budget = GetBudget($budget_id);
> 334 # build budget list
> 335 my $budget_loop = [];
> 336 my $budgets = GetBudgetHierarchy;
> 337 foreach my $r (@{$budgets}) {
> 338 next unless (CanUserUseBudget($patron, $r, $userflags));
> 339 push @{$budget_loop}, {
> 340 b_id => $r->{budget_id},
> 341 b_txt => $r->{budget_name},
> 342 b_sort1_authcat => $r->{'sort1_authcat'},
> 343 b_sort2_authcat => $r->{'sort2_authcat'},
> 344 b_active => $r->{budget_period_active},
> 345 b_sel => ( $r->{budget_id} == $budget_id ) ? 1 : 0,
> 346 b_level => $r->{budget_level},
> 347 };
> 348 }
>
> I think we have other occurrences as well - we should consolidate this code
> and make the dropdowns work the same
>
> I am not against removing the totals, but I think the loop in the script is
> the bigger culprit here
Yes, there might be other occurrences which need optimization too. When I
investigated the culprit the loop didn't stand out. The real affect came from
skipping the calculations. The improvement was huge, the waiting time was first
1.89 minutes and after this patch it went to 460ms.
If some places we are using only part of what GetBudgetHierarchy offers, would
it be a good idea make separate functions?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29990] Show authority heading use in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #7 from Alex Buckley --- *** Bug 26079 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26079] Use 008 positions 14-16 as authoritative authority entry type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26079 Alex Buckley changed: What|Removed |Added Resolution|--- |DUPLICATE Status|ASSIGNED|RESOLVED --- Comment #6 from Alex Buckley --- Bug 29990 displays how an authority can be used based on the MARC 008/14-16 one of the objectives of this bug report, so I am marking this as resolved. *** This bug has been marked as a duplicate of bug 29990 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Aleisha Amohia changed: What|Removed |Added Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 --- Comment #2 from Aleisha Amohia --- Created attachment 132494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132494&action=edit Bug 30402: Import authorities subroutines to ImportBatch script The following authorities subroutines are used by the ImportBatch script but are not accessible, because they aren't imported. This caused MARC importing errors. - GetAuthorityXML - ModAuthority - DelAuthority These affected the BatchCommitRecords and BatchRevertRecords routines, and it wasn't caught because there are no tests written for them. To test: 1. Find an existing authority record, or import one to use. 2. Save this authority record (export/download). 3. Go to Admin -> Record matching rules. Create a new record matching rule for authorities that matches on 001, Local-Number index. 4. Go to Tools -> Stage MARC for import. Upload the authority file you just downloaded. 5. Change record type to authority. 6. Under 'Look for existing items in catalog?', set the record matching rule to the rule you just made which matches on 001. If matching record found, replace the existing one. If no match is found, ignore. 7. Stage the record. Once complete, a match should've been found. 8. Go to Staged MARC management. 9. Import the batch into the catalog. Notice it hangs and never completes. 10. Apply the patch and restart services. 11. Repeat steps 4-9. This time importing should be successful. Sponsored-by: Educational Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Aleisha Amohia --- Have tracked down this is due to authorities subroutines not being imported to the MARC management script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #136 from Alex Buckley --- (In reply to Lucas Gass from comment #135) > This all seems to work great! Followed the test plan and everything worked > as described. > > Tests passed and QA script seems to be happy now! This is a great addition. Thank you Lucas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30402] New: Authority import hanging when replacing matched record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Bug ID: 30402 Summary: Authority import hanging when replacing matched record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org We've discovered a bug with the MARC staged management. When staging an authority record, we're applying a matching rule so that it should REPLACE a matched record. When trying to import, it hangs on 0% and never progresses or succeeds. This does not happen with ignoring or adding, only replacing. This does not happen with biblios but does with authorities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not accept whitespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142 --- Comment #5 from Katrin Fischer --- Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #103 from The Minh Luong --- Created attachment 132493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132493&action=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #102 from The Minh Luong --- Created attachment 132492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132492&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #101 from The Minh Luong --- Created attachment 132491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132491&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #100 from The Minh Luong --- Created attachment 132490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132490&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #99 from The Minh Luong --- Created attachment 132489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132489&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #130691|0 |1 is obsolete|| Attachment #130692|0 |1 is obsolete|| Attachment #130693|0 |1 is obsolete|| Attachment #130694|0 |1 is obsolete|| Attachment #130695|0 |1 is obsolete|| Attachment #131492|0 |1 is obsolete|| --- Comment #98 from The Minh Luong --- Created attachment 132488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132488&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30401] Convert budgets administration page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401 --- Comment #1 from Owen Leonard --- Created attachment 132487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132487&action=edit Bug 30401: Convert budgets administration page tabs to Bootstrap This patch updates the budgets administration page to use Bootstrap tabs instead of jQueryUI. This patch contains indentation changes, so ignore whitespace when you use your preferred diff tool. To test, apply the patch and go to Administration -> Budgets. Check that the "Active budgets" and "Inactive budgets" work correctly. Append "?tab=2" to the page URL to confirm that the second tab is preselected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30401] Convert budgets administration page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #340 from Kyle M Hall --- (In reply to Katrin Fischer from comment #336) > Patches still apply with a tiny rebase :) > > I've added the rebased patch set with 2 tiny follow-ups, but have some > issues I am struggling with: > > 1) Tests don't pass and there is a warning that might relate to some rebase > issue: > > kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons.t > t/db_dependent/Koha/Patrons.t .. Subroutine libraries_where_can_see_patrons > redefined at /kohadevbox/koha/Koha/Patron.pm line 1610. Should be fixed with this latest followup! > > 2) Permission descriptions > > We now have: > > * Edit any item. If not set the logged in user can only edit items whose > home library matches the logged in library. (edit_any_item) > * Edit items (edit_items) > > I think we need to actually rephrase Edit items if the note on edit_any_item > rings true. Also, we need to factor in the library group feature somehow... > > Edit all items with user's home library and from libaries within the edit > item library group (edit_items) > > It makes me realize I am not super sure yet how the library groups and > permissions work together, can you please check and maybe explain a little > more? I've added a followup to update those descriptions. I think the new ones are better, but if anyone has more improvements they would be welcome! > > 3) Library groups > > Limit item editing for librarians outside of this group. > > Maybe this would be clearer as: > > Limit item editing to librarians inside of this group > > But I might be misunderstanding something? That sounds good to me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #339 from Kyle M Hall --- Created attachment 132486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132486&action=edit Bug 20256: (QA follow-up) Update group feature description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron to preserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Nick Clemens changed: What|Removed |Added Attachment #131126|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 132485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132485&action=edit Bug 29059: Keep non-repeatable attribute from patron to preserve when merging See bug 21648 comment 17. Suggestion is to keep the non-repeatable patron's attribute from the patron we selected instead of raising a blocking error. A side-effect will be that when several patrons are merged, the non-repeatable attribute from the first one will be kept, which can result in unexpected result if the original patron does not have the attribute defined. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron to preserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #338 from Kyle M Hall --- Created attachment 132484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132484&action=edit Bug 20256: (QA follow-up) Update permission descriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #337 from Kyle M Hall --- Created attachment 132483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132483&action=edit Bug 20256: (QA follow-up) Remove duplicated sub -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30401] New: Convert budgets administration page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401 Bug ID: 30401 Summary: Convert budgets administration page tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the budgets administration template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30401 [Bug 30401] Convert budgets administration page tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 --- Comment #1 from Owen Leonard --- Created attachment 132482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132482&action=edit Bug 30400: Convert invoices page tabs to Bootstrap This patch updates the invoices page to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - Check that the "Open invoices" and "Closed invoices" tabs work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30400] Convert invoices page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 [Bug 30400] Convert invoices page tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Owen Leonard changed: What|Removed |Added Blocks||30400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 [Bug 30400] Convert invoices page tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30400] New: Convert invoices page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30400 Bug ID: 30400 Summary: Convert invoices page tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30398 Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs on the invoices page with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 [Bug 30398] Reindent invoices template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #2 from Owen Leonard --- Created attachment 132481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132481&action=edit Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #1 from Owen Leonard --- Created attachment 132480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132480&action=edit Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30399] New: Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Bug ID: 30399 Summary: Patron.t fails when there is a patron attribute that is mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org I noticed this while testing another bug and this is happening to me while using koha-testing-docker. To recreate: 1. sudo koha-shell kohadev 2. prove t/db_dependent/Koha/Patron.t 3. Tests pass. 4. Add a new patron attribute type and make it Mandatory by clicking the checkbox. 5. prove t/db_dependent/Koha/Patron.t # Failed test 'extended_attributes' # at t/db_dependent/Koha/Patron.t line 686. Missing mandatory extended attribute (type=TEST)# Looks like your test exited with 255 just after 7. t/db_dependent/Koha/Patron.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/16 subtests Test Summary Report --- t/db_dependent/Koha/Patron.t (Wstat: 65280 Tests: 7 Failed: 1) Failed test: 7 Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 7. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #135 from Lucas Gass --- This all seems to work great! Followed the test plan and everything worked as described. Tests passed and QA script seems to be happy now! This is a great addition. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Lucas Gass changed: What|Removed |Added Attachment #132478|0 |1 is obsolete|| --- Comment #134 from Lucas Gass --- Created attachment 132479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132479&action=edit Bug 26346: (follow-up) Fixing for QA tool Adding is_boolean to virtualshelves.public and virtualshelves.allow_change_from_staff in Virtualshelve.pm DBIC schema file. Fixing typo in Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Lucas Gass changed: What|Removed |Added Attachment #132373|0 |1 is obsolete|| --- Comment #133 from Lucas Gass --- Created attachment 132478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132478&action=edit Bug 26346: (follow-up) Fixing for QA tool Adding is_boolean to virtualshelves.public and virtualshelves.allow_change_from_staff in Virtualshelve.pm DBIC schema file. Fixing typo in Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Lucas Gass changed: What|Removed |Added Attachment #131764|0 |1 is obsolete|| --- Comment #132 from Lucas Gass --- Created attachment 132477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132477&action=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply first 3 patches and run updatedatabase.pl cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Restart memcached and plack 4. Create 4 patron accounts: - User A : Superlibrarian permissions - User B : 'Staff access, allows viewing of catalogue in staff interface (catalogue)' - User C : No permissions - User D : 'Staff access, allows viewing of catalogue in staff interface' and 'Lists' > Edit public lists (edit_public_lists)' sub-permission 5. Login to staff client as User A. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 6. Log into the staff client as User B. Confirm you can add items to the list from the following staff client pages: - Individual list page using the 'Add items' button - Staff client search result page - Staff client biblio detail page 7. Confirm you can remove items from the list 8. Confirm you can perform an OPAC search when not logged in 9. Log into the OPAC as User B. Confirm you can add items to the list from the following OPAC pages: - OPAC search result page - OPAC biblio detail page 10. Log into the OPAC as User C. Do an OPAC search and confirm you can view the list, but not add items to it 11. Login to the staff client as User B. Create a new list with the following settings: - 'Category'='Private', - 'Allow changes to contents from'='Staff only' Notice a red hint message is displayed. Change 'Category'='Public' and notice the hint is removed 12. Log into the OPAC as User C. Notice the 'Staff only' option is not available when creating a list 13. Log into the OPAC as User B. Repeat step 11. Confirm the same outcome 14. Log into the staff client as User A. Create a list with the following settings: - Public = 'Public' - Allow changes to contents from = 'owner only' 15. Log into the staff client as User D. Edit the list from step 14 confirm you can edit the list to have 'Allow changes to contents from' = 'Staff only' 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Lucas Gass changed: What|Removed |Added Attachment #128384|0 |1 is obsolete|| --- Comment #131 from Lucas Gass --- Created attachment 132476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132476&action=edit Bug 26346: Updated schema file Sponsored-By: Catalyst IT Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Lucas Gass changed: What|Removed |Added Attachment #128383|0 |1 is obsolete|| --- Comment #130 from Lucas Gass --- Created attachment 132475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132475&action=edit Bug 26346: Database changes - Adds allow_change_from_staff to virtualshelves table - Add edit_public_lists sub-permission Sponsored-By: Catalyst IT Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] New: Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Bug ID: 30398 Summary: Reindent invoices template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org This patch will update the invoices template so that it has consistent indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30396] Convert basket groups page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396 Lucas Gass changed: What|Removed |Added Attachment #132403|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 132474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132474&action=edit Bug 30396: Convert basket groups page tabs to Bootstrap This patch replaces the use of jQueryUI tabs on the basket groups page, in the view where open and closed basket groups are displayed in separate tabs. This patch includes indentation changes, so please ignore whitespace when using your preferred diff tool. To test you should have at least two basket groups set up in Acquisitions, one open and one closed. Go to Acquisitions -> Vendor -> Basket groups and confirm that the "Open" and "Closed" tabs look correct and work correctly. Under the "Closed" tab, try clicking the "Reopen" button. The page will refresh but you should still see the "Closed" tab active. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30396] Convert basket groups page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30396 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
