[Koha-bugs] [Bug 29155] Upgrade jquery version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Victor Grousset/tuxayo --- Issues found: - make a hold - go the patron detail page - click on the holds tab - list is empty, but it shouldn't - js console: Uncaught TypeError: can't access property "id", ui.newTab.context is undefined activate http://localhost:8081/intranet-tmpl/prog/js/pages/circulation_21.1200033.js:14 jQuery 32 http://localhost:8081/intranet-tmpl/prog/js/pages/circulation_21.1200033.js:12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30551] Cash register report shows wrong library when paying fees in two different libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30551] New: Cash register report shows wrong library when paying fees in two different libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Bug ID: 30551 Summary: Cash register report shows wrong library when paying fees in two different libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: shi-yao.w...@inlibro.com QA Contact: testo...@bugs.koha-community.org Cash register report shows wrong transaction library when paying fees in different libraries using the same account. Test plan to reproduce the bug: 1- Use cash registers (administration > system preferences > UseCashRegisters) 2- Create another library if you only have one (administration > libraries > new library) 3- Create a cash register in each library if they don't already have one (administration > cash registers > new cash register) 4- Create a fee on your own account and pay it right after in both libraries. 5- Go to reports > cash register and generate the statistics. 6- Notice "transaction library" in both rows are the same even though the fees were paid in two different libraries and two different cash registers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30550] OPAC recalls page tries to use jQueryUI datepicker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550 --- Comment #1 from Owen Leonard --- Created attachment 13 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13=edit Bug 30550: OPAC recalls page tries to use jQueryUI datepicker This patch updates the recalls page in the OPAC so that it uses Flatpickr for the "Recall not needed after" field. To test apply the patch and enable the UseRecalls preference if necessary. You made need to update your circulation rules as well, defining some default values for recalls. - Log in to the OPAC. - Locate a bibliographic record which has one item and that item is checked out. - Click "Place recall." - The "Recall not needed after" field should be styled correctly, and clicking it should trigger the calendar popup. - You should be limited to selections after today's date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30550] OPAC recalls page tries to use jQueryUI datepicker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What|Removed |Added Blocks||30550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550 [Bug 30550] OPAC recalls page tries to use jQueryUI datepicker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30550] New: OPAC recalls page tries to use jQueryUI datepicker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30550 Bug ID: 30550 Summary: OPAC recalls page tries to use jQueryUI datepicker Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 29212 The OPAC recalls template predates the switch to Flatpickr, but without jQueryUI datepicker available the calendar popup doesn't work. This patch will implement Flatpickr for that field. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 [Bug 29212] Use Flatpickr on OPAC pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3935] Schedule tasks periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on pending patron updates page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 --- Comment #1 from Owen Leonard --- Created attachment 12 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12=edit Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page This patch updates the pending patron updates page to use Bootstrap collapse instead of jQueryUI. This patch contains whitespace changes, so view the diff with this in mind. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, log into the OPAC and submit an update via the "Your personal details" page. Ideally do this for two or more patrons. - In the staff client, follow the "Patrons requesting modifications" link. - On the "Update patron records" page you should see the headings representing each of the patrons with pending updates. The first panel should be expanded. - Confirm that the panels expand and collapse correctly. - Follow the "Patron details" link for one of these patrons. - Click the "Review pending modifications" link on the patron detail page. - When the update page opens that patron's panel should be expanded. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30549] Replace the use of jQueryUI Accordion on pending patron updates page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30535] Add "Tool plugins" to the main tools screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535 --- Comment #1 from Fred King --- Update: I added a tool plugin, and now "Tool plugins" appears on the main Tools page, with my plugin listed under it. Maybe it needs a plugin to appear? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 Owen Leonard changed: What|Removed |Added Depends on||30549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 [Bug 30549] Replace the use of jQueryUI Accordion on pending patron updates page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 Owen Leonard changed: What|Removed |Added Blocks||30549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 [Bug 30549] Replace the use of jQueryUI Accordion on pending patron updates page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30549] New: Replace the use of jQueryUI Accordion on pending patron updates page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Bug ID: 30549 Summary: Replace the use of jQueryUI Accordion on pending patron updates page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30494 Blocks: 29224 As part of Bug 29224, "OMNIBUS: Replace the use of jQueryUI Accordion" we should replace the use of the jQueryUI accordion component on the pending patron updates page with Bootstrap's Collapse component. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30548] New: Plugin for coded data 181 UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30548 Bug ID: 30548 Summary: Plugin for coded data 181 UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: igor.a.syc...@mail.ru QA Contact: testo...@bugs.koha-community.org Please, add plugins for coded data 181a and 181b UNIMARC https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_181_new2016.pdf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30547] Plugin for coded data 123p UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30547 --- Comment #1 from Igor A. Sychev --- https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_123_update.pdf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30547] New: Plugin for coded data 123p UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30547 Bug ID: 30547 Summary: Plugin for coded data 123p UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: igor.a.syc...@mail.ru QA Contact: testo...@bugs.koha-community.org Please, add plugin for coded data 123p UNIMARC $p Planet (Mandatory for planets other than Earth, Not repeatable) $p/0-1 Planet ea Earth ju Jupiter ma Mars me Mercury ne Neptune pl Pluto sa Saturn ur Uranus ve Venus zz Other $p/2 Satellite s The body whose co-ordinates are recorded in subfields $d-$g is a satellite of the planet coded on pos. 0-1. y Not applicable: the body whose co-ordinates are recorded in subfields $d-$g is the planet itself, as coded on pos. 0-1. https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 --- Comment #1 from Owen Leonard --- Created attachment 11 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11=edit Bug 30545: Replace the use of jQueryUI Accordion on the notices page This patch updates the notices edit interface in order to replace jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Set the TranslateNotices system preference to "Don't allow." - Go to Tools -> Notices and edit any notice. - On the "Modify notice" page you should see three collapsed sections: Email, Print, and SMS. - Clicking the section headings should expand and collapse the panels. - With one of the panels open, click Save -> Save and continue editing. - When the page reloads the same panel should be expanded. - Enable the TranslateNotices system preference. - Return to the edit interface for one of your notices. - You should now see at least two tabs: Default and English. - The sections under each tab should continue to work correctly. - Test the "Save and continue" functionality again. When redirected you should return to both the correct tab and the correct panel, e.g. the "Print" section under the "English (en)" tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26646] Holds to Pull should show distinct item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26646 Rhonda Kuiper changed: What|Removed |Added CC||rkui...@roundrocktexas.gov --- Comment #4 from Rhonda Kuiper --- We are interested in getting the holds to pull to show all item level holds for a biblio. The situation that brought this problem to our attention is as follows: Patron A puts item-level holds on two items on a single biblio record. We run the hold to pull report and only one item shows on the report. We pull it and scan it in. Then later that day or the next morning we run the report again and the second item show up. We pull it and scan it in. The experience for the patron is that they get two hold notices between 4 and 18 hours apart which could lead to two trips to the library when they could have received the hold notices at the 'same' time and made one trip. Rhonda K. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28072] Z39.50/SRU servers would be a great addition to Mana KB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #4 from Cab Vinton --- +1 for this idea! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075 Igor A. Sychev changed: What|Removed |Added CC||igor.a.syc...@mail.ru --- Comment #10 from Igor A. Sychev --- Now only one character --- All data in $a is identified by character position within the subfield. Conventionally the character positions are numbered 0-12. Not repeatable. Table of Subfield $a Fixed-length Data Elements Name of Data Element | Number of Characters | Character Positions Type of electronic resource 1 0 Special material designation 1 1 Colour 1 2 Dimensions 1 3 Sound 1 4 Image bit depth 3 5-7 Number of file formats 1 8 Quality assurance target(s) 1 9 Antecedent/Source 1 10 Level of compression 1 11 Reformatting quality 1 12 --- https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf See also https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_135a_1_update2019_onlne_final.pdf https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_135_update2017.pdf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 10 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10=edit Bug 30536: Update spec files This patch removes superflous x-koha-embed defintions at the top level of the endpoint specifications. It also replaces a few x-koha-embeds at the top level with parameter lists where this had been missed in preceeding patches. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 133329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133329=edit Bug 30536: Remove validation overhead With the introduction of proper validation of collection headers in OpenAPI we no longer need to do our own validation here. This patch removes the early validation of x-koha-embed headers in preference to letting OpenAPI do it once and only once instead. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 133328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133328=edit Bug 30536: Refer to parameters enum This patch updates the stash_embed method to use the parameters hash enum instead of the top level x-koha-embed custom definition. This way we can remove the requirement for defining this list twice. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 133327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133327=edit Bug 30536: Unit tests This patch adds tests to make sure there's no behavior change regarding error conditions. When requests include wrong x-koha-embed values, a 400 error should be returned, both in our original implementation or relying on the Mojolicious::Plugin::OpenAPI features. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/query.t => SUCCESS: Tests pass 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests still pass 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133325|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133324|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133313|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #13 from Tomás Cohen Arazi --- Marking as NSO to gather other's opinions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26646] Holds to Pull should show distinct item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26646 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111403|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Comment on attachment 111403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111403 Bug 26646: Group holds to pull by item rather than bib Obsoleting this patch that didn't quite work when I wrote it and almost certainly won't apply now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30546] Initial articles not ignored when sorting by the summary column in the pending_orders table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30546 --- Comment #1 from Barbara Johnson --- Created attachment 133326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133326=edit Title with initial articles not sorted correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30546] New: Initial articles not ignored when sorting by the summary column in the pending_orders table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30546 Bug ID: 30546 Summary: Initial articles not ignored when sorting by the summary column in the pending_orders table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org Bug 29570 (Unable to sort summary column of pending_orders table on parcel.pl by summary column) added sorting capability back to the summary column for the pending orders table. However, search results do not ignore the articles 'a', 'an' and 'the' when displaying the results. I don't believe it used to be like this and other areas in acquisitions, such as invoices, ignore initial articles when displaying search results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #12 from Martin Renvoize --- Created attachment 133325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133325=edit Bug 30536: Update spec files This patch removes superflous x-koha-embed defintions at the top level of the endpoint specifications. It also replaces a few x-koha-embeds at the top level with parameter lists where this had been missed in preceeding patches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133314|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 133324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133324=edit Bug 30536: Remove validation overhead With the introduction of proper validation of collection headers in OpenAPI we no longer need to do our own validation here. This patch removes the early validation of x-koha-embed headers in preference to letting OpenAPI do it once and only once instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #20 from Marcel de Rooy --- Reworked this a bit and tested on top of 28786 - 29873 - 29894. Main thing is splitting the first patch and moving some code to Koha::Patron. Taking the liberty to set it to Signed Off with one request: Please run the Selenium test. And if you agree, squash patch 4 and patch 5. If you would not agree, feel free to change status and tell me about it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 [Bug 30545] Replace the use of jQueryUI Accordion on the notices page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Owen Leonard changed: What|Removed |Added Blocks||29226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Blocks||28998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 [Bug 28998] Encrypt borrowers.secret -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What|Removed |Added Blocks|28998 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 [Bug 28998] Encrypt borrowers.secret -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 Marcel de Rooy changed: What|Removed |Added Depends on|28786 |29894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 [Bug 28786] Two-factor authentication for staff client - TOTP https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 [Bug 29894] 2FA: Add few validations, clear secret, send register notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #19 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #17) > Created attachment 133322 [details] [review] > Bug 28998: Add encryption_key to the config file > > Signed-off-by: Marcel de Rooy Recently a QAer insisted that I should adjust koha-create when adding koha-conf.xml entries :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #18 from Marcel de Rooy --- Created attachment 133323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133323=edit Bug 28998: Add Crypt::CBC dependency Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 Marcel de Rooy changed: What|Removed |Added Attachment #124773|0 |1 is obsolete|| Attachment #124774|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 133322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133322=edit Bug 28998: Add encryption_key to the config file Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 Owen Leonard changed: What|Removed |Added Depends on||30545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 [Bug 30545] Replace the use of jQueryUI Accordion on the notices page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 Owen Leonard changed: What|Removed |Added Blocks||30545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 [Bug 30545] Replace the use of jQueryUI Accordion on the notices page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30545] New: Replace the use of jQueryUI Accordion on the notices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Bug ID: 30545 Summary: Replace the use of jQueryUI Accordion on the notices page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30494 Blocks: 29224 As part of Bug 29224, "OMNIBUS: Replace the use of jQueryUI Accordion" we should replace the use of the jQueryUI accordion component on the notices page with Bootstrap's Collapse component. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #16 from Marcel de Rooy --- Created attachment 133321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133321=edit Bug 28998: [TO_BE_SQUASHED] Adjust secret in Selenium test This patch can be squashed with the previous one, if all is ok. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #15 from Marcel de Rooy --- Created attachment 133320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133320=edit Bug 28998: Adjust Selenium test Test plan: Run t/db_dependent/selenium/authentication_2fa.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #14 from Marcel de Rooy --- Created attachment 133319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133319=edit Bug 28998: (follow-up) Apply changes to TwoFactorAuth module and script Test plan: Run t/db_dependent/Koha/Auth/TwoFactorAuth.t Walk thru cycle register - logout/login - deregister - logout/login. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #13 from Marcel de Rooy --- Created attachment 133318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133318=edit Bug 28998: (follow-up) Add Patron->encode_secret and ->decoded_secret Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 Marcel de Rooy changed: What|Removed |Added Attachment #124772|0 |1 is obsolete|| Attachment #133291|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 133317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133317=edit Bug 28998: Introduce Koha::Encryption Test plan: Run t/db_dependent/Koha/Encryption.t Signed-off-by: Marcel de Rooy [AMENDED] Added copyright line to module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133316|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133315|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #10 from Martin Renvoize --- Created attachment 133316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133316=edit Bug 30536: Use objects->find in SMTP Servers controller This patch removes the direct reference to the koha.embed stashed variable in the SMTP controller and switches us to the modern objects->find approach. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #9 from Martin Renvoize --- Created attachment 133315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133315=edit Bug 30536: Use objects->find in Cashups controller This patch removes the direct reference to the koha.embed stashed variable in the Cashups controller and switches us to the modern objects->find approach. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133309|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 133314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133314=edit Bug 30536: Remove validation overhead With the introduction of proper validation of collection headers in OpenAPI we no longer need to do our own validation here. This patch removes the early validation of x-koha-embed headers in preference to letting OpenAPI do it once and only once instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Martin Renvoize changed: What|Removed |Added Attachment #133303|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 133313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133313=edit Bug 30536: Refer to parameters enum This patch updates the stash_embed method to use the parameters hash enum instead of the top level x-koha-embed custom definition. This way we can remove the requirement for defining this list twice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30537] Patron searches are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30537 --- Comment #3 from Lucas Gass --- (In reply to Martin Renvoize from comment #2) > I used my powers as an RM Assistant to push the follow-up provided by Tomas > on bug 29810 so this should be working again now. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 Owen Leonard changed: What|Removed |Added Attachment #133311|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 133312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133312=edit Bug 30544: Add font awesome version to licenses page This patch simply adds the version number we are using and updates the link to point to our version To test: 1 - Confirm the About->Licenses page points to the correct Font Awesome version Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #6 from Martin Renvoize --- I'm still pottering here.. if we can move the call later, after validation has taken place, we can save ourselves both the validation and param extraction overhead. Not sure how far down the rabbit hole it's worth going for now. Of course.. we'd also want to clean up our spec files here, removing existing x-koha-embed top level keys. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 --- Comment #1 from Nick Clemens --- Created attachment 133311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133311=edit Bug 30544: Add font awesome version to licenses page This patch simply adds the version number we are using and updates the link to point to our version To test: 1 - Confirm the About->Licenses page points to the correct Font Awesome version -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] New: Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 Bug ID: 30544 Summary: Add font awesome version to licenses page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24103] Add option to dump built search query to templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens changed: What|Removed |Added Blocks||30543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Depends on||24103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 [Bug 24103] Add option to dump built search query to templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 --- Comment #1 from Nick Clemens --- Created attachment 133310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133310=edit Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences To test: 1 - Enable DumpSearchQueryTemplate 2 - Confirm you can find the search query in the HTML as a comment 3 - Enable other template dump preference 4 - Confirm they work as before 5 - Confirm new description of preference makes sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30543] New: Decouple DumpSearchQueryTemplate from other template dump preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 Bug ID: 30543 Summary: Decouple DumpSearchQueryTemplate from other template dump preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When using dump search query to debug search issues it would be simpler if we could get only the search query -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #5 from Martin Renvoize --- Created attachment 133309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133309=edit Bug 30536: Remove validation overhead With the introduction of proper validation of collection headers in OpenAPI we no longer need to do our own validation here. This patch removes the early validation of x-koha-embed headers in preference to letting OpenAPI do it once and only once instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30508] Do not display OPAC message about block from holds when OPACHoldRequests is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 --- Comment #1 from Owen Leonard --- Created attachment 133308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133308=edit Bug 30508: Do not display OPAC message about block from holds when OPACHoldRequests is disabled This patch adds a check for the OPACHoldRequests to determine whether a message should be shown to patrons whose account is over the maxoutstanding limit. To test, apply the patch and set the "maxoutstanding" system preference to a low value. Set OPACHoldRequests to "Allow." - Log in to the OPAC as a patron who has outstanding fines or charges which exceed the maxoutstanding value you set. - You should see a message on the "Your summary" page, "Holds are blocked because your fine balance is over the limit." - Set OPACHoldRequests to "Don't allow" and refresh the "Your summary" page in the OPAC. The message should disappear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30508] Do not display OPAC message about block from holds when OPACHoldRequests is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30508] Do not display OPAC message about block from holds when OPACHoldRequests is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30528] Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30528] Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528 --- Comment #2 from Nick Clemens --- Created attachment 133307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133307=edit Bug 30528: Process limits before handling CCL query This patch moves the code that handles limit processing before that for CCL queries to ensure that special limit cases (branch, multibranch, etc) are handled before adding the limits to the query string To test: 1 - Apply unit tests patch only 2 - prove -v t/db_dependent/Search.t 3 - It fails 4 - Apply this patch 5 - It passes! 6 - Test searching and confirm things work as epxected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30528] Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528 --- Comment #1 from Nick Clemens --- Created attachment 133306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133306=edit Bug 30528: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30528] Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30321] Order receive page dies if quantity received is more than 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30321 --- Comment #6 from Emmi Takkinen --- So I've been testing this and it occurs in version 21.11.03 and the conditions are following: - order has _only one item_ attached to it - orders quantityreceived value is more than 0 For some reason when there's only one item on order template orderreceived.tt handles it as Koha::Item, not Koha::Items as it should, thus "Koha::Item->count is not covered by tests!". In orderreceived.pl order->items returns Koha::Items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30523] Quiet console warning about missing shortcut-buttons map file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 --- Comment #1 from Owen Leonard --- Created attachment 133305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133305=edit Bug 30523: Quiet console warning about missing shortcut-buttons map file This patch updates the Flatpickr plugin shortcut-buttons which adds the "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets. This updates it to the latest version, 0.4.0. The file is modified in two ways: The version information is added to the top of the file, and the sourceMappingURL line is removed from the bottom. This quiets browser console warnings about a missing map file. To test, apply the patch and clear your browser cache. - Go to Circulation -> Check out and check out to a patron. - Click "Checkout settings" and click the "Specify due date" field. - In the pop-up calendar, test all controls, including the shortcut links, to confirm that everything works as before. - In the browser console there should be no warning related to shortcut-buttons-flatpickr. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30523] Quiet console warning about missing shortcut-buttons map file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489 --- Comment #1 from Owen Leonard --- Created attachment 133304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133304=edit Bug 30489: Convert MARC and authority subfield edit tabs to Bootstrap This patch updates the MARC and authority subfield edit interface to replace jQueryUI tabs with Bootstrap. The code for handling drag-to-reorder tabs is updated to accommodate the new markup. To test, apply the patch and restart_all. - Go to Administration -> MARC bibliographic framework -> Default framework and choose "MARC structure" from the Actions menu. - In the row for 000 LEADER, click Actions -> View subfields. - Click "Edit." On the edit page the tabs should look correct and work correctly. - Return to the list of tags and click "View subfields" for the 245 tag. - Click one of the "Edit" buttons for any but the first subfield, e.g. "a". - On the "Tag 245 Subfield constraints" page the "a" tab should be pre-selected. - Click any of the subfield tabs and drag it to re-order it in the sequence of tags. - It should stay in the correct slot when you release it. - Save and confirm that the new sequence of subfields has been saved. Perform all the same tests under Administration -> Authority types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #4 from Martin Renvoize --- Attached a first draft for golfing.. I have a hunch we can now drop at least some of the local validation we're doing in this method as we now validate properly at the openapi plugin level? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #3 from Martin Renvoize --- Created attachment 133303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133303=edit Bug 30536: Refer to parameters enum This patch updates the stash_embed method to use the parameters hash enum instead of the top level x-koha-embed custom definition. This way we can remove the requirement for defining this list twice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30531] Search.t needs update for Recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531 Nick Clemens changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30531] Search.t needs update for Recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531 --- Comment #1 from Nick Clemens --- Created attachment 133302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133302=edit BUg 30531: Add mock of UseRecalls to Search.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30531] Search.t needs update for Recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #2 from Martin Renvoize --- Description copied from bug 30542 - I jumped before I found this bug.. haha >Now that we're documenting, and properly validating, the x-koha-embed >parameter we can actually use this parameter definition list instead of the >custom x-koha-embed array from the top level of the endpoint definition. >This would reduce overhead of adding embeds.. we would only need to add them >to the enum list in the parameter definition instead of to both the parameter >definition and a top level x-koha-embed key. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 --- Comment #1 from Martin Renvoize --- *** Bug 30542 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30542] Use x-koha-embed parameter definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542 Martin Renvoize changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 30536 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30542] Use x-koha-embed parameter definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What|Removed |Added Blocks||30542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542 [Bug 30542] Use x-koha-embed parameter definition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30542] New: Use x-koha-embed parameter definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30542 Bug ID: 30542 Summary: Use x-koha-embed parameter definition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com CC: tomasco...@gmail.com Depends on: 29810 Now that we're documenting, and properly validating, the x-koha-embed parameter we can actually use this parameter definition list instead of the custom x-koha-embed array from the top level of the endpoint definition. This would reduce overhead of adding embeds.. we would only need to add them to the enum list in the parameter definition instead of to both the parameter definition and a top level x-koha-embed key. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 [Bug 29810] Add embed options documentation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29898] Overdues.pm line 663, Use of uninitialized value in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898 Anke changed: What|Removed |Added CC||anke.br...@gwdg.de --- Comment #2 from Anke --- (In reply to Elias from comment #0) > After migrating 37 instances from v19.11 to v20.11.13 the > /etc/cron.daily/koha-common logs the following on 7 instances: > > "Use of uninitialized value in string eq at > /usr/share/koha/lib/C4/Overdues.pm line 663." > > We've checked the settings across the instances and the database. > We can't find the root of this warning/error. Do you mean to say that in the other 30 instances the error doesn't occur and the overdues are processed correctly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Kyle M Hall changed: What|Removed |Added Attachment #133300|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 133301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133301=edit Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588. Test Plan: 1) Set MarkLostItemsAsReturned for return claims 2) Mark a checkout as claims returned 3) Verify the checkout is no longer on the patron record 4) Resolve the claim 5) Note the attempt "hangs" but refreshing the page shows it worked 6) Apply this patch, restart all the things! 7) Repeat steps 2-4 8) It works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 --- Comment #2 from Kyle M Hall --- Typo, this bug appears to only exist in 21.05 at this time. Not 21.11 as previously stated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30541] Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 --- Comment #1 from Kyle M Hall --- Created attachment 133300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133300=edit Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588. Test Plan: 1) Set MarkLostItemsAsReturned for return claims 2) Mark a checkout as claims returned 3) Verify the checkout is no longer on the patron record 4) Resolve the claim 5) Note the attempt "hangs" but refreshing the page shows it worked 6) Apply this patch, restart all the things! 7) Repeat steps 2-4 8) It works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
