[Koha-bugs] [Bug 30563] Add system preference to make the cash register field required when collecting a payment

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27546] Add option to search within results on the staff client

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #21 from Victor Grousset/tuxayo  ---
Retested, still good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23426] Empty AV field returned in Patron Info in addition to those requested

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23426

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #4 from Lucas Gass  ---
It looks like a pretty simple fix but unfortunately this patch no longer
cleanly applies to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Lucas Gass  ---
It looks like your unit tests no longer cleanly apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20384] Elasticsearch rebuild script improvements - options for indexing

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30563] Add system preference to make the cash register field required when collecting a payment

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563

Lucas Gass  changed:

   What|Removed |Added

 Attachment #133393|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 133698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133698=edit
Bug 30563: Add syspref to make the "cash register" field mandatory

Test plan:
1. Apply patch and run updatedatabase
2. Enable 'UseCashRegisters' syspref and create at least one cash
   register for your library
3. Verify that you have several authorized values in the 'PAYMENT_TYPE'
   category. One of them should be 'CASH'
4. Go to a patron accounting tab, create a manual invoice and go to the
   payment form. Select payment type 'CASH' and verify that you cannot
   submit the form if no cash register is selected.
   Select another payment type and verify that you can submit the form
   even if no cash register is selected
5. Set syspref 'RequireCashRegister' to 'always require a cash register'
6. Repeat step 4 but this time you should not be able to submit the form
   if no cash register is selected, no matter which payment type is
   selected.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30563] Add system preference to make the cash register field required when collecting a payment

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30563

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #133695|0   |1
is obsolete||

--- Comment #3 from Andrew Fuerste-Henry  ---
Created attachment 133697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133697=edit
Bug 30599: Add an 'Archive selected' button

This patch simply adds a new button on the suggestions interface to allow
for archiving multiple suggestions.

To test:
1 - Apply patch
2 - Create some purchase suggestions
3 - Select several suggestions
4 - Click 'Archive selected'
5 - Suggestions are archived
6 - You can view archived suggestions by selecting 'Suggestion
information'->'Include archived'

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Felicity Brown 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and kohastructure.sql

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600

--- Comment #2 from Fridolin Somers  ---
Second :

DBRev removes from ENUM branchtransfers.reason the value 'TransferCancellation'
added by Bug 12362

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and kohastructure.sql

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600

--- Comment #1 from Fridolin Somers  ---
We see that kohastructure.sql has 'Recall' and 'CancelRecall' in
branchtransfers.reason and branchtransfers.cancellation_reason :
https://git.koha-community.org/Koha-community/Koha/src/commit/74792b35a83a863fa5e68c37f0c0f552f0c21a7b/installer/data/mysql/kohastructure.sql#L1560

But DBRev only add in branchtransfers.reason :
https://git.koha-community.org/Koha-community/Koha/src/commit/74792b35a83a863fa5e68c37f0c0f552f0c21a7b/installer/data/mysql/db_revs/211200018.pl#L93

Which one is correct :/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||30600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600
[Bug 30600] Recalls sync problem between DBIx and kohastructure.sql
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and kohastructure.sql

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||19532


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30600] New: Recalls sync problem between DBIx and kohastructure.sql

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600

Bug ID: 30600
   Summary: Recalls sync problem between DBIx and
kohastructure.sql
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 133696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133696=edit
DBIx schema diff

Bug 19532 Recalls added several db changes.

Comparing a structure from v21.11.00 + updatedatabase.pl and a structure
generated from current master kohastructure.sql, after updating DBIx schema
(via misc/devel/update_dbix_class_files.pl not dbic) we see a difference in
Koha/Schema/Result/Branchtransfer.pm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #133694|0   |1
is obsolete||

--- Comment #2 from Andrew Fuerste-Henry  ---
Created attachment 133695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133695=edit
Bug 30599: Add an 'Archive selected' button

This patch simply adds a new button on the suggestions interface to allow
for archiving multiple suggestions.

To test:
1 - Apply patch
2 - Create some purchase suggestions
3 - Select several suggestions
4 - Click 'Archive selected'
5 - Suggestions are archived
6 - You can view archived suggestions by selecting 'Suggestion
information'->'Include archived'

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

--- Comment #1 from Nick Clemens  ---
Created attachment 133694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133694=edit
Bug 30599: Add an 'Archive selected' button

This patch simply adds a new button on the suggestions interface to allow
for archiving multiple suggestions.

To test:
1 - Apply patch
2 - Create some purchase suggestions
3 - Select several suggestions
4 - Click 'Archive selected'
5 - Suggestions are archived
6 - You can view archived suggestions by selecting 'Suggestion
information'->'Include archived'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] Allow archiving multiple suggestions

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30599] New: Allow archiving multiple suggestions

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30599

Bug ID: 30599
   Summary: Allow archiving multiple suggestions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The code on the staff client can accept multiple suggestions for archiving,
however, there is no button to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing randomly

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #133669|0   |1
is obsolete||

--- Comment #9 from Fridolin Somers  ---
Created attachment 133693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133693=edit
Bug 30596: Prevent api/v1/acquisitions_baskets.t and
api/v1/acquisitions_funds.t to fail randomly

because of updated_on

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30596] api/v1/acquisitions_baskets.t is failing randomly

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596

Fridolin Somers  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to debarments should be logged

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

Benjamin Daeuber  changed:

   What|Removed |Added

 CC||bdaeu...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253

--- Comment #13 from Fridolin Somers  ---
May I revert ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin Somers  ---
(In reply to Fridolin Somers from comment #11)
> Pushed to master for 22.05, thanks to everybody involved 濾

Sorry I forgot yesterday to update status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595

--- Comment #2 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30595] update_child_to_adult.t is failing randomly

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30595

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30531] Search.t needs update for Recalls

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531

--- Comment #4 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30531] Search.t needs update for Recalls

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30512] Staff interface search results template error

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512

--- Comment #5 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30512] Staff interface search results template error

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30446] Add a test for GetTagsLabels

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446

--- Comment #8 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30446] Add a test for GetTagsLabels

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30446

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253

--- Comment #11 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373

Fridolin Somers  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #49 from Fridolin Somers  ---
Pushed to master :
 Fix unimarc authorised values
 Fix xt/find-license-problems.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Fridolin Somers  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #167 from Fridolin Somers  ---
"Fix 2FA selenium tests" pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] New: Replacement cost is not copied from retail price when ordering from file

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Bug ID: 30598
   Summary: Replacement cost is not copied from retail price when
ordering from file
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

In acquisitions, when you order an individual title, and you enter the "vendor
price", it is copied in the retail price, the replacement cost, and the
budgeted cost. However, if you order from a file, when you enter the price, the
replacement price field stays empty.

To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record 
 --> Note that when you enter the "vendor price", it is copied in the
"replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays
empty

This means you have to enter the price twice for each item ordered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30525] Items batch modification broken

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.05.00|22.05.00,21.11.05
released in||
 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30532] guided_reports.pl has a problem

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.05.00|,21.11.05
released in||
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the next one

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775

--- Comment #3 from Owen Leonard  ---
> 3)Check the row of the serial with the EXPECTED status
> 4)Click 'Send notification'
> 5)Notice the status of the row : it is now CLAIMED

I don't know if I'm doing something wrong, but this step doesn't work for me.
The status of the issue remains EXPECTED.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
   Patch complexity|--- |Small patch

--- Comment #21 from Victor Grousset/tuxayo  ---
> 2) What do I need to do to make this work on ktd?

running `reset_all` or restarting ktd after applying the patches will make the
new files be copied in the right place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26635] Expand authorised values in REST API call

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net

--- Comment #10 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30584] Cannot add field mappings to Elasticsearch configuration

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing to include auto-renew

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597

--- Comment #1 from Andrew Fuerste-Henry  ---
Created attachment 133692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133692=edit
Bug 30597: Update RestrictionBlockRenewal description to include auto renew

To test:
- apply the patch, find the syspref, see the new wording

To confirm the behavior:
- set the syspref to Block
- give a patron an auto-renewing checkout and a restriction
- run automatic_renewal.pl, see item does not renew
- switch syspref to allow, repeat, see renewal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing to include auto-renew

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28998] Encrypt borrowers.secret

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Martin Renvoize  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #79 from Martin Renvoize  ---
Hmm, OK.. the selenium failures are now introduced by this bug..

Is there any way to mock the config (encrpytion_key) for a selenium test?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28747] Clarify wording on RestrictionBlockRenewing syspref

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||30597


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597
[Bug 30597] Update wording of RestrictionBlockRenewing to include auto-renew
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30597] New: Update wording of RestrictionBlockRenewing to include auto-renew

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597

Bug ID: 30597
   Summary: Update wording of RestrictionBlockRenewing to include
auto-renew
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 28747

In bug 28747 we changed the wording on this syspref to:
If a patron is restricted, (allow/block) renewing of items from the staff
interface.

In retrospect, we should mentioned auto-renewals:

If a patron is restricted, (allow/block) renewing of items from the staff
interface and via the automatic_renewals cronjob.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747
[Bug 28747] Clarify wording on RestrictionBlockRenewing syspref
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27382] [DOCS] [Omnibus] Spelling errors in the manual

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382
Bug 27382 depends on bug 28430, which changed state.

Bug 28430 Summary: [DOCS] Spelling error in the manual (tools): alreay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28430] [DOCS] Spelling error in the manual (tools): alreay

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430

Aude Charillon  changed:

   What|Removed |Added

   Keywords|Manual  |Manual-updated
 CC||aude.charillon@ptfs-europe.
   ||com
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Aude Charillon  ---
Manual updated
(https://gitlab.com/koha-community/koha-manual/-/merge_requests/555)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #74 from Martin Renvoize  ---
patrons_search.t selenium test is failing and I'm not entirely sure why :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11989] Holds Queue Scheduling

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11989

--- Comment #4 from George Williams (NEKLS)  ---
Good idea.  Would be great to see it implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #181 from The Minh Luong  ---
Created attachment 133691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133691=edit
Bug 12446: Fixing QA tool's tests

This patch fixes tests that fails by the QA test tool.
I removed the debug variable, since it is not used.
I also got a few spelling check errors when I ran the QA test tool. I corrected
them too.

To test:
1) Create an Adult AND Child category in Administration/Patron
categories
2) Create a child AND adult patron.
3) Go in your child patron's page.
4) Click on "Edit".
5) Notice that you can add a guarantor with "Add guarantor" button.
6) Go in your adult patron's page.
7) Click on "Edit".
8) Notice that there is no "Add guarantor" button. Therefore, you can't
add a guarantor for this patron.
9) Apply patch and run updatedatabase.pl
10) Go in Administration/Patron categories and edit one of them.
12) Notice that you can see the new "Can be guarantee" field.
13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult
category.
14) Repeat steps 6 to 7.
15) Notice that your adult patron can now add guarantors with the "Add
guarantor" button.
16) prove t/db_dependent/Patrons.t
=> All tests should still pass
17) Run the QA test tool. All tests should say OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #133574|0   |1
is obsolete||

--- Comment #6 from Andrew Fuerste-Henry  ---
Created attachment 133689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133689=edit
Bug 30579: Disentangle multi-hold and single bib forms

This patch simply groups the forms so that multi-hold and single
hold are each in their own section

While there is some duplication from this, it makes the sections easier to read
and allows for more variation in the two forms

To test:
1 - Place a single bib and multi bib hold in staff client
2 - Apply this patch
3 - Repeat and confirm nothing changes with this patch

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #133575|0   |1
is obsolete||

--- Comment #7 from Andrew Fuerste-Henry  ---
Created attachment 133690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133690=edit
Bug 30579: Group next available hold options, and disable when item is chosen

This patch rearranges options that only apply to next available holds
and disables them when an item is checked. This is intended to make it
more obvious which parts of the form apply to this selection

To test:
1 - Apply patches
2 - Confirm you can successfully place single or multiple items on hold
3 - Confirm that when placing a single hold the next available options are
grouped
4 - Confirm pickup location, specific item type, and number of holds all work
for next available
5 - Confirm item level holds save pickup location correctly

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30577] Item specific holds location can be missed when placing title level holds

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #133573|0   |1
is obsolete||

--- Comment #6 from Andrew Fuerste-Henry  ---
Created attachment 133688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133688=edit
Bug 30577: Fix a missing closing tag

This didn't affect table display, but when there was a biblioloo.warn
we were not closing the first  tag

Confirm multi-holds table loads correctly when one (or more) records cannot be
held

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30577] Item specific holds location can be missed when placing title level holds

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #133572|0   |1
is obsolete||

--- Comment #5 from Andrew Fuerste-Henry  ---
Created attachment 133687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133687=edit
Bug 30577: Move item specific pickup locations to the left

When placing holds, staff will set the pickup location at the top,
choose an item, then place the hold.
It is easy not to notice the item specific locations dropdown.

This patch moves it in line with the other selction areas on the request
screen.

To test:
 1 - Find a record on staff client, place hold
 2 - Select a patron to load the request screen
 3 - Note the location dropdown for next available hold
 4 - Note the item specific locations on the far right
 5 - Apply patch
 6 - Reload the page
 7 - Note the item specific location dropdowns are now moved to the left
 8 - Place the hold, verify it works with the dropdowns
 9 - Verify title levelholds still work as expected
10 - Verify multi-holds still work

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

--- Comment #1 from Andrew Fuerste-Henry  ---
We should split this functionality out into two sysprefs -- one about whether
or not one can type free text into authority-controlled fields and a second
about whether or not bibs link automatically on creation and import. Both of
those new sysprefs should have more accurate and descriptive names than
BiblioAddsAuthorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576

--- Comment #8 from Martin Renvoize  ---
Ho.. that last failure is also on master.. I'll fix it on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #133643|0   |1
is obsolete||

--- Comment #166 from Martin Renvoize  ---
Created attachment 133686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133686=edit
Bug 28786: Fix 2FA selenium tests

Looks like there was a bad rebase at some point.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30172] Background jobs failing due to race condition

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|22.05.00,21.11.05   |22.05.00,21.11.05,21.05.14
released in||

--- Comment #40 from Andrew Fuerste-Henry  ---
Pushed to 21.05.x for 21.05.14

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576

Martin Renvoize  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #7 from Martin Renvoize  ---
As discussed, there is still an issue should someone add a bad field into the
system preference.. but we decided that was out of scope for here.

I'm also still stuck with one last test failure.. I have no idea how this
patchset causes it.. hopefully it'll be something obvious for Jonathan to spot.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576

--- Comment #6 from Martin Renvoize  ---
Created attachment 133685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133685=edit
Bug 30576: (follow-up) Corrections to behaviour to reflect unit tests

The unit tests highlighted my original patch didn't cover the full
preference description.

We now replace the 'standard' option with the fields from the preference
and we also add those fields as options to the field selection in
advanced searches.

This patch also adjusts the tests to test for that and reflects the
expected changes to the number of options displayed in the select boxes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #133555|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 133684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133684=edit
Bug 30576: Use DefaultPatronSearchFields in patron search

This patch corrects the handling of the 'Standard' search field in
patron searches such that it accurately reflects the contents of the
DefaultPatronSearchFields system preference and falls back to a hard
coded list instead of always using the hard coded list.

To test:
1) Empty the contents of DefaultPatronSearchFields systempreference
2) Perform a patron search from the header search
3) Inspect the patrons API request and note that we search on the
   default fallback fields of firstname, surname, othernames,
   cardnumber and userid (and some extended attributes which are
   historically hard coded).
4) Navigate to the memebers-home by clicking the 'Patrons' button from
   the main page
5) Perform another search using the filters on the left with 'Standard'
   selected.
6) Note the same list of search fields used as above in the patrons API
   request.
7) Update the DefaultPatronSearchFields systempreference adding one or
   more borrower fields in a comma delimited list.
8) Repeat steps 2 -> 6 but this time upon inspecting the API request you
   should find that only the fields in your DefaultPatronSearchFields
   list are searched (along with the hard coded extended attributes
   list).
9) Signoff

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

--- Comment #48 from Owen Leonard  ---
Created attachment 133683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133683=edit
Bug 23352: (follow-up) Fix QA test failure

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

--- Comment #47 from Owen Leonard  ---
Created attachment 133682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133682=edit
Bug 23352: (follow-up) Fixes for QA review

Test plan:
1. Confirm that
installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl
has the exec flag

2. Create a subscription. Notice the 'Collection' dropdown defaults to
the 'None' option - same as Location

3. Save the subscription without changing the 'None' collection

4. Receive the serial and confirm the 'Collection' field is empty

5. Create a second subscription. Change the 'Collection' dropdown to
'Fiction', then save the subscription

6. Receive the serial and confirm the 'Collection' dropdown is set to
'Fiction'

7. Confirm that the 'Collection code' terminology in the template is replaced
with
'Collection'

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

--- Comment #46 from Owen Leonard  ---
Created attachment 133681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133681=edit
Bug 23352: Set default collection code when creating subscription

The default collection code set in the subscription will be applied if
item records are created when receiving the serial.

Test plan:
1. Apply 3 patches
2. Run updatedatabase.pl and restart services
3. Create a subscription:
- Tick the 'Create an item record when receiving this serial' radio
button
- Select values in the Location, Collection code and Item type dropdowns
- Save the subscription
4. Confirm the Location, and Collection code default values
you choose in #3 are displaying in the 'Information' tab of page that's
loaded
5. Receive the serial:
- Click 'Receive'
- Change the status dropdown from 'Expected' to 'Arrived'
- Confirm the 'Collection Code', 'Shelving location' and 'Koha item
type' dropdowns are pre-filled with the values you defined in #3
6. Run unit test t/db_dependent/Serials.t

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Samu Heiskanen 

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

--- Comment #45 from Owen Leonard  ---
Created attachment 133680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133680=edit
Bug 23352: Updated schema file

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Samu Heiskanen 

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Owen Leonard  changed:

   What|Removed |Added

 Attachment #131435|0   |1
is obsolete||
 Attachment #131437|0   |1
is obsolete||
 Attachment #131438|0   |1
is obsolete||
 Attachment #131439|0   |1
is obsolete||
 Attachment #132920|0   |1
is obsolete||

--- Comment #44 from Owen Leonard  ---
Created attachment 133679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133679=edit
Bug 23352: Database changes

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Samu Heiskanen 

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30412] Shelving location column in holdings table

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30412] Shelving location column in holdings table

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|22.05.00,21.11.03   |22.05.00,21.11.03,21.05.14
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #9 from Andrew Fuerste-Henry  ---
Pushed to 21.05.x for 21.05.14

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #284 from The Minh Luong  ---
Created attachment 133678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133678=edit
Bug 17015: Check out with the useDaysMode preference

When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.

To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30520] Command line stage and import broken since 21.11.

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |andreas.jons...@kreablo.se
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576

--- Comment #4 from Jonathan Druart  ---
Behaviour on 21.11.x:

1. DefaultPatronSearchFields has the default value
(surname,firstname,othernames,cardnumber,userid)
=> standard will search "standard" (retrieved from the pref in the pm)

2. DefaultPatronSearchFields=surname,initials,borrowernotes
=> standard will search "standard" (retrieved from the pref in the pm)
=> 2 new options are added to the dropdown, "Initials" and "Circulation note"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing validation

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing validation

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #133551|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 133677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133677=edit
Bug 30224: Show correct important field in cataloguing validation

This patch fxes the cataloguing validation messages to show the correct tag,
when the whole field is important (not just a subfield).

Note: Look at Bug 30159 to fix the formatting of the validation popup.

1. Go to Administration -> MARC bibliographic frameworks
2. Click Actions next to a framework, view MARC structure
3. Edit multiple tags (at least 2) and check the Important checkbox.
4. Go to cataloguing and create a new record using the framework you just
edited
5. Don't fill any of the important fields. Click Save to force the validation
for the important tags
6. Notice that the error message shows that an important field isn't filled,
but the tag number shown is repeated for each message. The 'Go to field' link
goes to the right tag, but the tag number shown is incorrect.
7. Apply patch and refresh page
8. Click Save to force validation again.
9. Confirm the correct tag number is now showing for each error message.

Sponsored-by: Education Services Australia SCIS
Signed-off-by: Petro Vashchuk 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #22 from Jonathan Druart  ---
(In reply to Nick Clemens from comment #21)
> (In reply to Jonathan Druart from comment #20)
> > Can we move this one forward please?
> 
> Test plan?

No test plan, the diff it too big. What we need here are QA eyes :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #21 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #20)
> Can we move this one forward please?

Test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

Owen Leonard  changed:

   What|Removed |Added

 Attachment #133358|0   |1
is obsolete||

--- Comment #6 from Owen Leonard  ---
Created attachment 133676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133676=edit
Bug 30438: Add select all/clear all buttons to invoices.tt

To test:
1. Apply patch
2. Have a bunch of invoices, some open and some closed.
3. Go to Home > Acquisitions > Invoices and do a search that will
   return you many of those invoices, some open and some closed.
4. Notice the 'Select all' and 'Clear all' buttons.
5. Try clicking 'Select all' on the Open invoices tab. All Open invoices
   should become checked.
6. Try clicking 'Clear all' on the Open invoices tab. All open invoices
   should become unchecked.
7. Try 5 - 6 again but on the Closed invoices tab.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||30224


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224
[Bug 30224] Wrong important field shown in cataloguing validation
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing validation

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Depends on||28694


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694
[Bug 28694] Check alert in cataloguing should be a static message
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30589] Allow importing circulation conditions as CSV or spreadsheet

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30589

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry  ---
I'd be uncomfortable with this feature moving forward until we've first adding
logging for changes to circ rules (Bug 16544). The idea of someone importing a
malformed csv and wiping out their circ rules is unpleasant.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30482] Potential for bad string concatenation in cataloging validation error message

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #133506|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  ---
Created attachment 133675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133675=edit
Bug 30482: Potential for bad string concatenation in cataloging validation
error message

In validating the basic MARC editor form before submission, we run
AreFieldsNotOk() twice (once with the parameter "false") and concatenate
the result for output. This creates the potential for the error string
to be appended with "0" if AreFieldsNotOk() returns false.

This patch improves the logic around building the error string.

To test, apply the patch and make sure one of your MARC frameworks
contains at least one mandatory field and at least one important field.

- Edit or create a MARC record in the basic MARC editor.
- Submit the form in various states of completion:
  - If a mandatory and an important field are empty, you should see two
error messages at the top. "The following mandatory subfields aren't
filled" and "The following important subfields aren’t filled."
  - If a mandatory OR an important field is empty, you should see a
single message.
- If it's the important field which is empty, a confirmation will
  ask if you want to save the record anyway. Test that both answers
  to this confirmation work correctly.
  - If no mandatory or important fields are empty the form should
submit.

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30482] Potential for bad string concatenation in cataloging validation error message

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326

Owen Leonard  changed:

   What|Removed |Added

 Attachment #133511|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 133674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133674=edit
Bug 30326: (follow-up) Add output parameter and handle bad biblionumbers

When the script is run without the --html parameter, the output will be
simply text. When the script is run with the --html parameter, the
output will display in an HTML table.

Additional test plan:

5. Test running script with and without --html parameter and confirm
output is correct.

6. Test running script with a --bibnum that does not exist and confirm
the output acknowledges this.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30122] Display note fields in authority result list

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30122

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #9 from Jonathan Druart  ---
We are displaying the notes at the OPAC, on the detail page of the authority.

I think I am identifying 2 different needs here, one is to display the notes on
the result page, the other one is to make configurable the notes we display.

If we add a syspref to list the subfields we want to display, should it drive
the behaviour for the OPAC as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #20 from Jonathan Druart  ---
Can we move this one forward please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29155] Upgrade jquery version to 3.6.0

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155

Jonathan Druart  changed:

   What|Removed |Added

Summary|Upgrade jquery version  |Upgrade jquery version to
   ||3.6.0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29155] Upgrade jquery version

2022-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155

--- Comment #25 from Jonathan Druart  ---
I haven't caught anything obvious, we should push this ASAP to let us a bit of
time to find possible regressions before the release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >