[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 David Cook changed: What|Removed |Added Attachment #134200|0 |1 is obsolete|| --- Comment #3 from David Cook --- Created attachment 134201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134201=edit Bug 30636: Show notforloan availability correctly in ILS-DI This patch adds the Koha::Item->is_notforloan() method which checks the item status of "notforloan" and it checks the effective item type to see if it's marked as "notforloan". This change brings ILS-DI in line with the catalogue which displays "Not for loan" for both those scenarios. 0. Don't apply patch yet 1. Enable ILS-DI system preference http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search=ILS-DI 2. Change Item types to "Not for Loan" for Books http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form=BK 3. Note that book is listed as "Not for loan" in catalogue http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29=scs_1651115075364 4. Note that book is listed as "available" via ILS-DI http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability=29_type=bib 5. Apply patch and restart starman (ie koha-plack --restart kohadev) 6. Note that book is listed as "not available" and "Not for loan" via ILS-DI http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability=29_type=bib -- 7. prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 --- Comment #2 from David Cook --- Created attachment 134200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134200=edit Bug 30636: Show notforloan availability correctly in ILS-DI This patch adds the Koha::Item->is_notforloan() method which checks the item status of "notforloan" and it checks the effective item type to see if it's marked as "notforloan". This change brings ILS-DI in line with the catalogue which displays "Not for loan" for both those scenarios. 0. Don't apply patch yet 1. Enable ILS-DI system preference http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search=ILS-DI 2. Change Item types to "Not for Loan" for Books http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form=BK 3. Note that book is listed as "Not for loan" in catalogue http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29=scs_1651115075364 4. Note that book is listed as "available" via ILS-DI http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability=29_type=bib 5. Apply patch and restart starman (ie koha-plack --restart kohadev) 6. Note that book is listed as "not available" and "Not for loan" via ILS-DI http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability=29_type=bib -- 7. prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 --- Comment #1 from David Cook --- Unfortunately, detail.tt uses item.notforloan_per_itemtype which is a column alias from a custom SQL query in C4/Items.pm. In theory, we could just add a Koha::Item->notforloan_per_itemtype method, but then it seems like Koha::Item->notforloan is often used as a boolean to determine if an item is not for loan... and sometimes Koha::Item->notforloan is used for its particular "Not for loan" description. It seems to me that we might be better off creating a new method like Koha::Item->is_not_for_loan() which returns a boolean response based on the "notforloan" value and whether it's "Not for loan" based on its item type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #10 from Alex Buckley --- Created attachment 134199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134199=edit Bug 30444: (follow-up) Ensure Self checkout by cardnumber and username/password works Test plan: 1. On a Koha setup to do Shibboleth set the following sysprefs: - OPACShibOnly = "Don't allow" - AutoSelfCheckAllowed = Allow - AutoSelfCheckID and AutoSelfCheckPass = The username and password of a patron with 'self_checkout_module' sub-permission enabled - SelfCheckoutByLogin = 'cardnumber' 2. Visit the self checkout page. Confirm a 'cardnumber' input page is loaded 3. Enter a cardnumber and confirm the self checkout page loads 4. Change SelfCheckoutbyLogin = 'username and password' 5. Repeat step 2 and confirm a username and password input page loads. 6. Enter a username and password and confirm the self checkout page loads 7. Change SelfCheckoutByLogin = 'shibboleth' 8. Repeat step 2 and confirm you're logged straight into the self checkout Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Alex Buckley changed: What|Removed |Added Attachment #134007|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #7 from Fridolin Somers --- *** Bug 22204 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22204] Leading spaces in barcode should not allowed in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204 Fridolin Somers changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #15 from Fridolin Somers --- *** This bug has been marked as a duplicate of bug 30409 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] New: ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 Bug ID: 30636 Summary: ILS-DI shows incorrect availability when Notforloan by Itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org If you've marked an item type as "Not for loan" in Koha, it'll show a "Status" of "Not for loan" in the catalogue, but the ILS-DI GetAvailability service will advertise it as still available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30167] Return soonest renewal date when CanBookBeRenewed returns %too_soon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167 --- Comment #8 from David Nind --- Testing notes (koha-testing-docker): - Tested on 04/28/2022 (American date format) with . 'no renewal before' set to 3 . 'loan period' set to 5 - Checked out on date is 04/28/2022 00:09 - For the patron from the checkouts: No renewal before 04/30/2022 - When trying to renew, the message is: "Cannot renew: Programming Perl / ( 311418 ) cannot be renewed before 04/30/2022. " - Date is calculated correctly including the current day (3 days - 28th, 29th + 30th) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30167] Return soonest renewal date when CanBookBeRenewed returns %too_soon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167 David Nind changed: What|Removed |Added Attachment #134083|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 134198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134198=edit Bug 30167: Use returned renewal date rather than fetching This patch updates the three scripts that fetched the soonest renewal date to use the return from CanBookBeRenewed To test: 1 - Set a circulation rule with a 'no renewal before' set to 3, loan length set to 5 2 - Check out an item to a patron that uses this rule 3 - Verify the checkouts for the patron show the correct 'No renewal before' date 4 - Sign in to the patron's opac account 5 - Verify the item shows it cannot be renewed, and shows the correct date 6 - Go to Circulation->Renew 7 - Attempt to renew using barcode 8 - Confirm error shows the soonest renewal date Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30167] Return soonest renewal date when CanBookBeRenewed returns %too_soon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167 David Nind changed: What|Removed |Added Attachment #134082|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 134197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134197=edit Bug 30167: Return soonest renewal date when renewal is to soon This patch adds an 'info' return param to CanBookBeRenewed and passes the soonest renewal date when returning too_soon errors To test: 1 - prove -v t/db_dependent/Circulation.t Fix whitespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30167] Return soonest renewal date when CanBookBeRenewed returns %too_soon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 David Nind changed: What|Removed |Added Text to go in the||This fixes SIP2 so that it release notes||correctly determines if ||issues should be blocked ||for patrons when the ||NoIssuesChargeGuarantees ||and ||NoIssuesChargeGuarantorsWit ||hGuarantees system ||preferences are set. ||Currently, it only checks ||the noissuescharge system ||preference as the limit for ||charges, and not the other ||'No Issues charge' system ||preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #119 from David Cook --- (In reply to Tomás Cohen Arazi from comment #118) > I would like to see some higher-level method, like Koha::Checkout->renew and > start removing old code but we can do that in a follow-up +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 David Nind changed: What|Removed |Added Status|Signed Off |Failed QA CC||da...@davidnind.com --- Comment #3 from David Nind --- After signing off, I ran the tests and they failed: prove t/db_dependent/SIP/Patron.t t/db_dependent/SIP/Patron.t .. 8/10 # Failed test 'Guarantee only fines correctly counted' # at t/db_dependent/SIP/Patron.t line 318. # got: '11.11' # expected: '0.11' # Failed test 'Guarantee not blocked by guarantor fines' # at t/db_dependent/SIP/Patron.t line 319. # Looks like you failed 2 tests of 4. t/db_dependent/SIP/Patron.t .. 9/10 # Failed test 'NoIssuesChargeGuarantees tests' # at t/db_dependent/SIP/Patron.t line 322. t/db_dependent/SIP/Patron.t .. 10/10 # Looks like you failed 1 test of 10. t/db_dependent/SIP/Patron.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/10 subtests Test Summary Report --- t/db_dependent/SIP/Patron.t (Wstat: 256 Tests: 10 Failed: 1) Failed test: 9 Non-zero exit status: 1 Files=1, Tests=10, 9 wallclock secs ( 0.04 usr 0.01 sys + 7.56 cusr 1.12 csys = 8.73 CPU) Result: FAIL Also, for steps 16-18 of the test plan, I think step 16 needs changing to "16 - Set NoIssuesChargeGuarantorsWithGuarantees to 10", rather than 11. - If 11 is used, the patrons and the child are not blocked. - The wording for the system preference is "Prevent a patron from checking out if the patron has guarantors and those guarantor's guarantees owing in total more than X USD in fines." - The key part is "MORE THAN X USD". In the test, the total is 11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 David Nind changed: What|Removed |Added Attachment #130449|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 134196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134196=edit Bug 29755: Check each NoIssuesCharge separately This patch updates SIP patron code to use account methods to calculate balances over the patronflags returns. It also checks if patron should be blocked for each 'No Issues charge' preference Tests are added for NoIssuesChargeGuarantees To test: 1 - Set noissuescharge preference to 5 2 - Add a $10 charge to a patron 3 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 4 - Note the 64 message starts with Y's that mean patron is blocked 5 - Set noissuescharge to 11 6 - Repeat 3, patron is no longer blocked 7 - Set NoIssuesChargeGuarantees to 8 8 - Repeat 3, patron is blocked 9 - Pay $3 on patron so they owe 7 10 - Repeat 3, patron is not blocked 11 - Add a child account with patron as guarantor 12 - Repeat 3, patron is not blocked 13 - Add a $4 charge to child 14 - Repeat 3, patron is blocked 15 - Repeat 3, but with child barcode, child is not blocked 16 - Set NoIssuesChargeGuarantorsWithGuarantees to 11 17 - Repeat 3, patron is blocked 18 - Repeat 3 with child barcode, child is blocked Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #41 from David Cook --- (In reply to Fridolin Somers from comment #40) > That code looks very strange to me. > Naming a TT filter 'Filter'. > > I would prefer to see syntax : [% var | $NoDoubleEncode %] > Like TT plugin Price. > > Class is using : > Base qw( Template::Plugin::Filter ) > But does not implement a 'filter' method. I think a good alternative would be what I suggest at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3#c7 as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #15 from Aleisha Amohia --- Created attachment 134195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134195=edit Bug 30358: (follow-up) Consider field has multiple subfields of same key To test: 1) Click the clone subfield button to make multiple subfields with the same key, i.e. 500$a$a$a 2) Save the record and confirm that the fields contain the correct data after whitespaces are stripped. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 --- Comment #23 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #240 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29092] Table settings for account_fines table is missing Updated on column and hides the wrong things
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29092] Table settings for account_fines table is missing Updated on column and hides the wrong things
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #239 from Fridolin Somers --- I've added to DBRev a print when preference was enabled : "NumSavedReports value '20' moved to table settings" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #238 from Fridolin Somers --- (In reply to Fridolin Somers from comment #237) > Ah we should remove "actions" from default sort order. > My 2c And also "selection". Using them does not break the table, ouf ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #237 from Fridolin Somers --- Ah we should remove "actions" from default sort order. My 2c -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #236 from Fridolin Somers --- Great enhancement. I push it asap to avoid more rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #235 from Fridolin Somers --- Created attachment 134194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134194=edit Bug 29648: (follow-up) Add missing raw filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | --- Comment #118 from Tomás Cohen Arazi --- I'll finish my review tomorrow. Overall, this is what I wanted to see on bug 23838, so I'm happy for this, Martin. Great! It is lacking (at least) tests for the new Koha::Checkouts::Renewal->store method. I can add it, but got late today to do it. I would like to see some higher-level method, like Koha::Checkout->renew and start removing old code but we can do that in a follow-up, this is solid as it stands. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #117 from Tomás Cohen Arazi --- Created attachment 134193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134193=edit Bug 30275: (QA follow-up) Rename columns to match API This patch performs the following column renames: * id => renewal_id * issue_id => checkout_id The idea is that no translation is needed for the API, and also, being a new table, we can educate the users into the 'to be' terminology we are leaning towards, instead of having them learn one naming to create reports and then need to translate them once we normalize things in a future. That said, this is simple to review. Apply this patch and repeat the test plan. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #116 from Tomás Cohen Arazi --- Created attachment 134192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134192=edit Bug 30275: Add renewals relation to Koha::Old::Checkout Add the new 'renewals' relation to Koha::Old::Checkout to return a list of Koha::Checkouts::Renewal objects. We also add the same relation to the OldIssue schema inline. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #115 from Tomás Cohen Arazi --- Created attachment 134191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134191=edit Bug 30275: (follow-up) Rebase fixes Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #114 from Tomás Cohen Arazi --- Created attachment 134190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134190=edit Bug 30275: Add basic unit test for fetching renewals Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #113 from Tomás Cohen Arazi --- Created attachment 134189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134189=edit Bug 30275: Fix checkouts.t unit test We no longer require a mocked userenv for these tests to pass, we're setting the userenv in api auth now. The mock just serves to break tests for the renew method now that AddRenewal required a correctly set userenv for 'number'. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #112 from Tomás Cohen Arazi --- Created attachment 134188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134188=edit Bug 30275: Add alias to create renewal in api routes Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
--- Comment #111 from Tomás Cohen Arazi ---
Created attachment 134187
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134187=edit
Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`
Signed-off-by: Owen Leonard
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #110 from Tomás Cohen Arazi --- Created attachment 134186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134186=edit Bug 30275: Add renewals relation to Koha::Checkout Add the new 'renewals' relation to Koha::Checkout to return a list of Koha::Checkouts::Renewal objects. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #109 from Tomás Cohen Arazi --- Created attachment 134185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134185=edit Bug 30275: Add 'renewals' relation to Issue Schema Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #108 from Tomás Cohen Arazi --- Created attachment 134184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134184=edit Bug 30275: renewals_count DBIC Update Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #107 from Tomás Cohen Arazi --- Created attachment 134183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134183=edit Bug 30275: Rename issues.renewals to issues.renewals_count Rename the issues.renewals field to renewals_count to prevent a method name collision with the new relation accessor introduced by this patchset. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #106 from Tomás Cohen Arazi --- Created attachment 134182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134182=edit Bug 30275: Add Koha::Objects for Renewals Add Koha::Checkouts::Renewals|Renewal classes Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #105 from Tomás Cohen Arazi --- Created attachment 134181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134181=edit Bug 30275: DBIC Schema Additions Add checkout and old_checkout relations to CheckoutRenewal schema and mark 'seen' as a boolean. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #104 from Tomás Cohen Arazi --- Created attachment 134180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134180=edit Bug 30275: Record renewals Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #103 from Tomás Cohen Arazi --- Created attachment 134179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134179=edit Bug 30275: DBIC Schema Changes Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #102 from Tomás Cohen Arazi --- Created attachment 134178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134178=edit Bug 30275: Generated kohastructure.sql This kohastructure update was generated using `koha-dump --schema-only` in koha-testing-docker once the atomicupdate had been run against the previous atomicupdate patch. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #101 from Tomás Cohen Arazi --- Created attachment 134177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134177=edit Bug 30275: Add checkout_renewals table This patch adds the new checkout_renewals table using an atomicupdate Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133983|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133982|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133981|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133980|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133979|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133978|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133977|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133976|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133975|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30629] in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- Maybe keep the span in PROCESS and remove them in creation. I've tryed but could not use filters on a PROCESS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133974|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133973|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133972|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133971|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133970|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133969|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #133984|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 Fridolin Somers changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #57 from Fridolin Somers --- Follow-ups pushed to master (commit message fixed) : 286a800704 Bug 30373: (follow-up) Add BNF z3950 server 880103371b Bug 30373: (follow-up) Enable 'qualif' authorised_value 5edafaff11 Bug 30373: (follow-up) Optional SUGGEST auth values 20ae18e5ee Bug 30373: (follow-up) UNIMARC relator codes auth values d4fa096001 Bug 30373: (follow-up) Language codes auth values 4bdaaed17b Bug 30373: (follow-up) Country codes auth values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #40 from Fridolin Somers --- That code looks very strange to me. Naming a TT filter 'Filter'. I would prefer to see syntax : [% var | $NoDoubleEncode %] Like TT plugin Price. Class is using : Base qw( Template::Plugin::Filter ) But does not implement a 'filter' method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30631] Show list of existing printer profiles when creating a new patron card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30631 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30629] in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Owen Leonard changed: What|Removed |Added Blocks||30629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 [Bug 30629] in title of patron card creator template needs to be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30629] in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Owen Leonard changed: What|Removed |Added Depends on||29602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 [Bug 29602] We must be nicer with translators -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30635] New: Add API route to create/update borrower_relationships, guarantors/guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30635 Bug ID: 30635 Summary: Add API route to create/update borrower_relationships, guarantors/guarantees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com CC: tomasco...@gmail.com We should have a way to deal with guarantors and guarantees via the API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #134175|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 134176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134176=edit Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #2 from Lucas Gass --- Created attachment 134175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134175=edit Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Martin Renvoize changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- Hmm, wasn't there actually a reason cataloguers needed to be able to change library? I have a feeling this was a feature rather than a bug as I've asked this question before.. ccing people to help dredge the hive mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 --- Comment #9 from Katrin Fischer --- Could you provide a test plan for this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 Michael Hafen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 Michael Hafen changed: What|Removed |Added Attachment #124786|0 |1 is obsolete|| --- Comment #5 from Michael Hafen --- Created attachment 134174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134174=edit Bug 28642: Expand IndependentBranches to hide others items and libraries Rebased on 2022-04-27 Adds a system preference: IndependentBranchesHideOtherBranchesItems. When on: All library select's will be limited to just the users library. Item lists in search results, title details, item details, holds, and exports will only show items at the users library. Test Plan: Apply patch and run koha-upgrade-schema or manually create IndependentBranchesHideOtherBranchesItems system preference. Login with an account that is not Super Librarian. Set the IndependentBranchesHideOtherBranchesItems system preference to yes. On the Item Search page observe that only your library shows in the home and current library fields. On the Advanced Search page observe that only your library shows in the location -> individual libraries field. Search the catalog for a title with an item at your library and also at another library. Observe that you only see your library listed in the facets panel (Refine your search -> Home Libraries section) Observe that you only see the item at your library in the search results, title details, MARC details, Items, Checkout history, and Edit Items pages. On the title details page Save the title as a text format, for example MARCXML, and observe that only item(s) at your library are in the export. On the Place hold page, search for a patron and observe that only patrons at your library are found. After selecting a patron observe that only items at your library are displaed. In the Circulation -> Overdues page observe that you only see items at your library. In the Check out quick search search for patrons. Observe that only patrons at your school are found unless you search by cardnumber. On the Patrons page observe that only your library shows in the library field of the search form. In the Search Patrons tab of the quick search click the '+' to open the other fields. Observe that only your library shows in the Library field. On the Modify Patron page (edit patron) observe that only your library shows in the library field in the library management section. In Serials start a new subscription and observe that only your library shows in the library field. In Serials -> Check expiration observe that only your library show in the library field. In Reports observe that only your library shows in the following reports: Acquis itions statistics, Patrons statistics, Catalog statistics, Circulation statistics, Serials statistics, Cash register statistics, Holds statistics, Patrons with the most checkouts, Most-circulated items, Items with no checkouts, Items lost, Catalog by item type, Average loan time. In Suggestions observe that only your library shows in the library field on the Suggestion management and New purchase suggestion pages. In Tools -> Patron Lists when adding patrons to a list observe that only patrons at your library are found by name. In Patron Clubs observe that the library field only shows your library in the Club Template and Club edit pages. In Comments observe that only comments at your library are shown. In Import Patrons observe that the library field in the defaults section only shows your library. In Batch patron modification observe that your library is the only library in the library field. In Batch item modification observe that your library is the only library in the Home and Current library fields. In Export data observe that only your library shows in the 'With items owned by the following libraries' field and it is selected. In Inventory observe that only your library shows in the library field. In News observe that only your library shows in the library field in the Filter on the home page and the Edit entry page. Open the Opac and log in. On the Advanced search page observe that your library is the only library in the Location field. Search for a title with items at multiple libraries. Observe that only your library shows in the libraries facets (refine your search). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through stage MARC record import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #83 from Martin Renvoize ---
Scratch that.. I forgot to test an action and now found a bug.
If you select to 'Ignore' then change your mind and select a match again.. the
API request fails with:
[
{
"message": "Expected application/json - got
application/x-www-form-urlencoded; charset=UTF-8.",
"path": "/body"
}
]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through stage MARC record import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #82 from Martin Renvoize --- All appears to be working well, QA scripts are happy too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen changed: What|Removed |Added Status|BLOCKED |Needs Signoff --- Comment #4 from Michael Hafen --- Bug 28657 has been rebased. Test plan: 1. Turn on SearchMyLibraryFirst system preference. 2. Make sure your computers ip address is covered by a branch's branchip. 3. Go to opac. 4. Observe that the branch isn't set. 5. Apply patch. Restart things if necessary 6. Reload opac. 7. Observe that the branch is set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Michael Hafen changed: What|Removed |Added Attachment #134126|0 |1 is obsolete|| --- Comment #4 from Michael Hafen --- Created attachment 134173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134173=edit Bug 28657: expand branches.branchip to allow for multiple ip ranges. Rebased on Current (2022-04-27) master change branches.branchip to a mediumtext, and remove '*' from existing branchip settings. Change C4/Auth.pm from a regexp to using in_iprange() to check client address against branchip. (in_iprange() doesn't work with '*' in branchip.) Change in_iprange() to default to false (which is what the POD says it should do). Also, have it trim '*' in case someone adds some back later. Change note in admin/branches.tt under branchip field to reflect changes to branchip handling. Test plan: 1. Turn on AutoLocation system preference 2. Change a branches branchip to multiple ip ranges seperated by a space, making sure one of the ranges includes your computers address. 3. Log out and try logging in. The location check will fail. 4. Apply patch. Restart plack if necessary. 5. Try logging in again. The location check will succeed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang changed: What|Removed |Added Attachment #133608|0 |1 is obsolete|| --- Comment #3 from Shi Yao Wang --- Created attachment 134172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134172=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30634] New: Allow to define primary and secondary sorting criteria for item table in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30634 Bug ID: 30634 Summary: Allow to define primary and secondary sorting criteria for item table in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 30633 It would be great if we could sort by not only one column, but 2 columns in some cases. A good example would be the items table in staff and OPAC. Something like homebranch, itemtype or homebranch, itemcallnumber would be nice, especially for libraries that use different callnumber schemes at different branches. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Katrin Fischer changed: What|Removed |Added Blocks||30634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30634 [Bug 30634] Allow to define primary and secondary sorting criteria for item table in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer changed: What|Removed |Added Blocks||30633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30633] New: Move OPACHoldingsDefaultSortField to table settings configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Bug ID: 30633 Summary: Move OPACHoldingsDefaultSortField to table settings configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 29648 Now that the sorting of a table can be defined in administration > table settings, we should move OPACHoldingsDefaultSortField there and remove the pref. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #234 from Katrin Fischer --- Created attachment 134171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134171=edit Bug 29648: (QA follow-up) Remove NumSavedReports from .pref file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer changed: What|Removed |Added Attachment #134123|0 |1 is obsolete|| --- Comment #233 from Katrin Fischer --- Created attachment 134170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134170=edit Bug 29648: (QA follow-up) Minor POD fix This just adds a top level set of POD headings to make the QA script happy Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer changed: What|Removed |Added Attachment #134122|0 |1 is obsolete|| --- Comment #232 from Katrin Fischer --- Created attachment 134169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134169=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
