[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 --- Comment #11 from Aleisha Amohia --- Created attachment 134345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134345=edit Bug 30326: (follow-up) Tidy up output and use staffClientBaseURL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30600] Recalls sync problem between DBIx and kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30600 Aleisha Amohia changed: What|Removed |Added Attachment #134008|0 |1 is obsolete|| --- Comment #6 from Aleisha Amohia --- Created attachment 134344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134344=edit Bug 30600: Fix recall reasons for branch transfers When a recall triggers a branch transfer, the reason for the transfer is 'Recall'. When a transfer is cancelled that was triggered by a recall, depending on where it is cancelled, will use the 'Manual' or 'CancelRecall' cancellation reasons. This patch ensures branchtransfers.cancellation_reason adds 'CancelRecall', and branchtransfers.reason adds 'Recall' as options. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #80 from Nick Clemens --- Created attachment 134343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134343=edit Bug 29346: (follow-up) Build holds queue when AlterPriority or RevertWaitingStatus is called To test: 1 - Place 3 holds on a bib with a single item 2 - Confirm bib shows in holds queue 3 - Check in item and cnofirm hold 4 - Bib is no longer in queue 5 - Revert the waiting status 6 - The hold is in the queue again 7 - Move top hold to bottom 8 - Confirm queue selects hold for new top priorty patron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #79 from Nick Clemens --- Created attachment 134342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134342=edit Bug 29346: Use fully qualified names for C4:Circulation routines in C4::HoldsQueue I suppose this is similar to circular dependency on other patch HoldsQueue uses Circulation uses BatchUpdateBiblioHoldsQueueuse HoldsQueue Without this the background job builds the queue, but reports failure: Holds queue for biblio The Jacobite clans of the Great Glen, 1650-1784 /. An error occurred (Undefined subroutine ::HoldsQueue::GetTransfers called at /kohadevbox/koha/C4/HoldsQueue.pm line 351. ) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #78 from Nick Clemens --- Created attachment 134341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134341=edit Bug 29346: Remove unused circular dependency on C4::Search Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #77 from Nick Clemens --- Created attachment 134340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134340=edit Bug 29346: Add better reporting Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #76 from Nick Clemens --- Created attachment 134339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134339=edit Bug 29346: (follow-up) Fix typo 'availabe' Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #75 from Nick Clemens --- Created attachment 134338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134338=edit Bug 29346: (QA follow-up) Rebuild queue when adjusting priorities of holds Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #74 from Nick Clemens --- Created attachment 134337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134337=edit Bug 29346: Add more fine-grained control of holds queue updates This patch deals with the fact that high-level circualtion methods like `AddIssue`, `AddReturn` and `ModDateLastSeen` all eventually call lower-level methods like ModBiblio, Koha::Item->store of UpdateTotalIssues which are expected to trigger holds queue updates (for the object CRUD operations use cases). As the circulation methods need to trigger holds queue update as well, duplicate updates were being requested which is suboptimal, of course. In order to prevent this, and because circulation methdos could trigger holds queue updates several times, actually, I added a new parameter *skip_holds_queue* to the low-level methods, so when they are called from circulation, the trigger is skipped and we have greater control on when and how holds queue updates are scheduled. This patch introduces the `skip_holds_queue` parameter to the following methods: * C4::Biblio::ModBiblio * C4::Biblio::UpdateTotalIssues * Koha::Item->store Calls to those methods from the following methods will include the new parameter, and thus duplicated holds queue updates avoided: * C4::Circulation::AddIssue * C4::Circulation::AddReturn * C4::Items::ModDateLastSeen Tests are added, to verify that the (mocked) BatchUpdateBiblioHoldsQueue task is only scheduled once when they are called. To test: 1. Apply up to the previous patch 2. Run: $ kshell k$ prove t/db_dependent/Biblio.t \ t/db_dependent/Biblio_holdsqueue.t \ t/db_dependent/Circulation_holdsqueue.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #73 from Nick Clemens --- Created attachment 134336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134336=edit Bug 29346: Avoid duplicate actions tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #72 from Nick Clemens --- Created attachment 134335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134335=edit Bug 29346: Highlight double enqueue This patch highlights a possible issue with the triggers.. though it may not actually matter in reality. I appear to already see test failures before this patch with a double enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot what was causing that but whilst digging I did find another case where it could happen as highlighted here... Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #71 from Nick Clemens --- Created attachment 134334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134334=edit Bug 29346: (follow-up) Fix typo We set biblio_ids in enqueue then referred to biblio_id in process ;) Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #70 from Nick Clemens --- Created attachment 134333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134333=edit Bug 29346: Item action trigger This patch makes the following actions trigger a holds queue rebuild for the related biblio: - Adding an item - Updating an item - Deleting an item To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! Background job scheduled 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #69 from Nick Clemens --- Created attachment 134332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134332=edit Bug 29346: Biblio actions triggers This patch adds the trigger for the holds queue update on teh following methods: - C4::Biblio::DelBiblio - C4::Biblio::ModBiblio The ModBiblio use case could be improved by checking if itemtype is one of the updated attributes... but it felt there was no way to do it without some overhead. So I leave it as-is. It also mocks the ->enqueue method in the tests that call DelBiblio and ModBiblio to avoid breakages [1] Tests are added to check the trigger is called. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Biblio.t => SUCCESS: Tests pass! It means the trigger is triggered :-D 3. Sign off :-D [1] This breakages could be avoided if we solve Koha/BackgrounJob.pm:101 FIXME. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #68 from Nick Clemens --- Created attachment 134331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134331=edit Bug 29346: Circulation actions triggers This patch introduces triggers for real-time updating the holds queue at check out and check in. The following high-level methods are involved: - C4::Circulation::AddIssue - C4::Circulation::AddReturn To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation_holdsqueue.t => SUCCESS: Tests pass! Triggers are triggered 3. Sign off :-D Note: I put the tests on a separate file because the other one was too big already. Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #67 from Nick Clemens --- Created attachment 134330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134330=edit Bug 29346: Hold actions triggers This patch makes several holds related actions schedule the background job for real-time update of the holds queue. This actions are: - place (C4::Reserves::AddReserve) - fill (Koha::Hold->fill) - cancel (Koha::Hold->cancel) - suspend (Koha::Hold->suspend) - resume (Koha::Hold->resume) The cancel() action is added a *skip_holds_queue* parameter to skip triggering the background job entirely. It targets cases like C4::Biblio::DelBiblio in which all biblio holds are cancelled in a loop. In that case, we just want to cancel them and let a single backgroung job take care of the holds queue, once the biblio is deleted. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t \ t/db_dependent/Reserves.t => SUCCESS: Tests pass! Triggers are triggered 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #66 from Nick Clemens --- Created attachment 134329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134329=edit Bug 29346: Add holds queue update background job This patch adds a background job that takes care of updating the holds queue rows for a given list of biblios. It is designed to be used for real-time batch updating the holds queue when required. Tasks would be added by the relevant methods under the right use cases. Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Nick Clemens changed: What|Removed |Added Attachment #134309|0 |1 is obsolete|| Attachment #134310|0 |1 is obsolete|| Attachment #134311|0 |1 is obsolete|| Attachment #134312|0 |1 is obsolete|| Attachment #134313|0 |1 is obsolete|| Attachment #134314|0 |1 is obsolete|| Attachment #134315|0 |1 is obsolete|| Attachment #134316|0 |1 is obsolete|| Attachment #134317|0 |1 is obsolete|| Attachment #134318|0 |1 is obsolete|| Attachment #134319|0 |1 is obsolete|| Attachment #134320|0 |1 is obsolete|| Attachment #134321|0 |1 is obsolete|| Attachment #134322|0 |1 is obsolete|| --- Comment #65 from Nick Clemens --- Created attachment 134328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134328=edit Bug 29346: Refactor loop code into a subroutine The CreateQueue() method deletes the holds queue data, fetches some configuration (branches to use, transport cost matrix) and then loops through a list of biblionumbers, generating the tmp_holdsqueue and hold_fill_targets rows for the specified biblio. This patch simply moves that last bit that is run inside the biblios loop into a separate sub. The update_queue_for_biblio sub is designed so it does the exact same thing it did inside the loop, but also gets added the capability of querying those parameters if not passed, and it also gets a 'delete' parameter so it deletes the biblio-specific holds queue rows before starting to work. This way, it can be reused to write a background job for real-time holds queue update :-D To test: 1. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! Behavior is kept! 4. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #13 from Hayley Pelham --- Created attachment 134327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134327=edit Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #12 from Hayley Pelham --- Created attachment 134326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134326=edit Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #11 from Hayley Pelham --- Created attachment 134325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134325=edit Bug 6796: ConsiderLibraryHoursWhenIssuing system preference -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Hayley Pelham changed: What|Removed |Added Attachment #124669|0 |1 is obsolete|| Attachment #124670|0 |1 is obsolete|| Attachment #124671|0 |1 is obsolete|| Attachment #124672|0 |1 is obsolete|| --- Comment #10 from Hayley Pelham --- Created attachment 134324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134324=edit Bug 6796: Updated schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #9 from Hayley Pelham --- Created attachment 134323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134323=edit Bug 6796: Add branch_hours table and set opening hours for library -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Hayley Pelham changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook --- (In reply to Marcel de Rooy from comment #4) > Does it make more sense to choose some arbitrary date for all unknown > acquired dates and run a SQL update to replace the NULLs? And even the > -00-00 values that I still discovered in my table too? +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #10 from David Cook --- (In reply to Katrin Fischer from comment #9) > But then the lines all get "mushed together" into a long block of text > without any separators making it hard to read/take apart: Perhaps wrap it in "" tags that preserve the original formatting from MARC::Lint? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30649 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28998 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- I think Jonathan has already almost gotten an encryption module into Koha with Bug 28998, so this would arguably be a duplicate? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #64 from Tomás Cohen Arazi --- Created attachment 134322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134322=edit Bug 29346: Remove unused circular dependency on C4::Search Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #63 from Tomás Cohen Arazi --- Created attachment 134321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134321=edit Bug 29346: Add better reporting Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #62 from Tomás Cohen Arazi --- Created attachment 134320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134320=edit Bug 29346: (follow-up) Fix typo 'availabe' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #61 from Tomás Cohen Arazi --- Created attachment 134319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134319=edit Bug 29346: (QA follow-up) Rebuild queue when adjusting priorities of holds Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #60 from Tomás Cohen Arazi --- Created attachment 134318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134318=edit Bug 29346: Add more fine-grained control of holds queue updates This patch deals with the fact that high-level circualtion methods like `AddIssue`, `AddReturn` and `ModDateLastSeen` all eventually call lower-level methods like ModBiblio, Koha::Item->store of UpdateTotalIssues which are expected to trigger holds queue updates (for the object CRUD operations use cases). As the circulation methods need to trigger holds queue update as well, duplicate updates were being requested which is suboptimal, of course. In order to prevent this, and because circulation methdos could trigger holds queue updates several times, actually, I added a new parameter *skip_holds_queue* to the low-level methods, so when they are called from circulation, the trigger is skipped and we have greater control on when and how holds queue updates are scheduled. This patch introduces the `skip_holds_queue` parameter to the following methods: * C4::Biblio::ModBiblio * C4::Biblio::UpdateTotalIssues * Koha::Item->store Calls to those methods from the following methods will include the new parameter, and thus duplicated holds queue updates avoided: * C4::Circulation::AddIssue * C4::Circulation::AddReturn * C4::Items::ModDateLastSeen Tests are added, to verify that the (mocked) BatchUpdateBiblioHoldsQueue task is only scheduled once when they are called. To test: 1. Apply up to the previous patch 2. Run: $ kshell k$ prove t/db_dependent/Biblio.t \ t/db_dependent/Biblio_holdsqueue.t \ t/db_dependent/Circulation_holdsqueue.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #59 from Tomás Cohen Arazi --- Created attachment 134317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134317=edit Bug 29346: Avoid duplicate actions tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #58 from Tomás Cohen Arazi --- Created attachment 134316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134316=edit Bug 29346: Highlight double enqueue This patch highlights a possible issue with the triggers.. though it may not actually matter in reality. I appear to already see test failures before this patch with a double enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot what was causing that but whilst digging I did find another case where it could happen as highlighted here... Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #57 from Tomás Cohen Arazi --- Created attachment 134315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134315=edit Bug 29346: (follow-up) Fix typo We set biblio_ids in enqueue then referred to biblio_id in process ;) Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #56 from Tomás Cohen Arazi --- Created attachment 134314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134314=edit Bug 29346: Item action trigger This patch makes the following actions trigger a holds queue rebuild for the related biblio: - Adding an item - Updating an item - Deleting an item To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! Background job scheduled 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #55 from Tomás Cohen Arazi --- Created attachment 134313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134313=edit Bug 29346: Biblio actions triggers This patch adds the trigger for the holds queue update on teh following methods: - C4::Biblio::DelBiblio - C4::Biblio::ModBiblio The ModBiblio use case could be improved by checking if itemtype is one of the updated attributes... but it felt there was no way to do it without some overhead. So I leave it as-is. It also mocks the ->enqueue method in the tests that call DelBiblio and ModBiblio to avoid breakages [1] Tests are added to check the trigger is called. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Biblio.t => SUCCESS: Tests pass! It means the trigger is triggered :-D 3. Sign off :-D [1] This breakages could be avoided if we solve Koha/BackgrounJob.pm:101 FIXME. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #54 from Tomás Cohen Arazi --- Created attachment 134312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134312=edit Bug 29346: Circulation actions triggers This patch introduces triggers for real-time updating the holds queue at check out and check in. The following high-level methods are involved: - C4::Circulation::AddIssue - C4::Circulation::AddReturn To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation_holdsqueue.t => SUCCESS: Tests pass! Triggers are triggered 3. Sign off :-D Note: I put the tests on a separate file because the other one was too big already. Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #53 from Tomás Cohen Arazi --- Created attachment 134311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134311=edit Bug 29346: Hold actions triggers This patch makes several holds related actions schedule the background job for real-time update of the holds queue. This actions are: - place (C4::Reserves::AddReserve) - fill (Koha::Hold->fill) - cancel (Koha::Hold->cancel) - suspend (Koha::Hold->suspend) - resume (Koha::Hold->resume) The cancel() action is added a *skip_holds_queue* parameter to skip triggering the background job entirely. It targets cases like C4::Biblio::DelBiblio in which all biblio holds are cancelled in a loop. In that case, we just want to cancel them and let a single backgroung job take care of the holds queue, once the biblio is deleted. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t \ t/db_dependent/Reserves.t => SUCCESS: Tests pass! Triggers are triggered 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #52 from Tomás Cohen Arazi --- Created attachment 134310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134310=edit Bug 29346: Add holds queue update background job This patch adds a background job that takes care of updating the holds queue rows for a given list of biblios. It is designed to be used for real-time batch updating the holds queue when required. Tasks would be added by the relevant methods under the right use cases. Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #51 from Tomás Cohen Arazi --- Created attachment 134309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134309=edit Bug 29346: Refactor loop code into a subroutine The CreateQueue() method deletes the holds queue data, fetches some configuration (branches to use, transport cost matrix) and then loops through a list of biblionumbers, generating the tmp_holdsqueue and hold_fill_targets rows for the specified biblio. This patch simply moves that last bit that is run inside the biblios loop into a separate sub. The update_queue_for_biblio sub is designed so it does the exact same thing it did inside the loop, but also gets added the capability of querying those parameters if not passed, and it also gets a 'delete' parameter so it deletes the biblio-specific holds queue rows before starting to work. This way, it can be reused to write a background job for real-time holds queue update :-D To test: 1. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! Behavior is kept! 4. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #87 from Aleisha Amohia --- Created attachment 134308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134308=edit Bug 3150: (follow-up) Fixing errors and notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #130153|0 |1 is obsolete|| --- Comment #86 from Aleisha Amohia --- Created attachment 134307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134307=edit Bug 3150: (follow-up) Add missing bracket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #130152|0 |1 is obsolete|| --- Comment #85 from Aleisha Amohia --- Created attachment 134306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134306=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #130151|0 |1 is obsolete|| --- Comment #84 from Aleisha Amohia --- Created attachment 134305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134305=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #130150|0 |1 is obsolete|| --- Comment #83 from Aleisha Amohia --- Created attachment 134304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134304=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30632] Fix report author display in list of saved reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||report authors in the list ||of saved reports to remove ||the extra space before the ||comma (Lastname, Firstname ||was displaying as Lastname ||, Firstname). CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30644] Cannot delete items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30644] Cannot delete items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30644 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 --- Comment #17 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 --- Comment #17 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #58 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30632] Fix report author display in list of saved reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 David Nind changed: What|Removed |Added Attachment #134281|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 134303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134303=edit Bug 30632: Fix report author display in list of saved reports This patch removes whitespace in the template around the markup of report author first name and surname. This prevents unwanted spaces in the output. To test, apply the patch and go to Reports -> Use saved. The display of report author should be like this: Leonard, Owen (123456) Instead of Leonard , Owen (20375) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30632] Fix report author display in list of saved reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 David Nind changed: What|Removed |Added Text to go in the|This fixes the batch patron |This fixes the batch patron release notes|modification (Tools > |modification tool (Tools > |Patrons and circulation > |Patrons and circulation > |Batch patron modification) |Batch patron modification) |so that the changes for all |so that the changes for all |selected patrons are|selected patrons are |modified. Before this, only |modified. Before this, only |the patrons listed on the |the patrons listed on the |current page were modified. |current page were modified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes the batch patron release notes||modification (Tools > ||Patrons and circulation > ||Batch patron modification) ||so that the changes for all ||selected patrons are ||modified. Before this, only ||the patrons listed on the ||current page were modified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #481 from Fridolin Somers --- I don't understand enough this feature and its links with other features. So I've chosen to pass it to next Release Manager. Great work ByWaters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #50 from Tomás Cohen Arazi --- Sorry, it seems I didn't confirm the upload on my desktop computer. Will do once I get back home. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from David Nind --- Patch no longer applies 8-(.. apologies for not getting back on to this one sooner. Applying: Bug 23781: SMS notices and messaging preferences for recalls Using index info to reconstruct a base tree... M Koha/Recall.pm M Koha/Recalls.pm M installer/data/mysql/en/mandatory/sample_notices.yml M installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql M koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml Auto-merging Koha/Recalls.pm Auto-merging Koha/Recall.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23781: SMS notices and messaging preferences for recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What|Removed |Added Attachment #134301|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 134302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134302=edit Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts Right now, we store passwords for external services in plain text in the database. It would be good to have the option to encrypt those passwords. Test Plan: 1) prove t/Crypt.t 2) Create a new vendor edi account 3) Note the password is encrypted 4) Update the password for an existing EDI vendor account 5) Note the password is now encrypted in the database 6) Stretch goal, set up an FTP server, send an EDI order to the FTP server where the vendor password is encrypted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What|Removed |Added Attachment #134300|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 134301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134301=edit Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts Right now, we store passwords for external services in plain text in the database. It would be good to have the option to encrypt those passwords. Test Plan: 1) prove t/Crypt.t 2) Create a new vendor edi account 3) Note the password is encrypted 4) Update the password for an existing EDI vendor account 5) Note the password is now encrypted in the database 6) Stretch goal, set up an FTP server, send an EDI order to the FTP server where the vendor password is encrypted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What|Removed |Added Attachment #134298|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 134300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134300=edit Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts Right now, we store passwords for external services in plain text in the database. It would be good to have the option to encrypt those passwords. Test Plan: 1) prove t/Crypt.t 2) Create a new vendor edi account 3) Note the password is encrypted 4) Update the password for an existing EDI vendor account 5) Note the password is now encrypted in the database 6) Stretch goal, set up an FTP server, send an EDI order to the FTP server where the vendor password is encrypted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 David Nind changed: What|Removed |Added Attachment #134222|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 134299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134299=edit Bug 29755: (follow-up) Mock NoIssuesChargeGuarantorsWithGuarantees in test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #1 from Kyle M Hall --- Created attachment 134298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134298=edit Bug 30649 - Add ability to encrypt data in Koha, use for EDI vendor accounts Right now, we store passwords for external services in plain text in the database. It would be good to have the option to encrypt those passwords. Test Plan: 1) prove t/Crypt.t 2) Create a new vendor edi account 3) Note the password is encrypted 4) Update the password for an existing EDI vendor account 5) Note the password is now encrypted in the database 6) Stretch goal, set up an FTP server, send an EDI order to the FTP server where the vendor password is encrypted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 David Nind changed: What|Removed |Added Attachment #134221|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 134297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134297=edit Bug 29755: Check each NoIssuesCharge separately This patch updates SIP patron code to use account methods to calculate balances over the patronflags returns. It also checks if patron should be blocked for each 'No Issues charge' preference Tests are added for NoIssuesChargeGuarantees To test: 1 - Set noissuescharge preference to 5 2 - Add a $10 charge to a patron 3 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 4 - Note the 64 message starts with Y's that mean patron is blocked 5 - Set noissuescharge to 11 6 - Repeat 3, patron is no longer blocked 7 - Set NoIssuesChargeGuarantees to 8 8 - Repeat 3, patron is blocked 9 - Pay $3 on patron so they owe 7 10 - Repeat 3, patron is not blocked 11 - Add a child account with patron as guarantor 12 - Repeat 3, patron is not blocked 13 - Add a $4 charge to child 14 - Repeat 3, patron is blocked 15 - Repeat 3, but with child barcode, child is not blocked 16 - Set NoIssuesChargeGuarantorsWithGuarantees to 10 17 - Repeat 3, patron is blocked 18 - Repeat 3 with child barcode, child is blocked Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] New: Add ability to encrypt data in Koha, use for EDI vendor accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Bug ID: 30649 Summary: Add ability to encrypt data in Koha, use for EDI vendor accounts Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Right now, we store passwords for external services in plain text in the database. It would be good to have the option to encrypt those passwords. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #480 from Nick Clemens --- Created attachment 134296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134296=edit Bug 24857: Add object classes to Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #479 from Nick Clemens --- Created attachment 134295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134295=edit Bug 24857: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #478 from Nick Clemens --- Created attachment 134294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134294=edit Bug 24857: Delete item group when last item is deleted To test: 1 - Find a record with an item gorup, or add a group 2 - Add an item to this group, ensure it is the only item in the group 3 - Delete the item 4 - Confirm the gorup was also deleted 5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #477 from Nick Clemens --- Created attachment 134293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134293=edit Bug 24857: Add ability to set item group when adding a new item During cataloging a user may wish to add an item to a group when creating a new item This patch also copies the group description to the enumchron field To test: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group, or create new 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #476 from Nick Clemens --- Created attachment 134292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134292=edit Bug 24857: Add item group management to detail.pl Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableItemGroups 5) Browse to detail.pl for a record with items 6) Note the new Item Groups tab 7) Test creating, editing and deleting groups 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting an item group for items, and for clearing an item group for items. 9) Test adding and clearing the item group for items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #475 from Nick Clemens --- Created attachment 134291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134291=edit Bug 24857: Add Object Methods To test: 1 - prove t/db_dependent/Koha/Biblio.t 2 - prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #474 from Nick Clemens --- Created attachment 134290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134290=edit Bug 24857: API spec To test: 1 - prove t/db_dependent/api/v1/item_groups.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #473 from Nick Clemens --- Created attachment 134289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134289=edit Bug 24857: Add Koha Objects To test: 1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Nick Clemens changed: What|Removed |Added Attachment #131449|0 |1 is obsolete|| Attachment #131450|0 |1 is obsolete|| Attachment #131451|0 |1 is obsolete|| Attachment #131452|0 |1 is obsolete|| Attachment #131453|0 |1 is obsolete|| Attachment #131454|0 |1 is obsolete|| Attachment #131455|0 |1 is obsolete|| Attachment #131456|0 |1 is obsolete|| --- Comment #472 from Nick Clemens --- Created attachment 134288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134288=edit Bug 24857: Database updates This adds the new tables, syspref, and a new permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30553] Add a count to the Files tab in the patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30553 --- Comment #7 from Lucas Gass --- Created attachment 134287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134287=edit Bug 30553: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 --- Comment #8 from Katrin Fischer --- I think Joubu is right about that the change needs to be not only in the templates, but secured server side as well. I think we'd definitely need to push this together with 29887 to make sure we don't break someones use case by closing this loop-holes. Would it make sense to test both patches together? As this is now SO I have moved bug 29887 back into the QA queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Katrin Fischer changed: What|Removed |Added Attachment #134220|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 134286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134286=edit Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30037] Set default profile when staging MARC records on import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 --- Comment #8 from Katrin Fischer --- (In reply to Owen Leonard from comment #7) > I think this change goes against the way we generally do things. In fact, > we've been patching similar fields elsewhere because it was too easy for the > user to accept a possibly incorrect default. > > I think if we want to define a default profile we should have it be an > additional setting in the profile. +1 I agree with Owen here, this was making me feel uneasy and I think the suggested solution would be a much better fit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Hi Aleisha, this works, but some questions: 1) Could we not use staffClientBaseURL instead of or as a default/fallback for the --intranet option? This way it would work for multiple instances without having differentiate the crontab entries. 2) The HTML output is a little hard to read. 2 suggestions: a) Add a header row b) Add instead of line breaks. The output on the command line is something like: 100: Indicator 1 must be 0, 1 or 3 but it's " " 245: Indicator 1 must be 0 or 1 but it's " " 245: Indicator 2 must be 0 thru 9 but it's " " 245: Must end with . (period). 245: Non-filing indicator is non-numeric 245: First word, clouded, does not appear to be an article, check 2nd indicator ( ). But then the lines all get "mushed together" into a long block of text without any separators making it hard to read/take apart: 100: Indicator 1 must be 0, 1 or 3 but it's " " 245: Indicator 1 must be 0 or 1 but it's " " 245: Indicator 2 must be 0 thru 9 but it's " " 245: Must end with . (period). 245: Non-filing indicator is non-numeric 245: First word, clouded, does not appear to be an article, check 2nd indicator ( ). Could you take a look and give me some feedback? Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30037] Set default profile when staging MARC records on import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- I think this change goes against the way we generally do things. In fact, we've been patching similar fields elsewhere because it was too easy for the user to accept a possibly incorrect default. I think if we want to define a default profile we should have it be an additional setting in the profile. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The clear screen and print icons in circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #9 from Katrin Fischer --- Hi Lucas, maybe you can have a look at my last follow-up and let me know if that works for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The clear screen and print icons in circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #8 from Katrin Fischer --- Created attachment 134285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134285=edit Bug 29129: (QA follow-up) Rephrasing DisplayClearScreenButton preference Trying to make it clearer that's either none or 2 buttons. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
