[Koha-bugs] [Bug 27305] Use low privileged tokens to enable authenticated iCal feed

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305

--- Comment #21 from Michal Denar  ---
Hi,
I like the idea. Some time ago I wondered if it would be possible to attach an
iCal file to notification messages. But the feed is easier for the user. It
would be great to add the ability to manage iCal feeds via the API. For
libraries that use other OPAC solutions (like VuFind). Actually, it would be
enough to generate/delete a token this way. It would also be great to add the
expiration date of the reader account to the feed. From my point of view, this
feature has a lot of potential. I'm not a developer, but I can offer testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381
Bug 29381 depends on bug 18532, which changed state.

Bug 18532 Summary: Messaging preferences for auto renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456
Bug 29456 depends on bug 18532, which changed state.

Bug 18532 Summary: Messaging preferences for auto renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27966] Fix plural handling for AUTO_RENEWALS_DGST message

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27966
Bug 27966 depends on bug 18532, which changed state.

Bug 18532 Summary: Messaging preferences for auto renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18532] Messaging preferences for auto renewals

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #134829|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30611] Add ability to trigger a patron password reset from the staff client

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30611] Add ability to trigger a patron password reset from the staff client

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611

--- Comment #21 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30611] Add ability to trigger a patron password reset from the staff client

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30510] Add a Patron reason column to the suggestion table in the staff interface

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510

--- Comment #6 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30510] Add a Patron reason column to the suggestion table in the staff interface

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30510

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

--- Comment #8 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30290] Article requests: Add TOC information to AR notices

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290

--- Comment #14 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30290] Article requests: Add TOC information to AR notices

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082

--- Comment #5 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

--- Comment #54 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615

--- Comment #17 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement to the
  release notes||OPAC detail page allows you
   ||to search WorldCat using
   ||the OCLC number. (Example:
   ||add an entry to 035$a (such
   ||as (OCoLC)62385712) and use
   ||{OCLC_NO} in the
   ||OPACSearchForTitleIn system
   ||preference.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #11 from David Nind  ---
Tetsing notes (koha-testing-docker):

1. Make tag 035 and subfields visible in the MARC editor for the BKS framework.

2. Add entry to 035$a = (OCoLC)62385712

3. Follow the rest of the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

David Nind  changed:

   What|Removed |Added

 Attachment #134815|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 134847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134847=edit
Bug 30678: (follow-up) Change call in opac scripts

Test plan:
See first patch. Add orgcode OCoLC.

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

David Nind  changed:

   What|Removed |Added

 Attachment #134814|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 134846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134846=edit
Bug 30678: (follow-up) Add oclc_number routine and friends

As requested by QA, we should match the orgcode.
Adding a few small routines in a Util module.

Test plan:
Run t/Koha/Util/MARC.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

David Nind  changed:

   What|Removed |Added

 Attachment #134614|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 134845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134845=edit
Bug 30678: Adjust pref description

Test plan:
Look up pref OPACSearchForTitleIn.

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

David Nind  changed:

   What|Removed |Added

 Attachment #134613|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 134844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134844=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn

We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.

Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being paid' with CurrencyFormat = FR

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #7 from David Nind  ---
Created attachment 134843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134843=edit
Screenshot - after patch applied

I've attached a screenshot after the patch was applied.

I'm assuming that for the cost column, amount being paid, and amount tendered
will be fixed to show a comma rather than a period once changes to
paycollect.tt moneyFormat function are made (comment #5).

Note: it was a little tricky to capture the screen with the amount tendered
entered as 10,00 - once you click out it defaults to being 10.00 as the amount
tendered.

I'm also not sure whether you would normally enter the amount tendered as 10.00
or 10,00.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27305] Use low privileged tokens to enable authenticated iCal feed

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305

David Cook  changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

--- Comment #20 from David Cook  ---
(In reply to Sally from comment #19)
> Sorry, patch no longer applies.

Thanks for testing :).

This patch needs an overhaul and I'm not sure there's enough community interest
in it to advance anyway, unfortunately.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

--- Comment #6 from David Cook  ---
(In reply to Aleisha Amohia from comment #5)
> Having multiple people using one account sounds like it's own security
> risk... I don't think we should compromise on functionality to support that
> use case.

Agreed. While account sharing is a common practice, it isn't one that we should
encourage or support. 

(In reply to Andrew Fuerste-Henry from comment #4)
> Whether or not users can change their password via the OPAC is governed by
> the OpacPasswordChange system preference. This enhancement should contain
> either a comparable syspref for the staff interface or a new user permission
> to change one's own password.

That's a good point too though. I suppose it is a fairly significant feature
change, and we do tend to make new features opt-in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being paid' with CurrencyFormat = FR

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139

David Nind  changed:

   What|Removed |Added

 Attachment #134830|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 134842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134842=edit
Bug 30139: Fix javascript moneyFormat to be compatible with FR format

New way of formatting money amount to make it work with FR format

Test plan:
1- Set CurrencyFormat pref to FR
2- Activate Point of sale and cash register features
3- Add cash register
4- Add debit type that 'can be sold' with a price of 10.00
5- Go to point of sale, click on the item to purchase
6- Verify the Amount to be paid shows the wrong amount and can't be fixed on
the interface
7- Apply the patch
8- Refresh the page and do step 5 again
9- Notice it now shows the right amount

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being paid' with CurrencyFormat = FR

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

David Nind  changed:

   What|Removed |Added

 Attachment #134821|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 134841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134841=edit
Bug 30727: Avoid holds queue updates multiple times on BatchDeleteBiblio

This patch makes the background job only enqueue holds queue updates
once per biblio, when appropriate.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
=> FAIL: It enqueues 3 times for a bib!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It only enqueues once!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

David Nind  changed:

   What|Removed |Added

 Attachment #134820|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 134840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134840=edit
Bug 30727: Regression tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

--- Comment #5 from David Nind  ---
(In reply to Tomás Cohen Arazi from comment #4)
> Sorry, I missed the fact the skip_holds_queue parameter was added on bug
> 30710. Tweaked the dependencies.

Thanks Tomás! Tests now pass, so sign-off on the way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #27 from David Nind  ---
I think I have tested this correctly.

Another sign-off would be very welcome!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

David Nind  changed:

   What|Removed |Added

 Attachment #134811|0   |1
is obsolete||

--- Comment #26 from David Nind  ---
Created attachment 134839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134839=edit
Bug 28529: Make biblio-level hold itemtype count against max rules

The current situation is that biblio-level holds can be assigned an item
type, so they can only be fulfilled by items matching that specified
item type (be it item-level itype or the fallback to biblio-level).

But there's the situation in which max holds limits for a specific item
type can be overridden by using biblio-level holds with item type
selection (AllowHoldItemTypeSelection) enabled.

To test:
1. Have a patron of category 'Staff' (S)
2. Have 3 records with items with the 'BK' item type, and maybe others
3. Enable AllowHoldItemTypeSelection
4. Set a limit of 2 max holds for that category+item type
5. In the OPAC. Place bibio-level holds, with item type contraint to 'BK' on
those 3 records
=> FAIL: You can place the 3 holds
6. Cancel the holds
7. Apply this patch and restart all
8. Repeat 5
=> SUCCESS: You can only place 2 holds
9. Run:
   $ kshell t/db_dependent/Reserves.t
=> SUCCESS: Tests pass!
10. Sign off :-D

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

David Nind  changed:

   What|Removed |Added

 Attachment #134810|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 134838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134838=edit
Bug 28529: Unit tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

David Nind  changed:

   What|Removed |Added

 Attachment #134809|0   |1
is obsolete||

--- Comment #24 from David Nind  ---
Created attachment 134837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134837=edit
Bug 28529: Add BiblioHoldItemTypeUseForRules system preference

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #4 from Tomás Cohen Arazi  ---
Sorry, I missed the fact the skip_holds_queue parameter was added on bug 30710.
Tweaked the dependencies.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30710] Background tasks can be called multiple times on batch item deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30710

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||30727


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727
[Bug 30727] Holds queue updates can be called multiple times on batch record
deletion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29346] Real-time holds queue update

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|30727   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727
[Bug 30727] Holds queue updates can be called multiple times on batch record
deletion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on|29346   |30710


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
[Bug 29346] Real-time holds queue update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30710
[Bug 30710] Background tasks can be called multiple times on batch item
deletion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

--- Comment #5 from Aleisha Amohia  ---
Having multiple people using one account sounds like it's own security risk...
I don't think we should compromise on functionality to support that use case.

The real issue is what David has mentioned in Comment 1. If a person can log
into the staff client, it's illogical to then have to direct them to the OPAC
(another site) to change their own password. Many Koha libraries don't use the
OPAC, or if they do, they may have OpacPasswordChange disabled, and then what? 

Additionally, I can't think of any online accounts I have where I can't change
my own password on the site I've logged into. I don't believe we need to wrap
this in a syspref or new permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

--- Comment #21 from David Nind  ---
I like the one called "owen patch" the best, but they all nice improvements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30713] Patron entry should limit date of birth selection to dates in the past

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713

--- Comment #7 from David Nind  ---
Thanks Owen for fixing - I wasn't sure I had originally tested it correctly
(thanks also Sally for testing and confirming as well!).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30713] Patron entry should limit date of birth selection to dates in the past

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713

David Nind  changed:

   What|Removed |Added

 Attachment #134816|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 134836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134836=edit
Bug 30713: Patron entry should limit date of birth selection to dates in the
past

This patch adds to the configuration of the date of birth field in the
patron entry form so that the calendar widget prohibits the selection of
a date in the future.

To test, apply the patch and open a patron record for editing. Try to
select a birth date in the future using the calendar widget. You should
be limited to a selection of today or before.

Confirm that clicking the "Yesterday" and "Today" shortcuts in the
calendar widget works correctly.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30713] Patron entry should limit date of birth selection to dates in the past

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590

Alex Buckley  changed:

   What|Removed |Added

   Assignee|alexbuck...@catalyst.net.nz |wainuiwitikapark@catalyst.n
   ||et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30422] Authorities editor update broke the feature added by Bug 20154

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422

David Nind  changed:

   What|Removed |Added

 Attachment #134822|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 134835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134835=edit
Bug 30422: Authorities editor update broke the feature added by Bug 20154

This patch corrects JavaScript in authorities templates so that
clicking "Edit" on the authority detail page will take you to the
authority edit page while keeping the same tab open.

This patch also corrects the JavaScript which should have been
automatically moving the cursor focus to the first form field when
switching tabs in the editor.

This patch also adds the "Section" headings which are present in the
basic cataloging editor but were not added here at the time of the
page's tabs revision.

To test, apply the patch and locate an authority record in your catalog.

- Without changing tabs, choose "Edit record" from the "Edit" dropdown
  menu."
- The authorities editor should load and display the "Section 0" tab.
- Return to the authority detail page and select a tab besides tab 0.
- Click back to tab 0. Editing the record at this point should open the
  editor to Section 0.
- Return to the authority detail page.
- Click any of the numbered tabs besides tab 0.
- Choose "Edit record" from the "Edit" dropdown menu.
- When the authorities edit page loads the same tab should be
  preselected.
- Test that when you switch tabs in the authority editor the cursor
  focus is automatically moved to the first visible input.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30422] Authorities editor update broke the feature added by Bug 20154

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30729] New: Template toolkit comments are caught in the translatable strings

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30729

Bug ID: 30729
   Summary: Template toolkit comments are caught in the
translatable strings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vic...@tuxayo.net
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

I was checking the untranslated strings for 22.05 and noticed template toolkit
comments are caught in the translatable strings.

For example this string:
%%] [%%# - category:␠
https://translate.koha-community.org/fr/22.05/translate/fr-FR-staff-prog.po#unit=22438387

It comes from koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc

[%# Display a complex patron search form %]
[%# - Search:  %]
[%# You can then pass a list of filters %]
[%# - branch:  %]
[%# - category:  %]
[%# - search_field:  %]
[%# - search_type:  %]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #13 from David Nind  ---
After signing off, the [OPTIONAL] patch is still there as well as the signed
off version without optional in the title - does this need to be obsoleted?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
The tests fail for me for step 4:

prove -v t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t .. 
1..1
# Subtest: process() tests
1..1
not ok 1 - Holds queue update is enqueued only once

#   Failed test 'Holds queue update is enqueued only once'
#   at t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t line 81.
#  got: '4'
# expected: '1'
# Looks like you failed 1 test of 1.
not ok 1 - process() tests

#   Failed test 'process() tests'
#   at t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t line 84.
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
---
t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t (Wstat: 256 Tests: 1
Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  3 wallclock secs ( 0.02 usr  0.01 sys +  2.25 cusr  0.18
csys =  2.46 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #12 from David Nind  ---
Created attachment 134834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134834=edit
Bug 30728: Make RealTimeHoldsQueue disabled by default

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

David Nind  changed:

   What|Removed |Added

 Attachment #134828|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 134833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134833=edit
Bug 30728: Only trigger real-time holds queue update if enabled

This patch makes the places in which Koha enqueues holds queue for
real time updates verify the feature is enabled.

To test:
1. Apply this patches up to the unit tests
2. Run:
   $ updatedatabase
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> FAIL: tests fail, the code doesn't care about the syspref
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Be happy!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

David Nind  changed:

   What|Removed |Added

 Attachment #134827|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 134832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134832=edit
Bug 30728: Add unit tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

David Nind  changed:

   What|Removed |Added

 Attachment #134826|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 134831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134831=edit
Bug 30728: Add RealTimeHoldsQueue syspref

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27631] Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

Fridolin Somers  changed:

   What|Removed |Added

  Text to go in the|This enhancement, as part   |This enhancement, as part
  release notes|of improving the|of improving the
   |accessibility of the staff  |accessibility of the staff
   |interface, makes the main   |interface, makes the main
   |topic/title of the page the |topic/title of the page the
   |`` rather than the  |`h1` rather than the logo.
   |logo.   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30697] IsAvailableForItemLevelRequest returns wrong when items_any_available is defined

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30697

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30697] IsAvailableForItemLevelRequest returns wrong when items_any_available is defined

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30697

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #134666|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #3 from Fridolin Somers  ---
We should clone MARC::Record in UpdateOAISetsBiblio ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable
 Version(s)|22.05.00,21.11.05,21.05.15  |22.05.00,21.11.05,21.05.15,
released in||20.11.19
 CC||vic...@tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo  ---
Backported: Pushed to 20.11.x branch for 20.11.19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing items

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29885] Add the option to customise Z39.50 searches

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885

Laura Horgan  changed:

   What|Removed |Added

 CC||horg...@middlesex.mass.edu

--- Comment #2 from Laura Horgan  ---
(In reply to Donna from comment #1)
> This sort of enhancement has been requested by a number of libraries.  One
> of the most common requests is to have a way to see in the search results
> what the format of the record is.  For instance, if I do a search and get
> three results, all containing the same ISBN, I have to look at each record
> to determine if the record is the print, ebook, audio etc as that info is
> not readily displayed.  So in this case, some way to see the leader and 008.
> 
> 
> While we can add additional search fields to the results display, it gets
> rather unwieldy quickly.  
> 
> Being able to choose what fields should show in the search results would be
> very helpful.  Perhaps a system preference where you can list which fields
> are wanted/unwanted?

Hey Donna it is not possible through the additional fields function to see the
336, 337, 338 which is quite helpful.  We just added this additional
information this semester

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being paid' with CurrencyFormat = FR

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139

Shi Yao Wang  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||shi-yao.w...@inlibro.com
   Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com
   |ity.org |

--- Comment #5 from Shi Yao Wang  ---
If this is good. We can copy paste the changes to paycollect.tt moneyFormat
function as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30139] Point of sale sets wrong 'Amount being paid' with CurrencyFormat = FR

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30139

--- Comment #4 from Shi Yao Wang  ---
Created attachment 134830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134830=edit
Bug 30139: Fix javascript moneyFormat to be compatible with FR format

New way of formatting money amount to make it work with FR format

Test plan:
1- Set CurrencyFormat pref to FR
2- Activate Point of sale and cash register features
3- Add cash register
4- Add debit type that 'can be sold' with a price of 10.00
5- Go to point of sale, click on the item to purchase
6- Verify the Amount to be paid shows the wrong amount and can't be fixed on
the interface
7- Apply the patch
8- Refresh the page and do step 5 again
9- Notice it now shows the right amount

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #8 from Tomás Cohen Arazi  ---
Personally, I prefer to have the feature enabled by default. But I've added a
follow-up patch disabling it by default so we can choose to disable it by
default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 134829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134829=edit
[OPTIONAL] Bug 30728: Make RealTimeHoldsQueue disabled by default

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 134828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134828=edit
Bug 30728: Only trigger real-time holds queue update if enabled

This patch makes the places in which Koha enqueues holds queue for
real time updates verify the feature is enabled.

To test:
1. Apply this patches up to the unit tests
2. Run:
   $ updatedatabase
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> FAIL: tests fail, the code doesn't care about the syspref
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Be happy!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 134827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134827=edit
Bug 30728: Add unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 134826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134826=edit
Bug 30728: Add RealTimeHoldsQueue syspref

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #134823|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #134825|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #134824|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30727] Holds queue updates can be called multiple times on batch record deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||30728


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728
[Bug 30728] Allow real-time holds queue opt-out
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30710] Background tasks can be called multiple times on batch item deletion

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30710

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||30728


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728
[Bug 30728] Allow real-time holds queue opt-out
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29346] Real-time holds queue update

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|30728   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728
[Bug 30728] Allow real-time holds queue opt-out
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on|29346   |30710, 30727


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
[Bug 29346] Real-time holds queue update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30710
[Bug 30710] Background tasks can be called multiple times on batch item
deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727
[Bug 30727] Holds queue updates can be called multiple times on batch record
deletion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 134825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134825=edit
Bug 30728: Only trigger real-time holds queue update if enabled

This patch makes the places in which Koha enqueues holds queue for
real time updates verify the feature is enabled.

To test:
1. Apply this patches up to the unit tests
2. Run:
   $ updatedatabase
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> FAIL: tests fail, the code doesn't care about the syspref
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Be happy!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 134824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134824=edit
Bug 30728: Add unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 134823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134823=edit
Bug 30728: Add RealTimeHoldsQueue syspref

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Simon Hohl  changed:

   What|Removed |Added

 CC||simon.h...@dainst.org

--- Comment #64 from Simon Hohl  ---
In order to keep this bug alive: Our institution has several libraries in
different countries requiring all kinds of char sets and punctuation supported,
so we are also very much interested to have a generic solution to the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768

--- Comment #13 from Joonas Kylmälä  ---
err..

(In reply to Joonas Kylmälä from comment #12)
> after applying the patch. I fix would be to go for now how other pages have

I fix -> One fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #12 from Joonas Kylmälä  ---
The last patch would break a lot of pages, e.g. see the browser title field
after applying the patch. I fix would be to go for now how other pages have
handled this: by grepping "patron-title.inc" you can find for examples:

> ./prog/en/modules/members/accountline-details.tt:  href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% 
> patron.borrowernumber | uri %]">Account for [% INCLUDE 'patron-title.inc' 
> %]

so basically add the link manually around the patron-title.inc include
statement.

However the ideal solution would be to:

1. Modify the last patch from here to support in addition no_html = 1 parameter
correctly in patron-title.inc (the current support is only partly done...)
2. add the no_html = 1 tag to all the places where patron-title.inc is used and
it cannot contain a link (for example in a browser title tag or inside another
link)

If you don't decide to go with the ideal solution then let's open another bug
report for that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12141] On Display Module

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141

--- Comment #15 from George Williams (NEKLS)  ---
This enhancement is still relevant - especially for libraries that can't turn
the Course Reserves module into a displays module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29346] Real-time holds queue update

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||Enabled by default, this
  release notes||feature can be opted out
   ||using the
   ||*RealTimeHoldsQueue* system
   ||preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29346] Real-time holds queue update

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||30728


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728
[Bug 30728] Allow real-time holds queue opt-out
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_22_05_candidate
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||fridolin.som...@biblibre.co
   ||m,
   ||jonathan.druart+koha@gmail.
   ||com,
   ||n...@bywatersolutions.com
 Depends on||29346


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
[Bug 29346] Real-time holds queue update
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30728] New: Allow real-time holds queue opt-out

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728

Bug ID: 30728
   Summary: Allow real-time holds queue opt-out
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Somehow, the patchset got an initially developed piece that made it optional
lost. Probably my fault on some submission.

We need to add that back.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30422] Authorities editor update broke the feature added by Bug 20154

2022-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422

Owen Leonard  changed:

   What|Removed |Added

 Attachment #132800|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 134822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134822=edit
Bug 30422: Authorities editor update broke the feature added by Bug 20154

This patch corrects JavaScript in authorities templates so that
clicking "Edit" on the authority detail page will take you to the
authority edit page while keeping the same tab open.

This patch also corrects the JavaScript which should have been
automatically moving the cursor focus to the first form field when
switching tabs in the editor.

This patch also adds the "Section" headings which are present in the
basic cataloging editor but were not added here at the time of the
page's tabs revision.

To test, apply the patch and locate an authority record in your catalog.

- Without changing tabs, choose "Edit record" from the "Edit" dropdown
  menu."
- The authorities editor should load and display the "Section 0" tab.
- Return to the authority detail page and select a tab besides tab 0.
- Click back to tab 0. Editing the record at this point should open the
  editor to Section 0.
- Return to the authority detail page.
- Click any of the numbered tabs besides tab 0.
- Choose "Edit record" from the "Edit" dropdown menu.
- When the authorities edit page loads the same tab should be
  preselected.
- Test that when you switch tabs in the authority editor the cursor
  focus is automatically moved to the first visible input.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >