[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #11 from Alex Buckley --- (In reply to Marcel de Rooy from comment #10) > (In reply to David Cook from comment #8) > > I think making the koha-* scripts more in line with Linux services is a very > > good reason though. I'm sure it would spare many sysadmins many headaches... > > Sounds like a good reason. Will change title and hope for some additional > patches. Thanks for your thoughts Marcel and David. Please correct me if I'm misunderstanding, but I should amend the files below, making the restart function in each stop and then start the service? - koha-indexer - koha-sip - koha-worker - koha-z3950-responder - koha-zebra Also, do you think I should still write to the mailing list to see if there is a broader community consensus, or just proceed with the above? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 --- Comment #1 from Alex Buckley --- Created attachment 135088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135088=edit Bug 30797: Add the calendar.inc include to addbiblio.tt addbiblio.tt throws the '$(...).flatpickr is not a function' because it is missing includes to flatpickr.min.js and shortcut-buttons-flatpickr.min.js To fix this the addbiblio.tt should include the calendar.inc file (like additem.tt does) which includes to those aforementioned JS files. Test plan: 1. Edit a MARC bibliographic framework 2. Make the 902$d subfield visible in the Editor 3. Also set the 902$d subfield plugin='dateaccessioned.pl' 4. Catalogue a new biblio record 5. Notice the 902$d subfield has not been pre-populated with todays date 6. Right click, choose 'Inspect', observe this JS error in the console: "Uncaught TypeError: $(...).flatpickr is not a function" 7. Apply patch, and restart services 8. Repeat steps 4-6 and this time observe the 902$d is pre-populated, and there is no flatpickr JS error in the console Sponsored-by: Chartered Accountants Australia and New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 --- Comment #8 from Aleisha Amohia --- Created attachment 135087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135087=edit Bug 30700: (follow-up) Add system preference StaffLoginResetPassword This syspref wraps around the functionality added for patrons with the 'catalogue' permission to reset their own password via the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30797] New: Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Bug ID: 30797 Summary: Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl By default the dateaccessioned.pl cataloguing value builder is linked to the 952$d subfield. When the additem.pl page loads the 952$d is pre-populated with today's date. However, some libraries link the dateaccessioned.pl cataloguing value builder plugin to subfields displayed in the addbiblio.pl (biblio cataloguing page). For example, 902$d. When you load the addbiblio.pl page those subfields are not pre-populated with today's date. Instead in the console you get the following JavaScript error: Uncaught TypeError: $(...).flatpickr is not a function -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786 David Nind changed: What|Removed |Added Text to go in the||This fixes the descriptions release notes||for the AdvancedSearchTypes ||and OpacAdvancedSearchTypes ||system preferences - ||sentence case is now used ||for "..Shelving ||location..". Keywords||Manual --- Comment #3 from David Nind --- Apologies Owen, I hadn't noticed that you had assigned this one to yourself! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786 David Nind changed: What|Removed |Added Assignee|oleon...@myacpl.org |da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786 --- Comment #2 from David Nind --- Created attachment 135086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135086=edit Bug 30786: Fix capitalization in advanced search system preferences This fixes the capitalization in the descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. Test plan: 1. In the staff interface, search the system preferences for 'AdvancedSearch'. 2. Review the current descriptions for the AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences. 3. Note that "..Shelving Location.." is used instead of "..Shelving location..". 4. Apply the patch. 5. Refresh the page. 6. Sentence case is now used for "Shelving location" in the descriptions (as per coding guideline HTML4: Upper and lower cases in strings). 7. Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30742] Confusion when placing hold on record with no items available because of not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30730 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25232] Add ability to skip triggering holds with a given notforloan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25232 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30730 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25184] Items with a negative notforloan status should not be captured for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25184 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30730 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25184, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25232, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30742 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #7 from David Nind --- I originally started this an FYI note, but I think someone with a better knowledge of Koha needs to review this and decide what needs to be done, if anything. I'm a little confused with the terminology used. My current understanding: You can place a record-level hold or an item-level hold for items that have a negative not for loan value. This seems to be a feature rather than a bug, whatever the logical part of my brain thinks! The development version of the manual (which is not up-to-date) says for NOT_LOAN (Not for loan) authorised values, that: "- Negative number values will still allow holds (use for ‘on order’ statuses, for example) - Positive numbers will not allow holds or checkouts. - A value of 0 means ‘for loan’." https://koha-community.org/manual/22.05/en/html/administration.html#existing-values-label Reference: https://koha-community.org/manual/22.05/en/html/administration.html#existing-values-label (as the manual isn't up-to-date, this may no longer be the current situation) I also came across the SkipHoldTrapOnNotForLoanValue system preference: "This system preference is used to completely exclude items with ‘not for loan’ values from filling holds." This was added in 20.11 and back ported to 20.05 in bug 25232 - from the description "this .. prevents items with that notforloan value from triggering holds at checkin, allowing for a temporary quarantine or any other circumstance in which an item should be temporarily delayed from circulation. This presents a more customizable alternative to the existing TrapHoldsOnOrder system preference.". Reference (search the page for the system preference name): https://koha-community.org/manual/22.05/en/html/circulationpreferences.html From this, it would seem that: - You should be able to place holds for items with a 'Not for hold' status with a negative value. (Confirmed by testing master) - These should show up on the holds to pull list. (This is the current behaviour before this bug). - If you don't want holds to be placed on 'not for loan' items, then make these values greater than 0. For example, if you don't want holds placed on items that are on order, make the value greater than 0. I originally thought that you should be able to put that value in the SkipHoldTrapOnNotForLoanValue , but as per bug 25232 it wasn't intended for this scenario and doesn't work. Where to from here? Some options/ideas - not exhaustive: 1. Option 1: make 'Not for loan' setting make more sense (minimal effort): - update the documentation for the 'not for loan' authorised value section and system preferences SkipHoldTrapOnNotForLoanValue to clarify that: . use not for loan authorised values greater than 0 if you don't want holds to be placed, or conversely don't allow negative numbers or holds to be placed on items not for loan . use negative not for loan authorised values where items are not for loan (the logic of allowing holds on items not for loan escapes me, and I find it really confusing!) - update the default data for Koha so that the 'Ordered' value is greater than 0: that is, if it is not for loan as it is on order then you can't place holds by default; provide some SQL queries to update any existing 'Ordered' values that are negative - update the description for the SkipHoldTrapOnNotForLoanValue to clarify that this is only for when items are checked in and the scenario it is intended for => end result: holds to pull should work as intended and needs no change 2. Option 2: rethink how to implement this: . To me, if an item is 'Not for loan' then you should not be able to place holds on these items. . If you want to be able to override an item that is 'Not for loan' then maybe have a system preference OverrideNotForLoan or something similar that does what SkipHoldTrapOnNotForLoanValue does, except for placing holds. I think that this a pattern we use elsewhere in Koha. 3. Option 3: identify or ask the Koha Community for the scenarios where you may want to allow holds on items that are not for loan, and then go from there. I hope I haven't confused things even more! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3935] Schedule tasks periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Lari Taskula changed: What|Removed |Added Attachment #135084|0 |1 is obsolete|| --- Comment #8 from Lari Taskula --- Created attachment 135085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135085=edit Bug 3935: Add support for recurring scheduled tasks Tools->Task scheduler lacked the ability to repeatedly execute tasks. This patch adds such functionality. It adds a new parameter "--recurring" to misc/cronjobs/runreport.pl After runreport.pl is executed and if --recurring is provided, we will now schedule a new task with the same parameters. To test: 1. Navigate to Tools->Task scheduler 2. Observe there is nothing that allows you to repeatedly execute the task 3. Apply patch 4. Refresh Tools->Task scheduler page 5. Observe new field "Recurring every" ... "minutes/hours/days..." 6. Check current server time 7. Add current server time + 1 minute to "Time" field 8. Add "1 minutes" to "Recurring every" field 9. Select a saved report (if you don't have one, create a new one) 10. Add your email address to "Email" 11. Click "Save" 12. Observe new row at "Jobs already entered" section and note down given datetime 13. Wait one minute 14. Refresh Tools->Task scheduler page 15. Observe updated row at "Jobs already entered" section, it should now have datetime + 1 minute of what you observed at step 12 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3935] Schedule tasks periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Lari Taskula changed: What|Removed |Added Attachment #135083|0 |1 is obsolete|| --- Comment #7 from Lari Taskula --- Created attachment 135084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135084=edit Bug 3935: Add support for recurring scheduled tasks Tools->Task scheduler lacked the ability to repeatedly execute tasks. This patch adds such functionality. It adds a new parameter "--recurring" to misc/cronjobs/runreport.pl After runreport.pl is executed and if --recurring is provided, we will now schedule a new task with the same parameters. To test: 1. Navigate to Tools->Task scheduler 2. Observe there is nothing that allows you to repeatedly execute the task 3. Apply patch 4. Refresh Tools->Task scheduler page 5. Observe new field "Recurring every" ... "minutes/hours/days..." 6. Check current server time 7. Add current server time + 1 minute to "Time" field 8. Add "1 minutes" to "Recurring every" field 9. Select a saved report (if you don't have one, create a new one) 10. Add your email address to "Email" 11. Click "Save" 12. Observe new row at "Jobs already entered" section and note down given datetime 13. Wait one minute 14. Refresh Tools->Task scheduler page 15. Observe updated row at "Jobs already entered" section, it should now have datetime + 1 minute of what you observed at step 12 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3935] Schedule tasks periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 --- Comment #6 from David Cook --- (In reply to Lari Taskula from comment #5) > (In reply to Katrin Fischer from comment #3) > > Hi, the main problem is bug 1993, that needs to be resolved first. Please > > understand that this will need funding and/or resources in order to move > > forward. > > I just noticed this comment and the dependent Bug 1993 and I agree with what > is discussed there. I'll leave the above patch here in case anyone finds it > useful, but Bug 1993 seems like the correct way to go. That's cool! However, it's unlikely that I'll ever work on it at my day job, and I haven't been doing much Koha coding at night since 2020. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #110 from David Cook --- (In reply to Jonathan Druart from comment #100) > > Patch pushed to master. Is anyone using this in production? BibLibre perhaps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3935] Schedule tasks periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi --- Comment #5 from Lari Taskula --- (In reply to Katrin Fischer from comment #3) > Hi, the main problem is bug 1993, that needs to be resolved first. Please > understand that this will need funding and/or resources in order to move > forward. I just noticed this comment and the dependent Bug 1993 and I agree with what is discussed there. I'll leave the above patch here in case anyone finds it useful, but Bug 1993 seems like the correct way to go. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I thought I had this problem until I applied Bug 29381. Looking at the notice below, I don't see why it would be showing in the errors section? Or is there a difference between "too_soon" and "auto_too_soon"? (I've found the autorenewals in general to be such a source of headaches, although I like the feature concept overall.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3935] Schedule tasks periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 --- Comment #4 from Lari Taskula --- Created attachment 135083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135083=edit Bug 3935: Add support for recurring scheduled tasks Tools->Task scheduler lacked the ability to repeatedly execute tasks. This patch adds such functionality. It adds a new parameter "--recurring" to misc/cronjobs/runreport.pl After runreport.pl is executed and if --recurring is provided, we will now schedule a new task with the same parameters. To test: 1. Navigate to Tools->Task scheduler 2. Observe there is nothing that allows you to repeatedly execute the task 3. Apply patch 4. Refresh Tools->Task scheduler page 5. Observe new field "Recurring every" ... "minutes/hours/days..." 6. Check current server time 7. Add current server time + 1 minute to "Time" field 8. Add "1 minutes" to "Recurring every" field 9. Select a saved report (if you don't have one, create a new one) 10. Add your email address to "Email" 11. Click "Save" 12. Observe new row at "Jobs already entered" section and note down given datetime 13. Wait one minute 14. Refresh Tools->Task scheduler page 15. Observe updated row at "Jobs already entered" section, it should now have datetime + 1 minute of what you observed at step 12 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30794] 'Default checkout, hold and return policy' overrides Unlimited holds in 'Default checkout, hold policy by patron category'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Fridolin Somers changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30611] Add ability to trigger a patron password reset from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 Fridolin Somers changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #26 from Fridolin Somers --- In the end, bug 27619 was pushed. All good here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30695] Checkouts and holds count display in tab could be better in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30695 --- Comment #12 from Fridolin Somers --- (In reply to Martin Renvoize from comment #11) > Fix attached, tested and pushed as rm assist :) Great thanks ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30520] Command line stage and import broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 --- Comment #12 from David Cook --- (In reply to David Cook from comment #6) > Oh interesting... I found the web based MARC stage and import broken in > 21.11 as well. I'm starting to look into it... Turns out it wasn't broken after all. It was just silently hiding an item import error. Bug 30738 helped clear that up... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 David Nind changed: What|Removed |Added Attachment #135075|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 135082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135082=edit Bug 30730: Unit tests Added an entry in holds for an item with negative notforloan value to test if get_items_that_can_fill returns the right items. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30796] Standardize CRUD HTML forms to use 1 controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30796 --- Comment #1 from David Cook --- Note though that this isn't a priority for me. I figured I'd add it here as it's an idea that has been in my head for years, and it's better to share it with all of you than keep it to myself. I think with Koha we are often working harder rather than working smarter, and I think this would help us work smarter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 David Nind changed: What|Removed |Added Attachment #135074|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 135081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135081=edit Bug 30730: Holds to Pull should not list items with a notforloan status Remove items with a notforloan value other than 0 because items that are potentially holdable (with negative notforloan status) are not wanted in holds to pull. Test plan: 1- Have a bib with 2 items, both holdable. Give one of these items a notforloan status with a negative value (like Ordered in the testing docker data). 2- Place a title-level hold on your bib 3- Confirm your bib is showing on Holds to Pull as expected, prompting staff to pull the item that does not have a not for loan status (correct!) 4- Take the item that does not have a not for loan status and check it out to a different patron, make sure not to fill or cancel your hold 5- Reload Holds to Pull, see your title is still listed and now Koha is directing staff to the item with a notforloan status 6- Apply the patch 7- Reload Holds to Pull, see your title with a notforloan status is gone 8- Run `prove t/db_dependent/Koha/Holds.t` and all tests should pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30796] New: Standardize CRUD HTML forms to use 1 controller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30796 Bug ID: 30796 Summary: Standardize CRUD HTML forms to use 1 controller Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org I would love it if we only had 1 controller for handling the input from CRUD HTML forms. At the moment, we have hundreds of different Perl scripts for CRUD operations where the logic is embedded in the Perl controller scripts and not the underlying Perl model modules. Having so many controller scripts means it's difficult to make system-wide changes. Whether changes are made manually or automatically it, it also increases the chance of errors, since you're having to make so many changes (to Perl code or HTML templates). When you have the 1 standard controller, you can use the same base template, the same base error handling, etc. You take advantage of the DRY principle to make old code easier to maintain and you make it easier to add new code. You can put your base code in a base Perl module, subclass it, and then only make the modifications you need to make for special cases. -- I work on other PHP and Perl projects that use this model and it's so much nicer. Of course, a similar alternative is something along the lines of Bug 30225. I'd be happy for there to be a standard Vue3 based form that used the APIs to handle CRUD. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30795 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30795] Configure unwanted and mandatory borrower fields based on patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30795 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13188 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30795] New: Configure unwanted and mandatory borrower fields based on patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30795 Bug ID: 30795 Summary: Configure unwanted and mandatory borrower fields based on patron category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be nice if there were a way to specify different unwanted and mandatory fields based on patron category (rather than enforcing 1 rule for all different patron categories). At the moment, I see libraries putting in junk data (like '-' or 'N/A') to get around mandatory field requirements where it doesn't make sense for certain patron categories. It makes sense to have a default rule for these fields, and then individual patron categories could be overwritten with more specific rules. -- I suppose the difficulty at the moment is that we don't choose a patron category until we're already on the add patron screen. Maybe we should be making it a multi-step process. That would have its pros and cons of course. Actually, this reminds me of another thought I've had where we could standardize CRUD forms... but I'll open another bug for that... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #42 from David Cook --- I know it's too late, but I was thinking the other day that it would be nice to be able to have different mandatory fields for different patron types. The reason being that I've seen libraries workaround mandatory fields for some patron categories by inserting junk data (like '-' or 'N/A'). Of course, using a system preference for a default set of mandatory fields makes sense. Anyway, just food for thought. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--- Comment #3 from David Nind ---
Testing notes using koha-testing-docker:
1. I used the Firefox addon RESTr to test.
2. Place two holds in the staff interface.
3. Change the username and password for a staff patron.
4. List the holds using the REST API and note down the hold_ids:
- Method: GET
- URL: http://127.0.0.1/8080/api/v1/holds/
- Authentication: use koha + koha for basic authentication (or give the
staff patron used Add, modify and view patron information (borrowers) access so
they can view the list of holds)
5. Suspend a hold (where {hold_id} is one of the holds listed in step 3 and
-MM-DD is a future date):
- Method: POST
- URL: http://127.0.0.1:8080/api/v1/holds/{hold_id}/suspension
- Authentication: staff patron with place_holds permission
- Body (JSON):
{
"end_date": "-MM-DD"
}
6. Cancel a hold (where {hold_id} is one of the holds listed in step 3):
- Method: DELETE
- URL: http://127.0.0.1:8080/api/v1/holds/{hold_id}
- Authentication: staff patron with place_holds permission
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 --- Comment #2 from David Nind --- Created attachment 135080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135080=edit Bug 30780: Librarians with only "place_holds" permissions can not update holds data via REST API This patch enables librarians with only "place_holds" permissions to cancel, suspend and resume holds via REST API. Test plan: 1) Try to cancel or suspend a hold with only "place_holds" permissions 2) See that it is forbidden. 3) Apply the patch 4) Cancel a hold again 5) The cancellation succeeds 6) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Lucas Gass changed: What|Removed |Added Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30794] 'Default checkout, hold and return policy' overrides Unlimited holds in 'Default checkout, hold policy by patron category'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Sara Brown changed: What|Removed |Added Summary|Default checkout, hold and |'Default checkout, hold and |return policy overrides |return policy' overrides |Unlimited holds in 'Default |Unlimited holds in 'Default |checkout, hold policy by|checkout, hold policy by |patron category'|patron category' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30794] New: Default checkout, hold and return policy overrides Unlimited holds in 'Default checkout, hold policy by patron category'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Bug ID: 30794 Summary: Default checkout, hold and return policy overrides Unlimited holds in 'Default checkout, hold policy by patron category' Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbr...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If holds for a patron category are set to Unlimited in 'Default checkout, hold policy by patron category' but a holds limit exists in 'Default checkout, hold and return policy', the latter will apply. To recreate: -Set max holds at 5 for Patron Category A in 'Default checkout, hold policy by patron category' -Set max holds at 2 in 'Default checkout, hold and return policy' -Attempt to place multiple holds for a patron in category A - you will be stopped on the 6th hold. -Change max holds to Unlimited for Patron Category A in 'Default checkout, hold policy by patron category' -Keep 'Default checkout, hold and return policy' at 2 max holds -Attempt to place multiple holds for that patron - you'll be stopped after the 2nd hold (In the test above, the circulation matrix has an Patron Category A/All item types max of 10 holds.) This appears to apply in 21.05 and 21.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30726] Flatpickr's "yesterday" shortcut doesn't work if entry is limited to past dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30726 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- +1, most patrons do not want to know about the 'too_soon' error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 --- Comment #6 from Lucas Gass --- Seems to work well everywhere including Syndetics, LibraryThing, and Novelist. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 Lucas Gass changed: What|Removed |Added Attachment #134795|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 135079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135079=edit Bug 30570: Replace the use of jQueryUI tabs in OPAC templates This patch switches to Bootstrap tabs anywhere in the OPAC where jQueryUI tabs were used. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the item type/collection/shelvinglocation tabs on the advanced search page. Test that it works correctly with different variations of the OpacAdvancedSearchTypes system preference. - Search for an authority record and view the details. The "Notes" tab should be styled correctly. - Locate a bibliographic record and view the detail page. Verify that tabs are working, including all the options: - Holdings - Other holdings ( If OpacSeparateHoldings is enabled) - Descriptions ( MARC notes ) - Subscriptions - Serial collection (UNIMARC, untested) - Components ( If ShowComponentRecords is enabled. Link to sample record: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 ) - Comments - Editions (OPACFRBRizeEditions) - Html5media ( If HTML5MediaEnabled is on. Link to sample records: (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685) - Images ( If OPACLocalCoverImages is enabled ) Bonus points for testing these tabs for which I don't have credentials: - Syndetics TOC - Syndetics Excerpt - Syndetics Reviews - Syndetics AuthorNotes - LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView set to "in tabs." - NovelistSelect - Check tabs on these patron-related pages: - Checkout history - Search history - Patron summary. The following tabs are ✓ Checkouts ✓ Relatives' checkouts ✓ Overdues ✓ Fines ✓ Relatives' fines ✓ Holds ✓ Recalls ✓ Article requests ✓ Overdrive Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30729] Template toolkit comments are caught in the translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30729 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel --- Many strings are analyzed and extracted using misc/translator/xgettext.pl. It has a way to detect strings that wants to keep and which to discard. Normally a line with pure TT ( ^[%.*%]$/ ) is discarded, but it reacts quickly to anything resembling an HTML tag. In this case the TT comment [%# Display a complex patron search form %] [%# - Search: %] [%# You can then pass a list of filters %] [%# - branch: %] [%# - category: %] [%# - search_field: %] [%# - search_type: %] is using things inside <.*>, and poor xgettext.pl is confused. Changing the comment to [%# Display a complex patron search form %] [%# - Search: "input" %] [%# You can then pass a list of filters %] [%# - branch: "select library list" %] [%# - category: "select patron category list" %] [%# - search_field: "select patron field list" %] [%# - search_type: "select 'contain' or 'start with'"> %] eliminates the confusion and preserves, I think, the spirit of the comment, and fixes the problem. To test: cd misc/translator mkdir test cp ../../koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc test/. echo test/patron-search.inc > test.list ./xgettext.pl -f test.list -s -o test.po The file test.po contains those strange strings, from the comment. Edit test/patron-search.inc changing the comment as suggested, repeat the last run and check that the strange strings are gone. It's either that or teach new skills to xgettext.pl I haven't been able to find any other cases that didn't come from that file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30774] Typo: i %sEdit %sReserve %s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Lucas Gass changed: What|Removed |Added Attachment #135059|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 135078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135078=edit Bug 30774: Typo: i %sEdit %sReserve %s This patch removes an out of place "i" and replaces it with a space. The patch also removes obsolete CDATA markers in the page's JavaScript. To test, apply the patch and go to Course reserves. - Create a course if necessary, then view the details of your course. - Click the "Add reserves" button. - Enter a barcode or biblionumber. - On the next page, the heading "Reserve [title] for [course]" should look correct, with no extra "i" at the beginning of the line. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30774] Typo: i %sEdit %sReserve %s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30761] Typo: PLease
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30761 David Nind changed: What|Removed |Added Attachment #135069|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 135077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135077=edit Bug 30761: Fix typos in OPAC reset password template This patch corrects the word "PLease" to "Please." The patch also adds some periods at the end of some alert strings to make punctuation consistent between different alerts. To test, an inspection of the patch is probably enough. The main fix (the "PLease") only appears when an unknown error occurs. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30761] Typo: PLease
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30761 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30772] Terminology: Replace instances of "reserve" with "hold"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- For the last change in the patch "Sorry, you are too young to reserve this material.", I think this should read as "Sorry, you are too young to place a hold for this item." instead of "Sorry, you are too young to hold this material." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30783] not loading the web page- http://landfill.bugzilla.org/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30783 Owen Leonard changed: What|Removed |Added Resolution|FIXED |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30783] not loading the web page- http://landfill.bugzilla.org/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30783 Sena changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30783] not loading the web page- http://landfill.bugzilla.org/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30783 Sena changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30792] Item cover images don't load in "Other holdings" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29184] Warn from chargelostitem when no replacement cost set for item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29184 Nick Clemens changed: What|Removed |Added Attachment #125798|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 135076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135076=edit Bug 29184: Fix warn about undefined replacecost This patch simply sets the cost to 0 if undefined To test: 1 - Create a new item with no replacement cost set 2 - Check the item out to a patron 3 - Mark the item lost 4 - Note in plack-intranet-error.log: [2021/10/06 12:43:26] [WARN] Use of uninitialized value $replacementprice in numeric gt (>) at /kohadevbox/koha/C4/Accounts.pm line 114. 5 - Apply patch 6 - Repeat 7 - No warn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30315] Calendar widget in staff interface no longer translates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 --- Comment #5 from Owen Leonard --- I think the root of the problem is that locale data isn't being loaded by the template because the "lang" variable is getting overwritten at some point. I think this is related to: Bug 24661 - Inclusion of locale-related javascript files is broken and Bug 29684 - Warning File not found: js/locale_data.js Without the correct "lang" template variable the link to the correct locale_date file is bad: /intranet-tmpl/prog/fr-FR/js/locale_data_20.1118000.js -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Shi Yao Wang changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 --- Comment #4 from Shi Yao Wang --- Created attachment 135075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135075=edit Bug 30730: Unit tests Added an entry in holds for an item with negative notforloan value to test if get_items_that_can_fill returns the right items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 --- Comment #3 from Shi Yao Wang --- Created attachment 135074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135074=edit Bug 30730: Holds to Pull should not list items with a notforloan status Remove items with a notforloan value other than 0 because items that are potentially holdable (with negative notforloan status) are not wanted in holds to pull. Test plan: 1- Have a bib with 2 items, both holdable. Give one of these items a notforloan status with a negative value (like Ordered in the testing docker data). 2- Place a title-level hold on your bib 3- Confirm your bib is showing on Holds to Pull as expected, prompting staff to pull the item that does not have a not for loan status (correct!) 4- Take the item that does not have a not for loan status and check it out to a different patron, make sure not to fill or cancel your hold 5- Reload Holds to Pull, see your title is still listed and now Koha is directing staff to the item with a notforloan status 6- Apply the patch 7- Reload Holds to Pull, see your title with a notforloan status is gone 8- Run `prove t/db_dependent/Koha/Holds.t` and all tests should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30714] Checkins from other branches spam the cataloguing log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #7 from Nick Clemens --- To me CataloguingLog implies changes made during cataloging, that is changes to a record by a person - not changes made second-hand as in circulation, and I don't think this is the correct place to maintain this information I could be convinced that 'ReturnLog' should record the return, hence the branch update, even if item not issued, but I think that would be a separate bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Failed QA --- Comment #17 from Sally --- I really like the redesign - it's very clear and user friendly. It all works perfectly, except if the staff make a mistake and do the following: - Place a hold for a patron - Choose 'Place a hold on a specific item' - Fail to choose an item - Just press the 'Place hold' button beneath 'Place a hold on a specific item' (#hold_item_btn) The hold is now placed for pick up at a blank library. If you check an item in to fill the hold, Koha presents an error page, e.g. Can't call method "branchcode" on an undefined value at /kohadevbox/koha/Koha/Item.pm line 683 On the current version of Koha, if the staff press this button (#hold_item_btn) without selecting an item, the hold defaults to being a bib level hold where the pick up library is the logged in library (as if they'd pressed: #hold_any_btn) It'd be good if the 'Place hold' button for 'Place a hold on a specific item' could be blanked out until a specific item has been chosen. Alternatively, maybe the pick up location drop down could go back into the 'Hold details' section at the top of the page - so then it can still fall back to a bib level hold if it's pressed without selection, but it would still be given a location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Shi Yao Wang changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com ||, shi-yao.w...@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30793] C4::Biblio PrepHostMarcField and prepare_host_field functions should be merged and migrated to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30793 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21469 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30793 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30793] C4::Biblio PrepHostMarcField and prepare_host_field functions should be merged and migrated to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30793 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30793] New: C4::Biblio PrepHostMarcField and prepare_host_field functions should be merged and migrated to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30793 Bug ID: 30793 Summary: C4::Biblio PrepHostMarcField and prepare_host_field functions should be merged and migrated to Koha::Biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org I propose we add a 'add_marc_host' method to Koha::Biblio and use it to replace both PrepHostMarcField and prepare_host_field methods in C4::Biblio. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26261] Split calendar.inc into include file and JavaScript file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 Katrin Fischer changed: What|Removed |Added Blocks|30315 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 [Bug 30315] Calendar widget in staff interface no longer translates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30315] Calendar widget in staff interface no longer translates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 Katrin Fischer changed: What|Removed |Added Depends on|26261 | --- Comment #4 from Katrin Fischer --- Confirmed it's broken in 20.05.05 which the patch was first included to. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 [Bug 26261] Split calendar.inc into include file and JavaScript file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26261] Split calendar.inc into include file and JavaScript file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 Katrin Fischer changed: What|Removed |Added Blocks||30315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 [Bug 30315] Calendar widget in staff interface no longer translates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30315] Calendar widget in staff interface no longer translates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 Katrin Fischer changed: What|Removed |Added Depends on||26261 --- Comment #3 from Katrin Fischer --- Trying to narrow this down a bit. Git bisect turned up this as the breaking commit: commit 701fde53ed703c751e37fd184de342838e8a9f2f Author: Owen Leonard Date: Thu Aug 20 20:10:40 2020 + Bug 26261: Split calendar.inc into include file and JavaScript file Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 [Bug 26261] Split calendar.inc into include file and JavaScript file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26145] Add the ability to attach a cover image at item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Owen Leonard changed: What|Removed |Added Blocks||30792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792 [Bug 30792] Item cover images don't load in "Other holdings" tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30792] New: Item cover images don't load in "Other holdings" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792
Bug ID: 30792
Summary: Item cover images don't load in "Other holdings" tab
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleon...@myacpl.org
Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 26145
If you have SeparateHoldings enabled and item-level local cover images on the
items which appear under the "Other holdings" tab, these covers will not load.
Line 1154 of detail.tt:
if( $(coverSlide).find(".cover-image:visible").length < 1 ){
This doesn't consider the possibility of correctly-loaded cover image under a
hidden tab. Removing the ":visible" seems to fix it.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145
[Bug 26145] Add the ability to attach a cover image at item level
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790
--- Comment #5 from Julian Maurice ---
(In reply to Tomás Cohen Arazi from comment #4)
> No, that's why I say I regret not finding the time to provide a generic
> solution... Namely, a pair of Koha::Objects methods for tweaking the 'embed'
> structure and queries
I just noticed that I can do
GET /api/v1/biblios?q={"isbn": "1-23-456789-0"}
without the "biblioitem." prefix and it works too. So... is there something
else needed ? (except updating the tests and commit messages to reflect that)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30315] Calendar widget in staff interface no longer translates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 Katrin Fischer changed: What|Removed |Added Summary|Calendar widget no longer |Calendar widget in staff |translates |interface no longer ||translates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 Owen Leonard changed: What|Removed |Added Attachment #134979|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 135073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135073=edit Bug 30747: Make column settings work for otherholdings table To test: 1. Turn on SeparateHoldings and find a record that has some items at different home libraries. 2. Look at the Other holdings(x) tab. Notice there is no Columns tool (gear icon). 3. Go to Table Settings, try hiding columns from the otherholdings table. You cannot. 4. Apply patch. 5. Now under the Other holdings(x) tab you should see the Columns button, it should work. 6. Go back to Table settings and try hiding columns, it should work. 7. Now try uploading an item level cover image, make sure all columns are still properly hidden and the Columns tool works 8. Try steps 6 & 7 but with the regular holdings table. Confirm that all colums can properly hide. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30315] Calendar widget no longer translates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 --- Comment #2 from Katrin Fischer --- In 20.11.18 I still have the problem, in our package based installations, but also on my kohadevbox. Any clues much appreciated. Tested with de-DE and the date of birth in put on the patron form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Nick Clemens changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Julian Maurice from comment #3) > (In reply to Tomás Cohen Arazi from comment #2) > > We have hidden the biblioitem table from the API. I regret not having spent > > time on a more generic solution yet... > > > > Take a look at... Orders.pm when it comes to filtering by biblio.* > > It looks like Koha/REST/Plugin/Objects.pm was duplicated inside > Koha::REST::V1::Orders::list > ... is it what we are supposed to do ? :/ No, that's why I say I regret not finding the time to provide a generic solution... Namely, a pair of Koha::Objects methods for tweaking the 'embed' structure and queries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #3 from Julian Maurice --- (In reply to Tomás Cohen Arazi from comment #2) > We have hidden the biblioitem table from the API. I regret not having spent > time on a more generic solution yet... > > Take a look at... Orders.pm when it comes to filtering by biblio.* It looks like Koha/REST/Plugin/Objects.pm was duplicated inside Koha::REST::V1::Orders::list ... is it what we are supposed to do ? :/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30791] Make it possible to use basket information in ACQORDER subjects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30791 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- Marking as a bug fix because of the 'promise' of bug 21898 :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21898] Add basket info to ACQORDER
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Katrin Fischer changed: What|Removed |Added Blocks||30791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30791 [Bug 30791] Make it possible to use basket information in ACQORDER subjects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30791] New: Make it possible to use basket information in ACQORDER subjects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30791 Bug ID: 30791 Summary: Make it possible to use basket information in ACQORDER subjects Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 21898 A lot of libraries would like to add the basketname or the order number to the email subject of ACQORDER. The test plan on bug 21898 included the case, but it doesn't appear to work. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 [Bug 21898] Add basket info to ACQORDER -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21898] Add basket info to ACQORDER
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Katrin Fischer changed: What|Removed |Added Summary|Add basket info available |Add basket info to ACQORDER |for ACQORDER| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #2 from Tomás Cohen Arazi --- We have hidden the biblioitem table from the API. I regret not having spent time on a more generic solution yet... Take a look at... Orders.pm when it comes to filtering by biblio.* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790
--- Comment #1 from Julian Maurice ---
Created attachment 135072
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135072=edit
Bug 30790: Add REST API route to list biblios
Examples:
GET /api/v1/biblios
GET /api/v1/biblios?q={"me.title": "foo"}
GET /api/v1/biblios?q={"biblioitem.isbn": "1-23-456789-0"}
GET /api/v1/biblios?_order_by=title
Test plan:
1. Try requesting this endpoint with your favorite API tool
2. Run `prove t/db_dependent/api/v1/biblios/list.t`
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Julian Maurice changed: What|Removed |Added Depends on||30790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 [Bug 30790] Add REST API route to list biblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] New: Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 Bug ID: 30790 Summary: Add REST API route to list biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: REST API Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com CC: tomasco...@gmail.com Blocks: 17371 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 [Bug 17371] Add routes for biblios [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #3 from Katrin Fischer --- After discussing with Joubu we agreed the fix should not change things, there is also: my $amount = 0; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #2 from Katrin Fischer --- Suspensions have a different rule for their interval, so it's not about this here. I think maybe we need to treat empty/null as 0, because with your fix the fine I believe the fine might not be recalculated. Use case would be: - There is an older fine > 0 - Library changes circulation rules to fine = 0 - fines.pl is rerun and reduces existing fines to 0 This works now (we have used it) and it should work after fixing the warn as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 --- Comment #1 from Nick Clemens --- Created attachment 135071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135071=edit Bug 30789: Improve performance of AddBiblio AddBiblio calls TransformMarcRecordToKoha. We are only interested in getting biblio and biblioitems info, so we can pass 'no_items' to save some field lookups Additionally we can pass the subfield structure we have already fetched into the subroutine TransformMarcToKohaOneField Testing with NYTProf I saw a reduction of ~6 seconds when importing ~400 bibs and ~1000 items i.e. I exported and imported the sample data (after removing duplicate 010 from record 72) To test: 1 - Stage and import some records 2 - Confirm it works the same before and after patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30709] 'Insert' button in notices editor not adding selected placeholders to notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30709 Owen Leonard changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Owen Leonard changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Owen Leonard changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
