[Koha-bugs] [Bug 13388] Add library pages to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 David Cook changed: What|Removed |Added Blocks||30873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30873 [Bug 30873] "Libraries" link on OPAC should be hideable by system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30873] "Libraries" link on OPAC should be hideable by system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30873 David Cook changed: What|Removed |Added Depends on||13388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 [Bug 13388] Add library pages to the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30873] New: "Libraries" link on OPAC should be hideable by system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30873 Bug ID: 30873 Summary: "Libraries" link on OPAC should be hideable by system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Most of my libraries don't want to show the "Libraries" link on the OPAC. While you can hide it using Javascript, it's not a very elegant solution. There should be a system preference to hide it (like every other option on that nav bar besides "Advanced search"). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30327] Sort component parts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #8 from David Nind --- From IRC - oleonard, there is a component parts sample record attached to bug 11175 http://irc.koha-community.org/koha/2022-06-01#i_2427405 If you are using koha-testing-docker to sign off, these are the steps I normally use (once .env file for koha-testing-docker is setup with Bugzillar information) - this is so that your sign-off is added to the patch, and appears on the dashboard: 1. git bz apply bug-number 2. Test and make sure things work as per the test plan. 3. git so 1 4. git bz attach -e bug-number HEAD~1.. 5. Remove the # in front of the signoff line (note that there is text added after the test plan, for example: "Signed-off-by: David Nind "), the :wq Notes: - If more than one patch, change: . git so 1 to the number of patches, for example: git so 2 . HEAD~1.. to the number of patches, for example: HEAD~2.. - see my cheat sheet https://gitlab.com/-/snippets/1893788 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23548] AQ field required in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- I'm not familiar with SIP2, but I would like to test. Are you able to provide a test plan similar to bug 26871 or bug 20517? Ideally with the commands to give, and the responses expected. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30327] Sort component parts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 Michal Urban changed: What|Removed |Added CC||michalurban...@gmail.com Status|Needs Signoff |Signed Off --- Comment #7 from Michal Urban --- Testing procedure: - Enabled ShowComponentRecords - Added 3 child records to record "E Street" - There were varying biblionumbers for the child records, in the details of "E Street" they were not displayed in ascending biblionumber order, instead in the order they were attached. - Applied patch and refreshed page - Child record components displayed by ascending biblionumber order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
CC||da...@davidnind.com
--- Comment #3 from David Nind ---
I get this message when trying to apply the patch (using koha-testing-docker) -
I think that this means the patch isn't correctly formatted, but I could be
wrong:
git bz apply 29607
Bug 29607 - addorderiso2709: The stored discount when importing an order from a
file is invalid
128127 - Patch for the bug 29607
Apply? [(y)es, (n)o, (i)nteractive] y
Traceback (most recent call last):
File "/usr/bin/git-bz", line 2716, in
applied = do_apply(bug_ref)
File "/usr/bin/git-bz", line 1827, in do_apply
users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher]
})['users']
File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__
return self.__send(self.__name, args)
File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request
verbose=self.__verbose
File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request
return self.single_request(host, handler, request_body, verbose)
File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request
response.msg,
xmlrpclib.ProtocolError:
Testing notes
~
The QA Team will probably want the commit message formatted according to
https://wiki.koha-community.org/wiki/Commit_messages I have drafted a test
plan, based on the comments in the bug description.
Bug 29607: Store the discount amount correctly when importing and order from a
file
This bug fixes how the discount amount for an order is stored, when an order is
added to a basket using "From staged MARC records".
Test plan:
1. Export a record (without the items) (Tools > Catalog > Export data).
2. Delete the record from the catalog (including any items).
3. Stage the record for import (Tools > Catalog > Stage MARC records for
import).
4. Create a new vendor with a discount of 25%. (Or select and existing vendor
that has a discount). (Acquisitions > New vendor)
5. Create a new basket for the vendor. (Acquisitions > Manage orders > search
for vendors > New > Basket).
6. Add to the basket using "From a staged file":
. select "Add orders" next to the staged file
. select the record to add to the order
. enter a price
. leave the discount field blank
. select a fund
. select "Save"
==> The order is created!
7. Modify the order - note that the discount is showing on the form as .25%
instead of 25%, also note that the discount amount is calculated correctly.
8. Check what is recorded in the database:
. koha-mysql kohadev
. select * from aqorders;
==> discount field for the basket item shows as 0.2500
9. Change the discount to 25%. Run step 8 again - discount amount will be
correctly shown as 25.
10. Apply the patch.
11. Repeat steps 1-9 - discount amount is shown and calculated correctly.
12. Test modifying the discount amount - should be calculated and shown
correctly.
13. Sign off!
See additional comments in the bug description.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30182] background_jobs.status should be an ENUM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30182 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #20 from David Cook --- One last thing... we might want to rename this issue to be "Cache effective circulation rules" because that would be more accurate than "Cache circulation rules". We're not just saving a database call by caching. We're saving a database call that has embedded logic in it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #19 from David Cook --- (In reply to Jonathan Druart from comment #15) > I think this is the correct approach, what do you think? Since we are clearing the cache via set_rule, there's probably no harm in using the L2 cache via Koha::Cache. Nick has already signed off this version though, and I think this one is good enough for now at least. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #18 from David Cook --- (In reply to Jonathan Druart from comment #15) > I think this is the correct approach, what do you think? I'm not 100% sure. I find that the code in ./admin/smart-rules.pl and Koha/CirculationsRules.pm is very messy. If we clear the cache after each set_rule() call, we'll be calling the function ~38 times (so 38 loops) for each add/update/delete in ./admin/smart-rules.pl. We should only need to call it 1 time for each CRUD operation. In terms of core code, it looks like Koha::CirculationRules->set_rule only gets called in Koha/CirculationRules.pm and once accidentally in ./admin/smart-rules.pl (it should use set_rules instead). We do call set_rule() a lot in the unit tests though. I suppose occasional inefficient cache setting/clearing in ./admin/smart-rules.pl is worth a performance speed up during frequent transactional work. In fact, since we're using the L1 cache and the L1 cache is flushed at the end of every HTTP/SIP request, clearing the cache (in ./admin/smart-rules.pl) is actually probably totally unnecessary for production purposes. The only time caching of circulation rules would be a potential problem is in the unit tests. So I'd say the cache clearing is messy but it's good enough. (Side note: the circulation_rules table has an "id" column, so we should be using that for for distinct update_rules/delete_rules operations.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #7 from David Nind --- The patch no longer applies 8-(... Also, just checking my understanding what is required here for testing. Is it that when adding to a basket "From a new (empty) record", that for the catalog details section the item type should be shown regardless of the setting for the item-level_itypes system preference? This is so that the record created has an item type, and it is not empty (which can cause issues elsewhere in Koha if it is NULL). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Just checking what is required here, as I'm not sure how it displays now f there are 580 entries and how it should display after the patch is applied. I'm not that familiar with authorities, so I'm not really sure how they should be "correctly" displayed. Screenshots of before and after would help. For me, if I add some 580 entries: - Displays in the summary column as "See also" and then the entries with a space between them. - This is the same before and after the patch is applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #2 from David Nind --- Status changed to Failed QA because of 3 and 4. Testing notes (koha-testing-docker): 1. I added some values to 952$h for a couple of items for some records. 2. Using the item search, the column "Serial enumeration" is now shown, and values entered show - the sorting and filtering also works. 3. Export results to: for CSV - column header is exported, but data is not (used Vol X Issue X in items, as well as just a plain number). 4. Reviewing the patch, for a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt line 327, "items_barcode" is used as the id for the table heading - should this be something else? 5. Found it interesting that the CSV is exported with a semicolon as the separator, I can log this as another bug if you think it is necessary. 5. Alternatively (and probably a bigger change) is to configure what columns are shown using data tables, and also let the columns be selected and configured using Administration > Additional parameters > Table settings. For example, like the holdings table in the view details view for a record. I'm not sure how this works, but I imagine it would be a lot more work. If this was changed, it could also use the Export function which gives additional options, but I'm not sure how you would get the barcode export. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #16 from Lucas Gass --- > But when I change a patron's password when logged in as a superlibrarian I'm > redirected to the main page rather than back to their account. This is the behavior I get as well. When I reset someone else's password as a superlibrarian I am redirected back to the staff main page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
|ity.org |
--- Comment #5 from David Nind ---
Testing notes (using koha-testing-docker):
1. I amended the second patch for the advanced editor to add a full stop at the
end of the sentence ("..controlled by Leader/06.") - maybe I should have done
as a follow-up?
2. I changed the assignee to Nick.
A nice clarification and improvement!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 David Nind changed: What|Removed |Added Attachment #135494|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 135518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135518=edit Bug 30871: Add notes in advanced cataloging editor This is the same as preevious patch, but for advanced cataloging editor To test: 1 - Enable EnableAdvancedCatalogingEditor 2 - Create a new record in advanced edtior 3 - Hover over leader6 and 008 type 4 - Confirm notes are useful Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 David Nind changed: What|Removed |Added Attachment #135493|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 135517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135517=edit Bug 30871: Add/expand title text for LDR/06 and 008 Type of material This patch simply adds title elements or clarifies existing title elements to indicate how default values are chosen To test: 1 - Create new record in default editor 2 - Open leader helper, hover over "6-Type of record" and the dropdown 3 - Confirm notes make sense 4 - Open 008 helper 5 - Hover over 'Type of Material' and dropdown 6 - Confirm notes make sense Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30539] Koha upgrade error "Column 'claimed_on' cannot be null"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Testing notes (using koha-testing-docker): - I haven't tested an upgrade from 17.x to 21.x. - I have reviewed the patch and comments - the change resolved the upgrade issue experienced, comments on the original bug. Feel free to change status back to needs sign off, or provide some feedback on how to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30539] Koha upgrade error "Column 'claimed_on' cannot be null"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539 David Nind changed: What|Removed |Added Attachment #135464|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 135516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135516=edit Bug 30539: (bug 24161 follow-up) Fix typo in DBrev Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30539] Koha upgrade error "Column 'claimed_on' cannot be null"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30844] The OPAC detail page's browser is limited to the current page of results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30844 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30837] Fix table width on 'Print summary'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 David Nind changed: What|Removed |Added Text to go in the||This fixes the width of the release notes||table for the print summary ||so that it fits the width ||of the page. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30855] Rename /import => /import_batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30855 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |vic...@tuxayo.net |.com| Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30855] Rename /import => /import_batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30855 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135413|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 135515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135515=edit Bug 30855: (follow-up) Rewrite tests using Basic authentication Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30870] Don't skip tests if Test::Deep is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30870] Don't skip tests if Test::Deep is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #135513|0 |1 is obsolete|| --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 135514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135514=edit Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30870] Don't skip tests if Test::Deep is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 David Nind changed: What|Removed |Added Attachment #135483|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 135513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135513=edit Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30870] Don't skip tests if Test::Deep is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #204 from Shi Yao Wang --- (In reply to Jonathan Druart from comment #196) > Can you please review the whole patch set carefully to make it ready for QA? > > It took me 3 min to catch trivial errors: > * merge marker > +<<< HEAD > > * installer/data/mysql/nb-NO/2-Valgfritt/patron_categories.sql > has been removed, this patch set reintroduce it > > * in members/memberentry.pl there are 2 calls to search_with_library_limits > > * still memberentry.pl > You are adding yet another fetch of the patron category: > Koha::Patron::Categories->find > It's fetched several times already in the same script > > * t/db_dependent/Patrons.t l.206: extra spaces Fixed mentioned errors except "Koha::Patron::Categories->find". It would require a new variable near the beginning of the script (after "my $categorycode ...") that stores "Koha::Patron::Categories->find($categorycode)" and would also require changing every place where the script uses it for consistency. I don't know if it's a good idea to do it here. Maybe a separate bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850 --- Comment #6 from Caroline Cyr La Rose --- (In reply to Marcel de Rooy from comment #5) > but we should probably inform them about this choice by printing an > informational message from a dbrev (atomic update). Sorry, I have no idea what that means. Please explain like I'm 5. > Please add also something in Release notes. Done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850 Caroline Cyr La Rose changed: What|Removed |Added Text to go in the||This enhancement maps 110$a release notes||(corporate author in ||MARC21) to biblio.author in ||the default framework. ||Having the corporate author ||in biblio.author ensures it ||will appear wherever the ||author usually appears in ||the staff interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Attachment #135509|0 |1 is obsolete|| --- Comment #203 from Shi Yao Wang --- Created attachment 135512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135512=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali Signed-off-by: Salman Ali Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Attachment #134936|0 |1 is obsolete|| --- Comment #202 from Shi Yao Wang --- Created attachment 135511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135511=edit Bug 12446: Fixing QA tool's tests This patch fixes tests that fails by the QA test tool. I removed the debug variable, since it is not used. I also got a few spelling check errors when I ran the QA test tool. I corrected them too. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass 17) Run the QA test tool. All tests should say OK Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Attachment #134935|0 |1 is obsolete|| --- Comment #201 from Shi Yao Wang --- Created attachment 135510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135510=edit Bug 12446: Any patron categories can have guarantors Rebase of previous patches This patch allows adult patrons to have guarantors. It adds the field "Can be guarantee" to patron categories, so it becomes possible for any category type to have a guarantor. NOTE: Attachment "Bug 12446: Adult can now have guarantors" created a sha1 error. I marked it as obsolete and put it's content into a new commit. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Attachment #134934|0 |1 is obsolete|| --- Comment #200 from Shi Yao Wang --- Created attachment 135509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135509=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali Signed-off-by: Salman Ali Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Attachment #134933|0 |1 is obsolete|| --- Comment #199 from Shi Yao Wang --- Created attachment 135508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135508=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Attachment #134932|0 |1 is obsolete|| --- Comment #198 from Shi Yao Wang --- Created attachment 135507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135507=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang changed: What|Removed |Added Attachment #134931|0 |1 is obsolete|| --- Comment #197 from Shi Yao Wang --- Created attachment 135506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135506=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #15 from Jonathan Druart --- Created attachment 135505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135505=edit Bug 20511: Remove translation support for short version of season Everything get messy when we translate "Sum", then "Summer" as it's a substring. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511
Jonathan Druart changed:
What|Removed |Added
Attachment #130751|0 |1
is obsolete||
Attachment #133107|0 |1
is obsolete||
--- Comment #14 from Jonathan Druart ---
Created attachment 135504
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135504=edit
Bug 20511: Make seasons translatable in prediction pattern
The season is stored in the DB in English and but not translated when
displayed on the interface.
This patch will translate the different seasons and their short form
('Spr' for 'Spring').
Test plan:
Update the PO of the language you like
Edit po/xx-XX-messages.po and translate the season names
Setup a new language and use it for the staff interface
Create a new subscription using the "Seasonal" subscription pattern
Generate new serial items and confirm that the seasons are correctly
translated when displayed
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #8 from Jonathan Druart --- (In reply to Nick Clemens from comment #4) > (In reply to Jonathan Druart from comment #3) > > Nick, extra '.' or extra space? > > It looks good without the dot Thanks for your quick response! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #7 from Jonathan Druart --- (In reply to Séverine Queune from comment #5) > (In reply to Jonathan Druart from comment #3) > > Nick, extra '.' or extra space? > > To me, it's an information not a sentence so dot didn't seem necessary. > I can change that if you prefer, though, Jonathan. I don't care, I am happy with both :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Jonathan Druart changed: What|Removed |Added Attachment #135458|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 135503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135503=edit Bug 29312: Remove unnecessary dot This patch removes an extra point after the number of shown results. Test plan : - don't apply patch - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio LIMIT 50 - see extra ' .' after the number of shown results - apply patch - run the report again and see the point isn't displayed anymore - check the behaviour is still correct when you change the number of rows displayed - sign off ! Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30039] Add published_on column to missing issues table on claims.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 --- Comment #4 from Lucas Gass --- (In reply to Jonathan Druart from comment #3) > Isn't this table already too large? Shouldn't we add the table settings then? We should add table settings, yes. I filed Bug 30872. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30872] New: Table on claims.tt ( missing issues table ) should be column configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30872 Bug ID: 30872 Summary: Table on claims.tt ( missing issues table ) should be column configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Bug 30039 adds another column to an already large table in claims.tt. That table should be column configurable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #196 from Jonathan Druart --- Can you please review the whole patch set carefully to make it ready for QA? It took me 3 min to catch trivial errors: * merge marker +<<< HEAD * installer/data/mysql/nb-NO/2-Valgfritt/patron_categories.sql has been removed, this patch set reintroduce it * in members/memberentry.pl there are 2 calls to search_with_library_limits * still memberentry.pl You are adding yet another fetch of the patron category: Koha::Patron::Categories->find It's fetched several times already in the same script * t/db_dependent/Patrons.t l.206: extra spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #17 from Jonathan Druart --- Created attachment 135502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135502=edit Bug 26377: Simplify JS code Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #16 from Jonathan Druart --- Created attachment 135501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135501=edit Bug 26377: Show when loading the page if needed Prevent a blink Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Jonathan Druart changed: What|Removed |Added Attachment #135455|0 |1 is obsolete|| Attachment #135491|0 |1 is obsolete|| Attachment #135492|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 135500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135500=edit Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart changed: What|Removed |Added Summary|Moment.js is deprecated |Replace Moment.js with ||Day.js Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #5 from Jonathan Druart --- Created attachment 135499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135499=edit Bug 30310: Adjust about page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #4 from Jonathan Druart --- Created attachment 135498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135498=edit Bug 30310: Remove momentjs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #3 from Jonathan Druart --- Created attachment 135497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135497=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #2 from Jonathan Druart --- Created attachment 135496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135496=edit Bug 30310: Add dayjs timezone plugin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #1 from Jonathan Druart --- Created attachment 135495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135495=edit Bug 30310: Add dayjs v1.11.2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 --- Comment #2 from Nick Clemens --- Created attachment 135494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135494=edit Bug 30871: Add notes in advanced cataloging editor This is the same as preevious patch, but for advanced cataloging editor To test: 1 - Enable EnableAdvancedCatalogingEditor 2 - Create a new record in advanced edtior 3 - Hover over leader6 and 008 type 4 - Confirm notes are useful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 --- Comment #1 from Nick Clemens --- Created attachment 135493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135493=edit Bug 30871: Add/expand title text for LDR/06 and 008 Type of material This patch simply adds title elements or clarifies existing title elements to indicate how default values are chosen To test: 1 - Create new record in default editor 2 - Open leader helper, hover over "6-Type of record" and the dropdown 3 - Confirm notes make sense 4 - Open 008 helper 5 - Hover over 'Type of Material' and dropdown 6 - Confirm notes make sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30871] New: Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 Bug ID: 30871 Summary: Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 --- Comment #14 from Owen Leonard --- Created attachment 135492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135492=edit Bug 26377: Simplify JS code Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl that relate to optional item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Owen Leonard changed: What|Removed |Added Attachment #135479|0 |1 is obsolete|| Attachment #135480|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 135491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135491=edit Bug 26377: Show when loading the page if needed Prevent a blink Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #24 from Kyle M Hall --- (In reply to Jonathan Druart from comment #16) > To clarify: we should have class methods, from classes that don't inherited > from Koha::Object[s]. > > Something like > Koha::Policy::Reserves::holds_control_library($item, $patron) > > (or that would take the ids if we don't want to fetch the objects prior to > the call) I think as a solution that would be sufficient but not necessary. If we always need to have both object to resolve the answer, it's just arbitrary to choose the item, the patron, or some third party as the "holder" of the method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #23 from Tomás Cohen Arazi --- Setting IN DISCUSSION to avoid confusion. We need to come up with a better design for this business stuffs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Slava Shishkin changed: What|Removed |Added CC|slavashish...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #22 from Jonathan Druart --- What are your opinions on the discussion, Kyle? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #21 from Kyle M Hall --- Created attachment 135490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135490=edit Bug 30825: Remove GetReservesControlBranch in favour of Koha::Item->holds_control_library This patch removes the GetReservesControlBranch method, and replaces its uses with the newly introduced method. To test: 1. Apply this patch 2. Verify that placing holds from the OPAC works => SUCCESS: Things work as expected 3. Run: $ kshell k$ prove t/db_dependent/Reserves* \ t/db_dependent/Hold* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #20 from Kyle M Hall --- Created attachment 135489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135489=edit Bug 30825: Add Koha::Item->holds_control_library This simple method takes care of calculating the control branch for an item and a patron, depending on a syspref. It targets replacing C4::Reserves::GetReservesControlBranch To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Kyle M Hall changed: What|Removed |Added Attachment #135275|0 |1 is obsolete|| Attachment #135276|0 |1 is obsolete|| Attachment #135277|0 |1 is obsolete|| Attachment #135281|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 135488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135488=edit Bug 30825: Add unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30837] Fix table width on 'Print summary'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #5 from Séverine Queune --- (In reply to Jonathan Druart from comment #3) > Nick, extra '.' or extra space? To me, it's an information not a sentence so dot didn't seem necessary. I can change that if you prefer, though, Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30837] Fix table width on 'Print summary'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30831] Add unit test for BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30831 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Passed QA |Pushed to master --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 pierre.ge...@biblibre.com changed: What|Removed |Added CC||pierre.ge...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30830] Add Koha Objects for Koha Import Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30830 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Version(s)||22.11.00 released in|| QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Status|Passed QA |Pushed to master --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Passed QA |Pushed to master CC||tomasco...@gmail.com Version(s)||22.11.00 released in|| --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 22.11, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #15) > IMO this does not belong to Koha::Item. We are making our Koha objects grow > and it will be a nightmare soon. > This is not the responsibility of the item object, it must go on separate > modules. I agree. We talked about it with Martin as we felt it didn't belong here. > I don't have something clear to suggest right now. I have asked a couple of > months ago to have a wider discussion about those naming/namespace/etc but > it didn't move much (cannot remember the bug report however). It'd be interesting to find it. I like what they are doing here about availability: https://github.com/NatLibFi/koha-plugin-rest-di/tree/main/Koha/Plugin/Fi/KohaSuomi/DI/Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy --- QA Comment: I am still missing something here. What we do, is making sure that new installs will map 110a too. But we do not care about the existing installs. I understand that we might not dictate this setting to all these installs, but we should probably inform them about this choice by printing an informational message from a dbrev (atomic update). Please add also something in Release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29282] Show items.issue and items.renewals in the holdings table on the detail page in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 --- Comment #11 from Nick Clemens --- (In reply to Victor Grousset/tuxayo from comment #10) > Is there a reason to use the classes issues_field and renewals_field for the > values when the other columns don't have the _field prefix? There doesn't > seem to be a name clash in the file with issues and renewals. > > Otherwise everything looks good for QA. I think those classes already has associated styles, and this was just a way to differentiate the view on this page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > Nick, extra '.' or extra space? It looks good without the dot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com --- Comment #2 from Jonathan Druart --- This will be a pain to implement, but it's worth the hassle. We are basically going to remove a lot of our dt_from_string, output_pref and $KohaDates occurrences. $KohaDates will be needed for display purpose only (not in flatpickr's input). We are going to retrieve the iso-formatted date from the DB, send it to the template, and retrieve the iso-formatted date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 --- Comment #1 from Jonathan Druart --- Created attachment 135487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135487=edit Bug 30718: POC - Use flatpickr's altInput -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717 Jonathan Druart changed: What|Removed |Added CC||nay...@mes.ac.in --- Comment #11 from Jonathan Druart --- *** Bug 30659 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30659] Date acquired is not working in 21.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30659 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||jonathan.druart+koha@gmail. ||com --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 30717 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28723] Holds table not displayed when it contains a biblio without title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #12 from Jonathan Druart --- Created attachment 135486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135486=edit Bug 28723: Replace "No title" by an empty string This is to be consistent with what is done in checkouts.js Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28723] Holds table not displayed when it contains a biblio without title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Jonathan Druart changed: What|Removed |Added Attachment #135452|0 |1 is obsolete|| Attachment #135484|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 135485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135485=edit Bug 28723: Fix holds table display when a biblio has no title Test plan: 1. Create a biblio without title, then create an item for this biblio. 2. Place a hold on it. 3. Go to the patron detail page and click on the Holds tab 4. Confirm that holds are correctly displayed Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28723] Holds table not displayed when it contains a biblio without title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28723] Holds table not displayed when it contains a biblio without title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28723 --- Comment #10 from Julian Maurice --- Created attachment 135484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135484=edit Bug 28723: Replace "No title" by an empty string This is to be consistent with what is done in checkouts.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Jonathan Druart changed: What|Removed |Added Depends on||29883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 [Bug 29883] Uninitialized value warning when GetAuthorisedValues gets called with no parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
