[Koha-bugs] [Bug 30893] typo: update_patrons_category.pl fine(s)

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30893

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
I amended the patch to fix a couple of minor things:

- -fo and -fu: extra spaces before update (so they line up with the other
items), removed space for -fo between "..over X.."

- -too_young: removed extra space between age and current

- --from and --to: changed to sentence case so now "*Required* Defines.."
instead of "*required* defines.."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30893] typo: update_patrons_category.pl fine(s)

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30893

David Nind  changed:

   What|Removed |Added

 Attachment #135677|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 135698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135698=edit
Bug 30893: Fix documentation in update_patrons_category.pl

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30893] typo: update_patrons_category.pl fine(s)

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30893

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844

--- Comment #52 from Andrew Nugged  ---
pls ignore previous comment - it's the wrong code (another branch :) ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844

--- Comment #51 from Andrew Nugged  ---
A-a-a-and one more:

File: C4/XSLT.pm
464: my %branches = map { $_->branchcode => $_->branchname }
Koha::Libraries->search({}, { order_by => 'branchname' });

->

my %branches = map { $_->branchcode => $_->branchname }
Koha::Libraries->search({}, { order_by => 'branchname' })->as_list;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

David Nind  changed:

   What|Removed |Added

 Blocks||29734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823

David Nind  changed:

   What|Removed |Added

 Blocks||29734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295

David Nind  changed:

   What|Removed |Added

 Blocks||29734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

David Nind  changed:

   What|Removed |Added

 Depends on||30885, 30823, 30295

--- Comment #4 from David Nind  ---
I've added some of the related recalls bugs. Feel free to remove if this
omnibus bug is no longer being used.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295
[Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823
[Bug 30823] Recalls should use 'FILL' in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885
[Bug 30885] Recall - detail page explosion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

David Nind  changed:

   What|Removed |Added

 Blocks||29734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876

David Nind  changed:

   What|Removed |Added

 Blocks||29734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

David Nind  changed:

   What|Removed |Added

 Depends on||30876, 30886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876
[Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search
in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886
[Bug 30886] Recall status cannot be correct on opac-detail
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876

David Nind  changed:

   What|Removed |Added

 Blocks||30877


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877
[Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

David Nind  changed:

   What|Removed |Added

 Blocks||30877


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877
[Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877

David Nind  changed:

   What|Removed |Added

 Depends on||30876, 29734

--- Comment #4 from David Nind  ---
Added bug 30876 as a dependency, otherwise I could not test properly.

Also added the new omnibus bug 29734 for recalls as well. Feel free to remove
if this is not being used.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876
[Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search
in list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes using koha-testing-docker:

0. Applied bug 30876 so that the "Recalls to pull" page works.
1. Enable the UseRecalls system preference and set up recalls-related
circulation rules.
2. Check out an item to Patron A where there are multiple items (I checked out
an item for Intermediate Perl to Mary Burton).
3. Log into the OPAC as Patron B and search for the item (I used Henry
Acevedo).
4. Place a recall on that item (I placed a record-level recall for Intermediate
Perl).
5. Go back to the staff interface and check the item in. Confirm the recall as
waiting for Patron B (Henry).
6. Access the "Recalls to pull" page (Circulation > Recalls) - this should work
as expected (display the recall).
7. Apply patch, restart services, refresh the OPAC.
8. Confirm that the "Recalls to pull" page is still working correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877

David Nind  changed:

   What|Removed |Added

 Attachment #135537|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 135697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135697=edit
Bug 30877: use List::MoreUtils::uniq from recalls_to_pull.pl

Test plan:
Confirm that "Recalls to pull" is still working correctly

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #1 from Caroline Cyr La Rose  ---
You can compare with what it used to look like in the screen captures in the
manual :
https://koha-community.org/manual/21.11/en/html/tools.html#edit-quotes-for-qotd-feature

Upload page (step 3) :
https://koha-community.org/manual/21.11/en/html/_images/importquotes.png

Editing quotes (step 4) :
https://koha-community.org/manual/21.11/en/html/_images/editquote.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
Testing notes (using koha-testing-docker):

1. Not that this is in the test plan, but if you view the detail page for the
record in the staff interface, you get this error:

Template process failed: undef error - The method Koha::Recall->waitingdate is
not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x559a26d7a8a0)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
line 522
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
line 522
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
line 633

2. This is fixed when bug 30876 and bug 30885 are applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] New: CSV import of quotes broken

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Bug ID: 30903
   Summary: CSV import of quotes broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 135696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135696=edit
CSV file with quotes to test the import feature

I think the CSV quote import feature is broken...

To test:

1- Download the attached csv or create a comma-separated csv with two columns,
one for source and one for text (no headers)
2- Go to Tools > Edit quotes for QOTD feature
3- Click on Import quotes
--> Note that the layout of the page is a bit strange... there is a big space
between the title of the page and the first content box, and there is no space
above the browse button
4- Click browse and choose the CSV file
--> The quotes should be imported in an editable table, you can click on either
the source or text of a quote to change it (on my browser the editable field is
really small, I wonder if it's the page or my browser (Firefox) or my OS
(Ubuntu))
5- Click Save quote
--> Nothing happens

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

David Nind  changed:

   What|Removed |Added

 Attachment #135636|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 135695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135695=edit
Bug 30886: Show pending recall on item on OPAC

The 'completed' flag was causing the wrong status to be shown, but we
can also give a more useful message to the patron.

To test:
1) Enable the UseRecalls system preference and set up your
recalls-related circulation rules.
2) Check out an item to Patron B.
3) Log into the OPAC as Patron A and search for the item.
4) Place a recall on that item.
5) Go back to the staff client and check the item in. Confirm the recall
as waiting for Patron A.
6) Go back to the OPAC record page and look at the holdings table.
Notice the status still says the item is Available.
7) Apply patch, restart services, refresh the OPAC.
8) Confirm the holdings table status now says the item has a pending
recall.

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in modborrowers.tt breaks the form sending

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in modborrowers.tt breaks the form sending

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135682|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 135694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135694=edit
Bug 30884: Fix jQuery selector to correctly detect active tab

To reproduce:
1. Go to /tools/modborrowers.pl and fill form Card number list with data and
click Continue.
2. It should give "No patron card numbers or borrowernumbers given." warning.
3. Using the browser inspector tool see that post fields cardnumberlist or
borrowernumberlist
   is sent with empty data.

Apply the patch, and then:
1. Fill form Card number or Borrowernumber list and click Continue.
2. Get the result: table with patrons for editing or warning about not found
number.
3. Using the inspector tool see that request has data from the active tab in
the form.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in modborrowers.tt breaks the form sending

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #37 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #36)
> Rough test plan - Jonathan, at one point you switch from item.onloan to
> item.checkout - do we need this extra fetch? onloan both tells us if checked
> out, and provides due date

Maybe because onloan is only the date, but doesn't have the time?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords|Manual  |
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29200] Remove Adlibris cover service

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords|Manual  |
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28494] Can't enable plugins on a new instance of Koha

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
   Keywords|Manual  |

--- Comment #5 from Caroline Cyr La Rose  ---
It's not in the manual anymore

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28373] Items fields not used in default XSLT

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
   Keywords|Manual  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
   Keywords|Manual  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27944] Add new stages to the article request process

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords|Manual  |
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #36 from Nick Clemens  ---
Rough test plan - Jonathan, at one point you switch from item.onloan to
item.checkout - do we need this extra fetch? onloan both tells us if checked
out, and provides due date

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #35 from Nick Clemens  ---
1 - View details.pl for a record - confirm barcode link takes you to correct
page and other info displays correctly
2 - Add several records to a cart - find a mix with and without items
3 - Confirm the records display correctly the location and branchcodes in the
cart
4 - Setup SMTP using your email. For gmail:
Create app password:
 https://support.google.com/accounts/answer/185833?hl=en
Add gmail server to koha-conf
 
smtp.gmail.com
465
60
SSL
koha...@cool.com
expialodotious
0
 
5 - Send cart to yourself and verify branches show name correctly
6 - Enable LocalCoverImages system poreference
7 - Upload an image to a record (from details page, images tab)
8 - Click the image in the tab and confirm it is shown
9 - Set searchenginge system preference to zebra
10 - sudo koha-shell kohadev
11 - perl misc/migration_tools/rebuild_zebra.pl -b -v
12 - confirm searchign for item fields works
13 - Find/create a subscription (Serials->New subscription)
 Ensure in subscription details that:
   Create an item record when receiving this serial 
 is marked
14 - Receive/find an issue with an item, view in opac
15 - Confirm "Vol info" column correctly populated, and other item info
displays as epxectd
16 - Place a reserve on OPAC, make sure to find/create a record with some
holdable and unholdable items, and some items on loan/checked out
17 - Ensure items show correctly in form and hold can be placed
18 - In staff client, view the items tab for a record.
19 - Confirm items show correctly and links are preserved
20 - Confirm item statuses show correctly, including issued items, transit
items, not for loan
21 - Repeat cart tests on the opac, ensure sent cart displays correcttly
22 - On staff client, return to subscription used previously
23 - From subscription details click 'Create routing list'
24 - Add some patrons, and a note, save
25 - Click 'save and preview' and ensure item displays correctly
26 - In the opac, add soem tags to a record (TagsEnabled system preference must
be on, add from details page)
27 - In staff client browse to tools->tags, approve tag, click on term in the
approved list
28 - Confirm items show correctly on the list
29 - Create a list on staff client (add items from search to new list)
30 - Send the list (Lists->clkick list name-> Send list)
31 - Confirm it is ofrmatted correctly
32 - Send list from OPAC and confirm it displays correctlyin email as well

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30902] New: MaxTotalSuggestions clarification

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30902

Bug ID: 30902
   Summary: MaxTotalSuggestions clarification
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If the MaxTotalSuggestions is per patron, and not a limit encompassing all
suggestions submitted, I would suggest that the working on this setting be
updated to reflect this.  It needs to be clarified either way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] date picker automatically fills todays date on cataloging screens

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

--- Comment #14 from Jonathan Druart  ---
I was actually saying I am concerned about reverting a patch that has been
considered an enhancement in the last release. We need feedback from people
involved in bug 29815 to know how we can fit everybody's needs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
Version|21.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135691|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 135693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135693=edit
Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135690|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 135692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135692=edit
Bug 30901: Add Renewals method to CirculationRules template plugin

It would be useful to be able to report renewals used/remaining in some notices
and slips.

Test Plan:
1) Apply this patch
2) Add the following to the RENEWAL notices:
--
[% USE CirculationRules %]
[% SET renewals = CirculationRules.Renewals( borrower.id, item.id ) %]
You have used [% renewals.count %] of [% renewals.allowed %], you have [%
renewals.remaining %] renewals left.
--
3) Trigger a renewal notice
4) Verify the text is correct!

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

--- Comment #5 from Kyle M Hall  ---
Created attachment 135691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135691=edit
Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #135687|0   |1
is obsolete||
 Attachment #135689|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 135690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135690=edit
Bug 30901: Add Renewals method to CirculationRules template plugin

It would be useful to be able to report renewals used/remaining in some notices
and slips.

Test Plan:
1) Apply this patch
2) Add the following to the RENEWAL notices:
--
[% USE CirculationRules %]
[% SET renewals = CirculationRules.Renewals( borrower.id, item.id ) %]
You have used [% renewals.count %] of [% renewals.allowed %], you have [%
renewals.remaining %] renewals left.
--
3) Trigger a renewal notice
4) Verify the text is correct!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #135688|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 135689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135689=edit
Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

--- Comment #2 from Kyle M Hall  ---
Created attachment 135688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135688=edit
Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

--- Comment #1 from Kyle M Hall  ---
Created attachment 135687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135687=edit
Bug 30901: Add Renewals method to CirculationRules template plugin

It would be useful to be able to report renewals used/remaining in some notices
and slips.

Test Plan:
1) Apply this patch
2) Add the following to the RENEWAL notices:
--
[% USE CirculationRules %]
[% SET renewals = CirculationRules.Renewals( borrower.id, item.id ) %]
You have used [% renewals.count %] of [% renewals.allowed %], you have [%
renewals.remaining %] renewals left.
--
3) Trigger a renewal notice
4) Verify the text is correct!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] date picker automatically fills todays date on cataloging screens

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

--- Comment #13 from Andrew Nugged  ---
Benjamin Daeuber: I also support your problem - we have the same issues and
very concerned customers :). So this patch (reverting) is needed.

I suspect Jonathan just said that the ticket patch should be just a reversal of
the previous commit, not a standalone commit.

to Jonathan: please hint Petro on how to make a "reversal".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] New: Add template method to be able to look up renewal data in Koha slips and notices

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

Bug ID: 30901
   Summary: Add template method to be able to look up renewal data
in Koha slips and notices
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be useful to be able to report renewals used/remaining in some notices
and slips.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29963
 Depends on|29963   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963
[Bug 29963] date picker automatically fills todays date on cataloging screens
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] date picker automatically fills todays date on cataloging screens

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

Jonathan Druart  changed:

   What|Removed |Added

Version|21.05   |unspecified
 Blocks|29815   |
 Depends on||29815


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
[Bug 29815] Pre-populate 'Date acquired' field when adding/editing items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

--- Comment #17 from Kyle M Hall  ---
Created attachment 135686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135686=edit
Bug 26689: Check for specific template then fallback - printinvoice

This patch adds a check for a more specific ACCOUNT_DEBIT template
(named to match the debit_type_code of the credit line) prior to
falling back to the ACCOUNT_DEBIT template.

Test plan
1/ On a patrons account page use the print option on a series of debit
lines with differing credit types (Overdue, Payout)
2/ Note that the same template 'ACCOUNT_DEBIT' is used for all types
3/ Apply the patch
4/ Run step 1 again and note all still print using ACCOUNT_DEBIT
5/ Add a new notice template under the 'circulation' module with a code
that matches one of your account debit types (OVERDUE, PAYOUT)
6/ Run step 1 again and note that where you have added a specific notice
for that debit type it has been used.

Signed-off-by: Sally 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #135113|0   |1
is obsolete||
 Attachment #135114|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 135685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135685=edit
Bug 26689: Check for specific template then fallback - printfeercpt

This patch adds a check for a more specific ACCOUNT_CREDIT template
(named to match the credit_type_code of the credit line) prior to
falling back to the ACCOUNT_CREDIT template.

Test plan
1/ On a patrons account page use the print option on a series of credit
lines with differing credit types (Payment, Lost Item Return, Writeoff)
2/ Note that the same template 'ACCOUNT_CREDIT' is used for all types
3/ Apply the patch
4/ Run step 1 again and note all still print using ACCOUNT_CREDIT
5/ Add a new notice template under the 'circulation' module with a code
that matches one of your account credit types (PAYMENT, WRITEOFF,
LOST_FOUND)
6/ Run step 1 again and note that where you have added a specific notice
for that credit type it has been used.

Signed-off-by: Sally 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] date picker automatically fills todays date on cataloging screens

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #135683|0   |1
is obsolete||

--- Comment #12 from Peter Vashchuk  ---
Created attachment 135684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135684=edit
Bug 29963: do not prefill empty date fields with today's date

Revert "Bug 29815: Pre-populate 'Date acquired' field when adding/editing
items"
commit bd197c64567fba6899f12e4897d786adf52384d8

Items date fields in MARC framework with dateaccessioned.pl assigned as
plugin automatically prefilled by it with today's date if empty on page
load.

This becomes big problem because it silently changes empty date fields
in single item edit form with today's date. This drastically degrades
UX because user won't noitce that fields were filled.

Also, even when user aware about this problem, user is forced to clean
the field manually each time they edit items with empty fields.

Also in item batch edit tool the probability heavily increases to make
mistake and leave those fields prefilled on mass.

To reproduce problem with single item edit:
1. Edit single item that doesn't have a date set in any of the date
fields where dateaccessioned.pl in MARC framework assigned as plugin,
see that the field got prefilled with today's date.
2. Save the item. See that it overwrote the previously empty date.
3. Apply the patch.
4. Edit single item again, and ensure that the empty date fields don't
get overwriten like it happened previously.

To reproduce problem with bath edit:
1. Edit items in batch for any biblio, see that the date fields where
dateaccessioned.pl in MARC framework assigned as plugin is automatically
 set to current day's date.
2. Apply the patch.
3. Check the fields again, they should be empty after that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] date picker automatically fills todays date on cataloging screens

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #135674|0   |1
is obsolete||

--- Comment #11 from Peter Vashchuk  ---
Created attachment 135683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135683=edit
Bug 29963: do not prefill empty date fields with today's date

Items date fields in MARC framework with dateaccessioned.pl assigned as
plugin automatically prefilled by it with today's date if empty on page
load.

This becomes big problem because it silently changes empty date fields
in single item edit form with today's date. This drastically degrades
UX because user won't noitce that fields were filled.

Also, even when user aware about this problem, user is forced to clean
the field manually each time they edit items with empty fields.

Also in item batch edit tool the probability heavily increases to make
mistake and leave those fields prefilled on mass.

To reproduce problem with single item edit:
1. Edit single item that doesn't have a date set in any of the date
fields where dateaccessioned.pl in MARC framework assigned as plugin,
see that the field got prefilled with today's date.
2. Save the item. See that it overwrote the previously empty date.
3. Apply the patch.
4. Edit single item again, and ensure that the empty date fields don't
get overwriten like it happened previously.

To reproduce problem with bath edit:
1. Edit items in batch for any biblio, see that the date fields where
dateaccessioned.pl in MARC framework assigned as plugin is automatically
 set to current day's date.
2. Apply the patch.
3. Check the fields again, they should be empty after that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in modborrowers.tt breaks the form sending

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

--- Comment #2 from Slava Shishkin  ---
Created attachment 135682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135682=edit
Bug 30884: Fix jQuery selector to correctly detect active tab

To reproduce:
1. Go to /tools/modborrowers.pl and fill form Card number list with data and
click Continue.
2. It should give "No patron card numbers or borrowernumbers given." warning.
3. Using the browser inspector tool see that post fields cardnumberlist or
borrowernumberlist
   is sent with empty data.

Apply the patch, and then:
1. Fill form Card number or Borrowernumber list and click Continue.
2. Get the result: table with patrons for editing or warning about not found
number.
3. Using the inspector tool see that request has data from the active tab in
the form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in modborrowers.tt breaks the form sending

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Slava Shishkin  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

Juliet Heltibridle  changed:

   What|Removed |Added

 CC||jheltibri...@rcplib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707

Owen Leonard  changed:

   What|Removed |Added

Summary|Having a closing div in |Move container's closing
   |intranet-bottom.inc is  |div tag into template from
   |wrong (?)   |intranet-bottom.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Lucas Gass  changed:

   What|Removed |Added

 Status|BLOCKED |Patch doesn't apply

--- Comment #57 from Lucas Gass  ---
Patch doesn't apply to current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (using koha-testing-docker):

1. Step 5: this should be the staff interface.

2. If there are no transfers required, things all work as expected (that is,
Patron A + B and item are all in the same library).

3. However, if the patrons are in different libraries and transfers are
required, I had an error on the transfers to receive page:
   (a) Used Mary Burton as Patron B (Midway), and Henry Acevedo as Patron A
(Midway), and Programming Perl (record #262).
   (b) Follow the test plan to step 9, then changed library to Midway
   (c) Go to Circulation > Transfers > Transfers to receive
   (d) Get error trace - see details below under errors > 3(d)

4. When cancelling/reverting the hold (after following the test plan to step 9
for a, b, c, and d), I noticed these issues - I presume these should be a
separate bug(s):
   (a) Recalls tab on the item details page (staff interface): nothing happens
when you click on 'Cancel recall and return to Centerville' (can cancel by
clicking the check box and selecting the 'Cancel selected recalls' button).
   (b) Go to Circulation > Recalls > Recalls queue: nothing happens when you
click on 'Cancel recall and return to: Centerville' (can cancel by clicking the
check box and selecting the 'Cancel selected recalls' button).
   (c) Go to the patron details section for Henry and then select the Recalls
tab: nothing happens when you click on Actions > 'Cancel recall and return to:
Centerville'.
   (d) Go to Circulation > Recalls > Recalls to pull > select Cancel recall and
return to: Centerville: get error - see details below under errors > 4(d)

Errors
---

3(d) - Change library to Midway: Circulation > Transfers > Transfers to receive
~~~

Template process failed: undef error - The method Koha::Recall->borrowernumber
is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x5566df86c340)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt
line 93
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt
line 93
.

4(d) - Circulation > Recalls > Recalls to pull > select 'Cancel recall and
return to: Centerville'
~~

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Data truncated for column 'reason' at row 1 at
/kohadevbox/koha/Koha/Object.pm line 170
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

in DBIx::Class::Exception::throw at
/usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords|Manual  |
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815

--- Comment #16 from Marcel de Rooy  ---
(In reply to Benjamin Daeuber from comment #15)
> Jumping in here regarding Bug 29963, but I think prepopulating date acquired
> when editing items is an undesirable behavior. It would need to be cleared
> more often than it would be useful. Makes sense when receiving serials or
> adding new items, but modification and batch modification it's just an
> annoyance.

How easy is it to have the plugin know in which context it works?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756

--- Comment #15 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #14)
> Search.t failing now, the records file was being used there as well
> 
> t/db_dependent/Search.t:
> 277 $mock_zebra->load_records(
> 278 sprintf( "%s/%s/zebraexport/authority", $sourcedir,
> lc($marcflavour) ),
> 279 'iso2709', 'authorities', 1
> 280 );

Will have a look

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in modborrowers.tt breaks the form sending

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Slava Shishkin  changed:

   What|Removed |Added

Summary|Incomplete replace of   |Incomplete replace of
   |jQueryUI tabs in|jQuery UI tabs in
   |modborrowers.tt breaks form |modborrowers.tt breaks the
   |sending |form sending

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQueryUI tabs in modborrowers.tt breaks form sending

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Slava Shishkin  changed:

   What|Removed |Added

 Blocks||29226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Slava Shishkin  changed:

   What|Removed |Added

 Depends on||30884
 CC||slavashish...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884
[Bug 30884] Incomplete replace of jQueryUI tabs in modborrowers.tt breaks form
sending
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

David Nind  changed:

   What|Removed |Added

 Attachment #135631|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 135681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135681=edit
Bug 30885: Display recall data correctly

This page does not pull the recall columns correctly.

To test:
1) Enable the UseRecalls system preference and set up your
recalls-related circulation rules.
2) Check out an item to Patron B.
3) Log into the OPAC as Patron A and search for the item.
4) Place an item-level recall on that item.
5) Go back to the OPAC and search for the item. Confirm that when you go
to the record detail page, it explodes and errors are shown.
6) Apply patch and refresh page.
7) Confirm page loads as expected.
8) Check the Status information for the item in the Holdings table.
Confirm it shows the recall information correctly.
9) Check in the item and confirm the recall as waiting for Patron A.
10) Go back to the record detail page and confirm the Status information
for the item shows as Waiting in the Holdings table.

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30900] New: "Error searching for analytic records"

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30900

Bug ID: 30900
   Summary: "Error searching for analytic records"
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no

Created attachment 135680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135680=edit
Screenshot of error message

On 21.11.05 using Zebra, this message is displayed between the "New", "Edit"
etc buttons, and the title of *some* records: 

  There was an error searching for analytic records, please see the logs for
details.

The logs say: 

==> /var/log/koha/koha/plack-error.log <==
CCL parsing error (10014) Unknown qualifier ZOOM for query:
Host-item=(Psychology and law =) at /usr/share/koha/lib/C4/Search.pm line 242.
Warning from simple_search_compat: 'CCL parsing error (10014) Unknown qualifier
ZOOM' at /usr/share/koha/lib/Koha/Biblio.pm line 540.

For a while I thought the message only displayed for records with a trailing
colon in 245$a, but on looking at more records that does not seem to be the
case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

Peter Vashchuk  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

--- Comment #15 from Peter Vashchuk  ---
Hey David, could you please check this again?

How I reproduced your problems with the patch applied:
- Circulation > Check in: I used " 308098 " and it did work,
it trimmed all trailing whitespaces and found the correct item with the barcode 
I was looking for,
- Circulation > Check out: I used " 308098 " again and again it did 
work, it trimmed all trailing whitespaces and found the correct item.
- Circulation > Renew: I used " 308098 " again, worked as well.
- Course reserves > Add reserves for [course name]: used " 308098 " 
input and it worked here as well.

I also tried different barcodes and they all work while trailing whitespaces
were properly removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30833] Add Preferred language for notices field in memberentry form

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30833

Owen Leonard  changed:

   What|Removed |Added

Version|21.11   |master
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
   Severity|new feature |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614

David Nind  changed:

   What|Removed |Added

 Attachment #135675|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 135679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135679=edit
Bug 13614: Replace usage of YUI on basket groups page

This patch updates the basket groups interface so that it doesn't rely
on YUI to move baskets in and out of groups. The patch also removes
all YUI assets and many long-obsolete references to YUI-related classes
and IDs.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Go to Acquisitions.
- Locate a vendor with multiple closed baskets.
- Click "Basket groups" in the sidebar menu.
- Create or edit a basket group.
- On the basket group page you should see the basket group form in one
  column and ungrouped baskets in another.
- Both grouped and ungrouped baskets should be in a sortable
  DataTable.
- Test that when you click the "Add to group" button on an ungrouped
  basket the row is removed from the table of ungrouped baskets and
  added to the table of grouped baskets.
  - The button text on the row should now read "Remove."
- Test the reverse operation: Clicking "Remove" on a grouped basket
  should move it to the table of ungrouped baskets.
- Test that when all baskets are moved out of either of the tables a row
  is displayed with a message specific to that table, e.g. "There are no
  ungrouped baskets."
- Test that the basket group saves correctly when zero or more baskets
  are added to the group.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828

Arthur Suzuki  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00 22.05 21.11
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815

Benjamin Daeuber  changed:

   What|Removed |Added

 CC||bdaeu...@cityoffargo.com

--- Comment #15 from Benjamin Daeuber  ---
Jumping in here regarding Bug 29963, but I think prepopulating date acquired
when editing items is an undesirable behavior. It would need to be cleared more
often than it would be useful. Makes sense when receiving serials or adding new
items, but modification and batch modification it's just an annoyance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23659] Allow hold pickup location to default to item home branch for item-level holds

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This patch adds a new
  release notes||system preference
   ||'DefaultHoldPickupLocation'
   ||
   ||This preference will allow
   ||the library to determine
   ||which library is the
   ||default for pickup location
   ||dropdowns while placing
   ||holds in the staff client.
   ||The options are logged in
   ||library, homebranch, or
   ||holdingbranch
   ||
   ||Previously
   ||the behavior was
   ||inconsistent, and varied
   ||between versions. Libraries
   ||may need to adjust this
   ||preference after upgrade to
   ||mirror their expected
   ||workflow

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] date picker automatically fills todays date on cataloging screens

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

--- Comment #10 from Benjamin Daeuber  ---
(In reply to Jonathan Druart from comment #8)
> You are then reverting
>   commit bd197c64567fba6899f12e4897d786adf52384d8
>   Bug 29815: Pre-populate 'Date acquired' field when adding/editing items

I can't imagine why you would want date acquired field prepopulated when you
are editing items. Adding items makes sense to me, but not editing. We would
need to clear the field every time we made a small change or batch modified
shelf locations or really any other daily activity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Owen Leonard  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Owen Leonard  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28877] Fix warns in logs when using plural translations

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28877
Bug 28877 depends on bug 26979, which changed state.

Bug 26979 Summary: Show correctly-pluralized labels on checkouts page tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

--- Comment #8 from Owen Leonard  ---
I don't seem to be able to reproduce this bug in master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||arthur.suz...@biblibre.com

--- Comment #16 from Arthur Suzuki  ---
pushed to 21.11.x for 21.11.07, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #24 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #23)
> I think we should invalidate/clean the cache when a new plugin is
> installed/enabled/disabled.
I agree

> You will certainly need the second patch from bug 29623.
I don't think so. There is only one key to flush here, so we don't need the
list of all keys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #23 from Jonathan Druart  ---
I think we should invalidate/clean the cache when a new plugin is
installed/enabled/disabled. You will certainly need the second patch from bug
29623.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

--- Comment #9 from Owen Leonard  ---
Created attachment 135678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135678=edit
Bug 30570: (follow-up) Correct rebase errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #14 from Nick Clemens  ---
Search.t failing now, the records file was being used there as well

t/db_dependent/Search.t:
277 $mock_zebra->load_records(
278 sprintf( "%s/%s/zebraexport/authority", $sourcedir,
lc($marcflavour) ),
279 'iso2709', 'authorities', 1
280 );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30893] typo: update_patrons_category.pl fine(s)

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30893

--- Comment #1 from Nick Clemens  ---
Created attachment 135677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135677=edit
Bug 30893: Fix documentation in update_patrons_category.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30893] typo: update_patrons_category.pl fine(s)

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30893

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #34 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #33)
>
> Great work. We need some priority lane for these things.

This is a priority on this cycle.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >