[Koha-bugs] [Bug 30938] Add column configuration to the acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938 David Nind changed: What|Removed |Added Text to go in the||This fixes the acquisitions release notes||home page to show the ||column configuration ||button. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30938] Add column configuration to the acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938 David Nind changed: What|Removed |Added Attachment #135956|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 135977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135977=edit Bug 30938: Convert ColumnSettings to TableSettings To test: 1. Apply this patch 2. Go to /cgi-bin/koha/acqui/acqui-home.pl 3. The columns button should be restored, make sure you can hide/show columns correctly. 4. Go to Table settings and make sure you can hide columns properly by default. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30938] Add column configuration to the acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 --- Comment #5 from victor --- apparent solution mysql >USE database; mysql >SET foreign_key_checks = 0; mysql > ALTER TABLE recalls CHANGE COLUMN borrowernumber patron_id int(11) NOT NULL DEFAULT 0; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30931] Handling of items.dateaccessioned in the item editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 --- Comment #6 from Alex Buckley --- (In reply to David Nind from comment #5) > Hi Alex. > > I've posted a message on the koha-US cataloguing special interest group > mailing list. > > I hope that will help with getting some feedback. > > David Hi David, Thank you very much! Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 --- Comment #10 from David Nind --- (In reply to Katrin Fischer from comment #9) > Hm, I've tried a reset_all_unimarc on ktd in order to get ready for testing > this, but it doesn't look right: I've found I need to change KOHA_MARC_FLAVOUR=unimarc in the .env file then start up KTD. I've had no luck when starting with a MARC21 system, then using reset_all_unimarc when things are running to get a unimarc system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30949] Error 500 in z3950_search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30949 --- Comment #2 from Manos PETRIDIS --- Created attachment 135976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135976=edit Sample Z39.50 settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30949] Error 500 in z3950_search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30949 --- Comment #1 from Manos PETRIDIS --- Created attachment 135975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135975=edit Apache error log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30949] New: Error 500 in z3950_search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30949 Bug ID: 30949 Summary: Error 500 in z3950_search.pl Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: egpetri...@yahoo.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 135974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135974=edit koha intranet error I wonder how may one debug errors 500 in z3950_search.pl, especially when searching against multiple targets. Searching for ISSN 1061-2688 in the following targets (among many others) host: webcat.lib.unc.edu port: 210 DB: innopac host: afton.lib.unc.edu port: 210 DB: INNOPAC I get the following error: Home Error 500 An error has occurred! Error 500 This message may have been caused by any of the following reasons: You made use of an external link to an item that is no longer available You followed an outdated link e.g. from a search engine or a bookmark You tried to access a page that needs authentication An internal link in the client is broken and the page does not exist What's next? Use top menu bar to navigate to another part of Koha. To report a broken link or any other issue, please contact the Koha administrator. Send email Error logs to be uploaded. Please don't focus on the server mentioned in them, as I located the servers above in previous tries but decided to file a bug report on subsequent searches that produced said error. In different previous searches I've encountered the same problem while searching against targets host: NLS.ALMA.EXLIBRISGROUP.COM port: 210 DB: 44NLS_INST (https://www.nls.uk/catalogues/z39-50/) host: ELIBRARY.MEL.ORG port: 210 DB: INNOPAC for example. Again, these are merely the targets I had managed to narrow down in the past. I noticed that tag 915 is mentioned in the logs (...Field 915 must have at least one subfield...), whereas no such tag is defined in standard koha frameworks such as BKS and SER. Could this be the culprit, data that koha doesn't expect to receive? Those very targets work fine when queried for different books/magazines, so it must be something contained in specific results. The error may also have to do with the fact that all Z39.50 servers defined in my installation have "Del952.xsl,Del9LinksExcept952.xsl" in the "XSLT File(s) for transforming results" field. Both XSLT files are stock, as provided in a packages installation. Some 10 years ago I had made the same question, but got nowhere. https://lists.katipo.co.nz/public/koha/2012-August/033847.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946
--- Comment #4 from victor ---
In addition to presenting an error when trying to restart the bases.
Upgrade to 21.12.00.048 [20:27:10]: Bug 30291 - Renaming recalls table columns
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot drop index
'borrowernumber': needed in a foreign key constraint at
/usr/share/koha/lib/C4/Installer.pm line 739
The interfaces are returning to the installation screen.
https://mydomain/cgi-bin/koha/installer/install.pl?step=1=updatestructure
In Ubuntu 20.04.4 LTS
mysql Ver 15.1 Distrib 10.4.14-MariaDB, for debian-linux-gnu (x86_64) using
readline 5.2
Koha 22.05
Installation with multiple instances
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 --- Comment #12 from Katrin Fischer --- Created attachment 135973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135973=edit Bug 25449: (QA follow-up) Set items.itype to mandatory by default (UNIMARC) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Katrin Fischer changed: What|Removed |Added Attachment #135703|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 135972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135972=edit Bug 25449: Set items.itype mandatory by default Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25449] Make itemtype mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30798] Columns Home library and Checked out from in wrong order on table settings for account_fines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 Katrin Fischer changed: What|Removed |Added Attachment #135109|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 135971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135971=edit Bug 30798: Change column order on account-fines table column settings Columns Home library and Checked out from are in wrong order on table settings. Because of this hiding Home library actually hides Checkout out from column and vice versa. This patch changes order of these columns on columns_settings.yml To test: 1) Navigate to columns settings page and modify account-fines tables column. => Note that if you hide column checked_out_from, column home_library is hidden on patrons account page. 2) Apply patch and restart plack etc. => Column checked_out_from should now be hidden. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30798] Columns Home library and Checked out from in wrong order on table settings for account_fines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30798] Columns Home library and Checked out from in wrong order on table settings for account_fines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30798] Columns Home library and Checked out from in wrong order on table settings for account_fines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30716] Add Collection column to cn_browser results table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30716 Katrin Fischer changed: What|Removed |Added Attachment #134771|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 135970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135970=edit Bug 30716: Add collection to cn_browser results To test: 1. Go to MARC bibliographic framework, pick a framework and go to 952, subfield "o". Turn the cn_browser plugin on. 2. Pick or create an item in that framework, edit that item. 3. TO the right of the 952$o notice the "...". Click that start the call number browser. 4. Notice there is no column for collection. 5. Apply patch, restart_all 6. Notice there is now a column for with the items collection. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30716] Add Collection column to cn_browser results table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30716 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30716] Add Collection column to cn_browser results table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30716 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #34 from Katrin Fischer --- Hi, a bit scared of this one, but got stuck on the first steps. 1) QA tools have some minor complaints: FAIL Koha/Item.pm FAIL spelling wich ==> which OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL t/db_dependent/Circulation.t FAIL spelling iwth ==> with 2) Tests are failing prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 33/60 # Failed test 'The LOST amountoutstanding is the expected amount after partial payment of lost fee' # at t/db_dependent/Circulation.t line 3325. # got: '99' # expected: '60' # Failed test 'Account balance should be zero after returning item with lost fee when partial payment has been made' # at t/db_dependent/Circulation.t line 3343. # got: '-39' # expected: '0' # Failed test 'The LOST amountoutstanding is the expected amount after partial payment of lost fee' # at t/db_dependent/Circulation.t line 3385. # got: '99' # expected: '0' # Failed test 'Account balance is the expected amount after partial payment of lost fee' # at t/db_dependent/Circulation.t line 3390. # got: '-39' # expected: '0' # Failed test 'Account balance should be zero after returning item with lost fee when full payment has been made' # at t/db_dependent/Circulation.t line 3403. # got: '-138' # expected: '0' # Looks like you failed 5 tests of 21. # Failed test 'lostreturn | refund_unpaid' # at t/db_dependent/Circulation.t line 3408. # Looks like you failed 1 test of 5. # Failed test 'enh 23091 | Lost item return policies' # at t/db_dependent/Circulation.t line 3785. # Looks like you failed 1 test of 9. t/db_dependent/Circulation.t .. 34/60 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 3786. t/db_dependent/Circulation.t .. 60/60 # Looks like you failed 1 test of 60. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/60 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 256 Tests: 60 Failed: 1) Failed test: 34 Non-zero exit status: 1 Files=1, Tests=60, 68 wallclock secs ( 0.13 usr 0.01 sys + 49.52 cusr 5.11 csys = 54.77 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #66 from Katrin Fischer ---
This is a really interesting dev I've been often asked about. But: Tests are
currently failing:
prove t/db_dependent/Biblio.t
t/db_dependent/Biblio.t .. 8/15 # Looks like you planned 3 tests but ran 1.
# Failed test 'autoControlNumber tests'
# at t/db_dependent/Biblio.t line 846.
Can't use string ("1") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Biblio.pm line 362.
# Looks like your test exited with 255 just after 15.
t/db_dependent/Biblio.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/15 subtests
Test Summary Report
---
t/db_dependent/Biblio.t (Wstat: 65280 Tests: 15 Failed: 1)
Failed test: 15
Non-zero exit status: 255
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #21 from Katrin Fischer --- Moving this back to BLOCKED until we have resolved bug 30387. I think both together make a lot of sense and hope to see them moving! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #10 from Katrin Fischer --- Freeing this one from 'In Discussion' and moving it to Failed QA for comment#7: We need these changes not only in templates, but also server side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit ||y.org --- Comment #9 from Katrin Fischer --- Hm, I've tried a reset_all_unimarc on ktd in order to get ready for testing this, but it doesn't look right: No record passed at /kohadevbox/koha/Koha/MetadataIterator.pm line 71. Something went wrong reading record for biblio Koha::Schema::Result::Biblio=HASH(0x560da1706fb0)->biblionumber: Can't bless non-reference value at /kohadevbox/koha/Koha/BiblioUtils.pm line 69. And after it finishes when I search for anything: Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> at /usr/share/perl5/MARC/File/XML.pm line 570 I guess I need some help here, but maybe someone wants to finish QA here meanwhile. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29333 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30946 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29333 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30946 --- Comment #8 from Katrin Fischer --- Hi Julian, could this relate to bug 30946 with MARC21 somehow? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Katrin Fischer changed: What|Removed |Added Attachment #135789|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 135969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135969=edit Bug 30914: (24153 follow-up) Fix cleanup_database.pl --transfers --old-reserves Silly mistake, 'delete if verbose' must be 'delete if confirm' Test plan: Try the cleanup_database.pl script to delete transfers and old issues. Using --transfers --old-reserves and the --confirm flag the entries must be removed Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Needs Signoff |Failed QA --- Comment #40 from Joonas Kylmälä --- I found some issues: - Commit "Bug 27272: basket/basket" breaks opening the basket: > Template process failed: file error - parse error - > /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt > line 235: unexpected token (ELSE) - Commit "Bug 27272: basket/sendbasket" seems to break sending the basket via email (need to fix the aformentioned basket opening bug too to get here), it complained about uncovered tests. - The patch "Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo" needs to come after all the calls have been removed. - Most of the commit titles don't describe the change, please add the descriptions. I will continue review after these issues has been addressed, and also the bugs in the dependency this bug relies on have been fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Katrin Fischer changed: What|Removed |Added Summary|cleanup_database.pl |cleanup_database.pl |--transfers --old-reserves |--transfers --old-reserves |--confirm does not work.|--confirm does not work QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30399] Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Katrin Fischer changed: What|Removed |Added Attachment #135824|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 135968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135968=edit Bug 30399: Make Patron.t pass even if mandatory attributes exist t/db_dependent/Koha/Patron.t is failing if mandatory attributes already exist in the DB. We can make it pass easily by deleting all the attributes before we run the tests. Test plan: prove t/db_dependent/Koha/Patron.t must return green even if one mandatory patron attribute exists. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30399] Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #80 from Joonas Kylmälä --- I found another problem, after this patch the zebra rebuild doesn't work: root@kohadevbox:koha(master)$ koha-shell kohadev $ perl misc/migration_tools/rebuild_zebra.pl -b error retrieving biblio 369 at misc/migration_tools/rebuild_zebra.pl line 689. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30399] Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- y -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #79 from Katrin Fischer --- Good catch, Joonas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #10 from Katrin Fischer --- This tests well, so happy to sign-off, but we are missing unit tests for the changes to Querybuilder.pm. Let us know if you need help with this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer changed: What|Removed |Added Attachment #135785|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 135967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135967=edit Bug 30745: handle ES ranges for date of acquisition Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer changed: What|Removed |Added Attachment #135784|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 135966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135966=edit Bug 30745: Use query builder and search_compat in label-item-search Test plan: - apply this patch, - make some searches in labels/label-item-search.pl using the 3 form input (index, after date, before date), - check it works like before Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=30845 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@iki.fi
Status|Passed QA |Failed QA
--- Comment #78 from Joonas Kylmälä ---
This patch series breaks easy analytic link creation. To reproduce:
1. Enable EasyAnalyticalRecords syspref
2. Go to any biblio page in the staff interface
3. Click New -> Analyze items
4. On one of the items for the biblio click "Create analytics"
5. Notice you get the following error:
> Can't use string ("Koha::Biblio") as a HASH ref while "strict refs" in use at
> /kohadevbox/koha/Koha/Object.pm line 830
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer changed: What|Removed |Added Severity|minor |normal Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | --- Comment #7 from Katrin Fischer --- Alex, please don't forget to assign the bug :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Katrin Fischer changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Katrin Fischer changed: What|Removed |Added Attachment #135849|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 135965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135965=edit Bug 30904: (bug 24387 follow-up) Fix library modification of additional contents Modifying an existing element of additional content (News) by changing the library causes a duplication of the entry on the Additional contents (News) list. A subsequent attempt of deleting one of the entries results in deleting both of them. This is due to the fact that after the unwanted duplication all the entries share the same additional_contents.code. Test plan = 1. Create a piece of news under Tools > News. 2. After having saved it make a modification by changing the library. It should result in two rows in the table. 3. Delete one of the lines with Delete button. Both lines will disappear. 4. Apply the patch. 5. Repeat the steps 1 and 2. Only the one (the modified) entry should be present in the table. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 --- Comment #9 from Joonas Kylmälä --- Created attachment 135964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135964=edit Bug 30822: Clarify that BatchCommitItems is a private function BatchCommitItems is only being used within this module and isn't mentioned in EXPORT_OK. This patch simply renames it to _batchCommitItems to take the _ standard for private functions and also adds a little hint to the POD of the function to clarify that the caller must trigger a re-index. JK: Amended patch to rename also the function in t/db_dependent/ImportBatch.t and fix typo "commiting" => "commiting" Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 Joonas Kylmälä changed: What|Removed |Added Attachment #135251|0 |1 is obsolete|| Attachment #135372|0 |1 is obsolete|| --- Comment #8 from Joonas Kylmälä --- Created attachment 135963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135963=edit Bug 30822: Make BatchCommitRecords update the index in one request When committing staged marc imports to the catalogue we will often be importing a batch of records. We don't want to send one index request per biblio affected, we want to index them all after the records have been modified otherwise we will end up with multiple tasks per record (when items are also affected). Test plan: 1) Use the stage marc record tool to stage and commit a set of records and confirm the behaviour remains correct. 2) If using Elastic, check that only one indexing job is queued to take place resulting from the committed import. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #23 from Joonas Kylmälä --- Passing QA. I noticed a small grammar error in the syspref text so added a follow-up for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #22 from Joonas Kylmälä --- Created attachment 135962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135962=edit Bug 30409: (QA follow-up) Fix grammar in syspref help text Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Joonas Kylmälä changed: What|Removed |Added Attachment #135731|0 |1 is obsolete|| --- Comment #21 from Joonas Kylmälä --- Created attachment 135961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135961=edit Bug 30409: barcodedecode() should always trim barcode Barcode is trimmed of leading/trailing whitespaces in many instances before the barcodedecode sub was called. This patch instead makes that barcodedecode sub is going to trim it itself and removes unnecessary, and repetitive code that was used before barcodedecode was called. Steps to test: 1. Edit item with any barcode, add a bunch of whitespaces at the start and at the bottom of it. Save the item. Ensure that this action ruins the barcode and ensure that the spaces are still there by editing the same item again. 2. Apply the patch. 3. Edit the same item again in the same fashion. Ensure that now all whitespaces are getting trimmed and it doesn't affect the barcode in any negative way. Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
