[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #136507|0   |1
is obsolete||
 Attachment #136508|0   |1
is obsolete||
 Attachment #136509|0   |1
is obsolete||
 Attachment #136510|0   |1
is obsolete||
 Attachment #136511|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  ---
Created attachment 137676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137676&action=edit
Bug 30310: Add dayjs timezone plugin

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||30310


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310
[Bug 30310] Replace Moment.js with Day.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||30718


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
[Bug 30718] Use flatpickr's altInput option everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #6 from Emmanuel Bétemps  ---
Due date is displayed but instead of this display :

Centerville
Audio Visual
 • 1 Due: 07/19/2022 Music


Could we rather get something like :


Centerville
Audio Visual
 • 1 Music
Due: 07/19/2022

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691

--- Comment #7 from Martin Renvoize  ---
Do you intend to revisit this Nick?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28259] Checking at branch B an item in waiting hold state at branch A kill Koha

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259

Anneli Österman  changed:

   What|Removed |Added

 CC||anneli.osterman@koha-suomi.
   ||fi

--- Comment #7 from Anneli Österman  ---
We really could need this fix. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||30847


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847
[Bug 30847] Cleanup opac-reserve.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||27272

--- Comment #22 from Jonathan Druart  ---
Hi Nick, I have rebased your patches on top of bug 27272, hope you don't mind!
I can also mark myself as assignee of the patches and continue their
integration if you like.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
[Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #21 from Jonathan Druart  ---
Created attachment 137675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137675&action=edit
Bug 30847: Consolidate code to check if patron can place holds and exit if they
cannot

This wil save us fetching more info if we are denying the holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #20 from Jonathan Druart  ---
Created attachment 137674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137674&action=edit
Bug 30847: Don't get biblio/item info when placing holds

The only bit we get form the hash is the rank and title
We can si9mply fetch the biblio once to calculate
no need to fetch all the info as we don't display or use it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #19 from Jonathan Druart  ---
Created attachment 137673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137673&action=edit
Bug 30847: Don't declrae undef variable for assignment

New holds have found set to undef - we can do this directly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #18 from Jonathan Druart  ---
Created attachment 137672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137672&action=edit
Bug 30847: Avoid fetching biblio object

Here the items biblionumber is either equal to the biblionumber passed in
or it is not and should be - we can just assign directly from the item in all
cases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #17 from Jonathan Druart  ---
Created attachment 137671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137671&action=edit
Bug 30847: Don't fetch patron twice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #16 from Jonathan Druart  ---
Created attachment 137670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137670&action=edit
Bug 30847: Remove unused OPACShowHoldQueueDetails

Search for the variables, they aren't used!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #15 from Jonathan Druart  ---
Created attachment 137669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137669&action=edit
Bug 30847: Remove unused noreserve parameter

This is defined but never used

To test:
1 - git grep noreserve
2 - only one ocurrence
3 - Apply patch
4 - repeat, no ocurrence
5 - Note the plural has a few uses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #135340|0   |1
is obsolete||
 Attachment #135341|0   |1
is obsolete||
 Attachment #135342|0   |1
is obsolete||
 Attachment #135343|0   |1
is obsolete||
 Attachment #135344|0   |1
is obsolete||
 Attachment #135345|0   |1
is obsolete||
 Attachment #135346|0   |1
is obsolete||
 Attachment #135347|0   |1
is obsolete||
 Attachment #135348|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  ---
Created attachment 137668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137668&action=edit
Bug 30847: Cleanup calculation of holds and rank

Currently we loop over all the holds on the record to get a count of the
reserves not
waiting and a rank for the upcoming hold

We can simply count the number of nont waiting holds and add 1

Note: Before this patch the count of holds included the new hold we were going
to place
which meant rank and count were the same. I believe countaing existing holds
and our
upcoming rank is the correct behavior

To test:
 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their
priorty level'
 2 - Place a few holds on a bib on the staff side
 3 - Mark 1 waiting
 4 - Attempt to place hold on the bib on the opac
 5 - Note 'Your priority' and 'Number of holds' are the same number
 6 - Place another hold, confirm both increase
 7 - Set another hold waiting, confirm both decrease
 8 - Apply patch
 9 - Confirm 'Your priority' is now 1 greater than Number of holds
10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31148] New: Add link to MARC import tools from Cataloging

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

Bug ID: 31148
   Summary: Add link to MARC import tools from Cataloging
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

While the MARC import tools are in the "Tools" module, they're strongly related
to the Cataloging module.

I think it would be good to have links from the Cataloging module page to the
MARC import tools.

We can wrap them in the same permissions that are used on tools-home.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #45 from Jonathan Druart  ---
Remote branch rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #5 from Jonathan Druart  ---
I think those patches are working as you expect.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

--- Comment #4 from Jonathan Druart  ---
Created attachment 137667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137667&action=edit
Bug 30992: Improve translatability for 'for'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #137664|0   |1
is obsolete||
 Attachment #137665|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 137666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137666&action=edit
Bug 30992: Improve translatability for Waiting at|On hold

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

--- Comment #2 from Jonathan Druart  ---
Created attachment 137665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137665&action=edit
Bug 30992: Improve translatability for 'for'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30992] Hard to translate single word strings

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

--- Comment #1 from Jonathan Druart  ---
Created attachment 137664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137664&action=edit
Bug 30992: Improve translatability for Waiting at|On hold

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

--- Comment #4 from Aleisha Amohia  ---
(In reply to Daniel Jones from comment #3)
> Signing off as test plan works as described.
> 
> One thing I noticed was that I couldn't complete the hold by checking in the
> item. Is this expected behaviour?

Do you mean you couldn't set the hold as waiting? Or fill the hold?

What do you mean by complete the hold?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
Ok If I checkout the branch it fails

   Failed test 'Single Gir field OK'
#   at t/Ediorder.t line 104.
#  got: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM'
# expected: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 117.

#   Failed test 'First part of split Gir field OK'
#   at t/Ediorder.t line 117.
#  got: undef
# expected: 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 123.

#   Failed test 'Second part of split GIR field OK'
#   at t/Ediorder.t line 123.
#  got: undef
# expected: 'GIR+002+S_I:LVT'
# Looks like you failed 3 tests of 13.

This is because this test is now db_dependent 
Koha/Edifact/Order.pm:my $lsq_field =
C4::Context->preference('EdifactLSQ');


So it needs to probably be moved out of t, or that syspref needs to be mocked.
The reason it works is if that syspref is set location. 

If I set the syspref to collection, the tests fail, if i set it location the
tests pass.  
The problem is then when you are building a package you dont have a database,
the t/ tests should all pass without relying on a syspref fetched from a db.

Chris

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30928] Add interface to statistics table

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

James Donaldson  changed:

   What|Removed |Added

 CC||james.donaldson@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31147] New: Recalls due date to the minute rather than 23:59

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147

Bug ID: 31147
   Summary: Recalls due date to the minute rather than 23:59
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I don't know if this is intended behaviour or a bug.

When placing a recall, the new due date is exactly now + recall due date
interval.

Let's say my recall due date interval is 7 and an item is due 2022-08-31
23:59:00. If I place my recall today (2022-07-12) at 16:31:14, the new due date
will be 2022-07-19 16:31:14.

Like I said, I'm not sure if this is the intended behaviour, but in my very
unknowledgable opinion, I find it a bit extreme to ask someone out of the blue
to return an item by a certain time (to the second).

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) Find a record with a checked out item; check the due date for that checked
out item, e.g.

SELECT date_due FROM issues WHERE itemnumber = ;

--> It should be -MM-DD 23:59:00

3) In the OPAC, log in as a patron
4) Find the same record and place a recall
5) Check the new due date
--> It should be today + the number of days you put in recall due date interval
in step 1.2 at the exact time you placed the recall

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped'

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

David Nind  changed:

   What|Removed |Added

 Attachment #137632|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 137663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137663&action=edit
Bug 31023: Quote authtypecode in FindDuplicateAuthorities

To test:
0 - Have Koha using Elasticsearch
1 - Set  QueryRegexEscapeOptions to 'unescape escaped'
2 - Attempt to add a new 'GENRE/FORM' authority record
3 - On save you get a 500 error
Unable to understand your search query, please rephrase and try again.
 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 102
4 - Apply patch, restart all
5 - Attempt to add a new 'GENRE/FORM' authority record
6 - Success!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped'

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

David Nind  changed:

   What|Removed |Added

 Attachment #137631|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 137662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137662&action=edit
Bug 31023: Unit tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities when QueryRegexEscapeOptions set to 'Unescape escaped'

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

--- Comment #6 from AspenCat Team  ---
Lucas demonstrated the test plan and I'm signing off on the work - Bob Bennhoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #5 from David Nind  ---
Created attachment 137661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137661&action=edit
Screenshot - due date in search results before and after patch applied

I have signed off, but note that the display seems slightly "off" - see the
screenshots.

Not sure if there is a better way to format this.

(Have re-added as a PDF)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind  changed:

   What|Removed |Added

 Attachment #137660|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
Created attachment 137660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137660&action=edit
Screenshot - due date in search results before and after patch applied

I have signed off, but note that the display seems slightly "off" - see the
screenshots.

Not sure if there is a better way to format this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Attachment #136055|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 137659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137659&action=edit
Holds history page for comparison

This is a screenshot of the holds history page in the patron's online account.
Note that the language switch is at the bottom left.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Attachment #136055|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 137658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137658&action=edit
Recalls history page wth language switch in wrong place

This is a screenshot of the recalls history page in the patron's online
account. Note that the language switch is right under the table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31146] New: Minor UI problem in recalls history in OPAC

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Bug ID: 31146
   Summary: Minor UI problem in recalls history in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

This is very minor, but I figured it might make an easy fix for someone...

When recalls are turned on, the patron has access to their recalls history in
their online account. If the OPAC is multilingual, the language switcher is
right under the recalls history table, rather than being at the bottom of the
page where it normally is.

To test:
1) Install another language and enable it in the OPACLanguages system
preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer
(either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind  changed:

   What|Removed |Added

 Attachment #137645|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 137657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137657&action=edit
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #27 from Lucas Gass  ---
Missing dependencies for 22.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #4 from David Nind  ---
For me, the clear form works initially:
1. Authority finder launched for a tag
2. Clear form is styled as a text link
3. Click 'Clear form' ==> text form fields are cleared
4. For the 'Search main heading ($a only)' change to 'starts with' and enter
perl as the term (don't press the search button)
5. Click 'Clear form' ==> form reset, including options and text entered

However, for step 4, if you click search, and search results are displayed:
1. The 'Clear form' button is now styled as a button, rather than a link
2. Clicking 'Clear form' now only clears the text but not the options
3. The results from the previous search are still displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30585] Table settings for course_reserves_table are wrong due to lack of "Holding library" option

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||

--- Comment #6 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30768] Typo: pin should be PIN

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #11 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #15 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30807] Use patron-title.inc in patron payments pages

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #14 from David Nind  ---
Testing notes (using koha-testing-docker)

1. To install telnet: apt-get install telnet

2. Restart the SIP server: koha-sip --restart kohadev

3. To access SIP server using telnet: telnet 127.0.0.1 6001

4. To exit telnet: CTRL+] and then quit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30806] Use patron-title.inc in member-flags template

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind  changed:

   What|Removed |Added

 Attachment #137622|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 137656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137656&action=edit
Bug 12225: Re-implement no block flag for checkouts

Test Plan ( assuming Koha Testing Docker or kohadevbox ):
1) Check out master
2) Start the SIP server ( edit the SIP config koha instutution to be
   "CPL" instead of "kohalibrary" )
3) Telnet to 6001
4) Send 9300CNkoha|COkoha|CPCPL|
5) Send 11YY2022071116350220250711   
163502AOCPL|AA2352935676|AB301396|ACkoha|BON|BIN|
6) Note the due date for the checkout in Koha is not in the year 2025:
   Henry Acevedo (2352935676) checked out Philippics. by Cicero, Marcus
Tullius. 301396
7) Apply this patch set
8) Restart all the things!
9) Check in the checkout
10) Repeat steps 3 through 5
11) Note the due date is now in 2025!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind  changed:

   What|Removed |Added

 Attachment #137578|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 137655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137655&action=edit
Bug 12225: Fix SIP message templates

If a renewal via SIP would produce an error due to being on reserve, or
exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the
item even if the "no block" flag is set to Y.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #4 from Tomás Cohen Arazi  ---
QA script happy. Simple change. Straight QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #137653|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 137654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137654&action=edit
Bug 31145: Supply defaults for vendors and funds

This is a convenience bug - when koha testing docker creates sample vendors and
budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without
removing this
2 - The funds have random values for statistical categories, and you get empty
dropdowns when choosing a fund in ordering

To test:
1 - Apply patch
2 - Restart all
3 - Edit 'My vendor'
4 - note webstie is empty and you can save without changing anythign
5 - Add order to basket for my vendor
6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as
text input fields

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
Shouldn't we add the index to the configuration on the update?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||jonathan.druart+koha@gmail.
   ||com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

--- Comment #2 from Nick Clemens  ---
'reset_all' that is

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

--- Comment #1 from Nick Clemens  ---
Created attachment 137653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137653&action=edit
Bug 31145: Supply defaults for vendors and funds

This is a convenience bug - when koha testing docker creates sample vendors and
budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without
removing this
2 - The funds have random values for statistical categories, and you get empty
dropdowns when choosing a fund in ordering

To test:
1 - Apply patch
2 - Restart all
3 - Edit 'My vendor'
4 - note webstie is empty and you can save without changing anythign
5 - Add order to basket for my vendor
6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as
text input fields

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Kelly McElligott  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #137651|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 137652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137652&action=edit
Bug 31144: When modifying an order we should not load the vendor default
discount

After placing an order in a basket with a discount of "0" if you attempt to
modify we will load the vendor default discount, this can lead to accidentally
applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount
6 - Cancel
7 - Apply patch
8 - Modify order
9 - Discount remains at 0
10 - Repeat with a vendor with no discount set
11 - Placing order not specifiying discount it remains blank
12 - Modifying order discount remains blank
13 - Modify order and set discount
14 - Confirm it is retained on modifcation

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31145] New: Add some defaults for acquisitions in TestBuilder

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Bug ID: 31145
   Summary: Add some defaults for acquisitions in TestBuilder
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

This is a convenience bug - when koha testing docker creates sample vendors and
budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without
removing this
2 - The funds have random values for statistical categories, and you get empty
dropdowns when choosing a fund in ordering

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

--- Comment #1 from Nick Clemens  ---
Created attachment 137651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137651&action=edit
Bug 31144: When modifying an order we should not load the vendor default
discount

After placing an order in a basket with a discount of "0" if you attempt to
modify we will load the vendor default discount, this can lead to accidentally
applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount
6 - Cancel
7 - Apply patch
8 - Modify order
9 - Discount remains at 0
10 - Repeat with a vendor with no discount set
11 - Placing order not specifiying discount it remains blank
12 - Modifying order discount remains blank
13 - Modify order and set discount
14 - Confirm it is retained on modifcation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31144] When modifying an order we should not load the vendor default discount

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #137649|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 137650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137650&action=edit
Bug 14680: Always subtract discoutn form price to calculate estimated cost

This patch simply removes a discrepancty where when a discount is provided on
the order form
we add the discount to the price, and when it comes form the vendor we subtract
the discount.

Discounts should always descrease the estimated cost

To test:
 0 - Have a vendor with a discount of 10% specified
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $10 RRP and $9 actual/budgeted cost
 6 - Repeat 2&3
 7 - Select the tile, set price $10 and discount 50%
 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL
 9 - Apply patch, restart all
10 - Repeat 2-7
11 - Add the order, note $10 RRP and $5 actual.budgeted cost

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31144] New: When modifying an order we should not load the vendor default discount

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Bug ID: 31144
   Summary: When modifying an order we should not load the vendor
default discount
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

After placing an order in a basket with a discount of "0" if you attempt to
modify we will load the vendor default discount, this can lead to accidentally
applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14680

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29607

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #47 from Christopher Brannon  ---
Looks good to me as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens  changed:

   What|Removed |Added

   Assignee|olli-antti.kivila...@jns.fi |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens  changed:

   What|Removed |Added

  Attachment #41551|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 137649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137649&action=edit
Bug 14680: Always subtract discoutn form price to calculate estimated cost

This patch simply removes a discrepancty where when a discount is provided on
the order form
we add the discount to the price, and when it comes form the vendor we subtract
the discount.

Discounts should always descrease the estimated cost

To test:
 0 - Have a vendor with a discount of 10% specified
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $10 RRP and $9 actual/budgeted cost
 6 - Repeat 2&3
 7 - Select the tile, set price $10 and discount 50%
 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL
 9 - Apply patch, restart all
10 - Repeat 2-7
11 - Add the order, note $10 RRP and $5 actual.budgeted cost

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #137523|0   |1
is obsolete||

--- Comment #46 from ByWater Sandboxes  ---
Created attachment 137648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137648&action=edit
Bug 12029: DBIC Schema

Signed-off-by: Martin Renvoize 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #137522|0   |1
is obsolete||

--- Comment #45 from ByWater Sandboxes  ---
Created attachment 137647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137647&action=edit
Bug 12029: (follow-up) Adhering to coding guidelines

This is a follow-up patch which (based on comment #19) does
the following:

1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)

Sponsored-by: Horowhenua Library Trust
Signed-off-by: Martin Renvoize 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #137521|0   |1
is obsolete||

--- Comment #44 from ByWater Sandboxes  ---
Created attachment 137646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137646&action=edit
Bug 12029: Patrons should be able to delete their patron messages

This patch adds an option for patrons to dismiss OPAC messages sent to
them by the staff. The messages remain visible in the staff interface
with an indication that the message has been read.

To test, apply the patch and run the database update.

- View a patron record in the staff interface.
- Click "Add message" and select "OPAC" from the "Add a message for..."
  dropdown.
- Add a message.

- Log in to the OPAC as that patron.
- On the "Your summary" page you should see the message along with a
  "Dismiss" link."
- Clicking the "Dismiss" link should make the message disappear.
- Go to the OPAC home page. The "User summary" box in the right sidebar
  should have the correct count of messages.

- View the patron record in the staff interface again.
- The list of patron messages should still include the message which was
  dismissed via the OPAC, but there should be indication that the
  message was read, e.g. "read 11-2-2022"

Signed-off-by: Martin Renvoize 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14239] Bibframe support in Koha

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when importing records with many items

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||

--- Comment #16 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #2 from Owen Leonard  ---
Created attachment 137645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137645&action=edit
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31071] Regression: date due removed from staff search results

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when importing records with many items

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789

Nick Clemens  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #15 from Nick Clemens  ---
Performance bugs should be considered bug, not enhancement, remarking.

Please consider for backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where clause' 500 error in API /api/v1/acquisitions/orders

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.x
released in||
 CC||lu...@bywatersolutions.com

--- Comment #24 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when importing records with many items

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #14 from Lucas Gass  ---
Enhancement will not be backported to 22.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #18 from Lucas Gass  ---
Enhancement will not be backported to 22.05, if needed please ask!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #12 from Lucas Gass  ---
Doesn't apply clean to 22.05.x, no backport.

If needed please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30539] Koha upgrade error "Column 'claimed_on' cannot be null"

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29994] Single label pdf export not working

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #3 from Caroline Cyr La Rose  ---
The problem occurs when clicking the "Export" button in the table of items,
Actions column. 

To test:
1) If you do not already have label templates and layouts, add some (can use
the settings in comment 2, but any will do)
2) Go to Tools > Label creator > New > Label batch
3) Add one barcode in the box
4) Click Add items
5) Click the 'Export full batch' button
6) Choose the label template and layout
7) Click Export
8) Click Download as PDF
--> PDF is generated
9) In the label batch, select the item (the checkbox on the right)
10) Click 'Export selected items'
11) Repeat steps 6-8
--> PDF is generated
12) In the label batch, click the 'Export' button in the Actions column
13) Repeat steps 6-8
--> No PDF is generated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30891] SMS provider shows on staff side even if SMS::Send driver is not set to "Email"

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31143] New: We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143

Bug ID: 31143
   Summary: We should attempt to fix/identify all cases where
'-00-00' may still remain in the database
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

With the move to more and more of Koha using the REST API's and our rest API's
being suitably strict about date formats, we need to retrospectively correct
occurrences of -00-00 dates appear in database fields system wide.

I've had enough occurrences of bad data still in the database after a number of
upgrade and it biting me in the UI that I think we should now look at
introducing a script to either bulk fix these or at the least identify them and
warn they will cause serious issues going forward.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30280] Koha does not currently support authority records with common subject headings from different thesaurus

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #18 from Frank Hansen  ---
(In reply to David Nind from comment #16)
> Hi Frank.
> 
> I am getting an error message when resetting the mappings after the patch is
> applied (step 5 of the test plan) - this worked without error before the
> patch was applied:
> 
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> execute failed: Data truncated for column 'marc_type' at row 1 at
> /kohadevbox/koha/Koha/Objects.pm line 114
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77
> 
> in DBIx::Class::Exception::throw at
> /usr/share/perl5/DBIx/Class/Exception.pm line 77
> 
>74: my $self = { msg => $msg };
>75: bless $self => $class;
>76: 
>77: die $self;
>78: }
>79: 
>80: =head2 rethrow
> 
>.
> 
> David

Hi David,

I don't get this error. I don't using docker myself but a kohadevbox. I using
the latest debian 11 box to create the koha enviroment with ElasticSearch 6. I
did the following:

1. Creating the koha database instance by using the webinstaller.
2. Loaded demo records into the database (i using kshell when I work with the
records)
perl ../misc4dev/insert_data.pl
rebuild_elasticsearch.pl -d -v
3. Enabling Elasticsearch as search engine in intranet
4. Loading the sample records with bulkmarkimport.pl:
./bulkmarcimport.pl -v -a -file /var/tmp/authorities.mrc -insert -c=MARC21
./bulkmarcimport.pl -v -b -file /var/tmp/biblios.mrc -insert -c=MARC21
5. I verified if the sample records were loaded properly. I experienced that
the authority record was loaded and indexed ok. But the biblio record weren't
indexed for some reason. They seems to have been loaded into the database but
somehow Koha didn't indexed the record. This command worked for me before. I
had to reindex the biblio records again before I applied the patch:
/home/vagrant/kohaclone/misc/search_tools/rebuild_elasticsearch.pl -d -v
6. The sample biblio have topic terms but they are not linked to any authority
records.
7. Applying the patch.
8. Resetting the mappings which work for me without any any errors as described
above.
9. Rebuilding the authority index.
/home/vagrant/kohaclone/misc/search_tools/rebuild_elasticsearch.pl -a -d -v
10. Link bibliographic records to authority records
/home/vagrant/kohaclone/misc/link_bibs_to_authorities.pl -v -l
11. When I search the record, the topic_terms is linked.

Is there some differences between docker and kohadevbox when it comes to
mappings?

Regards,
Frank

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03
released in||
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >