[Koha-bugs] [Bug 31208] New: "Check for embedded item record data" should default to "No"

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31208

Bug ID: 31208
   Summary: "Check for embedded item record data" should default
to "No"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

At the moment, "Check for embedded item record data" in stage-marc-import.pl
defaults to "Yes", but I doubt that the majority of libraries would want to
check for embedded item record data. 

(By extension, I think it would be good to default "How to process items:" to
"Ignore items" instead of "Always add items" - just to be on the safe side.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #137938|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 137952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137952=edit
Bug 31201: Prevent Pseudonymization.t to fail

It's failing if selenium/patrons_search.t failed before, they are using
the same code and the selenium tests didn't clean correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |a.rous...@dataly.gr
 Status|NEW |ASSIGNED

--- Comment #4 from Andreas Roussos  ---
Self-assigning this as I'm preparing a patch that fixes both issues
outlined above. I'm also going to include a Selenium unit test that
will (hopefully) make it easier to catch Shelf browser-related bugs
in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28180

--- Comment #3 from Andreas Roussos  ---
With regards to the display of local cover images, the OPAC Shelf
browser works correctly in Koha versions < 21.11.00. It's also worth
noting that the correct Shelf browser behaviour can be observed in
all Koha versions (including master) when other cover image providers
(Amazon, etc.) are in use (either on their own or in combination with
the local cover images system preferences).

The relevant commit that changed the Shelf browser's behaviour is
fad97080e97da5bc77724c68b9394aba15518847 (from Bug 28180), where
these lines were removed from opac-detail.tt:

[% IF OPACLocalCoverImages %]
KOHA.LocalCover.GetCoverFromBibnumber(true);
[% IF itemloop_has_images OR oheritemloop_has_images %]
KOHA.LocalCover.GetCoverFromItemnumber(true);
[% END %]
[% END %]

Adding the above code to opac-detail.tt fixes the problem in master.

However, if you look closely you'll notice the code has a small typo.
The template parameter in the second [% IF %] conditional is named:

oheritemloop_has_images

vs. the correct parameter name:

otheritemloop_has_images

Because of that, the display of local cover images in the
OPAC Shelf browser has never worked as intended when the SysPref
OpacSeparateHoldings is set to 'Separate'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Andreas Roussos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31207

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #2 from Andreas Roussos  ---
Created attachment 137951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137951=edit
Koha 21.11.00 - OPAC Shelf browser - Local covers Broken

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #1 from Andreas Roussos  ---
Created attachment 137950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137950=edit
Koha 21.05.16 - OPAC Shelf browser - Local covers OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31207] New: The OPAC Shelf browser fails to display local cover images

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Bug ID: 31207
   Summary: The OPAC Shelf browser fails to display local cover
images
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: a.rous...@dataly.gr
QA Contact: testo...@bugs.koha-community.org

In the OPAC Details page for a biblio, opening the Shelf browser
will display adjacent items next to each other based on their call
number and also display any cover images found. It's a very useful
OPAC feature that allows librarians to have a "virtual" look at
their library shelves.

This is currently broken *when local covers are exclusively in use*,
as it fails to fetch the related local cover images from the DB.

Steps to reproduce:

TL;DR: Just visit the sandbox URL below and see for yourself ;-)
https://opac-shlfbrwsr.sandboxes.biblibre.eu/cgi-bin/koha/opac-detail.pl?biblionumber=344_itemnumber=1348#holdings

Go to Home > Administration > System preferences in the Staff interface:
- in section 'OPAC -> Shelf browser', make sure OPACShelfBrowser
  is enabled (i.e. set to 'Show')
- in section 'Enhanced content -> Local or remote cover images',
  make sure both LocalCoverImages and OPACLocalCoverImages
  are enabled (i.e. set to 'Display')
- make sure no other cover image provider is enabled
- make sure OpacSeparateHoldings and OpacSeparateHoldingsBranch
  are set to 'Don't separate' and 'home library', respectively

Next, in the Staff interface, find a record without any local cover
images (either at the biblio or at the item level), having at
least one item attached to it that has a Call number (the call
number value can be anything -- it's only needed to trigger the
display of the 'Browse shelf' hyperlink). Use the 'Images' tab
in the Details page of the record to upload a local cover image
at the biblio level (do *not* upload any item-level cover image).

Finally, in the OPAC, visit the Details page of the record you
just added the cover image to, and click on the 'Browse shelf'
link found in the 'Call number' column. When the Shelf browser
expands, you'll notice that there is no cover image displayed
for the item(s) that belong to your test biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in batch patron modification breaks the form sending

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|22.11.00, 22.05.01, |22.11.00, 22.05.01
released in|21.11.07|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31206] New: Highlight logged in library in green in Circ History

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31206

Bug ID: 31206
   Summary: Highlight logged in library in green in Circ History
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mada...@ckls.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

This is based on the same idea that was used in Bug 10902 (pushed to 21.11;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902). I think it
might be helpful to have the same kind of highlighting feature in other areas
of Koha for consortiums. 

Specifically, in this case, highlighting the logged-in library when looking at
circ history. However, I'm not sure if this would be "too much of a good
thing," i.e. if we started adding highlighting all over the place, is it going
to be more of a problem than a solution? I'm open to input on this. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31206] Highlight logged in library in green in Circ History

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31206

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18392] Allow exporting circulation conditions as CSV or spreadsheet

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #23 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #22)
> I feel like we can't expect people to constantly reset their Elasticsearch
> mappings and redo their own. As this fixed a bug, could we update mappings
> with a database update?

I don't think it is that simple. We have created the ability for librarians to
manage their own ES configuration - we cannot know what thy have done and
whether our fixes are desired

bug 30836 needs to address this as a larger issue, but I don't think this
should be held up by that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi

--- Comment #8 from Joonas Kylmälä  ---
Thanks, trivial fix, passing QA. Adjusted the commit title a bit as it was not
passing the qa tool and didn't describe the change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #137905|0   |1
is obsolete||

--- Comment #7 from Joonas Kylmälä  ---
Created attachment 137949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137949=edit
Bug 30458: Include librarian (manager_id) in accountline when using "Payout
amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!

Signed-off-by: Sally 
JK: Fix commit title

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||tomasco...@gmail.com

--- Comment #2 from Tomás Cohen Arazi  ---
It is actually failing randomly, with this patch at least:

$ prove t/db_dependent/Koha/Pseudonymization.t
t/db_dependent/Koha/Pseudonymization.t .. 1/3 
#   Failed test 'Attribute 1 should be retrieved correctly'
#   at t/db_dependent/Koha/Pseudonymization.t line 201.
# Structures begin differing at:
#  $got->{code} = 'sJHyWk'
# $expected->{code} = 'YgXf22O9Vp'

#   Failed test 'Attribute 2 should be retrieved correctly'
#   at t/db_dependent/Koha/Pseudonymization.t line 207.
# Structures begin differing at:
#  $got->{attribute} = 'attribute for code1'
# $expected->{attribute} = 'attribute for code3'
# Looks like you failed 2 tests of 3.
t/db_dependent/Koha/Pseudonymization.t .. 3/3 
#   Failed test 'PseudonymizedBorrowerAttributes tests'
#   at t/db_dependent/Koha/Pseudonymization.t line 214.
# Looks like you failed 1 test of 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #113 from Joonas Kylmälä  ---
(In reply to Jonathan Druart from comment #103)
> Last patch would benefit from a QA review but I don't want to set the status
> back to NQA and lose it for weeks.

Looks good to me, handing off to the release manager.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #137924|0   |1
is obsolete||

--- Comment #112 from Joonas Kylmälä  ---
Created attachment 137948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137948=edit
Bug 29697: Don't crash ES reindex if a record is wrong

We don't want rebuild_elasticsearch.pl to crash if a record is wrong
(also fix ktd setup).
Note that now the script will output an error for the problematic
record, which is certainly the expected behaviour as we are doing it
already for authority records.

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0"

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Michal Urban  changed:

   What|Removed |Added

 CC||michalurban...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0"

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Michal Urban  changed:

   What|Removed |Added

 Attachment #137941|0   |1
is obsolete||

--- Comment #2 from Michal Urban  ---
Created attachment 137947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137947=edit
Bug 31202 - Koha removes optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Michal Urban 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban  changed:

   What|Removed |Added

 Attachment #137853|0   |1
is obsolete||

--- Comment #6 from Michal Urban  ---
Created attachment 137946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137946=edit
Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill

This patch makes the method use the new
Koha::Item::Transfers->filter_by_current one.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Holds.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Michal Urban 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban  changed:

   What|Removed |Added

 Attachment #137852|0   |1
is obsolete||

--- Comment #5 from Michal Urban  ---
Created attachment 137945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137945=edit
Bug 31183: Add Koha::Item::Transfers->filter_by_current

This patch introduces the aforementioned method.

To test:
1. Apply this unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item/Transfers.t
=> FaIL: method not defined?
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban  changed:

   What|Removed |Added

 Attachment #137851|0   |1
is obsolete||

--- Comment #4 from Michal Urban  ---
Created attachment 137944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137944=edit
Bug 31183: Unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

--- Comment #4 from Joonas Kylmälä  ---
(In reply to Jonathan Druart from comment #0)
> The cache is cleared for the default framework, but the mapping can be read
> from another framework

I'm pretty sure I used the default framework when noticing this bug for the
first time. The cache invalidation problem occurred only when I deleted a
mapping, I didn't notice it happening when changing the value of a mapping.
I'll try to circle back to this bug report later to confirm / and see if I have
any ideas on how to fix this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31205] Adding Custom name to the 'From' field in email notices

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31205

Todd Goatley  changed:

   What|Removed |Added

 CC||tgoat...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

--- Comment #1 from Lucas Gass  ---
Created attachment 137943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137943=edit
Bug 31204: Clearly indicate edit buttons are for record modification

To test:
1. Apply patch
2. Do a search and select some records
3. On the toolbar (#selection_ops) open the Edit dropdown.
4. The labels should read 'Batch edit records' and 'Batch delete records'.

Note: To see both you must have batchmod and batchdelete permission.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31205] New: Adding Custom name to the 'From' field in email notices

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31205

Bug ID: 31205
   Summary: Adding Custom name to the 'From' field in email
notices
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tgoat...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 137942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137942=edit
Please enter valid email address

Adding Custom name to the 'From' field in email notices (i.e. Whatever you want
in front ) hasn't been working for a few years and
recently a few libraries have requested. The wiki page for this is:
https://wiki.koha-community.org/wiki/Adding_Custom_name_to_the_%27From%27_field_in_email_notices

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31204] New: Edit dropdown on results.tt should indicate it is record modification

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Bug ID: 31204
   Summary: Edit dropdown on results.tt should indicate it is
record modification
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

On results.tt there is an option to select records and then, from the toolbar,
select edit and choose either 'Batch edit' or 'Batch delete'.

Some librarians have found this confusing, thinking it would lead them to
'Batch Item Modification' when instead it leads to 'Batch record modification'.

We could make it less confusing by clearly indicating this function takes the
user to record modification, not item modification.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #1 from Liz Rea  ---
100% yes please

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31203] New: Cronjobs should log completion as well as logging begin

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

Bug ID: 31203
   Summary: Cronjobs should log completion as well as logging
begin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Currently our cronjobs call cronlogaction when they begin

We should add a second call:
cronlogaction({done => 1});

To indicate when a job has completed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0"

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0"

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

--- Comment #1 from Kyle M Hall  ---
Created attachment 137941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137941=edit
Bug 31202 - Koha removes optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702

Michal Urban  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702

Michal Urban  changed:

   What|Removed |Added

 Attachment #137939|0   |1
is obsolete||

--- Comment #4 from Michal Urban  ---
Created attachment 137940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137940=edit
Bug 28702: Make buildKohaItemsNamespace take an array

If we fetch some of the authorised values and before hand we can reduce the
amount of work needed in this routine.
We stil require queries for pending holds and transfers, but these are lighter
than fetching the items

To test:
1 - Perform a search on the OPAC
2 - Add the results to a list
3 - Load the list several times and use developer tools (F12) to view the time
to load in the network tab
4 - Repeat a search several times and use developer tools (F12) to view the
time to load in the network tab
5 - Record the times noted above
6 - Apply patch
7 - Repeat the search and list view and compare to before the patch
8 - prove -v t/db_dependent/XSLT.t

Signed-off-by: Michal Urban 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702

Michal Urban  changed:

   What|Removed |Added

 Attachment #122785|0   |1
is obsolete||

--- Comment #3 from Michal Urban  ---
Created attachment 137939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137939=edit
Bug 28702: Make buildKohaItemsNamespace take an array

If we fetch some of the authorised values and before hand we can reduce the
amount of work needed in this routine.
We stil require queries for pending holds and transfers, but these are lighter
than fetching the items

To test:
1 - Perform a search on the OPAC
2 - Add the results to a list
3 - Load the list several times and use developer tools (F12) to view the time
to load in the network tab
4 - Repeat a search several times and use developer tools (F12) to view the
time to load in the network tab
5 - Record the times noted above
6 - Apply patch
7 - Repeat the search and list view and compare to before the patch
8 - prove -v t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0"

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31202] New: Koha removes optional SIP fields with a value of "0"

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Bug ID: 31202
   Summary: Koha removes optional SIP fields with a value of "0"
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Discovered this when trying to send the number of patron holds in a custom SIP
field.

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

--- Comment #1 from Jonathan Druart  ---
Created attachment 137938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137938=edit
Bug 31201: Prevent Pseudonymization.t to fail

It's failing if selenium/patrons_search.t failed before, they are using
the same code and the selenium tests didn't clean correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25449] Make itemtype mandatory by default

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

--- Comment #14 from Jonathan Druart  ---
Created attachment 137937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137937=edit
Bug 25449: Fix basic_workflow.t

We need to create an itemtype for the biblio, then the item form will
have 942$c prefilled by default

STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch
{...}
/usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try
(eval 1726):1 in Selenium::Remote::Driver::__ANON__
(eval 1728):2 in Selenium::Remote::Driver::__ANON__
/usr/share/perl5/Selenium/Remote/Driver.pm:953 in
Selenium::Remote::Driver::_execute_command
t/db_dependent/selenium/basic_workflow.t:224 in
Selenium::Remote::Driver::get_title

Error while executing command: unexpected alert open: Dismissed user prompt
dialog: Form not submitted because of the following problem(s)


- 1 mandatory fields empty (highlighted) at
/usr/share/perl5/Selenium/Remote/Driver.pm line 411.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31201] New: Pseudonymization.t failing if selenium/patrons_search.t failed before

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Bug ID: 31201
   Summary: Pseudonymization.t failing if
selenium/patrons_search.t failed before
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Blocks: 25551

Koha_Master/2115

19:52:29 koha_1   | #   Failed test 'No tests run for subtest
"PseudonymizedBorrowerAttributes tests"'
19:52:29 koha_1   | #   at t/db_dependent/Koha/Pseudonymization.t line 211.
19:52:29 koha_1   | Duplicate ID# Looks like your test exited with 255 just
after 3.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25449] Make itemtype mandatory by default

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||31201


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201
[Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed
before
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31200] New: Block payment of late fees when document not return

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31200

Bug ID: 31200
   Summary: Block payment of late fees when document not return
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: julie.em...@collecto.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Hi, 

A library would like to be able to block any payment of late fees if materials
are not returned to the library. 

As this could have undesirable effects it should be possible to make changes in
the system preference and not be blocked for everyone. 

Does anyone know a way to enforce this preference?

Another possibility would be to display a pop-up during payment so that the
person who wants to collect knows that the document has not been returned.
After the libraby chooses if it want accept of not the payment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199

--- Comment #1 from Jonathan Druart  ---
Koha_Master/2115

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||31199


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199
[Bug 31199] selenium/patrons_search.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31199] New: selenium/patrons_search.t is failing randomly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199

Bug ID: 31199
   Summary: selenium/patrons_search.t is failing randomly
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Blocks: 25551

19:38:24 koha_1   | # Looks like you planned 24 tests but ran 16.
19:38:24 koha_1   | 
19:38:24 koha_1   | #   Failed test 'Search patrons'
19:38:24 koha_1   | #   at t/db_dependent/selenium/patrons_search.t line
287.
19:38:24 koha_1   | Cannot wait more for jQuery to be active
(wait_for_ajax) at /kohadevbox/koha/t/lib/Selenium.pm line 206.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30268] When creating an order from a staged file, mandatory item subfields that are empty do not block form submission

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #19 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30268] When creating an order from a staged file, mandatory item subfields that are empty do not block form submission

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31186] Search result numbering in OPAC got suppressed

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Nick Clemens  changed:

   What|Removed |Added

 Attachment #137861|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 137936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137936=edit
Bug 31186: Fix the hidingrules test for result numbering

We should not test the $hidingrules variable but the number
of keys it contains.

Test plan:
Clear OpacHiddenItems.
Check with and without this patch search result numbering on
the OPAC.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Nick Clemens  changed:

   What|Removed |Added

 Attachment #137792|0   |1
is obsolete||
 Attachment #137793|0   |1
is obsolete||
 Attachment #137794|0   |1
is obsolete||

--- Comment #16 from Nick Clemens  ---
Created attachment 137933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137933=edit
Bug 27045: Fix items lost report export if delimiter is tab

When choosing tabulation as the delimiter for a CSV profile
for the lost item report, the tabs appear in the file as \t
instead of as proper tabs.

title\tauthor\tstocknumber\tcallnumber
"E Street shuffle :"\"Heylin, Clinton."\\

To test:
* Upate the existing sample lost item CSV profile to use tabs as
  separator
* Make sure you have some lost items in your database or create some
* Go to Reports > Lost items
* Run the report
* Check all or some of the checkboxes in the result list
* Export using the link on top and the CSV profile
* Verify the tabs are not exported correctly
* Apply patch
* Verify tabs now are proper tabs instead of \t

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #18 from Nick Clemens  ---
Created attachment 137935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137935=edit
Bug 27045: (follow-up) Fix delimiter in header rows

The header rows still showed \t because the newly defined
variable wasn't used there.

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #49 from Jonathan Druart  ---
Petro, are you working on this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as separator don't work correctly

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #17 from Nick Clemens  ---
Created attachment 137934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137934=edit
Bug 27045: Fix other exports using CSV profiles

This patch corrects the export of the 2 other reports
using CSV profiles:

* Late issues (serials)
* Basket (acquisitions)

To test:
1) Late issues
* Update the late issues sample report to use tab as separator
* Create a subscription
* Go to serial collection and 'generate next' to get some late issues
* Go to Claims
* Export the late issues and verify format is correct
* Verify exported file has tabs

2) Basket summary
* Create an order with several order lines
* Create an SQL type CSV profile for basket export using tab as separator
  Example: aqorders.quantity|aqordres.listprice|Title=biblio.title
* Export the basket using your configured CSV profile
* Verify exported file has tabs

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #70 from Kyle M Hall  ---
Created attachment 137930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137930=edit
Bug 14364: Fix spelling and tests

Moved the installer to pl file
Adjusted capitalization / reply-to
Fix tests by importing needed fuction and adjusting a wrong call

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #69 from Kyle M Hall  ---
Created attachment 137929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137929=edit
Bug 14364: (follow-up) Cleanup duplicate code and adjust notices and prefs

This patch removes a duplicated stanza left form moving routine
Changes the routines to use inbound_library_address
Improves the display if the system preferences
Updates the update file
Moves smaple notice

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #133923|0   |1
is obsolete||
 Attachment #133924|0   |1
is obsolete||
 Attachment #133925|0   |1
is obsolete||
 Attachment #133926|0   |1
is obsolete||
 Attachment #133927|0   |1
is obsolete||
 Attachment #133928|0   |1
is obsolete||

--- Comment #67 from Kyle M Hall  ---
Created attachment 137927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137927=edit
Bug 14364: Allow automatically canceled expired waiting holds to fill the next
hold

Right now, if a library automatically cancels expired waiting holds, a
librarian must still re-checkin an item to trap the next available hold
for that item. It would be better if the next hold was automatically
trapped and the librarians receive an email notification so they can
make any changes to the item if need be ( hold area, hold slip in item,
etc ).

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Create a record with one item
 4) Place two holds on that record
 5) Check in the item and set it to waiting for the first patron
 6) Set ReservesMaxPickUpDelay to 1
 7) Enable ExpireReservesMaxPickUpDelay
 8) Enable ExpireReservesAutoFill
 9) Set an email address in ExpireReservesAutoFillEmail
10) Modify the holds waitingdate to be in the past
11) Run misc/cronjobs/holds/cancel_expired_holds.pl
12) Note the hold is now waiting for the next patron
12) Note a waiting hold notification email was sent to that patron
13) Note a hold changed notification email was sent to the library

Signed-off-by: Victoria Faafia 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #71 from Kyle M Hall  ---
Created attachment 137931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137931=edit
Bug 14364: (QA follow-up) Fix capitalization

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #68 from Kyle M Hall  ---
Created attachment 137928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137928=edit
Bug 14364: (QA follow-up) Generate message for transfers as well

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #72 from Kyle M Hall  ---
Created attachment 137932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137932=edit
Bug 14364: (QA follow-up) Add email validation to ExpireReservesAutoFillEmail

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #48 from Martin Renvoize  ---
I think I agreed to the idea of explicit search_ordered.. thus calling it
chained to get the order one wants in each case..

Can you now actually pass ordering in as attributes to the relation accessor
anyway too already?

  $biblio->items({},{ order_by => whatever });

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31008] Long Term Support (LTS) version of Koha

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31008

--- Comment #4 from David Nind  ---
Discussed further at the 6 July 2022 development meeting
https://meetings.koha-community.org/2022/development_irc_meeting_6_july_2022.2022-07-06-21.00.log.html

General points discussed:

1) Which version will be LTS: discussion leant towards preferring 22.05, rather
than 21.11
2) Overlap time (half year or year): discussion leant towards a year
3) Regular maintenance time (1 year, 1.5 years...)

Diagram: https://lite.framacalc.org/29o8a7mlwc-9v57

To add questions to vote on to the next agenda. Those not able to attend next
meeting - add apologies and record votes in advance (if questions added to the
agenda).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30982] Use the REST API for background job list view

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #16 from Martin Renvoize  ---
I think this is pretty much ready to go.. just needs a QA eye.. which I can't
lend as I SO'd :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Nick Clemens  changed:

   What|Removed |Added

 Attachment #137903|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 137926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137926=edit
Bug 31192: Check for item before calling is_bundle

The code in here is weird.. we really aught to check for the item before
anything else and throw an error to screen if we don't find one... but
my patch takes the simple option, and the one taken elsewhere in the
script.. to just check for item being defined before calling a method
upon it.

Signed-off-by: Sally 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18668] Add the column localuse to the items table

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18668

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Andrew Fuerste-Henry  ---


*** This bug has been marked as a duplicate of bug 16122 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #9 from Andrew Fuerste-Henry  ---
*** Bug 18668 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31188] UPC or ASIN from amazon for dvd, music cds image

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31198] New: Display results search authority numbers

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31198

Bug ID: 31198
   Summary: Display results search authority numbers
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: julie.em...@collecto.ca
QA Contact: testo...@bugs.koha-community.org

Created attachment 137925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137925=edit
Authority display example

Hi, 

We would like to show the authority number in the search results. Currently you
have to click on the authorized to display the number.

It would therefore be interesting if we could choose the display options for
the authority results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #66 from Tomás Cohen Arazi  ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Make patron restrictions user definable

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Patron restrictions should  |Make patron restrictions
   |be user definable   |user definable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

--- Comment #17 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30333] Move view actions on acquisitions receipt summary page into menu

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30333] Move view actions on acquisitions receipt summary page into menu

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #17 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate
   Severity|enhancement |new feature
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results pages

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30039] Add publication date column to serial claims table

2022-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >