[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #8 from Tomás Cohen Arazi --- Ok, I added a sample usage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Victor Grousset/tuxayo changed: What|Removed |Added Depends on|29403 |29718 CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- It's not 29403, reverting doesn't fix the issue. Bisecting shows that it's commit Bug 29718: Mock the timezone Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed more data than expected for the format https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 [Bug 29718] DateTime - our 'iso' is not ISO 8601 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 138060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138060=edit [POC] Bug 31224: Add Koha::Biblio->metadata_record This patch introduces a higher-level method for retrieving a 'prepared' record for using in specific contexts. In particular, I only focused on embedding item information and OPAC view filtering. But we could add a way to get the record through the ViewPolicy also for staff. The virtue of this patch is that it explains better than my words why I think having the *embed_items* and *opac* parameters in Koha::Biblio::Metadata->record is not ideal. And makes the other implementation feel like is done at the wrong level. I know it's been done like that to act as a drop-in replacement fro GetMarcBiblio, which was a good first step. But we need to revisit how it is used, in general, to come up with a more refined and useful design. So we do not port the same design problems from C4::* into Koha::*. Try to think how it would be used in contexts like opac-MARCdetail.pl or any other OPAC controller script. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added Attachment #138060|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 138061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138061=edit [POC] Bug 31224: Add Koha::Biblio->metadata_record This patch introduces a higher-level method for retrieving a 'prepared' record for using in specific contexts. In particular, I only focused on embedding item information and OPAC view filtering. But we could add a way to get the record through the ViewPolicy also for staff. The virtue of this patch is that it explains better than my words why I think having the *embed_items* and *opac* parameters in Koha::Biblio::Metadata->record is not ideal. And makes the other implementation feel like is done at the wrong level. I know it's been done like that to act as a drop-in replacement fro GetMarcBiblio, which was a good first step. But we need to revisit how it is used, in general, to come up with a more refined and useful design. So we do not port the same design problems from C4::* into Koha::*. Try to think how it would be used in contexts like opac-MARCdetail.pl or any other OPAC controller script. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #4 from Tomás Cohen Arazi --- Resubmitted as an unrelated change slipped in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Use EmbedItems in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #25 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #13) > If I have nothing in OPACHiddenItems or just itype: [CF], > I do not see my two items on a record with itype BK or BKS. > Just: No available items. > > Without your patch, they come up again. Nice. > > So there is still something wrong ;) Can you find it ? I don't manage to reproduce this. It might have been the old YAML library we were using? I tried --- itype: ['CF'] and --- itype: [CF] Both produced the expected result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #1 from Tomás Cohen Arazi --- Ok, I submitted to bug 23247 and implementation that doesn't rely on the new embed_items param, so we ponder how coding with RecordProcessor looks like in the controllers. I will now submit a version that uses RecordProcessor in the method. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 138063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138063=edit [POC] Bug 31224: Add Koha::Biblio->metadata_record This patch introduces a higher-level method for retrieving a 'prepared' record for using in specific contexts. In particular, I only focused on embedding item information and OPAC view filtering. But we could add a way to get the record through the ViewPolicy also for staff. The virtue of this patch is that it explains better than my words why I think having the *embed_items* and *opac* parameters in Koha::Biblio::Metadata->record is not ideal. And makes the other implementation feel like is done at the wrong level. I know it's been done like that to act as a drop-in replacement fro GetMarcBiblio, which was a good first step. But we need to revisit how it is used, in general, to come up with a more refined and useful design. So we do not port the same design problems from C4::* into Koha::*. Try to think how it would be used in contexts like opac-MARCdetail.pl or any other OPAC controller script. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 138062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138062=edit [POC] Bug 31224: Use metadata_record in opac-MARCdetail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 138064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138064=edit [POC] Bug 31224: Use metadata_record in opac-MARCdetail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Victor Grousset/tuxayo changed: What|Removed |Added Blocks|30030 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added Attachment #138061|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Use EmbedItems in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added Attachment #138062|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #8 from Victor Grousset/tuxayo --- To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for 22.05 and in the future 22.11, should 29718 be reverted until then? (assuming it's possible) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #41 from Victor Grousset/tuxayo --- This causes a failure on Ubuntu 18.04: bug 30030 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||30030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 Nick Clemens changed: What|Removed |Added Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31138] DataTables is not raising error to the end user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #115 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102095|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23247 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 --- Comment #17 from Nick Clemens --- Created attachment 138058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138058=edit Bug 30085: [21.11.x] Reduce scope of holds count / today holds count We retrieve two counts that are only needed if rules for hold limits are defined. The DB counts should only be fetched once the rules are confirmed to exist Further improvement would be possiblke by allowing them to be passed in (or cached?) from CanBookBeReserved as they rely only on patron/biblionumber and not item specific information Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Bug 30085: Don't fetch ReservesControlBranch twice We essentially copy the code from GetReservesControlBranch here, because we also calculate 'branchfield' Setting it to "" vs undef makes no difference in this code, so lets not fetch this again later. Rename the variable to make it clearer where the branchcode came from Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Bug 30085: Consolidate querycoutn code and only check if needed Similar to first patch, move a count only conditionally used into the conditional This could be updated to use DBIC, but the itemtype conditionals add complexity Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Bug 30085: Move IndependentBranches check sooner This doesn't rely on the other statuses, and requires only cached preference check, so lets allow the possibiliy of an early exit Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Small patch |Trivial patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #26 from Tomás Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #28 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Use EmbedItems in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31224 Depends on||29697 QA Contact|m.de.r...@rijksmuseum.nl|testo...@bugs.koha-communit ||y.org Summary|Simplify visibility logic |Use EmbedItems in |in opac-MARCdetail.pl |opac-MARCdetail.pl --- Comment #24 from Tomás Cohen Arazi --- Ok, In light of bug 29697 and the design discussion on bug 31224, I decided to rework this bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting pickup' should not reset the selected tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878 Kyle M Hall changed: What|Removed |Added Attachment #136333|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 138054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138054=edit Bug 30878: Avoid resetting waiting reserves tab When canceling holds waiting over X days in "Holds awaiting pickup" view, form submission resets the selected tab to "Holds waiting". This tab reset may cause confusion for the user and lead to unwanted actions. Instead, the user should be returned to the same tab that they began with. To test: 1. Apply patch 2. Navigate to /cgi-bin/koha/circ/waitingreserves.pl 3. Select "Holds waiting over X days" tab 4. Refresh page 5. Observe "Holds waiting over X days" is still selected 6. Have some holds waiting over X days 7. Select one of them and press "Cancel selected (1)" and confirm 8. Observe "Holds waiting over X days" is still selected after form submission Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102094|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi changed: What|Removed |Added Blocks||31224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] New: Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Bug ID: 31224 Summary: Koha::Biblio::Metadata->record should use the EmbedItems filter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Bug 29697 removed GetMarcBiblio in favor of using Koha::Biblio::Metadata->record. YAY! But it added a redundant Koha::Biblio::Metadata::_embed_items method. It also adds a suspicious 'record' param. I say suspicious because it looks like a trick to have a given MARC::Record object added the items information. Which feels like wrong API design. Specially when we have the Koha::Filter::MARC::EmbedItems processor filter for the task. Now that things are 'modernized' we really need to revisit this code for a cleanup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #29 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 138059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138059=edit Bug 23247: Use EmbedItems in opac-MARCdetail.pl This patch uses the EmbedItems processor to add the items to the MARC record. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 Andreas Roussos changed: What|Removed |Added Attachment #138014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting pickup' should not reset the selected tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #23 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31212] Datelastseen should be a datetime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #1 from Michal Urban --- Created attachment 138053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138053=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #28 from Tomás Cohen Arazi --- I hate the filter name. But it is accurate! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #114 from Tomás Cohen Arazi --- Created attachment 138057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138057=edit Bug 29697: (follow-up) Indexing a deleted record is not expected to crash Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option should be available as a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 --- Comment #14 from Andreas Roussos --- (In reply to Sally from comment #13) > Sorry for the noise - I messed up on the number of patches to sign off from > the sandbox. :( > > But the patch works great - appreciate the solid test plan. No worries, I've marked the non-relevant comments as obsolete. Many thanks for your feedback and the speedy sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option should be available as a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31121] Format date range on top of cashup summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31138] DataTables is not raising error to the end user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988 --- Comment #45 from Shi Yao Wang --- I will wait for a reply on my previous comment before attempting to write unit tests. Should the test be at t/db_dependent/Koha/Auth/Client/OIDC.t? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30858] Add serial enumeration/chronology to itemsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 Andreas Roussos changed: What|Removed |Added Attachment #138015|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31121] Format date range on top of cashup summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 138052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138052=edit Bug 30838: (QA follow-up) Add missing semicolon Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31212] Datelastseen should be a datetime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Michal Urban changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate it is record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 138051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138051=edit Bug 31086: (QA follow-up) Use plain SQL in db_rev Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26549] Show value of global system preferences on subscription form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #22 from Kyle M Hall --- Created attachment 138050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138050=edit Bug 30678: (follow-up) Change call in opac scripts Test plan: See first patch. Add orgcode OCoLC. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #2 from Paul Derscheid --- There's another thing: I think that the only Content-Type that makes sense for the return value is 'application/marc-in-json' because we return 1..n records instead of a single one. Additionally I can't imagine a use-case in which you wouldn't want JSON as a return value for that route. Is there any sane way to discern marc records from one another in an api response? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option should be available as a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157 Katrin Fischer changed: What|Removed |Added Attachment #137736|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 138044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138044=edit Bug 31157: Allow selection for overdue from address in the UI This patch adds a new system preference to allow systems librarians the option to pick wich address to use for overdues notices. We default to 'cron' to allow existing uses of '--frombranch' on the command line to continue to function but now allow end users to override this option via the new OverdueNoticeFrom preference. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting pickup' should not reset the selected tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #20 from Kyle M Hall --- Created attachment 138048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138048=edit Bug 30678: Adjust pref description Test plan: Look up pref OPACSearchForTitleIn. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option should be available as a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option should be available as a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157 --- Comment #7 from Katrin Fischer --- Created attachment 138045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138045=edit Bug 31157: (QA follow-up) Update descriptions and wording of configuration options Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
Kyle M Hall changed:
What|Removed |Added
Attachment #138046|0 |1
is obsolete||
--- Comment #19 from Kyle M Hall ---
Created attachment 138047
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138047=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn
We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.
Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.
Signed-off-by: Marcel de Rooy
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize changed: What|Removed |Added Attachment #138039|0 |1 is obsolete|| --- Comment #81 from Martin Renvoize --- Created attachment 138041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138041=edit Bug 23838: (QA follow-up) Rename patron-renewal => checkout-renewal Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988
--- Comment #44 from Shi Yao Wang ---
(In reply to Martin Renvoize from comment #42)
> This is looking good.. a few comments of where I'd love to see it headed and
> one that is unfortunately a QA fail at the moment.
>
> QA Fail
> * We're missing Unit Tests for the new module you introduce, I'm afraid
> that's a hard fail for now. It also looks like you have a note to do
> validation here which is missing... little confused as it looks like you are
> passing in a json structure rather than the token string.. so I'd have
> expected that to already be verified? We could perhaps just use an existing
> library for this Mojo::JWT for instance?
Sorry, I am not really knowledgeable on the subject of token validation. For
the note, I put it there because I saw this note in the file
opac/svc/auth/googleopenidconnect that I copied to opac/svc/auth/openidconnect
when I started:
># Normally we'd have to validate the token - but google says not to worry here
>(Avoids another library!)
># See
>https://developers.google.com/identity/protocols/OpenIDConnect#obtainuserinfo
>for rationale
So I rewrote the note in the same spot just to give a heads up since I am not
sure if it is needed and I couldn't figure out how to do it if it is needed. I
looked into it a little and I think it has something to do with validating the
token signature involving kid attribute (key id) and jwks_uri of the discovery
document?
> little confused as it looks like you are
> passing in a json structure rather than the token string.. so I'd have
> expected that to already be verified?
The json passed in looks like this:
>{
>'access_token' => '(encoded stuff)'
>'id_token' => '(encoded stuff)'
>'scope' => 'openid https://www.googleapis.com/auth/userinfo.profile
> https://www.googleapis.com/auth/userinfo.email'
>'expires_in' => 3598
>'token_type' => 'Bearer'
>}
Then 'id_token' is split (into 3 parts) by '.' and the middle part is decoded
into another json that contains the claims. Hope this helps comprehension.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #21 from Kyle M Hall --- Created attachment 138049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138049=edit Bug 30678: (follow-up) Add oclc_number routine and friends As requested by QA, we should match the orgcode. Adding a few small routines in a Util module. Test plan: Run t/Koha/Util/MARC.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
Kyle M Hall changed:
What|Removed |Added
Attachment #136222|0 |1
is obsolete||
Attachment #136223|0 |1
is obsolete||
Attachment #136224|0 |1
is obsolete||
Attachment #136225|0 |1
is obsolete||
--- Comment #18 from Kyle M Hall ---
Created attachment 138046
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138046=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn
We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.
Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.
Signed-off-by: Marcel de Rooy
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #133499|0 |1 is obsolete|| --- Comment #113 from Shi Yao Wang --- Created attachment 138032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138032=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #84 from Tomás Cohen Arazi --- Created attachment 138043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138043=edit Bug 23838: (QA follow-up) Move include files As talked with Martin, this patches were originally developed before we added the modals/ and str/ dirs, but we need to align it with current way of doing it. This patch does that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #80 from Tomás Cohen Arazi --- Created attachment 138040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138040=edit Bug 23838: Add 'view' link to item detail page Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #133501|0 |1 is obsolete|| --- Comment #115 from Shi Yao Wang --- Created attachment 138034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138034=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #83 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] New: DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222
Bug ID: 31222
Summary: DBIC queries for batch mod can be very large
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
We had an issue with mysql logging for a site doing many batch modifications.
The object search is currently:
Koha::Items->search({ barcode => \@contentlist }
Which generate code like:
barcode = 1 OR barcode = 2 OR barcode = 3
This can get quite large
We can reduce the query size by using -in:
Koha::Items->search({ barcode => { -in => \@contentlist } }
Which generates code like:
barcode in ( 1, 2, 3 )
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #79 from Tomás Cohen Arazi --- Created attachment 138039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138039=edit Bug 23838: (QA follow-up) Rename patron-renewal => checkout-renewal Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #133502|0 |1 is obsolete|| --- Comment #116 from Shi Yao Wang --- Created attachment 138035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138035=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option should be available as a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157 --- Comment #4 from Katrin Fischer --- I've tried to understand how the code works and I think this doesn't quite work the option and the pref describe it: Set the from address for the notice to one of 'item-homebranch' or 'item-issuebranch'. 1) Option influences item selection To test: * In Centerville, check out: * 1 item from Centerville * 1 item from Fairview Run the overdue_notices script with default/item-issuebranch setting: * checkout library is used, 1 notice, listing both items Run the overdue_notices script with item-homebranch setting: * home library is used, 2 notices, each listing 1 item Conclusion: this is not only about the from address setting, but more importantly it influence how the overdue items are grouped/selected. 2) Email settings item-issuebranch CPL is used item-homebranch CPL and FPL are used, as you'd expect. I feel like this works, but the descriptions make you think it's only about a specific email header setting, which is not true. It will use the 'email configuration' of either the home library or checkout library and it will group the overdue items accordingly. I'll try to provide a follow-up with a suggestion for a slightly different wording. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31223] New: Batch edit items - not working anymore in 22.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Bug ID: 31223 Summary: Batch edit items - not working anymore in 22.05 Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: isabel.pin...@ds.edu.sv QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl In a register with several items I select all (or some) items and click "edit selected items". I make the modification (write a public note, change the signature, change item type etc.) and click "Save", the modifications don't get saved. It used to work in previous versions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222
--- Comment #1 from Nick Clemens ---
Created attachment 138038
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138038=edit
Bug 31222: Reduce query size for batchMod
The object search is currently:
Koha::Items->search({ barcode => \@contentlist }
Which generate code like:
barcode = 1 OR barcode = 2 OR barcode = 3
This can get quite large
We can reduce the query size by using -in:
Koha::Items->search({ barcode => { -in => \@contentlist } }
Which generates code like:
barcode in ( 1, 2, 3 )
To test:
1 - Apply patch
2 - Perform batch modifications
3 - Confirm nothing has changed
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
