[Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Jonathan Druart changed: What|Removed |Added Attachment #137798|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 138452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138452&action=edit Bug 28707: Translate RECEIPT notice There is a badly crafted regex used when extracting strings in multiline fields in yaml files The regex is my own, introduced in Bug 24262, sorry. This patch correct it a little. Better eyes are welcome. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing strings egrep "Total out|Operator ID|August 31" po/fr-CA-installer.po first two are from sample notices, third from sample creator data 3) apply the patch, repeat 1) 4) repeat 2), verify the strings are present in the translation file 5) translate some of the new strings, install the language, verify strings are present in the translated files ./translate install fr-CA check fr-CA/optional/sample_creator_data.yml and fr-CA/mandatory/sample_notices.yml There are some 60+ new strings. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 --- Comment #12 from Jonathan Druart --- Created attachment 138456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138456&action=edit Bug 29971: Add selenium tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #26 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #87104|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122550|0 |1 is obsolete|| --- Comment #92 from Victor Grousset/tuxayo --- Created attachment 138419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138419&action=edit Bug 26282: Update Holds to pull Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 --- Comment #15 from Jonathan Druart --- Hi Andreas, The test is failing for me: kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/selenium/opacshelfbrowser.t t/db_dependent/selenium/opacshelfbrowser.t .. # No tests run! t/db_dependent/selenium/opacshelfbrowser.t .. 1/3 # Failed test 'No tests run for subtest "OPAC Shelf browser - Check display of local cover images (OpacSeparateHoldings set to "Don't separate")"' # at t/db_dependent/selenium/opacshelfbrowser.t line 137. upload_file: no such file: ./opacshelfbrowser-test-image1.jpg at t/db_dependent/selenium/opacshelfbrowser.t line 120. Also: +# test image by Kourosh Qaffari on Unsplash (https://unsplash.com/photos/RrhhzitYizg) The Unspash license does not seem GPLv3 compatible: https://unsplash.com/license To avoid an unnecessary discussion about the license (which is not at all the goal here :D), and to prevent a 50kb to be added to the git repo, shouldn't we go with 1px images? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456
--- Comment #104 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #102)
> I am sorry, but I get this error when trying to return an item with a hold
> on it:
>
> Can't call method "id" on an undefined value at
> /kohadevbox/koha/circ/returns.pl line 351
>
> 349: # is there a waiting hold for the item, for which cancellation
> 350: # has been requested?
> 351: my $waiting_holds_to_be_cancelled =
> 352: Koha::Holds->waiting->search( { itemnumber => $item->id } )
> 353: ->filter_by_has_cancellation_requests;
> 354: while ( my $hold = $waiting_holds_to_be_cancelled->next ) {
Sorry, I cannot reproduce. I tried with:
- 3 item-level holds, for different patrons, on same item
- 1 biblio-level hold
- Doing a check-in for a not having item-level hold item on the biblio
=> SUCCESS: biblio-level hold trapped, offered to confirm. tried both
confirming and discarding.
The fact it breaks on $item->id is pointing me to something else: it means the
item hasn't been found using the barcode. So... it must be something else on
your branch that wasn't correctly rebased after this one got pushed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30543] Decouple DumpSearchQueryTemplate from other template dump preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30543 ByWater Sandboxes changed: What|Removed |Added Attachment #133310|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 138485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138485&action=edit Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences To test: 1 - Enable DumpSearchQueryTemplate 2 - Confirm you can find the search query in the HTML as a comment 3 - Enable other template dump preference 4 - Confirm they work as before 5 - Confirm new description of preference makes sense Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31235] UseDaysMode is used for calculating the expiration date for waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235 Jonathan Druart changed: What|Removed |Added Depends on||24159 CC||jonathan.druart+koha@gmail. ||com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 [Bug 24159] Allow daysMode for calculating due and renewal dates to be set at the circulation rules level -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Marcel de Rooy changed: What|Removed |Added Attachment #137802|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 138448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138448&action=edit Bug 27849: Koha::Token may access undefined C4::Context->userenv The _add_default_csrf_params internal function accesses C4::Context->userenv without checking that it has been defined. I think not all of the potential callers of it declare that they require a defined userenv, so we should test and provide defaults for required values if it is not defined, to avoid some "Can't use an undefined value as a HASH reference" HTTP 500 Internal Server Errors. To test: Do anything that requires a form with CSRF token, such as editing your details. Behaviour should be unchanged. To test the failure case, you would need some customised code that indirectly generates a CSRF token before setting the userenv up and I am not sure there is any in released Koha yet. Signed-off-by: Paul Derscheid Looks good to me. Working as expected. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What|Removed |Added Attachment #138254|0 |1 is obsolete|| --- Comment #67 from Jonathan Druart --- Created attachment 138427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138427&action=edit Bug 29897: Don't use $6 for linkage but build the link instead See comment 26: $6 is a very specialized field that will never contain a URL. Linkage here means 'linking MARC fields within the record'. For example it is used to link an original script tag with the corresponding tag in transliteration. See: https://www.loc.gov/marc/authority/ecadcntf.html Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Tomás Cohen Arazi changed: What|Removed |Added Attachment #138232|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122448|0 |1 is obsolete|| --- Comment #80 from Victor Grousset/tuxayo --- Created attachment 138407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138407&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122452|0 |1 is obsolete|| --- Comment #87 from Victor Grousset/tuxayo --- Created attachment 138414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138414&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description to explain consequences of setting in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448 --- Comment #2 from Nick Clemens --- In Koha, a 'keyword' search does not search a cpombined 'keyword' field, but rather searches your term across all the fields marked as 'searchable' in the current interface. Cross fields is used to determine whether you want to only return values where all entered terms are included in a single search field, or whether you wish to find a record with all terms, but allowing the terms to be in any combination of fields. e.g. "king grass" without cross fields will return: The Island of the Grass King by Nancy Willard (grass in title/king in title) with cross fields will return: The Island of the Grass King by Nancy Willard (grass in title/king in title) In the tall grass by Stephen King (grass in title/king in author) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #79 from Katrin Fischer --- Created attachment 138487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138487&action=edit Bug 29897: (QA follow-up) Add valid $2 codes to pref description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31275] New: AdditionalContents.search_for_display returns branch block and All block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Bug ID: 31275 Summary: AdditionalContents.search_for_display returns branch block and All block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org If there is a branch specific block, you normally dont want the All block to appear too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #8 from Jonathan Druart --- Shouldn't be named account_lines instead of accountlines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What|Removed |Added Attachment #138258|0 |1 is obsolete|| --- Comment #71 from Jonathan Druart --- Created attachment 138431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138431&action=edit Bug 29897: Move the identifier list to an include file Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Add a curbside pickup module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #163 from Jonathan Druart --- Created attachment 138401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138401&action=edit Bug 30650: Add missing koha_object[s]_class methods To fix TestBuilder.t # at t/db_dependent/TestBuilder.t line 453. # got: 'Can't locate Koha/CurbsidePickupPolicys.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #1 from Chris Nighswonger --- Please post this URL from your instance: http://staff-client.kohadev.org/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=1&layout_id=5&start_label=1 Include the parameters which cause the loop. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #64 from Katrin Fischer --- Hi Joubu, it almost works perfectly now, but: The author identifiers don't only show on their own tab, but on all tabs on the OPAC detail page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart --- You need to adjust t/db_dependent/Koha/Reports.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | --- Comment #4 from Katrin Fischer --- Please don't forget to fill in the assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 --- Comment #11 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > Is that what you wanted? Yes, that's much better - thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What|Removed |Added Attachment #138260|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart --- Created attachment 138433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138433&action=edit Bug 29897: Fix tab display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New interface for staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 --- Comment #146 from Katrin Fischer --- (In reply to Julian Maurice from comment #145) > Sandbox recreated will all patches: > https://staff-bug30952.sandboxes.biblibre.eu I've posted the link into the discussion on the mailing list - thanks a lot for setting this up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31274] OPACSuggestionAutoFill must be 1 or 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 138476
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138476&action=edit
Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere
The YAML preference definition defines it as a string ('yes' or 'no' the
possible values). And the opac-suggestions.tt template has one occurence
of the variable being compared to a string.
This patch does:
- fix the template
- fixes opac.pref for 0|1
- adds an atomicupdate that takes care of moving 'yes' and 'no' to their
respective boolean values.
To test:
1. Change the syspref value to enable/disable
2. Check on the DB that the value is wrong:
$ koha-mysql kohadev
> SELECT value FROM systempreferences WHERE
variable='OPACSuggestionAutoFill';
=> FAIL: It is either 'yes' or 'no' depending on what you choose.
3. Apply this patch
4. Run:
$ updatedatabase
5. Repeat 2
=> SUCCESS: Values are now 0 or 1
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #26 from Victor Grousset/tuxayo --- (tests still pass) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138408|0 |1 is obsolete|| --- Comment #84 from Victor Grousset/tuxayo --- Created attachment 138411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138411&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27849] Koha::Token may access undefined C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What|Removed |Added Attachment #138253|0 |1 is obsolete|| --- Comment #66 from Jonathan Druart --- Created attachment 138426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138426&action=edit Bug 29897: Fix linkage Signed-off-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 --- Comment #12 from Jonathan Druart --- Also removing items_rs is a step backward compared to bug 28299. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #3 from Jonathan Druart --- I am very bad at that. Owen, could you help me please? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31262] Curbside pickups - disable dates without slots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart changed: What|Removed |Added Attachment #138403|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What|Removed |Added Attachment #138256|0 |1 is obsolete|| --- Comment #69 from Jonathan Druart --- Created attachment 138429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138429&action=edit Bug 29897: Improve syspref's description Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #13 from Jonathan Druart --- Created attachment 138445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138445&action=edit Bug 30874: 2 more - need more investigation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468 --- Comment #9 from Jonathan Druart --- What about this patch? Set to PQA if you agree with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31262] Curbside pickups - disable dates without slots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31261] Curbside pickups - remove dates in the past
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138409|0 |1 is obsolete|| --- Comment #85 from Victor Grousset/tuxayo --- Created attachment 138412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138412&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31269] DataTables error when managing staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Katrin Fischer changed: What|Removed |Added Attachment #138404|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 138422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138422&action=edit Bug 31264: Curbside pickups - Take CalendarFirstDayOfWeek into account We need to take the pref CalendarFirstDayOfWeek into account to display the days on the curbside pickups admin page. Test plan: Turn on the CurbsidePickup pref Set CalendarFirstDayOfWeek to Sunday Go to the curbside pickups admin page, add new slots, and confirm that Sunday is displayed first. Try again with CalendarFirstDayOfWeek set to Monday and Saturday. Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #122451|0 |1 is obsolete|| --- Comment #86 from Victor Grousset/tuxayo --- Created attachment 138413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138413&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #87103|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Katrin Fischer changed: What|Removed |Added Attachment #137309|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 138420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138420&action=edit Bug 30965: Add patron autocomplete search to curbside pickups Prior to this patch librarians had to know the cardnumber to search for patron. Now it's possible to search using the default patron autocomplete search (name, cardnumber, etc.) Test plan: Confirm that you can search for a patron without their cardnumber, select it and create a curbside pickup Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Add a curbside pickup module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #164 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #160) > Great job, Jonathan. > > - We could use some more unit tests Which missing tests did you identify? > - Some of this could've been squashed, specially the typos, etc. Yes, they should have been. I submitted to easy the QA review, but they could have been squashed before push for sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
