[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139317|0 |1 is obsolete|| --- Comment #12 from David Cook --- Created attachment 139319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139319=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139316|0 |1 is obsolete|| --- Comment #11 from David Cook --- Created attachment 139318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139318=edit Bug 31380: Allow Koha Plugins to run using Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart 3) Go to http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl 4) Next to "Mojolicious Test", click "Actions", then click "Run tool" 5) Note that the web page looks perfect 6) Note that the URL is a bit different to normal: http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool instead of: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool Note: The test Koha plugin will only work with a Mojolicious controller, but it could be easily made to work with both -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139315|0 |1 is obsolete|| --- Comment #10 from David Cook --- Created attachment 139317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139317=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139314|0 |1 is obsolete|| --- Comment #9 from David Cook --- Created attachment 139316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139316=edit Bug 31380: Allow Koha Plugins to run using Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart 3) Go to http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl 4) Next to "Mojolicious Test", click "Actions", then click "Run tool" 5) Note that the web page looks perfect 6) Note that the URL is a bit different to normal: http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool instead of: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool Note: The test Koha plugin will only work with a Mojolicious controller, but it could be easily made to work with both -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks||31391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 [Bug 31391] Staff-side recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Depends on||19532 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] New: Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Bug ID: 31391 Summary: Staff-side recalls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Add functionality for recalls to be placed via the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30837] Fix table width on 'Print summary'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 --- Comment #15 from Fridolin Somers --- (In reply to Arthur Suzuki from comment #13) > pushed to 21.11.x for 21.11.11 Great thanks Arthur. It will make happy librarians ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139312|0 |1 is obsolete|| --- Comment #8 from David Cook --- Created attachment 139315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139315=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139308|0 |1 is obsolete|| --- Comment #7 from David Cook --- Created attachment 139314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139314=edit Bug 31380: Build core functionality for Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart 3) Go to http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool 4) Note that it looks perfect 5) The following URL will generate a 500 error, but technically the Koha Plugin could easily be crafted to support both CGI and Mojolicious::Controller objects: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #6 from David Cook --- I think that this is ready for sign off. Let me know if you have any additional feedback, and I can keep working on it. Otherwise, I'd consider this done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Attachment #139309|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #5 from David Cook --- Created attachment 139313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139313=edit Koha Plugin with Mojolicious controller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #4 from David Cook --- Created attachment 139312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139312=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 --- Comment #1 from David Cook --- Created attachment 139311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139311=edit Bug 31389: Calculate user permissions in separate function This patch refactors the setting of user permissions for templates into a new function, which can be easily unit tested and reduces the amount of code in C4::Auth::get_template_and_user(). It also aids in the re-usability of permission checking code. Test plan: 0) Apply patch and koha-plack --restart kohadev 1) prove t/Koha/Auth/Permissions.t 2) As koha superlibrarian, go to http://localhost:8081/cgi-bin/koha/tools/tools-home.pl 3) Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 4) Create new test user with "Staff access..." and "Remaining circulation permissions" 5) Logout of koha superlibrarian 6) Login as test user 7) Note you can only see a limited view of the staff interface (i.e. no administration, no tools, no reports, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30837] Fix table width on 'Print summary'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC||vic...@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #16 from David Cook --- (In reply to Jonathan Druart from comment #8) > IN limit is max_allowed_packet, which is 16M by default. (In reply to Jonathan Druart from comment #9) > Why do we want to reduce mysql query length exactly? You are not supposed to > have mysql logging in production servers, you will face perf issues (but I > guess you know that already). While I don't think I've seen it in Koha, I have seen other systems throw MySQL errors, because their SQL queries were too long. Of course "barcode in(?, ?, ?)" could still have that happen, but I suppose it's less likely than "barcode = ? or barcode = ? or barcode = ?". -- I keep looking at https://mariadb.com/kb/en/in/, but it doesn't really make sense outside their limited examples. In the example 'SELECT 2 IN (0,3,5,7);' it makes sense that it would do a binary search of that value list, since that would be the most efficient operation. It would just need to do 1 search. However, if it's "SELECT barcode WHERE barcode IN (1,2,3,4,5)", then it would be extremely inefficient to binary search the value list, because it would have to row scan the whole table for each "barcode" field and then binary search the value list. At a glance, it looks like both query styles actually have the same performance: analyze select * from items where barcode = '1' or barcode = '2' or barcode = '3' or barcode = '4' or barcode = '5'; analyze select * from items where barcode in ('1','2','3','4','5'); Both queries do a range query using the itembarcodeidx. Now that idea of the database row scanning the whole table and then binary searching the value list can still happen, if the number of rows in the database is < the number of values in the value list. For example: analyze select * from z3950servers where id in ('1','2','3','4','5'); That will do an ALL type query (ie table scan of every row). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31348] Plack stop should be graceful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 --- Comment #3 from David Cook --- (In reply to Jonathan Druart from comment #2) > Same for debian/scripts/koha-z3950-responder? I don't think so. The QUIT signal is specific to Starman. The Z3950 responder might have signal handling somewhere but I didn't notice anything at a glance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 David Cook changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 --- Comment #1 from David Cook --- Created attachment 139310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139310=edit Bug 31390: Remove noisy warns in C4::Templates This patch removes two noisy warnings from C4::Templates 0) Apply patch and koha-plack --restart kohadev 1) Go to http://localhost:8081/ 2) Note no warnings in /var/log/koha/kohadev/plack-intranet-error.log 3) Go to http://localhost:8080/ 3) Note no warnings in /var/log/koha/kohadev/plack-opac-error.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 David Cook changed: What|Removed |Added Blocks||31380 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 [Bug 31380] Build Mojolicious controller for running Koha plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Depends on||31390 --- Comment #3 from David Cook --- The Koha::Auth class contains a function which should use Bug 31389 instead, so that will be my next thing to do. Currently, the Koha::Template class generates the following warnings: [2022/08/18 00:55:50] [WARN] no query in gettemplate at /kohadevbox/koha/C4/Templates.pm line 216. [2022/08/18 00:55:50] [WARN] no query in themelanguage at /kohadevbox/koha/C4/Templates.pm line 276. [2022/08/18 00:55:50] [WARN] no query in themelanguage at /kohadevbox/koha/C4/Templates.pm line 276. Bug 31390 should take care of those warnings though. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 [Bug 31390] Remove noisy warns in C4::Templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27293 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31380 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] New: Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Bug ID: 31390 Summary: Remove noisy warns in C4::Templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org If you don't provide a $query argument for C4::Templates::gettemplate it will warn, but it's just passing the $query object to C4::Languages::getlanguage() which is often invoked in Koha without it. It's a totally unnecessary warning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #2 from David Cook --- Created attachment 139309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139309=edit Koha Plugin with Mojolicious controller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #216 from Fridolin Somers --- Up ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #1 from David Cook --- Created attachment 139308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139308=edit Bug 31380: Build core functionality for Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart 3) Go to http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool 4) Note that it looks perfect 5) The following URL will generate a 500 error, but technically the Koha Plugin could easily be crafted to support both CGI and Mojolicious::Controller objects: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious=tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31380 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27293 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27293 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26791 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 David Cook changed: What|Removed |Added Blocks||31380 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 [Bug 31380] Build Mojolicious controller for running Koha plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What|Removed |Added Depends on||31389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 [Bug 31389] Calculate user permissions in separate function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31389 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27342 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] New: Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Bug ID: 31389 Summary: Calculate user permissions in separate function Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org C4::Auth::get_template_and_user() is an extremely long function. By decomposing it into functions, it becomes easier to test and re-use those functions elsewhere. The current calculation of "CAN_user_*" is also inefficient and contains some unused code, so this would help to clean it up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31352] Terminology: Borrower name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 David Nind changed: What|Removed |Added Text to go in the||This updates the table release notes||heading name from "Borrower ||name" to "Patron name" when ||adding a new batch in the ||patron card creator. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31352] Terminology: Borrower name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 David Nind changed: What|Removed |Added Attachment #139167|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 139307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139307=edit Bug 31352: Change 'Borrower name' to 'Patron name' Test plan: 1. Go to Tools > Patron card creator > New > Card batch 2. Enter a borrowernumber and click 'Add patron(s)' 3. Observe a table with the leftmost column name 'Borrower name' loads 4. Apply patch 5. Refresh page 6. Observe the leftmost column name is 'Patron name' Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31352] Terminology: Borrower name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31352 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 David Nind changed: What|Removed |Added Text to go in the||This fixes the patron release notes||self-registration form so ||that the 'Other names' ||(othernames) field ||correctly displays the text ||'Required' when this is set ||as required (using the ||PatronSelfRegistrationBorro ||werMandatoryField system ||preference). Currently, ||this text is not displayed ||(however, an error message ||is displayed when ||submitting the form). CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 David Nind changed: What|Removed |Added Attachment #139300|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 139306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139306=edit Bug 31387: Fix othernames required label 1. Mark othernames as required via PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self-reg form, the field is required but the span that makes it look required stays hidden. (Required) 3. Mark initials as required via PatronSelfRegistrationBorrowerMandatoryField. 4. Now the label_required field appears for othernames in the self ref form 5. Apply patch 6. Try again, the label should now properly show when othernames is marked as required Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 Alex Buckley changed: What|Removed |Added Text to go in the|This enhancement restarts |This enhancement restarts release notes|services if they are not|services if they are not |running when using the |running when using the |--restart option for|--restart option for |koha-plack, koha-indexer, |koha-plack, koha-indexer, |koha-sip, koha-worker, |koha-sip, koha-worker, |koha-z3950-responder, and |koha-z3950-responder, and |koha-zebra . Before this, |koha-zebra . |if a service was not| |running an error message|An example |was generated (Error: |of a message if plack is |{servicename} not running |not running and the service |for ${instancename}") and a |is restarted: |start command for the |koha-plack |service was required. |--restart kohadev ||[warn] |Example of message if plack |Plack not running for |is not running and the |kohadev. ... (warning). |service is restarted: |[ ||ok ] Starting Plack daemon |koha-plack --restart|for kohadev:. |kohadev | | Plack not running |Previously |for kohadev.:Starting Plack |if a service was not |daemon for kohadev:.|running an error message ||was generated (Error: ||{servicename} not running ||for ${instancename}") and a ||start command for the ||service was required. --- Comment #32 from Alex Buckley --- (In reply to Jonathan Druart from comment #30) > Alex, try 'log_warning_msg' for the "not running" warning. Thanks Jonathan. Is that follow-up any better now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 --- Comment #31 from Alex Buckley --- Created attachment 139305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139305=edit Bug 30684: (follow-up) Use log_warning_msg for the "not running" warning Also, return 0 rather than return 1 in else clause of koha-zebra Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 Alex Buckley changed: What|Removed |Added Attachment #139247|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Version(s)|22.11.00, 22.05.03, |22.11.00, 22.05.03, released in|21.11.11|21.11.11, 21.05.18 Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.18 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30716] Add Collection column to cn_browser results table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30716 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30567] Create manual invoice with FR currency format show the incorrect format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC||vic...@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31066] Can't use regex in batch modification on fields associated with a plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31066 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|22.11.00, 22.05.04, |22.11.00, 22.05.04, released in|21.11.11|21.11.11, 21.05.18 Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #23 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.18 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 --- Comment #2 from Fridolin Somers --- If sound OK i will create a patch for creation of order from other sources. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 --- Comment #1 from Fridolin Somers --- Created attachment 139304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139304=edit Bug 31388: Add select2 to fund selection in new order form In new order form, when you have a lot of funds, would be useful to have autocompletion in funds combobox. Test plan : 1) Create an activ and an inactiv budget with at least one fund 2) Create a new order 'From a new (empty) record' 3) Check you see autocompletion in 'Fund' combobox 4) Click on 'Show inactive' 5) Check you see inactiv funds in combobox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23465] Add item form in acq is missing Select2 style selects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23465 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31388 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23465 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] New: Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Bug ID: 31388 Summary: Add select2 to fund selection in new order form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org In new order form, when you have a lot of funds, would be useful to have autocompletion in funds combobox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26993] Allow StoreLastBorrower to retain up to 2 previous patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #4 from Wally DesChamps --- Here are two reports we use. They are effective unless the patron marks their account to not keep their history. Check-Outs in a date range 1 SELECT i.barcode as 'Item Barcode', 2 b.title as 'Title', 3 i.itemcallnumber as 'Item Call Number', 4 a.timestamp as 'Date and Time', 5 concat(borr.surname,", ",borr.firstname) as 'Patron Name', 6 borr.cardnumber as 'Patron Barcode' 7 FROM action_logs a 8 LEFT JOIN borrowers borr on (borr.borrowernumber=a.object) 9 LEFT JOIN items i on (i.itemnumber=a.info) 10 INNER JOIN biblio b on (b.biblionumber=i.biblionumber) 11 WHERE a.action='ISSUE' AND DATE(a.timestamp) BETWEEN <> AND <> 12 ORDER BY borr.firstname asc Circulation History of an Item. NOTE: Must edit/save the SQL of the report with the target item’s barcode (in line 14 below). 1 SELECT 2 borrowers.cardnumber as "Cardnumber", 3 borrowers.othernames as "Othername", 4 borrowers.surname as "Surname", 5 items.itype, 6 items.barcode, 7 items.itemcallnumber as "Call Number", 8 date(statistics.datetime) as "Transaction Date", 9 statistics.type as "Transaction Type" 10 FROM borrowers 11 LEFT JOIN statistics on (statistics.borrowernumber=borrowers.borrowernumber) 12 LEFT JOIN items on (items.itemnumber = statistics.itemnumber) 13 LEFT JOIN biblioitems on (biblioitems.biblioitemnumber = items.biblioitemnumber) 14 WHERE items.barcode='2194456' 15 ORDER BY statistics.datetime DESC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25622] Change way MySQL password is generated by koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25622 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #21 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). See comment 15 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #23 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31062] Change description of QOTD tool in tools-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31062 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Needs documenting CC||vic...@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. (In reply to Caroline Cyr La Rose from comment #9) > This will need an update of the manual. I'm not sure in the new workflow > when this is supposed to be changed to "Needs documenting". Thanks for saying it, I would have wrongly guessed that it changed nothing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26993] Allow StoreLastBorrower to retain up to 2 previous patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Erik Stevens changed: What|Removed |Added Priority|P5 - low|P2 CC||technol...@haineslibrary.or ||g --- Comment #3 from Erik Stevens --- We would love to see this feature. It has come up several times that the item was damaged by the 2nd-to last patron, and we have no record of who that was. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31064] Local login is difficult to style using CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. It looks like there is nothing to document, correct me if I'm wrong, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 31085, which changed state. Bug 31085 Summary: The return claims table no longer reloads on resolution https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31085] The return claims table no longer reloads on resolution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 31087, which changed state. Bug 31087 Summary: Undefined notes in returns claims get stringified to 'null' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31087] Undefined notes in returns claims get stringified to 'null'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to stable|RESOLVED --- Comment #5 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31106] Error searching for analytics in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Bug 31106 depends on bug 30865, which changed state. Bug 30865 Summary: Koha::Biblio->get_components_query should double quote Host-item search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 139303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139303=edit Bug 31382: Pass password_has_expired param to templte This patch restores the param, while still leaving the check against invalid login credentials to ensure we don't leak information. To test: 1 - enable EnableExpiredPasswordReset 2 - Edit a patron to set password to expire in the past 3 - Attempt opac login as patron 4 - It fails, but you are redirected to login screen with no info 5 - Apply patch 6 - Attempt login 7 - You are notified password expired and given reset link 8 - Go back to login screen 9 - Login with correct username,, wrong password 10 - You are notified of incorrect credentials, not password expiration Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 139302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139302=edit Bug 31382: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 Tomás Cohen Arazi changed: What|Removed |Added Attachment #139297|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316 Teresa Van Doren changed: What|Removed |Added CC||tvando...@blackgold.org --- Comment #7 from Teresa Van Doren --- Black Gold is a 6 library consortium and our libraries are asking to be able to choose their Z39.50 search targets by the library, rather than the global setting. Thank you. tvando...@blackgold.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #69 from Katrin Fischer --- Handing over to Martin for final QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #68 from Katrin Fischer --- Created attachment 139301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139301=edit Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 --- Comment #1 from Lucas Gass --- Created attachment 139300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139300=edit Bug 31387: Fix othernames required label 1. Mark othernames as required via PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self-reg form, the field is required but the span that makes it look required stays hidden. (Required) 3. Mark initials as required via PatronSelfRegistrationBorrowerMandatoryField. 4. Now the label_required field appears for othernames in the self ref form 5. Apply patch 6. Try again, the label should now properly show when othernames is marked as required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] New: Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Bug ID: 31387 Summary: Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: lu...@bywatersolutions.com Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Mark othernames as required via PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self-reg form, the field is required but the span that makes it look required stays hidden. (Required) 3. Mark initials as required via PatronSelfRegistrationBorrowerMandatoryField. 4. Now the label_required field appears for othernames in the self ref form This is because of a cut/paste error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Kyle M Hall changed: What|Removed |Added Attachment #139209|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 139299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139299=edit Bug 29782: Fix handling records without title or content Test plan: Save a new record with only a title in the non-default tab (english). Check if you see it on the list. Edit. Save a new record without title but only content in non-default lang. Check if you see it. Do the same 2 edits on the default tab only. Verify too. Signed-off-by: Marcel de Rooy Signed-off-by: Caroline Cyr La Rose Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31385] opac-page: Allow searching a page by code in multilanguage env
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 --- Comment #13 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #7) > What makes sense to me is to pass the id and optionally the language. Look > up the news item by id. > > We now have the code based on the id. If the language of this one doesn't > match the given and logged in language, use the code from this one to look > of the correct language version. > > This means we don't need to go mucking about in the database to find the > code for the page. Will open another report to show this code URL on the additional contents page, and the need for looking it up will be gone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31385] opac-page: Allow searching a page by code in multilanguage env
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 --- Comment #12 from Marcel de Rooy --- Created attachment 139298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139298=edit Bug 31385: (follow-up) Switch to language param As Katrin suggested, we should use the language URL param instead. If you pass code, we use the language cookie as fallback. If that does not work, we look for default. Test plan: Try former test plan but use code=X=Y. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31385] opac-page: Allow searching a page by code in multilanguage env
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 --- Comment #11 from Katrin Fischer --- I thin default will always be the native language, but it's supposed to be a fallback. I don't think that triggering it directly makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31385] opac-page: Allow searching a page by code in multilanguage env
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 --- Comment #10 from Marcel de Rooy --- Kyle suggest to pass the page_id which refers to the default record. But when you pass a language too, you could switch to the specific language. It feels a bit odd however to do so. I think it should be possible to pass default. You could use it as your native language in additional contents to reduce records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31382] Cannot reach password reset page when password expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31382 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/