[Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What|Removed |Added Attachment #139440|0 |1 is obsolete|| Attachment #139441|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 139646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139646=edit Bug 31415: Script to automate converting reserves to recalls This is a work in progress and not ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Blocks||31415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 [Bug 31415] Script to automate converting reserves to recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks|31415 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 [Bug 31415] Script to automate converting reserves to recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What|Removed |Added Depends on|19532 |31391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 [Bug 31391] Staff-side recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||ability to place recalls ||via the staff interface by ||introducing a system ||preference, ||RecallsInterface, to ||configure where recalls can ||be placed. Recalls can ||either be placed via the ||OPAC, or the staff ||interface, or both. This is ||set to OPAC by default to ||be consistent with current ||behaviour. || ||This ||enhancement also adds the ||ability to convert existing ||reserves to recalls easily ||via the staff interface. ||The reserve will be ||cancelled and a recall ||placed using the reserve's ||information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #9 from Aleisha Amohia --- Created attachment 139645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139645=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #8 from Aleisha Amohia --- Created attachment 139644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139644=edit Bug 31391: Implement RecallsInterface on OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #7 from Aleisha Amohia --- Created attachment 139643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139643=edit Bug 31391: Recalled authorised value for hold cancellation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Attachment #139442|0 |1 is obsolete|| Attachment #139443|0 |1 is obsolete|| Attachment #139446|0 |1 is obsolete|| --- Comment #6 from Aleisha Amohia --- Created attachment 139642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139642=edit Bug 31391: RecallsInterface system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Medium patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 --- Comment #28 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #19) > Applied the patches, restart_all: > > * The page loads ok, table is empty in my installation > * I check the "Only include jobs started in the last hour" checkbox: > Error: Something went wrong when loading the table. > 500: Internal Server Error > > In my background_jobs table I have several entries, one for > batch_item_record_modification and several update_elastic_index. All are > finished. I don't get the issue. Tested with empty db table and after checking in an item of a record on hold I get a Holds queue update and Update Elasticsearch index entry. (why is there an ES entry update?) The change here since your test doesn't look like to be able to fix that. And there were no changes on bug 30462. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #27 from Victor Grousset/tuxayo --- Rebased to fix conflict. Tests still pass. (t/db_dependent/api/v1/background_jobs.t) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138114|0 |1 is obsolete|| --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 139641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139641=edit Bug 30982: Add 'context' to the REST API specs context has been added by bug 30889 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136715|0 |1 is obsolete|| --- Comment #25 from Victor Grousset/tuxayo --- Created attachment 139640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139640=edit Bug 30982: Make code more re-usable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136707|0 |1 is obsolete|| --- Comment #24 from Victor Grousset/tuxayo --- Created attachment 139639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139639=edit Bug 30982: Add tests and implement GET /background_jobs/$id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136672|0 |1 is obsolete|| --- Comment #23 from Victor Grousset/tuxayo --- Created attachment 139638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139638=edit Bug 30982: (QA follow-up) Double quoting and console.log This patch fixes the issues highlighted by the QA script; We use double quotes for translatable strings in JS and remove an errant console.log call. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136671|0 |1 is obsolete|| --- Comment #22 from Victor Grousset/tuxayo --- Created attachment 139637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139637=edit Bug 30982: Use the REST API for background job list view Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #136670|0 |1 is obsolete|| --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 139636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139636=edit Bug 30982: REST API specs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #44 from Victor Grousset/tuxayo --- Here is a rebase. Placing hold from staff and OPAC still works. Changing priorities and marking as waiting still works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #7 from David Cook --- (In reply to Katrin Fischer from comment #6) > Yep, that's it :) I've often struggled to explain why that is to users as > well. The item search is exact, but for the catalog search (doesn't matter > if Zebra or Elastic) this is an unresolved issue. I'm not familiar with Koha's integration with Elastic, but I think it is solvable with Elastic, since it allows different data types and nested data structures. We use Elastic for other projects, and we've got it so that you can do an "AND" across different values in that deeper nested structure. We're going to be looking more at Koha's Elastic integration at some stage, so probably will be commenting more in the future... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138941|0 |1 is obsolete|| --- Comment #43 from Victor Grousset/tuxayo --- Created attachment 139635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139635=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot This will save us fetching more info if we are denying the holds Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138940|0 |1 is obsolete|| --- Comment #42 from Victor Grousset/tuxayo --- Created attachment 139634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139634=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the hash is the rank and title We can simply fetch the biblio once to calculate no need to fetch all the info as we don't display or use it Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138939|0 |1 is obsolete|| --- Comment #41 from Victor Grousset/tuxayo --- Created attachment 139633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139633=edit Bug 30847: Don't declare undef variable for assignment New holds have found set to undef - we can do this directly Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138938|0 |1 is obsolete|| --- Comment #40 from Victor Grousset/tuxayo --- Created attachment 139632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139632=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to the biblionumber passed in or it is not and should be - we can just assign directly from the item in all cases Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138937|0 |1 is obsolete|| --- Comment #39 from Victor Grousset/tuxayo --- Created attachment 139631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139631=edit Bug 30847: Don't fetch patron twice Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138936|0 |1 is obsolete|| --- Comment #38 from Victor Grousset/tuxayo --- Created attachment 139630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139630=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't used! Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138935|0 |1 is obsolete|| --- Comment #37 from Victor Grousset/tuxayo --- Created attachment 139629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139629=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1 - git grep noreserve 2 - only one ocurrence 3 - Apply patch 4 - repeat, no ocurrence 5 - Note the plural has a few uses Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138934|0 |1 is obsolete|| --- Comment #36 from Victor Grousset/tuxayo --- Created attachment 139628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139628=edit Bug 30847: Cleanup calculation of holds and rank Currently we loop over all the holds on the record to get a count of the reserves not waiting and a rank for the upcoming hold We can simply count the number of nont waiting holds and add 1 Note: Before this patch the count of holds included the new hold we were going to place which meant rank and count were the same. I believe countaing existing holds and our upcoming rank is the correct behavior To test: 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their priorty level' 2 - Place a few holds on a bib on the staff side 3 - Mark 1 waiting 4 - Attempt to place hold on the bib on the opac 5 - Note 'Your priority' and 'Number of holds' are the same number 6 - Place another hold, confirm both increase 7 - Set another hold waiting, confirm both decrease 8 - Apply patch 9 - Confirm 'Your priority' is now 1 greater than Number of holds 10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31220] Error when attempting to export selected labels as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30666] Holds reminder cronjob (holds_reminder.pl) uses DateTime::subtract wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30666 Bug 30666 depends on bug 30667, which changed state. Bug 30667 Summary: Holds reminder cronjob (holds_reminder.pl) never uses default letter template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30667] Holds reminder cronjob (holds_reminder.pl) never uses default letter template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to stable|RESOLVED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > (In reply to David Cook from comment #9) > > This sounds so hacky but if it works... > > We often have libraries with callnumbers containing special characters (most > of our libraries use custom classifications) like ( ) [] etc. that make an > unquoted search return nothing. So I think this will prove helpful. > > Quoting right away would take the ability to truncate etc. away, but as a > second step it makes sense. I'm happy to agree to disagree when it comes to search :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #109 from Victor Grousset/tuxayo --- Hi :) There is a new version of Koha every 6 months. On November and May https://koha-community.org/about/release-schedule/ The last 3 major versions are still maintained and get monthly releases. So it's possible that 22.05, 21.11 and 21.05 will get this enhancement. Stay tuned to this ticket to know if that will be the case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #25 from David Cook --- (In reply to Marcel de Rooy from comment #23) > If you enable --preload-app option, however, the code will be only loaded in > the startup process and will not pick up the code changes you made. If you > want to preload the app and do graceful restarts by reloading the code > changes, you're recommended to use Server::Starter, configured to send QUIT > signal when superdaemon received HUP ... > [End of quote] We don't use --preload-app, so we don't need to worry about it. Even if we did use --preload-app, I think some of the text is misleading. While code changes to code that is preloaded wouldn't come through, changes to code that is lazy loaded after forking the children would still come through. I use mod_perl for a different Perl app where I preload the core Catalyst application into the httpd master process so that slow setup like the ORM just takes place 1 time, and then all the lazy loads for function specific things happen within the child processes. > While testing with about and inserting a small code change, I notice that > while I started the about web request before the plack reload, the code > change already is visible in the web request. > I think that this is not what we want here ? If you want to test a small code change, you'd need to first make sure that all Starman workers have already cached the about.pl page in their CGI to PSGI cache. Once they're cached, then you can make your code change, confirm that the change isn't visible, do the reload, and then note that the change is visible. I chose the about.pl test somewhat arbitrarily because koha-testing-docker is such a small database. In production, where you really see this being useful is in search.pl and opac-search.pl where a search might take 5+ seconds. Using koha-plack --reload will wait for that long search request to complete, and then it will restart that worker. -- Does that answer your questions? I will be online a bit tonight (ie European morning) so might be able to answer more on IRC :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] Add Plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #24 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #23) > If you enable --preload-app option, however, the code will be only loaded in > the startup process and will not pick up the code changes you made. If you > want to preload the app and do graceful restarts by reloading the code > changes, you're recommended to use Server::Starter, configured to send QUIT > signal when superdaemon received HUP ... > [End of quote] > While testing with about and inserting a small code change, I notice that > while I started the about web request before the plack reload, the code > change already is visible in the web request. > I think that this is not what we want here ? What do you mean? The patch doesn't use --preload-app. I tested changing something in about.pl: once over the ~10 tries the change was reflected only by reloading the page. Otherwise I had to run `pkill starman --signal SIGHUP` to get the change. Your plack_max_requests isn't 1 is it? That would be an explanation of what you observed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #4 from Lucas Gass --- Is there a test plan? Maybe a list of tables we should check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #14 from Lucas Gass --- Created attachment 139627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139627=edit Bug 31374: (follow-up) change private note to staff_note and reorder columns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31374] Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31434] Improve display of title information when receiving orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31434 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #1 from Barbara Johnson --- +1 Being able to see the additional info about a title that is on order will increase staff efficiency and reduce mistakes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of title information throughout acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #17 from Barbara Johnson --- In my latest test, I can confirm that I am able to view the 245abhnp on basket.pl, orderreceive.pl and invoice.pl. Only the 245a info is displayed on parcel.pl and I believe bug 31434 is supposed to address that. Also, only the 245a is displayed on ordered.pl - it would be helpful to see the additional info here as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 --- Comment #70 from Victor Grousset/tuxayo --- Thanks all ^^ Oh right, that was one of the few (the only?) things not using Plack. Surprising that this has a big effect on tasks that are long where the time loading Perl and the modules should be a small fraction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31434] Improve display of title information when receiving orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31434 Andrew Fuerste-Henry changed: What|Removed |Added Summary|mprove display of title |Improve display of title |information when receiving |information when receiving |orders |orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang changed: What|Removed |Added Attachment #139625|0 |1 is obsolete|| --- Comment #22 from Shi Yao Wang --- Created attachment 139626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139626=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang changed: What|Removed |Added Attachment #132068|0 |1 is obsolete|| --- Comment #21 from Shi Yao Wang --- Created attachment 139625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139625=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31394] background hold cancellation causing confusion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #17 from Joonas Kylmälä --- Thanks Kyle for spotting the failing test. I fixed the issue by restoring the previous check that I had accidentally removed (btw, the check looks somewhat buggy actually but that's for another bug report). There was also a small issue with the follow-up patch from Nick, added a fix for that too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #99 from Shi Yao Wang --- Created attachment 139624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139624=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #16 from Joonas Kylmälä --- Created attachment 139623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139623=edit Bug 31112: (follow-up) Don't return "on_reserve" when there are 0 possible holds It's possible that there could be 0 possible reserves, for example when the hold has already been filled, thus the check would fail as the item count can never be less than 0. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31112] Able to renew checkout when the number of holds exceeds available number of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #15 from Joonas Kylmälä --- Created attachment 139622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139622=edit Bug 31112: (follow-up) Bring back the check for non-priority holds Before the changes from bug 31112 when CheckReserves returned a non-priority hold we didn't return "on_reserve" status but checked in addition to that whether there are any priority holds and if there were, only then we returned the "on_reserve" error. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23674] Allowing editable notes on all entries in patron Transactions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31254] Add additional fields for accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Azucena Aguayo changed: What|Removed |Added CC||azucena.agu...@uvu.edu --- Comment #2 from Azucena Aguayo --- Our library has the same problem. Our patrons get confused with the back to back emails for the same item telling them the item was renewed / not renewed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #57 from Andrew Fuerste-Henry --- Test plan successful once I fixed my notice! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What|Removed |Added Attachment #139612|0 |1 is obsolete|| --- Comment #56 from ByWater Sandboxes --- Created attachment 139621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139621=edit Bug 10950: (QA follow-up) Exec Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What|Removed |Added Attachment #139611|0 |1 is obsolete|| --- Comment #55 from ByWater Sandboxes --- Created attachment 139620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139620=edit Bug 10950: (follow-up) fix typo in kohastructure.sql Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What|Removed |Added Attachment #139610|0 |1 is obsolete|| --- Comment #54 from ByWater Sandboxes --- Created attachment 139619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139619=edit Bug 10950: API spec update Test plan: 1. Apply patch, restart_all, and updatedatabase 2. In the staff client go to a patron record or create a new patron. 3. Notice the pronouns field, make sure you add a value to it. 4. Now notice that the value should display in parentheses in places where the patron name is displayed. 5. Go to the details page and you should see the value display in quotes. ( next to othernames ) 6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField. 7. Check to make sure you can make the field required with BorrowerMandatoryField 8. Go to the OPAC to self register. The pronouns field should appear in the form. 9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ). 10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ). 11. Try some notices like ISSUESLIP. You should be able to add either <> or [% borrower.pronoun %] to the notice and have it display when you generate the notice. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What|Removed |Added Attachment #139609|0 |1 is obsolete|| --- Comment #53 from ByWater Sandboxes --- Created attachment 139618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139618=edit Bug 10950: Display pronouns field Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What|Removed |Added Attachment #139608|0 |1 is obsolete|| --- Comment #52 from ByWater Sandboxes --- Created attachment 139617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139617=edit Bug 10950: Add intranet/OPAC form fields Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What|Removed |Added Attachment #139607|0 |1 is obsolete|| --- Comment #51 from ByWater Sandboxes --- Created attachment 139616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139616=edit Bug 10950: Schema update Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 ByWater Sandboxes changed: What|Removed |Added Attachment #139606|0 |1 is obsolete|| --- Comment #50 from ByWater Sandboxes --- Created attachment 139615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139615=edit Bug 10950: Database update Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31373] Notice template validation is missing INCLUDE_PATH
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31389] Calculate user permissions in separate function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 139614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139614=edit Bug 31095: Add Koha::Patron::Restriction(s) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31095] Move Koha::Patron::Debarment into Koha::Object based classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Tomás Cohen Arazi changed: What|Removed |Added Summary|Koha::Patron::Debarment |Move |should be updated to follow |Koha::Patron::Debarment |current Koha:: style|into Koha::Object based ||classes CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #49 from Lucas Gass --- (In reply to Andrew Fuerste-Henry from comment #48) > I was successful with everything in this test plan except generating a > notice. > Calling <> worked fine. > Using [% borrower.pronoun %] gave me a big angry error: > > "ERROR PROCESSING TEMPLATE: undef error - The method Koha::Patron->pronoun > is not covered by tests!" Andrew, this is my fault. The test plan for step 11 should be: 11. Try some notices like ISSUESLIP. You should be able to add either <> or [% borrower.pronouns %] to the notice and have it display when you generate the notice. It is [% borrower.pronouns %] not [% borrower.pronoun %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org --- Comment #1 from Jason Robb --- Agree that this is confusing and misleading to the patron. We're seeing a consistent duplication of messages whenever something auto renews, both with digests and one-off messaging thanks to the odd too_many behavior. The too_many error is also getting sent while a title has renewals available. For example, we had a scenario where Book A and Book B both had one renew available. Checkout period was 14 days. No renewal before was set to 0 so that the auto-renew happened on the day the item came due. Book A was due 7/1. Book B was due 7/7. The digested messaging went like this: 7/1 - Book A was renewed, Book B was not renewed (too_many error) 7/2 - Both titles were not renewed (too_many error) 7/7 - Book B was renewed, Book A was not renewed (too_many error) 7/8 - Both titles were not renewed (too_many error) The messages on 7/1 and 7/2 gave Book B the too_many error so it appears like no renewals were available, proven untrue when the title auto-renewed on its due date of 7/7. Ideally the 'too_many' error would only pop when all renewals have been exhausted. Titles that have renewals available but aren't getting renewed yet because they aren't due yet should be handled separately so they can be explained/ignored in the templates. The goal for digested messaging in the above scenario would be something like: 7/1 - Book A was renewed, Book B is not yet eligible for auto renewal 7/7 - Book B was renewed, Book A is no longer eligible for auto renewal (too_many) 7/15 - Book A and Book B are no longer eligible for auto renewal (too_many) 7/21 - Book A and Book B are no longer eligible for auto renewal (too_many) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #108 from Biblioteca de Asociación Médica --- Greetings to all Koha´s developers: We wanted to ask you how´s everything going out there? Is there a date for this new version to be ready? Also we want to thank you for all your attention that you have given us by mail, you are so efficient and friendly. Congrats!!! Sincerely, Medical Association Library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31390] Remove noisy warns in C4::Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31390 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31387] Marking othernames as required via PatronSelfRegistrationBorrowerMandatoryField does not display required label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31387 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31348] Plack stop should be graceful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31348] Plack stop should be graceful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31348 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 Tomás Cohen Arazi changed: What|Removed |Added Blocks||15348 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 [Bug 15348] Change/Edit estimated delivery date per order line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply Depends on||29955 CC||tomasco...@gmail.com --- Comment #103 from Tomás Cohen Arazi --- Hi, please rebase. Bug 29955 made a small change that makes the first patch fail to apply. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31377] Add basket's internal note to tables on vendor search result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31377 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 139613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139613=edit Bug 29955: Fix method import issues This patch fixes this: $ prove t/db_dependent/Utils/Datatables_Virtualshelves.t t/db_dependent/Utils/Datatables_Virtualshelves.t .. 2/13 Use of inherited AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is no longer allowed at /kohadevbox/koha/Koha/Virtualshelf.pm line 248. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31439] New: Item count bullet ( ) should be easier to style/remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31439 Bug ID: 31439 Summary: Item count bullet () should be easier to style/remove Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The staff results page included a bullet () that is hard to target. It should be either wrapped in a class or a CSS psuedo element to make it easier to style of remove. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #48 from Andrew Fuerste-Henry --- I was successful with everything in this test plan except generating a notice. Calling <> worked fine. Using [% borrower.pronoun %] gave me a big angry error: "ERROR PROCESSING TEMPLATE: undef error - The method Koha::Patron->pronoun is not covered by tests!" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #47 from Lucas Gass --- rebased for current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Attachment #136064|0 |1 is obsolete|| --- Comment #46 from Lucas Gass --- Created attachment 139612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139612=edit Bug 10950: (QA follow-up) Exec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Attachment #136063|0 |1 is obsolete|| --- Comment #45 from Lucas Gass --- Created attachment 139611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139611=edit Bug 10950: (follow-up) fix typo in kohastructure.sql Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Attachment #136062|0 |1 is obsolete|| --- Comment #44 from Lucas Gass --- Created attachment 139610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139610=edit Bug 10950: API spec update Test plan: 1. Apply patch, restart_all, and updatedatabase 2. In the staff client go to a patron record or create a new patron. 3. Notice the pronouns field, make sure you add a value to it. 4. Now notice that the value should display in parentheses in places where the patron name is displayed. 5. Go to the details page and you should see the value display in quotes. ( next to othernames ) 6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField. 7. Check to make sure you can make the field required with BorrowerMandatoryField 8. Go to the OPAC to self register. The pronouns field should appear in the form. 9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ). 10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ). 11. Try some notices like ISSUESLIP. You should be able to add either <> or [% borrower.pronoun %] to the notice and have it display when you generate the notice. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Attachment #136061|0 |1 is obsolete|| --- Comment #43 from Lucas Gass --- Created attachment 139609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139609=edit Bug 10950: Display pronouns field Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Attachment #136060|0 |1 is obsolete|| --- Comment #42 from Lucas Gass --- Created attachment 139608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139608=edit Bug 10950: Add intranet/OPAC form fields Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Attachment #136059|0 |1 is obsolete|| --- Comment #41 from Lucas Gass --- Created attachment 139607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139607=edit Bug 10950: Schema update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Attachment #136058|0 |1 is obsolete|| --- Comment #40 from Lucas Gass --- Created attachment 139606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139606=edit Bug 10950: Database update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
