[Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Lucas Gass changed: What|Removed |Added Attachment #141301|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 141332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141332=edit Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #44 from Lucas Gass --- *** Bug 31683 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31683] Return descriptions from items API endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31683 Lucas Gass changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 26635 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31683] Return descriptions from items API endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31683 --- Comment #1 from Tomás Cohen Arazi --- Hi, good call. This is actually a duplicate of bug 26635. Could you please take a look at the conversation there? As an API consumer, I would like your opinion on the data structure we should be returning, a subject which has actually blocked that one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31654] Hide non-public libraries from MastheadLibraryPulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass --- Hey Thomas, This will be a nice addition! There are a few problems with your patch: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL forbidden patterns forbidden pattern: tab char (line 235) * Commit title does not start with 'Bug X: ' - abec2a9a88 Can you make sure your commit title starts with "Bug 31654: " and have a look at the bad pattern in masthead.inc? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31683] New: Return descriptions from items API endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31683 Bug ID: 31683 Summary: Return descriptions from items API endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com CC: tomasco...@gmail.com It would be pretty handy of the items endpoint (/api/v1/items ) returned the descriptions along with the actual codes. For example if I go here to '/api/v1/items/419' the location returned is 'GEN', which is the A.V. code. It would be neat if I could get the description too, 'General stacks'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #74 from David Nind --- (In reply to David Nind from comment #73) > Feedback - Rotating collections > --- > > There doesn't appear to be a link to Rotating collections, unless this is > controlled by another system preference. Ignore this, I see that it is under Patrons and circulation on the Tools page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #73 from David Nind --- Hi Martin. I've tested again and have some more feedback and comments. Feedback - bring back the toolbar? -- Should we bring back the toolbar at the top (with Advanced editor, New record and New from Z3950/SRYU buttons) rather than try fitting under the "New" sub-heading? Rationale: - While some styling is required, it looks a little "odd" to me as it is - I don't think we have a dropdown button mingled with options in other areas as part of a landing page. - Familiarity for cataloguers - the key options used are in a familiar place. Feedback - Rotating collections --- There doesn't appear to be a link to Rotating collections, unless this is controlled by another system preference. Some other comments --- 1. I like the idea of the separate bugs for the breadcrumbs and the sidebar changes - makes it easier to do a step at a time, rather than a large change all in one bug. 2. Should there be a separate bug to move the permissions from tools to editcatalogue? 3. Should there be a separate bug to move the system preferences from Tools (or other areas) to Cataloging? 4. From Heather's comment #72, should we also have a separate bug to look at the Administration settings? As a compromise (or first step) we could have an option/link to "Catalog administration" or "Catalog configuration", or something similar. 5. The tools currently have a description in their old location on the tools page. Do we need these, or do we have a way of adding a tooltip with the description? We don't on the staff interface home page, so maybe there is not an issue. 6. Some tools are also used for authorities (such as Batch record deletion, Batch record modification, Export data, Stage MARC records for import). Just trying to think about how we would approach these if we adopt this approach for other modules - do we split these tools (separate out the cataloging vs authority parts), make an arbitrary decision on where they should be, or have a way for the breadcrumbs/URLs to recognise what area we are in (Cataloging, Authorities, etc) and then reflect that? Probably thinking too far ahead at the moment Testing notes - 1. Enable the StockRotation and EnableAdvancedCatalogingEditor (so that these appear). 2. Check that there are no cataloguing-related tools under the tools menu. 3. Check that all the option links work as expected: . New record . New from Z39.50/SRU . Advanced editor . All the other cataloguing tools 4. Check that all the items previously on the tools page are now on the new cataloging home page (new section shown in brackets): - Batch item deletion (Batch editing) - Batch item modification (Batch editing) - Batch record deletion (Batch editing) - Batch record modification (Batch editing) - Automatic item modifications by age (Automation) - Export data (Export) - Inventory (Reports) - Label creator (Tools) - Barcode image generator (Tools) - Quick spine label creator (Tools) - Rotating collections (---Not currently shown---) - Stock rotation (Automation) - MARC modification templates (Batch editing) - Stage MARC records for import (Import) - Staged MARC record management (Import) - Upload local cover image (Tools) 5. Check that the grouping of the various cataloging tools makes logical sense to you - suggestions welcome on categorising! NOTES: - Breadcrumbs and page URLs will be changed in bug 31556 - The sidebar menu will be changed in bug 31417 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 --- Comment #1 from Aleisha Amohia --- Created attachment 141331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141331=edit Bug 31682: Silence automatic linker warn To test: 1. Open the plack-intranet-error.log in your terminal 2. When editing or adding a bibliographic record, click the button to link authorities automatically. 3. Notice the warn in the log 4. Apply the patch, restart services and refresh the page 5. Click the button again. There should be no warn Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31682] Silence warn when using automatic linker in biblio editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31682] New: Silence warn when using automatic linker in biblio editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31682 Bug ID: 31682 Summary: Silence warn when using automatic linker in biblio editor Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When cataloguing a biblio and you use the 'link authorities automatically' button, there is a warn in the logs that could be silenced: [WARN] CGI::param called in list context from /home/vagrant/kohaclone/svc/cataloguing/automatic_linker.pl line 52, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31679] Circulation Rules needs individual rule cloning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 --- Comment #3 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > There is a workaround for this if you need it: > Edit any rule: if you change item type or patron category it will either > overwrite the existing rule for this combination or create a new one. Yeah, this doesn't really apply to the topic. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31679] Circulation Rules needs individual rule cloning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > There is a workaround for this if you need it: > Edit any rule: if you change item type or patron category it will either > overwrite the existing rule for this combination or create a new one. Hm, but of course, this doesn't work for copying between libraries, maybe still helpful to some. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31679] Circulation Rules needs individual rule cloning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 --- Comment #1 from Katrin Fischer --- There is a workaround for this if you need it: Edit any rule: if you change item type or patron category it will either overwrite the existing rule for this combination or create a new one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #2 from Katrin Fischer --- Hm, I ran these tests just yesterday without fail, I still see it in my bash history: prove t/db_dependent/Circulation.t t/db_dependent/Circulation/* Could it depend on having an untouched sample database to start with? But it is a bit odd. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31681] New: Daily digest notice for ALL notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31681 Bug ID: 31681 Summary: Daily digest notice for ALL notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org What if a patron had the option to have a SINGLE notice per day, that was a digest of all notices to them? So, if they have this option checked, they would get a notice at the end of the day, or beginning, that would contain any hold, overdue, predue, etc notices. So, if this is checked, instead of queuing up for the regular cron, maybe the notice is sent in a new cron that is once a day. If done, it might also be beneficial to note on the parton's notifications how the notification was queued (right away/daily). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Katrin Fischer changed: What|Removed |Added Blocks||31673 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Katrin Fischer changed: What|Removed |Added Summary|Bug 31086 |DB update of bug 31086 ||fails: Cannot change column ||'branchcode': used in a ||foreign key constraint Depends on||31086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 [Bug 31086] Do not allow hold requests with no branchcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #4 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #3) > How to categorize this bug might be hard too: If lots of items would not get > a date anymore, a library might not consider this Minor anymore Today's date is used autommagically when you leave the input empty. So that won't be the case, but I also liked the old behaviour as it allowed easy manipulation of the date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31680] New: Cloning circulation rules to more than one library at a time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31680 Bug ID: 31680 Summary: Cloning circulation rules to more than one library at a time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently you can only clone a set of rules to one library at a time. It would be better if you could select all the branches you want to clone to and clone them all at once. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31635] Empty title for current result in OPAC results browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31635 Katrin Fischer changed: What|Removed |Added Summary|Empty title for current |Empty title for current |result in opac results |result in OPAC results |browser |browser -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31679] New: Circulation Rules needs individual rule cloning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31679 Bug ID: 31679 Summary: Circulation Rules needs individual rule cloning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently you can clone a set of rules, but you can't clone an individual rule. It would be great if the action buttons were replaced by a single action button, and included a cloning option to clone that rule to another branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19556] Added content ISBN does not match MARC 020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556 Katrin Fischer changed: What|Removed |Added Summary|Added Content ISBN Does Not |Added content ISBN does not |Match MARC 020 |match MARC 020 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25884] Automatic item modifications by age needs title and description fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25884 --- Comment #2 from Christopher Brannon --- (In reply to Andrew Fuerste-Henry from comment #1) > You mean each rule itself needs a title/description? Sounds handy! Yes! Very much needed. It would be great to know more about the rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #90 from Katrin Fischer --- Nick, just to let you know: I am back, but Martin was faster! ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26028] Allow HoldsToPullStartDate to be blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26028 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26028] Allow HoldsToPullStartDate to be blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26028 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||31678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 [Bug 31678] Convert authority editor tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31678] New: Convert authority editor tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31678 Bug ID: 31678 Summary: Convert authority editor tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the authorities editor (authorities.tt) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||31677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 [Bug 31677] Convert basic MARC editor tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31677] New: Convert basic MARC editor tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31677 Bug ID: 31677 Summary: Convert basic MARC editor tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the basic MARC editor (addbiblio.tt) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31676] Fix db_dependent/Circulation.t tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 --- Comment #1 from David Gustafsson --- Created attachment 141330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141330=edit Bug 31676: Fix db_dependent/Circulation.t tests To test: 1) Run tests in t/db_dependent/Circulation.t and verify that fails (the script should actually crash before all can be run). 2) Apply the patch 3) Verifiy that all tests now pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31676] New: Fix db_dependent/Circulation.t tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Bug ID: 31676 Summary: Fix db_dependent/Circulation.t tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: glask...@gmail.com QA Contact: testo...@bugs.koha-community.org A lot of tests in db_dependent/Circulation.t are currently failing, many seems to have done so for quite a while so it's a bit puzzling how this has gone under radar for such a long time. If any of the changes are unclear I'm happy to expand more on the different addressed issues. A short summary of the changes: - The patron attribute autorenew_checkouts was added a while ago, patrons for some tests needed this set to preserve previous behavior - OverduesBlockRenewing-test relied on a state that was mutated by new tests, these have been moved to a place where the state is as was before this regression. - The test "AddRenewal left both fines" broke when account line statuses where refactored (probably), there should be one one fine - Fixed a test which expects 'auto_to_soon' error. CanBookBeRenewed will not return this status unless the $cron parameter is set to true - "Incremented fee tests" builds an item with missing "library" parameter since treating the library object as a hashref. This cases a circulation-rule not match and serveral tests fail as a result. - The "AddIssue records staff who checked out item if appropriate" subtest treats some objects as hashrefs when retrieving properties, and also checks the wrong issue objects in the last test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10984] Cannot cancel received order if the parent order is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984 --- Comment #5 from Daniel Gaghan --- Ok, it sounds like this is still a problem. I will look for the bugs concerning this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31675] Remove packages from debian/control that are no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 --- Comment #1 from Kyle M Hall --- Created attachment 141329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141329=edit Bug 31675: Remove packages from debian/control that are no longer used As far as I can tell, we are no longer using CGI::Session::Serialize::YAML or YAML::Syck, but they are still marked dependencies for the Debian package. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31675] Remove packages from debian/control that are no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31675] Remove packages from debian/control that are no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31675] New: Remove packages from debian/control that are no longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 Bug ID: 31675 Summary: Remove packages from debian/control that are no longer used Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org As far as I can tell, we are no longer using CGI::Session::Serialize::YAML or YAML::Syck, but they are still marked dependencies for the Debian package. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00, 21.05.19 |22.11.00, 22.05.06, released in||21.05.19 Status|Pushed to master|Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31674 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31674] We need a template/guideline around how to consistently form our modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31674] We need a template/guideline around how to consistently form our modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31674] We need a template/guideline around how to consistently form our modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31674] New: We need a template/guideline around how to consistently form our modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 Bug ID: 31674 Summary: We need a template/guideline around how to consistently form our modals Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org We have more and more modals appearing in the staff client now and I like them.. but they're really inconsistently formed.. We should create a template for how they should be structured in the general case and put it into a coding guideline. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Nick Clemens changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #89 from Martin Renvoize --- The core code here works well.. though we managed to slip parts of it into master already in bug 30528.. oops. Anyway.. QA wise I'm actually pretty happy it all works as designed and doesn't introduce any regressions... but there GUI elements so far are pretty ugly and strangely formed.. I started working through some of them, but as the final patch says, I think we may be better of pushing this as is and then working Owen and I working togeter to create some nice templates and a guideline for modal based forms going forward.. and then use this feature to apply/test our idea's on their own bug. As such.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #88 from Martin Renvoize --- Created attachment 141328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141328=edit Bug 17170: (QA follow-up) Improve model structure This feature is awesome, but it's modals all feel a bit off.. this is an improvement to one of them, but far from perfect. I opt to work with Owen to create a guideline (and template) for modals going forward and let this patchset go in as is. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #87 from Martin Renvoize --- Created attachment 141327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141327=edit Bug 17170: (QA follow-up) Relocate 'Save' Another minor rebase issue I believe.. relocate the 'Save search as filter' link back up to sit next to 'Edit this search'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #86 from Martin Renvoize --- Created attachment 141326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141326=edit Bug 17170: (QA follow-up) Remove re-introduced file We reintroduced the definitions api spec file with this patch.. it's not required. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141237|0 |1 is obsolete|| --- Comment #85 from Martin Renvoize --- Created attachment 141325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141325=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Michal Urban Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141236|0 |1 is obsolete|| --- Comment #84 from Martin Renvoize --- Created attachment 141324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141324=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141235|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize --- Created attachment 141323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141323=edit Bug 17170: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141234|0 |1 is obsolete|| --- Comment #82 from Martin Renvoize --- Created attachment 141322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141322=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141233|0 |1 is obsolete|| --- Comment #81 from Martin Renvoize --- Created attachment 141321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141321=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141232|0 |1 is obsolete|| --- Comment #80 from Martin Renvoize --- Created attachment 141320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141320=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141231|0 |1 is obsolete|| --- Comment #79 from Martin Renvoize --- Created attachment 141319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141319=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141230|0 |1 is obsolete|| --- Comment #78 from Martin Renvoize --- Created attachment 141318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141318=edit Bug 17170: Update schema for boolean Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141229|0 |1 is obsolete|| --- Comment #77 from Martin Renvoize --- Created attachment 141317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141317=edit Bug 17170: DO NOT PUSH - Schema Updates Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added Attachment #141228|0 |1 is obsolete|| --- Comment #76 from Martin Renvoize --- Created attachment 141316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141316=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31673] Bug 31086
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Owen Leonard changed: What|Removed |Added Component|bugs.koha-community.org |Installation and upgrade ||(command-line installer) Severity|enhancement |normal Keywords|Academy | OS|Linux |All Hardware|PC |All -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What|Removed |Added Attachment #141128|0 |1 is obsolete|| --- Comment #38 from Marcel de Rooy --- Created attachment 141315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141315=edit Bug 31203: (follow-up) Remove stray debug statement Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What|Removed |Added Attachment #140983|0 |1 is obsolete|| --- Comment #37 from Marcel de Rooy --- Created attachment 141314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141314=edit Bug 31203: Alter other cronjobs that currenlty use cronlogaction Added command line ooption logging and completion logging where cronlogaction was already imported. We should probably standardize all cronjobs, but this is a start One cron didn't log on confirm, likely we need to update all crons to log if confirm, and possibly not log if running in test mode? Another bug as well Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What|Removed |Added Attachment #140982|0 |1 is obsolete|| --- Comment #36 from Marcel de Rooy --- Created attachment 141313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141313=edit Bug 31203: Add End action to cronjobs and log viewer Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What|Removed |Added Attachment #140981|0 |1 is obsolete|| --- Comment #35 from Marcel de Rooy --- Created attachment 141312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141312=edit Bug 31203: POC advance_notices This patch proposes a new standard for cronlogaction We copy @ARGV into a space separated string, then pass this to cronlogaction At the end of the script we add a call with info "COMPLETED" To test: 1 - Apply patch 2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c 3 - sudo koha-mysql kohadev 4 - SELECT * FROM action_logs WHERE interface="CRON"; 5 - Note start and completion logged 6 - Note command line arguments included in info If this looks good I will copy this pattern to the other cronjobs Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What|Removed |Added Attachment #140980|0 |1 is obsolete|| --- Comment #34 from Marcel de Rooy --- Created attachment 141311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141311=edit Bug 31203: Alter cronlogaction to take a hash This patch simply changes the routine to expect a hashref for info and to log the PID as object in action logs Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #33 from Marcel de Rooy --- (In reply to Nick Clemens from comment #32) > (In reply to Marcel de Rooy from comment #24) > > Hmm. The PID as the object number. We should not do that. > This is to allow matching the Run to End actions for a single run - what > would you prefer? Well, I think we have more inappropriate use of that column. So I can live with that ;) > (In reply to Marcel de Rooy from comment #26) > > Running advance_notices: > > Can't locate PatternLayout.pm in @INC > > Whats happening here? > > I don't recreate - custom logging setup? Not sure what it is. But my new container doesnt complain anymore.. > (In reply to Marcel de Rooy from comment #28) > > +[% FOREACH actx IN [ 'ADD' 'DELETE' > > 'MODIFY' 'ISSUE' 'RETURN' 'RENEW' 'CREATE' 'CANCEL' 'FILL' 'SUSPEND' > ... > > Seems to work, although I expected commas. > Following pattern with my patch - feel free to provide a follow-up > > > It is a bit weird that we have lower case Run and End here. > Following the current status for this - feel free to provide a follow-up There is a limit :) > (In reply to Marcel de Rooy from comment #29) > > + > > console.log(Array.isArray(options.embed)); > > debugging > > Removed Good -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 --- Comment #11 from Marcel de Rooy --- Great. No failures anymore from qa tools. Here is another question :) @@ -179,6 +179,7 @@ sub XSLTParse4Display { my $hidden_items = $params->{hidden_items} || []; my $variables= $params->{xslt_variables}; my $items_rs = $params->{items_rs}; +my $interface= $params->{interface}; Why do you use a parameter? Did you consider using C4::Context->interface ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31557] Hold queue/home vs. holding library/transport cost matrix complications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- I found this difficult to test as all my imports were so darn quick.. but it does appear to all work. Two QA follow-ups to keep the QA scripts happy.. I'm going to PQA, but a second set of eyes on my final follow-up wouldn't go a miss... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 --- Comment #7 from Martin Renvoize --- Created attachment 141310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141310=edit Bug 31666: (QA follow-up) Remove ES template literals Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 --- Comment #6 from Martin Renvoize --- Created attachment 141309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141309=edit Bug 31666: (QA follow-up) Add filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Martin Renvoize changed: What|Removed |Added Attachment #141261|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 141308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141308=edit Bug 31666: Add job progress bar to stage-marc-import.pl It would be nice if we had progress bars to indicate the progress of background jobs for scripts that utilize them. This patch implements a reusable bootstrap based progess bar. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template literals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template literals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #50 from Marcel de Rooy --- From IRC: [15:34] 28 has all good answers.. looks like you've thought about most of it and are planning them for a continuation in the tree of bugs.. [15:34] so don't let me comment block anything -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31657] [DOCS] Fix the cause of duplicate label warning messages when generating the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 David Nind changed: What|Removed |Added Summary|[DOCS] [Omnibus] Fix the|[DOCS] Fix the cause of |cause of duplicate label|duplicate label warning |warning messages when |messages when generating |generating the manual |the manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31658] [DOCS] Update conf.py to remove sphinx.ext.autosectionlabel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31658 Bug 31658 depends on bug 31657, which changed state. Bug 31657 Summary: [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31657] [DOCS] [Omnibus] Fix the cause of duplicate label warning messages when generating the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31657 David Nind changed: What|Removed |Added Status|NEW |RESOLVED Documentation||Merge requests 591 and 593 submission|| Resolution|--- |FIXED Documentation||Katrin Fischer + Caroline contact||Cyr La Rose --- Comment #10 from David Nind --- Woot! Thanks Katrin and Caroline for all your speedy work on updating all the refs and fixing the casue of error messages! The manual is now generated without any warning or other error messages! David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31658] [DOCS] Update conf.py to remove sphinx.ext.autosectionlabel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31658 David Nind changed: What|Removed |Added Summary|Update conf.py to remove|[DOCS] Update conf.py to |sphinx.ext.autosectionlabel |remove ||sphinx.ext.autosectionlabel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31658] Update conf.py to remove sphinx.ext.autosectionlabel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31658 David Nind changed: What|Removed |Added Assignee|da...@davidnind.com |caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Documentation||Caroline Cyr La Rose contact|| --- Comment #4 from David Nind --- Thanks Caroline! Now merged, and no output errors when generating the manual! David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25936] Notify users if their password has changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #29 from Martin Renvoize --- Created attachment 141307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141307=edit Bug 25936: (follow-up) Unit test for store This unit test confirms that we are not triggering the Password Change notification notice upon patron creations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25936] Notify users if their password has changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #28 from Martin Renvoize --- Created attachment 141306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141306=edit Bug 25936: (follow-up) Fix ../api/v1/patrons.t Disable password change notifications for the api test to negate the need for setting up notices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What|Removed |Added Attachment #140645|0 |1 is obsolete|| --- Comment #10 from David Nind --- Comment on attachment 140645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140645 Example PDF output - Document column is very narrow Obsoleted as layout now updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19556] Added Content ISBN Does Not Match MARC 020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556 Owen Leonard changed: What|Removed |Added Version|3.22|master --- Comment #2 from Owen Leonard --- (In reply to John Yorio from comment #0) > Bug 15772 mentions > that Novelist can't interpret 10-digit ISBNs ending in X Not necessarily relevant to this bug report, but I don't think this is still the case. I can see Novelist content related to 10-digit ISBNs ending in X. https://search.myacpl.org/cgi-bin/koha/opac-detail.pl?biblionumber=6645 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 --- Comment #9 from David Nind --- Thanks Aleisha for updating. Have signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What|Removed |Added Attachment #141299|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 141305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141305=edit Bug 31257: (follow-up) Fix display of PDF This patch rearranges the Qty and Document columns and shifts the vendor account number field lower to make room for address fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What|Removed |Added Attachment #140644|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 141304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141304=edit Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a basket as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Owen Leonard changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 --- Comment #1 from Owen Leonard --- Created attachment 141303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141303=edit Bug 31420: Managing funds: Labels of statistic fields overlap with pull downs This patch removes some very old inline style attributes from the fund edit form. The "white-space" attribute prevented label text from naturally wrapping. To test, apply the patch and go to Administration -> Funds. - In the list of funds, click Actions -> Edit. - The the form, confirm that the text of the "Statistic" 1 and 2 labels wraps, not getting hidden by the associated select tags. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31420] Managing funds: Labels of statistic fields overlap with pull downs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31420 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31673] Bug 31086
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 mohamed changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31673] New: Bug 31086
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 Bug ID: 31673 Summary: Bug 31086 Change sponsored?: --- Product: Koha Version: 22.05 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: mohamednofal...@gmail.com QA Contact: testo...@bugs.koha-community.org Upgrade to 22.05.04.002 [14:07:01]: Bug 31086 - Do not allow null values in branchcodes for reserves ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'branchcode': used in a foreign key constraint 'reserves_ibfk_4' at /usr/share/koha/lib/C4/Installer.pm line 739 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/