[Koha-bugs] [Bug 32130] Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 Jonathan Druart changed: What|Removed |Added Attachment #143385|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 143387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143387=edit Bug 32130: Add a test to ensure vue files will be kept tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32130] Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 Jonathan Druart changed: What|Removed |Added URL||https://tree.taiga.io/proje ||ct/joubu-koha-erm/us/140 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Emmi Takkinen changed: What|Removed |Added Attachment #143349|0 |1 is obsolete|| --- Comment #16 from Emmi Takkinen --- Created attachment 143386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143386=edit Bug 31447: Add unit tests To test prove t/db_dependent/Circulation.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #17 from Emmi Takkinen --- My bad. I added those four tests under new subtest to count instead of one. This is now fixed, hopefully they pass now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #208 from David Cook --- (In reply to David Cook from comment #207) > So I think fixes required are: > > 1) Hide overly revealing error messages in Web UI > 2) Fix mapping so that auto-register "update on login" works and auto > register includes mappings beyond just email. I notice in the help text that it says "If you plan to use auto register feature, either userid or cardnumber must be present in this mapping". That doesn't appear to be true in my testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #207 from David Cook --- I've double-checked that my ID token and UserInfo responses include "given_name" and "family_name" and they do. I've noticed with the auto register that it isn't populating the "firstname" and "surname" fields. That's probably why the update on login isn't working either. -- So I think fixes required are: 1) Hide overly revealing error messages in Web UI 2) Fix mapping so that auto-register "update on login" works and auto register includes mappings beyond just email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #206 from David Cook --- (In reply to David Cook from comment #204) > I got the following error: > > There was an error authenticating to external identity provider > > DBIC result _type isn't of the _type Category at > /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. > > Looks like auto register doesn't work still... It looks like I had forgotten to provide "Default library" and "Default category". When I do provide "Default library" and "Default category", it does auto register a new patron! Yay! If I provide a "Default category" but no "Default library", then I get this error: "There was an error authenticating to external identity provider Broken FK constraint" -- I think for these two scenarios, you just shouldn't show the error on the Web UI. Log it to the log files and leave it at that. It's enough to tell the end user that "There was an error authentication to external identity provider. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32130] Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 --- Comment #1 from Jonathan Druart --- Created attachment 143385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143385=edit Bug 32130: Add a test to ensure vue files will be kept tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32130] Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What|Removed |Added Blocks||32130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 [Bug 32130] Vue files must be kept tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32130] New: Vue files must be kept tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 Bug ID: 32130 Summary: Vue files must be kept tidy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Keywords: rel_22_11_candidate Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 32030 We want to keep them tidy, and all use the them rules. To enforce that we should have a test in xt to catch possible discrepancies. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #205 from David Cook --- When I add a Domain rule that forbids login for staff interface or OPAC, it says "No configuration found for your email domain". I think you could just leave it as "There was an error authenticating to external identity provider". But that's just a comment and not a blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #204 from David Cook --- Test plan 1: 0. Apply patches 1. apt install libmojolicious-plugin-oauth2-perl 2. koha-upgrade-schema kohadev 3. restart_all Test plan 2a (Quarkus Keycloak): 1. Go to http://:8082/ 2. Click "Administration Console" 3. Login to master realm 4. Click on dropdown menu that says "master" 5. Click "Create Realm" 6. Type "test" into "Realm name" and click "Create" 7. Click "Clients" 8. Click "Create client" 9. Type "test" into "Client ID" 10. Click "Next" 11. Set "Client authentication" to "On" 12. Click "Save" 13. Add "Valid redirect URIs" of "http://localhost:8080/*; and "http://localhost:8081/*; 14. Click "Credentials" tab and note the "Client secret" 15. Click "Advanced" tab and turn "Exclude Session State From Authentication Response" to "On" then click "Save" 16. Click "Users" on left nav 17. Click "Create new user" 18. Type "kohadev" into "Username" 19. Type "koha...@koha-community.org" into Email" 20. Type "Firstname" into "First name" 21. Type "Lastname" into "Last name" 22. Click "Create" 23. Click "Credentials" tab and click "Set password" 24. Choose a password, turn off "Temporary", and click "Save" 25. Click "Realm settings" from the left nav 26. Click "OpenID Endpoint Configuration" at the bottom of the page Test plan 2b: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Identity providers" 3. Click "New identity provider" 4a. Type "test" into "Code" 4b. Type "Test" into "Description" 4c. Choose "OIDC" for "Protocol" 4d. Click "Add default OIDC configuration" 4e. Click "Add default OIDC mapping" 4f. Update "Configuration" to match Keycloak details for "key", "secret", and "well_known_url" 5. Click on "Manage Domains" 6. Click "Edit" on the default domains 7. Set "Allow staff" and allow update on login and autoregister and click "Submit" 8. koha-plack --restart kohadev 9. Update OPACBaseURL and staffClientBaseURL to http://localhost:8080 and http://localhost:8081 respectively Test plan 3: 1. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha -- I got the following error: There was an error authenticating to external identity provider DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. Looks like auto register doesn't work still... I changed the email address for the "koha" user to "koha...@koha-community.org" at http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51 Login works, but it doesn't update the user details on login either. Going to have to fail this again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 --- Comment #24 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #22) > Wait, when I click it doesn't populate the field. And no JS console error to > help. Same with Chromium. Same on ERM sandbox. Click filter without date selected, today date will be used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 --- Comment #23 from Jonathan Druart --- (In reply to Kyle M Hall from comment #19) > I am provisionally passing QA on this. I've added your signed-off-by lines, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 --- Comment #22 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #15) > It's not how it appears, it should be displayed like this: > https://snipboard.io/Pv5a9O.jpg Weird, I still have it wrong on default zoom after getting latest code and running yarn install. I see it fine on the ERM sandbox. > > There doesn't seem to be another filter mode when unchecked. > > Another filter mode? What do you mean? I was hypothesizing that the checkbox could be to switch from agreements having expired before or equal to the date field. And to switch to agreements having expired precisely at the date. The checkbox is next to the "on" so I though it activated the "on" to modify the filter. To only show the agreements having expired precisely on the date. Or something else. > > From the code it seems the date field is only used when the box is ticked. > > Is that done to be able to keep an expiration date saved without having it > > used? (it's not saved so it's not that) > > Otherwise the filter could just be used when the date field is populated. > > You only need to click the checkbox to search for "expired on today" (it > will populate the date with today when the checkbox is ticked). That's > something you couldn't have with your suggestion. Ah ok the checkbox actually does something different! Now I though it was just a switch meaning "take the next date field filter into account". Which seems redundant and confusing. So my confusion came from wrongly understanding this. Wait, when I click it doesn't populate the field. And no JS console error to help. Same with Chromium. Same on ERM sandbox. > I don't think the current behaviour is confusing, really. We could > eventually hide 'on [date]' when the checkbox is not checked. We are talking > about providing a MVP for 22.11 inclusion, not trying to catch minor UI > design flaws ;) Well at first my comment would have been about the expiration date filter not working at all. I might have messed up when trying with the agreement periods (End date vs Cancellation deadline) and though it was the license period. Since the licenses have an expired status. But of course it wasn't the license period. But I finally got it working but thought either the checkbox was redundant and was just to enable the use of the date filter. Or that there was two filter modes or something else that I missed. Anyway, yes at that moment I lost the focus on the MVP since indeed the expiration filter works! Let's keep that for follow-ups. > (In reply to Victor Grousset/tuxayo from comment #14) > Coming from Folio: > https://github.com/folio-org/ui-agreements/blob/master/src/constants/ > agreementRelationshipTypes.js > I guess the idea was to have '_' for spaces and '-' for '-', but yes, it's > inconsistent. Ok it's to be consistent with another project. Makes sense even if they don't :P Thanks for the clarifications :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks||32129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Depends on||19532 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32129] New: Use patron categorycode of most relevant recall when checking if item can be a waiting recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 Bug ID: 32129 Summary: Use patron categorycode of most relevant recall when checking if item can be a waiting recall Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com We check in (return) an item to trigger the recalls process and set it as waiting for the patron who requested the recall. Sometimes the recalls process isn't triggered, and there is no other way to alert the patron that their item is ready for them to pick up if they've recalled it. This is because of more specific circulation rules. When we check if an item can be set as waiting to fill a recall, we do not consider the category code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #203 from David Cook --- (In reply to David Cook from comment #202) > (In reply to Tomás Cohen Arazi from comment #201) > > I've just added an --sso option switch to the 'ktd' command, using the > > examples you provided (with minor tweaks). > > I use a bit of a custom setup, but I'll include your docker-compose.sso.yml > :D Looks like the docker-compose.sso.yml still needs some work, but I've emailed about fixing that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #202 from David Cook --- (In reply to Tomás Cohen Arazi from comment #201) > I've just added an --sso option switch to the 'ktd' command, using the > examples you provided (with minor tweaks). I use a bit of a custom setup, but I'll include your docker-compose.sso.yml :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 --- Comment #33 from Aleisha Amohia --- (In reply to Lucas Gass from comment #31) > Aleisha, > > I think if we make this one dependent on Bug 26648 we can move it back to > NSO. Addressed in latest patch, ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Aleisha Amohia changed: What|Removed |Added Attachment #139937|0 |1 is obsolete|| --- Comment #32 from Aleisha Amohia --- Created attachment 143384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143384=edit Bug 31051: (follow-up) Tests for get_savings and more - Added tests in t/db_dependent/Koha/Patron.t - Added wording to OPACShowSavings syspref about anonymised checkout history - Added IDs to the savings messages on the OPAC - Prevent explosion if a checked out item has been deleted Sponsored-by: Horowhenua Libraries Trust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32110] Duplicated additional content entries on DBRev 210600016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30913] Show itemtype notforloan with ILS-DI service GetRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 --- Comment #2 from David Cook --- I thought I'd attached a patch for this. Looks like I hadn't... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32127] Sort patron categories by description in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #1 from Fridolin Somers --- Created attachment 143382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143382=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AA is last => With patch the value AA is first 4) Click on 'New patron' => Without patch the value AA is last => With patch the value AA is first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32127] Sort patron categories by description in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32127] Sort patron categories by description in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32127] Sort patron categories by description in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers changed: What|Removed |Added Summary|Always sort patrpn |Sort patron categories by ||description in templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32127] New: Always sort patrpn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Bug ID: 32127 Summary: Always sort patrpn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32075] Staff mainpage crashed on Can't use an undefined value as a HASH reference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31908 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908
Marcel de Rooy changed:
What|Removed |Added
See Also||https://bugs.koha-community
||.org/bugzilla3/show_bug.cgi
||?id=32075
CC||m.de.r...@rijksmuseum.nl
--- Comment #4 from Marcel de Rooy ---
-my $local_pendingsuggestions_count = $pendingsuggestions->search({
'me.branchcode' => C4::Context->userenv()->{'branch'} })->count();
+if( C4::Context->userenv() && C4::Context->userenv()->{branch} ){
In this case there should be a userenv. Why it isnt? Reported this too on bug
32075. Weird.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||da...@davidnind.com
--- Comment #4 from David Nind ---
This works on the staff interface, but I get no results for the OPAC.
This is related to the query in the URL I think.
OPAC:
- Query in URL generated on the OPAC:
/cgi-bin/koha/opac-search.pl?q=Host-item%3A("Easy piano pieces for children
\%2F")%26sort_by%3Dtitle_asc
- Search box: Host-item:("Easy piano pieces for children \/")_by=title_asc
- Note - the staff interface has this in the search box: Host-item:("Easy piano
pieces for children \/")
If I change the query in the OPAC URL to the match that used in the staff
interface, it works:
- Change OPAC URL to: /cgi-bin/koha/opac-search.pl?q=Host-item:("Easy piano
pieces for children \/")_by=title_asc
- OPAC search box: Host-item:("Easy piano pieces for children \/")
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22405] Funds from inactive budgets appear in 'Funds' dropdown on acqui/orderreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405 --- Comment #4 from Abbey Holt --- I agree 100 percent. Our acquisitions staff member regularly grumbles about this! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31406] Set focus for cursor to Name input when adding a new item search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406 David Nind changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #3 from David Nind --- Status incorrectly changed! Have changed back to Needs Signoff - once bug 32126 is fixed, this can be retested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32126] Adding item search fields is broken - can't add more than one field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 David Nind changed: What|Removed |Added Blocks||31406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406 [Bug 31406] Set focus for cursor to Name input when adding a new item search field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31406] Set focus for cursor to Name input when adding a new item search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406 David Nind changed: What|Removed |Added Depends on||32126 Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #2 from David Nind --- Hi Isobel. This isn't working for me after applying the patch on master. I think something else is going on that is unrelated to your change (both before and after your patch is applied): - I can add ONE new search field - If I go to add another one, the body of the page is blank (navigation, etc is still in place) and I don't get the add new item search field form - Have tried in different browsers (Firefox and Google Chrome) - I checked on the latest 22.05 version, and this problem doesn't occur: I can successfully add multiple item search fields I have created bug 32126 for this issue. Once that is fixed, this bug can be retested. David Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 [Bug 32126] Adding item search fields is broken - can't add more than one field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32126] New: Adding item search fields is broken - can't add more than one field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Bug ID: 32126 Summary: Adding item search fields is broken - can't add more than one field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: da...@davidnind.com QA Contact: testo...@bugs.koha-community.org When adding item search fields (Administration > Catalog > Item search fields) in current master, you can only add one new field. If you try and add another one, the body of the page is blank (navigation, etc is still in place). I also checked this on the latest 22.05, and this problem doesn't occur - I can successfully add multiple item search fields. So something has broken this in master. I have also tried in different browsers (Firefox and Google Chrome). To replicate: 1. Go to Administration > Catalog > Item search fields. 2. Click on 'New search field'. 3. Enter required details and submit: ==> table with the item search field added displayed. 4. Repeat step 2: ==> You now get a blank page (navigation, etc is still in place) and no add new item search field form. Identified when testing bug 31406. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31345] Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345 Kyle M Hall changed: What|Removed |Added Attachment #139027|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 143381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143381=edit Bug 31345 - Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails Sometimes it would be better for process_message_queue.pl to stop if a plugin hook fails rather than continue processing. It would be nice if that was a command line option. Test Plan: 1) Install any plugin with a before_send_messages hook 2) Modify the plugin, add a 'die;' statement at the start of the before_send_messages method of the plugin. 3) Run process_message_queue.pl as usual 4) Note the exit code is 0 5) Run it again with the new -e setting 6) Note the exit code is 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31345] Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31042] OVERRIDE_SYSPREF does not work for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31908 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30109] Wrong interface in logs when renewing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30109 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31908 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30109, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31042 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31908] Context accessed but not always set on mainpage.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32123 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a HASH reference at circ/article-requests.pl line 38
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31908 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32120] Wrong display when editing a fund
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32120 Owen Leonard changed: What|Removed |Added Version|unspecified |master Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding additional fields for baskets or subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414 David Nind changed: What|Removed |Added Attachment #143343|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 143380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143380=edit Bug 31414: Set focus to name in additional fields. Focus is set to name on additional fields on administation add fields. Test plan 1. Go to administation and manange additional fields. 2. If you then add field the focus should automatically go to the field name. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding additional fields for baskets or subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22405] Funds from inactive budgets appear in 'Funds' dropdown on acqui/orderreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405 Jaki changed: What|Removed |Added CC||jaki.fris...@leblibrary.com --- Comment #3 from Jaki --- Since we have a lot of inactive budgets, it's a little confusing to sift through all the old ones that shouldn't show up. It would be nice if only the active ones show up! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31751] Breadcrumb style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 --- Comment #7 from Tomás Cohen Arazi --- Older style (>), normal text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31751] Breadcrumb style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 --- Comment #6 from David Nind --- The older style for me (>)(ideally without the italics). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block refund generation when item is withdrawn and lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block refund generation when item is withdrawn and lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042 ByWater Sandboxes changed: What|Removed |Added Attachment #143373|0 |1 is obsolete|| --- Comment #9 from ByWater Sandboxes --- Created attachment 143379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143379=edit Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to block Currently this syspref only bokcs the literal 'return' from a patron, i.e. the checkin It still processes transfers, refunds lost items, updates NotForLoan status etc. We should block all of these things To test: 1 - Set BlockReturnOfWithdrawn to block 2 - Set an item as lost and withdrawn 3 - Check it in 4 - Item is found 5 - Apply patch 6 - Repeat 1-3 7 - Checkin is blocked, item still lost Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Owen Leonard changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31751] Breadcrumb style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751 --- Comment #5 from Martin Renvoize --- Anyone else got an opinion here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added Keywords||rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 --- Comment #15 from Martin Renvoize --- I decided to split this into two bugs.. one for the generic return code and one for the use of it in the biblio details comments tab. I also added a minor follow-up on the subsequent bug to ensure the correct tab is selected too. Keeping the QA stamp here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What|Removed |Added Attachment #142734|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What|Removed |Added Attachment #142733|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 143378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143378=edit Bug 31699: Add 'return' option to opac modal login This patch adds the option to trigger a redirect back to the current context after successful login using modal logins triggered from various places in the OPAC. To make use of this, simply add 'data-return="true"' to the modal trigger link. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement ensures release notes||patrons are returned to the ||correct biblio detail page ||after a login that is ||prompted when attempting to ||comment on a bilio. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 --- Comment #3 from Martin Renvoize --- This simply splits the work from bug 31699 to better document it for the release notes.. carrying over SO and QA stamps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 --- Comment #2 from Martin Renvoize --- Created attachment 143377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143377=edit Bug 32125: Select correct tab on return Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 --- Comment #1 from Martin Renvoize --- Created attachment 143376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143376=edit Bug 32125: Impliment modal context return on opac-detail. This patch utilises the generic return option introduced in the previous patch to prevent lose of context when clicking to login to add a comment to a biblio. Test plan 1/ Test that prior to this patch, upon clicking 'Log in to your account to post a comment' you are redirected to opac-user.pl and thus loose your context. 2/ Apply the patch 3/ Confirm that a login using the 'Log in to your account to post a comment' link now redirect immediatly back the correct record and thus maintains context. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize changed: What|Removed |Added Blocks||32125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 [Bug 32125] Implement contextual return on opac comments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize changed: What|Removed |Added Depends on||31699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32125] New: Implement contextual return on opac comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Bug ID: 32125 Summary: Implement contextual return on opac comments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org We should use the contextual return option added in bug 31699 to ensure a patron is returned to the biblio details page they were on when trying to add a comment to said biblio and getting prompted to login. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 David Gustafsson changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #9 from David Gustafsson --- Sorry about being slow to reply. Tried applying the patch and applied cleanly for me, realized the conflict was in bug 29440 which since have been rebased. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #59 from David Gustafsson --- Created attachment 143375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143375=edit Bug 29440: Replace removed syspref BiblioAddsAuthorities with AutoLinkBiblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30913] Show itemtype notforloan with ILS-DI service GetRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17004] REST API: add route to authenticate patron (Single Sign On - SSO)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24841] REST API should check if patron is restricted/debarred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Signing off.. happy to see a follow-up here to make the other two cases I identified match the markup.. or we could submit another bug for that.. I'll defer that decision to the RM/QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109
Martin Renvoize changed:
What|Removed |Added
Attachment #143178|0 |1
is obsolete||
--- Comment #3 from Martin Renvoize ---
Created attachment 143374
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143374=edit
Bug 32109: Fix spacing in toolbars containing text links
This patch adds a new class to toolbars in certain contexts: Where the
toolbar contains only text links (as opposed to Bootstrap-styled
controls). This lets us set some comfortable padding on the links.
To test, apply the patch and rebuild the staff interface CSS.
Test the following pages to confirm that the toolbar of selection links
("Select all," "Clear all," etc.) has legible spacing.
- Cataloging -> Batch item modification -> List of submitted barcodes
- Cataloging -> Batch item deletion -> List of submitted barcodes
- Cataloging -> Batch record modification -> List of submitted records
- Cataloging -> Batch record deletion -> List of submitted records
- Tools -> Batch extend due dates -> Preview results
- Tools -> Batch patron modification -> List of submitted patrons
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 --- Comment #2 from Martin Renvoize --- I see.. this is another place we're a little inconsistent with how we mark up a 'toolbar'. On 'Opac problem reports' and 'checkout notes' there are similar "toolbars" for filtering the datatable... they have the following marking Should we try to synchronize the markup of those two 'filter bars' too here? Challenge with this is that on those two pages there are also already blocks on the page too. I feel like an id of toolbar is wrong.. it should likely be a class instead.? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a HASH reference at circ/article-requests.pl line 38
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123 Marcel de Rooy changed: What|Removed |Added Blocks||32124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124 [Bug 32124] [OMNIBUS] Problems with C4::Context->userenv -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32075] Staff mainpage crashed on Can't use an undefined value as a HASH reference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075 Marcel de Rooy changed: What|Removed |Added Blocks||32124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124 [Bug 32124] [OMNIBUS] Problems with C4::Context->userenv -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124 Marcel de Rooy changed: What|Removed |Added Depends on||32075, 32123 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075 [Bug 32075] Staff mainpage crashed on Can't use an undefined value as a HASH reference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123 [Bug 32123] CRASH: Can't use an undefined value as a HASH reference at circ/article-requests.pl line 38 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32124] New: [OMNIBUS] Problems with C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124 Bug ID: 32124 Summary: [OMNIBUS] Problems with C4::Context->userenv Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Things like: Can't use an undefined value as a HASH reference at mainpage.pl Can't use an undefined value as a HASH reference at circ/article-requests.pl line 38 See referenced bugs. In both cases you should though expect to find a userenv. So what's going on in C4::Context or C4::Auth here ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22398] Ability to create patrons that can't be deleted with normal edit_borrowers permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22398 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #2 from George Williams (NEKLS) --- I would find this very useful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32123] New: CRASH: Can't use an undefined value as a HASH reference at circ/article-requests.pl line 38
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123
Bug ID: 32123
Summary: CRASH: Can't use an undefined value as a HASH
reference at circ/article-requests.pl line 38
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
Looks like bug 32075.
Just another case where userenv returns undef.
my $branchcode = defined( $query->param('branchcode') ) ?
$query->param('branchcode') : C4::Context->userenv->{'branch'};
This line is just after get_template_and_user so we should expect it?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28465] Don't allow staff user to change patron categories of other staff users and their own account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28465 --- Comment #3 from George Williams (NEKLS) --- I would also find this feature helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #22 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #21) > That's why I wondered if there was any gain compared to just storing the > passwords into koha-conf.xml directly? (or another file) Simply put, imo, that would mean librarians could no longer update that data without help from the server administrator, making their jobs more difficult. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 --- Comment #21 from Kyle M Hall --- (In reply to Jonathan Field from comment #20) > Thanks Kyle! The upload document issue is sorted with this commit > https://gitlab.com/joubu/Koha/-/commit/ > 468ae2cf215630274f953b539bc3b373cb8f73f8 so, hopefully, all is good! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Nick Clemens changed: What|Removed |Added Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block refund generation when item is withdrawn and lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042 Nick Clemens changed: What|Removed |Added Attachment #136693|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 143373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143373=edit Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to block Currently this syspref only bokcs the literal 'return' from a patron, i.e. the checkin It still processes transfers, refunds lost items, updates NotForLoan status etc. We should block all of these things To test: 1 - Set BlockReturnOfWithdrawn to block 2 - Set an item as lost and withdrawn 3 - Check it in 4 - Item is found 5 - Apply patch 6 - Repeat 1-3 7 - Checkin is blocked, item still lost -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block refund generation when item is withdrawn and lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32122] Wrong permissions check on item circulation alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32122] Wrong permissions check on item circulation alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32119] Cannot add new guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32119] Cannot add new guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31895] New Account hook when adding credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
