[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Katrin Fischer  changed:

   What|Removed |Added

 CC||shi-yao.w...@inlibro.com

--- Comment #270 from Katrin Fischer  ---
*** Bug 30988 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #52 from Katrin Fischer  ---
The alternative OIDC implementation has been pushed and I hope it fulfills all
requirements of this development. Marking as duplicate, also to make people
aware.

*** This bug has been marked as a duplicate of bug 31378 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9717] Local use recorded for holds/transfers

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32147] Capitalization: E-Resource management should be E-resource management

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Amit Gupta  changed:

   What|Removed |Added

 CC||amit.gupta@informaticsgloba
   ||l.com,
   ||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding an agreement to EBSCO's package

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Amit Gupta  changed:

   What|Removed |Added

 CC||amit.gupta@informaticsgloba
   ||l.com,
   ||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #143817|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 143818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143818=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

This enhancement adds an issued_or_reserved option to the HoldFeeMode
system preference, so that a hold fee may be charged if either all items
are check out, or the record has at least one hold already.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> Patron categories
3) Edit Category A and add a hold fee of $1.00

4) Go to Administration -> System preferences and search for
HoldFeeMode
5) Set HoldFeeMode to not_always - "only if all items are checked out
and the record has at least one hold already"

6) In another tab, open the staff interface. Search for a record with
one item attached to it (Biblio A)
7) Place a hold on this record for Patron B (any category).

not_always, reserved but not issued

8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of
Category A which the hold fee applies to)
9) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, reserved but not issued

10) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
11) Delete Patron A's hold on Biblio A
12) Place a hold on Biblio A for Patron A
13) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued but not reserved

14) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
15) Delete all holds on Biblio A
16) Check out Biblio A's item (Item A) to Patron B
17) Place a hold on Biblio A for Patron A
18) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, issued but not reserved

19) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
20) Delete Patron A's hold on Biblio A
21) Place a hold on Biblio A for Patron A
22) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued and reserved

23) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
24) Delete all holds on Biblio A
25) Place a hold on Biblio A for Patron C (any category).
26) Place a hold on Biblio A for Patron A
27) Check Patron A's accounting page. They SHOULD have a hold fee

issued_or_reserved, issued and reserved

28) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
29) Delete Patron A's hold on Biblio A. There should still be a hold for
Patron C.
30) Place a hold on Biblio A for Patron A
31) Check Patron A's accounting page. They SHOULD have a hold fee

32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #143598|0   |1
is obsolete||

--- Comment #4 from Aleisha Amohia  ---
Created attachment 143817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143817=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

This enhancement adds an issued_or_reserved option to the HoldFeeMode
system preference, so that a hold fee may be charged if either all items
are check out, or the record has at least one hold already.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> Patron categories
3) Edit Category A and add a hold fee of $1.00

4) Go to Administration -> System preferences and search for
HoldFeeMode
5) Set HoldFeeMode to not_always - "only if all items are checked out
and the record has at least one hold already"

6) In another tab, open the staff interface. Search for a record with
one item attached to it (Biblio A)
7) Place a hold on this record for Patron B (any category).

not_always, reserved but not issued

8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of
Category A which the hold fee applies to)
9) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, reserved but not issued

10) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
11) Delete Patron A's hold on Biblio A
12) Place a hold on Biblio A for Patron A
13) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued but not reserved

14) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
15) Delete all holds on Biblio A
16) Check out Biblio A's item (Item A) to Patron B
17) Place a hold on Biblio A for Patron A
18) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, issued but not reserved

19) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
20) Delete Patron A's hold on Biblio A
21) Place a hold on Biblio A for Patron A
22) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued and reserved

23) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
24) Delete all holds on Biblio A
25) Place a hold on Biblio A for Patron C (any category).
26) Place a hold on Biblio A for Patron A
27) Check Patron A's accounting page. They SHOULD have a hold fee

issued_or_reserved, issued and reserved

28) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
29) Delete Patron A's hold on Biblio A. There should still be a hold for
Patron C.
30) Place a hold on Biblio A for Patron A
31) Check Patron A's accounting page. They SHOULD have a hold fee

32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32140] Sessions created using the OIDC/OAuth2 client use an "api" interface rather than "intranet" or "opac"

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32140

David Cook  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from David Cook  ---
It looks like bug 32178 will resolve this

*** This bug has been marked as a duplicate of bug 32178 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32135] Ability to batch cancel transfers

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32135

--- Comment #2 from Katrin Fischer  ---
We now also have transfers to send. Should this be added to both pages?

What's the reason/use case for needing the bulk cancel?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Katrin Fischer  changed:

   What|Removed |Added

Version|21.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32168

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32168] Editing date/datetime fields without the dateaccessioned.pl plugin can cause errors

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31212

--- Comment #1 from Katrin Fischer  ---
It looks like we already added dateaccessioned.pl to $w, so we could probably
also add it to datelastseen? 

Just wondering, if that could cause problems with bug 31212

  925 - tagfield: "952"
  926   tagsubfield: "w"
  927   liblibrarian: "Price effective from"
  928   libopac: "Price effective from"
  929   repeatable: 0
  930   mandatory: 0
  931   kohafield: items.replacementpricedate
  932   tab: 10
  933   authorised_value: ""
  934   authtypecode: ""
  935   value_builder: dateaccessioned.pl
  936   isurl: 0
  937   hidden: 0
  938   frameworkcode: ""
  939   seealso: ""
  940   link: ""
  941   defaultvalue:

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27973

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27973] Limit to currently available items should have an option to filter out notforloan statuses

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25375

--- Comment #7 from Katrin Fischer  ---
Which version have you been testing with?

I believe bug 25375 should have fixed this for 22.11 and 22.05

Although I still believe it's different for different type of libraries and
would love if the behavior could be customized. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32171] Order prices not populated when adding to a basket from a staged file

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Katrin Fischer  changed:

   What|Removed |Added

Summary|Order prices not populated  |Order prices not populated
   |when adding to a basket |when adding to a basket
   |form a staged file  |from a staged file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32174] bulkmarcimport.pl ignore items info when using -update

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32174

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #1 from Katrin Fischer  ---
Hi Pablo, there are scripts that mimick the staged import that are probably
better suited for this task: stage_file.pl and commit_file.pl

To my knowledge matching/updating items was not developed for bulkmarcimport.pl
yet, which would make this an enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #17 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #16)
> Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg

Filed separately as: Bug 32189 - When items are created on receive, item form
layout is broken

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31819] Formatting of item form in acq when ordering is broken

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32189

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||32189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32189
[Bug 32189] When items are created on receive, item form layout is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32189] New: When items are created on receive, item form layout is broken

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32189

Bug ID: 32189
   Summary: When items are created on receive, item form layout is
broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952

When items in acquisitions are created on order, the item form shows the same
issues we already fixed on the order form (see bug 31819).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #65 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #64)
> (In reply to Jonathan Druart from comment #57)
> > https://snipboard.io/0uEloj.jpg - shouldn't we hide if there is no template
> > defined?
> 
> Kyle, this is not strictly a blocker, but we really need you to fix it for
> the release. Separate bug please.

Filed it as: Bug 32188 - Only show template controls above item form if
templates have been defined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32188] Only show template controls above item form if templates have been defined

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||32188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188
[Bug 32188] Only show template controls above item form if templates have been
defined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32188] New: Only show template controls above item form if templates have been defined

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Bug ID: 32188
   Summary: Only show template controls above item form if
templates have been defined
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: k...@bywatersolutions.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
Depends on: 24606

The new item templates above the item edit form should only show, when at least
one template has been defined.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606
[Bug 24606] Allow storing item values as a template for creating new items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31853] The overdue tab states "no renewals left" when item is on hold

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31853

Katrin Fischer  changed:

   What|Removed |Added

Summary|The Overdue-tab states "no  |The overdue tab states "no
   |renewals left" when item is |renewals left" when item is
   |on hold |on hold
   Severity|minor   |normal
Version|22.05   |master

--- Comment #1 from Katrin Fischer  ---
Hi Hanna, I just checked this on master which will soon be 22.11:

- Checked out an item with a due date in the past 
- Verified it showed on the overdue tab in the OPAC (5 renewals left)
- Placed a hold on it
- OPAC message changed to: No renewals left

As you said, the checkouts tab is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32175] Item info not cloning when receiving multiple items due to Flatpickr issue

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

--- Comment #8 from Katrin Fischer  ---
This sounds a bit similar to bug 23202 we encountered after the switch to
flatpickr for 'items on ordering'. 

I also had no issues testing this on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32187] New: (Bug 24161 follow-up) With IndependentBranches on a non superlibrarian librarian is not able to track late orders

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187

Bug ID: 32187
   Summary: (Bug 24161 follow-up) With IndependentBranches on a
non superlibrarian librarian is not able to track late
orders
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P3
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: janus...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.druart+k...@gmail.com

With IndependentBranches a non superlibrarian librarian is not able to track
late orders. 

To reproduce: have an installation of Koha with IndependentBranches on.  Be a
librarian without superlibrarian rights.  Try to generate the report about late
orders (.../cgi-bin/koha/acqui/lateorders.pl).  You should get an error 500
page.  In log you should find something like:

... DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'branchcode' in 'where clause' at
/usr/share/koha/lib/Koha/Objects.pm line 417:
/usr/share/koha/intranet/cgi-bin/acqui/lateorders.pl, referer: ...

This is due to:

(
C4::Context->preference('IndependentBranches')
  && !C4::Context->IsSuperLibrarian
? ( 'borrower.branchcode' => C4::Context->userenv->{branch} )
: ()
),

from Koha/Acquisition/Orders::filter_by_lates  (line ~128)

Changing borrower.branchcode into borrowers.branchcode (borrowerS -- missing
's' at the end) does not correct the issue.

The borrower.branchcode was to substitue the C4::Acquisition::GetLateOrders
function, but something went wrong...

The problem was found in 21.11, but it seems that it is still present in the
master (as of November 12th, 2022).

Unfortunately, I'm not able to fix it at the moment.  Jonathan, would you be
able...?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

--- Comment #4 from Katrin Fischer  ---
Good catch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143391|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 143815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143815=edit
Bug 32127: Sort by description in Koha::Template::Plugin::Categories

Like in Koha::Template::Plugin::Branches, methods in
Koha::Template::Plugin::Categories must return categories sorted by
description.

Test plan :
1) Create a new patron category with code ZZZ and description AA
2) Go to patron search /cgi-bin/koha/members/members-home.pl
3) Look at filter by category :
=> Without patch the value AA is last
=> With patch the value AA is first
4) Click on 'New patron'
=> Without patch the value AA is last
=> With patch the value AA is first

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #24 from Katrin Fischer  ---
No string changes :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143777|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 143814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143814=edit
Bug 31447: Add unit tests

To test prove t/db_dependent/Circulation.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143776|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 143813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143813=edit
Bug 31447: Use holds pick up branch in "Please confirm checkout" message

When one tries to check out item which has hold in it,
"Please confirm checkout" message uses patrons home library
instead of holds pick up library. It would be more logical
to use latter here.

To test:
1. Find record with holds.
2. For first priority hold, change it's pick up library to differ from patrons
homebranch if needed.
3. Check out records item for a different patron.
=> Note that notice reads: "Item ... has been on hold for ... at [patrons
homebranch] since ...".
4. Apply this patch.
5. Repeat steps 2 and 3.
=> Notice should now read: "Item ... has been on hold for ... at [holds pick up
branch] since ...".

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Axelle Clarisse 

Signed-off-by: Katrin Fischer 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #21 from Katrin Fischer  ---
The Circulation tests are a quite picky. I often only get them to pass
completely after a fresh reset_all. But in this case, these unrelated tests
keep failing:

t/db_dependent/Circulation.t .. 62/64 
#   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
#   at t/db_dependent/Circulation.t line 5683.
#  got: '2022-11-13T14:26:32'
# expected: '2022-11-27T00:00:00'

#   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
#   at t/db_dependent/Circulation.t line 5689.
#  got: '2022-11-13T14:26:32'
# expected: '2022-11-27T23:59:00'
# Looks like you failed 2 tests of 5.
t/db_dependent/Circulation.t .. 63/64 
#   Failed test 'GetSoonestRenewDate tests'
#   at t/db_dependent/Circulation.t line 5694.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

--- Comment #10 from Katrin Fischer  ---
No string changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #9 from Katrin Fischer  ---
Created attachment 143812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143812=edit
Bug 20207: Don't show search options when no suggestions show

When you are not logged in and OPACViewOthersSuggestions is
deactivated, you don't see any suggestions.

When we see no suggestions, we should also not show the option
to serach in suggestions.

To test:
* as a logged in user and logged out, try various combinations of:
  * OPACViewOthersSuggestions
  * AnonSuggestions
* Verify display matches expectations (new button, shown suggestions,
  search input)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143798|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 143811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143811=edit
Bug 20207: Don't show anyones's suggestions when OPACViewOthersSuggestions is
deactivated

When you enable AnonSuggestions and ALLOW patrons that aren't logged
in to make purchase suggestions, once a suggestion has successfully
been submitted, anonymous purchase suggestions will show on OPAC even
when system preference OPACViewOthersSuggestions, is set to Don't show.

The suggestions will show on opac-suggestions.pl. However, if you search
for the title you suggested, you will get a message saying
"You are not authorized to see pending purchase suggestions."

This patch fixes the error, ie if OPACViewOthersSuggestions is set to
false not other suggestions are shown (if you are not logged in and
AnonSuggestions)
OR ONLY your own suggestions if you are logged in

To test:
1) activate AnonSuggestions
2) create an anon suggestion
3) create a suggestion with a logged in user
4) toggle OPACViewOthersSuggestions Show/Don't show
5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case
6) apply patch
7) OPACViewOthersSuggestions is now respected ie suggestions from other users
are only shown if activated
8) Please sign off

Sponsored-by: Library of the Natural History Museum Vienna

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24841] REST API should check if patron is restricted/debarred

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

--- Comment #9 from mathieu saby  ---
Hi
My library is planning to use the holds API to mimic the behavior of the OPAC,
and the current behavior is problematic.

What about a new parameter to define the "context" of the action
(?context=staff vs ?context=opac ) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #7 from Katrin Fischer  ---
2 things here (for the future):

* When fixing a bug, make sure it's marked as such (bugzilla defaults to
enhancement). This can influence how fast things are looked at, if they are
pushed to stable vesions etc.
* The bug title should describe the problem, the commit message/subject shoudl
describe the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even when OPACViewOthersSuggestions is set to 'Don't show'

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer  changed:

   What|Removed |Added

Summary|Anonymous Purchase  |Anonymous suggestions show
   |Suggestions show on OPAC|in OPAC even when
   |even when   |OPACViewOthersSuggestions
   |OPACViewOthersSuggestions   |is set to 'Don't show'
   |is set to Don't Show|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32185] Template error in opac-reserve.pl

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

--- Comment #2 from Katrin Fischer  ---
As this was found translating we can be sure it affects translations, changing
a string in the OPAC. Maybe we could do another update to the strings a few
days before release to catch such last minute fixed stuff?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32185] Template error in opac-reserve.pl

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

--- Comment #1 from Katrin Fischer  ---
Created attachment 143810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143810=edit
Bug 32185: Fix template typo in opac-reserve.pl

This removes the %] showing for not for loan items disappear.

To test:
* Create a record with multiple items, mark one 'not for loan'
* Place an item level request on this record in the OPAC
* Make sure you 'Show nonholdable items'
* Verify the %] shows in the column with the not for loan status
* Apply patch
* Verify display is now improved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32185] Template error in opac-reserve.pl

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32185] Template error in opac-reserve.pl

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Keywords||rel_22_11_candidate
   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31782] Patron autocomplete broken when using js/autocomplete/patrons.js

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143785|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 143809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143809=edit
Bug 31782: Remove js/autocomplete/patrons.js

On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons
route. A new patron_autocomplete JS function has been written
(js/patron-autocomplete.js) for that purpose.

However 3 occurrences were using an existing patron_autocomplete
function, and 30578 didn't take care of adjusting correctly the call to
the REST API route.

On this patchset I am suggesting to copy/paste the JS functions defined
in js/autocomplete/patrons.js, because we are very close of the 22.11
release. But ideally we should improve js/patron-autocomplete.js to add
a new 'on-select-add-to' option that will take care of add/remove/hide
behaviour. IMO that must be done on a separate bug, and after 22.11 is
released (to not need to retest the other occurrences of the patron
autocomplete)

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31782] Patron autocomplete broken when using js/autocomplete/patrons.js

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143784|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 143808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143808=edit
Bug 31782: Fix autocomplete when duplicating orders

Test plan:
Add a new order to a basket from an existing order
Search for the order to duplicate using the "Basket created by" field

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31782] Patron autocomplete broken when using js/autocomplete/patrons.js

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143783|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 143807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143807=edit
Bug 31782: Fix patron autocomplete on order search

Test plan:
Search for order using the "Basket created by" field

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31782] Patron autocomplete broken when using js/autocomplete/patrons.js

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143782|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 143806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143806=edit
Bug 31782: Fix patron autocomplete on patron list

Test plan:
Add new patrons to a patron list

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31782] Patron autocomplete broken when using js/autocomplete/patrons.js

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

--- Comment #11 from Katrin Fischer  ---
Really helpful enh bordering on a bug fix (scheduling something in the past
doesn't make sense) :)

Touches templates, but doesn't change strings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143203|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 143805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143805=edit
Bug 31261: Introduce flatpickr-futureinclusive

That let us use future + today, and it's working perfectly for our use
case :)

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #143201|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 143804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143804=edit
Bug 31261: Disable dates in the past for curbside pickups

When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.

Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.

QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/