[Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556

--- Comment #7 from Magnus Enger  ---
Thanks for your input, Galen! 

I found a way to make my quickfix work: 

- Dump the database
- Edit the dumped database and fix CREATE TABLE statements for
borrower_message_preferences.borrower_message_preference_id and
borrower_message_transport_preferences.borrower_message_preference_id to make
them BIGINT
- Drop the Koha database
- Create the Koha database
- Load the database-dump back in

The problem was that I was trying to run the dumped database against a
non-empty database. 

Next question then is: Should we change the schema and run Galen's solution as
part of an upgrade, or should we just document the quickfix for those that run
into the problem? And/or change how these message preferences are handled?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492

Wes  changed:

   What|Removed |Added

 CC||wsm...@marshallcolibrary.or
   ||g

--- Comment #3 from Wes  ---
I'm experiencing the same issue as Jason Robb. Works fine on moremember.pl but
csrf_token is empty in the html on any of the other patron tab/pages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503

Lucas Gass  changed:

   What|Removed |Added

 Attachment #144982|0   |1
is obsolete||

--- Comment #11 from Lucas Gass  ---
Created attachment 145053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145053=edit
Bug 32503: Use first cancellation for date ordering

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503

Lucas Gass  changed:

   What|Removed |Added

 Attachment #144981|0   |1
is obsolete||

--- Comment #10 from Lucas Gass  ---
Created attachment 145052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145052=edit
Bug 32503: (follow-up) Move data-order attributes

It looks like the data-order attributes were at the wrong level to me,
i.e. not part of the 'td' but instead part of the cell content.

This patch moves those data-order attributes where possible and drops
the data-type definitions on the headers.

However, for the cancellation case, this isn't as clear cut as we may
well display more than one cancellation request date in the same cell.
For this case I've left Katrins data-type="@data-order" trick.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503

Lucas Gass  changed:

   What|Removed |Added

 Attachment #144980|0   |1
is obsolete||

--- Comment #9 from Lucas Gass  ---
Created attachment 145051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145051=edit
Bug 32503: Fix date sorting for holds awaiting pickup tables

This patch is a little experimental, but seems to do the trick.

Signed-off-by: Martin Renvoize 

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570

--- Comment #1 from Lucas Gass  ---
Created attachment 145050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145050=edit
Bug 32570: Display patron.state correctly

To test:
1. Have a patron with both a city and state in their Main address.
2. Do a patron search that will return that patron among others.
3. Notice the patroncity will say something like Centerville, Centerville:
repeating the city but no state.
4. Apply patch
5. Try step 2 again, this time the city, state should display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570

Lucas Gass  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |
   |y.org   |
   Severity|enhancement |normal
   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32570] New: City is duplicated in patron search if the patron has both city and state

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570

Bug ID: 32570
   Summary: City is duplicated in patron search if the patron has
both city and state
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:

1. Have a patron with both a city and state in their Main address.
2. Do a patron search that will return that patron among others.
3. Notice the patroncity will say something like Centerville, Centerville:
repeating the city but no state.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

   Keywords|rel_22_11_candidate |rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Attachment #144596|0   |1
is obsolete||

--- Comment #38 from Lucas Gass  ---
Created attachment 145049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145049=edit
Bug 30624: Unit tests

Signed-off by: Bob Bennhoff/AspenCat Team

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Attachment #144595|0   |1
is obsolete||

--- Comment #37 from Lucas Gass  ---
Created attachment 145048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145048=edit
Bug 30624: Add loggedinlibrary permission and DB update

To test:
1. Apply patch, updatedatabase, restart_all
2. Have a user with superlibrarian privileges ( User1 )
3. Have a user who has staff access and circulate privileges but is not a super
librarian. ( User2 ) Make note of this users home library
4. Turn on the system preference 'CircSidebar'.

-MAIN log in ( auth.tt )
5. As User1, go to the main login screen and try logging in. You should be able
to log in AND you should be able to properly chnage your branch BEFORE logging
in.
6. As User2, to to the main login screnn amd try logging in. You should be able
to but if you try and switch your libraray to anything beside the user's home
branch it will not work. You will be logged in at your home branch.
7. For User2, set the new top level permission 'Allow staff to change logged in
library (loggedinlibrary).
8. Now you should be able to successfully switch libraries before log in.
9. Turn the 'loggedinlibrary' permission back off for User2.

-AFTER log in-
10. With User1, click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
11. With User2, click on your name/branch in the top right. If you have
'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see
nothing.
12. Repeat step 7.
13. NOw if you click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
14. Repeat Step 9.

-CircSideBar-
15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds
to pull, Holds awaiting pickup) with User1. You will see the 'Set library'
link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'.
16. Try with User2 and you will not see a 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set desk' link.
17. Repeat step 7.
18. For with User2 you go to any ciculation page (Holds queue, Holds to pull,
Holds awaiting pickup). You will see the 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set library and desk'.
19. Repeat step 9.

-Set library page-
20. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will
see a dropdown for 'Set library'. Make sure you can change your library
successfully.
21. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should
NOT see see a dropdown for 'Set library'.
22. Repeat step 7.
23. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you
should see a dropdown for 'Set library'.

Signed-off by: Bob Bennhoff/AspenCat Team

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32569] CloneSubfield() and CloneField() function can result in duplicate ID's when using the upload cataloging plugin

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32569

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32569] New: CloneSubfield() and CloneField() function can result in duplicate ID's when using the upload cataloging plugin

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32569

Bug ID: 32569
   Summary: CloneSubfield() and CloneField() function can result
in duplicate ID's when using the upload cataloging
plugin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

This problem was exposed when trying to clone 856 fields while using the
upload.pl cataloging plugin. 

To recreate:
1. Edit a framework so that the 856$u uses the upload.pl plugin.
2. Go to a record within that framework using the basic editor. 
3. Create and 856u, if you don't already have one. 
4. Now try and clone the entire field. Look at the ID on the upload button, it
beings with 'buttonDot_tag_856_subfield_u_'
5. Notice that the ID is the same as the one you cloned it from. Because of
this you cannot use the 2nd 'upload link'.
6. Save you changes and exit the basic editor.
7. Go back into the editor and the new fields now have a different ID and the
upload links work correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32538] Biblionumber problem

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32538

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #4 from Owen Leonard  ---
Koha mailing list https://koha-community.org/support/koha-mailing-lists

#koha IRC channel https://koha-community.org/get-involved/irc/

Koha documentation: https://koha-community.org/documentation/

Options for paid support: https://koha-community.org/support/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

--- Comment #9 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #8)
> (In reply to Katrin Fischer from comment #6)
>  
> > Has this worked before? 
> 
> Patron searching works correctly in 22.05 with the comma included, so this
> is a regression.

Thx for confirming, I already marked it as such and added Joubu in CC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

--- Comment #8 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #6)

> Has this worked before? 

Patron searching works correctly in 22.05 with the comma included, so this is a
regression.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
   Severity|enhancement |normal
  Component|Staff interface |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #142843|0   |1
is obsolete||

--- Comment #74 from ByWater Sandboxes  ---
Created attachment 145047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145047=edit
Bug 16522: (follow-up) If no 773$w, try to return host record

Use host biblionumber or host itemnumber to return a host record if
EasyAnalyticalRecords is enabled, or return an undef record and a string
of host information when get_marc_host is called in list context.

Confirm tests pass:
- t/db_dependent/Koha/Biblio/host_record.t

Signed-off-by: Heather Hernandez 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Heather  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

--- Comment #73 from Heather  ---
Thank you SO much for all of this, Katrin!  I'm going to go ahead and sign off
because everything you say makes a lot of sense.

Also, I followed the adapted test plan here:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522#c39

I imported an analytic record and its parent/host record; the child was linked
to the parent (with the generated search using the record number in the $w of
the child record to the 001 of the parent record).  I deleted the $w from the
773 and the child remained linked to the parent because Koha then used the data
in the 773 $t of the child record which retrieved the data in the 245 $a of the
parent record.  It does this even with the syspref "UseControlNumber" set to
"Use" and "EasyAnalyticalRecords" set to "Don't Show."

Maybe it shouldn't do this, but I like it--I like the fact that there is a
fallback behavior when there is no Control Number (i.e. no $w) to use for
searching.

(And I will keep arguing that the "In:..." in the OPAC should be moved down to
be consistent with other displays, but more folks in the community like it up
near the title and author(s), then I'll probably start arguing to move it up
there in the staff client!)

I think this is a GREAT development, not at all minor, and will be of service
to many libraries in getting to their users articles, chapters, papers,
songs...all those great things that analytic records are used for.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq)

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564

--- Comment #1 from Owen Leonard  ---
Created attachment 145046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145046=edit
Bug 32654: Update ILL template markup to conform to Bootstrap panels

The ILL request detail template uses Bootstrap panel markup that
isn't quite correct. This patch changes the markup around the
details and comments panels so that they look correct.

To test you must have ILL enabled and have at least one request
to view.

- Apply the patch and go to ILL requests -> Manage request
- The page should display with the "Request details" panel
  expanded by default.
- Expanding and collapsing the "Request details" and "Comments"
  panels should work correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq)

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #145040|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 145045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145045=edit
Bug 32400: Add page-section to aqbudgetperiods table

To test:
1. Apply patch
2. Go to Administration -> Budgets
3. Close a budget
4. Make sure the page-section looks right.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #145038|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 145044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145044=edit
Bug 32568: Add page-section to checkedin table

To test:
1. Apply patch
2. Checkin some items that are checked out/
3. Make sure the page-section looks right.

Note: There are some indentation changes.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558

--- Comment #13 from Kyle M Hall  ---
Created attachment 145043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145043=edit
Bug 32558: (follow-up) Allow configuration of max processes via env or koha
conf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

Katrin Fischer  changed:

   What|Removed |Added

Summary|Can no longer search|Can no longer search
   |patrons in format   |patrons in format 'surname,
   ||firstname'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32491] Can no longer search patrons in format

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

Katrin Fischer  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
Summary|Special characters causes   |Can no longer search
   |patron search to fail   |patrons in format
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32491] Special characters causes patron search to fail

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

--- Comment #7 from PPLCS  ---
Entering in "Doe, John" in the patron search field worked before the last Koha
update. As a librarian I'm hardwired to type in last name first, comma, first
name. So this is a real problem when looking up patrons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

--- Comment #12 from David Nind  ---
(In reply to Thibaud Guillot from comment #9)

> Now it will be better I think ;) Thanks for your feedback again

Thanks Thibaud! Now signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

David Nind  changed:

   What|Removed |Added

 Attachment #144979|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 145042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145042=edit
Bug 31550: (follow-up) fix bareword issue

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

David Nind  changed:

   What|Removed |Added

 Attachment #140432|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 145041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145041=edit
Bug 31550: Add fields to get opac description on ILSDI web service

Test plan

1) Active your ILS-DI syspref
2) Have some authorised values linked to one or more concern
fields
3) Choose an item and go to
'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords='
4) The XML file contains item fields with some of them the code associated to
the authorized values.
5) Apply this patch
6) Repeat step 3 and see the new fields with specific "_description"
suffix added and contains opac description from authorized values

https://bugs.koha-community.org/show_bug.cgi?id=31550

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

Katrin Fischer  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31935] Serials subscription form is misaligned

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the alignment of
  release notes||the serials subscription
   ||form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523

David Nind  changed:

   What|Removed |Added

Version|22.11   |master
   Assignee|koha-b...@lists.koha-commun |bibliot...@th-wildau.de
   |ity.org |

--- Comment #17 from David Nind  ---
I've changed the assignee to yourself, as well as changing the version to
master (needs back porting to 22.11).

Good luck with the QA!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq)

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq)

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400

--- Comment #1 from Lucas Gass  ---
Created attachment 145040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145040=edit
Bug 32400: Add page-section to aqbudgetperiods table

To test:
1. Apply patch
2. Go to Administration -> Budgets
3. Close a budget
4. Make sure the page-section looks right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq)

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523

--- Comment #16 from David Nind  ---
(In reply to Jan Kissig from comment #14)
> I am sorry for spamming that bug page. 
> 
> @David you were right, the subject was in case the problem. 
> I created the commit message inside visual studio and it seems like this
> caused the strange formatted subject, which then caused git bz -e to fail.
> 
> I marked the first attachment as obsolete and was able to submit again, but
> now with correct subject line.

No problem Jan!

Glad you were able to figure out how to fix it.

Now signed off.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523

David Nind  changed:

   What|Removed |Added

 Attachment #145013|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 145039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145039=edit
Bug 32523: Links to missing fields in MARC editor error

This bug appears after switching to the new staff interface design (from 22.05
to 22.11).
When adding/editing a biblio in staff interface leaving out mandatory fields
and click on save, you get an error dialog with shortcuts/links to these
missing fields. Clicking on these links should change section tabs and focus
the field.
This patch fixes that error.

Test plan:
1) in staff interface go to
/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=
2) click Save
3) Error dialog appears, informing about missing input in mandatory fields.
4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible.
5) In the error dialog click on a "Go to field" which points f.e. to section 9
6) The selected / active tab will switch to section 9 and will not focus on the
selected field
7) apply patch
8) repeat step 1) to 6)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

--- Comment #3 from Emily Lamancusa  ---
(In reply to Katrin Fischer from comment #2)
> Could the script be modified to only check for missing holds that haven't
> been allocated yet? Otherwise it will delete the whole table, mess with all
> the timestamps etc which would be a real set back now that we have RT.

I second this - in addition to the reasons Katrin mentioned, we've found (at
least in testing) that the real-time holds queue also distributes the holds
more equitably among our libraries than the cron job, so we'd like to preserve
that!
Running a modified holds queue cron would also be more in keeping with the
goals of Bug 31995.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

--- Comment #72 from Katrin Fischer  ---


> These are minor quibbles, but I think it would be best for them to be fixed
> before going into master:
> --Move the "In:..." in the OPAC near the "Online access..." and/or
> "Availability:..." so users are more likely to notice it.

This could be done, although I the current placement also makes sense to me.
Having the article and journal information close together. But moving it would
be more consistent with other pages, I understand that argument.

> --Don't use an invalid 773 subfield 0 (zero) with a biblionumber in the 773,
> but actually use the valid $w field to contain the biblionumber
> --Don't retain/have an invalid itemnumber in the 773 field, since it's
> unnecessary and nonsense for this type of relationship, and really use the
> 773$w.

This is out of scope here. I'll explain:

These subfields are added because you used EasyAnalytics:
_0163
_9354

When you remove to $w there is a fallback to the biblionumber in these
subfields. But we didn't add that - it's always been in the XSLTs. We would
break things for people using EasyAnalytics changing this behaviour. But I
think we can assume that libraries using $w won't have EasyAnalytics turned on,
they are known to be incompatible.

Try cataloguing things manually with UseControlNumber activated and
EasyAnalytics turned off, all should work as you expect it then with $w used.
Make sure your host has a 001. Then from the detail page use New > New child
record and it should create a nice standard 773 for you.

I wrote an adapted test plan that should cover that if you ignore the first
paragraph:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522#c39

> If these quibbles are too minor, no problem--of course, I rely on y'all's
> expertise for such decisions!  It's a great development!!
> --h2

Thanks for testing this - very happy to see it get attention!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

--- Comment #2 from Katrin Fischer  ---
Could the script be modified to only check for missing holds that haven't been
allocated yet? Otherwise it will delete the whole table, mess with all the
timestamps etc which would be a real set back now that we have RT.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567

Katrin Fischer  changed:

   What|Removed |Added

Summary|Update plugin   |Update plugin
   |unimarc_field_110.pl|unimarc_field_110.pl
   |'Script of title' and   |'Script of title' and
   |'Translitteration code' |'Transliteration code'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32491] Special characters causes patron search to fail

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491

--- Comment #6 from Katrin Fischer  ---
(In reply to PPLCS from comment #5)
> We desperately need this fixed!

Can you explain the problem a bit more as it manifests for you?

Has this worked before? I am not aware of it, but not totally user as we had
some changes to patron search recently. 

As I said the problem with comma is that it's not part of the data, it's not
failing because of being a special character. If the comma was in your data,
you should be able to search for it without issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

Lucas Gass  changed:

   What|Removed |Added

  Text to go in the||This patch adds the
  release notes||page-section class to the
   ||checkedin table on the
   ||returns page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

--- Comment #1 from Lucas Gass  ---
Created attachment 145038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145038=edit
Bug 32568: Add page-section to checkedin table

To test:
1. Apply patch
2. Checkin some items that are checked out/
3. Make sure the page-section looks right.

Note: There are some indentation changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] Add page section to list of checkins

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

David Gustafsson  changed:

   What|Removed |Added

 Attachment #145036|0   |1
is obsolete||

--- Comment #17 from David Gustafsson  ---
Created attachment 145037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145037=edit
Bug 32476: Add caching for relatively expensive patron methods

To test:
1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144771|0   |1
is obsolete||

--- Comment #16 from David Gustafsson  ---
Created attachment 145036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145036=edit
Bug 32476: Add caching for relatively expensive patron methods

To test:
1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

--- Comment #15 from David Gustafsson  ---
Sure, personally I don't see major issues using closures if resulting in less
boiler plate and thus less error prone code. But using your suggestion  allows
for flexibility with regards to flushing cache on uncached calls, so I guess
that could be a good thing. A downside is that it would lead to more convoluted
code if wishing to cache methods with arguments. But perhaps in those cases
caching should be handled manually anyways. I slightly modified your suggesting
calling different methods instead of relying on arguments to dispatch to
different behaviors (clearing/retrieving cache), but should otherwise be
equivalent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
I think the solution to this one may be server configuration - there is a need
to run the holds queue cron daily/nightly to check for holds that may not have
had an open library when placed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481

--- Comment #19 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #18)
> I think I recreate the problem this way:
> 
> % more /etc/rabbitmq/rabbitmq.conf
> consumer_timeout = 15000
> 
> Add a sleep 10 in Koha::BackgroundJob::BatchUpdateItem->process
> 
> Then enqueue several batch item mod jobs.
> 
> However:
> 1. I don't see jobs stuck in "new" (without the patch)
> 
> 2. I am seeing the following in the rabbitmq logs, with and without the patch
> 
> 2023-01-04 11:01:03.041 [warning] <0.2774.0> Consumer
> Q_/queue/koha_kohadev-long_tasks on channel 1 has timed out waiting on
> consumer acknowledgement. Timeout used: 15000 ms
> 
> 2023-01-04 11:01:03.041 [error] <0.2774.0> Channel error on connection
> <0.2764.0> (127.0.0.1:39578 -> 127.0.0.1:61613, vhost: '/', user: 'guest'),
> channel 1:
> operation none caused a channel exception precondition_failed: consumer ack
> timed out on channel 1  
> 
> 2023-01-04 11:01:03.042 [error] <0.2758.0> STOMP error frame sent:  
> 
> Message: precondition_failed
> Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n"
> Server private detail: none
> 2023-01-04 11:01:03.042 [info] <0.2758.0> closing STOMP connection
> <0.2758.0> (127.0.0.1:39578 -> 127.0.0.1:61613)

I played with this a bunch, and things seem to sometimes recover and sometimes
not

Setting rabbitmq.conf with:
consumer_timeout = 1

Adding "sleep 1;" in the Koha/BackgroundJob/UpdateElasticIndex.pm

sudo koha-mysql kohadev
DELETE FROM biblio WHERE biblionumber=269;
DELETE FROM biblio WHERE biblionumber=72;

Set SearchEngine syspref to 'Elastic'

perl misc/maintenance/touch_all_biblios.pl

With or without patch, I get errors like:
2023-01-04 16:49:40.689 [warning] <0.7712.0> Consumer
Q_/queue/koha_kohadev-default on channel 1 has timed out waiting on consumer
acknowledgement. Timeout used: 1 ms
2023-01-04 16:49:40.692 [error] <0.7712.0> Channel error on connection
<0.7703.0> (127.0.0.1:60178 -> 127.0.0.1:61613, vhost: '/', user: 'guest'),
channel 1:
operation none caused a channel exception precondition_failed: consumer ack
timed out on channel 1
2023-01-04 16:49:40.692 [error] <0.7700.0> STOMP error frame sent:
Message: precondition_failed
Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n"
Server private detail: none
2023-01-04 16:49:40.693 [info] <0.7700.0> closing STOMP connection <0.7700.0>
(127.0.0.1:60178 -> 127.0.0.1:61613)
2023-01-04 16:49:41.224 [info] <0.14720.0> accepting STOMP connection
<0.14720.0> (127.0.0.1:60376 -> 127.0.0.1:61613)
2023-01-04 16:49:41.235 [error] <0.14732.0> Channel error on connection
<0.14723.0> (127.0.0.1:60376 -> 127.0.0.1:61613, vhost: '/', user: 'guest'),
channel 1:
operation basic.ack caused a channel exception precondition_failed: unknown
delivery tag 245
2023-01-04 16:49:41.239 [error] <0.14720.0> STOMP error frame sent:
Message: precondition_failed
Detail: "PRECONDITION_FAILED - unknown delivery tag 245\n"
Server private detail: none
2023-01-04 16:49:41.239 [info] <0.14720.0> closing STOMP connection <0.14720.0>
(127.0.0.1:60376 -> 127.0.0.1:61613)
2023-01-04 16:49:42.477 [info] <0.14736.0> accepting STOMP connection
<0.14736.0> (127.0.0.1:60388 -> 127.0.0.1:61613)


And varied number of jobs that remain in new

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

--- Comment #71 from Heather  ---
Hi, Katrin--

I went through the test plan again:

--I still think that the "In:..." link should be moved in the OPAC, down to the
"Online access..." and "Availability..." area, as it is in the staff client.

--I did this step:
"15. Delete the 773$w and confirm host item info still shows correctly
but no longer links to biblio"
And the host item info does still show correctly, but the record does still
link to the host biblio.  It can be seen in my sandbox here:
https://staff-bug16522.sandbox.bywatersolutions.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=16=

Could this be because there is a subfield 0 (zero) in the 773 field ("Host
biblionumber") which is not actually a valid MARC21 subfield?
(c.f. https://www.loc.gov/marc/bibliographic/bd773.html)

--Also, there is a subfield 9 in the 773 to "Host itemnumber," which is
nonsense (according to this cataloger)--analytic relationships should only
exist at the title level/biblionumber level.  If you have variation in contents
at the item level, the items should not be on the same biblio (says the
cataloger).

These are minor quibbles, but I think it would be best for them to be fixed
before going into master:
--Move the "In:..." in the OPAC near the "Online access..." and/or
"Availability:..." so users are more likely to notice it.
--Don't use an invalid 773 subfield 0 (zero) with a biblionumber in the 773,
but actually use the valid $w field to contain the biblionumber
--Don't retain/have an invalid itemnumber in the 773 field, since it's
unnecessary and nonsense for this type of relationship, and really use the
773$w.

If these quibbles are too minor, no problem--of course, I rely on y'all's
expertise for such decisions!  It's a great development!!
--h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

--- Comment #14 from David Gustafsson  ---
Ok, there are other lines exceeding that line number in that file, but should
in that case I would have formatted it as

C4::Circulation::ReturnLostItem(   
$self->borrowernumber,
$debit->itemnumber
);

Also realize there are formatting/style related changes left. Took the
opportunity to fix a few of the most egregious ones while going the code as
would never get around to beak out into separate issues. I know it's not best
practice, but figured would not be to much of an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417
Bug 31417 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32062] Add import tool to Authorities

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062
Bug 32062 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31992] t::lib::Mocks::Zebra still using old stage for import page

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992
Bug 31992 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31844] Clarify cataloging permissions

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31844
Bug 31844 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31478] Standardize upload/download icons

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478
Bug 31478 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31477] Switch icon for inventory

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477
Bug 31477 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31476] Add tool tips to the buttons on the circulation start page

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476
Bug 31476 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5523] Display list of items which are to be cataloged in the cataloguing home page

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523
Bug 5523 depends on bug 31162, which changed state.

Bug 31162 Summary: Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Resolution|--- |FIXED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/600
  Documentation||Caroline Cyr La Rose
contact||

--- Comment #111 from Caroline Cyr La Rose  
---
Manual has been updated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

--- Comment #70 from Heather  ---
Hi, Victor!  This is great--very helpful for a newbie!  Thank you!!  --h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

--- Comment #13 from Jonathan Druart  ---
(In reply to David Gustafsson from comment #12)
> Fixing the  formatting of
> C4::Circulation::ReturnLostItem( $self->borrowernumber,
> $debit->itemnumber );
> feels like such a minor change that would hardly merit it's own bug report,
> also noticed the if above is also incorrectly formatted. I can revert this
> change though.

Actually it does not need to be fixed, it's the expected format. The line is
longer than x (I guess 80 is the default) chars and so perltidy is splitting it
into 2 lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #145030|0   |1
is obsolete||

--- Comment #58 from David Gustafsson  ---
Created attachment 145035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145035=edit
Bug 31735: Fix array that should be passed as reference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #145029|0   |1
is obsolete||

--- Comment #57 from David Gustafsson  ---
Created attachment 145034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145034=edit
Bug 31735: Optimize OPAC checkouts view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #145032|0   |1
is obsolete||

--- Comment #56 from David Gustafsson  ---
Created attachment 145033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145033=edit
Bug 31735: Avoid re-fetcing objects from database by passing them directly
instead of ids to various subroutines

To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Circulation/transferbook.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #145028|0   |1
is obsolete||

--- Comment #55 from David Gustafsson  ---
Created attachment 145032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145032=edit
Bug 31735: Avoid re-fetcing objects from database by passing them directly
instead of ids to various subroutines

To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Circulation/transferbook.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||32568


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568
[Bug 32568] Add page section to list of checkins
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32568] New: Add page section to list of checkins

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568

Bug ID: 32568
   Summary: Add page section to list of checkins
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952

When you check in one or more items, the list of checkins is missing the
page-section class that woudl give it a white background.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

--- Comment #12 from David Gustafsson  ---
Ok, thanks for spotting that. The changes pertaining to CheckReserves have not
been moved to bug 31735. In Koha/Hold.pm now using the fully qualified sub name
for CheckResvere, there is a use line for C4::Reserves that can probably be
removed but keeping it not to cause further issue. For some reason imported
subroutines seems not to work inside of object methods so you are probably
right it would have crashed. Fixing the  formatting of
C4::Circulation::ReturnLostItem( $self->borrowernumber,
$debit->itemnumber );
feels like such a minor change that would hardly merit it's own bug report,
also noticed the if above is also incorrectly formatted. I can revert this
change though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567

Thibaud Guillot  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567

--- Comment #2 from Thibaud Guillot  ---
I hope there is no translation error, if someone tells me I will correct it. I
took the opportunity to reorder the different fields in alphabetical order, it
is easier to find your way

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567

--- Comment #1 from Thibaud Guillot  ---
Created attachment 145031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145031=edit
Bug 32567: Update unimarc_field_110.pl with some values

'Script of title' values =>
e - b/c/d/e/f/g/h
i - d/e
j - f/g
l - f
n - b/c
o - a
p - a

'Translitteral code' values =>
'g' and 'h'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567

Thibaud Guillot  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144803|0   |1
is obsolete||

--- Comment #54 from David Gustafsson  ---
Created attachment 145030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145030=edit
Bug 31735: Fix array that should be passed as reference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144802|0   |1
is obsolete||

--- Comment #53 from David Gustafsson  ---
Created attachment 145029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145029=edit
Bug 31735: Optimize OPAC checkouts view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson  changed:

   What|Removed |Added

 Attachment #144801|0   |1
is obsolete||

--- Comment #52 from David Gustafsson  ---
Created attachment 145028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145028=edit
Bug 31735: Avoid re-fetcing objects from database by passing them directly
instead of ids to various subroutines

To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Circulation/transferbook.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

David Gustafsson  changed:

   What|Removed |Added

 Attachment #145024|0   |1
is obsolete||

--- Comment #11 from David Gustafsson  ---
Created attachment 145027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145027=edit
Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm

Refactor the most performance critical subroutines in Circulation.pm
to take objects instead of unblessed ones to reduce unnecessary
unblessings and generally clean up the code.

To test:

1) Ensure the following tests all pass:
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Illrequests.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/Reserves.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Plugins/Recall_hooks.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Circulation/_CalculateAndUpdateFine.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567

Thibaud Guillot  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32567] New: Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code'

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567

Bug ID: 32567
   Summary: Update plugin unimarc_field_110.pl 'Script of title'
and 'Translitteration code'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: thibaud.guil...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Update value builder for unimarc_field_110 with some values

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31935] Serials subscription form is misaligned

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935

--- Comment #9 from Jonathan Druart  ---
Created attachment 145026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145026=edit
Bug 31935: (follow-up) Make form look better

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31935] Serials subscription form is misaligned

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #144521|0   |1
is obsolete||
 Attachment #144522|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  ---
Created attachment 145025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145025=edit
Bug 31935: Fix misaligned form when adding serial subscription

This patch attempts to fix the misaligned form on subscription-add.tt by
removing some of the wrapping  tags and adding labels where appropriate.

To test:
1. Add a serial subscription and notice the misaligned form on step 1.
2. Apply patch
3. Look again and confirm that the form looks better.
4. Read through everything and make sure the form still makes sense.
5. Make sure the form still works properly.

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31935] Serials subscription form is misaligned

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556

--- Comment #6 from Galen Charlton  ---
As a side note, I ran across this query that identifies cases where an
auto_increment column is at risk of hitting its maximum value:

SELECT
  c.TABLE_CATALOG,
  c.TABLE_SCHEMA,
  c.TABLE_NAME,
  c.COLUMN_NAME
FROM information_schema.COLUMNS AS c
JOIN information_schema.TABLES AS t USING (TABLE_CATALOG, TABLE_SCHEMA,
TABLE_NAME)
WHERE c.EXTRA LIKE '%auto_increment%'
  AND t.AUTO_INCREMENT / CASE c.DATA_TYPE
  WHEN 'TINYINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 255, 127)
  WHEN 'SMALLINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 65535, 32767)
  WHEN 'MEDIUMINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 16777215,
8388607)
  WHEN 'INT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 4294967295,
2147483647)
  WHEN 'BIGINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED',
'18446744073709551615', 9223372036854775807) # need to quote because column
type defaults to unsigned.
  ELSE 0
END > .9; # 10% buffer

Source: https://stackoverflow.com/a/45171880

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556

--- Comment #5 from Galen Charlton  ---
By the way, I wonder if the error 150 you're seeing isn't about
borrower_message_preference_id but rather one of the three foreign key
contraints on borrower_message_preferences (i.e., borrowernumber,
message_attribute_id, or categorycode).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32495] Required fields in API and UI form don't match

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32495

--- Comment #2 from Jonathan Field  ---
I would say that the Description could definitely be an optional field (in UI
and therefore API).
In fact, is_perpetual could also be deemed not required. It is in the UI right
now as it's a Yes/No option.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32566] New: Show show 'ILL request logs' button, when IllLog is turned off

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32566

Bug ID: 32566
   Summary: Show show 'ILL request logs' button, when IllLog is
turned off
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de

When the IllLog system preference is turned off, the 'ILL request log' will
always be empty. We should not show the button when the system preference is
turned off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556

--- Comment #4 from Galen Charlton  ---
Whoops, syntax error. I meant:

ALTER TABLE borrower_message_transport_preferences 
  DROP FOREIGN KEY borrower_message_transport_preferences_ibfk_1;
ALTER TABLE borrower_message_preferences
  MODIFY borrower_message_preference_id bigint(11) UNSIGNED  NOT NULL
AUTO_INCREMENT;
ALTER TABLE borrower_message_transport_preferences
  MODIFY borrower_message_preference_id bigint(11) UNSIGNED  NOT NULL DEFAULT
0;
ALTER TABLE borrower_message_transport_preferences
  ADD CONSTRAINT borrower_message_transport_preferences_ibfk_1 
FOREIGN KEY (`borrower_message_preference_id`) 
REFERENCES `borrower_message_preferences`
(`borrower_message_preference_id`)
ON DELETE CASCADE ON UPDATE CASCADE;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit

2023-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556

--- Comment #3 from Galen Charlton  ---
This could do it in-place:

ALTER TABLE borrower_message_transport_preferences 
  DROP FOREIGN KEY borrower_message_transport_preferences_ibfk_1;
ALTER TABLE borrower_message_preferences0
  MODIFY borrower_message_preference_id bigint(11) UNSIGNED  NOT NULL
AUTO_INCREMENT;
ALTER TABLE borrower_message_transport_preferences
  MODIFY borrower_message_preference_id bigint(11) UNSIGNED  NOT NULL DEFAULT
0;
ALTER TABLE borrower_message_transport_preferences
  ADD CONSTRAINT borrower_message_transport_preferences_ibfk_1 
FOREIGN KEY (`borrower_message_preference_id`) 
REFERENCES `borrower_message_preferences`
(`borrower_message_preference_id`)
ON DELETE CASCADE ON UPDATE CASCADE;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >